[00:40] <vino_> wallyworld : Build is over for #8644 and it is still the go fmt issue..
[00:40] <wallyworld> vino_: weird, ok. the PR doesn't touch that file right?
[00:42] <vino_> it does. thats why i am worried
[00:43] <wallyworld> vino_: did you run go fmt before committing?
[00:43] <wallyworld> or use the pre-commit check?
[00:45] <veebers> wallyworld, vino_ just pulled the branch locally gofmt complains on it. I would suggest enabling the pre-commit hook :-)
[00:46] <wallyworld> veebers: thank you. i didn't realise till just now that that particular file was part of the pull request
[00:46] <wallyworld> was conversing in another channel
[00:47] <veebers> wallyworld: no worries. I had a vested interest to make sure my job changes hadn't borked things ;-)
[00:48] <vino_> i still have issues with pre-hook check. so i do manuall run go fmt.
[00:48] <vino_> i missed these folders i guess.
[00:48] <vino_> but its going on now.
[00:52] <vino_> the other PR inherits the same issue..
[00:52] <vino_> so fixed both and the CI is running now.
[00:55] <wallyworld> vino_: go fmt ./...   from the top level juju dir is safest
[00:55] <wallyworld> but we need to sort out the pre-commit hook also
[00:55] <vino_> agree..
[01:08] <vino_> wallyworld : PR#8644 is happy
[01:09] <wallyworld> vino_: just finishing review, been multitasking
[01:11] <vino_> no worries.
[01:13] <wallyworld> vino_: first one reviewed, take a look, happy to chat, but need to grab coffee first (still haven't been able to get away from keyboard to grab one and i'm getting desperate)
[01:23] <vino_> sure wallywolrd. ping me once u r back
[01:36] <wallyworld> vino_: did you want to talk about first PR?
[01:36] <wallyworld> or you happy to make suggested changes?
[01:39] <vino_> hm.. i want to talk abt the moving the agentinfo to agent.
[01:40] <vino_> can we have a quick talk.
[01:40] <vino_> other chnages are fine for me.
[01:40] <vino_> they are very minor ones(comments)
[01:42] <vino_> wallyworld : i am in hangout..
[01:42] <anastasiamac> anyone keen to review 2 tiny PRs? 8647 and 8648...
[01:42] <anastasiamac> babbageclunk: veebers: ^^
[01:43] <veebers> I'll take 8648
[01:43] <wallyworld> vino_: coming
[01:43] <anastasiamac> veebers: haha :D since u did, it'd b awesome to have a ci test around storage pools... :D
[01:43] <anastasiamac> veebers: but I'll take ur eyes on PR for now ;D
[01:44] <veebers> anastasiamac: I'm always happy to help people add new and extend our CI tests ;-)
[01:44] <anastasiamac> veebers: haha
[01:47] <veebers> anastasiamac: reviewed, have asked a question but otherwise lgtm
[01:50] <anastasiamac> veebers: it is tested for this layer :) so if u happy could u tick the tick so that i can land it?
[01:51] <veebers> anastasiamac: I can , for money
[01:51] <veebers> anastasiamac: hah :-) yep all good have approved now
[01:52] <anastasiamac> veebers: \o/ money? i cannot money... ;( but i can drinks... how about a drink at next sprint?
[01:52] <veebers> anastasiamac: deal
[01:53] <anastasiamac> veebers: awesome. now it's set in stone (too many witnesses) ;D
[01:53] <veebers> ^_^
[02:16] <wallyworld> kelvinliu: i left a comment or two on your PR
[02:16] <kelvinliu> wallyworld, looking now, thx
[02:17] <babbageclunk> anastasiamac: sorry to blank you! I didn't get a pop up notification for some reason! Any still needing review?
[02:18] <babbageclunk> anastasiamac: looking at 8647
[02:26] <babbageclunk> anastasiamac: approved with v. minor comment
[04:40] <babbageclunk> names
[04:40] <babbageclunk> doh
[05:08] <anastasiamac> babbageclunk: :-P
=== _thumper_ is now known as thumper
[11:27] <balloons> Good morning all
[11:35] <frankban> stickupkid: hey
[11:49] <stickupkid> hey: frankban :D
[12:04] <frankban> stickupkid: so I've seen that you tried to use jujushell in production (jujucharms.com) and you got an error. I updated the service, could you please try again?
[12:16] <rogpeppe> anyone from juju side around and able to give this small juju/cmd PR a lookover? https://github.com/juju/cmd/pull/54
[12:26] <balloons> rogpeppe, what's the drive for this?
[12:26] <rogpeppe> balloons: i want to be able to have flags that are common to all subcommands (like the logging flags are)
[12:26] <rogpeppe> balloons: so when i type "mycommand help" i'll get to see those flags
[12:27] <balloons> rogpeppe, but you don't have a specific global flag you have in mind?
[12:27] <rogpeppe> balloons: yeah, i do: --candid-url and --agent
[12:27] <rogpeppe> balloons: (i'm going to use this in the candid command initially
[12:27] <rogpeppe> )
[12:29] <balloons> rogpeppe, ty. ohh right, candid. I know that name!
[12:31] <rogpeppe> balloons: wanna give me a review then? :)
[12:32] <balloons> rogpeppe, on it
[12:32] <rogpeppe> balloons: ta!
[13:14] <rogpeppe> balloons: i responded to your questions on the PR. they were both drive-by fixes tbh. I could do them as part of a separate PR if you'd prefer.
[13:15] <balloons> rogpeppe, no, that's fine. approval is the same
[13:15] <rogpeppe> balloons: ta
[13:18] <balloons> rogpeppe, looks like we need to add a bot for juju/cmd though to merge
[13:19] <rogpeppe> balloons: there definitely *was* a bot at some point...
[13:19] <rogpeppe> balloons: i've tried a $$merge$$ and we'll see
[13:19] <rogpeppe> balloons: i can always push the green button...
[13:19] <balloons> rogpeppe, yea, we have new infastructure now. It's trivial to add a bot, just need to get off the phone
[13:20] <rogpeppe> balloons: ok, cool, thanks
[15:02] <rogpeppe> balloons: did you manage to enable a bot on juju/cmd, by any chance?
[15:26] <balloons> rogpeppe, haven't gotten a moment yet :-)
[15:26] <balloons> I saw you landed it, that's fine
[15:33] <rogpeppe> balloons: np, thought that might take the pressure off :)
[15:46] <admcleod_> anyone around who can help me with 'juju metadata generate-image' ?
[15:46] <admcleod_> not sure if im doing it wrong or have abug
[15:50] <balloons> admcleod_, that's kind of tricky to get right
[15:51] <admcleod_> balloons: yeah - actually i think i have it
[15:51] <admcleod_> balloons: the error i was getting was: well
[15:51] <admcleod_> https://paste.ubuntu.com/p/6tgrNGqST5/
[15:52] <admcleod_> balloons: but it looks like specifying the arch as the bootstrap constrain sorts it out - just that error is a bit confusing
[15:52] <admcleod_> balloons: line 72
[16:05] <admcleod_> balloons: cos image type and flavour are not really related other than the size of the image
[16:08] <balloons> admcleod_, ahh.. yea, cross arch can be confusing. Best to specify arch in those cases
=== akhavr1 is now known as akhavr