[01:38] <wallyworld> kelvinliu: got a minute to talk?
[01:39] <babbageclunk> names
[01:39] <babbageclunk> doh
[01:47] <wallyworld> veebers: got a minute?
[01:48] <kelvinliu> wallyworld, sorry, just saw ur message. yeah, i am free now
[01:48] <veebers> wallyworld: I'm just about to pop out for a childcare meeting :0\
[01:48] <wallyworld> kelvinliu: ok
[01:48] <wallyworld> veebers: no worries, just ping when you're back
[01:48] <veebers> wallyworld: can we chat after?
[01:48] <veebers> mean, will so
[01:48] <veebers> do
[02:09] <wallyworld> vino: how goes it? let me know when you might be free for a chat?
[02:10] <vino> It working.
[02:10] <vino> i was able to replace the cmd.Context in differant way.
[02:10] <vino> test it..
[02:10] <vino> and push the commit
[02:10] <vino> that can be first reviewed
[02:11] <wallyworld> yay, great
[02:11] <wallyworld> let me know hen ready for review
[02:12] <vino> sure.
[02:31] <wallyworld> babbageclunk: quick chat?
[02:31] <babbageclunk> wallyworld: sure sure
[02:31] <babbageclunk> in 1:1?
[02:31] <wallyworld> yup
[02:55] <vino> wallyworld:
[02:56] <wallyworld> vino: hey, just talking to chtis, give me
[02:56] <wallyworld> 55
[02:56] <wallyworld> 5
[02:56] <vino> sure sure.
[02:58] <vino> anastasiamac: hi Can u please take a look at PR#8644
[02:58] <vino> provide ur feeback please
[02:58] <anastasiamac> vino: m a bit swamp atm but will try later on today. otherwise, monday :D
[03:00] <vino> sure.
[03:04] <wallyworld> vino: free now
[03:04] <wallyworld> habgout?
[03:04] <vino> ok.
[03:04] <vino> not really.
[03:05] <vino> i want u to take a look.
[03:05] <vino> unit tests are still pending.
[03:05] <vino> if u r ok with the way i retrurn
[03:05] <vino> if its CLEAN
[03:07] <wallyworld> vino: ok, will review now
[03:26] <wallyworld> vino: i've left come comments. good to see those contexts gone. let me know if anything is unclear
[03:26] <vino> sure..
[03:27] <vino> i cleaned up the updateseries_test.go
[03:27] <vino> and unti test result:
[03:27] <vino> OOPS: 10 passed, 6 FAILED
[03:27] <vino> --- FAIL: TestPackage (0.21s)
[03:27] <vino> FAIL
[03:27] <vino> so 4 are the ones which has sysd issue
[03:27] <vino> and 2 are STDOUT format err.
[03:28] <vino> and verified the juju-updateseries functionality as well.
[03:30] <wallyworld> unit tests will take a little tweaking to get right for sure
[03:30] <vino> yes.
[03:30] <vino> Just gone thru ur comments
[03:30] <vino> its all clear for me.
[03:30] <vino> i will address them.
[03:30] <vino> Yes. Unit test.... :)
[03:31] <vino> I want u to decide upon that.
[03:31] <vino> shd i be moving them all to service folder as agentconf_test.go ?
[03:31] <vino> wallyworld: the above message is for u :)
[03:32] <wallyworld> yeah, there should be some tests for the helper code in that file. but potentially also some updateseries tests still as well
[03:32] <wallyworld> let's get everything working and then we can mess with where the tests live
[03:32] <vino> ok sure.
[03:32] <wallyworld> easier to refactor with a clean system
[03:33] <vino> first i will address ur review comments and keep it clean.
[03:33] <vino> wallyworld:Agree
[03:33] <wallyworld> that way you know any failures are due to the refactoring and not broken code
[03:33] <vino> wallyworld:agree
[05:38] <vino> wallyworld: have a min
[05:42] <anastasiamac> vino: do u still need that PR reviewed? m in a logical break and can spare a min
[05:42] <anastasiamac> :D
[05:42] <vino> yes. i did address the review comments.
[05:43] <vino> But i need to discuss upon the way unit tests are going to be placed
[05:43] <anastasiamac> "yes" u need a review or is wallyworld reviewing it?
[05:43] <vino> we still have 4 issues failing.
[05:43] <vino> review is done.
[05:43] <anastasiamac> right. so can u resolve the failing tests before next review or do u need a hand?
[05:44] <vino> the resolution of those 4 issues.. requires the unit tests to be relocated.
[05:44] <anastasiamac> m about to go to school picku... do u want to pair on monday to iron these wrinkles? i cannot guaranteed 4am wakeup but certtainly can do a reasonable 9.15am
[05:45] <vino> :)
[05:45] <anastasiamac> really? why? nm - let's discuss on monday :)
[05:45] <vino> sure. i need you help and inputs.
[05:45] <vino> yes see u on Monday
[05:45] <anastasiamac> enjoy crispy cold weekend :)
[05:46] <vino> U too.. Have Fun!
[05:46]  * anastasiamac is tired of scorching heat in autumn..
=== frankban|afk is now known as frankban
=== zerick_ is now known as zerick
=== frankban is now known as frankban|afk
[22:54] <cloaked1> Could someone enlighten me on how to trigger creation of a client-certificate using the easyrsa charm? I'm super new to juju, but so far, it doesn't seem doable to run something like: `juju create_client_certificate` or some such. We're trying to create RBAC based namespaces for users authenticated with certs.
[23:09] <McL0v1n> Anyone having issues with the prefer ipv6 function?
[23:09] <McL0v1n> I have a proper ipv6 address (global and permanent) on an interface but the charms are not recognizing the ipv6 addresses on the interface