Gianlu | hello everyone. Where can I open a bug (or check is an open bug already exists)? I have a problem with the ca_certs module | 08:46 |
---|---|---|
rharper | Gianlu: bugs are at http://bugs.launchpad.net/cloud-init | 08:47 |
Gianlu | ok, thanks | 08:48 |
=== gin is now known as ginsul_ | ||
jocha | blackboxsw: hey Chad, just wanted to let you know I've refactored the unit tests, if you'd kindly take a look: https://code.launchpad.net/~jocha/cloud-init/+git/cloud-init/+merge/344192 :) | 17:45 |
blackboxsw | +1 jocha I was thinking I was going to land this today. I like the changes good work | 18:16 |
* blackboxsw wants to spin up azure again to run a quick test | 18:17 | |
* powersj launched CI on it and it was good | 18:28 | |
jocha | blackboxsw: thanks! appreciate it! :) | 18:50 |
blackboxsw | powersj: https://github.com/canonical-server/jenkins-jobs/pull/38 | 19:55 |
blackboxsw | if you have a chance, I'd like to fix the trigger | 19:55 |
blackboxsw | good 'ole 1 character diffs | 19:55 |
powersj | blackboxsw: when did that get added? I don't see it in your last commit? | 19:57 |
blackboxsw | my PR? I just added that a couple seconds ago | 19:57 |
powersj | the '--' | 19:57 |
blackboxsw | ohh you mean the -- | 19:57 |
powersj | trying to understand why it was hit | 19:57 |
blackboxsw | yeah lemme see. git blame show point an ugly finger | 19:58 |
powersj | and also why the URL was 404, as I think it is more than the -- | 19:58 |
powersj | ac77cc9f (Joshua Powers | 19:59 |
powersj | what a noob | 19:59 |
powersj | was this even working since january?! | 20:01 |
blackboxsw | shows how often we kicked the trigger ;) | 20:01 |
powersj | because this means it will try to launch the job $pre$t | 20:01 |
powersj | $pre == cloud-init-integration-proposed- | 20:01 |
powersj | then $t == triggerwhat == cloud-init-integration-proposed-a | 20:01 |
powersj | so that would combine to be cloud-init-integration-proposed-cloud-init-integration-proposed-a | 20:02 |
powersj | which ain't going to work | 20:02 |
blackboxsw | ugh bad patch, what a noob | 20:02 |
powersj | we need to get rid of pre | 20:02 |
powersj | and just use the $t a la triggerwhat | 20:02 |
powersj | agreed? | 20:03 |
blackboxsw | right we just don't need pre actually read the code now ;( | 20:03 |
powersj | yeah | 20:03 |
blackboxsw | checking traceback in jenkins again to be sure, but yeah I think so | 20:03 |
blackboxsw | roblem accessing /server/job/cloud-init-integration-proposed--cloud-init-integration-proposed-b yep | 20:04 |
blackboxsw | duplicated as you said | 20:04 |
blackboxsw | no prefix. pushing now | 20:04 |
blackboxsw | force pushed now | 20:05 |
powersj | blackboxsw: want to check on https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/344976 too | 20:05 |
powersj | I put a comment there | 20:06 |
powersj | once travis +1s I'll pull | 20:07 |
blackboxsw | so the slop continues | 20:07 |
blackboxsw | I mistakenly pulled the dep version from the wrong tox env | 20:07 |
blackboxsw | for flake8 | 20:07 |
blackboxsw | fixing/testing and pushing | 20:07 |
powersj | pulled your jenkins job fix and jobs redeployed | 20:08 |
blackboxsw | ok inconsistencies with 3.5.0. will sort it | 20:08 |
blackboxsw | thx powersj | 20:08 |
powersj | see I can actually do reviews when not at a hockey game or on the beach ;) | 20:09 |
blackboxsw | heh: Flake8's dependencies explicitly state "< 2.4.0" https://github.com/PyCQA/pycodestyle/issues/741 | 20:12 |
blackboxsw | so might not be able to bump both flake8 and pycodestyle to tip :/ | 20:12 |
powersj | need a new flake8 on pypi | 20:15 |
powersj | 3.5 since oct | 20:15 |
smoser | maybe time to drop flake8 then i guess | 20:20 |
smoser | and just run pycodestyle and pyflakes | 20:20 |
blackboxsw | smoser: you think a new tox env pycodestyle with a pinned version 2.4.0 to supplement tip-pycodestyle tox env? | 21:06 |
blackboxsw | and we have jenkins run that in ci | 21:06 |
=== hrybacki_ is now known as hrybacki |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!