[01:04] <andyrock> robert_ancell: yep
[01:05] <robert_ancell> andyrock, was just checking your gnome-initial-setup MP (I wasn't subscribed so I hadn't seen it). Do you agree?
[01:07] <andyrock> robert_ancell: seb answered before
[01:08] <andyrock> robert_ancell: upstream does not want this, by design they want "quit" to show the wizard again
[01:08] <andyrock> robert_ancell: we can avoid creating the stamp file in other places
[01:09] <andyrock> robert_ancell: but is it worth doing that?
[01:11] <andyrock> robert_ancell: so I'll ask again upstream tomorrow but I can already guess the answer
[01:13] <robert_ancell> andyrock, I think if we drop the desktop check the patch will be smaller which is good if upstream doesn't want that.
[01:13] <robert_ancell> there's no penalty to writing them twice that I can see
[01:14] <andyrock> robert_ancell: not sure I'm getting what you're asking me to do :)
[01:19] <robert_ancell> andyrock, I mean, why have the is_desktop ("ubuntu") part?
[01:19] <robert_ancell> Just always write the files on shutdown
[01:19] <robert_ancell> Then this change can be carried separate to our changes
[01:19] <robert_ancell> our pages I mean
[01:20] <andyrock> mmm are we using  the same gnome-initial-setup  for other desktops too in ubuntu?
[01:20] <andyrock> robert_ancell: I can do that. Tomorrow morning
[01:22] <jbicha> vanilla GNOME is the only other desktop that uses it
[01:22] <andyrock> jbicha: same package?
[01:22] <jbicha> Budgie has its own welcome app and it would need some work to be usable in Unity
[01:23] <jbicha> yes, same package. It shows different pages in vanilla GNOME
[01:23] <andyrock> robert_ancell: that's why I used the is_desktop
[01:23] <jbicha> Ubuntu GNOME 17.04 included gnome-initial-setup by default
[01:23] <andyrock> to not change the beavhior in other desktops
[01:24] <robert_ancell> andyrock, sure, I just feel like this is more of a "we consider users who cancel the dialog to have completed it" rather than "this is specific to the Ubuntu desktop welcome"
[01:24] <robert_ancell> And that leaves us with a smaller patch to carry.
[01:24] <andyrock> jbicha: what do you think?
[01:24] <andyrock> I don't have a strong opinion on this
[01:26] <jbicha> it doesn't matter to me
[01:26] <andyrock> jbicha: kk thanks
[01:26] <andyrock> robert_ancell: ok I'll drop the is_desktop
[01:26] <robert_ancell> andyrock, thanks
[01:27] <andyrock> let me try to do that now
[01:27] <robert_ancell> I think this patch has highlighted how annoying the Appmenu is :)
[01:27] <robert_ancell> Or is it the dock that people use to close it?
[01:28] <robert_ancell> yeah, you can do it from both..
[01:29] <andyrock> I didn't test the dock
[01:29] <andyrock> but it should work
[01:35] <andyrock> robert_ancell: I pushed it as a separate commit
[01:35] <andyrock> if you want I can rebase the all thing
[01:35] <robert_ancell> andyrock, thanks!
[01:36] <andyrock> also I didn't build it (I'm on xenial with ubiquity running on a vm and I cannot restart)
[01:36] <andyrock> but the change was trivial enough
[01:36] <robert_ancell> andyrock, It looked fine to me, we can always fix it if not
[03:49] <HEX0> hello
[06:15] <duflu> Morgen thumper
[06:15] <thumper> hey
[06:16] <thumper> I forgot I had irc open
[06:16] <duflu> biab
[06:21] <oSoMoN> good morning desktoppers
[06:34] <seb128> good morning desktopers
[06:34] <didrocks> good morning seb128!
[06:35] <seb128> hey didrocks
[06:39] <oSoMoN> salut seb128, didrocks
[06:40] <seb128> lut oSoMoN, en forme ?
[06:40] <didrocks> salut oSoMoN
[06:40] <oSoMoN> oui, et vous?
[06:40] <seb128> nickel
[06:40] <oSoMoN> tout se passe bien à Berlin?
[06:41] <seb128> oui, notre review est faite, pas de surprise
[06:44] <oSoMoN> tant mieux
[06:48] <c-lobrano> good morning to all :)
[06:49] <didrocks> hey c-lobrano!
[06:49] <c-lobrano> hey didrocks, how are you?
[06:49] <didrocks> good good, yourself? :)
[06:50] <c-lobrano> I doing good :)
[06:50] <c-lobrano> *I'm
[07:09] <duflu> Morning seb128, didrocks, oSoMoN, c-lobrano
[07:10] <seb128> hey duflu, how are you?
[07:10] <oSoMoN> good afternoon duflu
[07:10] <duflu> seb128, going well. I'm pleasantly surprised to see the bionic bug rush is over (or not started?)
[07:11] <duflu> Wie gehts Berlin, seb128?
[07:14] <seb128> sehr gut
[07:15] <seb128> quiet time until we enable upgrades for 16.04 users at .1? :)
[07:16] <didrocks> hey duflu
[07:16] <duflu> ah, of course
[07:18] <Nafallo> morning
[07:19] <didrocks> hey Nafallo
[07:19] <duflu> Hi Nafallo
[07:25] <seb128> duflu, did you made any progress on the ubiquity issue?
[07:28] <duflu> seb128, not yet. I'm reviewing and retesting yesterday's theories. Might have got it backwards but on the right track
[07:29] <seb128> backwards with uids?
[07:29] <seb128> I asked andyrock if he could help yesterday afternoon but I'm unsure if he was able to reproduce/figured out anything
[07:30] <duflu> seb128, yes, when the installer is working ps shows its uid is root. When it's not working, it's dropped to 'ubuntu'
[07:33] <duflu> But that may be an incorrect observation, which is why I am checking again
[07:33] <jibel> duflu, are you running the installer always from the live session?
[07:33] <duflu> jibel, yes. I like to wipe the partition table manually first
[07:37] <duflu> ALthough that may be correlation, not causation
[07:39] <duflu> Yeah. Seems to be correlated. The problem occurs around the point where the installer switches from uid 999 to 0
[07:40] <duflu> And verified again also that it's not the scale, but timing
[07:40] <duflu> Which would also explain why some reports of similar crashes appear in 16.04
[07:41] <duflu> Maybe
[07:43] <jibel> we had this bug several years ago and completely disabled the slideshow but I cannot find the bug #
[07:45] <duflu> Oh! Cairo uses that call in 3 places. And only this one place fails to sync and handle X errors.
[07:55] <duflu> seb128, I think I might have a fix today...
[07:55] <seb128> nice
[07:55] <seb128> by making that 3rd call use the same error handling that the other 2?
[07:56] <duflu> seb128, yes. The caller already has a fallback. So then it should fall back and keep working
[07:56] <duflu> We shouldn't need to fix the race, only handle it
[07:56] <seb128> great
[08:04] <Laney> moin
[08:04] <Laney> something weird happened to my router
[08:04] <Laney> but internets is happening now
[08:05] <seb128> hey Laney
[08:05] <seb128> back from London?
[08:06] <Laney> yeah
[08:06] <Laney> and it is sunny!
[08:06] <Laney> what's up in berlin?
[08:06] <seb128> nice!
[08:06] <seb128> currywurst!
[08:07] <seb128> week is going well, no surprise so far
[08:07] <Laney> good
[08:08] <seb128> Trevinho, good morning?
[08:09] <Trevinho> seb128: hey seb... Yeah, good morning to you and rest of the team too
[08:10] <seb128> oh, Marco is there :)
[08:11] <Laney> hey Trevinho
[08:11] <didrocks> hey Trevinho
[08:11] <Laney> wb to the proper side of the ocean
[08:11] <didrocks> and Laney!
[08:11] <Trevinho> thanks Laney
[08:12] <Trevinho> and hi didrocks
[08:12] <Laney> what up didrocks
[08:12] <didrocks> nothing special, swapping with my vms ;)
[08:12] <didrocks> you?
[08:12] <Laney> enjoying being home
[08:14] <Laney> going to fish that old inspiron out to see if that gdm bug happens
[08:14] <seb128> I wanted to ask Trevinho if he can have a look tomorrow but he was not around
[08:14] <Laney> that sentence feels time travelly
[08:15] <seb128> now unsure who wants to own/poke at it, either of you guy would do
[08:15] <Laney> yesterday tomorrow was today but now tomorrow is tomorrow
[08:15] <seb128> doh
[08:15] <Trevinho> ahah
[08:15] <seb128> yesterday :p
[08:15] <seb128> I'm tired :p
[08:15] <Laney> well I said I'd get some more logs
[08:15] <Laney> not sure if that is owning
[08:16] <Trevinho> seb128: which one? I didn't see mentions
[08:16] <seb128> Trevinho, can you look if you can reproduce https://gitlab.gnome.org/GNOME/gnome-shell/issues/227 & help upstream to fix it if that's the case?
[08:16] <ubot5-ng`> GNOME bug 227 in gnome-shell "Login fails when preceded by incorrect password" (comments: 16) [Opened]
[08:17] <Laney> anyone know anything about https://bugs.launchpad.net/ubuntu/+source/grub-installer/+bug/1767703 too?
[08:17] <Laney> it is collecting a lot of dupes
[08:17] <Laney> some problem installing grub-efi
[08:17] <seb128> urg
[08:18] <Trevinho> indeed you did... fkng IRC client. I got no notifications on queries
[08:18] <seb128> Laney, let me escalade to our foundations friends
[08:18] <Laney> jibel: ^- maybe you know something about that one?
[08:18] <Laney> like if foundations know :P
[08:18] <Laney> thx
[08:27] <didrocks> looks like people like the communitheme snap CI integration with per-PR branches: https://community.ubuntu.com/t/call-for-participation-an-ubuntu-default-theme-lead-by-the-community/1545/986 and https://community.ubuntu.com/t/call-for-participation-an-ubuntu-default-theme-lead-by-the-community/1545/987 :)
[08:28] <seb128> :)
[08:35] <seb128> Laney, seems like it could be the same as bug #1766945
[08:36] <seb128> raised with Patricia/Steve now
[08:37] <Laney> cheers!
[08:37] <seb128> thank you for mentioning it
[08:39] <Laney> would be good to have a way to update the installer without needing a new iso
[08:39] <Laney> to be able to fix this kind of thing before the point release
[08:39] <didrocks> +1
[08:39] <didrocks> even just for development…
[08:40] <didrocks> (especially in ubiquity-dm mode)
[08:42] <seb128> yeah
[08:43] <seb128> though we might need a new libcairo for the hidpi/xerror bug
[08:43] <seb128> but yeah, having the installer auto-updating upfront would be nice
[08:44] <Laney> omfg
[08:44] <Laney> the inspiron has decided that its battery is fake
[08:44] <Laney> and it tells me this by making a deafening noise
[08:50] <willcooke> andyrock, where should I log a bug for the software and updates livepatch UI?  When the g-o-a u1 account expires it shows livepatch as not being enabled
[08:51] <jibel> Laney, this is a dupe of bug 1766945
[08:51] <willcooke> Trevinho, I'm suddenly seeing a lot of "I can see the desktop when I resume from suspend" bugs, anything I can do while its doing this to help debug?
[08:52] <Trevinho> willcooke: oh, are we again on that? :)
[08:52] <willcooke> :))))
[08:52] <Laney> jibel: ok, that's the same one seb pointed to
[08:52] <jibel> Laney, it's mainly because they removed the warning saying that installing a EFI system without an EIF system partition will fail.
[08:52] <Trevinho> mh... I think we should try to do the same we were doing in unity... andyrock also has a good background on that
[08:53] <Trevinho> so basically painting  a dark frame before giving the ok to suspend
[08:53] <Trevinho> need to see how we can do that in a nice way though
[08:54] <jibel> Laney, and for reference due to fixing bug 1668148
[08:54] <willcooke> Ahh, I wonder if me install the gs connect shell extension has made this worse.
[08:55] <jibel> where is the bot?
[08:55] <Trevinho> willcooke: can you please add a card / bug on that?
[08:55] <willcooke> e,g https://pastebin.canonical.com/p/G5P4JFG8S9/
[08:55] <willcooke> Trevinho, sure thing
[08:55] <seb128> willcooke, so basically it's your fault :p
[08:56] <willcooke> yeah pretty much
[08:56] <willcooke> makes a change, right?
[08:56] <willcooke> lemme disable it and see what happens.
[08:56] <seb128> :)
[08:56] <Trevinho> Laney: as per https://gitlab.gnome.org/GNOME/gnome-shell/issues/227 when attaching such logs also do a `call gjs_dumpstack()`
[08:56] <ubot5-ng`> GNOME bug 227 in gnome-shell "Login fails when preceded by incorrect password" (comments: 16) [Opened]
[08:56] <Trevinho> Laney: see what I've added to https://is.gd/wiki_gnome_shell_crash_debug
[08:58] <Laney> Trevinho: I did, see the top of the log
[09:01] <Laney> jibel: ok, sounds like this error was unexpected tho
[09:01] <Laney> good that they're going to look into it
[09:02] <Trevinho> Laney: also those Apr 23 15:45:26 adam-thinkpad-t430 gnome-shell[5986]: g_dbus_connection_signal_unsubscribe: assertion 'G_IS_DBUS_CONNECTION (connection)' failed seem like it's the cause of one of the bigger crasher we have
[09:08] <seb128> willcooke, there is https://bugzilla.gnome.org/show_bug.cgi?id=753678
[09:08] <ubot5-ng`> bugzilla.gnome.org bug 753678 in lock-screen "Desktop temporarily visible after wake up from suspend" [Normal, Assigned] - Assigned to gnome-shell-maint
[09:08] <seb128> but that's not specific to the case where you disable autolock
[09:09] <seb128> willcooke, https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1532508
[09:10] <seb128> willcooke, https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1741248 was about gnome-shell
[09:10] <seb128> but duflu duplicated it from the unity one
[09:10] <seb128> I think we should undup
[09:10] <seb128> less confusing
[09:12] <didrocks> those kinds of bug will never disappear…
[09:13] <willcooke> Ok, I've logged a new bug since my test cases are very specific:
[09:13] <willcooke> https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1768786
[09:15] <seb128> Trevinho, ^ can you look at that one once you are done with 227?
[09:15] <seb128> or maybe andyrock?
[09:20] <Trevinho> seb128: yeah, sure
[09:21] <seb128> thx
[09:21]  * Trevinho adds cards or his mind won't work
[09:23] <willcooke> Trevinho, are you adding them to the 18.04 board for now?  I'll get a new one set up next week if we can last without it for that long
[09:23] <Trevinho> willcooke: yeah, we can move them once we've a new one
[09:23] <willcooke> kk
[09:23] <Trevinho> willcooke: although not sure we can continue using that for 18.04.x's?
[09:27] <seb128> we have a .1 column, stack here for the moment
[09:29] <Trevinho> seb128: ah, i see it... However I'd prefer to have that most on the right as it feels more natural now to move things from left to right when they proceed
[09:31] <seb128> Trevinho, right, we do that in the new board next week
[09:37] <seb128> Trevinho, I assigned the bug from will to you, but feel free to trade with andy if he wants to take it, please reassign if needed
[09:38] <didrocks> \o/ and I screwed the *last* step of ubuntu-release-upgrader!
[09:38] <didrocks> glad to have tested it :p
[09:38] <seb128> wth communitheme? https://launchpadlibrarian.net/368384621/Zrzut%20ekranu%20z%202018-05-03%2009-21-19.png
[09:39] <didrocks> now fix -> rebuild -> redo a release upgrade
[09:39] <seb128> :)
[09:39] <didrocks> seb128: told you it's not yet fully ready :p
[09:39] <didrocks> ah
[09:39] <didrocks> the list of channels
[09:39] <seb128> yes
[09:39] <didrocks> well, as told, there is a channel for each PR
[09:39] <didrocks> (see my blog posts and the posts I've sent above)
[09:40] <didrocks> they autoclose in 30 days, it's not configurable
[09:40] <seb128> is that a bug in g-s that they are all named the same?
[09:40] <didrocks> yes
[09:40] <didrocks> and there aren't as much
[09:40] <andyrock> willcooke: why the goa account expires? mmm
[09:40] <dxvxb> i am trying to open geogebra in 18.04LTS. it isn't working. program closes after welcome screen...
[09:41] <didrocks> hum, I wonder how I can get the list from snapcraft…
[09:41] <didrocks> when I release something, I get it
[09:41] <didrocks> but without releasing…
[09:41] <andyrock> willcooke: target gnome-online-accounts and whatever software you used to enable it
[09:41] <didrocks> ah status…
[09:42] <didrocks> seb128: here is the real list: http://paste.ubuntu.com/p/s5sQQ8nKVT/
[09:42] <andyrock> seb128, Trevinho iirc they are already showing a black frame before suspend
[09:42] <didrocks> you can notice snapcraft double them though :/ all and amd64
[09:42] <seb128> didrocks, what option to dump the list?
[09:42] <andyrock> seb128: Trevinho it can be the kernel/intel bug we had in unity as well
[09:42] <didrocks> seb128: well, you need to be the snap author and use snapcraft status <snap name>
[09:42] <seb128> andyrock, not when privacy->lock is disabled apparently
[09:43] <seb128> the lock on idle
[09:43] <seb128> didrocks, ah ok
[09:43] <didrocks> only "collaborators/developers/who knows" can
[09:43] <andyrock> seb128: I'll givet it a look
[09:43] <seb128> andyrock, thx
[09:43] <andyrock> i was checking the permission thing in ubiquity
[09:43] <didrocks> so yeah, bug in G-S
[09:43] <didrocks> or snapd
[09:44] <seb128> andyrock, duflu made progress/has an idea about a cairo fix
[09:44] <andyrock> mmm i found a problem when we deal with permissions
[09:44] <Trevinho> andyrock: I meant the thing we did painting a GL frame, more than highlevel thing
[09:44] <Trevinho> there's a thing from Jonas though on that bug that might help
[09:44] <andyrock> Trevinho: I copied the idea from them :D
[09:44] <Trevinho> I didn't check it yet
[09:45] <seb128> didrocks, thx, https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1768779 is the bug, can you maybe put your pastebin list on it for Robert?
[09:45] <didrocks> seb128: doing
[09:45] <seb128> thx
[09:46] <seb128> andyrock, oh, can you give details?
[09:47] <andyrock> so before we call misc.drop_privileges_save() we have: uid=0 and euid=999
[09:47] <andyrock> after we have uid=999 and euid=999
[09:48] <andyrock> after we call misc.regain_..._save() we have uid=999 and euid=999
[09:49] <andyrock> the all point of those functions is to restore the previous beavhior
[09:49] <andyrock> I'm checking what happens in 17.19
[09:49] <andyrock> 17.10
[09:49] <seb128> k, thx
[09:49] <seb128> that sounds weird that it fails to restore
[09:50] <didrocks> seb128: btw, I only reproduced repeated key in Xorg but using a VM… I'm not sure if the issue is clearly native though or just related to using the vm (and so, maybe qemu repeating the key…)
[09:51] <seb128> ah, good to know
[09:51] <seb128> I didn't see it mentioned by users/bugs reports yet
[09:51] <seb128> so doesn't seem to hit/annoy lot of users atm
[09:51] <didrocks> yeah, maybe it's only VM related, and so, unrelated
[09:51] <didrocks> yep
[09:51] <andyrock> didrocks: repeated key a broken in mutter/gnome-shell even without vm
[09:51] <didrocks> andyrock: Xorg?
[09:51] <seb128> andyrock, under xorg?
[09:52] <andyrock> didrocks: xorg for sure
[09:52] <seb128> :/
[09:52] <didrocks> ah… so a real one
[09:52] <andyrock> but when I tested on wayland is not better
[09:52] <didrocks> yeah, we started seeing it on wayland here
[09:52] <andyrock> I started to take a look before we started the work on gnome-initial-setup
[09:52] <didrocks> was better in Xorg… but hemf :/
[09:53] <andyrock> didrocks: just keep f11 pressed while firefox is focused
[09:53] <andyrock> save your session before ;)
[09:53]  * didrocks isn't going to do it then :p
[09:54] <andyrock> in compiz we had a way to specify for a keybinding if autorepeat should work or not
[09:54] <andyrock> with f11 it shouldn't
[09:54] <andyrock> with alt+tab it should
[09:55] <andyrock> there is not such a thing in mutter
[10:04] <willcooke> andyrock, https://bugs.launchpad.net/ubuntu/+source/gnome-online-accounts/+bug/1768797
[10:04] <willcooke> andyrock, dont look at that now though :)
[10:05] <duflu> seb128, yes my cairo patch fixes the installer crash. I half expect upstream to not like it because of the performance implications. Although they already have a bug open for the same line of code, for similar reasons
[10:05] <seb128> duflu, nice, let's see what they say
[10:06] <seb128> we shouldn't hit that codepath in "normal use" right?
[10:06] <seb128> the xerror is hit only because ubiquity is doing weird uid handling?
[10:07] <duflu> seb128, it is a "normal" code path, but only "normal" for setup logic. Not central to animation performance
[10:07] <andyrock> willcooke: I've a weird way to check if the credentials are still valid, it can be this the reason why it fails
[10:07] <andyrock> I'll take a look later
[10:24] <andyrock> seb128: ubiquity runs with uid=0 and euid=0 in 17.10
[10:24] <andyrock> when drop_privileges_save the uid and euid stay the same
[10:24] <seb128> what part/at what time?
[10:24] <andyrock> seb128: in 17.10 from the start
[10:24] <andyrock> you can notice just using ps
[10:24] <seb128> well that's right/supposed to be the same in 18.04
[10:25] <andyrock> nope in 18.04 is runs as 999
[10:25] <andyrock> at least the euid
[10:25] <andyrock> let me check the last commits
[10:25] <seb128> well, ubiquity does those drop/restore dances
[10:26] <andyrock> that don't work as they should :D
[10:26] <seb128> but the .desktop still do sudo ...
[10:29] <willcooke> LUNCH!
[10:31] <duflu> andyrock, you are now assigned part of bug 1751252 :)
[10:32] <duflu> seb128, here's a fix: https://bugs.freedesktop.org/show_bug.cgi?id=98883#c6 I think I'm done for today
[10:32] <ubot5-ng`> bugs.freedesktop.org bug 98883 in xlib backend "BadAccess errors in ShmAttach due to thread races with XNextRequest() usage in cairo-xlib-surface-shm.c" [Normal, New] - Assigned to chris
[10:33] <duflu> andyrock, if you have a fix for ubiquity too, please add it to bug 1751252. I'm heading off...
[10:53] <Laney> Trevinho: this has to be some refcounting thing
[10:54] <Trevinho> Laney: which one? The signal unsubscribe?
[10:55] <Laney> not sure where, these things are the worst
[10:55] <Laney> that's probably just the one that gets unlucky and makes the thing actually be disposed
[10:55] <seb128> side effect of the gjs leak fix?
[10:55] <didrocks> dist-upgrading, and was almost done in the VM from 17.10 -> session closed, no crash file :/
[10:55] <seb128> journal error?
[10:56] <didrocks> nothing either
[10:56] <didrocks> apart from the session closing part
[10:56] <didrocks> I didn't get that starting in the exact same state…
[10:56] <seb128> :/
[10:56] <didrocks> (and it went further down, as I got the issue on saving the upgade telemetry file)
[10:56] <didrocks> I guess that's another try now, reverting to the snapshot
[11:21] <Trevinho> seb128: not sure if that... But indeed it's the garbage colector. However I don't like how it works the glib side of things either, so I was looking into it
[13:03] <andyrock> seb128: so the crash has been introduce by https://git.launchpad.net/ubiquity/commit/?h=bionic&id=dcb538ded2159439e3d9c4c988a6d9d2c4138622
[13:03] <andyrock> seb128: the commit is correct, but it's triggering the crash
[13:04] <seb128> ahah
[13:04] <seb128> Laaaaannnnneeeyyy
[13:04] <andyrock> it's not Laney's fault
[13:04] <andyrock> :D
[13:05] <Laney> what
[13:05] <didrocks> redoing an upgrade test. It seems the issue is with screen locking…
[13:05] <didrocks> at least, want to confirm telemetry first before even starting debugging this…
[13:06] <seb128> didrocks, what are you debugging/fixing?
[13:06] <andyrock> Laney: so without that commit drop_privileges_* does not work and this does not trigger the crash
[13:06] <andyrock> but having drop_privileges_* not working is not a good idea
[13:06] <Laney> the same one duflu fixed?
[13:07] <andyrock> but at least we know why it started happening
[13:07] <seb128> yes
[13:07] <Laney> ok...
[13:07] <seb128> duflu is not sure his fix is not going to have a performances impact
[13:07] <seb128> so we are waiting to hear from upstream before considering it as the way to go
[13:07] <seb128> but yeah, those permissions issues in ubiquity are really annoying :/
[13:08] <seb128> we need to make it an user app with proper backend/polkit use
[13:08] <didrocks> seb128: I'm adding upgrading logs to our telemetry
[13:08] <seb128> not going to be for .1 though
[13:08] <Laney> yes that's well known
[13:08] <Laney> but unless some people get assigned to do this work it's not going to happen
[13:08] <seb128> right
[13:09] <didrocks> yeah, we need to have an UI piloting a separate backend with clear communication and permissions between those 2
[13:09] <didrocks> however, I'm afraid that's almost a rewrite…
[13:10] <seb128> we raised up that installer needs more resources
[13:10] <seb128> ideally some extra headcount is needed for installer, n-m, etc
[13:10] <seb128> let's see if we get anything
[13:10] <didrocks> yep
[13:14] <seb128> Laney, I've no idea what your backlog looks like atm, do you think you have space to look at bug #1768541? unsure how important that problem is, we got a few reports, would be nice to at least have someone trying to understand what's going on to see if that needs to be fixed or is low importance
[13:17] <seb128> andyrock, so does it mean on 17.10 the webkit code is used as root?
[13:18] <andyrock> seb128: that's what I was thinking
[13:18] <andyrock> it should not work as root but it does
[13:18] <seb128> k, well at least it explains why it started recently
[13:18] <Laney> Can do later.
[13:18] <seb128> at least things make sense
[13:19] <seb128> Laney, thx!
[13:19] <Laney> andyrock: Try moving the widget creation to the constructor or something that is not running as root
[13:19] <seb128> andyrock, k, thanks for poking/figuring that out. Feel free to move back to the other things you were worked on, if cairo's upstream is happy with duflu's patch we should be set
[13:19] <Laney> Save it in the class and fetch it out when you need it later
[13:19] <andyrock> Laney: thanks.. I'll try to do that
[13:20] <seb128> maybe try what Laney suggests
[13:20] <andyrock> seb128: let me spend some more time
[13:20] <andyrock> on this :D
[13:20] <seb128> kk
[13:34] <andyrock> seb128: confirmed that the webkit process runs as root in 17.10
[13:34] <andyrock> the two processes
[13:34] <seb128> k
[13:34] <seb128> well that explains then
[13:35] <seb128> I'm not sure to understand why we hit the access Xerror when being "ubuntu"
[13:35] <seb128> I would have expeted to be the other way around
[13:35] <andyrock> seb128: I guess it's the change of [e]uids
[13:35] <andyrock> that confuses X
[13:35] <andyrock> in 17.10 they don't change
[13:36] <andyrock> in 18.04 they change and the change confuses X
[13:36] <seb128> hum, k
[13:44] <didrocks> phew, first successfull dist-upgrade with do-release-upgrade done
[13:44] <didrocks> same, it's a pain to test without publishing a version…
[13:44] <didrocks> now, seems harder to test the gtk version
[13:45] <didrocks> I think I'll as it needs to sudo <app> with my download bypass switch to a Xorg session
[13:45] <didrocks> (on 17.10)
[14:08] <seb128> didrocks, what sort of metrics do we add to the upgrader?
[14:10] <didrocks> seb128: which version we upgrade From, and the various step + time they take
[14:10] <seb128> k, nice
[14:10] <didrocks> seb128: I'm powndering adding the "flavor" of do-release-upgrade which was used
[14:10] <didrocks> it's not included right now
[14:10] <didrocks> (cli, gtk, kde…)
[14:10] <seb128> ah, interesting one
[14:10] <didrocks> do you think that worths inclusion? Shouldn't be hard
[14:11] <seb128> yes, it's interesting to know if users update from the gui or cli
[14:11] <didrocks> ok, let me add it, and then, redoing some tests
[14:11] <didrocks> I wonder how you trigger the non interactive one though
[14:12] <didrocks> the 3 others (text, gtk, kde) makes sense…
[14:12] <didrocks> I'll have a look at how to try this
[14:12] <didrocks> also --help isn't in sync, I should update it while I'm at it
[14:12] <didrocks> unrelated but bug #1738870 is raised on d-d-l
[14:20]  * mgedmin twice had the gui upgrader crash in the middle and no longer trusts it
[14:21] <jibel> mgedmin, did you send bug reports?
[14:21] <mgedmin> I did
[14:22] <jibel> mgedmin, do you have bug numbers?
[14:24] <mgedmin> https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1573558
[14:27] <jibel> inspecting the upgrader while it's upgrading is not the typical use case but still.
[14:28] <seb128> didrocks, who raised it? I'm not subscribed and there are quite some replies on that discussion, I'm too lazy to click on them all
[14:28] <mgedmin> the other one was a known issue, mentioned in the release notes (ubuntu gnome upgrades lost the ability to unlock the screen because some gdm socket directory changed iirc; so of course I was very careful about disabling the screensaver before upgrading but then hit the Lock Screen key when I went to get my tea oops)
[14:28] <jibel> mgedmin, so it seems there was a debconf prompt "got a conffile-prompt from dpkg for file: '/etc/default/rcS'" that you didn't see
[14:29] <jibel> mgedmin, AFAIR there was a bug where the text area didn't open when there was a debconf prompt and it looked like everything stalled while it was actually waiting for user input
[14:29] <mgedmin> I saw it and told it to keep my version
[14:29] <jibel> ah okay
[14:29]  * mgedmin has extensive notes ;)
[14:30] <mgedmin> I even remarked that the buttons on the prompt had icons on them, like in early GNOME 2 days
[14:32]  * mgedmin seems to remember another upgrade that restarted gdm in the middle, killing the X session, but it was more than ten years ago and I had a different computer and my notes for it are backed away somewhere I don't remember where
[14:33] <didrocks> seb128: the bug reporter, Jeb Eldridge
[14:34] <seb128> ah, https://mail.gnome.org/archives/desktop-devel-list/2018-May/msg00001.html
[14:34] <seb128> k
[14:36] <seb128> well, not a lot we can do
[14:36] <seb128> his main issue is that launchpad don't know how to remote watch gitlab urls
[14:37] <didrocks> yeah, I don't remember what was the outcome after discussing with Colin
[14:37] <seb128> which Colin said is non trivial work/needs to be scoped on their roadmap
[14:37] <didrocks> ok
[14:37] <seb128> but I expect that's going to be less important than other snap related work he's doing
[14:37] <didrocks> yes
[14:38] <seb128> other option is that someone is our team is interested by doing launchpad hacking for a week
[14:38] <didrocks> hum, I'll do the --help outdated fix in a separate commit, as all translations need to be updated as well
[14:38] <seb128> though learning curve etc might not make that having sense
[14:38] <didrocks> yeah, I don't think if a week is realistic
[14:38] <didrocks> especially with the test infra
[14:39] <didrocks> know*
[14:39] <didrocks> (and also, don't think ;))
[14:39] <jbicha> I guess cloning cjwatson is out of our budget too ;)
[14:39] <didrocks> interesting option, --depth=1 or more? ;)
[14:42]  * didrocks leaves quietly with his git joke…
[14:45] <didrocks> ok, with the cosmic gate opened, my ubuntu-release-upgrader new build with flavor support is delayed by hours
[15:18] <kenvandine> ugh... i subscribed to cosmic-changes and forgot to setup a filter... inbox exploded
[15:18] <didrocks> :)
[15:18] <seb128> lol
[15:23] <didrocks> I had to patch the file manually to make some tests, can't wait for the ppa to be built, the time is pushing back and back
[15:31] <jbicha> didrocks: here's a secret, you can skip ahead of other PPAs if you bump the urgency
[15:31] <jbicha> or bribe someone that can rescore your builds
[15:31] <seb128> blame on dok_o?
[15:33] <didrocks> jbicha: well, I know about it, it's not like I'm not using launchpad since 2007 or so :p
[15:33] <didrocks> jbicha: I've got my score bumped up multiple times, but it's annoying to ping people for this
[18:09] <andyrock> seb128: fixing regain_privileges_save makes the crash go away
[18:09] <andyrock> so drop_privileges_save works if and only if you called drop_privileges before
[18:10] <andyrock> so the intial situation is (ruid, euid, suid) =  (0, 0, 0)
[18:10] <andyrock> when we call drop_privileges we get (0, 999, 0)
[18:11] <andyrock> this is not enough to call webkit code (because gtk init will fail! We need ruid == euid)
[18:11] <andyrock> so we call drop_privileges_save and we get (999, 999, 0)
[18:12] <andyrock> atm if we call regain_privileges_save we get (0, 0, 0) but we should get
[18:12] <andyrock> (0, 999, 0)
[18:13] <andyrock> it used to be like that, than https://git.launchpad.net/ubiquity/commit/?id=815fbf12 introduced the regression
[18:13] <andyrock> if found a way to do it properly
[18:13] <andyrock> seb128: I'll check if kde installer works too
[18:13] <andyrock> as regain_privileges_save is used there too
[18:16] <BarrieButsers> Hi, i run xenial, and want a bugfix that is in zesty, but don`t want to upgrade whole system; is that possible?
[18:19] <andyrock> BarrieButsers: which fix and which package?
[18:23] <BarrieButsers> andyrock: https://bugs.launchpad.net/ubuntu/+source/libxi/+bug/1360342
[18:25] <andyrock> BarrieButsers: try to manually install the deb, you can download from here: https://launchpad.net/ubuntu/+source/libxi
[18:26] <andyrock> https://launchpad.net/ubuntu/+archive/primary/+files/libxi-dev_1.7.9-1_amd64.deb and https://launchpad.net/ubuntu/+archive/primary/+files/libxi6_1.7.9-1_amd64.deb
[18:30] <BarrieButsers> andyrock: ok thanks, gonna try that,have downloaded the debs but gotta go now, thanks in advance for the answer. Will let know if it succeeded later
[19:00] <oSoMoN> good night all
[19:19] <andyrock> seb128: https://code.launchpad.net/~azzar1/ubiquity/+git/ubiquity/+merge/345056
[19:19] <andyrock> Laney too ^^^
[19:48] <jbicha> robert_ancell: https://launchpad.net/ubuntu/+source/gnome-initial-setup/3.28.0-2ubuntu6.1
[19:48] <jbicha> the workflow was a bit of a pain with those merge commits, not sure whether we'd be better off rebasing and force pushing or what
[19:57] <robert_ancell> jbicha, I rebase
[19:58] <robert_ancell> kenvandine, oh, I remembered the other reason that keeping the changes in the g-i-s branch is hard - you have to constantly rebase on upstream anyway, and that can get hard with a huge list of changes.
[19:59] <kenvandine> robert_ancell, yeah
[21:23] <andyrock> robert_ancell: https://gitlab.gnome.org/Community/Ubuntu/gnome-initial-setup/merge_requests/2/diffs
[21:23] <ubot5-ng`> Ubuntu bug (Merge request) 2 in gnome-initial-setup "livepatch: Do not dereference a null error pointer." (comments: 0) [Opened]
[21:23] <robert_ancell> andyrock, sounds like a good idea :)
[21:23] <robert_ancell> oops
[21:23] <seb128> andyrock, you keep being amazing :)
[21:24] <andyrock> XD
[21:25] <robert_ancell> andyrock, is there a bug for that? So we can SRU it easily
[21:30] <seb128> robert_ancell, it's in the description... :)
[21:30] <seb128> also the current SRU just got accepted
[21:31] <seb128> I wanted to do another one though, including also the "quit means quit" fix
[21:32] <seb128> oh, seems like jbicha did another upload
[21:32] <seb128> duplicating existing bugs
[21:33] <seb128> well, my other changes are strings changes so I'm going to manually update the template and give translators a notice
[21:33] <seb128> then we can do another upload after giving them so time for doing the translations
[21:37] <seb128> robert_ancell, kenvandine, see, debian/ in bzr over upstream is better, no rebasing issues :)