[05:43] <seb128> good morning desktopers
[05:43] <jibel> Good morning seb128
[05:44] <seb128> lut jibel, en forme ? bientôt le w.e ? ;)
[05:44] <jibel> seb128, en pleine forme et bientot les vacances :) et toi ça va ?
[05:45] <seb128> oui, c'est vendredi :)
[05:50] <duflu> Morning seb128 and jibel
[05:50] <duflu> bon vendredi
[05:50] <seb128> bon vendredi duflu!
[05:50] <jibel> hi duflu, happy friday to you
[06:30] <willcooke> morning all.  Happy Friday!
[06:34] <duflu> Hi willcooke
[06:43] <didrocks> good morning
[06:43] <seb128> lut didrocks
[06:44] <didrocks> salut seb128, paré pour la dernière journée en Allemagne ?
[06:46] <seb128> oui :)
[06:48] <duflu> 'lo didrocks
[06:48] <didrocks> hello duflu
[06:55] <oSoMoN> good morning desktoppers
[06:56] <seb128> lut oSoMoN
[06:57] <oSoMoN> salut seb128
[06:57] <oSoMoN> ça va?
[07:17] <didrocks> hey oSoMoN
[07:17] <oSoMoN> hey didrocks
[07:19] <didrocks> installing kubuntu to test dist-upgrade telemetry
[07:19] <duflu> Morning oSoMoN
[07:19] <oSoMoN> good afternoon duflu
[08:02] <Laney> moin
[08:06] <didrocks> hey Laney
[08:07] <Laney> hey didrocks
[08:07] <Laney> andyrock: you better get cjwatson to review that
[08:07] <Laney> didrocks: how's it going?
[08:07] <didrocks> Laney: quite well! Week-end almost there, installing kubuntu… ;) how are you?
[08:08] <Laney> tired, looking forward to a 3 day weekend!
[08:08] <didrocks> (funny that running the dist-upgrader from source between GTK and KDE require different procedures… :p)
[08:08] <didrocks> 3 days?
[08:08] <didrocks> Monday if off for you?
[08:09] <didrocks> "Early May bank holiday"
[08:09] <didrocks> we are not going to see each other a lot next week :)
[08:09] <didrocks> Tuesday and Thursday is off in France
[08:09] <didrocks> are*
[08:09] <didrocks> (but not Monday)
[08:10] <Laney> yeah may's a good month for holidays
[08:11] <didrocks> indeed :)
[08:11] <Laney> 2 for us though, you get 4 I think
[08:11] <Laney> slackerssss
[08:12] <didrocks> well, actually, 3
[08:12] <didrocks> we got 4, but only get paid for 3
[08:14] <didrocks> the 21 one is a weird one, basically, it's taxing for elder's charges
[08:14] <didrocks> and they are discussing about adding one more like this
[08:15] <Laney> hmm?
[08:15] <Laney> don't think we have anything like this
[08:15] <didrocks> it started with the heat waves in 2003
[08:16] <didrocks> so, if I count correctly, you have 8 days off in UK, we have 9 in France (once you removed the Saturdays and Sundays)
[08:16] <didrocks> as for us, it depends on the year ;)
[08:16] <Laney> yep always 8
[08:16] <didrocks> yeah, more random for us
[08:16] <Laney> unless you vote labour
[08:17] <didrocks> ah ?
[08:17] <Laney> they want to make more!
[08:17] <didrocks> I wonder, for all of those who don't work on Monday, how does it work for you?
[08:17] <didrocks> do they get it back at their leasure?
[08:20] <Laney> interesting, I don't actually know if there's a general rule
[09:23] <seb128> Laney, didrocks, did you see https://code.launchpad.net/~azzar1/ubiquity/+git/ubiquity/+merge/345056 ? seems like andyrock figured out the permission issue :)
[09:23] <seb128> I'm trying to wrap my head around the fix
[09:23] <seb128> extra reviews/comment are welcome :)
[09:24] <seb128> duflu, duflu, btw https://lists.ubuntu.com/archives/ubuntu-devel/2018-May/040295.html , you are right that the vcs info needs updated but that requires an upload
[09:25] <duflu> seb128, yeah sounds like both cairo and ubiquity are broken simultaneously. Fixing at least one of them will hide the problem
[09:25] <seb128> right
[09:25] <duflu> And we have fixes for both
[09:25] <didrocks> oh nice! looking
[09:25] <seb128> well done team!
[09:26] <didrocks> hum
[09:27] <didrocks> I don't understand why we don't call directly os.setresuid(0, egid, 0) for instance
[09:27] <didrocks> probably because os.setgroups([]) has an incidence, but I've never used that one
[09:27] <seb128> yeah, it's a bit over me as well how that code works :/
[09:27] <seb128> I wonder if we should get foundations to review
[09:28] <didrocks> well, preservering the euid and geuid is needed for sure
[09:28] <Nafallo> morning
[09:28] <didrocks> and replacing with 0 for uid/guid was a mistake
[09:28] <didrocks> but I don't understand why the 2 calls
[09:28] <didrocks> hey Nafallo
[09:28] <seb128> right
[09:31] <seb128> I've pinged Steve/Dimitri, let's see if they want to review
[09:31] <didrocks> yeah
[09:32] <Laney> hi seb128
[09:32] <Laney> I already told andyroc-k earlier that he should ask Colin
[09:32] <Laney> but ok that you pinged them
[09:33] <seb128> ah, I disconnected/didn't see that
[09:33] <seb128> thx
[09:36] <seb128> Laney, xnox commented saying you should review :p
[09:36] <Laney> that's not a very helpful comment
[09:36] <seb128> indeed
[09:37] <xnox> /o\
[09:37] <xnox> 😱
[09:37] <seb128> xnox, btw you could change the Vcs info in the git repo at least, so it's in the next upload
[09:37] <xnox> seb128, yes
[09:37] <seb128> thx
[09:38] <Laney> I still recommend that Andrea talks to Colin when he's around, that's probably likely to be the most productive route
[09:38] <Laney> hi xnox :P
[09:39] <xnox> yo
[09:43] <seb128> Laney, right
[10:37] <andyrock> hey all
[10:37] <andyrock> didrocks: the two calls are required because .setgroups requires permissions
[10:38] <andyrock> that's why the regression was introduced in the first place
[10:43] <andyrock> I'll talk with colin and add a comment to explain why the double call is required
[12:23] <seb128> tkamppeter, did you see bug #1763520?
[13:08] <andyrock> seb128: Laney: Colin said we should ask Foundation to review it
[13:08] <Laney> hahaha
[13:09] <Laney> right then :-/
[13:09] <Laney> xnox: guess it's up to you please :-)
[13:09] <andyrock> we could ask community to help testing it
[13:09] <andyrock> on kubuntu too
[13:10] <xnox> lovely
[13:10] <xnox> Laney, my first thoughts are "it seems sketchy to have more than one pair of drop/restore privilidges"
[13:10] <xnox> Laney, the effects of these extra euids, are potentially non-obvious
[13:10] <xnox> Laney, and i need to inspect all calls to these things....
[13:10] <xnox> Laney, Test that "push battan" works
[13:11] <didrocks> andyrock: sent "approved" for my part as you answered my question, but yeah, would be nice to have Foundation doing the final round ;)
[13:12] <andyrock> the *_save version is not used in a lot of places
[13:14] <andyrock> basically in 3 places
[13:43] <seb128> who wants to handle merging/SRUing that ubiquity fix?
[13:43] <seb128> cyphermox, xnox, want to do that?
[13:45] <cyphermox> I can merge it
[13:45] <seb128> thx
[13:46] <seb128> if someone here wants to try to drive that through upload/SRU next week that would be nice
[13:46] <seb128> otherwise I can have a look once I'm back
[13:49] <didrocks> my realm for a "s" option in bzr sheleve
[13:49] <didrocks> shelve*
[13:49] <seb128> I update bug #1751252 for SRU info
[13:49] <seb128> cyphermox, if you merge can you dput to bionic as well? ;)
[13:50] <seb128> cyphermox, the bug reference is ^ and is SRU compliant
[14:00] <cyphermox> yeah, I was going to dput as well
[14:00] <seb128> thx!
[14:00] <cyphermox> it's just that I was preparing to do this on the bzr branch, because that's what I still had loaded
[14:01] <seb128> hehe
[14:01] <seb128> on that note, I'm wrapping in a bit so have a nice w.e/week desktopers if I don't see you again before your eod
[14:02] <seb128> (I might be online from airport/train/... later)
[14:02] <didrocks> have a nice travel back/week-end/week seb128!
[14:02] <seb128> thx
[15:49] <rbasak> Bug 1767527 looks legit to me. I think I've hit it previously (upgrading to 16.04 perhaps?). Stuff gets removed on release upgrade such that there's not enough in the initramfs to decrypt LUKS.
[17:02] <HEX0> rbasak: afaik the only hook you need in initramfs is "encrypt". Imo it's best to just compile everything into the kernel including firmware blobs and disable module loading.
[17:06] <HEX0> default keymap is US so you only need keyboard and encrypt hook. if you use dracut you need to specify crypt module. I'd personally still make initramfs as simple as possible so it's less likely to fail and build everything into the kernel
[17:26] <oSoMoN> have a good week-end desktoppers!