[04:05] mcphail: snapcraft's README.md refers to the Launchpad one [05:06] morning [05:34] mvo: hey, how are things? [05:45] Good morning [05:45] zyga: hey [05:46] zyga: i see we made it to 2.32.6 [05:50] hey zyga and mborzecki ! [05:50] mvo: morning [05:51] mvo: how was the sprint? [05:52] * zyga -> walk [05:52] mborzecki: it was good [05:52] mborzecki: no surprises, focus for the next couple of weeks is making core18 bootable and working on the upgrade path [05:52] mvo: any updates to the roadmap then? [05:52] mborzecki: but we knew that :) [05:53] mborzecki: nothing new in the roadmap I think [05:54] mborzecki: we will need to do a .7 to fix an important usecase (two PRs up for that already) [05:54] mborzecki: and then we are hopefully fully back to 2.33 [05:54] Oh [05:54] What is for .7? [05:54] hm and i thought we were done with .6 :) [05:54] zyga: a systemd target for when the system is fully seeded [05:54] zyga: and a way for snaps to declare an "after: snapd.seeded" [05:55] zyga: it is important for some 18.04 cloud image use-cases [05:55] mborzecki: I thought so too :) but then reality disagreeded [05:55] I think its pretty straightforward, it will need a design ACK from gustavo though [05:56] I See [05:57] mvo: a target taget? as in snapd.seeded.target? [05:57] mborzecki: correct [05:57] mborzecki: so that a unit can say "after=snapd.seeded.service" [05:59] mborzecki: there is a PR up for this (5124) but it was written during the sprint so an extra careful review is needed :) [05:59] the other one is 5132 and we will need 5133 for cosmic [06:09] PR snapd#5136 opened: tests: ubuntu 18.04 or higher does not need linux-image-extra- [06:26] PR snapd#5128 closed: Revert "Skip test lp-1721518 for arch, snapd is failing to start afte… [06:29] PR snapd#5121 closed: interfaces:minor autoconnect cleanup [06:36] PR snapd#5069 closed: configcore: validate experimental.layouts option [06:44] * zyga is back home and working now [06:44] my whole desk was covered with yellow powder [06:45] something must be blooming nearby [06:45] yuck [06:48] * zyga catches up with email [06:49] mvo: please ping me if something urgent is needed, I will start hacking at around noon, I need to get my inbox under control [06:54] zyga: I will focus on .7 this morning and trying to make sure autopkgtests and spread is happy [06:55] zyga: 5131 needs a second review but its pretty trivial and can probably go in with a single review even [06:55] zyga: I got this error in one of my PRs so it might be a prereq for landing the 2.32 ones [06:58] mvo: FYI, I think there's a real error that affects debian [06:58] mvo: but it's rare [06:58] mvo: if you see a network-bind or network test fail there, that's it [06:58] it looks like we become unconfined in some situations [06:59] PR snapd#5136 closed: tests: ubuntu 18.04 or higher does not need linux-image-extra- [07:00] mvo: btw, do you know what is cosmic? [07:00] cosmic ... c-what? [07:00] zyga: I don't [07:00] zyga: canimal? [07:00] zyga: cockroach maybe [07:01] mborzecki: no :) [07:01] or maybe canibal [07:01] haha [07:01] canibal cockroach [07:01] sounds like a great name for a death metal band ;) [07:02] lol [07:02] cosmic cosmonaut would be nice [07:02] humans are animals too [07:02] I like cosmonaut! === pstolowski|off is now known as pstolowski [07:04] mornings! [07:04] hey pstolowski good morning and welcome back [07:04] how was the sprint? [07:05] pstolowski: morning [07:05] good morning pawel [07:05] pstolowski: good, no surprises, roadmap is pretty much what we discussed already [07:12] arch package bumped to 2.32.6 [07:13] and wow, we have quite a lot of open PRs [07:14] PR snapd#5135 closed: Docs moved to forum [07:15] need coffee [07:15] PR snapd#5133 closed: spread.yaml: add cosmic (18.10) to autopkgtest/qemu [07:28] zyga: regarding #1769203, haven't we looked at auto mounting snaps via .automount unit files? [07:28] Bug #1769203: every revision of snaps are mounted [07:29] mborzecki: I mentioned this and I think gustavo was sceptical about it [07:33] zyga: do you recall what was his reasoning? [07:37] mborzecki: we did use automount a long time ago, it may even be in the git history (a looooong time ago, very early days of the project) [07:37] mborzecki: that it is not fully transparent [07:37] mborzecki: you can observe automount points [07:37] mborzecki: you can unmount them to break them [07:38] zyga: hm, unmount them to break them is also true for .mount services, no? [07:40] PR snapd#5131 closed: tests: fix interfaces-network test for systems with partial confinement [08:06] mvo: are we pushing .6 to stable [08:25] zyga: is there any concern still about https://github.com/snapcore/snapd/pull/5075 ? [08:25] PR #5075: snap/env: fix env duplication logic [08:30] zyga: yes, today when cachio is around (probably after the standup [08:30] mvo: brilliant [08:32] zyga: is there any work to make 2.32 tested again that I can build upon? or just go over the master PRs and cherry-pick the right stuff? [08:35] btw, a review for 5132 would be great. it need a final +1 from niemeyer to ensure he is happy with the language but beside that it should be ready for review [08:42] doing [08:43] ta [08:52] mvo: done [08:56] ta [09:06] PR snapd#5137 opened: tests: cherry-pick commits to move spread to google backend [09:14] hmmmmm [09:14] mvo: I have a debian 10 vm with two snaps but no core [09:14] * zyga wonders how that happened [09:15] snap changes from debian 10 https://www.irccloud.com/pastebin/oU28h1jS/ [09:15] * mvo hugs mborzecki and zyga for the excellent review in 5131 [09:16] zyga: strange, what version of snapd is running? [09:22] 2.30 [09:23] 3.30-5+b1 [09:38] mwhudson: hey [09:38] mwhudson: not super urgent but it would be good to update snapd in debian to 2.32.6 or .7 [09:39] mwhudson: also (as before) not sure how to maintain this package [09:40] mwhudson: what is the process for doing a new release? merge upstream and massage? [09:43] we should also check if re-exec is enabled [09:44] yay, cosmic autopkgtest for ppc64/s390x is green [09:55] mborzecki: are you running arch or ubuntu now [09:55] mborzecki: I may need your help [09:55] arch [09:56] zyga: what do you need help with? [09:56] Bug #1593141 changed: Each run of a snap app leak directories in /tmp [09:57] mborzecki: there's a bug, I cannot find it now [09:57] maybe on the forum, maybe on laucnhpad [09:57] it relates to this call [09:57] PR snapd#5137 closed: tests: cherry-pick commits to move spread to google backend [09:58] https://www.irccloud.com/pastebin/Wygky688/ [09:58] someone got a denial on that [09:58] I wonder if the "none" is significant [09:58] can you see if you got that denial? [09:58] * zyga boots 18.04 live usb to test something else [10:00] wow, I didn't know there are so many snaps on the live ISO [10:00] zyga: ok, let me sync some stuff first [10:01] mborzecki: thanks [10:01] snap list truncates "tracking" too much [10:03] PR snapd#5129 closed: cmd/snap-confine: allow any base snap to provide /etc/alternatives [10:03] mvo: thank you [10:03] mvo: I was working on a new base snap last weekend [10:03] mvo: I ran into a serious bug, I didn't manage to debug it yet though [10:04] zyga: oh? ok - anything you can share? [10:04] zyga: what was the error etc? [10:04] mvo: snaps based on that snap didn't start at all, something wrong in the deep guts of snap-confine [10:04] I didn't get to the bottom of it, I can share later today if you want to play [10:07] some issues from the live ISO [10:08] failed refresh on live iso https://www.irccloud.com/pastebin/bLhbMBWf/ [10:08] failed mount on live iso (curious) https://www.irccloud.com/pastebin/h2R6g2mI/ [10:09] afaik refreshes are not working on the live image, that's why they asked us how to turn them off [10:09] ureadahead is creazy on the live iso, spamming with errors [10:09] pedronis: they work on 2nd try [10:10] what I mean, afaik they are not expected to work [10:10] I see [10:11] I don't know the details, but they didn't ask to help fix them, but how to turn off auto-refreshes [10:11] I think there's a basic space problem as well [10:15] Bug #1443612 changed: please set /run/shm/snaps/@{APP_PKGNAME}/@{APP_VERSION}/ for apps [10:18] Bug #1650389 changed: Installing snapd on 14.04.5 desktop downgrades xorg et al. <14.04> [10:21] Bug #1659924 changed: Snap failures in 16.04 [10:30] mvo: damn, that template is tricky [10:30] Bug #1458866 changed: hangs in uboot boot prompt if dtbs dir is missing [10:33] cjwatson: thanks. that's the one i've used [10:33] Bug #1464396 changed: "sudo: unable to resolve host ..." when custom hostname is used. [10:36] Bug #1471868 changed: automatic reboot fails with non executable empty systemd [10:36] Bug #1473465 changed: kvm/generic-amd64: system got in a broken state in the second boot [10:36] Bug #1650671 changed: Content sharing from snap common is broken [10:39] pedronis: can you take a look at https://github.com/snapcore/snapd/pull/4844#issuecomment-384969859 ? [10:39] PR #4844: overlord/snapstate: allow core defaults configuration via 'system' key [10:39] Bug #1641132 changed: no way to include devmode snaps in snap prepare-image? [10:39] Bug #1666074 changed: Can't update "snapweb' snap [10:39] Bug #1752031 changed: core `service.ssh.disable` key not taken into account [10:41] zyga: any particular revision you'd want to me check? [10:42] Bug #1467553 changed: automatic reboot fails with zero size kernel, no watchdog in grub [10:42] Bug #1588192 changed: GL interfaces seem wedged for Krita on nvidia [10:42] [10:45] Bug #1484898 changed: device tarball needs to allow setting sysctl defaults [10:46] mvo: https://play.golang.org/p/QERhAshfyMC [10:46] best i could come up with [10:46] mborzecki-ubuntu: nope [10:46] mborzecki-ubuntu: just anything [10:46] mborzecki-ubuntu: maybe try latest stable + krita [10:48] zyga: stable is 2.32.5+18.04 (distro package) [10:48] Bug #1507693 changed: please add gdb, strace, ltrace, etc to snappy-debug [10:48] Bug #1668738 changed: core snap with configure hook fails for some people [10:51] ogra_: do you know if this is still an issue in practice? https://bugs.launchpad.net/snappy/+bug/1496141 [10:51] Bug #1496141: /etc/adduser.conf should default to use extra_users [10:51] Bug #1474463 changed: a networking service snap like xkcd doesn't wait for the server to be listening [10:53] zyga, well, the tools we use all use the --extrausers option ... switching that default would allow to avoid this [10:53] zyga: yes it would, wouldn't it [10:53] so nothing has changed but if you want to close it ... [10:53] zyga: yes, merge + massage i think, we need to move it salsa too... [10:53] mwhudson: I'm sooo out of date on this process [10:53] zyga: i think there are some new deps that need to be packaged? [10:53] mwhudson: I can merge and push my tree somewhere after some basic massaging [10:53] mwhudson: I bet [10:54] zyga: go for it! [10:55] Bug #1543764 changed: snappy classic must use officially supported lxd images from simplestream; not unsupported ones from linux-containers.org [10:55] mborzecki thank you! [10:55] zyga: it's probably easier for me to do the new packages as a DD i guess [10:56] mwhudson: yeah, for sure [10:56] mwhudson: I'll merge and see what comes out, I'm very out of touch with that aspect, I'll send you a mail with the updates (or forum thread) [10:56] zyga: +1 [10:56] zyga: i don't see any denials [10:56] * mwhudson makes a thing in a trello [10:57] need to zzz now [10:57] o/ [10:57] mvo: who maintains the classic snap [10:57] mvo: and what should it do since we now have 18 looming [10:57] zyga, mvo and me ... kind of [10:57] should it be magic smart and follow the booted base? [10:57] or ... what? [10:57] we should have a classic-18 snap i guess [10:58] Bug #1551747 changed: ubuntu-fan causes issues during network configuration Released by apw> [10:58] ogra_: but you cannot install arbitrary classic on arbitrary system, can you? [10:58] if it is suppsed do that magically we'd have to ship both chroots [10:58] (and have it pik the right one at runtime) [10:59] s/ship both/ship support for both/ [10:59] i suspect 18 looks a litte different to 16 :) [11:04] zyga: tried with "none" and NULL, no denials in either case [11:11] Thanks [11:14] hm, snapcraft still doesn't support license? [11:14] kalikiana: is this fixed or am I using it wrongly? [11:16] popey: offtopic [11:16] popey: I have https://github.com/snaphub [11:16] feels like something you should have instead [11:22] PR core#87 closed: snapcraft.yaml: update stage-packages during build [11:24] I updated 5132 based on the excellent feedback I got [11:27] looking [11:29] zyga: looks empty? [11:30] What is it (intended to be)? [11:35] I think it is very old [11:35] popey: it was supposed to be a place for snaps under shared maintenance [11:35] like snapcrafters today [11:38] mvo, I'm looking forward to seeing a dnf plugin for snapd from you :P [11:38] mborzecki: I'm not sure merging them would be useful, I would suspect people putting a copy or more stuff under system [11:40] pedronis: hm sounds fair, very well, i'll push a change replacing error with the log [11:46] Zyga feel free to delete if it's not used [11:48] popey: ack [11:57] mvo: zyga: any PR I should prioritize vs starting to look at the full queue? [11:58] pedronis: maybe pass through all simple first [11:58] to allow them to land [11:58] mborzecki, mvo: I will fix master as arch moved to a more restrictive compiler now [12:01] PR snapd#5138 opened: cmd/libsnap: fix compile error on more restrictive gcc [12:01] https://github.com/snapcore/snapd/pull/5138 [12:01] PR #5138: cmd/libsnap: fix compile error on more restrictive gcc [12:01] * zyga -> walk dog [12:08] mborzecki, hey, build fail on arch [12:08] failing [12:08] here https://api.travis-ci.org/v3/job/375775038/log.txt [12:08] cachio_: yes, zyga is working on it [12:08] mborzecki, great, thanks [12:08] i've updated to gcc 8.1 just now :) [12:09] Fixed above :-) [12:09] off to pick up my daughter [12:09] pedronis: pushed an update to #4844 [12:09] PR #4844: overlord/snapstate: allow core defaults configuration via 'system' key [12:12] PR snapd#5130 closed: interfaces/apparmor: allow bash and dash to be in /usr/bin/ === pstolowski is now known as pstolowski|lunch [12:20] zyga, you waited until Arch had it too until you'd fix the problem I've had in Fedora 28 since February? [12:20] I'm hurt :( [12:20] That is the problem? [12:21] It broke master :/) [12:21] yes [12:21] Hey jdstrand [12:21] you promised me you'd fix it back then, and you didn't :( [12:22] and you guys keep disabling the Fedora CI instead of fixing it, so I have nothing left to make you guys notice these things [12:23] Hmmm? We only disabled it when golang was broken [12:23] zyga, I've been forced to modify the autofoo to drop -Werror since February so that snapd releases would even build [12:24] I lost track of that [12:24] :'( [12:24] We should have f28 in CI [12:24] you should have Rawhide in CI too [12:24] I distinctly remember help setting that up at the last sprint [12:31] Son_Goku: heh, will look into that once the fires are out [12:32] pedronis: the 2.32 ones would be great [12:32] yay, cosmic autopkgtests are all green now [12:32] Son_Goku: so to recap (I was afk) [12:32] Son_Goku: it would be great if we had the error in CI so that it gets fixed instantly and not forgotten [12:33] Son_Goku: I'll ask if we can move to F28 testing [12:33] zyga: aha, the arch failure(s) I see right now are known and you take care of them [12:33] ? [12:33] mvo: correct [12:33] Son_Goku: I encourage you to nag us more if there's a known issue [12:33] I gave up after three weeks [12:33] zyga: ta, approved [12:34] that's why I keep doing this: https://src.fedoraproject.org/rpms/snapd/blob/master/f/snapd-2.32.4-Drop-Werror.patch [12:34] that started in 2.31.1 [12:34] Son_Goku: also the patch is pretty trivial, we could have merged it long ago [12:34] sorry for dropping it [12:34] yes, but you didn't want to [12:34] you said you'd rather fix the bugs [12:35] I mean the patch for fixing this, not dropping -Werror [12:35] cachio_: do we have a f28 image? [12:35] and of course, I keep this little bugger alive: https://src.fedoraproject.org/rpms/snapd/blob/master/f/0001-cmd-use-libtool-for-the-internal-library.patch :) [12:35] I would swap f26 for f28 (26 is about to EOL) [12:37] mvo: where shall we track bugs for classic snap? [12:37] zyga: hm, gut-feeling is lp:snapd [12:37] ah, I'm blind [12:37] https://launchpad.net/classic-snap [12:37] zyga: aha, even better [12:38] kyrofa, oh wow, many thanks for the investigation which led to https://github.com/snapcore/snapcraft/pull/2119 [12:38] PR snapcraft#2119: repo: automatically prune unneeded stage-packages [12:38] kyrofa, \o/ [12:38] mvo: we should probably rename the project a little [12:38] is this "classic dimension" [12:38] (reword) [12:39] what is the proper name for that? [12:40] hmm, github imports are failing [12:40] https://code.launchpad.net/~snappy-dev/classic-snap/master [12:41] and have failed since 2017 [12:41] ouch [12:41] Bug #1653648 changed: classic does not properly unmount /dev/pts on exist [12:41] that has been fixed ages ago [12:41] retried now [12:42] (the bug i mean, havent looked at your import above) [12:45] ogra_: can you triage https://bugs.launchpad.net/classic-snap/+bug/1653648 please [12:45] Bug #1653648: classic does not properly unmount /dev/pts on exist [12:46] zyga, i obviously did 5min ago [12:46] cjwatson: hey, would you mind helping me understand why this git import is failing https://code.launchpad.net/~snappy-dev/classic-snap/master [12:46] zyga, laos https://github.com/snapcore/classic-snap/commit/4ec9dec90c555c4c26995ca83b23a48cd61d6743 [12:46] err === pstolowski|lunch is now known as pstolowski [12:46] zyga, also https://code.launchpad.net/%7Esnappy-dev/classic-snap/+git/classic-snap/+ref/master [12:47] (sorry bad paste in the first one= [12:47] the imports work fine [12:47] ogra_: ? [12:47] zyga: missing trailing ".git" in the URL, which is needed for git-to-bzr imports. But why do you need a git-to-bzr import in the first place? [12:47] ogra_: I clicked retry and it failed once again [12:47] zyga: (I've fixed the URL) [12:47] thanks! [12:47] I wanted a git->git mirror [12:47] not a bzr import [12:47] then you did it wrong [12:47] zyga: https://help.launchpad.net/Code/Git#Mirroring_repositories_from_other_sites [12:47] ah, sorry than, let me remove that and start over [12:48] zyga, the mirrored tree is at https://code.launchpad.net/%7Esnappy-dev/classic-snap/+git/classic-snap/+ref/master [12:48] there is no bzr involved [12:49] ah, right, so just remove the git->bzr import and then there's nothing else to do [12:49] oh, and you should configure https://launchpad.net/classic-snap to have git as its default VCS [12:49] yeah, not sure where that bzr stuff comes from, the snap has worked fine for the last years [12:49] cjwatson: thanks! [12:49] done :) [12:49] (including the mirroring) [12:50] ogra_: "Created by Oliver Grawert on 2017-07-29 and last modified on 2017-07-29" is where it comes from :) [12:50] hmm [12:50] (anyway, I see it's gone now, so you probably just made a mistake and then forgot about it) [12:50] yeah [12:50] yeah, I just removed it [12:50] everything is fine now, no dead links [12:50] it didnt interfere with anything though [12:51] (and the GH README clearly points to the right urls [12:51] ) [12:52] I wonder how to clean up https://code.launchpad.net/classic-snap [12:53] why do you think thats needed ? [12:53] well, it's a bit messy [12:53] why is lp:classic-snap in "other"? [12:53] what does it even mean [12:54] mborzecki: lgtm, small comment about the message, also "core snap-id" vs "core-snap-id" [12:54] pedronis: thanks, i'll push a fix in a minute [12:55] zyga: that's a bug [12:55] but it's not something you can clean up (unless you want to fix the LP UI there) [12:57] zyga: not as simple as just filtering that out of the list though; the default repository does still need to be linked to somewhere, as there's useful information on https://code.launchpad.net/~snappy-dev/classic-snap/+git/classic-snap that's not on https://code.launchpad.net/classic-snap [12:57] I'm not totally sure whether the fix is to make that information available on https://code.launchpad.net/classic-snap (maybe in a more compact form), or to make the presentation of the link less confusing, or some combination [12:58] slightly inclined towards the former [12:58] Heya [12:59] Bug #1586248 changed: 96boards-kernel need change name [12:59] Can someone please send me an invite for the standup? The Android Hangouts app is somewhat broken still [13:00] hey zyga :) [13:06] jdstrand: hey, I'm sure you have plenty of things to catch up on, I will ask you for some reviews as you have the time (you are usually subscribed as a reviewer). How was your trip home? [13:07] zyga: I have a fairly long list of things that you asked for last week (and others). I plan to get to them this week, hopefully by tomorrow [13:07] zyga: trip home was fine, thanks. uneventful, which is just what you want :) [13:08] jdstrand: sounds good [13:08] jdstrand: just take your time to re-adjust, nothing urgent on my side [13:10] jdstrand: hey, i hope you've recovered from the sprint! will you find some time to take a look at my interface hooks PR? as i said it was reviewed a few times already, so you can probably focus on the policy aspect === Kamilion|ZNC is now known as Kamilion === TooLmaN_ is now known as TooLmaN [13:27] Wimpress: heya, did you forget to schedule a new meeting or did it get lost in my inbox? === leftyfb_ is now known as leftyfb [13:41] Bug #1738197 changed: Daemons do not have an /run/user/* dir created [13:42] Does anyone know an easy way to provision an Ubuntu Core machine with use of vSphere? [13:44] zyga: there's a couple more errors that need to be fixed in #5138 [13:44] PR #5138: cmd/libsnap: fix compile error on more restrictive gcc [13:45] zyga: https://paste.ubuntu.com/p/ztx9NMCSQ3/ [13:45] zyga: i can take over the pr in case you want to focus on something else [13:47] mborzecki: yeah, push away [13:47] I don't have the env available [13:47] ok [13:47] thanks [13:48] zyga: we should really rewrite snap-confine in go [13:48] ;) [13:49] mborzecki: it's not doable [13:49] mborzecki: unless you mean go + big C chunk that runs before main ;-) [13:49] cachio_: from my side all clear for the .6 release, we just need to ensure the store is happy and then it can go out I think [13:49] mborzecki: we can shrinkg the C parts for sure but there's no workaround otherwise [13:50] pstolowski: yes, I hope to get caught up on reviews by eod tomorrow [13:50] mvo, ok, I'll talk to the store team [13:50] zyga: iirc we discussed this a bit, i recall taking a look at libcontainer [13:51] mborzecki: really ;) [13:51] mborzecki: not doable [13:51] mborzecki: not everything can be done, I read what libcontainer does [13:52] jdstrand: thanks. we were just discussing about landing that PR now to have it in early (before next release); any comments you might have would be addressed in a followup [13:52] mborzecki: I think we should really work on removing most of the hard-coded features to profiles [13:54] Bug #1769669 opened: Snapd causes corruption on upgrade [13:54] cachio_: thank you [14:05] sitter: Oversight on my part and public holiday in the UK today. I send an invite when I'm back to work [14:07] zyga: the arch fix PR has more failures [14:07] I can paste if you want [14:09] mvo: mborzecki is fixing those [14:09] I only fixed the first one from the log [14:09] mvo, it is done [14:09] 32.6 in stable === cpaelzer_ is now known as cpaelzer [14:10] woot [14:10] thank you cachio_ [14:10] cachio_: !!! thanks [14:10] np [14:17] zyga, mborzecki out of curiosity, what version of gcc is causing these issues? [14:17] mvo: 8.0 and up [14:18] mvo: https://gcc.gnu.org/gcc-8/changes.html [14:20] mborzecki: thanks. I can reproduce with the gcc-snapshot package. but I assume you have it all under control? or want a hand? [14:21] mvo: i'll be pushing patches in a minute [14:21] mborzecki: cool [14:22] mborzecki: hey, are you handling 5138 [14:22] I can pick it up now [14:23] zyga: i have all the changes now, just rerunning make check [14:32] zyga: mvo: pushed [14:32] I saw [14:32] builds cleanly now [14:33] the last one was funny, had to run the test to check if it's actually testing the right thing [14:34] mborzecki: ta [14:34] mborzecki: was the change from * to [] needed? [14:35] mborzecki: works fine here with gcc-snapshot, thanks for the fix [14:35] zyga: yes, it's the least effort fix [14:35] mborzecki: can you explain it? [14:37] zyga: you mean in snap-test.c ? [14:37] yes [14:37] zyga: i didn't want to hardcode the size to 41, but to avoid the check for truncation i had to switch to memcpy, if someone changed the length of good_bad_name this may break the tests [14:37] * cachio_ afk [14:37] I don't mean that [14:37] I mean this specifically: [14:38] - const char *good_bad_name = "u-94903713687486543234157734673284536758"; [14:38] + const char good_bad_name[] = "u-94903713687486543234157734673284536758"; [14:38] is that for the sizeof to work? [14:38] zyga: this is to be able to do char varname[sizeof good_bad_name] = { 0 }; [14:38] zyga: yes [14:38] ok [14:38] thanks [14:38] +1 [14:38] didn't want to do alloca(strlen(good_bad..)+1) [14:50] mborzecki: I pushed a tiny extra commit as it was breaking on ubuntu with the gcc8 fixes, but now it should work everywhere [14:51] mvo: yup, works here too [14:55] yay [14:55] pstolowski: once interface hooks lands it seems it will open up a lot of its follow ups to review [14:56] pedronis: yes [14:58] * zyga needs to break now; I will be back in 3 hours to work on more things [15:00] mvo: gcc warns about unused result of those two? [15:01] zyga: chdir only, I did the rmdir for symetry [15:01] zyga: didn't warn here, but maybe there's something turned on by default in gcc-snapshot or ubuntu glibc [15:05] zyga: I think we use -Wunused-result or something, let me look [15:05] no worries, I was just curious [15:05] the patches look good [15:05] zyga: http://paste.ubuntu.com/p/B9TBshVG2n/ [15:05] zyga: just fyi [15:12] mvo: looks like something in libc then [15:15] mvo: zyga: extern int chdir (const char *__path) __THROW __nonnull ((1)) __wur; where __wur sets warn_unused_result but only if FORTIFY_LEVEL is > 0 [15:19] Bug #1769669 changed: Snapd causes corruption on upgrade [15:19] mborzecki: ok [15:35] * zyga is really off now [15:35] pedronis: you're going to make one more pass over interface hooks PR (Gustavo's comments), right? [15:37] grr, now ubuntu-18.04-64 fails in spread-shellcheck with a pip install --user error [15:37] (i.e. pip fails) [15:37] mborzecki, zyga just fyi (pr 5138) [15:37] PR #5138: cmd/libsnap: fix compile error on more restrictive gcc [15:52] pstolowski: did something change since I last looked? [15:54] sergiusens, https://forum.snapcraft.io/t/proposal-snapcraft-provides/5275 [15:55] pedronis: i've addressed the comments from Gustavo that I missed from his earlier review; and refresh was moved into separate PR. that's about it [15:56] pstolowski: ok, I will look tomorrow morning at this point, also github is giving me unicorns [15:56] pedronis: sure [16:01] kyrofa: https://github.com/snapcore/snapcraft/blob/master/TESTING.md#testing-arm === pstolowski is now known as pstolowski|afk [16:35] kyrofa: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_Server_errors [16:37] kyrofa: from http.client import responses [16:38] kyrofa: requests.status_codes.codes [18:09] PR snapcraft#2123 closed: file_utils: don't let FileNotFoundError escape [18:20] noise][: hey, I've been getting 504's on https://dashboard.snapcraft.io/reviewer/ubuntu/. https://status.snapcraft.io/ looks ok [18:49] sergiusens, I just realized the sentry Always PR got rid of the environment variable with the same functionality-- how do you anticipate making this work in CI? [18:49] I'm getting some tracebacks in CI, I'd like to set it up to automatically submit those [18:49] I suspect LP will want to do the same at some point [18:52] kyrofa: yeah, I got rid of the environment to force us into the workflow. For now you could just create the appropriate config [18:55] sergiusens, sure, just curious what the long-term plan is. Adding something like that back? [18:56] an env var is something we can add back, but I'd prefer something closer to a setting, that involves a larger/longer discussion though [19:25] out of curiosity hows this snap delay/schedule stuff coming along? Because with Gimp being a snap recommended at install time, if I was doing some design stuff (I can't design, we're talking hypothetics here) it'd be rather annoying if it suddenly stopped working or went a bit wacky cause Gimp got upgraded from under me. [19:25] thats the one that springs to mind, i'm sure you could say the same for a lot of apps [19:25] or maybe its a non issue [19:25] hence my curiosity :) [19:30] Hey magicalt1out, I think most of the snapd team is EOD already, but there is a bit of info in the forum, and you can always ask there if you need async communication === magicalt1out is now known as magicaltrout [19:41] magicaltrout: "snap revert" is supposed to be the solution to that problem. I don't 100% agree [19:50] interesting mcphail... I 100% agree with your not 100% agreeing [19:53] magicaltrout: it'll maybe be better when people start using tracks as standard. that way there might be a persistent 2.8 track [19:57] mcphail, I don't think that's what magicaltrout was asking (correct me if I'm wrong magicaltrout). The concern is that, when a snap updates, if an app is already running, it may run into issues accessing the underlying data directories with the confinement [19:58] magicaltrout, you can schedule updates today, but that ^ is still an issue for when an update _does_ happen as far as I'm aware [19:58] Unless the snap in question is classically confined [19:58] yes, that's a particularly annoying problem [20:00] although i don't know if it is such an issue for snaps with the home plug [20:03] BUG: wrong emphasis of headings on this page https://docs.snapcraft.io/build-snaps/scriptlets [20:06] om26er, what are you talking about? That's obviously on purpose. Your eyes are drawn to the emphasis, no? [20:06] *cough* [20:07] om26er, mind logging an issue here? https://github.com/canonical-docs/snappy-docs [20:07] wonder if we have a new design language ;-) [20:07] kyrofa is correct i'm curious about stuff that is up and running [20:07] Heh [20:08] kyrofa: whats this schedule stuff you speak of? [20:08] magicaltrout, let me go forum diving, hold on a sec [20:08] snap set core refresh.schedule? [20:10] magicaltrout, yeah https://forum.snapcraft.io/t/refresh-scheduling-on-specific-days-of-the-month/1239 is the first one I find [20:12] ah yeah thats cool, I'm really coming at it from a Charm angle. Because I want to ship Analytics tools and it'll be really sad for users if it updates mid workday mid month end [20:12] for example [20:12] thats cool though, i can try and set that during the install hook [20:12] Yeah I hear ya [20:22] magicaltrout: i'm poking the devs about this :) https://forum.snapcraft.io/t/bug-saves-are-blocked-to-snap-user-data-if-snap-updates-when-it-is-already-running/3226 [20:24] mcphail, ah, yes [20:25] * mcphail feels it is his role to be an annoyance ;) [20:40] annoyances ensure the useful stuff not just the fun stuff gets implemented ;) === ubott2 is now known as ubottu === cwayne_ is now known as cwayne === JamieBennett_ is now known as JamieBennett === cprov_ is now known as cprov === popey_ is now known as popey === tedg_ is now known as tedg === blackboxsw_ is now known as blackboxsw === rsalveti_ is now known as rsalveti === tai271828_ is now known as tai271828 === Faults_ is now known as Faults === Wimpress_ is now known as Wimpress [21:34] PR snapcraft#2115 closed: storeapi: ensure snap ID is sane before using it [23:36] pbek: just noticed you have old versions in beta/candidate/edge of qownnotes [23:37] pbek: you can 'snapcraft close beta' for example to nudge people towards stable (and thus the latest build) [23:37] (same for the other channels)