[04:05] <cjwatson> mcphail: snapcraft's README.md refers to the Launchpad one
[05:06] <mborzecki> morning
[05:34] <mborzecki> mvo: hey, how are things?
[05:45] <zyga> Good morning
[05:45] <mborzecki> zyga: hey
[05:46] <mborzecki> zyga: i see we made it to 2.32.6
[05:50] <mvo> hey zyga and mborzecki !
[05:50] <mborzecki> mvo: morning
[05:51] <mborzecki> mvo: how was the sprint?
[05:52]  * zyga -> walk
[05:52] <mvo> mborzecki: it was good
[05:52] <mvo> mborzecki: no surprises, focus for the next couple of weeks is making core18 bootable and working on the upgrade path
[05:52] <mborzecki> mvo: any updates to the roadmap then?
[05:52] <mvo> mborzecki: but we knew that :)
[05:53] <mvo> mborzecki: nothing new in the roadmap I think
[05:54] <mvo> mborzecki: we will need to do a .7 to fix an important usecase (two PRs up for that already)
[05:54] <mvo> mborzecki: and then we are hopefully fully back to 2.33
[05:54] <zyga> Oh
[05:54] <zyga> What is for .7?
[05:54] <mborzecki> hm and i thought we were done with .6 :)
[05:54] <mvo> zyga: a systemd target for when the system is fully seeded
[05:54] <mvo> zyga: and a way for snaps to declare an "after: snapd.seeded"
[05:55] <mvo> zyga: it is important for some 18.04 cloud image use-cases
[05:55] <mvo> mborzecki: I thought so too :) but then reality disagreeded
[05:55] <mvo> I think its pretty straightforward, it will need a design ACK from gustavo though
[05:56] <zyga> I See
[05:57] <mborzecki> mvo: a target taget? as in snapd.seeded.target?
[05:57] <mvo> mborzecki: correct
[05:57] <mvo> mborzecki: so that a unit can say "after=snapd.seeded.service"
[05:59] <mvo> mborzecki: there is a PR up for this (5124) but it was written during the sprint so an extra careful review is needed :)
[05:59] <mvo> the other one is 5132 and we will need 5133 for cosmic
[06:09] <mup> PR snapd#5136 opened: tests: ubuntu 18.04 or higher does not need linux-image-extra- <Created by mvo5> <https://github.com/snapcore/snapd/pull/5136>
[06:26] <mup> PR snapd#5128 closed: Revert "Skip test lp-1721518 for arch, snapd is failing to start afte… <Simple> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5128>
[06:29] <mup> PR snapd#5121 closed: interfaces:minor autoconnect cleanup <Simple> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5121>
[06:36] <mup> PR snapd#5069 closed: configcore: validate experimental.layouts option <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5069>
[06:44]  * zyga is back home and working now
[06:44] <zyga> my whole desk was covered with yellow powder
[06:45] <zyga> something must be blooming nearby
[06:45] <zyga> yuck
[06:48]  * zyga catches up with email
[06:49] <zyga> mvo: please ping me if something urgent is needed, I will start hacking at around noon, I need to get my inbox under control
[06:54] <mvo> zyga: I will focus on .7 this morning and trying to make sure autopkgtests and spread is happy
[06:55] <mvo> zyga: 5131 needs a second review but its pretty trivial and can probably go in with a single review even
[06:55] <mvo> zyga: I got this error in one of my PRs so it might be a prereq for landing the 2.32 ones
[06:58] <zyga> mvo: FYI, I think there's a real error that affects debian
[06:58] <zyga> mvo: but it's rare
[06:58] <zyga> mvo: if you see a network-bind or network test fail there, that's it
[06:58] <zyga> it looks like we become unconfined in some situations
[06:59] <mup> PR snapd#5136 closed: tests: ubuntu 18.04 or higher does not need linux-image-extra- <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5136>
[07:00] <zyga> mvo: btw, do you know what is cosmic?
[07:00] <zyga> cosmic ... c-what?
[07:00] <mvo> zyga: I don't
[07:00] <mborzecki> zyga: canimal?
[07:00] <mvo> zyga: cockroach maybe
[07:01] <zyga> mborzecki: no :)
[07:01] <mvo> or maybe canibal
[07:01] <mborzecki> haha
[07:01] <mborzecki> canibal cockroach
[07:01] <mborzecki> sounds like a great name for a death metal band ;)
[07:02] <mvo> lol
[07:02] <zyga> cosmic cosmonaut would be nice
[07:02] <zyga> humans are animals too
[07:02] <mvo> I like cosmonaut!
[07:04] <pstolowski> mornings!
[07:04] <mvo> hey pstolowski good morning and welcome back
[07:04] <pstolowski> how was the sprint?
[07:05] <mborzecki> pstolowski: morning
[07:05] <zyga> good morning pawel
[07:05] <mvo> pstolowski: good, no surprises, roadmap is pretty much what we discussed already
[07:12] <mborzecki> arch package bumped to 2.32.6
[07:13] <mborzecki> and wow, we have quite a lot of open PRs
[07:14] <mup> PR snapd#5135 closed: Docs moved to forum <Created by abitrolly> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5135>
[07:15] <mborzecki> need coffee
[07:15] <mup> PR snapd#5133 closed: spread.yaml: add cosmic (18.10) to autopkgtest/qemu <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5133>
[07:28] <mborzecki> zyga: regarding #1769203, haven't we looked at auto mounting snaps via .automount unit files?
[07:28] <mup> Bug #1769203: every revision of snaps are mounted <amd64> <apport-bug> <bionic> <wayland-session> <snapd (Ubuntu):Invalid> <https://launchpad.net/bugs/1769203>
[07:29] <zyga> mborzecki: I mentioned this and I think gustavo was sceptical about it
[07:33] <mborzecki> zyga: do you recall what was his reasoning?
[07:37] <mvo> mborzecki: we did use automount a long time ago, it may even be in the git history (a looooong time ago, very early days of the project)
[07:37] <zyga> mborzecki: that it is not fully transparent
[07:37] <zyga> mborzecki: you can observe automount points
[07:37] <zyga> mborzecki: you can unmount them to break them
[07:38] <mvo> zyga: hm, unmount them to break them is also true for .mount services, no?
[07:40] <mup> PR snapd#5131 closed: tests: fix interfaces-network test for systems with partial confinement <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5131>
[08:06] <zyga> mvo: are we pushing .6 to stable
[08:25] <pstolowski> zyga: is there any concern still about https://github.com/snapcore/snapd/pull/5075 ?
[08:25] <mup> PR #5075: snap/env: fix env duplication logic <Simple> <Created by didrocks> <https://github.com/snapcore/snapd/pull/5075>
[08:30] <mvo> zyga: yes, today when cachio is around (probably after the standup
[08:30] <zyga> mvo: brilliant
[08:32] <mvo> zyga: is there any work to make 2.32 tested again that I can build upon? or just go over the master PRs and cherry-pick the right stuff?
[08:35] <mvo> btw, a review for 5132 would be great. it need a final +1 from niemeyer to ensure he is happy with the language but beside that it should be ready for review
[08:42] <zyga> doing
[08:43] <mvo> ta
[08:52] <zyga> mvo: done
[08:56] <mvo> ta
[09:06] <mup> PR snapd#5137 opened: tests: cherry-pick commits to move spread to google backend <Created by mvo5> <https://github.com/snapcore/snapd/pull/5137>
[09:14] <zyga> hmmmmm
[09:14] <zyga> mvo: I have a debian 10 vm with two snaps but no core
[09:14]  * zyga wonders how that happened
[09:15] <zyga> snap changes from debian 10 https://www.irccloud.com/pastebin/oU28h1jS/
[09:15]  * mvo hugs mborzecki and zyga for the excellent review in 5131
[09:16] <mvo> zyga: strange, what version of snapd is running?
[09:22] <zyga> 2.30
[09:23] <zyga> 3.30-5+b1
[09:38] <zyga> mwhudson: hey
[09:38] <zyga> mwhudson: not super urgent but it would be good to update snapd in debian to 2.32.6 or .7
[09:39] <zyga> mwhudson: also (as before) not sure how to maintain this package
[09:40] <zyga> mwhudson: what is the process for doing a new release? merge upstream and massage?
[09:43] <mvo> we should also check if re-exec is enabled
[09:44] <mvo> yay, cosmic autopkgtest for ppc64/s390x is green
[09:55] <zyga> mborzecki: are you running arch or ubuntu now
[09:55] <zyga> mborzecki: I may need your help
[09:55] <mborzecki> arch
[09:56] <mborzecki> zyga: what do you need help with?
[09:56] <mup> Bug #1593141 changed: Each run of a snap app leak directories in /tmp <snapd:Fix Released> <https://launchpad.net/bugs/1593141>
[09:57] <zyga> mborzecki: there's a bug, I cannot find it now
[09:57] <zyga> maybe on the forum, maybe on laucnhpad
[09:57] <zyga> it relates to this call
[09:57] <mup> PR snapd#5137 closed: tests: cherry-pick commits to move spread to google backend <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5137>
[09:58] <zyga> https://www.irccloud.com/pastebin/Wygky688/
[09:58] <zyga> someone got a denial on that
[09:58] <zyga> I wonder if the "none" is significant
[09:58] <zyga> can you see if you got that denial?
[09:58]  * zyga boots 18.04 live usb to test something else
[10:00] <zyga> wow, I didn't know there are so many snaps on the live ISO
[10:00] <mborzecki> zyga: ok, let me sync some stuff first
[10:01] <zyga> mborzecki: thanks
[10:01] <zyga> snap list truncates "tracking" too much
[10:03] <mup> PR snapd#5129 closed: cmd/snap-confine: allow any base snap to provide /etc/alternatives <Simple> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5129>
[10:03] <zyga> mvo: thank you
[10:03] <zyga> mvo: I was working on a new base snap last weekend
[10:03] <zyga> mvo: I ran into a serious bug, I didn't manage to debug it yet though
[10:04] <mvo> zyga: oh? ok - anything you can share?
[10:04] <mvo> zyga: what was the error etc?
[10:04] <zyga> mvo: snaps based on that snap didn't start at all, something wrong in the deep guts of snap-confine
[10:04] <zyga> I didn't get to the bottom of it, I can share later today if you want to play
[10:07] <zyga> some issues from the live ISO
[10:08] <zyga> failed refresh on live iso https://www.irccloud.com/pastebin/bLhbMBWf/
[10:08] <zyga> failed mount on live iso (curious) https://www.irccloud.com/pastebin/h2R6g2mI/
[10:09] <pedronis> afaik refreshes are not working on the live image, that's why they asked us how to turn them off
[10:09] <zyga> ureadahead is creazy on the live iso, spamming with errors
[10:09] <zyga> pedronis: they work on 2nd try
[10:10] <pedronis> what I mean, afaik they are not expected to work
[10:10] <zyga> I see
[10:11] <pedronis> I don't know the details, but they didn't ask to help fix them, but how to turn off auto-refreshes
[10:11] <pedronis> I think there's a basic space problem as well
[10:15] <mup> Bug #1443612 changed: please set /run/shm/snaps/@{APP_PKGNAME}/@{APP_VERSION}/ for apps <Snappy:Won't Fix> <https://launchpad.net/bugs/1443612>
[10:18] <mup> Bug #1650389 changed: Installing snapd on 14.04.5 desktop downgrades xorg et al. <14.04> <Snappy:Invalid> <systemd (Ubuntu):Fix Committed by thomas-voss> <systemd (Ubuntu Trusty):Fix Committed by thomas-voss> <https://launchpad.net/bugs/1650389>
[10:21] <mup> Bug #1659924 changed: Snap failures in 16.04 <Snappy:Fix Released> <https://launchpad.net/bugs/1659924>
[10:30] <mborzecki> mvo: damn, that template is tricky
[10:30] <mup> Bug #1458866 changed: hangs in uboot boot prompt if dtbs dir is missing <Snappy:Won't Fix> <https://launchpad.net/bugs/1458866>
[10:33] <mcphail> cjwatson: thanks. that's the one i've used
[10:33] <mup> Bug #1464396 changed: "sudo: unable to resolve host ..." when custom hostname is used. <Snappy:Won't Fix> <https://launchpad.net/bugs/1464396>
[10:36] <mup> Bug #1471868 changed: automatic reboot fails with non executable empty systemd <snappy-robustness> <Snappy:Won't Fix> <https://launchpad.net/bugs/1471868>
[10:36] <mup> Bug #1473465 changed: kvm/generic-amd64: system got in a broken state in the second boot <Snappy:Won't Fix> <Snappy 15.04:Won't Fix> <Snappy trunk:Won't Fix> <https://launchpad.net/bugs/1473465>
[10:36] <mup> Bug #1650671 changed: Content sharing from snap common is broken <Snappy:Fix Released by zyga> <https://launchpad.net/bugs/1650671>
[10:39] <mborzecki> pedronis: can you take a look at https://github.com/snapcore/snapd/pull/4844#issuecomment-384969859 ?
[10:39] <mup> PR #4844: overlord/snapstate: allow core defaults configuration via 'system' key <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4844>
[10:39] <mup> Bug #1641132 changed: no way to include devmode snaps in snap prepare-image? <personal> <Snappy:Won't Fix by mvo> <Ubuntu Image:Expired> <https://launchpad.net/bugs/1641132>
[10:39] <mup> Bug #1666074 changed: Can't update "snapweb' snap <snapweb:Fix Released by abreu-alexandre> <https://launchpad.net/bugs/1666074>
[10:39] <mup> Bug #1752031 changed: core `service.ssh.disable` key not taken into account <Snappy:Fix Released> <https://launchpad.net/bugs/1752031>
[10:41] <mborzecki-ubuntu> zyga: any particular revision you'd want to me check?
[10:42] <mup> Bug #1467553 changed: automatic reboot fails with zero size kernel, no watchdog in grub <snappy-robustness> <snapd:Triaged> <https://launchpad.net/bugs/1467553>
[10:42] <mup> Bug #1588192 changed: GL interfaces seem wedged for Krita on nvidia <patch> <Snappy:Fix Released> <nvidia-graphics-drivers-304 (Ubuntu):In Progress by albertomilone> <nvidia-graphics-drivers-340 (Ubuntu):Won't Fix by albertomilone> <nvidia-graphics-drivers-361 (Ubuntu):Won't Fix by albertomilone>
[10:42] <mup> <nvidia-graphics-drivers-304 (Ubuntu Xenial):In Progress by albertomilone> <nvidia-graphics-drivers-340 (Ubuntu Xenial):Won't Fix by albertomilone> <nvidia-graphics-drivers-361 (Ubuntu Xenial):Won't Fix by albertomilone> <https://launchpad.net/bugs/1588192>
[10:45] <mup> Bug #1484898 changed: device tarball needs to allow setting sysctl defaults <Snappy:Won't Fix> <https://launchpad.net/bugs/1484898>
[10:46] <mborzecki> mvo: https://play.golang.org/p/QERhAshfyMC
[10:46] <mborzecki> best i could come up with
[10:46] <zyga> mborzecki-ubuntu: nope
[10:46] <zyga> mborzecki-ubuntu: just anything
[10:46] <zyga> mborzecki-ubuntu: maybe try latest stable + krita
[10:48] <mborzecki-ubuntu> zyga: stable is 2.32.5+18.04 (distro package)
[10:48] <mup> Bug #1507693 changed: please add gdb, strace, ltrace, etc to snappy-debug <Snappy:Invalid> <https://launchpad.net/bugs/1507693>
[10:48] <mup> Bug #1668738 changed: core snap with configure hook fails for some people <Snappy:Fix Released> <https://launchpad.net/bugs/1668738>
[10:51] <zyga> ogra_: do you know if this is still an issue in practice? https://bugs.launchpad.net/snappy/+bug/1496141
[10:51] <mup> Bug #1496141: /etc/adduser.conf should default to use extra_users <Snappy:Confirmed for ogra> <https://launchpad.net/bugs/1496141>
[10:51] <mup> Bug #1474463 changed: a networking service snap like xkcd doesn't wait for the server to be listening <Snappy:Won't Fix> <https://launchpad.net/bugs/1474463>
[10:53] <ogra_> zyga, well, the tools we use all use the --extrausers option ... switching that default would allow to avoid this
[10:53] <mwhudson> zyga: yes it would, wouldn't it
[10:53] <ogra_> so nothing has changed but if you want to close it ...
[10:53] <mwhudson> zyga: yes, merge + massage i think, we need to move it salsa too...
[10:53] <zyga> mwhudson: I'm sooo out of date on this process
[10:53] <mwhudson> zyga: i think there are some new deps that need to be packaged?
[10:53] <zyga> mwhudson: I can merge and push my tree somewhere after some basic massaging
[10:53] <zyga> mwhudson: I bet
[10:54] <mwhudson> zyga: go for it!
[10:55] <mup> Bug #1543764 changed: snappy classic must use officially supported lxd images from simplestream; not unsupported ones from linux-containers.org <Snappy:Invalid by mvo> <https://launchpad.net/bugs/1543764>
[10:55] <mvo> mborzecki thank you!
[10:55] <mwhudson> zyga: it's probably easier for me to do the new packages as a DD i guess
[10:56] <zyga> mwhudson: yeah, for sure
[10:56] <zyga> mwhudson: I'll merge and see what comes out, I'm very out of touch with that aspect, I'll send you a mail with the updates (or forum thread)
[10:56] <mwhudson> zyga: +1
[10:56] <mborzecki-ubuntu> zyga: i don't see any denials
[10:56]  * mwhudson makes a thing in a trello
[10:57] <mwhudson> need to zzz now
[10:57] <zyga> o/
[10:57] <zyga> mvo: who maintains the classic snap
[10:57] <zyga> mvo: and what should it do since we now have 18 looming
[10:57] <ogra_> zyga, mvo and me ... kind of
[10:57] <zyga> should it be magic smart and follow the booted base?
[10:57] <zyga> or ... what?
[10:57] <ogra_> we should have a classic-18 snap i guess
[10:58] <mup> Bug #1551747 changed: ubuntu-fan causes issues during network configuration <verification-done> <cloud-init:Invalid> <Snappy:Invalid> <ubuntu-fan (Ubuntu):Fix
[10:58] <mup> Released by apw> <ubuntu-fan (Ubuntu Xenial):Fix Released by apw> <ubuntu-fan (Ubuntu Yakkety):Fix Released by apw> <https://launchpad.net/bugs/1551747>
[10:58] <zyga> ogra_: but you cannot install arbitrary classic on arbitrary system, can you?
[10:58] <ogra_> if it is suppsed do that magically we'd have to ship both chroots
[10:58] <ogra_> (and have it pik the right one at runtime)
[10:59] <ogra_> s/ship both/ship support for both/
[10:59] <ogra_> i suspect 18 looks a litte different to 16 :)
[11:04] <mborzecki-ubuntu> zyga: tried with "none" and NULL, no denials in either case
[11:11] <zyga> Thanks
[11:14] <zyga> hm, snapcraft still doesn't support license?
[11:14] <zyga> kalikiana: is this fixed or am I using it wrongly?
[11:16] <zyga> popey: offtopic
[11:16] <zyga> popey: I have https://github.com/snaphub
[11:16] <zyga> feels like something you should have instead
[11:22] <mup> PR core#87 closed: snapcraft.yaml: update stage-packages during build <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/core/pull/87>
[11:24] <mvo> I updated 5132 based on the excellent feedback I got
[11:27] <zyga> looking
[11:29] <popey> zyga: looks empty?
[11:30] <popey> What is it (intended to be)?
[11:35] <zyga> I think it is very old
[11:35] <zyga> popey: it was supposed to be a place for snaps under shared maintenance
[11:35] <zyga> like snapcrafters today
[11:38] <Son_Goku> mvo, I'm looking forward to seeing a dnf plugin for snapd from you :P
[11:38] <pedronis> mborzecki: I'm not sure merging them would be useful, I would suspect people putting a copy or more stuff under system
[11:40] <mborzecki> pedronis: hm sounds fair, very well, i'll push a change replacing error with the log
[11:46] <popey> Zyga feel free to delete if it's not used
[11:48] <zyga> popey: ack
[11:57] <pedronis> mvo: zyga: any PR I should prioritize vs starting to look at the full queue?
[11:58] <zyga> pedronis: maybe pass through all simple first
[11:58] <zyga> to allow them to land
[11:58] <zyga> mborzecki, mvo: I will fix master as arch moved to a more restrictive compiler now
[12:01] <mup> PR snapd#5138 opened: cmd/libsnap: fix compile error on more restrictive gcc <Critical> <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5138>
[12:01] <zyga> https://github.com/snapcore/snapd/pull/5138
[12:01] <mup> PR #5138: cmd/libsnap: fix compile error on more restrictive gcc <Critical> <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5138>
[12:01]  * zyga -> walk dog
[12:08] <cachio_> mborzecki, hey, build fail on arch
[12:08] <cachio_>  failing
[12:08] <cachio_> here https://api.travis-ci.org/v3/job/375775038/log.txt
[12:08] <mborzecki> cachio_: yes, zyga is working on it
[12:08] <cachio_> mborzecki, great, thanks
[12:08] <mborzecki> i've updated to gcc 8.1 just now :)
[12:09] <zyga> Fixed above :-)
[12:09] <mborzecki> off to pick up my daughter
[12:09] <mborzecki> pedronis: pushed an update to #4844
[12:09] <mup> PR #4844: overlord/snapstate: allow core defaults configuration via 'system' key <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4844>
[12:12] <mup> PR snapd#5130 closed: interfaces/apparmor: allow bash and dash to be in /usr/bin/ <Simple> <Created by zyga> <Merged by jdstrand> <https://github.com/snapcore/snapd/pull/5130>
[12:20] <Son_Goku> zyga, you waited until Arch had it too until you'd fix the problem I've had in Fedora 28 since February?
[12:20] <Son_Goku> I'm hurt :(
[12:20] <zyga> That is the problem?
[12:21] <zyga> It broke master :/)
[12:21] <Son_Goku> yes
[12:21] <zyga> Hey jdstrand
[12:21] <Son_Goku> you promised me you'd fix it back then, and you didn't :(
[12:22] <Son_Goku> and you guys keep disabling the Fedora CI instead of fixing it, so I have nothing left to make you guys notice these things
[12:23] <zyga> Hmmm? We only disabled it when golang was broken
[12:23] <Son_Goku> zyga, I've been forced to modify the autofoo to drop -Werror since February so that snapd releases would even build
[12:24] <zyga> I lost track of that
[12:24] <Son_Goku> :'(
[12:24] <zyga> We should have f28 in CI
[12:24] <Son_Goku> you should have Rawhide in CI too
[12:24] <Son_Goku> I distinctly remember help setting that up at the last sprint
[12:31] <mvo> Son_Goku: heh, will look into that once the fires are out
[12:32] <mvo> pedronis: the 2.32 ones would be great
[12:32] <mvo> yay, cosmic autopkgtests are all green now
[12:32] <zyga> Son_Goku: so to recap (I was afk)
[12:32] <zyga> Son_Goku: it would be great if we had the error in CI so that it gets fixed instantly and not forgotten
[12:33] <zyga> Son_Goku: I'll ask if we can move to F28 testing
[12:33] <mvo> zyga: aha, the arch failure(s) I see right now are known and you take care of them
[12:33] <mvo> ?
[12:33] <zyga> mvo: correct
[12:33] <zyga> Son_Goku: I encourage you to nag us more if there's a known issue
[12:33] <Son_Goku> I gave up after three weeks
[12:33] <mvo> zyga: ta, approved
[12:34] <Son_Goku> that's why I keep doing this: https://src.fedoraproject.org/rpms/snapd/blob/master/f/snapd-2.32.4-Drop-Werror.patch
[12:34] <Son_Goku> that started in 2.31.1
[12:34] <zyga> Son_Goku: also the patch is pretty trivial, we could have merged it long ago
[12:34] <zyga> sorry for dropping it
[12:34] <Son_Goku> yes, but you didn't want to
[12:34] <Son_Goku> you said you'd rather fix the bugs
[12:35] <zyga> I mean the patch for fixing this, not dropping -Werror
[12:35] <zyga> cachio_: do we have a f28 image?
[12:35] <Son_Goku> and of course, I keep this little bugger alive: https://src.fedoraproject.org/rpms/snapd/blob/master/f/0001-cmd-use-libtool-for-the-internal-library.patch :)
[12:35] <zyga> I would swap f26 for f28 (26 is about to EOL)
[12:37] <zyga> mvo: where shall we track bugs for classic snap?
[12:37] <mvo> zyga: hm, gut-feeling is lp:snapd
[12:37] <zyga> ah, I'm blind
[12:37] <zyga> https://launchpad.net/classic-snap
[12:37] <mvo> zyga: aha, even better
[12:38] <thresh> kyrofa, oh wow, many thanks for the investigation which led to https://github.com/snapcore/snapcraft/pull/2119
[12:38] <mup> PR snapcraft#2119: repo: automatically prune unneeded stage-packages <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/2119>
[12:38] <thresh> kyrofa, \o/
[12:38] <zyga> mvo: we should probably rename the project a little
[12:38] <zyga> is this "classic dimension"
[12:38] <zyga> (reword)
[12:39] <zyga> what is the proper name for that?
[12:40] <zyga> hmm, github imports are failing
[12:40] <zyga> https://code.launchpad.net/~snappy-dev/classic-snap/master
[12:41] <zyga> and have failed since 2017
[12:41] <zyga> ouch
[12:41] <mup> Bug #1653648 changed: classic does not properly unmount /dev/pts on exist <Classic dimension for snappy:New for ogra> <https://launchpad.net/bugs/1653648>
[12:41] <ogra_> that has been fixed ages ago
[12:41] <zyga> retried now
[12:42] <ogra_> (the bug i mean, havent looked at your import above)
[12:45] <zyga> ogra_: can you triage https://bugs.launchpad.net/classic-snap/+bug/1653648 please
[12:45] <mup> Bug #1653648: classic does not properly unmount /dev/pts on exist <Classic dimension for snappy:Fix Released by ogra> <https://launchpad.net/bugs/1653648>
[12:46] <ogra_> zyga, i obviously did 5min ago
[12:46] <zyga> cjwatson: hey, would you mind helping me understand why this git import is failing https://code.launchpad.net/~snappy-dev/classic-snap/master
[12:46] <ogra_> zyga, laos https://github.com/snapcore/classic-snap/commit/4ec9dec90c555c4c26995ca83b23a48cd61d6743
[12:46] <ogra_> err
[12:46] <ogra_> zyga, also https://code.launchpad.net/%7Esnappy-dev/classic-snap/+git/classic-snap/+ref/master
[12:47] <ogra_> (sorry bad paste in the first one=
[12:47] <ogra_> the imports work fine
[12:47] <zyga> ogra_: ?
[12:47] <cjwatson> zyga: missing trailing ".git" in the URL, which is needed for git-to-bzr imports.  But why do you need a git-to-bzr import in the first place?
[12:47] <zyga> ogra_: I clicked retry and it failed once again
[12:47] <cjwatson> zyga: (I've fixed the URL)
[12:47] <zyga> thanks!
[12:47] <zyga> I wanted a git->git mirror
[12:47] <zyga> not a bzr import
[12:47] <cjwatson> then you did it wrong
[12:47] <cjwatson> zyga: https://help.launchpad.net/Code/Git#Mirroring_repositories_from_other_sites
[12:47] <zyga> ah, sorry than, let me remove that and start over
[12:48] <ogra_> zyga, the mirrored tree is at https://code.launchpad.net/%7Esnappy-dev/classic-snap/+git/classic-snap/+ref/master
[12:48] <ogra_> there is no bzr involved
[12:49] <cjwatson> ah, right, so just remove the git->bzr import and then there's nothing else to do
[12:49] <cjwatson> oh, and you should configure https://launchpad.net/classic-snap to have git as its default VCS
[12:49] <ogra_> yeah, not sure where that bzr stuff comes from, the snap has worked fine for the last years
[12:49] <zyga> cjwatson: thanks!
[12:49] <zyga> done :)
[12:49] <ogra_> (including the mirroring)
[12:50] <cjwatson> ogra_: "Created by Oliver Grawert on 2017-07-29 and last modified on 2017-07-29" is where it comes from :)
[12:50] <ogra_> hmm
[12:50] <cjwatson> (anyway, I see it's gone now, so you probably just made a mistake and then forgot about it)
[12:50] <ogra_> yeah
[12:50] <zyga> yeah, I just removed it
[12:50] <zyga> everything is fine now, no dead links
[12:50] <ogra_> it didnt interfere with anything though
[12:51] <ogra_> (and the GH README clearly points to the right urls
[12:51] <ogra_> )
[12:52] <zyga> I wonder how to clean up https://code.launchpad.net/classic-snap
[12:53] <ogra_> why do you think thats needed ?
[12:53] <zyga> well, it's a bit messy
[12:53] <zyga> why is lp:classic-snap in "other"?
[12:53] <zyga> what does it even mean
[12:54] <pedronis> mborzecki: lgtm, small comment about the message,  also  "core snap-id"   vs "core-snap-id"
[12:54] <mborzecki> pedronis: thanks, i'll push a fix in a minute
[12:55] <cjwatson> zyga: that's a bug
[12:55] <cjwatson> but it's not something you can clean up (unless you want to fix the LP UI there)
[12:57] <cjwatson> zyga: not as simple as just filtering that out of the list though; the default repository does still need to be linked to somewhere, as there's useful information on https://code.launchpad.net/~snappy-dev/classic-snap/+git/classic-snap that's not on https://code.launchpad.net/classic-snap
[12:57] <cjwatson> I'm not totally sure whether the fix is to make that information available on https://code.launchpad.net/classic-snap (maybe in a more compact form), or to make the presentation of the link less confusing, or some combination
[12:58] <cjwatson> slightly inclined towards the former
[12:58] <niemeyer> Heya
[12:59] <mup> Bug #1586248 changed: 96boards-kernel need change name <Snapcraft:Invalid> <Snappy:Fix Released> <https://launchpad.net/bugs/1586248>
[12:59] <niemeyer> Can someone please send me an invite for the standup? The Android Hangouts app is somewhat broken still
[13:00] <jdstrand> hey zyga :)
[13:06] <zyga> jdstrand: hey, I'm sure you have plenty of things to catch up on, I will ask you for some reviews as you have the time (you are usually subscribed as a reviewer). How was your trip home?
[13:07] <jdstrand> zyga: I have a fairly long list of things that you asked for last week (and others). I plan to get to them this week, hopefully by tomorrow
[13:07] <jdstrand> zyga: trip home was fine, thanks. uneventful, which is just what you want :)
[13:08] <zyga> jdstrand: sounds good
[13:08] <zyga> jdstrand: just take your time to re-adjust, nothing urgent on my side
[13:10] <pstolowski> jdstrand: hey, i hope you've recovered from the sprint! will you find some time to take a look at my interface hooks PR? as i said it was reviewed a few times already, so you can probably focus on the policy aspect
[13:27] <sitter> Wimpress: heya, did you forget to schedule a new meeting or did it get lost in my inbox?
[13:41] <mup> Bug #1738197 changed: Daemons do not have an /run/user/* dir created <snapd:Confirmed> <https://launchpad.net/bugs/1738197>
[13:42] <nodeman> Does anyone know an easy way to provision an Ubuntu Core machine with use of vSphere?
[13:44] <mborzecki> zyga: there's a couple more errors that need to be fixed in #5138
[13:44] <mup> PR #5138: cmd/libsnap: fix compile error on more restrictive gcc <Critical> <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5138>
[13:45] <mborzecki> zyga: https://paste.ubuntu.com/p/ztx9NMCSQ3/
[13:45] <mborzecki> zyga: i can take over the pr in case you want to focus on something else
[13:47] <zyga> mborzecki: yeah, push away
[13:47] <zyga> I don't have the env available
[13:47] <mborzecki> ok
[13:47] <zyga> thanks
[13:48] <mborzecki> zyga: we should really rewrite snap-confine in go
[13:48] <mborzecki> ;)
[13:49] <zyga> mborzecki: it's not doable
[13:49] <zyga> mborzecki: unless you mean go + big C chunk that runs before main ;-)
[13:49] <mvo> cachio_: from my side all clear for the .6 release, we just need to ensure the store is happy and then it can go out I think
[13:49] <zyga> mborzecki: we can shrinkg the C parts for sure but there's no workaround otherwise
[13:50] <jdstrand> pstolowski: yes, I hope to get caught up on reviews by eod tomorrow
[13:50] <cachio_> mvo, ok, I'll talk to the store team
[13:50] <mborzecki> zyga: iirc we discussed this a bit, i recall taking a look at libcontainer
[13:51] <zyga> mborzecki: really ;)
[13:51] <zyga> mborzecki: not doable
[13:51] <zyga> mborzecki: not everything can be done, I read what libcontainer does
[13:52] <pstolowski> jdstrand: thanks. we were just discussing about landing that PR now to have it in early (before next release); any comments you might have would be addressed in a followup
[13:52] <zyga> mborzecki: I think we should really work on removing most of the hard-coded features to profiles
[13:54] <mup> Bug #1769669 opened: Snapd causes corruption on upgrade  <Snappy:New> <https://launchpad.net/bugs/1769669>
[13:54] <mvo> cachio_: thank you
[14:05] <Wimpress> sitter: Oversight on my part and public holiday in the UK today. I send an invite when I'm back to work
[14:07] <mvo> zyga: the arch fix PR has more failures
[14:07] <mvo> I can paste if you want
[14:09] <zyga> mvo: mborzecki is fixing those
[14:09] <zyga> I only fixed the first one from the log
[14:09] <cachio_> mvo, it is done
[14:09] <cachio_> 32.6 in stable
[14:10] <zyga> woot
[14:10] <zyga> thank you cachio_
[14:10] <mvo> cachio_: !!! thanks
[14:10] <cachio_> np
[14:17] <mvo> zyga, mborzecki out of curiosity, what version of gcc is causing these issues?
[14:17] <mborzecki> mvo: 8.0 and up
[14:18] <mborzecki> mvo: https://gcc.gnu.org/gcc-8/changes.html
[14:20] <mvo> mborzecki: thanks. I can reproduce with the gcc-snapshot package. but I assume you have it all under control? or want a hand?
[14:21] <mborzecki> mvo: i'll be pushing patches in a minute
[14:21] <mvo> mborzecki: cool
[14:22] <zyga> mborzecki: hey, are you handling 5138
[14:22] <zyga> I can pick it up now
[14:23] <mborzecki> zyga: i have all the changes now, just rerunning make check
[14:32] <mborzecki> zyga: mvo: pushed
[14:32] <zyga> I saw
[14:32] <mborzecki> builds cleanly now
[14:33] <mborzecki> the last one was funny, had to run the test to check if it's actually testing the right thing
[14:34] <mvo> mborzecki: ta
[14:34] <zyga> mborzecki: was the change from * to [] needed?
[14:35] <mvo> mborzecki: works fine here with gcc-snapshot, thanks for the fix
[14:35] <mborzecki> zyga: yes, it's the least effort fix
[14:35] <zyga> mborzecki: can you explain it?
[14:37] <mvo> zyga: you mean in snap-test.c ?
[14:37] <zyga> yes
[14:37] <mborzecki> zyga: i didn't want to hardcode the size to 41, but to avoid the check for truncation i had to switch to memcpy, if someone changed the length of good_bad_name this may break the tests
[14:37]  * cachio_ afk
[14:37] <zyga> I don't mean that
[14:37] <zyga> I mean this specifically:
[14:38] <zyga> - const char *good_bad_name = "u-94903713687486543234157734673284536758";
[14:38] <zyga> +	const char good_bad_name[] = "u-94903713687486543234157734673284536758";
[14:38] <zyga> is that for the sizeof to work?
[14:38] <mborzecki> zyga: this is to be able to do char varname[sizeof good_bad_name] = { 0 };
[14:38] <mborzecki> zyga: yes
[14:38] <zyga> ok
[14:38] <zyga> thanks
[14:38] <zyga> +1
[14:38] <mborzecki> didn't want to do alloca(strlen(good_bad..)+1)
[14:50] <mvo> mborzecki: I pushed a tiny extra commit as it was breaking on ubuntu with the gcc8 fixes, but now it should work everywhere
[14:51] <mborzecki> mvo: yup, works here too
[14:55] <mvo> yay
[14:55] <pedronis> pstolowski: once interface hooks lands it seems it will open up a lot of its follow ups to review
[14:56] <pstolowski> pedronis: yes
[14:58]  * zyga needs to break now; I will be back in 3 hours to work on more things
[15:00] <zyga> mvo: gcc warns about unused result of those two?
[15:01] <mvo> zyga: chdir only, I did the rmdir for symetry
[15:01] <mborzecki> zyga: didn't warn here, but maybe there's something turned on by default in gcc-snapshot or ubuntu glibc
[15:05] <mvo> zyga: I think we use -Wunused-result or something, let me look
[15:05] <zyga> no worries, I was just curious
[15:05] <zyga> the patches look good
[15:05] <mvo> zyga: http://paste.ubuntu.com/p/B9TBshVG2n/
[15:05] <mvo> zyga: just fyi
[15:12] <mborzecki> mvo: looks like something in libc then
[15:15] <mborzecki> mvo: zyga: extern int chdir (const char *__path) __THROW __nonnull ((1)) __wur; where __wur sets warn_unused_result but only if FORTIFY_LEVEL is > 0
[15:19] <mup> Bug #1769669 changed: Snapd causes corruption on upgrade  <snapd:Confirmed> <https://launchpad.net/bugs/1769669>
[15:19] <mvo> mborzecki: ok
[15:35]  * zyga is really off now
[15:35] <pstolowski> pedronis: you're going to make one more pass over interface hooks PR (Gustavo's comments), right?
[15:37] <mvo> grr, now ubuntu-18.04-64 fails in spread-shellcheck with a pip install --user error
[15:37] <mvo> (i.e. pip fails)
[15:37] <mvo> mborzecki, zyga just fyi (pr 5138)
[15:37] <mup> PR #5138: cmd/libsnap: fix compile error on more restrictive gcc <Critical> <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5138>
[15:52] <pedronis> pstolowski: did something change since I last looked?
[15:54] <kyrofa> sergiusens, https://forum.snapcraft.io/t/proposal-snapcraft-provides/5275
[15:55] <pstolowski> pedronis: i've addressed the comments from Gustavo that I missed from his earlier review; and refresh was moved into separate PR. that's about it
[15:56] <pedronis> pstolowski: ok, I will look tomorrow morning at this point, also github is giving me unicorns
[15:56] <pstolowski> pedronis: sure
[16:01] <sergiusens> kyrofa: https://github.com/snapcore/snapcraft/blob/master/TESTING.md#testing-arm
[16:35] <sergiusens> kyrofa: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_Server_errors
[16:37] <sergiusens> kyrofa: from http.client import responses
[16:38] <sergiusens> kyrofa: requests.status_codes.codes
[18:09] <mup> PR snapcraft#2123 closed: file_utils: don't let FileNotFoundError escape <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2123>
[18:20] <jdstrand> noise][: hey, I've been getting 504's on https://dashboard.snapcraft.io/reviewer/ubuntu/. https://status.snapcraft.io/ looks ok
[18:49] <kyrofa> sergiusens, I just realized the sentry Always PR got rid of the environment variable with the same functionality-- how do you anticipate making this work in CI?
[18:49] <kyrofa> I'm getting some tracebacks in CI, I'd like to set it up to automatically submit those
[18:49] <kyrofa> I suspect LP will want to do the same at some point
[18:52] <sergiusens> kyrofa: yeah, I got rid of the environment to force us into the workflow. For now you could just create the appropriate config
[18:55] <kyrofa> sergiusens, sure, just curious what the long-term plan is. Adding something like that back?
[18:56] <sergiusens> an env var is something we can add back, but I'd prefer something closer to a setting, that involves a larger/longer discussion though
[19:25] <magicalt1out> out of curiosity hows this snap delay/schedule stuff coming along? Because with Gimp being a snap recommended at install time, if I was doing some design stuff (I can't design, we're talking hypothetics here) it'd be rather annoying if it suddenly stopped working or went a bit wacky cause Gimp got upgraded from under me.
[19:25] <magicalt1out> thats the one that springs to mind, i'm sure you could say the same for a lot of apps
[19:25] <magicalt1out> or maybe its a non issue
[19:25] <magicalt1out> hence my curiosity :)
[19:30] <kyrofa> Hey magicalt1out, I think most of the snapd team is EOD already, but there is a bit of info in the forum, and you can always ask there if you need async communication
[19:41] <mcphail> magicaltrout: "snap revert" is supposed to be the solution to that problem. I don't 100% agree
[19:50] <magicaltrout> interesting mcphail... I 100% agree with your not 100% agreeing
[19:53] <mcphail> magicaltrout: it'll maybe be better when people start using tracks as standard. that way there might be a persistent 2.8 track
[19:57] <kyrofa> mcphail, I don't think that's what magicaltrout was asking (correct me if I'm wrong magicaltrout). The concern is that, when a snap updates, if an app is already running, it may run into issues accessing the underlying data directories with the confinement
[19:58] <kyrofa> magicaltrout, you can schedule updates today, but that ^ is still an issue for when an update _does_ happen as far as I'm aware
[19:58] <kyrofa> Unless the snap in question is classically confined
[19:58] <mcphail> yes, that's a particularly annoying problem
[20:00] <mcphail> although i don't know if it is such an issue for snaps with the home plug
[20:03] <om26er> BUG: wrong emphasis of headings on this page https://docs.snapcraft.io/build-snaps/scriptlets
[20:06] <kyrofa> om26er, what are you talking about? That's obviously on purpose. Your eyes are drawn to the emphasis, no?
[20:06] <kyrofa> *cough*
[20:07] <kyrofa> om26er, mind logging an issue here? https://github.com/canonical-docs/snappy-docs
[20:07] <om26er> wonder if we have a new design language ;-)
[20:07] <magicaltrout> kyrofa is correct i'm curious about stuff that is up and running
[20:07] <kyrofa> Heh
[20:08] <magicaltrout> kyrofa: whats this schedule stuff you speak of?
[20:08] <kyrofa> magicaltrout, let me go forum diving,  hold on a sec
[20:08] <magicaltrout> snap set core refresh.schedule?
[20:10] <kyrofa> magicaltrout, yeah https://forum.snapcraft.io/t/refresh-scheduling-on-specific-days-of-the-month/1239 is the first one I find
[20:12] <magicaltrout> ah yeah thats cool, I'm really coming at it from a Charm angle. Because I want to ship Analytics tools and it'll be really sad for users if it updates mid workday mid month end
[20:12] <magicaltrout> for example
[20:12] <magicaltrout> thats cool though, i can try and set that during the install hook
[20:12] <kyrofa> Yeah I hear ya
[20:22] <mcphail> magicaltrout: i'm poking the devs about this :) https://forum.snapcraft.io/t/bug-saves-are-blocked-to-snap-user-data-if-snap-updates-when-it-is-already-running/3226
[20:24] <kyrofa> mcphail, ah,  yes
[20:25]  * mcphail feels it is his role to be an annoyance ;)
[20:40] <magicaltrout> annoyances ensure the useful stuff not just the fun stuff gets implemented ;)
[21:34] <mup> PR snapcraft#2115 closed: storeapi: ensure snap ID is sane before using it <Created by kyrofa> <Merged by kyrofa> <https://github.com/snapcore/snapcraft/pull/2115>
[23:36] <popey> pbek: just noticed you have old versions in beta/candidate/edge of qownnotes
[23:37] <popey> pbek: you can 'snapcraft close beta' for example to nudge people towards stable (and thus the latest build)
[23:37] <popey> (same for the other channels)