| === Ionic is now known as Guest99101 | ||
| cjwatson | We always wanted to have some equivalent of refs/pull/, and I believe it's still in an Asana backlog task somewhere, but we've never got round to it | 01:25 |
|---|---|---|
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === Ionic is now known as Guest67011 | ||
| === chihchun is now known as chihchun_afk | ||
| === maclin1 is now known as maclin | ||
| === chihchun_afk is now known as chihchun | ||
| === Ionic is now known as Guest43434 | ||
| smoser | cjwatson: is it useful at all if i open a bug/feature request ? it really is helpful to be able to see what someone changed between two pushes, especially when they are in response to review feedback. | 12:55 |
| cjwatson | smoser: Feel free. It would be good if you could substantiate your claim that you can get old versions of PRs on GitHub as git refs though; from a brief look it's not clear to me that that is true. | 12:58 |
| cjwatson | smoser: BTW the fact that you can see old versions of the diff in the MP doesn't mean that it hasn't been garbage-collected; those are stored as textual diffs. | 12:59 |
| cjwatson | (It probably hasn't been GCed, but still.) | 12:59 |
| smoser | oh. ok, i thought maybe internally lp was holding on to it. | 13:10 |
| smoser | cjwatson: i'll try to find it.. thanks. | 13:10 |
| smoser | cjwatson: https://bugs.launchpad.net/launchpad/+bug/1771357 | 13:50 |
| ubot5 | Ubuntu bug 1771357 in Launchpad itself "feature request: git merge proposal refs/pull (github) or refs/changes (gerrit) function" [Undecided,New] | 13:50 |
| smoser | couldn't find it on github, but gerrit does have it. | 13:50 |
| smoser | asked about this for github in https://github.community/t5/How-to-use-Git-and-GitHub/Access-to-old-versions-of-a-pull-request/m-p/7459 | 14:04 |
| smoser | :q | 14:10 |
| tsimonq2 | :q! | 15:24 |
| mdeslaur | cjwatson, wgrant: hi! is the +sourcefiles issue going to be resolved today? it's really breaking our workflow... | 15:30 |
| cjwatson | mdeslaur: I'm planning to finish the QA and roll out that fix when I get back from getting my wife's trike repaired | 15:31 |
| mdeslaur | cjwatson: awesome, thank you! | 15:31 |
| cjwatson | ... OK, I've done the QA, just don't want to leave a deployment running while I'm about to be cycling back across town | 15:37 |
| === chihchun is now known as chihchun_afk | ||
| cjwatson | mdeslaur: Sorry, I think this rollout may actually have to wait a bit longer - there are a couple of DB schema changes from wgrant that I believe were intended to be applied hot but haven't yet been applied, and I'd rather wait until he's around before requesting those | 18:26 |
| mdeslaur | cjwatson: ok, thanks | 18:28 |
| genii | Hello, is there a page where bugs can be filed against Launchpad itself? | 18:31 |
| teward | genii: https://bugs.launchpad.net/launchpad doesn't work? | 18:32 |
| genii | teward: Without a specific project then? | 18:32 |
| teward | ... that *is* the Launchpad Itself tracker | 18:33 |
| genii | OK | 18:33 |
| teward | the project for Launchpad on Launchpad is "Launchpad" | 18:33 |
| teward | :p | 18:33 |
| genii | hah | 18:33 |
| genii | https://bugs.launchpad.net/launchpad/+bug/1771406 | 18:44 |
| ubot5 | Ubuntu bug 1771406 in Launchpad itself "Wrong dates on team expiry emails" [Undecided,New] | 18:44 |
| genii | I renewed with a team admin already now, but weirdly it reported my expiry twice as the day before the actual one, and then twice as the day after. If it just continuously reports the expiry as 6-7 days from when email gets sent, this could be a problem for someone who still thinks they have time left to re-up | 18:51 |
| genii | ( and doesn't always bother checking their older emails on the same subject ) | 18:52 |
| wgrant | cjwatson: The code changes ahould go out first | 20:25 |
| wgrant | mdeslaur: hm did the workaround not work? | 20:25 |
| cjwatson | wgrant: Should I just deploy up to r18658 then? | 20:47 |
| cjwatson | (I've QAed r18654, but qa-tagger hasn't noticed, probably something to do with it being private.) | 20:47 |
| wgrant | cjwatson: You can go all the way if you want, since an ndt doesn't do DB patches and doesn't revoke permissions. So should make no difference. | 20:49 |
| cjwatson | I'll take the cautious path just in case of Sod's Law, I think. | 20:50 |
| cjwatson | If they're not actually needed. | 20:50 |
| wgrant | Reasonable. | 20:50 |
| wgrant | note that the test suite passed despite them being a suffix of revisions, so they can't be required for earlier revs to work | 20:51 |
| cjwatson | Yeah that's fair | 20:55 |
| cjwatson | wgrant,mdeslaur: code deployment is finished now | 22:38 |
| wgrant | Yay | 22:38 |
| wgrant | Thanks | 22:38 |
| cjwatson | np | 22:39 |
| cjwatson | So that's Twisted 17.9.0 everywhere. We could possibly start allowing ECDSA keys ... | 22:39 |
| cjwatson | Twisted doesn't do Ed25519 yet sadly | 22:39 |
| mdeslaur | cjwatson, wgrant: thanks! :) | 22:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!