| wallyworld | kelvinliu__: i left a comment on the juju-managed-units PR - just a small change needed | 00:02 |
|---|---|---|
| kelvinliu__ | wallyworld, ah, u r right. just pushed the change, thanks. | 00:07 |
| wallyworld | nw, looking | 00:07 |
| wallyworld | kelvinliu__: what about the other bit? | 00:08 |
| wallyworld | the if numUnits > 0 | 00:08 |
| kelvinliu__ | wallyworld, u mean the deployment controller? | 00:11 |
| wallyworld | kelvinliu__: yeah, a few lines down where it does "if numUnits > 0". that check will alsways be true now | 00:12 |
| wallyworld | so it's no longer needed | 00:12 |
| wallyworld | ie we always want the deployment controller | 00:12 |
| kelvinliu__ | wallyworld, that's right. | 00:13 |
| wallyworld | kelvinliu: small fix for a code comment and then good to $$merge$$ | 00:23 |
| wallyworld | kelvinliu: actually | 00:24 |
| wallyworld | we don't need the cleanups slice anymore | 00:24 |
| wallyworld | maybe | 00:24 |
| wallyworld | ah, i think we do after all | 00:25 |
| wallyworld | so leave it as is | 00:25 |
| kelvinliu | ic, wallyworld thanks | 00:27 |
| === freyes__ is now known as freyes | ||
| thumper | veebers: ping | 01:36 |
| thumper | veebers: nm, found the issue | 01:42 |
| kelvinliu | wallyworld, can i have ur 2 minutes? | 01:56 |
| wallyworld | sure | 01:56 |
| === jhebden is now known as jhebden-afk | ||
| veebers | thumper: oh, please share :-) | 02:21 |
| thumper | veebers: I had golang 1.6 deb installed | 02:31 |
| veebers | ah, that'll do it | 02:31 |
| veebers | :-) | 02:31 |
| babbageclunk | wallyworld and/or thumper: could you please take a look at https://github.com/juju/juju/pull/8680? | 03:21 |
| babbageclunk | ended up being a bit bigger than expected | 03:21 |
| wallyworld | babbageclunk: sap you? | 03:27 |
| wallyworld | swap | 03:27 |
| babbageclunk | wallyworld: Doh. Yup! | 03:27 |
| wallyworld | :-D | 03:27 |
| babbageclunk | wallyworld: you mean 8700? | 03:27 |
| wallyworld | yup | 03:28 |
| babbageclunk | cool cool | 03:30 |
| wallyworld | babbageclunk: i still wish we called the worker raft-unfucker :-) | 03:31 |
| babbageclunk | wallyworld: yeah, that would be pretty cool sort of. | 03:32 |
| wallyworld | babbageclunk: does the raft backstop worker need to be a singular worker? | 03:43 |
| wallyworld | the manifold definition looks like it sytarts up in every controller? | 03:44 |
| babbageclunk | wallyworld: that's right - it needs to run in each controller just in case that's the only one left standing. | 03:46 |
| babbageclunk | Hmm. I guess it could be a singular worker. Except when that's being run by raft it couldn't be. | 03:47 |
| wallyworld | ok. i'll read more of the code. i am wondering how they all then coordinate and not get confused | 03:47 |
| babbageclunk | Well, it only ever does anything when it gets told by the peer grouper that it's the only one left alive. | 03:47 |
| wallyworld | the whole idea of a singular work is that there's always one, no matter how many controllers there are | 03:47 |
| babbageclunk | Right, but we can't use something that will be powered by raft to save raft. | 03:48 |
| wallyworld | ok, i'll read more of the code | 03:48 |
| babbageclunk | The singular worker uses leases, which will be implemented by raft. | 03:48 |
| babbageclunk | wallyworld: approved with some comments. | 04:25 |
| wallyworld | babbageclunk: ty, 75% done on yours | 04:25 |
| babbageclunk | awesome | 04:25 |
| wallyworld | babbageclunk: i have a meeting, so left some initial comments for now | 04:29 |
| babbageclunk | ok, thanks wallyworld | 04:29 |
| veebers | wallyworld: FYI percona-cluster and mediawiki bugs I filed re: CMR/upgrade issues https://bugs.launchpad.net/charm-percona-cluster/+bug/1771729 and https://bugs.launchpad.net/charms/+source/mediawiki/+bug/1768710 (I'll follow up the mediawiki one too) | 04:32 |
| mup | Bug #1771729: When using CMR db username is too long <OpenStack percona-cluster charm:New> <https://launchpad.net/bugs/1771729> | 04:32 |
| mup | Bug #1768710: workload status does not survive juju upgrade. <mediawiki (Juju Charms Collection):New> <https://launchpad.net/bugs/1768710> | 04:32 |
| wallyworld | veebers: great ty | 04:32 |
| wallyworld | babbageclunk: let me know to take another look at the PR so I can +1 | 05:23 |
| babbageclunk | wallyworld: ok, will do - just replying to comments at the moment, then I've got some fixes to do. | 05:24 |
| wallyworld | ok, np, just want to be sure i'm not blocking you | 05:24 |
| babbageclunk | wallyworld: just pushing review fixes now, also lots of argumentative replies to your comments ;) - can you take another look? | 06:05 |
| wallyworld | sure :-) | 06:05 |
| babbageclunk | only slightly argumentative. | 06:06 |
| wallyworld | babbageclunk: +1 with the main followup required being using the machine id rather than tag string | 06:18 |
| anastasiamac | wallyworld: if u get a chance, PTAL https://github.com/juju/juju/pull/8717 | 06:23 |
| anastasiamac | :) | 06:23 |
| wallyworld | sure | 06:24 |
| wallyworld | anastasiamac: lgtm, awesome | 06:27 |
| anastasiamac | wallyworld: \o/ | 06:27 |
| sanju | join | 07:30 |
| srihas | hi guys, I am unable to login to openstack from dashboard, the error is "Unable to establish connection to keystone endpoint." | 09:33 |
| srihas | apache error log shows the openstack dashboard is trying to access keystone on the localhost instead of the keystone host | 09:33 |
| srihas | local_settings.py has the OPENSTACK_HOST set to the keystone hsot | 09:34 |
| srihas | how can I debug this? | 09:34 |
| srihas | can some one help? | 09:34 |
| srihas | or may be is there a place where I can post these questions? | 12:07 |
| TheAbsentOne | I'm not that familiar with openstack but I assume most experts are offline right now, what timezone do you live in srihas? You could always try the mailinglist if it's urgent | 12:09 |
| srihas | TheAbsentOne: CEST | 12:32 |
| srihas | thank you | 12:32 |
| srihas | but I have fixed it by upgrading the charm with 258 version | 12:32 |
| srihas | but we have issues with neutron-api charm when neutron_plugin: aci | 12:34 |
| magicaltrout | charmers, I have a little competition running with my interns where they've been tasked to build a dashboard over the charmstore API using opensource software of their choosing | 14:29 |
| magicaltrout | the entries are being judged on, usefulness, ease of install and look and feel. We want it judged by some 3rd parties to remove bias, anyone want to volunteer for judging in a few weeks time? | 14:30 |
| kwmonroe | magicaltrout: i'm in! | 14:34 |
| magicaltrout | thanks kwmonroe | 14:35 |
| magicaltrout | i'm sure i can convince rick_h_ to waste some cycles on it also | 14:36 |
| admcleod_ | magicaltrout: sure | 14:49 |
| magicaltrout | cheers egghead | 14:54 |
| admcleod_ | you're just such a great guy, i cant find anything to tease you about | 14:58 |
| admcleod_ | :D | 15:02 |
| rick_h_ | magicaltrout: :) do I get a gavel? I want a gavel. | 15:08 |
| admcleod_ | i hope https://bugs.launchpad.net/juju/+bug/1771885 is an easy fix... | 20:09 |
| mup | Bug #1771885: 2.4-beta2 - lxd containers missing search domain in systemd-resolve configuration <juju:New> <https://launchpad.net/bugs/1771885> | 20:09 |
| thumper | morning peeps | 21:33 |
| wallyworld | babbageclunk: hey, you aware of this? http://ci.jujucharms.com/job/github-check-merge-juju/1418/testReport/junit/github/com_juju_juju_worker_raft_raftclusterer/TestPackage/ | 21:37 |
| babbageclunk | wallyworld: yup - it bit my PR last night. It's my top priority | 21:40 |
| babbageclunk | wallyworld: then your "no tags anywhere" vendetta | 21:41 |
| wallyworld | :-) | 21:41 |
| wallyworld | babbageclunk: also, did you see my comment about the ref count? i forgot about the global vs model collection thing | 21:41 |
| babbageclunk | wallyworld: ooh, no - just looking | 21:42 |
| babbageclunk | ah yeah - that makes a lot of sense | 21:43 |
| babbageclunk | wallyworld: did you see my comment about the select-clause priority thing? | 21:43 |
| wallyworld | oh, no, looking :-) | 21:43 |
| wallyworld | babbageclunk: huh. maybe that changed. maybe it was always like that. but so much of our code is written to assume that the source order determines which one of multiple ready channels gets the result first | 21:48 |
| babbageclunk | I can see some confusion because of the evaluation order thing | 21:48 |
| babbageclunk | What do you think, should I still simplify it? I'm not sure the priority argument really holds water anyway. | 21:49 |
| babbageclunk | wallyworld: that's the last thing I've got, if you're ok with it I'm landing the sucker! | 21:54 |
| wallyworld | babbageclunk: if you think the order doesn't matter then simplification would be gr8. we don't seem to make the distinction in other owrkers | 21:55 |
| wallyworld | thumper: wouldn't mind a teddy bear for something if you are free at some point | 22:00 |
| thumper | wallyworld: I'm using babbageclunk for that just now | 22:00 |
| wallyworld | be gentle with him | 22:01 |
| thumper | wallyworld: how urgent is your teddy bear needs? as I'd like to complete this bug fix | 22:09 |
| thumper | and I need to talk to veebers to do that | 22:09 |
| wallyworld | thumper: not too urgent, i'll relocate soon and maybe we can chat after | 22:09 |
| thumper | ok | 22:09 |
| thumper | veebers: got a few minutes? | 22:09 |
| veebers | thumper: sure do | 22:09 |
| thumper | sweet | 22:10 |
| thumper | veebers: in our 1:1 | 22:10 |
| veebers | whenever I add --destroy-all-models to a command I picture Bender saying "destroy all humans". I wonder if I can alias that argument | 22:40 |
| babbageclunk | thumper: Am I right in thinking that Catacomb.Err() will never return Catacomb.ErrDying()? | 22:45 |
| thumper | I couldn't say without looking | 22:47 |
| babbageclunk | thumper: it looks like it from my reading - tomb.Kill(err) will never store tomb.ErrDying as the reason it's dying. | 22:50 |
| thumper | babbageclunk: https://github.com/juju/juju/pull/8720 | 22:54 |
| babbageclunk | thumper: looking | 22:55 |
| babbageclunk | thumper: approved with minor comment. | 23:07 |
| thumper | babbageclunk: thansk | 23:07 |
| thumper | reasonable comment | 23:09 |
| thumper | babbageclunk: although wrong | 23:11 |
| babbageclunk | ? | 23:11 |
| thumper | babbageclunk: we need to check against a nil initial error | 23:11 |
| thumper | because a dial error is better than nothing | 23:11 |
| babbageclunk | thumper: oh, right | 23:12 |
| babbageclunk | I had the sense wrong. | 23:12 |
| thumper | :0 | 23:12 |
| thumper | all good | 23:12 |
| babbageclunk | Will other ever be nil? | 23:13 |
| thumper | nope | 23:13 |
| thumper | initial is only ever nil the first time combine is called | 23:13 |
| babbageclunk | ok, in that case fine. | 23:13 |
| thumper | assuming that combine returns non-nil | 23:13 |
| thumper | it is only called when there was an error returned | 23:13 |
| babbageclunk | cool cool | 23:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!