/srv/irclogs.ubuntu.com/2018/05/24/#snappy.txt

mwhudson$ snap download --channel=wibble hello00:52
mwhudsonFetching snap "hello"00:52
mwhudsonerror: cannot find snap "hello": snap not found00:52
mwhudsonaccurate but possibly not maximally helpful00:52
niemeyermwhudson: Thanks, will have a look tomorrow00:54
* niemeyer => bed00:55
mwhudsonniemeyer: good night00:55
niemeyerNight!00:55
niemeyerOr rather, have a good day :)00:55
mupBug #1773044 opened: Can't get snap gui apps (notepadqq and firefox) to run in LXD/LXC container <Snappy:New> <https://launchpad.net/bugs/1773044>01:06
mborzeckimorning05:01
zygao/05:04
mborzeckizyga: back from vacation?05:14
zygayes05:15
zygahey mvo :-)05:15
mborzeckimvo: morning05:15
zygawe arrived late, plane switching and endless waiting05:15
zygaa bit sleepy05:15
zygabut I managed to fix my machine's snapd by aborting existing changes and refreshing core in isolation05:16
mvohey zyga and mborzecki05:16
mborzeckizyga: but otherwise the stay in spain was enjoyable?05:16
zygamborzecki: yes but also very emotional05:16
zygamborzecki: we have way more close friends there than here05:16
zygamborzecki: and given the size of the city we met all but one of them, mostly just by bumping into each other, ahead of planned events :)05:17
zygamborzecki: it's likely we will return there if stars align05:17
mborzeckizyga: haha nice05:18
mborzeckizyga: 2nd thoughts about moving back there? :)05:18
zygahow was the week?05:18
zygaany fires05:18
zygamborzecki: yes, definitely05:18
mupPR snapd#5193 closed: spread-shellcheck: port to python <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5193>05:19
mupPR snapd#5190 closed: tests: new parameter for the journalctl rate limit <Created by sergiocazzolato> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/5190>05:24
zygaDog time05:25
mvozyga: when you have a moment (and you are back) a review of 5143 would be great05:52
mvozyga: you reviewed this already so hopefully simple05:53
mvowe are back to 25 open PRs, yay05:53
mvoa review for 5194 would also be nice (should be pretty trivial)06:06
* zyga reviews 514306:25
zygasorry for the lag, I didn't bring shaving gear with me and I looked like robinson stranded on some island06:25
mvono worries06:26
mborzeckigdpr emails, getting many of those now that the deadline is tomorrow (?)06:39
zygamborzecki: yeah, quite a swarm06:43
zygamborzecki: if I'm a self-emloyed company and I have you in my address book, do I need to send you one too?06:43
mborzeckihahaha06:43
mborzeckiwell, you'll probably need to keep the business cards in a safe too :)06:44
zygamvo: done, looking at 519406:53
mupPR snapd#5194 closed: interfaces/apparmor: add 'mediate_deleted' profile flag for all snaps <Created by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5194>06:57
=== pstolowski|afk is now known as pstolowski
pstolowskigood morning07:02
mvozyga: thank you07:02
mborzeckipstolowski: hey07:06
zygahey pawel!07:08
mvohey pstolowski good morning!07:11
BlueSharkHow to set an app that was installed using Snap to auto-start on boot?07:26
zygaBlueShark: hey, if the application supports this by itself use internal application settings07:27
zygaBlueShark: otherwise your desktop environment may have something for starting apps on login07:27
zygaBlueShark: if this is a service it will automatically start on boot07:27
BlueSharkzyga, It's slack. I enabled auto-start inside Slack settings, but that does not work. It does not start automatically.07:27
BlueSharkWhen I used to install it using the deb file from the wbesite, it used to work perfectly. Now, with Snap though, it's not working.07:28
zygaBlueShark: slack may need a tweak to enable this feature in the snap, it is a new addition07:28
BlueShark(I can't install using the .deb fiile because of some dependency conflict with libcurl4)07:28
BlueSharkzyga, no work around possible?07:28
zygaBlueShark: (and I may be wrong that it is still only avialable in the development version of snapd)07:28
BlueSharklike something I can add in rc.local or some startup script so that it's executed?07:29
zygaBlueShark: well, as I said, it's a recent addition, once deployed the checkbox you used to use will work again07:29
BlueSharkyup, until then, I can use some work around.07:29
BlueShark(if possible.)07:29
zyganot really, those are not compatible with desktop apps07:29
zygamborzecki: is auto-start for desktop apps released to stable?07:29
mborzeckizyga: yes07:29
zygaah nice07:30
* zyga looks at slack07:30
BlueSharkthanks!07:30
zygaslack is not using this07:30
BlueSharkok, what are they using?07:30
zygapopey: hey, nitpick suggestion about slack, it could ot into the auto-start feature supprt07:30
zyga*support07:30
zygait should be a one line diff to their snap.yaml now07:30
zygaahmm07:31
zygaactually07:31
BlueSharkFile -> Preferences -> Launch app on login - I check this box every time, but when I restart the system, not only does it not start, the checkbox becomes unticked.07:31
zygaslack is using classic confinement07:31
zygaso whatever it is doing should be uninhibited07:31
mborzeckizyga: is it still?07:31
mborzeckii thought they moved to strict07:31
zygano, they haven't07:31
mborzeckihmmpfff07:32
BlueSharklaunching /snap/bin/slack from command line seems to work.07:34
BlueSharkadding it to a startup script, wouldn't work, zyga?07:34
zygaBlueShark: it looks like auto-start does nothing inside slack07:34
zyganot sure why07:34
zygaBlueShark: define startup script07:34
zygaBlueShark: it would only work if started from your session manager07:34
zygait would not work from typical system startup07:34
mborzeckizyga: it should drop a desktop file in ~/.config/autostart07:35
BlueSharkI was thinking @reboot in crontab07:35
zygamborzecki: it doesn't07:35
zygaBlueShark: what?07:35
zygain any case, it would not work :)07:35
BlueSharkok.07:35
BlueShark>  it would only work if started from your session manager - is there any way to accomplish this?07:35
zygapopey: I take that back, it would be nice to poke slack about auto-start for their app, it seems to be disabled and it ought to work now07:35
zygaBlueShark: it depends on the session manager but as mborzecki said many of them support reading ~/.config/autostart and looking for desktop files to run there07:36
zygathis book cover: https://twitter.com/mononcqc/status/999471339474968576 :^)07:38
BlueSharkzyga, I'm using Ubuntu mATE.07:39
zygait should work then07:39
zygabut again, it is a bug in slack07:39
zygaso perhaps slack can fix it to just work as it should07:39
mborzeckiBlueShark: a workaround, but you could try and symlink /var/lib/snapd/desktop/applications/<slack-desktop-file>.desktop to ~/.config/autostart07:43
Chipacamood gorning all!07:54
zygagood morning John07:54
Chipacawho is this 'John' person07:57
Chipacai see only chipacas07:57
mvoChipaca: hey, good morning!07:58
Chipacazyga: mvo: good morning :) how's things?07:58
zygaI'm slowly getting back into business07:58
zygadoing reviews now07:59
zygaenjoying the warmth of Poland over the coldness of Spain07:59
pstolowski:)08:04
mborzeckiwell, it's a nice weather for biking for sure, not too hot, not too cold, bit too windy, but otherwise evening rides are fun :)08:05
Chipacahuh, so my snapd is again stuck in a loop08:18
Chipacaah... probably need to stop it and rebuild08:18
zygaChipaca: or abort it and refresh snapd alone08:18
zygait fixed it for me08:18
Chipacazyga: it's a dev snapd, no reexec08:18
BlueSharkmborzecki, ln -s?08:22
mvoniemeyer: could you please add github.com/snapcore/core18 to mup so that it announces new PRs here?08:22
mborzeckiBlueShark: ln -s /var/lib/snapd/desktop/applications/slack_slack.desktop ~/.config/autostart/08:25
Chipacapedronis: I just set ensureInterval, pruneInterval, pruneWait and abortWait to time.Second (to force prune my 68MB state.json), and snapd paniced08:26
pedronisChipaca: that was a bit aggressive08:26
Chipacapedronis: ikr08:26
Chipacapedronis: i expected it to be a bit unhappy :-) but a panic seems wrong08:27
pedroniswell08:27
pedronisI'm not sure what the invariants are but there are for sure some08:27
Chipacahttps://pastebin.ubuntu.com/p/xGTBSswsDD/ if it's of interest to you08:27
* Chipaca can't delve into that right now08:28
pedronisChipaca: well we are deleting a task that is being run08:28
pedronisor something like that08:28
pedronisnot sure08:29
pedronisChipaca: I see, I think the issue is that   changes become ready before they  are cleaned up08:35
pedronisChipaca: I suppose it's a real bug in the sense that the pruning code should wait for the change to be clean, not just ready08:36
pedronisChipaca: otoh I suppose cleaning might fail and that never happen08:41
pedronisChipaca: so we would need a cleanWait time08:43
pedronisand a way to stop cleaning itself08:44
pedronisChipaca: is cleaning on shot? do you remember?08:45
Chipacapedronis: I don't even remember what cleaning involved :-)08:46
Chipacapedronis: was that what we hung cleanup from?08:46
pedronisChipaca: yes, anyway your panic seems related to that08:46
Chipacak08:46
pedronisand the fact that ready and clean are distinct concept08:46
pedronisbut I don't remember how we handle clean errors08:47
pedronisChipaca: afaict it seems we would try forever08:51
pedronisotoh the only clean we have doesn't return errors (except for state issues)08:52
Chipacapedronis: there's a cleanup in snapshotmgr08:53
Chipacapedronis: but it also doesn't error08:53
Chipacai thought not erroring was cleanups thing08:53
pedronisyea08:53
pedronisChipaca: though there is still something weird about that panic08:57
mborzeckipedronis: Chipaca: i undestand client.Snap should also carry the list of appstream IDs as top level common-ids?09:02
pedronisthink so09:03
Chipacamborzecki: yah09:03
pedronisChipaca: so I think the panic as such is an actual bug,   the place that does Task(id)  should probably not assume that the return will not be nil09:04
pedronisit kinds always not nil, except when it is09:05
zygahttps://github.com/snapcore/snapd/pull/5184 is long but interesting if anyone wants to look09:11
mupPR #5184: interfaces: add desktop-{contacts,calendar}-service interfaces <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/5184>09:11
pedronisChipaca: there's two bugs probably, though one is really relevant only if you set a very low pruneWait09:13
pstolowskipedronis: hey, i've a helper and tentative fix per yesterdays discussion09:17
pstolowskiand test is happy09:17
pstolowskipreparing PRs09:17
pedronispstolowski: cool09:17
zygapstolowski: hey, is the hookapocalypse solved now?09:18
pstolowskinot running hooks twice isn't addressed yet, but i'll do that as well i think09:19
pstolowskizyga: it should be yes09:19
pedronisChipaca: anyway basically pruneWait and abortWait need to be some healthy multiple of ensureInterval09:24
* zyga reached his first PR while doing reviews, yay09:24
pedronisChipaca: I'll do a small PR about the panic itself09:25
Chipacapedronis: thanks09:25
* zyga small break09:27
Chipacawaaaait09:29
Chipacathere are only 24 PRs up09:29
Chipacathat's less than a page09:29
Chipacaquick, more PRs!09:30
pstolowskithey're coming ;)09:40
pedronisChipaca: https://github.com/snapcore/snapd/pull/519509:43
mupPR snapd#5195 opened: overlord/snapstate: don't panic in a corner case interaction of cleanup tasks and pruning <Created by pedronis> <https://github.com/snapcore/snapd/pull/5195>09:43
mupPR #5195: overlord/snapstate: don't panic in a corner case interaction of cleanup tasks and pruning <Created by pedronis> <https://github.com/snapcore/snapd/pull/5195>09:43
mupPR snapd#5196 opened: ifacestate: FindSnapsWaitingFor helper <Created by stolowski> <https://github.com/snapcore/snapd/pull/5196>09:44
Chipacapedronis: +1 :-)09:45
* Chipaca -> physio, probably09:45
upgreyddhello. Can someone help me with `snap` please? I have problem with access to ports - still getting `access denied`. Ports are unused in hosts machine :(09:50
zygaupgreydd: hey, which ports are you referring to?10:01
upgreyddzyga: 8080, 27017 - they are unused at host -i'm trying to use rocketchat10:02
zygaIP ports?10:02
mvomborzecki: do we have a forum post about the new watchdog support you added recently? if so, could you please paste hte link? I am updating the 2.33 roadmap page right now. anything else I should mention there that you remember from your side?10:05
zygaupgreydd: well, if you are after network, is your snap using network-bind interface? you need a plug (connected) of that interface to create network services10:05
mvozyga: same question, anything I should mention (high level) for 2.33 from you?10:06
mvopstolowski: for 2.33 - interface hooks are in, right?10:06
upgreyddzyga: what are you talking about? :|10:06
zygaupgreydd: can you please give us an overview of your problem?10:07
pedronismvo: they are not fully usable10:07
pstolowskimvo: we don't have complete feature without now reverted reconnect10:07
pedronisgiven what we reverted10:07
zygaupgreydd: are you writing some software that binds to network sockets?10:07
pstolowskiand without disconnect hooks (PR up, but needs some more work)10:07
mborzeckimvo: i'm afraid there's no separate post about software watchdog, what reminds me i should probably update snap.yaml doc page10:08
upgreyddzyga I've installed package `rocketchat-server` <- it was working before10:08
zygamvo: I need to check, I think I was only doing bug fixes lately,10:08
upgreyddzyga: when i run `snap start rocketchat-server` only one service is starting, two is not: they are showing errors in journalctl: listen tcp :8090: socket: permission denied10:09
zygaupgreydd: can you run "snap interfaces | grep rocket chat-server"10:09
zyga(skip the space in rocketchat above)10:09
upgreyddzyga: :desktop, :network, :network-bind10:10
upgreyddzyga: there are subservices10:10
upgreyddsnap services rocketchat-server Service                              Startup  Current rocketchat-server.rocketchat-caddy   enabled  inactive rocketchat-server.rocketchat-mongo   enabled  inactive rocketchat-server.rocketchat-server  enabled  active10:10
zygacan you now run "dmesg | grep DENIED"10:10
upgreyddzyga: lot of: [ 1055.222607] audit: type=1400 audit(1527156637.606:9658): apparmor="DENIED" operation="ptrace" profile="snap.rocketchat-server.rocketchat-server" pid=7152 comm="ps" requested_mask="trace" denied_mask="trace" peer="unconfined"10:11
zygacan you run10:11
zygadmesg -c >/dev/null10:11
zygasystemctl restart rocketchat-server # + other services10:11
zygadmesg | grep DENIED10:12
zygaand pastebin the result10:12
upgreyddzyga: https://pastebin.com/FY9MWcNe10:13
popeycjwatson: https://launchpad.net/~build.snapcraft.io/+snap/20905f58c528ef301b741b624b79dc28-xenial/+build/223942  this build looks wedged, can it be cleaned please?10:13
popeyref: https://forum.snapcraft.io/t/tizonia-store-build-stuck-for-more-than-4-days/558310:13
=== grumblr is now known as grumble
zygaupgreydd: can you pastebin /snap/rocketchat-server/current/meta/snap.yaml please10:14
upgreyddzyga: https://pastebin.com/itCDhgLM10:15
zygacan you pastebin /var/lib/snapd/apparmor/profiles/rocketchat-server.rocketchat-caddy10:16
zyga(er, snap.rocketchart-server.rocketchat-caddy)10:16
mborzeckimvo: i've updated https://forum.snapcraft.io/t/the-snap-format/69810:16
upgreyddzyga: https://pastebin.com/96GzLgnU10:18
upgreyddzyga: is there a way to disable apparmor for whole snap?10:19
cjwatsonpopey: Yes, I also saw Evan's bug about that, only need one notification10:19
zygaupgreydd: hmm, this is curious10:20
popeyI wasn't aware Ev had filed a bug, sorry.10:20
zygaupgreydd: can you run "snap interfaces" and pastebin that again please10:20
cjwatsoncancelling, but in general we do cancel stuck builds in bulk every so often10:20
upgreyddzyga: https://pastebin.com/E91MpW5w10:21
zygahmm hmm hmm10:21
zygathis looks curious10:21
zygaand "snap version"?10:22
upgreyddsnap    2.32.8 snapd   2.32.8 series  16 ubuntu  14.04 kernel  4.4.0-127-generic10:22
zygaso10:23
upgreyddas I understand theres a problem with apparmor? Can we just simply override apparmor for this app somehow?10:23
zygafor whatever reason, while snapd claims that the network-bind plug is connected10:23
zygait is not present in the profile of that app10:23
zygaupgreydd: can you "snap disable rocketchat-server"; snap enable rocketchat-server10:23
zygathat ought to fix it10:23
zygaupgreydd: not per app10:23
mborzeckimvo: and left a note here https://forum.snapcraft.io/t/expose-a-more-consistent-subset-of-systemds-service-directives/2268/45 in case you want to link to it10:23
zygaupgreydd: there's a way to switch apparmor to non-enforcing mode but I think this will fix itself after that last command10:24
zygaI'm worried that it has happened in the first place10:24
upgreyddzyga: your'e right10:24
upgreyddfixed10:24
zygaupgreydd: can you tell me when this started to happen exactly (assuming the disable/enable commands fix it)10:24
upgreyddzyga: after rocketchat autorefresh10:25
zygacan you pastebin snap changes10:25
zygaand then10:25
zygasnap tasks NNN # where NNN is the number of the change you get from the previous command10:25
upgreyddhttps://pastebin.com/8zdqm1Yj10:26
zygathanks10:27
zyganothing that seems to indicate something went wrong :/10:27
zygadid you reboot your machine?10:27
zygawhen this happened10:27
zygaas in <reboot> <stuff is broken>10:27
zygaupgreydd: also in case it has some useful clues as to what went wrong, please pastebin: jounalctl -u snapd10:32
upgreyddzyga: rebooted lot of times10:32
mupPR snapd#5195 closed: overlord/snapstate: don't panic in a corner case interaction of cleanup tasks and pruning <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/5195>10:32
mvomborzecki: thank you! I will link to it10:32
upgreyddzyga: there was some other before me and I don't know what did he did10:32
mvopstolowski: I move the interface hooks to 2.34 then for now10:32
mvopstolowski: thank you10:32
zygamvo: do we have that debian version compare somewhere in the tree?10:37
mvozyga: we used to, let me see if we still do10:38
zygaI need a function that's similar10:38
zygathinking about just reusing it10:38
mvozyga: try strutil.VersionCompare10:39
zygaperfect!10:39
zygathanks10:39
mvozyga: if the version numbering is vaguely sane it should work10:39
mvozyga: what do you need to compare?10:39
zygamvo: kernel versions10:43
zygaI think this will work perfectly10:43
mvozyga: yes10:47
zygamborzecki: hey11:10
zyga    - google:ubuntu-14.04-64:tests/main/snapd-notify fails, is that expected?11:11
mborzeckizyga: hmhm?11:11
mborzeckiwhich pr is it?11:11
zygahttps://travis-ci.org/snapcore/snapd/builds/38312177211:12
zygahttps://github.com/snapcore/snapd/pull/519611:12
mupPR #5196: ifacestate: FindSnapsWaitingFor helper <Created by stolowski> <https://github.com/snapcore/snapd/pull/5196>11:12
* zyga hates packagekit11:15
mborzeckizyga: not expected, saw it a couple of times, restarting the build helps, intersting bit was journal being empty between cursors11:15
zygaI restarted it already11:15
zygabut maybe bad luck11:15
mupPR snapd#5119 closed: dirs: on opensuse store apparmor profiles in /etc/apparmor.d <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/5119>11:15
pedronispstolowski: the PR is red11:15
mupPR snapd#5119 opened: dirs: on opensuse store apparmor profiles in /etc/apparmor.d <Created by zyga> <https://github.com/snapcore/snapd/pull/5119>11:16
pstolowskipedronis: indeed, tests/main/snapd-notify failure, cursor on journal failed11:38
pedronisah, 14.0411:39
pedronismmh11:39
jdstrandpstolowski: hi! it seems https://forum.snapcraft.io/t/supported-snap-hooks/3795 is out of date. it doesn't list connect-{plug,slot}-* and prepare-(plug,slot}-*. are there any others that are missing? I ask because a snap is using a 'refresh' hook (not post-refresh or pre-refresh)11:44
jdstrandpstolowski: I haven't look in the snapd sources yet, but is 'refresh' supported? are there others?11:44
jdstrandlooked*11:44
pstolowskipedronis: i'm going to kick the test again and see, but these cursor- based tests seem flaky, we need to revisit them11:44
jdstrandpstolowski: if you don't know otoh, I can read the sources myself11:46
pstolowskijdstrand: hey. i'll take a look at the list; we don't have refresh , only post- and pre- refresh. i'm surprised we see refresh hook somewhere, there was a very brief moment we had this hook (and i think only in edge) and we split/renamed it into pre- and post- very quickly11:47
jdstrandpstolowski: ok, cool, then the tools did their job :)11:47
pstolowskijdstrand: the list looks complete to me in a sense that interface hooks are not fully landed and usable yet, so we shouldn't probably document  onnect- and prepare-plug/slot- yet11:48
jdstrandpstolowski: ah, ok. thanks!11:49
zygajdstrand: hey11:52
zygajdstrand: question11:52
zygajdstrand: I'm writing a service that loads snapd-specific apparmor profiles11:52
zygawhat kind of guarantees should I put in place, do I need to replicate all the things done by various distro specific helpers11:52
zygalike mounting securityfs and such11:52
jdstrandzyga: if you're unit file does After=apparmor or similar, no. if your unit is meant to be independent, yes.11:54
zygacan I do After=apparmor?11:55
zygathat would definitely simplify it, yes11:55
jdstrandsure, why not?11:55
zygawell, as long as that's portable :)11:55
zygaI'll do it, thanks11:55
jdstrand./libvirt-bin.service:After=apparmor.service11:55
jdstrandzyga: it is as portable as apparmor.service existing11:55
Chipacazyga: remember After= isn't Requires=11:57
Chipacazyga: you can put After=Dziewięćsetdziewięćdziesięciodziewięcionarodowościowego and it'd probably work11:58
jdstrandin this case, After=apparmor.service is probably correct. on distros without apparmor.service, you probably don't have apparmor_parser or the apparmor abstractions. snapd can then proceed in devmode12:00
jdstrandzyga, Chipaca: ^12:01
mupPR snapd#5197 opened: [WIP] cmd/snap: display a link to the TOS for interactive snap login <Created by pedronis> <https://github.com/snapcore/snapd/pull/5197>12:07
mupPR snapd#5198 opened: data/systemd: add snapd.apparmor.service <Created by zyga> <https://github.com/snapcore/snapd/pull/5198>12:07
zygajdstrand: ^ a quick idea12:07
zygajdstrand: I would subsequently install this on openSUSE12:08
cachiozyga, mvo, #5143 updated12:11
mupPR #5143: tests: speed up save/restore snapd state for all-snap systems suring tests execution <Squash-merge> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/5143>12:12
cachiomborzecki, #5143 updated12:12
cachiothanks for reviewing!!12:12
zygacachio: ack, looking again12:12
mvocachio: thank you12:14
mvocachio: looking12:14
cachiomvo, I am re executing this in the boards to validate everything is ok12:15
mvocachio: cool, thank you. once this is good I will cherry-pick it into 2.3312:16
mvocachio: we just need to remember to squash merge it12:16
cachiomvo, perfect12:16
zygacachio: in 5143, can you please react to existing feedback, I'm not sure if you saw something but chose to ignore it or if an older feedback was acted upon but the lines have changed so the comment is hidden12:24
* zyga -> school see you at the standup12:25
mvozyga, sil2100 feedback on 10,11 for https://github.com/snapcore/core18/pulls woudl be great (no rush though)12:25
cachiozyga, sure12:33
sil2100mvo: sure o/12:33
popeydiddledan: I'm told by sergiusens  that the new snapcraft should be available in build now, so maybe we can land your gimp 2.10 work?12:34
diddledan\o/12:35
diddledanclick the butten!12:35
diddledanbutton*12:35
diddledanI'm working on 2.10.2 atm12:35
diddledanthis is a problem I'm encountering, which appears to be something with my build rather than snapd? (gimp:17871): GLib-ERROR **: 13:36:13.404: gmem.c:333: overflow allocating 18446744073709551615*18446744073709551615 bytes12:36
Chipacadiddledan: here's a nickle, etc12:39
* zyga actually doesn't do school run now, eh12:39
mupPR snapd#5199 opened: many: expose AppStream IDs (AKA common ID) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5199>12:41
om26erChipaca: that https://github.com/torvalds/linux/blob/master/include/math-emu/double.h#L29 ?12:43
Chipacaom26er: which is a reference to http://dilbert.com/strip/1995-06-2412:44
om26erepic12:45
zygamborzecki: question on appstream integration12:45
zygaposted on github12:45
Chipacazyga: search responses don't include app info12:47
zygaah12:47
zygaI see12:47
Chipacazyga: but search consumers need to know the ids of the results12:47
Chipacazyga: so the easiest way is to have it in both places12:47
zygaso this is the client side12:48
Chipacazyga: all sides12:48
zygais the store side (that is snapd->store) part ready?12:48
Chipacazyga: yes, has been for a while now12:48
Chipacawe were lagging12:48
Chipacai mean12:48
Chipacathe _store_ has been responding with common ids for a while, if asked12:48
Chipacasnapd hasn't been asking12:48
zygahow do we ask?12:49
zygaI see deserialisation things but I don't see something like "gimme common-id"12:49
Chipacazyga: include it in the 'fields' query12:50
Chipacazyga: store.Config.DetailFields12:50
mborzeckizyga: that part is magical :)12:50
zygaoh?12:50
Chipacazyga: MAGIC12:51
zygait gets computed from the structs somehow>12:51
zyga?12:51
mborzeckiChipaca: did you write it?12:51
mborzeckizyga: yes12:51
Chipacayes12:51
zygaah, ok12:51
zyga+1 then12:51
zygathis is a major thing, thank you mborzecki12:51
Chipacano, it's a common thing12:51
Chipacaotherwise it would be major-id12:51
* Chipaca runs12:51
mborzeckihaha12:51
zygaChipaca: is a general-id better than major-id12:53
zygaand is there a private-id12:53
* zyga gets back to coding12:53
cachiozyga, #5143 ready again12:56
mupPR #5143: tests: speed up save/restore snapd state for all-snap systems during tests execution <Squash-merge> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/5143>12:56
zygamvo: thanks for the question on 5198, replied and removed the code there12:56
zygacachio: ack,12:56
zygacachio: thanks, I think only https://github.com/snapcore/snapd/pull/5143#discussion_r190480661 remains12:59
mupPR #5143: tests: speed up save/restore snapd state for all-snap systems during tests execution <Squash-merge> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/5143>12:59
zygaafter that +112:59
zygajdstrand: thanks for the quick review, replied and will make the changes13:31
mupPR snapd#5188 closed: tests: ubuntu core abstraction <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/5188>14:21
jdstrandzyga: interesting: kernel: [624468.239774] audit: type=1400 audit(1527171830.098:109395): apparmor="DENIED" operation="file_inherit" profile="snap-update-ns.firefox" name="/dev/null" pid=15584 comm="3" requested_mask="r" denied_mask="r" fsuid=0 ouid=014:24
kjackalWhat is the process for changing the publisher of a snap?14:24
popeykjackal: The store team can initiate a transfer, Start a thread on the forum in the store category14:25
kjackalthanks14:25
cachiozyga, hey14:25
jdstrandzyga: we should add '/dev/null rw,' to the sun profile14:25
zygaack14:25
cachioI can add a function to systems.sh like it_is_ubuntu_1414:26
cachiois_ubuntu_1414:26
cachioso we can use that in state.sh and leave it as bash14:26
cachiosh14:26
cachiodoes it make sense?14:27
zygayes,14:27
cachioI'll just used that method in the state, then I'll update the rest of the code in a new PR14:28
cachiobecause otherwise it will be huge change14:28
cachiozyga, does it make sense?14:29
* zyga needs to take the dog for a walk14:34
jdstrandroadmr: fyi, https://dashboard.snapcraft.io/snaps/huggle/revisions/1227/ was stuck for what looked like 16 hours. I pressed the 'run the automated review again' button14:48
jdstrandroadmr: hi btw :)14:48
roadmrjdstrand: oh! so is it unstuck now?14:49
jdstrandroadmr: yes14:49
roadmryes it is!14:49
roadmrok, I'll check logs to see what may have happened.14:49
jdstrandroadmr: also, can you queue up r1078? not urgent at all. can come after the last request for pull15:03
mvosil2100, zyga trivial PR https://github.com/snapcore/core18/pull/1215:03
mupPR core18#12: hooks: trivial rename to make them consistently XXX-name.chroot <Created by mvo5> <https://github.com/snapcore/core18/pull/12>15:03
roadmrjdstrand: sure!15:03
zygaLooking15:04
zyga+115:05
sil2100Yeah, I guess it's much cleaner now15:06
jdstrandroadmr: thanks!15:06
mvozyga, sil2100 ta15:07
pedronisChipaca: we usually spell id ID15:30
Chipacawe do15:30
Chipacaoops15:31
pedronisexcept when we don't, but it's usually ID  around snap stuff15:31
pedronismajor offender seems some code in state.go15:33
pedronisuser.LookupId seems an offender in the stdlib15:35
* zyga -> food15:36
mupPR snapd#5200 opened: interfaces: reconnect, fix for autoconnect/reconnect conflict check <Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/5200>16:00
pedronisniemeyer: I asked a clarification about  common-id here:  https://forum.snapcraft.io/t/support-for-appstream-id/2327/2416:32
niemeyerLooking16:32
niemeyerpedronis: Replied16:33
pedronisniemeyer: does it mean we need validation about repeated common-ids in snapcraft, snapd?16:34
pedronisor it's benign enough, just not expected16:35
mborzeckire16:37
pedronisniemeyer: sorry, I asked here, but the answer to what to do probably should go in the forum16:38
niemeyerpedronis: I think we should enforce it in snapd/snapcraft16:38
niemeyerpedronis: Hmm.. well16:38
niemeyerpedronis: Or maybe it's not a big deal after all16:38
niemeyerpedronis: What'd be the consequences of that?16:39
niemeyerThe point is mapping id => snap16:39
pedronisnot big16:39
niemeyerIf multiple apps have the same, that's still just one id => snap arrow16:39
pedronisbut I see snapcraft does thing with common-id and desktop files16:39
pedroniswhich I'm not sure I understand16:39
pedronishow is impacted16:39
mborzeckifwiw checking for unique common-id within a snap in snap pack --check-skeleton could be easily added16:41
pedronismborzecki: we are discussing in the forum post as well16:42
niemeyerpedronis: See note16:50
cachiozyga, does it make sense what I proposed for the bash/sh discussion?16:52
zygacachio: looking now17:01
cachiozyga, tx17:01
zygacachio: not really :)17:03
zygacachio: the point was that including is confusing because there are two languages17:03
zygacachio: if you include systems.sh from bash it works ok17:03
zygacachio: if you include it from sh it will not work because [[ is not in dash17:04
zygacachio: the solution is to either use bash everywhere (I made a point that we dont) or use sh compatible code17:04
zygacachio: (like the one maciej suggested)17:05
zygadoes that make sense?17:05
cachioyes, but what is we use bash for everything?17:07
cachiowhat if17:07
zygathat is fine too17:07
zygaI personally prefer to avoid the need for bash but that's beyond the point17:07
cachiobut, all the tests run on bash17:08
cachioso the helpers could too17:08
=== pstolowski is now known as pstolowski|afk
cachio_zyga, I got disconnected17:10
zygacachio_: I didn't write more than before, my point is that we need to be consistent as we are not writing separate files that get executed but instead have a swarm of include files17:10
cachio_zyga, agree with this17:11
cachio_that's why I propose to move everything to bash17:11
cachio_as the tests are on bash17:11
cachio_and those are sourcing most of the scripts17:12
cachio_I prefer to have just 1 language17:12
cachio_so we reduce the complexity and it is more robust as well17:12
zygacachio_: ok, go ahead17:13
cachio_mvo, mborzecki guys do you agree with that?17:14
cachio_zyga, should I do it in this PR or create a new one?17:16
zygacachio_: maybe a small separate PR, although TBH your current PR just needs a tweak to be sh safe in one line and it could land as well17:16
cachio_zyga, awesome, thanks17:17
cachio_zyga, shellchecks fixed and pushed17:44
zygaack17:44
cachio_now running here on ubuntu core to make extra validation17:44
zygathanks17:45
zygaapproving17:45
cachio_zyga, thanks!!!!17:46
zygadone17:46
zygaboy, my dog is crazy today17:46
zygahe is so all over me today17:46
zygaafter being away for a week he got super lonely17:46
zygahe's literally walking overy my laptop in front of my face for attention17:47
cachio_hehehe17:56
cachio_zyga, he needs another walk17:56
zygajdstrand: can you please have another look at https://github.com/snapcore/snapd/pull/519818:06
mupPR #5198: data/systemd: add snapd.apparmor.service <Created by zyga> <https://github.com/snapcore/snapd/pull/5198>18:06
mvozyga, cachio_ I just read backlog - fwiw, we are using bashisms already in our scripts left and right, just "git grep \[\[", including in prepare-restore reset, snaps18:32
zygamvo: I know, that's fine18:32
mvozyga, cachio_ so moving "formally" to bash seems to make sense18:32
zygamvo: I think this just makes sense to do all the way18:32
mvozyga: aha, ok. maybe I missed parts of the discussion then18:32
mvozyga: +118:32
mvozyga: yeah, we are (de-facto) already doing it :)18:32
zygamvo: no, just saying that the point I was after was addressed and I already approved that18:32
mvoI mean, everywhere lib/pkgdb.sh, lib/dbus.sh18:32
mvozyga: cool, so we are all in agreement18:33
cachio_mvo, zyga agreed :)18:34
cachio_mvo, I'll create a PR for tha tchange18:36
zygasigh18:37
mvozyga: hm?18:37
zygaThe log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).18:37
zygayet we log src/github.com/snapcore/snapd/interfaces/backend.go and all the other files18:37
mvocachio_: I think its fine to keep as is and make this a separate PR, the mixing of bash/dash is not a new issue with the PR we already do it, I think it should not block this pr from landing (as long as we fix it properly in a followup). *if* its trivial, then I don't mind if its the same PR of course18:38
mupPR snapd#5201 opened: interfaces/apparmor: use helper to load stray profile <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5201>18:44
mvozyga: just finished reading the bash/dash comments, sorry that I lacked some context earlier and thank you for raising this (and now it gets fixed :)18:45
zygamvo: no worries at all :)18:45
Pharaoh_Atemzyga, fwiw, I'm totally okay with explicitly using bash19:02
Pharaoh_AtemI'm not a fan of pure-posix shellscript anyway19:02
=== r04r is now known as Guest44185
=== ahayzen is now known as Guest53889
=== Shibe is now known as Guest78958
=== mwhudson is now known as Guest32565
=== braderhart is now known as Guest74533
=== yofel is now known as Guest51009
=== Ursinha is now known as Guest40906
=== BlueShark is now known as Guest36446
=== tianon is now known as Guest43437
=== ackk is now known as Guest13403
=== icey is now known as Guest76648
=== kirkland is now known as Guest97190
=== Guest53889 is now known as ahayzen
=== Guest13403 is now known as ackk
mupPR snapd#5202 opened: packaging: filter out verbose flags from "dh-golang" <Created by zyga> <https://github.com/snapcore/snapd/pull/5202>20:04
zygajdstrand: I pathched my system not to load profiles from /var/lib/snapd/apparmor/profiles20:56
zygajdstrand: and installed the improved snapd.apparmor.service20:56
zygajdstrand: no issues20:56
jdstrandnice! :)20:56
zyga           173ms snapd.apparmor.service20:57
zygathat's according to systemd-analyze20:57
zygait is surprisingly fast20:57
zygaI assume that cached hot path (after reboot) must be in effect20:58
zygaor ... my code is a nop ;-)20:58
jdstrandyes. loading from cache is going to be fast20:58
zygareading the code carefuly I found some things to ask you20:59
zyga1) skipping in containers and 2) cache invalidation20:59
zygado I need to concern myself with 2?20:59
jdstrandzyga: 2> no. the parser will do that21:00
jdstrandzyga: since you are using --write-cache21:00
zygajdstrand: and 1) ?21:03
jdstrandzyga: you need to do that21:04
zygaack21:04
zygajdstrand: hmmm21:08
zygajdstrand: will this break snapd in lxd?21:08
zyga^ https://www.irccloud.com/pastebin/qV2tRkpA/21:08
jdstrandzyga: not if you do it right. see /lib/apparmor/profile-load and functions21:08
zygajdstrand: this is what start does as a check, is that's essentially what we need as well?21:09
zygathe reason I ask is because this check runs first21:10
jdstrandzyga: yes. udevadm info -an /dev/input/js0 is defined in /lib/apparmor/functions on ubuntu. you'd need to steal it21:10
zygaso the more sophisticated check ... wont run21:10
jdstrandwow21:10
jdstrandthat was not what I expected in my clipboard21:10
jdstrandzyga: yes. is_container_with_internal_policy is defined in /lib/apparmor/functions on ubuntu. you'd need to steal it21:10
zygahmm, but how does that code run if apparmor.service exits quickly because the code I pasted returns early?21:11
zygaah21:11
zygaI'm blind21:11
zygaI didn't see the &&21:11
zygajdstrand: do you think I can source /lib/apparmor/functions21:12
zygaI;d rather not copy that21:12
jdstrandzyga: no. that won't exist every where21:12
zygaok21:12
zygathanks!21:12
jdstrandis_container_with_internal_policy is an Ubuntu-ism since no one else had stacking until more recent kernels21:12
=== Guest44185 is now known as r04r
zygadone21:21
zygait's shellcheck clean too21:22
zygaI will reboot to give it one more test21:22
jdstrandohh!21:27
jdstrandpopey:21:27
jdstrand# evdev joystick21:27
jdstrandKERNEL=="event[0-9]*", SUBSYSTEM=="input", ENV{ID_INPUT_JOYSTICK}=="1", TAG+="snap_mame_mame"21:27
popeyis that good or bad?21:28
jdstrandpopey: that is good. that is just a change to joystick.go21:28
popeyI agree then, good :)21:28
jdstrandpopey: I'm still investigating, but that is super promising21:28
* zyga imagines jdstrand playing zelda while explaining "I'm working" at his surprised family members :)21:32
zygajdstrand: all good after reboot21:32
jdstrandzyga: it literally already happened21:32
jdstrandI think the quote was: You're doing God's work, aren't you?"21:33
jdstrandit wasn't sarcastic at all! ;)21:35
zygajdstrand: can you have a look at 5201, it's a tiny cleanup21:35
=== Guest32565 is now known as mwhudson
zygajdstrand: is adb-support something that is still blocked, maybe I don't understand your prior feedback?21:52
mupPR snapd#5119 closed: dirs: on opensuse store apparmor profiles in /etc/apparmor.d <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/5119>21:53
jdstrandzyga: approved22:04
jdstrandzyga: I haven't gotten back to re-reviewing it. I've added it to my list for tomorrow22:05
zygathanks :)22:16
zygaI will EOD today22:16
zygasee you tomorrow22:16
jdstrandzyga: take it easy22:27
jdstrandkyrofa: hey, am I remembering right that you wanted evdev joystick support?22:28
mupPR snapcraft#2146 opened: project_loader: process parts in consistent order <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/2146>22:28
kyrofajdstrand, indeed, did you figure it out?22:32
jdstrandkyrofa: yes. PR on its way22:33
kyrofaLovely!22:33
sergiusenskyrofa: you should add a test using `after` too22:36
mupPR snapd#5203 opened: interfaces/joystick: also support modern evdev joysticks and gamepads <Created by jdstrand> <https://github.com/snapcore/snapd/pull/5203>22:37
jdstrandkyrofa: ^ there you go (surprisingly simple)22:37

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!