=== r-daneel_ is now known as r-daneel
[08:27] <caribou> smoser: thanks for the info. I based my changes on the DataSourceOpenstack & DataSourceEc2 so it should be good. Merge Request to follow soon
=== boxrick_ is now known as boxrick
[12:31] <smoser> caribou: ok. its fine to share early if you want to make sure you're going in the right direction.
[13:34] <caribou> smoser: I'm about to send it; do you people want an LP bug to go along with it or simply the MR ?
[13:36] <caribou> smoser: matter of fact: https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973
[13:39] <smoser> k. thanks.
[13:46] <caribou> smoser: but for some reason, now that I packaged it it fails on me
[13:49] <caribou> & I got jenkins failure. I'll work on that
=== r-daneel_ is now known as r-daneel
=== r-daneel_ is now known as r-daneel
=== r-daneel_ is now known as r-daneel
[15:16] <caribou> smoser: I fixed the issue that might have caused the failed Jenkins build. Any way to re-launch the build ?
[15:59] <smoser> caribou: https://jenkins.ubuntu.com/server/job/cloud-init-ci/83/
[15:59] <caribou> smoser: yeah, I saw it & found the reason. I'll fix that tomorrow, it's getting near EOD
[16:00]  * caribou makes a note not to run unittests as root
[16:01] <caribou> hmm, sorry I saw build-82 which also failed for the same reason. 83 will fail as well
[16:06] <smoser> caribou: ok. thanks.
[16:57] <blackboxsw> ok decoupling azure-hotplug  from on-boot maintenance out of this wip branch today https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/347991
[17:22] <blackboxsw> smoser & rharper I've started decoupling maintenance event content into this WIP branch https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/348000
[17:23] <blackboxsw> I wanted to throw that up as a very broken/basic first start, so if there are initial suggestions to where we want to move content or behavior I can tackle that as I start adding unit tests and iron out the details.
[17:23]  * blackboxsw runs for an early lunch
[17:36] <rharper> blackboxsw: ok, I'll look
[17:46] <smoser> blackboxsw: i just tagged taht 'work in progress'
[17:46] <smoser> so pushes wont have ci on them and such
[18:26] <blackboxsw> +1 smoser thanks.
[18:26] <blackboxsw> ok starting to work on that branch in earnest now
[19:19] <blackboxsw> smoser: and rharper: if you guys get a chance to look over the fix for xenial-Ec2 that'd be great to avoid OpenStack init-local discovery
[19:19] <blackboxsw>  side-effects https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/347937
[19:19] <rharper> yeah
[19:19] <blackboxsw> it's also blocking our CI being green (and the next SRU)
[19:19] <blackboxsw> thx
[19:21] <blackboxsw> smoser are you peeking at any fixes in cloud-init  the CI lxd-cosmic issues per  https://github.com/lxc/lxd/issues/4649?
[19:26] <smoser> blackboxsw: almost have
[19:27] <blackboxsw> ok, I won't touch it, I had created a card to look at it, but I want to get the joyent/azure stuff in shape first
[19:30] <blackboxsw> card is here https://trello.com/c/bYpOVdxU/836-fix-lxc-31-301-collision-pre-existing-lxdbr0-automatic-bridge-creation
[19:31] <smoser> blackboxsw: ok. running tox locally, fixing flake8 and pushing for review
[19:32] <smoser> (and then i'll actually test :)
[19:42] <smoser> blackboxsw: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/348005
[22:05] <blackboxsw> thanks for the reviews: addressed review comments on dont-probe-openstack-ec2 branch https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/347937
[22:32] <blackboxsw> tried addressing a couple of the initial comments on the cold-plug Event handling branch to maintain network on boot https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/348000