[00:47] <mup> PR snapcraft#2162 closed: tests: new codespell, narrowed checks and better execution order <Created by sergiusens> <Merged by kyrofa> <https://github.com/snapcore/snapcraft/pull/2162>
[02:27] <tooijar> Is it possible to remove old revisions from the store?
[02:49] <Son_Goku> zyga: https://flocktofedora.org/#cfp
[05:03] <mborzecki> morning
[05:24] <mup> PR snapd#5346 opened: cmd/snap: add a backup handler for snap:// URIs that prompts the user to install the gnome-software snap <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/5346>
[06:09] <zyga> hey
[06:09] <zyga> irccloud is down, hmm
[06:13] <mborzecki> zyga: heh, looks like it
[06:13] <zyga> ok, let me push those suse PRs
[06:20] <zyga> oh, drat
[06:20] <zyga> master has even better integration
[06:20] <zyga> let me take some of that too
[06:21] <zyga> I wish the snapd.apparmor.service was in 2.33 :/
[06:26] <mborzecki> zyga: can't you backport it?
[06:26] <zyga> yeah, that's what I'm looking at now
[06:26] <zyga> it's not a large change
[06:27] <zyga> I'm building 2.33 as is to see what it lacks from the packaging in master
[06:37] <zyga> I don't love cherry picking our patches when they are not squashed
[06:38] <zyga> I guess I can branch off 2.33 and cherry pick the lot
[06:38] <zyga> then squash and export
[06:38] <zyga> right?
[06:39] <zyga> tumbleweed is on 4.17,
[06:39] <zyga> that's ... fast :)
[06:50] <mborzecki> zyga: 4.17.2-1-ARCH
[06:50] <mborzecki> probably fedora too
[06:53] <zyga> ok, patches prepared, one more build
[06:55] <zyga> Pharaoh_Atem I need to thank you for the fantastic rework of the opensuse package!
[06:55] <zyga> it makes things much easier
[06:58] <mborzecki> zyga: did you get a chance to look at #5341 ?
[06:58] <zyga> the C changes?
[06:58] <mup> PR #5341: cmd/libsnap-confine-private: intoduce helpers for validating snap instance name and instance key <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5341>
[06:58] <mborzecki> zyga: yup
[06:59] <zyga> not in detail,
[06:59] <mborzecki> probably good if jdstrand could take a look too when he comes back
[07:00] <mborzecki> btw. if nobody minds i'll be landing #5314 soon
[07:00] <mup> PR #5314: many: rename snap.Info.Name() to snap.Info.InstanceName(), leave parallel-install TODOs <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5314>
[07:04] <pstolowski> mornings
[07:04] <zyga> pstolowski hey
[07:04] <zyga> mborzecki I asked one question on the validate PR
[07:05] <zyga> https://pastebin.ubuntu.com/p/y3kjK4zXGS/ <- rpmlint report so far
[07:06] <mvo> hey pstolowski ! good morning
[07:06] <mborzecki> zyga: not sure i follow, the pr splits instance name to snap name and instance key and validates both already
[07:06] <pstolowski> mvo, mborzecki any new developments re snapd.seeded service issue? you haven't forwarded me those emails, have you?
[07:06] <zyga> yes but you _already_ have a function for splitting it
[07:10] <mborzecki> zyga: right but that code is supposed to work with validated input and dies instead of returning nice errors, i could probably rework it to use sc_error
[07:10] <zyga> ah
[07:10] <mborzecki> zyga: it will die if sc_error is unset right?
[07:11] <zyga> this makes sense
[07:11] <zyga> yes
[07:11] <zyga> sc_error was designed so that errors are either propagated or the program dies
[07:11] <mborzecki> zyga: i can look into it
[07:12] <mborzecki> mvo: do yu have any high priority pending PRs that use info.Name() that would conflict if i merge #5314?
[07:12] <mup> PR #5314: many: rename snap.Info.Name() to snap.Info.InstanceName(), leave parallel-install TODOs <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5314>
[07:13] <zyga> mborzecki btw, I want to simplify sc_error
[07:13] <mvo> mborzecki: nothing with priority, feel free to land this
[07:13] <zyga> I wrote some personal code and I evolved (simplfied) error handling a bit
[07:14] <mborzecki> mvo: ack
[07:14] <zyga> we could talk about this on Friday
[07:15] <mup> PR snapd#5314 closed: many: rename snap.Info.Name() to snap.Info.InstanceName(), leave parallel-install TODOs <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/5314>
[07:15] <zyga> [   43s] FAIL: booted_test.go:218: bootedSuite.TestUpdateBootRevisionsOSErrorsLate
[07:15] <zyga> [   43s]
[07:15] <zyga> [   43s] booted_test.go:253:
[07:15] <zyga> [   43s]     c.Assert(chg.IsReady(), Equals, true)
[07:15] <zyga> [   43s] ... obtained bool = false
[07:15] <zyga> [   43s] ... expected bool = true
[07:15] <zyga> random test failures are best
[07:16] <mborzecki> zyga: does it fail when ran isolated?
[07:16] <zyga> it didn't fail for the last N runs I did
[07:16] <zyga> I'm only tweaking linter errors so it's just random
[07:16] <zyga> I didn't try isolated yet
[07:16] <mborzecki> zyga: trid go test -c -o foo.test && while true; ./foo.test -check.f || break; done ?
[07:17] <mborzecki> mvo: do you have the log from  snapd.seeded failure? (or is pstolowski already looking into it)
[07:21] <pstolowski> mborzecki: https://pastebin.canonical.com/p/thJBrCX4wr/ ; i haven't looked at it yet but about to, mvo has some more info in emails, looking forward to them
[07:21] <mvo> mborzecki: pstolowski said he will look into it last night, I can mail the logs to both of you
[07:22] <mvo> pstolowski: I sent the mail a bit earlier is it not there yet?
[07:22] <pstolowski> mvo: nope, no emails
[07:23] <zyga> most lint errors are gone now
[07:23] <zyga> just a few more..
[07:26] <mborzecki> mvo: pstolowski: looks like snapd.seeded could use Requires=snapd.socket at least
[07:27] <pstolowski> indeed
[07:29] <mvo> mborzecki, pstolowski sent it to both of you again
[07:32] <mup> PR snapd#5347 opened: data: remove /bin/sh from snapd.sh <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5347>
[07:36] <mvo> mborzecki: did you get the mail?
[07:36] <mborzecki> mvo: yup, got it
[07:36] <mborzecki> mvo: thanks!
[07:37] <mvo> mborzecki: thank you, interessting, pstolowski did not get it, we were wondering if my fastmail provider has a problem but apparently its more complicated :/
[07:37] <pstolowski> interesting :)
[07:37] <mborzecki> mvo: yeah, got a nice fat warning from gmail about possible spoof
[07:38] <mborzecki> mvo: similar to a name in your organization but the email address does not belong to your domain or the email is not authenticated. Avoid clicking links or replying with sensitive information unless you reach out to the sender by another means to ensure that this email is legitimate
[07:42] <pstolowski> mvo: so yes looks like Requires=.. will do it, but i'd test it; how do i play with seeding?
[07:43] <mborzecki> hm i'm wondering if there could some unwanted side effect
[07:43] <mborzecki> pstolowski: mvo: maybe we should have Restart=on-failure too?
[07:44] <mvo> mborzecki: yeah, that sounds reasonable
[07:44] <mvo> mborzecki: restart on failure
[07:52] <pstolowski> allright i see some spread tests for seeding
[07:52] <mborzecki> hmm got 14% of battery left, need to find a power outlet
[07:57] <pstolowski> mvo, mborzecki okay, i'll try to amend existing spread tests to reproduce and then will apply the above plan
[07:58] <mborzecki> pstolowski: sounds good
[07:58] <mvo> pstolowski: \o/
[08:01] <mup> PR snapd#5348 opened: packaging/opensuse: snap-confine should be 06755 <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5348>
[08:11] <pstolowski> mvo: ok, the problem reproduces nicely with just examining systemctl snapd.seeded service status in existing spread test, onto fix now
[08:12] <mvo> pstolowski: yay, thank you
[08:12] <mvo> pstolowski: I will pull that into 2.33.1
[08:12] <pstolowski> ok
[08:12] <mborzecki> ok, i'm moving back home, bbiab
[08:14] <mup> PR snapd#5349 opened: packaging/opensuse: add missing bits for snapd.seeded.service <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5349>
[08:15] <Chipaca> mvo: pstolowski: which problem?
[08:16] <pstolowski> Chipaca: https://pastebin.canonical.com/p/thJBrCX4wr/
[08:16] <pstolowski> Chipaca: snapd.seeded service not waiting for snapd.socket
[08:17] <Chipaca> pstolowski: it should wait for snapd.service I'd think
[08:17] <Chipaca> unless that creates a loop
[08:22] <mup> PR snapd#5350 opened: packaging/opensuse: don't use %-macros in comments <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5350>
[08:23] <zyga> Chipaca hey sir
[08:23] <zyga> quick question
[08:23] <zyga> $(reverse complete.sh) needs to be executable, correct?
[08:23] <mup> PR snapd#5351 opened: packaging/opensuse: build position-independent binaries <Created by zyga> <https://github.com/snapcore/snapd/pull/5351>
[08:25] <Chipaca> zyga: hmm... let me remember
[08:26] <Chipaca> zyga: it doesn't need to afaik
[08:26] <zyga> it is on ubuntu
[08:26] <zyga> it isn't on opensuse
[08:26] <zyga> shall I unify some way?
[08:27] <Chipaca> zyga: we run essentially 'bash etelpmoc.sh'
[08:27] <zyga> and it is in the tree
[08:30] <Chipaca> zyga: if you have the 'http' snap installed, and you run: snap run --command=complete http 9 9 6 1 ' ' "http -" http -
[08:30] <Chipaca> zyga: if that prints a bunch of stuff, it works :)
[08:30] <Chipaca> (by a bunch of stuff i mean a list of options)
[08:31] <zyga> yes, it works
[08:31] <zyga> ok, I'll remove the +x bit then
[08:31] <Chipaca> zyga: er
[08:31] <zyga> hm?
[08:31] <Chipaca> zyga: note it's the one in the core you want to tweak
[08:31] <zyga> oh
[08:31] <zyga> bummer
[08:31] <Chipaca> :)
[08:32] <zyga> that's more work ;)
[08:33] <zyga> Chipaca ok, that works too
[08:34] <Chipaca> zyga: also it's rev <<<complete
[08:34] <Chipaca> $(rev <<<complete).sh
[08:34] <Chipaca> clearly
[08:35] <mup> PR snapd#5270 closed: snap,client: show "publisher" in `snap list` and expose in client API <Created by mvo5> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/5270>
[08:35] <mup> PR snapd#5352 opened: many: expose full publisher info of the snapd api <Created by pedronis> <https://github.com/snapcore/snapd/pull/5352>
[08:37] <Chipaca> hah! in github the way you tell it utf is ok is with 'utf8=✓'
[08:38] <pedronis> Chipaca: hi,  5352 follows your suggestion about expanding publisher in the snapd API to the same object as the v2 store API
[08:38] <Chipaca> pedronis: reviewing it already
[08:38] <Chipaca> (toggled whitespace to see the struct diffs properly which is when i noticed the utf8=✓ thing)
[08:39] <mup> PR snapd#5353 opened: data/completion: remove shebang and +x from etelpmoc.sh <Created by zyga> <https://github.com/snapcore/snapd/pull/5353>
[08:41] <Chipaca> pedronis: had we agreed on changing the column name in list?
[08:41] <Chipaca> pedronis: (that's a bigger 'we' than you and me)
[08:43] <mvo> Chipaca: for publisher instead of developer? I think we did
[08:43] <Chipaca> mvo: schweet
[08:53] <mup> PR snapd#5354 opened: packaging/opensuse: ship apparmor integration if enabled <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5354>
[08:57] <zyga_> https://code.facebook.com/posts/605721433136474/accelerate-large-scale-applications-with-bolt/ is interesting
[09:05] <zyga> Chipaca: I pushed the opposite approach, we should also perhaps look at those shellcheck warnings I posed
[09:05] <zyga> nothing there screams critical though
[09:05] <zyga> I will address those separately
[09:06] <Chipaca> zyga: sure. be careful though :)
[09:09] <pedronis> Chipaca: answered some of your comments
[09:10] <pedronis> Chipaca: also do you really meant adding output related code to the client pkg? that feels strange
[09:12] <mup> PR snapd#5355 opened: data/complete: fix three out of four shellcheck warnings in data/complete <Created by zyga> <https://github.com/snapcore/snapd/pull/5355>
[09:12] <zyga> Chipaca: I decided not to touch that last one
[09:12] <zyga> feel free to do so
[09:12] <zyga> my bash is not that fantastic to do it comfortably
[09:14] <pedronis> Chipaca: also I notice that client/packages.go imports  snap nowadays, do you know what's the expected boundary?  I could move to shared snap.StoreAccount under you unflatten request
[09:14] <pedronis> *your
[09:15] <mborzecki> re
[09:15] <zyga> 2018-06-20 09:13:55 Cannot allocate google:arch-linux-64: cannot allocate new Google server for arch-linux-64: quota 'IN_USE_ADDRESSES' exceeded. Limit: 575.0 in region us-east1.
[09:15] <zyga> google hates us todaty
[09:16] <zyga> or just me
[09:16] <mborzecki> ayy
[09:16] <pedronis> mmh
[09:16] <zyga> ETOOMANYIPV4ADDRESSESWHATWEREYOUTHINKING
[09:16] <pedronis> do we have machines left over
[09:16] <mborzecki> something not cleaning up the machines?
[09:17] <pedronis> zyga: to be fair you created a tons of small PRs it seems
[09:17] <zyga> or perhaps the many small PRs consumed too much
[09:17] <zyga> yeah, I think that's it
[09:17] <zyga> let's wait for this to settle in ~20 mintues
[09:18] <pedronis> like another round and we are in review sprint territory
[09:20] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/5342 can be merged now
[09:20] <mup> PR #5342: tests: shellchecks part 4 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5342>
[09:20] <Chipaca> pedronis: I'm +1 for shared, but gustavo has sometimes objected to it
[09:20] <zyga> I hope my small packaging fixes can mostly land very fast
[09:21] <Chipaca> pedronis: but I think we're moving towards mostly-shared, see snapshots for example
[09:21] <mup> PR snapd#5342 closed: tests: shellchecks part 4 <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/5342>
[09:21] <Chipaca> mborzecki: when is the cutover for your shellchecks work?
[09:22] <Chipaca> mborzecki: by this i mean, when would an 'exceptions' list be shorter than a 'must' list :)
[09:22] <mborzecki> Chipaca: i think we're at ~40%
[09:23] <mborzecki> i'll open another batch today
[09:23] <pedronis> Chipaca: ok, I kept it flat because is flat atm, and also there would be more churn but I can do that if you feel it's better
[09:23] <pedronis> Chipaca: did you see my questions/comment on ForTerminal ?
[09:24] <Chipaca> pedronis: I did not
[09:24] <Chipaca> got the gas inspector in, got a little sidetracked
[09:29] <pedronis> Chipaca: also if it's snap.StoreAccount it seems even a worse place for ForTerminal, I think we'll have a function with flags or functions in cmd/snap itself instead
[09:29] <mvo> mborzecki: if you want you can review your/our go-check PR, I tweaked it a little bit to address the concerns that gustavo had and I think its quite nice now
[09:30] <Chipaca> pedronis: ok
[09:33] <mborzecki> mvo: i see you've pushed the fix for basic types
[09:33] <mborzecki> nice
[09:34] <Chipaca> mborzecki: we need a 'basic types starter pack' meme now
[09:34] <mvo> mborzecki: yeah, I think/hope its good now
[09:35] <mvo> mborzecki: it still has the properties we want, i.e. big structs/long strings are nicely diffed
[09:35] <zyga> https://github.com/snapcore/snapd/pull/5350 is green and trivial, please review
[09:35] <mup> PR #5350: packaging/opensuse: don't use %-macros in comments <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5350>
[09:35] <mvo> mborzecki: if it looks good to you I will ask gustavo (either here or in the standup) for a quick look
[09:36] <zyga> https://github.com/snapcore/snapd/pull/5347 is in the same spot
[09:36] <mup> PR #5347: data: remove /bin/sh from snapd.sh <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5347>
[09:37] <zyga> mvo: trivial action on https://github.com/snapcore/snapd/pull/5331
[09:37] <mup> PR #5331: snapstate: sort "snapd" first <Created by mvo5> <https://github.com/snapcore/snapd/pull/5331>
[09:40] <mvo> zyga: thanks, will do
[09:42] <mup> PR snapd#5356 opened: packaging: require snapd.socket in snapd.seeded.service; make sure snapd.seeded.… <Created by stolowski> <https://github.com/snapcore/snapd/pull/5356>
[09:42] <pstolowski> mvo, mborzecki ^
[09:43] <pstolowski> btw, systemd didn't like Restart=on-failure, perhaps because it can't be combined with oneshot?
[09:45] <mvo> pstolowski: silly question, why is the after=snapd.socket not enough?
[09:49] <pstolowski> mvo: that's a little bit vague, see https://serverfault.com/questions/812584/in-systemd-whats-the-difference-between-after-and-requires
[09:49] <mborzecki> mvo: after is just ordering, if both seeded.service and snapd.socker are started together, seeded will be ordered after
[09:49] <pstolowski> "After= configures service order (do X only after Y), while Requires= state dependencies. If you don't specify an order, a service depending on another would be started at the same time as the one it is depending on"
[09:49] <mborzecki> but if you start seeded.service and socket is not active then it will not be started
[09:50] <pstolowski> "After= is a "loose coupling"
[09:53] <mvo> zyga: should your rpm stuff go into 2.33.1 as well?
[09:53] <mborzecki> pstolowski: right, it may nee to be one of the 'daemon' modes
[09:54] <zyga> well, the packaging/ directory can be master only
[09:54] <zyga> there are a few things we could cherry pick once everything lands
[09:54] <zyga> but I have patches in the tree so not a hard requirement
[09:54] <zyga> I'm happy if they land in master only
[09:55] <mvo> mborzecki, pstolowski thanks, I guess I'm missing something. if snapd.seeded is ordered after snapd.socket (which it currently is afaiui) then when snapd.seeded runs it should simply socket activate on snap system-info snapd. or are sockets and services started by systemd in different "runs" ?
[09:55] <zyga> mvo: thank you for the reviews!
[09:55] <zyga> https://github.com/snapcore/snapd/pull/5349 needs a 2nd review now
[09:55] <mup> PR #5349: packaging/opensuse: add missing bits for snapd.seeded.service <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5349>
[09:55] <zyga> (green and ready)
[09:55] <mvo> mborzecki, pedronis I guess my question is "why are snapd.seeded, snapd.socket" not started togehter :)
[09:56] <mup> PR snapd#5350 closed: packaging/opensuse: don't use %-macros in comments <Simple> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5350>
[09:56] <mvo> mborzecki, pstolowski is it because of the different "WantedBy"?
[09:57] <mvo> mborzecki, pstolowski sorry for the questions, just trying to understand the why behind it
[09:57] <mborzecki> mvo: my guess is that the seeded target is ordered independenly of the sockets target
[09:58] <mvo> mborzecki: yeah, I think that makes sense. I would have assumed socket targets run before the normal multi-user though. but its the best theory so far :)
[09:58] <mvo> as an experiment we could make snapd.seeded wantedby socket.target to see if that also solves the issue
[09:58] <mborzecki> mvo: or make snapd.socket wanted by seeded target
[10:00] <pstolowski> i can experiment with that
[10:00] <Chipaca> why wanted by and not before/after?
[10:01] <Chipaca> also note wantedby and requires do not imply before/after
[10:01] <pstolowski> fwtw the spread tests are happy after requires= fix
[10:01] <Chipaca> so i guess you need both
[10:01] <Chipaca> requires= and after=
[10:01] <Chipaca> or wantedby= and before=
[10:01] <pstolowski> Chipaca: atm (with my PR) we have after= and requires=, yes
[10:01] <Chipaca> (probably the former)
[10:02] <Chipaca> good
[10:06] <pedronis> pstolowski: hi, btw can your disconnect hooks PR be re-reviewed?
[10:06] <pstolowski> pedronis: not really, there is a spread test failure that may be related to conflict-checks change
[10:08] <pedronis> ok, ping me when you think I should look again
[10:09] <pstolowski> pedronis: but if you could take a look at https://github.com/snapcore/snapd/pull/5323 that would be great
[10:09] <mup> PR #5323: ifacestate: prevent running interface hooks twice when self-connecting on autoconnect <Created by stolowski> <https://github.com/snapcore/snapd/pull/5323>
[10:13] <zyga> mvo: updated https://github.com/snapcore/snapd/pull/5353 -- I also re-worded the branch description to match the final state
[10:13] <mup> PR #5353: data/completion: fix inconsistency in +x and shebang <Squash-merge> <Created by zyga> <https://github.com/snapcore/snapd/pull/5353>
[10:18] <zyga> mborzecki: can you have a quick look at https://github.com/snapcore/snapd/pull/5349
[10:18] <mup> PR #5349: packaging/opensuse: add missing bits for snapd.seeded.service <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5349>
[10:18] <mvo> I noticed we hit a GCE quota limit for IN_USE_ADDRESSES
[10:21] <zyga> likely due to the number of PRs in flight
[10:21] <mup> PR snapd#5349 closed: packaging/opensuse: add missing bits for snapd.seeded.service <Simple> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5349>
[10:21] <zyga> we discussed that above with pedronis a moment ago
[10:22] <pstolowski> oh wow that's a massive failure https://api.travis-ci.org/v3/job/394476948/log.txt
[10:23] <pstolowski> cannot allocate new Google server for ubuntu-16.04-32: quota 'IN_USE_ADDRESSES' exceeded. Limit: 575.0 in region us-east1
[10:23] <pstolowski> etc.
[10:25] <pstolowski> ah that's what you discussed above
[10:25] <zyga> mborzecki: thank you for the idea, https://github.com/snapcore/snapd/pull/5347 is now a one-liner
[10:25] <mup> PR #5347: data: remove /bin/sh from snapd.sh <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5347>
[10:29] <pedronis> pstolowski: will look at that after lunch
[10:29] <pstolowski> thx
[10:32] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/5341#pullrequestreview-130331441 is reviewed :)
[10:32] <mup> PR #5341: cmd/libsnap-confine-private: intoduce helpers for validating snap instance name and instance key <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5341>
[10:33] <mborzecki> zyga: thanks!
[10:35] <jamesh> mborzecki: for your shellcheck work, what do you think of listing the spread tests that are allowed to fail rather than the ones that are required to pass?
[10:36] <jamesh> mborzecki: I ask, because I've added new spread tests in some of my branches that failed shellcheck and didn't error out because they weren't listed in the "must" file
[10:37] <Chipaca> what's the default terminal on kubuntu, xubuntu, lubuntu, mate? <- popey?
[10:37] <mborzecki> jamesh: hm something to consider, looks like an easy change
[10:37] <popey> uh
[10:37] <popey> konsole, dunno about the others
[10:37] <jamesh> mborzecki: it seems like a check that new tests should be required to pass
[10:38] <Chipaca> popey: do you have a konsole handy? (as in already installed, at your fingertips)
[10:38] <popey> yes
[10:38] <Chipaca> popey: could you run http://paste.ubuntu.com/p/WkK7GSvhfC/ ?
[10:38] <mborzecki> jamesh: yes, that would be helpful, i could stop reminding people to add their files to must-pass list
[10:39] <jamesh> mborzecki: it would also make it easier to tell when the job was finished: you'd have an empty file listing the tests allowed to fail.
[10:41] <mup> PR snapd#5357 opened: firstboot: mark essential snaps as "Required" in the state <Created by mvo5> <https://github.com/snapcore/snapd/pull/5357>
[10:42] <popey> https://usercontent.irccloud-cdn.com/file/DtIIptAt/Screenshot_20180620_114053.png
[10:42] <popey> @Chipaca ^
[10:42] <Chipaca> zyga: what's the easiest way for a machead to run a core image?
[10:42] <zyga> machead?
[10:42] <Chipaca> zyga: person with a mac and no ubuntu
[10:42] <zyga> aaah
[10:42] <Chipaca> popey: what
[10:42] <zyga> Mac head
[10:43] <zyga> :D
[10:43] <zyga> lol, sorry, I didn't parse that at first
[10:43] <popey> Chipaca: screenshot above
[10:43] <zyga> well, those raspberry pi's, Mac-heads love to buy stuff I suspect ;)
[10:43] <Chipaca> popey: no i mean what happened to the utf8
[10:43] <popey> no clue
[10:44] <zyga> Chipaca: more seriously, if you need a VM there are several popular choices
[10:44] <zyga> VMware fusion, maybe parallels (but I didn't use it and it's a subscription now so bleh)
[10:44] <Chipaca> popey: all those should be «[…] Green ☑✅✓✔🗸🗹»
[10:45] <popey> my bad
[10:45] <mborzecki> kinkpad ;)
[10:45] <popey> kde thinkpad -> kinkpad :)
[10:45] <zyga> kinky
[10:46] <popey> https://usercontent.irccloud-cdn.com/file/hCiOpnNQ/Screenshot_20180620_114603.png
[10:46] <popey> better
[10:46] <Chipaca> thank you
[10:46] <Chipaca> popey: 18.04?
[10:46] <popey> sorry, i used the raw text from the pastebin, which was my error
[10:46] <popey> 16.04
[10:46] <popey> kde neon
[10:46] <Chipaca> popey: ok
[10:47] <Chipaca> popey: and those strings are now the right utf8 thing, in that order?
[10:48] <popey> i copypasted from the pastebin, so should be as you wrote them
[10:48] <Chipaca> IOW konsole in 16.04 renders ☑ and ✅ the same?
[10:48] <zyga> emoji support is much later
[10:48] <zyga> so that's expected
[10:48] <popey> yeah, i dont think I've fiddled much with the fonts or anything
[10:49] <zyga> is cachio around today
[10:49] <Chipaca> zyga: all of those work acceptably on gnome terminal in 16.04, fwiw
[10:49] <zyga> I wonder if spread somehow forgets to release IP addresses
[10:49] <Chipaca> zyga: no, cachio  is not around today
[10:49] <zyga> maybe after the issue we had lately
[10:49] <zyga> we killed all the stray VMs
[10:49] <zyga> but not their addresses
[10:49] <zyga> sseessesses
[10:49] <zyga> ss... ss..
[10:50] <zyga> I need a coffeee
[10:50] <zyga> eee
[10:50]  * zyga stops
[10:50] <Chipaca> Wimpress: are you around?
[10:50] <zyga> mvo: do you have permissions to see IP address allocations?
[10:52] <popey> Chipaca: he's on a call
[10:52]  * Chipaca installs mate-terminal
[10:53] <mvo> zyga: I don't think so
[10:56] <mup> PR snapd#5358 opened: tests: add spread test to ensure snapd/core18 are not removable <Created by mvo5> <https://github.com/snapcore/snapd/pull/5358>
[10:57] <ogra_> do we ignore user preferences if interfaces do autoconnect (and do we have a bug for that if this is the case) https://forum.snapcraft.io/t/snap-premissions-automatic-resets/6021
[11:05] <pedronis> ogra_: we had a bug about that what pstolowski landed a fix I think (don't remember when)
[11:06] <ogra_> well, smells like this user didnt get the fix yet ... unless it is really a UI only issue
[11:09] <pstolowski> ogra_, pedronis it landed in master on may 18th - https://github.com/snapcore/snapd/pull/4551
[11:09] <mup> PR #4551: ifacestate: do not auto-connect manually disconnected interfaces <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/4551>
[11:10] <ogra_> ah, so not in any stable release yet, that explains it
[11:15] <zyga> I guess PRs are stuck in limbo now
[11:15] <zyga> waiting to go over 49 minute mark
[11:15] <zyga> let's not open new PRs
[11:15] <zyga> or re-start anything
[11:15] <zyga> until this clears
[11:19] <mup> PR snapd#5250 closed:  interfaces/udev,misc: only trigger udev events on input subsystem as needed <Reviewed> <Squash-merge> <Created by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5250>
[11:33]  * zyga -> lunch
[11:55] <mup> PR snapd#5359 opened: spread-shellcheck: use a whitelist of files that are allowed to fail validation <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5359>
[11:55] <mborzecki> jamesh: ^^
[12:21] <mup> PR snapd#5360 opened: tests: fix shellcheck 0.5.0 warnings <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5360>
[12:30] <zyga> hmm
[12:30] <zyga> I think gce is very unhappy now
[12:31] <zyga> mvo: I'll postpone suse work until I can land the rest of the things to master
[12:31] <zyga> mvo: switching to interfaces in core18
[12:31] <mvo> zyga: yay!
[12:31] <zyga> as we discussed yesterday
[12:31]  * mvo hugs zyga 
[12:32] <mup> PR snapd#5361 opened: snapstate: allow removal of snap.TypeOS when using a model with a base <Created by mvo5> <https://github.com/snapcore/snapd/pull/5361>
[12:33] <pedronis> yes, gce issues are a bit blocking work atm
[12:34] <zyga> Murphy strikes :)
[12:34] <zyga> when Sergio is off, clouds rain
[12:35] <zyga> Pharaoh_Atem: can you please have a look at a suse packaging change: https://github.com/snapcore/snapd/pull/5351
[12:35] <mup> PR #5351: packaging/opensuse: build position-independent binaries <Created by zyga> <https://github.com/snapcore/snapd/pull/5351>
[12:42] <mup> PR core18#33 opened: hooks: install net-tools package <Created by mvo5> <https://github.com/snapcore/core18/pull/33>
[12:44] <zyga> mvo: I'm -1 on that
[12:48] <mborzecki> hm sergio off, but argentina plays their match only tomorrow ;)
[12:49] <mvo> zyga: yeah, thats fine. I was a bit split about it myself
[12:49] <zyga> mvo: I replied on the thread
[12:50] <pedronis> is a national holiday today there
[12:50] <mborzecki> i'm contemplating switching the shellcheck test to run on arch instead of 18.04, i don't really feel like building shellcheck from source
[12:50] <mborzecki> pedronis: what kind of holiday?
[12:50] <pedronis> I don't know
[12:50] <mup> PR core18#33 closed: hooks: install net-tools package <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/core18/pull/33>
[12:50] <mborzecki> :D
[12:50] <ogra_> chocolate appreciation day :)
[12:50] <pedronis> Flag Day apparently
[12:51] <ogra_> (or was it cheese)
[12:51] <mborzecki> ogra_: fondue?
[12:51] <zyga> mborzecki: cough, snap it, cough
[12:51] <ogra_> lol
[12:51] <mup> PR core18#30 closed: hooks: clenup /etc/{passwd,shadow,group,gshadow}.orig <Created by mvo5> <Merged by sil2100> <https://github.com/snapcore/core18/pull/30>
[12:51] <zyga> mvo: as I'm thinking about core18
[12:52] <zyga> mvo: can we please ship locales-all and see how big that becomes
[12:52] <sil2100> mvo: what do you think about https://github.com/snapcore/core18/pull/24 now ?
[12:52] <mup> PR core18#24: Add the systemd-sysv package for tools like shutdown and reboot <Created by sil2100> <https://github.com/snapcore/core18/pull/24>
[12:52] <zyga> mvo: I can take that if you don't NACK it
[12:52] <zyga> mvo: locales sans .mo files, that is
[12:52] <mvo> zyga: I tried that and it was huge, let me try again
[12:52] <zyga> if you teach me how to try I could do too
[12:52] <mvo> sil2100: let me check, thanks for the update
[12:52] <zyga> mvo: I'm only after the locale catalogs
[12:53] <zyga> mvo: since apps can relatively easily ship .mo files
[12:53] <zyga> (eventually)
[12:53] <mborzecki> zyga: that might not be such a bad idea after all, only nit is that it's in haskell probably pulls in several GB of packages just for the build
[12:53] <sil2100> zyga: just modify the hook for additional packages and you can add locales-all there - then just build it
[12:53] <zyga> but shipping basic locale would let us fix a class of bugs
[12:53] <sil2100> mvo: you doing that or should I check how the size changes?
[12:53] <sil2100> (to save you time)
[12:54]  * zyga hugs sil2100 and mvo
[12:54] <zyga> seems this is in good hands
[12:54] <Wimpress> Chipaca: I am now
[12:54] <zyga> I'll go back to interfaces
[12:54] <Chipaca> Wimpress: too late har har, too late har har
[12:54] <Wimpress> Sorry.
[12:57] <mvo> sil2100: feel free to test it yourself, I have a meeting in 3min
[12:57] <sil2100> mvo: building with locales-all to compare the size
[12:58] <mvo> sil2100: thank you!
[12:58] <mvo> sil2100: I also update the cleanup PR now
[12:58] <zyga> Pharaoh_Atem: thank you! I'll update that
[12:58] <sil2100> mvo: same here, although depends if I'll have my sprint load at the same time or I'll be able to get to the snappy one
[13:00] <sil2100> mvo, zyga: by installing locales-all just the snap size increased by 11 MB
[13:00] <zyga> \o/
[13:01] <zyga> that's _neat_
[13:01] <zyga> thank you
[13:01] <zyga> and if you strip the .mo files?
[13:01] <sil2100> Checking!
[13:03]  * Son_Goku still bemoans the poorly named core* snaps
[13:03]  * zyga hugs Son_Goku agreeing 
[13:04] <Son_Goku> that's probably going to be one of those things I'm not ever going to let go
[13:04] <Son_Goku> like the dumb thing with /snap
[13:16] <zyga> mvo: comment https://github.com/snapcore/snapd/pull/5361#pullrequestreview-130386914
[13:16] <mup> PR #5361: snapstate: allow removal of snap.TypeOS when using a model with a base <Created by mvo5> <https://github.com/snapcore/snapd/pull/5361>
[13:19] <mup> PR snapd#5362 opened: tests: use "ss" instead of "netstat" (netstat is not available in cor18) <Created by mvo5> <https://github.com/snapcore/snapd/pull/5362>
[13:25] <mvo> thanks zyga :)
[13:25] <mvo> zyga: will reply after the standup
[13:25] <zyga> ok
[13:51] <mup> PR snapcraft#2163 closed: tests: add lifecycle ordering tests <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2163>
[13:51] <zyga> sil2100: did you get that number without .mo files?
[13:53] <mborzecki> Chipaca: yay, getting consistent results with shellchek from snap :P
[13:53] <sil2100> zyga: not yet! We're still eh, sprint loading
[13:53] <zyga> no worries
[13:53]  * zyga wonders what is "sprint loading"
[13:53] <zyga> in a bus waiting to fly?
[13:53] <sil2100> zyga: I'll have it in a few, just need to run the build
[13:54] <sil2100> zyga: it's like, loading tasks we're going to work on during the next 2 week 'sprint' ;)
[13:54] <mup> PR snapcraft#2164 opened: add support for the "website" field in snapcraft <Created by mvo5> <https://github.com/snapcore/snapcraft/pull/2164>
[13:54] <zyga> aah
[13:54] <sil2100> 'loading' == 'committing to working on them'
[14:05] <om26er> Wimpress: ping
[14:11] <sil2100> zyga: oh, there's actually no .mo files installed
[14:12] <sil2100> Not by this package or it's dependencies
[14:12] <zyga> sil2100: thank you
[14:13] <mup> PR snapd#5354 closed: packaging/opensuse: ship apparmor integration if enabled <Simple> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5354>
[14:18] <sil2100> I was wondering why my hook wasn't changing the size, and well, it's because it wasn't removing anything
[14:21] <zyga> Thank you for checking. This is useful data
[14:21]  * zyga -> afk
[14:22] <Chipaca> mborzecki: huzzah
[14:25] <mborzecki> Chipaca: if you feel like reviewing a bit then #5359 and #5360 need some attention :)
[14:25] <mup> PR #5359: spread-shellcheck: use a whitelist of files that are allowed to fail validation <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5359>
[14:25] <mup> PR #5360: tests: fix shellcheck 0.5.0 warnings <Simple> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5360>
[14:26] <Chipaca> mborzecki: I never* don't feel like reviewing
[14:29] <Chipaca> mborzecki: question: why not parser.add_argument('--can-fail', default=os.getenv('CAN_FAIL', None)) ?
[14:30] <mup> PR snapcraft#2165 opened: many: automatically detect dependency changes <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/2165>
[14:31] <pedronis> mvo:  Chipaca: using "-"  for no publishers break yaml parsing, which we use in  the snap info test
[14:31] <Chipaca> pedronis: hah
[14:31] <Chipaca> pedronis: we use em dash for that in yaml output
[14:31] <Chipaca> pedronis: :)
[14:31] <mborzecki> hm a list item
[14:31] <pedronis> Chipaca: in info ?
[14:31] <Chipaca> pedronis: yes
[14:31] <pedronis> ah
[14:32] <Chipaca> pedronis: sorry, an en dash
[14:32] <Chipaca> 					version = "–" // that's an en dash (so yaml is happy)
[14:32] <mvo> Chipaca: nice
[14:32] <pedronis> Chipaca: only in info though, right? the other places use "-"
[14:33] <Chipaca> pedronis: yes
[14:33] <pedronis> Chipaca: thx
[14:34] <Chipaca> that, and uparrow, and horizontal ellipsis, are all in the default linux console font
[14:36] <Chipaca> mvo: :-)
[14:38] <mborzecki> Chipaca: thanks for the reviews
[14:39] <Chipaca> mborzecki: thanks for the code :)
[14:40] <Chipaca> the switch from whitelist to blacklist makes me happy
[14:40]  * Chipaca is easy to please
[14:51] <niemeyer> Okay, spread -gc seems to be working well, and spread in Travis was updated so it reports properly the job it's running for..
[14:52] <niemeyer> Please let me know if you see any bugs there
[15:07] <niemeyer> Lunch
[15:18] <mup> Issue core18#4 closed:  Crash qt gui aplication (build with core 18 on ubuntu 18.04(LXD))  <Created by EndrII> <https://github.com/snapcore/core18/issue/4>
[15:18] <mup> PR core18#24 closed: Add the systemd-sysv package for tools like shutdown and reboot <Created by sil2100> <https://github.com/snapcore/core18/pull/24>
[15:19] <mup> Issue core18#4 opened:  Crash qt gui aplication (build with core 18 on ubuntu 18.04(LXD))  <Created by EndrII> <https://github.com/snapcore/core18/issue/4>
[15:20] <mup> PR core18#24 opened: Add the systemd-sysv package for tools like shutdown and reboot <Created by sil2100> <https://github.com/snapcore/core18/pull/24>
[15:24] <kyrofa> mvo, regarding https://github.com/snapcore/snapcraft/pull/2164, is that actually supported in snapd? The thread to which you linked leads me to believe something isn't quite done there
[15:24] <mup> PR snapcraft#2164: add support for the "website" field in snapcraft <Created by mvo5> <https://github.com/snapcore/snapcraft/pull/2164>
[15:24] <cachio> niemeyer, hey, last change in spread is breaking axecutions
[15:24] <kyrofa> pedronis, what do you mean when you say website is not fully exposed to snapd?
[15:25] <cachio> niemeyer, https://travis-ci.org/snapcore/snapd/builds/394581202#L791
[15:25] <pedronis> kyrofa: the  APIs that snapd use don't all habe website as  a field
[15:25] <cachio> it is making fail all the travis builds
[15:25] <pedronis> kyrofa:  it's not a snapcraft side issue afaiu
[15:25]  * cachio afk
[15:26] <kyrofa> mvo, pedronis, jdstrand will the review tools let website through?
[15:26] <pedronis> that I don't know, likely not
[15:26] <pedronis> jdstrand is on holiday this week
[15:26] <kyrofa> We need to start using cross-project bugs for this stuff, we need to coordinate better
[15:27] <pedronis> to be fair this was a bit mvo chomping at the bit
[15:28] <kyrofa> Yeah... and it doesn't work, but I'll ignore that ;)
[15:28] <mvo> kyrofa: its not there on the snapd side yet either
[15:29] <kyrofa> mvo, haha!
[15:31] <pedronis> afaiu  this is partly supported by the store and metadata api, but not snapcraft ? or is supported by snapcraft but not over snap.yaml?
[15:32] <kyrofa> pedronis, snapcraft doesn't support a website field at all right now. Other than that, this is the first of heard of it, so I don't know the rest
[15:32] <kyrofa> Note that passthrough is available if folks are just wanting to test it out
[15:32] <pedronis> there's a forum topic with some discussion it (and store does support it)
[15:32] <pedronis> but don't think there was even agreement on the topic itself
[15:32] <kyrofa> Indeed, I read it, and came away shrugging :P
[15:33] <mborzecki> 2018-06-20 14:50:44 Cannot allocate google:ubuntu-18.04-64: cannot allocate new Google server google:ubuntu-18.04-64 (jun201446-697464): cannot find ready marker in console output for google:ubuntu-18.04-64 (jun201446-697464)
[15:42] <mup> PR snapcraft#2164 closed: add support for the "website" field in snapcraft <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapcraft/pull/2164>
[15:46] <Chipaca> mborzecki: that's google speak for "EOD byeeee"
[15:59] <pedronis> Chipaca: I updated #5352
[16:00] <mup> PR #5352: many: expose full publisher info over the snapd API <Squash-merge> <Created by pedronis> <https://github.com/snapcore/snapd/pull/5352>
[16:00] <Chipaca> pedronis: oh no
[16:00] <Chipaca> :)
[16:01] <Chipaca> pedronis: thank you
[16:01] <Chipaca> pedronis: wee, you even did the 'be more structured' thing :-D
[16:09] <abeato> niemeyer, hi, a new review is needed in https://github.com/snapcore/snapd/pull/5309 :)
[16:09] <mup> PR #5309: overlord/configstate: add watchdog options <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/5309>
[16:19] <mup> PR snapd#5348 closed: packaging/opensuse: snap-confine should be 06755 <Simple> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5348>
[16:28] <pedronis> niemeyer: gce has started given a different kind of error, what mborzecki posted above
[16:29] <niemeyer> Oops.. will have a look shortly
[16:32] <Chipaca> mborzecki: is there a 'glxgears'-like snap?
[16:33] <popey> omgiraffe is the new glxgears
[16:33] <popey> :)
[16:33] <Chipaca> :)
[16:34] <Chipaca> popey: what's missing is that ohmygiraffe has a lot of dependencies that a simple GL thing doesn't have
[16:34] <popey> yeah, true
[16:35] <Chipaca> i'm not after a "is gl working", but rather a "minimal snap that works with opengl that i can steal from"
[16:35] <Chipaca> :)
[16:35] <Chipaca> my usual technique of copying stuff until ldd stops complaining is not working
[16:35] <Chipaca> it's almost as if I should use snapcraft
[16:35]  * Chipaca ponders that
[16:37] <popey> http://paste.ubuntu.com/p/kYpjSMWWnd/
[16:37] <popey> lddtostage  script
[16:37] <popey> point it at a binary, it tells you what packages you need in stage-packages
[16:37] <Chipaca> heh :)
[16:38] <Chipaca> popey: it says I should stage 'nvidia-384'
[16:38]  * Chipaca doubts
[16:58] <niemeyer> I see the bug
[16:59] <niemeyer> mborzecki, pedronis: Please give it another shot
[17:24] <niemeyer> abeato: Thanks for the changes
[17:24] <niemeyer> abeato: Submitted a last round of details there
[17:33] <mborzecki> Chipaca: graphics-debug-tools-bboozzoo, it includes glxinfo, eglinfo, vulkaninfo and xrandr
[17:34] <Chipaca> mborzecki: i'd forgotten about those! thanks
[17:40] <abeato> niemeyer, great, thanks
[17:41] <niemeyer> mborzecki: Is it working now?
[18:05] <thiras> https://github.com/snapcrafters/discord/issues/35
[18:13] <mborzecki> niemeyer: yup, PRs are slowly getting green
[18:13] <niemeyer> \o/
[18:31] <zyga> re!
[18:31]  * zyga is done with doctors for a while
[18:31] <zyga> and all is good
[18:31] <zyga> and I can (I think) focus on work now
[19:25] <niemeyer> zyga: Congrats! :)
[19:25] <zyga> niemeyer: haha, thank you :)
[19:25] <zyga> we are all happy and now much calmer