mup | PR snapd#5448 opened: tests: start using the new opensuse image with test dependencies <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/5448> | 02:28 |
---|---|---|
mborzecki | morning | 05:13 |
pstolowski | mornings | 07:02 |
mborzecki | pstolowski: hey | 07:04 |
zyga | Hey ho | 07:05 |
zyga | A bit late today, | 07:05 |
zyga | mvo: I went on a small detour to simplify some code and add tests | 07:06 |
zyga | I have some misc branches and then more meat | 07:06 |
zyga | (Rice, soy, ...) | 07:07 |
mvo | zyga: hey, thanks | 07:07 |
zyga | I was working towards testing all of the patches properly | 07:08 |
zyga | Out of the interface WIP one | 07:08 |
mvo | zyga: neat | 07:09 |
mborzecki | mvo: zyga: hey guys | 07:10 |
mvo | hey mborzecki | 07:12 |
mborzecki | mvo: i'm looking at sysctl manpage, have you checked that sysctl -p <file> with <file> as separate arg, not -p<file> works? | 07:13 |
mvo | mborzecki: the test will check, I have not, let me try that now | 07:14 |
mborzecki | i have a vague recollection of something being iffy there, but that's from a few years back and with busybox | 07:14 |
mvo | mborzecki: I did a quick test and it seems to be fine | 07:17 |
mborzecki | mvo: ok :) | 07:17 |
mvo | mborzecki: but the test will also fail if it is not | 07:17 |
Gargoyle | Can you check the confinement of a snap before you install it? I can't see anything in "snap info x" or another obvious snap command. | 07:26 |
mborzecki | Gargoyle: try snap info --verbose | 07:26 |
Gargoyle | Cool. Ta. :-) | 07:27 |
mup | PR snapd#5447 closed: snap,interfaces: move interface name validation to snap <Core18> <Simple> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5447> | 07:28 |
mborzecki | mvo: could you take a look at #5434? | 07:36 |
mup | PR #5434: overlord: introduce InstanceKey to SnapState and SnapSetup, renames <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5434> | 07:36 |
mvo | mborzecki: sure | 07:52 |
mborzecki | mvo: ta | 07:52 |
=== matteo| is now known as matteo | ||
zyga | mvo: thanks for that! | 08:02 |
mup | PR snapd#5449 opened: snap: add helper for renaming slots <Created by zyga> <https://github.com/snapcore/snapd/pull/5449> | 08:06 |
zyga | mvo: that's one of the helpers ^ | 08:07 |
zyga | pedronis: could you please look at https://github.com/snapcore/snapd/pull/5443 - it has two reviews already but I wanted to ensure you ack it | 08:07 |
mup | PR #5443: interfaces: treat "snapd" snap as type:os <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5443> | 08:07 |
zyga | mvo: quick review on https://github.com/snapcore/snapd/pull/5446 | 08:11 |
mup | PR #5446: coreconfig: add support for `snap set core network.disable-ipv6` <Created by mvo5> <https://github.com/snapcore/snapd/pull/5446> | 08:11 |
mup | PR snapd#5445 closed: tests: add artful for sru validation on google backend <Created by sergiocazzolato> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5445> | 08:15 |
mvo | zyga: aha, nice. yeah, initially I wanted to do ipv4/ipv6 but then a) YAGNI b) ipv4 is not as straightforward | 08:16 |
=== chihchun_afk is now known as chihchun | ||
* Chipaca waves | 08:19 | |
mborzecki | Chipaca: hey, now that you're here, would you mind taking a look at #5426? :) | 08:20 |
mup | PR #5426: client, cmd/snap: pass snap instance name when installing from file <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5426> | 08:20 |
Chipaca | mborzecki: no | 08:20 |
zyga | mvo: it's fine not to do ipv4 | 08:21 |
Gargoyle | Discord have both beta and "bleeding edge" versions available, is it possible to get these wired up into the snap? | 08:21 |
Chipaca | Gargoyle: depending on who's doing the snapping, those can be tracks or just the pre-existing risks | 08:22 |
Gargoyle | Not sure what that means! :/ | 08:25 |
zyga | Gargoyle: if the people making the snap want to, they can do that with snaps | 08:25 |
zyga | Gargoyle: they can offer a beta channel/track | 08:26 |
zyga | Gargoyle: and an "edge" channel/track | 08:26 |
zyga | Gargoyle: alongside stable, that is | 08:26 |
zyga | and people installing the snap can choose which one to get | 08:26 |
Chipaca | Gargoyle: you can look at the 'go' snap for (a rather extreme) example | 08:33 |
Chipaca | Gargoyle: you can get anything from 1.6 to devel, in a snap | 08:34 |
=== chihchun is now known as chihchun_afk | ||
zyga | Chipaca: and by look we mean "snap info go" | 08:36 |
Chipaca | zyga: or gnome software, or https://snapcraft.io/go (and click on 'all versions') | 08:36 |
Gargoyle | That's a lot of options! :D | 08:37 |
zyga | Chipaca: I wonder if we will ever need to do paging on "snap info" ;-) | 08:37 |
zyga | Chipaca: hum | 08:38 |
zyga | Chipaca: why is 1.10 above 1.11? | 08:38 |
pedronis | mborzecki: I did a pass over #5434 | 08:38 |
mup | PR #5434: overlord: introduce InstanceKey to SnapState and SnapSetup, renames <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5434> | 08:38 |
zyga | Chipaca: do we need number sorting there? | 08:38 |
mborzecki | pedronis: thanks! | 08:38 |
zyga | (actually the ordering of tracks is a bit weird in general) | 08:38 |
Chipaca | zyga: there is no order to tracks yet | 08:38 |
pedronis | zyga: we don't know how to sort them, last time we had a discussion with Chipaca and other store people, we need a sort order defined in the store | 08:39 |
Chipaca | zyga: there probably will be at some point, but that point is still in the future :-) AFAIK at least | 08:39 |
zyga | Chipaca: should we version sort them "just in case" | 08:39 |
pedronis | the result we get from the store are sorted | 08:39 |
zyga | aha | 08:39 |
zyga | I see | 08:39 |
Chipaca | well | 08:39 |
pedronis | except they are lexically sorted atm | 08:39 |
Chipaca | they are _ordered_, which is more important | 08:39 |
zyga | re-sorted by us or by the store? | 08:39 |
Chipaca | :) | 08:39 |
pedronis | no, that's the point | 08:39 |
Chipaca | if snapd is sorting them, it shouldn't be | 08:40 |
zyga | ok | 08:40 |
Chipaca | snapd gets them with a defined order and should leave it alone | 08:40 |
pedronis | there's a store order (is just not a good one) | 08:40 |
pedronis | but we should't try to fix that | 08:40 |
pedronis | it's up to the store | 08:40 |
Chipaca | (to answer whether snapd sorts them i'd need to look at the code) | 08:40 |
zyga | agreed | 08:40 |
Chipaca | OTOH, snapcraft.io and 'snap info' show a different order | 08:40 |
Chipaca | so that's a separate issue i'm chasing down | 08:40 |
Chipaca | (it just so happens to be a nicer order! grrr) | 08:41 |
Chipaca | (for go, on snapcraft.io) | 08:41 |
mborzecki | pedronis: yeah, the non-test code setting InstanceKey in either snapsup or snapst lives here atm https://github.com/bboozzoo/snapd/commits/bboozzoo/parallel-install-overlord | 08:42 |
=== chihchun_afk is now known as chihchun | ||
Chipaca | pedronis: ETOOMANYCHANNELS | 08:50 |
Chipaca | er | 08:50 |
Chipaca | mborzecki: ^ | 08:50 |
Chipaca | :) | 08:50 |
mborzecki | heh | 08:51 |
zyga | pretty please https://github.com/snapcore/snapd/pull/5449 :) | 08:54 |
mup | PR #5449: snap: add helper for renaming slots <Created by zyga> <https://github.com/snapcore/snapd/pull/5449> | 08:54 |
zyga | it's short and test code | 08:54 |
zyga | mvo: thank you for the update, two more comments on 5446 | 08:59 |
* zyga coffee | 08:59 | |
mup | PR snapd#5450 opened: store: keep all files with link-count > 1 in the cache <Created by mvo5> <https://github.com/snapcore/snapd/pull/5450> | 09:11 |
mborzecki | pedronis: pushed a fix to #5434, i've tweaked the error message a little, added some tests | 09:18 |
mup | PR #5434: overlord: introduce InstanceKey to SnapState and SnapSetup, renames <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5434> | 09:18 |
zyga | mvo: one last comment on 5446, | 09:27 |
pstolowski | dog emergency, need to go to vet | 09:29 |
=== pstolowski is now known as pstolowski|vet | ||
mvo | zyga: thanks for your comment. this is a bit tricky, if things get removed sysctl -p won't work. on removal the system default is used. we can make this explicit but it has the side-effect that there will always be a sysctl file created even with an empty config | 09:30 |
mup | PR snapd#5451 opened: interfaces: honor static attributes when reloading conns <Created by stolowski> <https://github.com/snapcore/snapd/pull/5451> | 09:32 |
zyga | pstolowski|vet: interesting, reading | 09:37 |
mvo | zyga: I commented, I can rework the code accordingly | 09:40 |
mvo | zyga: I think it makes sense, will do so in a wee bit | 09:40 |
zyga | thank you, looking | 09:40 |
zyga | mvo: I commented as well, let me know where you want to take this | 09:43 |
zyga | mborzecki: replied on your comment on RenameSlot | 09:45 |
ogra_ | mvo, not sure you have noticed, ppc64el and s390x daily core snap builds failed (looks like a gpg error) | 09:47 |
mvo | zyga: thanks, I updated the code now, I think we are fine with EnsureDirState and a bit of extra smarts, I pushed a new revision, please let me know if I overlooked anything but I think we should be fine now | 09:51 |
mvo | ogra_: you mean the builds in https://launchpad.net/~snappy-dev/+archive/ubuntu/edge/+packages?field.name_filter=snapd&field.status_filter=&field.series_filter= ? | 09:52 |
ogra_ | mvo, https://launchpad.net/~snappy-dev/+snap/core/+build/267041 and https://launchpad.net/~snappy-dev/+snap/core/+build/267042 | 09:53 |
mvo | ogra_: they are flaky on these arches but not consistently failing? or am I looking at the wrong place maybe? | 09:53 |
mvo | ogra_: aha, the core snap, let me check | 09:53 |
ogra_ | it is the first build error i have seen in a while | 09:53 |
* mvo looks | 09:53 | |
ogra_ | noit flaky usually ... | 09:53 |
cjwatson | ogra_,mvo: Those are transient failures due to known keyserver network chaos | 09:53 |
ogra_ | *not | 09:53 |
cjwatson | just retry | 09:53 |
ogra_ | ah, great | 09:54 |
mvo | thanks cjwatson | 09:54 |
ogra_ | yeah, i noticed a ton of livefs mails too | 09:54 |
cjwatson | AIUI somebody discovered that you could upload a gigabyte key to the keyserver network and have it kill stuff | 09:54 |
cjwatson | or something along those lines | 09:54 |
ogra_ | lol | 09:54 |
mvo | *cough* | 09:54 |
cjwatson | the livefs stuff is different and I'm investigating | 09:54 |
ogra_ | ah, k | 09:54 |
mup | PR snapd#5428 closed: devicestate: fix panic in firstboot code when no snaps are seeded <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5428> | 09:56 |
zyga | mvo: looking | 10:02 |
zyga | mvo: it is good | 10:06 |
zyga | mvo: I suggested one more tweak to make it more clear why this happens | 10:06 |
zyga | but logic wise it is correct | 10:06 |
zyga | smart way of doing that btw :) | 10:06 |
zyga | cjwatson: so gpg network is the new bittorrent? | 10:08 |
cjwatson | hopefully not ... | 10:08 |
mvo | zyga: sure thing, thank you | 10:19 |
popey | niemeyer: any chance we can bump the largest post size from 32000 to ~40000 on discourse. I'm trying to migrate a large doc to the site, but it's ~35K | 10:20 |
niemeyer | Heya | 10:22 |
niemeyer | Which doc is that? | 10:22 |
popey | https://github.com/snapcore/snapd/wiki/REST-API | 10:23 |
popey | it's the last one still on the wiki | 10:23 |
popey | well, last one linked on the front page of the wiki | 10:24 |
niemeyer | popey: I think we should break it down a bit on the way in, even so we can read it reasonably | 10:24 |
niemeyer | popey: IIRC I provided an outline of how to break it down in the thread where we discuss the doc site | 10:25 |
popey | that seems reasonable. | 10:25 |
niemeyer | popey: We don't need to break it down every single section, but rather by area of interest or something similar | 10:26 |
popey | Robert seems to "own" that doc. I'd rather he broke it up and kept owning it | 10:26 |
niemeyer | popey: Thanks for the work on that, btw | 10:26 |
popey | I'll drop Robert a mail as he's in another TZ | 10:27 |
popey | thanks | 10:27 |
niemeyer | popey: np, and if you want I'd be happy to work with you on that migration.. it's been pending for too long | 10:31 |
zyga | mborzecki, mvo: can you please look at https://github.com/snapcore/snapd/pull/5449 | 10:50 |
mup | PR #5449: snap: add helper for renaming slots <Created by zyga> <https://github.com/snapcore/snapd/pull/5449> | 10:50 |
zyga | I have a pair of follow ups on top | 10:50 |
zyga | hmm | 10:52 |
zyga | journalctl fails to restart https://www.irccloud.com/pastebin/w7dISItk/ | 10:52 |
zyga | have you guys seen that before ^ | 10:52 |
zyga | journalctl failing to _restart_ ? | 10:53 |
* zyga -> walk | 10:57 | |
mborzecki | zyga: yes, seen it before | 10:57 |
niemeyer | mvo: Heya | 11:20 |
niemeyer | mvo: One question on spread#61 | 11:20 |
mup | PR spread#61: client: fix dialOnReboot() if the remote does not reply <Created by mvo5> <https://github.com/snapcore/spread/pull/61> | 11:20 |
mborzecki | parallel installs will be fun to merge/resolve conflicts :/ | 11:22 |
mup | PR snapd#5452 opened: store, overlord/snapstate: introduce instance name in store APIs <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5452> | 11:46 |
mborzecki | pedronis: Chipaca: probably something for you guys ^^ | 11:46 |
mborzecki | it's very likely this will conflict with changes i wanted to open for review after landing #5434 | 11:47 |
mup | PR #5434: overlord: introduce InstanceKey to SnapState and SnapSetup, renames <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5434> | 11:47 |
mborzecki | pedronis: you've seen part of the store changes 2-3 weeks ago, most of it is the same patches just updated to account for downloads + some extra adjustments | 11:50 |
zyga | re | 11:50 |
zyga | MATCH mystery again https://www.irccloud.com/pastebin/p8HCgyXK/ | 11:51 |
pedronis | mborzecki: well, I should probably land my other PR and then it will likely conflict | 11:53 |
mborzecki | pedronis: no worries, i'll keep resolving the conflicts as they come | 11:54 |
zyga | mvo: can you please review https://github.com/snapcore/snapd/pull/5449 quickly | 12:24 |
mup | PR #5449: snap: add helper for renaming slots <Created by zyga> <https://github.com/snapcore/snapd/pull/5449> | 12:24 |
mborzecki | Chipaca: did you manage to come up with anything regading 'the mystery of MATCH' yesterday? | 12:26 |
Chipaca | mborzecki: no, i didn't carry on digging | 12:26 |
Chipaca | falling too far behind with warnings | 12:27 |
mborzecki | ack | 12:27 |
zyga | thank you mborzecki :) | 12:30 |
* zyga looks at the diff from the upcoming branch and is very happy | 12:30 | |
mup | PR snapcraft#2175 opened: ci: disable osx tests until a new pyyaml is released <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2175> | 12:33 |
mvo | zyga: sure, I have a look | 12:34 |
mvo | zyga: match mystery> I think your idea to hexdump the output we got is interessting, maybe there is some whitespace mangling going on | 12:35 |
mborzecki | mvo: travis hides certain characters in the output log, though i'm not sure if the same applies to the raw log | 12:36 |
Chipaca | mborzecki: mvo: I did 'od -a' the file fwiw | 12:41 |
Chipaca | and it was fine | 12:41 |
Chipaca | (i thought i'd told you this yesterday0 | 12:41 |
Chipaca | ) | 12:41 |
Chipaca | why haven't i had lunch yet? | 12:43 |
Chipaca | also, where has my morning gone | 12:44 |
* Chipaca scrambles to get lunch | 12:44 | |
zyga | mvo: I honestly don't believe my theory anymore | 12:45 |
zyga | mvo: I bet I will be surprised by the _actual_ issue | 12:45 |
mup | PR snapd#5449 closed: snap: add helper for renaming slots <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5449> | 12:57 |
zyga | joining | 13:01 |
mup | PR snapd#5453 opened: interfaces: tweak tests to have less repetition of "core" and "ubuntu… <Created by zyga> <https://github.com/snapcore/snapd/pull/5453> | 13:03 |
zyga | mvo: ^ the small refactor for the disconnect/connect resolve with snapd awareness | 13:06 |
zyga | the patch on top of this one is the main part of the WIP branch that was still pending | 13:06 |
zyga | so very close with getting all of that out | 13:06 |
zyga | I will prepare a branch that is derived from your integration branch where I have the new patch set (from master) and see how things are going | 13:06 |
zyga | I didn't manage that last night, sorry | 13:07 |
Chipaca | cachio: the Software crash, is that in 18.04? | 13:12 |
mvo | Chipaca: artful iirc | 13:12 |
mborzecki | zyga: hmm https://paste.ubuntu.com/p/CNqt2p6gj8/ | 13:25 |
zyga | oh | 13:26 |
zyga | weird | 13:26 |
zyga | ah, sorry | 13:26 |
zyga | I didn't read this righ | 13:26 |
zyga | *right | 13:26 |
zyga | this is a bug | 13:26 |
zyga | caused by >1 instance of "change to this directory and then back" | 13:27 |
zyga | without handling the error by going to the void | 13:27 |
mborzecki | heh lucky me | 13:27 |
zyga | is this new? | 13:27 |
Chipaca | zyga: why is this a bug? | 13:27 |
Chipaca | it's in /tmp | 13:28 |
mborzecki | zyga: dk, tried to figure out why shellcheck in tests/unit/go does not work | 13:28 |
zyga | Chipaca: because the correct behavior was (and it worked before) to go to /var/lib/snapd/void | 13:28 |
Chipaca | zyga: ahhh | 13:28 |
Chipaca | zyga: maybe /var/lib/snapd/void doesn't exist? | 13:28 |
zyga | Chipaca: yes but the /tmp inside the snap is different and cannot contain what is on the host (it's a private tmp) | 13:28 |
zyga | Chipaca: oh, that's interesting | 13:28 |
zyga | does it mborzecki / | 13:28 |
mborzecki | zyga: it does drwxr-xr-x 2 root root 4096 Jul 3 12:36 void | 13:29 |
mborzecki | try it locally | 13:29 |
zyga | the permissions are wrong | 13:29 |
zyga | anyway, that's something to add to the queue | 13:29 |
zyga | probably a fallout of something that happened recently | 13:29 |
mborzecki | running it outside of tmp at least once makes the problem go away | 13:30 |
zyga | this implies the problem is in the first part of the setup code | 13:30 |
zyga | mvo: https://github.com/snapcore/snapd/pull/5446#issuecomment-402155147 | 13:32 |
mup | PR #5446: coreconfig: add support for `snap set core network.disable-ipv6` <Created by mvo5> <https://github.com/snapcore/snapd/pull/5446> | 13:32 |
=== pstolowski|vet is now known as pstolowski | ||
mvo | zyga: yeah, just noticed and looking | 13:34 |
mvo | zyga: fixed, it was just that the output of sysctl has some extra whitespace | 13:36 |
mvo | zyga: did you tag all PRs that help with the iface renames as core18? | 13:37 |
mvo | zyga: if so, I will merge and run them now against core18 | 13:37 |
zyga | no, not yet, hold on | 13:38 |
zyga | I didn't open all of them due to stacking | 13:39 |
mborzecki | zyga: https://paste.fedoraproject.org/paste/4hQSsupdzQNcvvbwpZlhUA makes it go away | 13:40 |
cachio | Chipaca, it is on 17.10 | 13:40 |
Chipaca | just finished installing it | 13:40 |
Chipaca | (because why not) | 13:40 |
mborzecki | zyga: or https://paste.ubuntu.com/p/yWyRj3Pqqj/ no clue why fpaste is so slow today | 13:42 |
Chipaca | cachio: and you start 'ubuntu software', and search for 'snapd', and the UI crashes? | 13:42 |
mborzecki | zyga: why does it even bother chdir()ing in setup_private_mount() while it done so in sc_populate_mount_ns() already | 13:43 |
mvo | zyga: no worries, I think I found the relevant ones | 13:46 |
zyga | I haven't opened all of them | 13:46 |
zyga | I actually wanted to ask you | 13:46 |
zyga | well, tell you | 13:46 |
mvo | zyga: aha ok | 13:46 |
zyga | I'll create a branch from your working one but replace the older versions of the patches as I said in the standup | 13:47 |
zyga | it's fine to test what you made, let's where it gets | 13:47 |
zyga | but I want to have a clean picture of the patches that are not in master | 13:47 |
zyga | (a list that shrinks rather than grows0 | 13:47 |
mvo | zyga: ok, it might be easier to use core18-all-fixes-all-tests-2 | 13:50 |
mvo | zyga: which is a clean master with just all the core18 PRs | 13:50 |
zyga | sure, I'll use that | 13:50 |
pstolowski | cachio: can #5391 land? | 13:50 |
zyga | nice | 13:50 |
mvo | zyga: and it also enables all core18 tests | 13:50 |
mup | PR #5391: tests: simplify econnreset test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/5391> | 13:50 |
cachio | pstolowski, yes | 13:53 |
pstolowski | thanks | 13:53 |
mup | PR snapd#5391 closed: tests: simplify econnreset test <Created by sergiocazzolato> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/5391> | 13:54 |
zyga | pedronis: thank you for the comments! I'm on that now | 13:57 |
zyga | mborzecki: we need to rework more code I'm afraid, to get the right "way" of handling that error | 13:58 |
mborzecki | zyga: i can open a PR with http://paste.ubuntu.com/p/XvBhhFSMk8/ which resolves the issue, the question is why it tries to chdir into the old cwd while doing that, since it's already being restored at the end | 14:00 |
mvo | pedronis: zyga: core18 meeting | 14:01 |
zyga | mborzecki: later | 14:01 |
zyga | ack | 14:01 |
mup | PR snapd#5369 closed: overlord,interfaces,cmd: WIP early support for interfaces on core18 <Core18> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/5369> | 14:07 |
mup | PR snapd#5453 closed: interfaces: tweak tests to have less repetition of "core" and "ubuntu… <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5453> | 14:26 |
zyga | mvo: thank you for the review, one more for implicit operations this time ^ | 14:26 |
zyga | well v | 14:26 |
zyga | 5454 | 14:27 |
mup | PR snapd#5454 opened: interfaces: prefer "snapd" when resolving implicit connections <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5454> | 14:27 |
Chipaca | cachio: how do I reproduce the crash? | 14:30 |
cachio | just open ubuntu software | 14:31 |
Chipaca | cachio: done | 14:31 |
cachio | and search "snapd" | 14:31 |
Chipaca | cachio: done | 14:31 |
Chipaca | cachio: … and the crash? | 14:31 |
mvo | zyga: thanks, looking | 14:32 |
cachio | Chipaca, did it return results? | 14:33 |
cachio | for me, it closed the app | 14:33 |
mvo | zyga: also, please share the run results if you run the full tests with your PRs against core18, maybe there is some stuff that I need to tweak | 14:33 |
Chipaca | cachio: yes | 14:33 |
Chipaca | cachio: with what version of snapd? | 14:33 |
cachio | try again | 14:33 |
cachio | I try with the 2.38.* | 14:33 |
cachio | and with 2.33.1 | 14:33 |
cachio | 2.28 sorry | 14:33 |
Chipaca | cachio: this is snapd from the package, yes? | 14:34 |
cachio | yes | 14:34 |
Chipaca | cachio: I get 2.32.9+17.10 from the archive | 14:34 |
Chipaca | cachio: where do i get 2.28 from? | 14:34 |
zyga | mvo: yes, I will share the results, I need to spend some time to prepare the branch | 14:34 |
cachio | 1 sec | 14:35 |
Chipaca | cachio: ah, i can get 2.28.5 from artful/main (as opposed to artful-updates/main) | 14:35 |
cachio | I have 2.28.5+17.10 | 14:35 |
Chipaca | cachio: yes, taht's the one in artful/main (you've not updated) | 14:36 |
ogra_ | mvo, zyga i recently see this (not sure if it was there before) when starting a core 16 edge image on my pi's https://paste.ubuntu.com/p/gGKBBSG4nB/ ... the system seems to behave normally but it prints in red during boot so it is pretty noticeable | 14:36 |
Chipaca | cachio: apt update && apt upgrade should get you 2.32.9 | 14:36 |
Chipaca | cachio: in any case, it worked ok with both | 14:37 |
Chipaca | cachio: also with core from edge | 14:37 |
Chipaca | so I don't know what I'm looking for | 14:37 |
cachio | Chipaca, it is failing here | 14:38 |
cachio | perheps it is a different version of ubuntu software | 14:38 |
cachio | did you search for something else and then "snapd" | 14:39 |
cachio | ? | 14:39 |
cachio | Chipaca, I just got distro_install_package google-compute-engine | 14:39 |
cachio | sorry, seg fault | 14:39 |
zyga | ogra_: that's very interesting | 14:40 |
zyga | can you provide journal data from that service? | 14:40 |
cachio | Chipaca, [ 173.948719] pool[1815]: segfault at 0 ip 00007fdea83ec1f0 sp 00007fde6effc7e8 error 4 in libglib-2.0.so.0.5400.1[7fdea83b2000+111000] | 14:40 |
cachio | Chipaca, gnome-software 3.26.1 | 14:41 |
zyga | ogra_: thank you for reporting this | 14:41 |
mup | PR snapd#5455 opened: many: assorted shellcheck fixes <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5455> | 14:42 |
Chipaca | cachio: how much memory in your vm? | 14:42 |
cachio | 2GB | 14:43 |
Chipaca | cachio: can you try with 4? | 14:43 |
cachio | sure | 14:43 |
Chipaca | cachio: gnome-software is that same version here | 14:43 |
Chipaca | cachio: it doesn't crash here with 2 either though | 14:45 |
cachio | Chipaca, weird, I'll update snapd and retry | 14:46 |
cachio | Chipaca, perhaps we are using different artfull images | 14:48 |
Chipaca | cachio: I'm just running it with kvm after installing it from the artful desktop iso, so yeah | 14:50 |
Chipaca | cachio: how are you running yours? | 14:50 |
cachio | same, but using virtual machine manager | 14:51 |
zyga | "options matteR" | 14:53 |
Chipaca | zyga: -march=broken | 14:53 |
cachio | Chipaca, after upgrade all the packages the ubuntu software does not crash anymore | 14:54 |
Chipaca | cachio: i'm not sure if that's a win or a lose | 14:54 |
cachio | did you upgrade before trying to reproduce it? | 14:55 |
zyga | Chipaca: virtio/accel all kinds of visual magic nobody knows how to run by hand | 14:56 |
mup | PR snapd#5411 closed: many: remove core-support interface <Core18> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/5411> | 14:56 |
Chipaca | cachio: I think I checked the "download ugprades while installing" checkbox | 14:57 |
Chipaca | cachio: should I try again without that? | 14:57 |
Chipaca | (i then also upgraded, and then tried with snapd from edge) | 14:57 |
Chipaca | (i didn't understand exactly what you're trying to do so i covered most things) | 14:58 |
Chipaca | i can easily re-install it without the upgrades checkbox | 14:58 |
cachio | Chipaca, I don't know which is the error, if we need to fix something og it is already fixed :( | 14:58 |
Chipaca | cachio: when you installed, did you check the 'download upgrades' button? | 14:59 |
cachio | no | 14:59 |
Chipaca | i'll try without that | 14:59 |
cachio | basically, I installed as clean as possible | 14:59 |
cachio | then I reproduced the error | 15:00 |
Chipaca | cachio: and what is the error blocking us from doing? | 15:00 |
cachio | Chipaca, well, for sru we have a test which searches "snapd" | 15:00 |
cachio | and then install test-snapd-tools | 15:01 |
cachio | and it was failing | 15:01 |
Chipaca | cachio: but for the sru test you've upgraded snapd to the sru version, right? | 15:01 |
cachio | yes | 15:01 |
cachio | it is also happening for 2.33.1 | 15:01 |
cachio | I just upgraded snapd | 15:01 |
cachio | not all the packages | 15:02 |
Chipaca | cachio: so it's not happening for you with 2.28.5? | 15:05 |
ogra_ | pedronis, hmm, should the connections: keyword in gadget.yaml work with the snapd in beta ? ubuntu-image gets me: | 15:06 |
ogra_ | gadget.yaml parse error: Invalid gadget.yaml @ connections | 15:06 |
cachio | Chipaca, yes | 15:06 |
Chipaca | cachio: yes it isn't? | 15:06 |
cachio | it happes | 15:06 |
cachio | happens | 15:06 |
Chipaca | … | 15:06 |
Chipaca | cachio: so again, i ask, what are we testing | 15:06 |
cachio | with 28.5 and 33.1 | 15:06 |
cachio | Chipaca, we test the integration between ubuntu software and snapd | 15:07 |
Chipaca | cachio: but you're not testing the SRU package | 15:07 |
cachio | yes | 15:07 |
cachio | Chipaca, let me explain | 15:07 |
Chipaca | please because I'm losing it | 15:07 |
pedronis | ogra_: yes, should work, are you sure ubuntu-image is using the right snapd? | 15:07 |
Chipaca | (fresh reinstall, this time no updates selected, no crashes here) | 15:07 |
cachio | what I did is: I installed the snapd from proposed in a vm | 15:08 |
cachio | I searched snapd in ubuntu software and I saw the crash | 15:08 |
pedronis | ogra_: or ubuntu-image does its own strict parsing? in which case it needs fixing | 15:08 |
ogra_ | pedronis, no idea, which one should it use ? the image itself is built with --channel edge, the machine executing ubuntu-image runs 16-2.34~pre1 from beta | 15:08 |
cachio | then in another vm which was totally clean | 15:08 |
ogra_ | ah, i didnt think u-image does parsing at all and relies on snap prepare-image | 15:09 |
cachio | Chipaca, I did the same with without the sru package to check if it was a regression | 15:09 |
pedronis | ogra_: well it needs to parse volumes | 15:09 |
ogra_ | oh, indeed | 15:09 |
cachio | Chipaca, and I reproduced the error with 28.5 | 15:09 |
pedronis | but indeed I didn't think it would do strict parsing | 15:09 |
ogra_ | yeah, that m,ight be it then | 15:09 |
cachio | Chipaca, so, it wasn't a regressions | 15:09 |
cachio | Chipaca, that's it | 15:09 |
Chipaca | cachio: ok | 15:09 |
pedronis | ogra_: in which case, can you open a u-i bug? | 15:09 |
Chipaca | cachio: so, I have again not been able to reproduce the issue | 15:10 |
Chipaca | just in case, I'll grab the snapd from proposed | 15:10 |
ogra_ | pedronis, yeah, i'll look into it and file a bug | 15:10 |
cachio | Chipaca, it is ok, it is the same I did | 15:10 |
cachio | Chipaca, I suppose there is something else causing this | 15:11 |
cachio | another package | 15:11 |
cachio | and perhaps you are using an new iso | 15:11 |
cachio | and I am using an old one | 15:12 |
Chipaca | cachio: 17.10 doesn't have more than one iso | 15:12 |
Chipaca | afaik | 15:12 |
Chipaca | cachio: just tried with snapd from proposed, also no crash | 15:13 |
cachio | Chipaca, in the clean image, with no upgrades? | 15:14 |
Chipaca | cachio: yes | 15:15 |
Chipaca | cachio: can you strace the process? | 15:15 |
Chipaca | cachio: that is: start it, then check its pid and use strace -f -p <that pid> | 15:16 |
Chipaca | (just stracing ubuntu-software doesn't work) | 15:16 |
cachio | Chipaca, sure | 15:23 |
mup | PR core#92 opened: Remove core-support plug <Created by zyga> <https://github.com/snapcore/core/pull/92> | 15:31 |
zyga | mvo: I created https://github.com/snapcore/core/pull/92 and I'm testing a corresponding change to snapd master | 15:32 |
mup | PR core#92: Remove core-support plug <Created by zyga> <https://github.com/snapcore/core/pull/92> | 15:32 |
zyga | I will just drop the plug from the core snap | 15:32 |
zyga | CC jdstrand, pedronis ^ | 15:32 |
cachio | Chipaca, https://paste.ubuntu.com/p/HzzcTp3cWz/ | 15:34 |
cachio | 404 | 15:34 |
Chipaca | [pid 1931] sendto(20, "GET /v2/snaps/(null) HTTP/1.1\r\nH"..., 177, MSG_NOSIGNAL, NULL, 0) = 177 | 15:35 |
Chipaca | that looks a lot like a bug in gnome software or libsnapd-glib1 | 15:35 |
cachio | yes | 15:35 |
cachio | because if I search another string it works | 15:35 |
Chipaca | cachio: but if you upgrade everything (not to proposed, just regular artful-updates) the bug goes away? | 15:36 |
cachio | Chipaca, yes | 15:36 |
cachio | Chipaca, I just realized that when you could not reproduce the error | 15:37 |
Chipaca | cachio: so, I'd drop robert ancell an email about this, but it's probably known and fixed already | 15:37 |
Chipaca | cachio: I suggest we update the SRU testing to say we upgrade to whatever's in -updates before trying snapd from -proposed | 15:38 |
Chipaca | but I don't know if that's kosher | 15:38 |
Chipaca | mvo: would that be ok? | 15:38 |
mvo | Chipaca: yes, absolutely fine | 15:40 |
mvo | Chipaca: and sensible | 15:40 |
mvo | zyga: I'm dying of curiosity, how is the core18 main test run going? | 15:41 |
zyga | mvo: I haven't started everything-at-once yet, I'm still running partial checks for the things I'm changing | 15:41 |
Chipaca | zyga: running like the little lambs in https://www.youtube.com/watch?v=WQO-aOdJLiw | 15:41 |
zyga | mvo: ~3 hours from now realistically (I want to break now to take a walk before it's dark) | 15:41 |
mvo | zyga: ok, thanks for the update .) | 15:42 |
* mvo hugs zyga | 15:42 | |
mvo | zyga: sorry for being so impatient | 15:42 |
zyga | no worries, it's good to check :) | 15:42 |
zyga | mvo: I'm running a full main run with snapd modified to kill core support | 15:49 |
zyga | clarification: with snapd modified to remove the core-support-plug from the core snap | 15:49 |
mup | PR snapd#5456 opened: snapstate: refuse to remove bases or core if snaps need them <Created by mvo5> <https://github.com/snapcore/snapd/pull/5456> | 15:50 |
* cachio lunch | 15:51 | |
zyga | mvo: https://github.com/snapcore/snapd/pull/5456/files#r199860433 | 15:55 |
mup | PR #5456: snapstate: refuse to remove bases or core if snaps need them <Created by mvo5> <https://github.com/snapcore/snapd/pull/5456> | 15:55 |
zyga | mvo: mainly to put the logic about "I need this" in one clear spot | 15:55 |
zyga | and not all over the place | 15:55 |
zyga | the first one is giving you simple hints (all the snaps with those names are related to myself) | 15:55 |
zyga | this would return the base snap | 15:55 |
zyga | but also, perhaps, default content provider or even the one that is connected right now | 15:56 |
zyga | the second would look at a real snap info and say if this is ok to remove | 15:56 |
zyga | I suspect they may need snap state at that time | 15:56 |
zyga | (I didn't include that in my comment on the PR) | 15:56 |
zyga | so that we can check connections and what not | 15:56 |
zyga | just a though, I'll go for a walk now because it will be getting dark soon and woods are not like a park | 15:57 |
=== chihchun is now known as chihchun_afk | ||
zyga | mvo: still testing, got one error that spewed megabytes of journal that didn't say much, re-testing that one to see if it is something real | 16:30 |
zyga | mvo: please review https://github.com/snapcore/core/pull/92 if you can | 16:30 |
mup | PR core#92: Remove core-support plug <Created by zyga> <https://github.com/snapcore/core/pull/92> | 16:30 |
zyga | mvo: I will really really go in ~30 minutes because $life tasks | 16:31 |
mvo | zyga: thanks for the upate | 16:33 |
zyga | mvo: I added a patch that does the removal snapd-side, if it works I will open another PR | 16:35 |
zyga | mvo: can we land https://github.com/snapcore/snapd/pull/5443 | 16:37 |
zyga | I think we can now | 16:37 |
mup | PR #5443: interfaces: treat "snapd" snap as type:os <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5443> | 16:37 |
zyga | mvo: and we need a review on https://github.com/snapcore/snapd/pull/5454 | 16:37 |
mup | PR #5454: interfaces: prefer "snapd" when resolving implicit connections <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5454> | 16:37 |
mvo | zyga: ok | 16:38 |
Son_Goku | :/ | 16:39 |
Son_Goku | this bug is really bothering me | 16:40 |
Son_Goku | I really don't know what causes this | 16:40 |
Son_Goku | and the worst part is, it's pretty easily reproducible | 16:40 |
zyga | Son_Goku: I have no idea, I have a F28 system to play with but I'm deep in core18 work that actually a prerequisite for fedora snap that works without pulling in ubuntu | 16:41 |
Son_Goku | yeah | 16:41 |
zyga | Son_Goku: the work is also time boxed as we are running towards a commercial deadline | 16:41 |
Son_Goku | oh? | 16:42 |
zyga | Son_Goku: I will devote way more time to fedora after this | 16:42 |
zyga | Son_Goku: just making core18 available | 16:42 |
mvo | Son_Goku: how is it reproducible? | 16:42 |
zyga | for customers that want that | 16:42 |
zyga | Son_Goku: is it _any_ snap that triggers this? | 16:43 |
Son_Goku | zyga, the launching of a snap seems to do it | 16:44 |
Son_Goku | I triggered it with ohmygiraffe | 16:45 |
zyga | Son_Goku: thanks | 16:46 |
zyga | well | 16:46 |
zyga | can you check if hello-world does that too? | 16:46 |
zyga | it's shorter to strace to eventually find out what the problem is | 16:46 |
Son_Goku | I'll check later in the day | 16:47 |
Son_Goku | I'm unfortunately busy at the moment | 16:47 |
zyga | no worries, thank you for the information | 16:48 |
cachio | zyga, the documentation for spread images is described on this PR | 16:54 |
cachio | https://github.com/snapcore/spread-images/pull/13 | 16:54 |
mup | PR spread-images#13: Adding base images and test dependencies including new documentation <Created by sergiocazzolato> <https://github.com/snapcore/spread-images/pull/13> | 16:54 |
* zyga hugs cachio :-) | 16:56 | |
cachio | zyga, it is first version | 16:56 |
cachio | zyga, open to rewrite it if needed :) | 16:57 |
zyga | I will read it | 16:57 |
cachio | thanks | 16:58 |
ahoneybun | I'm seeing an issue with snapd.service that it has issues starting. So it is holding the boot process. | 17:00 |
ahoneybun | I can provide log files. | 17:00 |
zyga | ahoneybun: please report all you know in a forum thread on forum.snapcraft.io | 17:00 |
zyga | and coordinate here for more feedback as we review | 17:01 |
zyga | mvo: I tested master with this extra patch https://github.com/zyga/snapd/commit/366ca43e3149db942207e6e81a0b17fe61f80f0c | 17:03 |
zyga | mvo: and this test change https://github.com/snapcore/snapd/compare/master...zyga:feature/lessen-use-of-core-support?expand=1 | 17:03 |
zyga | I will propose the test change in a moment, | 17:03 |
zyga | this will let us land the core change with confidence (dropping core-support-plug from core{,16} | 17:04 |
zyga | mvo: I haven't done that yet but we can also drop it from core18 if it is there, I haven't checked yet | 17:04 |
zyga | I'm running one more test on this upcoming branch in isolation (without the suppor patch that removes core-support-plug programmatically) | 17:05 |
zyga | jdstrand: briefly, my mind thought about having compiler.apparmor.net that exposes ultra-fast, cached apparmor_parser | 17:10 |
zyga | especially since it would have a small (<<~1M) set of profiles | 17:10 |
zyga | that could be cached efficiently | 17:10 |
zyga | and it would probably scream from RAM on a modest server | 17:11 |
zyga | it could reply with some status code if overloaded (fallback to local) | 17:11 |
zyga | but on slow machines it would meaningfully speed things up | 17:11 |
mup | PR snapcraft#2175 closed: ci: disable osx tests until a new pyyaml is released <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2175> | 17:49 |
mvo | zyga: core18 does not have this plug | 18:50 |
zyga | mvo: that's great | 18:54 |
zyga | tests passed, opening PR | 18:54 |
zyga | mvo: one more, I hope it passes | 18:56 |
mup | PR snapd#5457 opened: many: lessen the use of core-support <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5457> | 18:57 |
* cachio afk | 19:04 | |
twobitsprite | I'm trying to boot up the KVM/Qemu image and it stalls booting right after "Started network service" and ssh is just reseting connection... it's been sitting there like that for about 10 minutes... | 20:58 |
twobitsprite | Err... sorry, I thought this channel was dedicated to Ubuntu Snappy Core, not the whole snappy project :P | 21:01 |
twobitsprite | Is there a better place to ask about Ubuntu Snappy? | 21:02 |
mup | PR snapcraft#2174 closed: build_providers: inject snaps when running from a snap <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2174> | 21:16 |
mup | PR snapd#5458 opened: tests: check catalog refresh before and after restart snapd <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/5458> | 22:03 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!