=== otubo3 is now known as otubo [16:35] smoser: pushed changes to https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349081 [16:55] blackboxsw: it seems wrong to have sles and opensuse retain their old behavior though, doesnt it ? [17:11] caribou: please ping me if you need any help for scaleway datasource stuff [17:48] smoser: probably, and I don't think that value in sles is actually used anywhere in cloud-init either so aligning that with other distros would be helpful more than harmful [17:48] I'm adding a comment to the branch right now [17:52] pushed that branch using load_shell_content, thanks for the review [18:08] blackboxsw: c-i doenst like you [18:11] c-i doens't like anyone right now [18:11] oh? [18:11] lxc seems to be hosed [18:11] https://jenkins.ubuntu.com/server/job/cloud-init-ci/145/console i dont think was generic [18:11] ah ok he hasn't gotten that far :D [18:12] ugh. but also doesnt seem related to branch [18:12] oh. yes it does [18:18] hab [18:18] bbah [18:18] got it [18:33] blackboxsw: use of 'dedent' on OS_RELASE_DEBIAN is unnecessary [18:33] probably want to indent that like the others tehre. [19:10] pushed fixes. will land it once ci passes again [19:45] powersj: smoser also for today (for cosmic plus SRU) doc changes https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349209/+edit-description [19:45] https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349209 rather [19:51] powersj: so I can rely on https://jenkins.ubuntu.com/server/job/admin-lp-git-autoland/11/ to land the following right? https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349081 [19:51] yep [19:52] blackboxsw: it is in testing now [19:52] https://jenkins.ubuntu.com/server/job/cloud-init-autoland-test/4/console [19:59] blackboxsw: landed: https://jenkins.ubuntu.com/server/job/admin-lp-git-autoland/12/console [19:59] https://bugs.launchpad.net/cloud-init/+bug/1780481 [19:59] Ubuntu bug 1780481 in cloud-init "ubuntu/centos/debian: get_linux_distro has different behavior than platform.dist" [High,Fix committed] [19:59] bug marked fix committed :D [20:00] excellent [20:01] thanks for the review smoser: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349209 is approved now [20:03] * blackboxsw kicks the autoland-trigger job [20:19] smoser: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349210 is for cosmic [20:22] and bionic https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349212 [20:23] bah dentist appt, back in an hour [21:10] blackboxsw: i think i might miss you here.. [21:13] No smoser wrapping up [21:13] No prob [21:14] https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349212 [21:20] i'll come in and upload for you late.r [21:21] Thx will address it in 10 mins [21:51] blackboxsw: add the bug reference [21:51] https://github.com/CanonicalLtd/uss-tableflip/pull/1 [21:51] http://paste.ubuntu.com/p/Q2ZPSkPxBV/ [21:51] hrm smoser: shall I remove it from the previous changelog? [21:52] ahh you mean geT_linux_distro [21:52] ok. not SRU bug [21:52] right. [21:52] make sense ? [21:52] was wondering again what we do about SRU bug# that was on previous changelog [21:52] yeah, i think you have it right now [21:52] leave the previous changelog alone right?it alone right [21:52] leave the previous changelog alone right? [21:52] yes. you leave the old in place [21:52] it is "burned" [21:52] ok doing that now [21:53] and then i have to remember when i upload to use '-v18.3-0ubuntu1~18.04.1' to debuild [21:53] and /me has to run... back in 2 hours or so to upload for you. [21:53] later [21:58] pushed xenial, artful, bionic [21:58] xenial: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349223 [21:58] artful: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349222 [21:59] bionic: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349212