[06:23] <didrocks> good morning
[06:31] <duflu> Morning didrocks
[06:43] <didrocks> hey duflu
[07:49] <oSoMoN> good morning desktoppers!
[07:49] <duflu> Morning oSoMoN
[07:56] <willcooke> morning
[07:57] <didrocks> salut oSoMoN, hey willcooke
[08:14] <duflu> Hi willcooke
[08:54] <duflu> Fine then
[08:57] <willcooke> afternoon duflu
[09:52] <andyrock> goodmorning all
[09:54] <oSoMoN> good morning andyrock
[09:59] <duflu> Hi andyrock
[13:45] <andyrock> am I the only one having trouble with gitlab.gnome.org today?
[13:51] <seb128> hey andyrock, what sort of issues? I just tried to browse the open bugs for g-c-c and that loads fine
[13:51] <andyrock> I can't open a MR
[13:54] <willcooke> hey seb128!  Day off fail?
[13:54] <seb128> andyrock, ask maybe on #gnome-hackers?
[13:55] <seb128> willcooke, kid is sleeping and I'm watching wimbledon, I just decided to check the status of the SRU uploads I did yesterday and clean some emails, maybe I can swap one or two hour in exchange to go play some tennis next week :)
[13:56] <seb128> well, I mean if I'm top of my todolist that free some time for exercice, so it's not like I wasted vac hours :)
[13:56] <willcooke> good plan"
[13:57] <seb128> how are things going here today? I guess it's a quiet day with friday and some people having a day off  post GUADEC
[14:05] <andyrock> seb128: is gnome-intial-setup already using git also for debian changes?
[14:05] <kenvandine> hey seb128
[14:06] <seb128> andyrock, don't ask me, I emailed Robert about it yesterday, that vcs with a big patch that keeps being rebased doesn't make any sense to me
[14:06] <seb128> like we don't even have a vcs history of our changes
[14:06] <seb128> https://gitlab.gnome.org/Community/Ubuntu/gnome-initial-setup/commits/ubuntu-welcome/gnome-initial-setup/pages/ubuntu-changes
[14:06] <seb128> how wth is that
[14:06] <seb128> kenvandine, hey, how are you? had a good trip back?
[14:06] <kenvandine> long :)
[14:06] <kenvandine> very tired today
[14:06] <kenvandine> but hanging in there
[14:06] <seb128> you should take some rest and not be on IRC
[14:06] <seb128> haha
[14:07] <seb128> andyrock, I think we should change g-i-s to use a standard git layout
[14:07] <kenvandine> need to prepare for the next trip this weekend :)
[14:07] <seb128> I don't even understand why Robert did that
[14:07] <andyrock> seb128: yeasterday I merged your change wihout rebasing
[14:07] <kenvandine> he tried explaining that at one point
[14:07] <kenvandine> and i didn't understand
[14:07] <didrocks> hey seb128! :)
[14:07] <seb128> he said that it was too complicated rebasing basically
[14:07] <kenvandine> but that doesn't really make sense
[14:07] <seb128> hey didrocks, how are you? didn't you say you wouldn't be around today?
[14:07] <kenvandine> well
[14:08] <andyrock> the problem now is that I want to work on that thing we were discussing yeasterday
[14:08] <andyrock> but I'm not sure which branch should I use as a base
[14:08] <kenvandine> maybe it's not easy, but it's also a pain for anyone else
[14:08] <andyrock> https://code.launchpad.net/~usd-import-team/ubuntu/+source/gnome-initial-setup/+git/gnome-initial-setup/+ref/ubuntu/bionic
[14:08] <seb128> andyrock, just use trunk and we distro patch diff and let Robert sort out the Vcs
[14:08] <andyrock> ?
[14:08] <didrocks> seb128: the doctor isn't available today, so I couldn't fetch my receipt. Will get it Wednesday thus
[14:08] <seb128> didrocks, ah ok :/
[14:09] <seb128> andyrock, I would work on top of https://gitlab.gnome.org/Community/Ubuntu/gnome-initial-setup/tree/ubuntu-welcome or just make a debdiff
[14:09] <seb128> we need Robert to fix the vcs, nobody seems able to work with what he did
[14:09] <andyrock> seb128: but that's not bionic
[14:10] <didrocks> meson doc is so hard to read…
[14:11] <seb128> andyrock, https://gitlab.gnome.org/Community/Ubuntu/gnome-initial-setup/tree/ubuntu-welcome-bionic is bionic?
[14:11] <andyrock> ah ok
[14:12] <andyrock> makes sense
[14:16] <andyrock> seb128: regarding https://gitlab.gnome.org/Community/Ubuntu/gnome-initial-setup/merge_requests/6/diffs?commit_id=117891aa84ab5b7079c72e1a04a3b43d6c0edb73
[14:16] <gitlab-bot> Ubuntu issue (Merge request) 6 in gnome-initial-setup "livepatch: show an dialog in case of error" (comments: 7) [Closed]
[14:16] <andyrock> the problem was that we cannot SRU because of the new strings?
[14:18] <seb128> andyrock, changes "39",  new UI, new strings ... it just looked like too much change to SRU the week before .1 to me
[14:19] <seb128> too risky and no time for translations
[14:19] <andyrock> nah it's not 39 changes
[14:20] <andyrock> it shows 39 changes because of the weird rebase system
[14:21] <andyrock> the dialog will show just in case of error and the same strings are used in software properties
[14:22] <seb128> k, so that might be fine
[14:22] <andyrock> the only problem is this string: _("You're all set: Livepatch is now being enabled.")
[14:22] <seb128> get a patch for bionic and I look at it on monday
[14:22] <seb128> that's a new one?
[14:22] <andyrock> yeah
[14:22] <seb128> we have no time for translations and langpack updates now
[14:22] <andyrock> we can remove this string
[14:22] <seb128> so maybe it's best to jsut land it as a SRU post .1
[14:23] <andyrock> kk
[14:23] <seb128> when is it displayed?
[14:23] <seb128> where
[14:23] <andyrock> in the main UI
[14:23] <andyrock> right now we get _("You're all set: Livepatch is now on.")
[14:24] <andyrock> but the true benefit of this fix is that we're sure that we close gnome-initial-setup once livepatch has answered us back
[14:24] <andyrock> so I can propose a branch with the same fix but using the same string
[14:24] <seb128> yeah, that would be better
[14:24] <andyrock> string is just a minor change
[14:25] <seb128> we can SRU a string change if we believe that's worth it
[14:25] <andyrock> sure
[14:25] <seb128> but that needs coordination with translators
[14:25] <andyrock> I'll add a comment
[14:25] <seb128> so post .1
[14:25] <seb128> thanks
[14:25] <andyrock> np!
[14:58] <andyrock> seb128: https://gitlab.gnome.org/Community/Ubuntu/gnome-initial-setup/merge_requests/8
[14:58] <gitlab-bot> Ubuntu issue (Merge request) 8 in gnome-initial-setup "livepatch: show an dialog in case of error" (comments: 0) [Opened]
[14:58] <seb128> andyrock, thx
[14:59] <andyrock> I cherry-picked one and added a commit on top of it
[14:59] <andyrock> this way it's going to be easier to review and to revert the fix later on
[15:00] <seb128> great
[16:44] <willcooke> g'night all.  seb128 forgot to ask, can you run the meeting etc on Tuesday.  Assume I won't be around much next week
[16:45] <willcooke> I'll keep you posted on how it goes
[16:45] <willcooke> ta ta
[18:03] <oSoMoN> week-end, have a good one!