/srv/irclogs.ubuntu.com/2018/07/18/#snappy.txt

=== amurray` is now known as amurray
=== pstolowski|afk is now known as pstolowski
pstolowskimorning07:17
mvohey pstolowski, good morning07:18
mvo 07:24
Chipacamoin moin07:56
Chipaca...rude.07:58
mvoChipaca: hey good morning!07:59
mvoChipaca: rude?08:00
Chipacamvo: joke about somebody leaving without a word just after I said hello08:01
mvohaha08:01
=== jacekn_ is now known as jacekn
Chipacamvo: do you ready z_yga's "+1 but" as an actual +1, i.e. can I merge #5524?08:31
mupPR #5524: cmd/snap: check for typographic dashes in command <Created by chipaca> <https://github.com/snapcore/snapd/pull/5524>08:31
Chipacaread*08:31
Chipacamvo: also, did we reach a consensus on the flag to watch for "do not error if none found"? I know we agreed it wasn't --oknodo :-)08:32
Chipacawas thinking of --no-error-on-empty taking a page from xargs, but it does seem a bit verbose08:33
Chipacaalternatively, and perhaps more naturally given the flag is only for use with --last, we could add syntax to --last, e.g. «--last=foo?» vs «last=foo»08:35
mvoChipaca: I'm not great with names but --no-error-on-empty seems to be ok (yes verbose but). alternatives might be "--empty-ok"08:35
mvoChipaca: I like "foo?"08:35
mvoChipaca: not sure about zygas +1, but he should be online soon(ish)08:36
Chipacasorted :-)08:36
mvoChipaca: ta08:36
Chipacamvo: ah, i thought they were further west08:36
mvoChipaca: its 6h from here, so I would expect (jetlag and all that) in ~2h08:40
zyga4am-orning08:52
* ogra_ grumbles about his kiosk app being rejected because of missing .desktop file ... how pointless08:53
Chipacahehe08:54
Chipacazyga: morning08:54
Chipacazyga: we were just talking about you and jetlag08:54
Chipacaogra_: wat?08:54
Chipacaogra_: what's rejecting your app because of that?08:55
zygaStore Review tools08:55
zygaHow are you guys doing?08:55
ogra_yeah ... it uses an x11 loopback interface to itself ... the review tools block if you dont have a .desktop file when this interface is found08:55
Chipacazyga: in #5224, does your "+1 but" mean an actual +1?08:55
Chipacawait08:55
Chipacazyga: #552408:55
* Chipaca kicks mup08:55
zygaMup is partially off08:56
ogra_jetlag08:56
zygaChipaca: that depends, if you agree then you can tweak the feature, if you don’t you can treat my review as +108:57
Chipacazyga: I disagree (explained a bit why on the pr)08:57
zygaOk08:57
Chipacazyga: (also i brought this other approach up with Juanreal before implementing it)08:57
zygaI haven’t read that yet08:57
mupPR #5224: interfaces: remove Plug/Slot types <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/5224>08:58
mupPR #5524: cmd/snap: check for typographic dashes in command <Created by chipaca> <https://github.com/snapcore/snapd/pull/5524>08:58
zygamvo: how is core18?09:00
mvozyga: mostly happy, the snap-stop-mode test was still racy though, looks like output related, I added marker files and with that I got no failures yet (running with -repeat 100)09:15
mvozyga: the integration PR is failing with what looks like unrelated issues09:16
zygaThank you! That is good news09:16
mvozyga: I am discussing kernel track names right now, I added you to the mail thread and maybe you can ask Gustavo to have a look so that we can make a decision. its one of the blockers for the model assertion for core1809:16
zygaHow about the core18 snapd hosting  slots?09:17
mvozyga: you mean 5527? or something else?09:17
zygaYes09:19
Chipacasnap set system refresh.hold=+2h09:19
zygaI saw it was red09:19
Chipacawhy can't we do that :-)09:19
zygaDidn’t check deeper yet09:19
pedronisChipaca: the plan is to have a command to do that sort of stuff, was blocked on deciding how to call it and the fact we have too many commands09:33
Chipacapedronis: I could add it to corecfg (if we ignore that the function is called 'validate' and not 'validate-and-normalise'09:34
Chipaca)09:34
pedronisplease don't09:35
* Chipaca quietly does 'git reset --hard'09:35
mvozyga: aha, indeed, its red because settle is not converging09:36
mvozyga: we need to either fake the production snapd id09:36
mvozyga: or add the test snapd-id to the detection if its the snapd snap, we had this issue before I think09:36
zygaAh, I remember now09:36
zygaCan you patch that in some acceptable way09:37
zygaI’d love to say “we can boot core18 and it works”09:37
mvozyga: I can add a patch, we will see if that is "acceptable" ;)09:39
mvozyga: just working on the sru for 2.34.1 will do in a little bit09:39
zygaThank you :-)09:39
zygaOk09:39
* Chipaca steels himself to go to the dentist10:01
zygamvo: feedback from the field: we should have a workflow where developers can copy a new kernel, snap install it and reboot10:08
mvozyga: to test new kernels?10:09
zygacurrently that doesn't work and requires time-consuming workarounds or use of ubuntu classic10:09
zygayes10:09
zygato do kernel development10:09
zyga(driver etc)10:09
mvomakes sense, we have some restrictions here currently mostly to avoid users doing strange things10:09
zygamhm10:10
zygamaybe just --dangerous --very10:10
zygaor something like this10:11
pstolowski--scary10:19
zyga--I-know-what-you-did-last-summer10:23
pstolowskizyga: how is the sprint going?10:24
zygavery good so far10:24
zygawe have one interesting thing that was discussed yesterday evening10:24
zygawe will change how refresh works10:24
zygaI will share all the details later today/tomorrow (as time permits)10:24
zygait will involve a new hook as well10:24
pstolowskiinteresting10:25
pstolowskipedronis: RFC - https://github.com/snapcore/snapd/pull/553210:54
mupPR #5532: api/connect: report "nothing to do" if attempting to re-connect <Created by stolowski> <https://github.com/snapcore/snapd/pull/5532>10:54
pedronispstolowski: mmh,   that's a change of behavior10:56
pedronisI think the old code just did nothing, not an error10:56
pstolowskipedronis: indeed, the old code would just do nothing in the handler, but created the change etc.10:58
pedronispstolowski: we have  a similar case already10:58
pedronispstolowski: we do this:   https://github.com/snapcore/snapd/blob/master/daemon/api.go#L1436 but I think Connect shoudl return either an empty ts or some kind of error11:01
pedronisto trigger that behavior11:01
pstolowskipedronis: yes i considered empty ts, but wasn't sure a dummy change with 'done' status was a good idea (forgot we have a case already)11:03
pstolowskipedronis: okay, i will do it that way then11:05
=== pstolowski is now known as pstolowski|lunch
* Chipaca lunch11:46
Chipacahmm, clearing refresh.hold with "" seems to be broken11:48
Chipaca2018/07/18 12:48:39.556782 stateengine.go:101: state ensure error: internal error: cannot unmarshal snap "core" option "refresh.hold" into *time.Time: parsing time """" as ""2006-01-02T15:04:05Z07:00"": cannot parse """ as "2006", json: ""11:49
Chipacahmm11:49
* ogra_ curses loudly ... 11:57
ogra_the damned review tools are making me mad today11:58
popeyDon't get mad, get even.11:58
ogra_i think i tried evyery possible way to ship a pointless .desktop file for my kiosk daemon app now11:58
ogra_but they all got rejected11:58
* ogra_ has no idea how to proceed with that11:59
ogra_snap/gui/ doesnt work, specifying it in snapcraft.yaml and shipping it doesnt ... not sure what else to try11:59
popeywhy not just put a valid desktop file?12:00
ogra_?12:00
popeyyoure talking about a "pointless" desktop file12:00
popeywhy don't you do what we do for every other snap and put a valid one in there12:00
ogra_well, i use an IMHO valid file12:00
ogra_the point is that this is a daemon12:00
ogra_it doesnt need a desktop file since it cant be run from it12:00
popeycan I see the project/yaml/desktop file?12:00
ogra_https://github.com/ogra1/xdmcp-client12:01
popeyi always put the desktop file in snap/gui/foo.desktop12:01
ogra_(i originally shipped it in snap/gui, just moved it arouond to toplevel and defined it via deskto: )12:01
popeyand never mention it in the yaml12:01
popeyit gets automatically found12:01
ogra_yes12:01
ogra_thats what  did first12:01
ogra_*I12:02
popeyyour icon path is invalid12:02
popeyin the desktop file12:02
popeyput .desktop and .png in snap/gui, and make sure they are both called <snapname>.*12:02
ogra_yeah, now it is :( ... (wasnt when it was in snap/gui12:02
ogra_912:02
ogra_thats what i had in the former revision ...12:02
ogra_like in all other desktop snaps i create ...12:03
ogra_but that just caused the very same review error12:03
ogra_popey, https://github.com/ogra1/xdmcp-client/tree/c70eafedf3ea751730677a843782f567d7c2d816 was my last revision12:03
popeyfilename is wrong12:04
popeyfor the icon, make it xdmcp-client.png12:04
ogra_ <snapname>.desktop12:04
popeyand refer to it as such in the desktop file12:04
ogra_well, icon.png works for all other desktop snaps i have ... but happy to try12:04
niemeyermvo, nessita: Heya12:05
popeyyou can run the snap review tools locally to test it12:05
popeyrather than do the store turn around time12:05
niemeyersnap info on snaps published by canonical is showing that long email address instead of snaps@canonical..12:05
niemeyernessita: What do we need to do to fix that?12:06
nessitaniemeyer, we should reindex the snaps, let me do that12:06
niemeyernessita: Thanks!12:07
nessitaniemeyer, have an example of a snap showing the wrong email address?12:09
=== abeato_ is now known as abeato
=== pstolowski|lunch is now known as pstolowski
zyganessita: core12:25
nessitazyga, I see. That's the contact url of a snap which is set by the publisher and is not automatically changed when SSO profile data changes12:27
popeyhttps://snapcraft.io/core could do with a metadata update too! as could https://snapcraft.io/canonical-livepatch12:28
ogra_the core text came originally from mark FWIW12:31
ogra_(i had a way longer text for the initial uploads)12:31
=== ondra_ is now known as ondra
popeyThat was when we only had "snap info" though, the web store needs more text to make it look compelling.12:37
Chipacanot sure core needs to be compelling :-)12:38
nessitazyga, niemeyer I filed an RT to have the contact_url changed for every snap12:38
ogra_popey, true12:40
popeypeople link to it, it needs more than one line12:41
ogra_popey, so ... whatever i try i still get the same denial even with local review-tools12:41
ogra_ogra@acheron:~/Devel/xdmcp-client:master$ review-tools.snap-review xdmcp-client_0.1_amd64.snap12:41
ogra_Errors12:41
ogra_------12:41
ogra_ - declaration-snap-v2:slots_deny-connection:xephyr:x1112:41
ogra_human review required due to 'deny-connection' constraint for 'on-classic' from base declaration12:41
popeythats not the same error12:41
popeythat's not a desktop file issue12:41
ogra_(actually it doesnt look like the desktop file thing at all that i get by mail)12:41
ogra_no12:41
popeyone for jamies12:42
ogra_the desktop file is what i got by mail from the review12:42
ogra_popey, hmm12:43
ogra_ogra@acheron:~/Devel/xdmcp-client:master$ review-tools.snap-review xdmcp-client_0.1_amd64.snap12:43
ogra_Errors12:43
ogra_------12:43
ogra_ - declaration-snap-v2:slots_deny-connection:xephyr:x1112:43
ogra_human review required due to 'deny-connection' constraint for 'on-classic' from base declaration12:43
ogra_err12:43
ogra_one sec, wrong paste12:43
ogra_The reviewer provided the following feedback:12:43
ogra_desktop interfaces (x11) specified without a corresponding meta/gui/*.desktop file. If using snapcraft, please see https://snapcraft.io/docs/build-snaps/metadata#fixed-assets. Otherwise, please provide a desktop file in meta/gui/*.desktop (it should reference one of the &#39;apps&#39; from your snapcraft/snap.yaml)12:43
ogra_thats what i get by mail ...12:43
mupPR #39: Login integration test closes #38 <Created by fgimenez> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/39>12:43
ogra_seems slightly contradicting to what the review tools tell12:44
ogra_popey, is there a way to find out who did the manual review ?12:46
ogra_https://dashboard.snapcraft.io/snaps/xdmcp-client/revisions/12/review/ would be one that caused the mail12:46
popeyJamie12:47
ogra_oh, yeah, i didnt know i could open that link even !12:47
ogra_heh12:48
ogra_well, the tools definitely reject it because the app needs to declare a " slots: [ x11 ]" in the apps: section12:49
ogra_(to provide an x11 loopback interface for using XWayland under mir-kiosk)12:49
ogra_geez .... i didnt expect that to be this complicated ....12:49
ogra_yay ... new technology :)12:49
* ogra_ updates https://forum.snapcraft.io/t/review-tools-forcing-desktop-file-for-kiosk-apps/643612:57
=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
Chipacaogra_: "i didnt expect that to be this complicated" --napoleon, somewhere around sepember 181213:28
kjackalhi everyone. I am a bit confused. Is it possible to have the launchpad builders build and release snaps on a few different tracks? Can we have lp builders build from branch A and release to track A and at the same time have other(?) builders build from branch B and release to track B?13:28
roadmrhello folks, there's currently an outage in the snap store, we're working to solve it, I'll update when it's fixed13:29
kjackalI may be missing some button13:29
Chipacakjackal: I thought the builders only released to [foo?]/edge13:29
Chipacakjackal: but https://docs.snapcraft.io/build-snaps/ci-integration seems to imply you should be able to choose branches13:30
Chipacaoh wait13:31
Chipacathose are lp branches :-)13:31
Chipacakjackal: but in that same page, step 1113:31
kjackalI think I understand it now. I have to start with the branch on LP and then create the builders. let me try that13:33
roadmrstore outage should now be resolved, thanks for your patience13:34
pstolowskipedronis: if you have some time for reviews, https://github.com/snapcore/snapd/pull/4940 needs re-reviewing; and i'm waiting for spread test run of #553213:41
mupPR #4940: overlord: added UDevMonitor for future hotplug support <Created by stolowski> <https://github.com/snapcore/snapd/pull/4940>13:41
mupPR #5532: api/connect: ignore connect if already connected <Created by stolowski> <https://github.com/snapcore/snapd/pull/5532>13:41
ogra_Chipaca, lol13:45
=== chihchun_afk is now known as chihchun
pedronisChipaca: hi, could you look at #551513:58
mupPR #5515: daemon: make sure most change generating handlers can produce errors with kinds <Created by pedronis> <https://github.com/snapcore/snapd/pull/5515>13:58
Chipacapedronis: looking14:09
zygahow are things going?14:09
zygaor doing actually14:10
oSoMoNI've added plugs for gtk-3-themes, icon-themes and sound-themes to the libreoffice snap like was done for a bunch of gnome app snaps, but I'm getting the following error and don't know what's causing it:14:11
oSoMoNmain.go:192: cannot change mount namespace of snap "libreoffice" according to change mount (/snap/gtk-common-themes/319/share/icons/Adwaita /snap/libreoffice/x1/data-dir/icons/Adwaita none bind,ro 0 0): cannot create writable mimic over "/snap/libreoffice/x1": permission denied14:11
oSoMoNcan anyone enlighten me?14:11
Chipacapedronis: youch14:12
oSoMoN(this is what I added to snapcraft.yaml: https://git.launchpad.net/~libreoffice/+git/libreoffice-snap/commit/?id=0e58538d71af93eef00c6d73b7767a548208e30d)14:12
oSoMoNand the bug report with all the details is https://github.com/ubuntu/gtk-communitheme/issues/35014:12
zygaoSoMoN: hey14:12
zygaoSoMoN: can you share the snap yaml's of the two snaps and the output of "dmesg | grep DENIED" please14:13
zygaoSoMoN: also snap version but I suspect you are just on the latest stable14:13
oSoMoNzyga, snapcraft.yaml: https://git.launchpad.net/~libreoffice/+git/libreoffice-snap/tree/snap/snapcraft.yaml?h=6.014:15
oSoMoN$ snap version14:15
oSoMoNsnap    2.33.114:15
oSoMoNsnapd   2.33.114:15
oSoMoNseries  1614:15
oSoMoNubuntu  18.0414:15
oSoMoNkernel  4.15.0-23-generic14:15
zygaok14:15
zygaoSoMoN: can you tell me if $SNAP/data-dir/{themes,icons,sounds} all exist in the snap?14:16
zygaI assume they don't14:16
oSoMoNzyga, they don't14:16
zygaok14:16
zygaplease share the denial14:16
zygaand /var/lib/snapd/apparmor/profiles/snap-update-ns.libreoffice from the affected machine14:16
oSoMoNzyga, there are multiple denials, most of them are similar to this:14:17
oSoMoNjuil. 18 16:17:04 bribon audit[4274]: AVC apparmor="DENIED" operation="mount" info="failed mntpnt match" error=-13 profile="snap-update-ns.libreoffice" name="/tmp/.snap/snap/libreoffice/69/" pid=4274 comm="3" srcname="/snap/libreoffice/69/" flags="rw, rbind"14:17
oSoMoNzyga, https://paste.ubuntu.com/p/HhXgw52vzY/14:18
zygaok14:18
zygathis is https://github.com/snapcore/snapd/pull/539514:19
mupPR #5395: interfaces: generalize writable mimic profile <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5395>14:19
zygaI will try to land this branch14:19
zygaas a workaround please create, inside the libreoffice snap, the data-dir/14:19
zygathen the rest should work14:19
zygait's the extra level of nesting that is breaking this14:20
Chipacapedronis: is sideloadCheck just moved?14:20
oSoMoNzyga, thanks! I'll test creating the data-dir/ inside the snap14:21
oSoMoNI wonder why this is working for other snaps, like evince or gedit, though14:21
oSoMoNthose don't have a data-dir/ directory either14:21
zygaI don't know14:24
zygaI will study the rules you gave me to see if this is the same thing I think for sure14:24
oSoMoNthanks!14:24
zygaoSoMoN: please let me know if this works for you14:28
oSoMoNzyga, yes, I'm repacking the snap with an additional data-dir/ directory, will let you know14:28
zygaoSoMoN: thank you14:28
zygayou can just unsquash it, mkdir and snap pack it14:28
oSoMoNzyga, yep, that's what I did14:30
oSoMoNbut same error14:30
oSoMoNI verified that $SNAP/data-dir exists after installing14:30
zygacan you be more specific please, what is the error you are getting now14:30
oSoMoNcannot create writable mimic over "/snap/libreoffice/x1/data-dir": permission denied14:30
zygathat is more curious14:31
zygahold on14:31
zygawell, add the extra three directories and that will go away14:31
zygabut I really need to get to the bottom of this14:31
oSoMoNok, adding those14:31
zygaand please dmesg the denial that you saw now14:31
oSoMoNAVC apparmor="DENIED" operation="mount" info="failed mntpnt match" error=-13 profile="snap-update-ns.libreoffice" name="/tmp/.snap/snap/libreoffice/x1/data-dir/" pid=8248 comm="3" srcname="/snap/libreoffice/x1/data-dir/" flags="rw, rbind"14:32
zygathank you14:33
pedronisChipaca: yes14:33
oSoMoNrepacking with all three directories now, let's see if that works14:33
Chipacapedronis: ah yes i edited locally to confirm :-)14:33
Chipacapedronis: before +1'ing it (without the edit it would've taken me a lot longer to review)14:34
pedronisChipaca: was moved far for some reason from either it's first or last usage14:34
pedronisso I moved it14:34
zygaah14:34
zygaI know why it didn't help14:34
pedronisChipaca: that test file is too long (tm) :(14:34
zygabut it's still that bug14:34
Chipacapedronis: as is api.go itself14:34
zygaoSoMoN: the reason is that gtk-common-themes is actually exportng a number of items that are nested themselves14:35
zygathe branch I referenced fixes this but, as I said, it's on me to land14:36
=== chihchun is now known as chihchun_afk
oSoMoNzyga, I can confirm that creating the missing dirs works around the issue14:42
abeatojdstrand, mind taking a look at https://github.com/snapcore/snapd/pull/5469 when you can?15:18
mupPR #5469: interfaces/apparmor: (un)load profiles in one apparmor_parser call <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/5469>15:18
zygaoSoMoN: thank you15:23
=== pstolowski is now known as pstolowski|afk
mvozyga: pr#5533  allows creating images with the new kernel-track feature of the model assertion. if Gustavo has a free minute it would be great to get his opinion on what kernel track name to pick. having one soon would be really great, then I can start writing an integration test16:18
mvohm, no mup currently?16:23
cachiozyga, https://paste.ubuntu.com/p/BQHWShC7Zv/17:54
cachioI see these denials executing a test for daemon-notify interface17:55
cachiozyga, any idea why it could be happening17:55
cachio=17:55
zygacachio: yes, it is not auto-connected18:35
zygayou have a slot but it's not connected18:35
cachiozyga, I manually connected it18:35
zygaI wrote a thread about this on the forum18:35
zygait's too late18:35
zygayou cannot connect it fast enough18:35
zygawell18:35
zygaI'd have to see your test service18:36
zygabut in general you cannot use that from non-service started by systemd18:36
zygaand you cannot connect it fast enough18:36
zygaso in practice it's not really usable18:36
zygaplease read my forum post about this18:36
zygahttps://forum.snapcraft.io/t/its-a-little-bit-hard-to-use-daemon-notify-for-sd-notify/636618:37
zygamvo: the github part of mup is off because of the github availability issue18:37
cachiozyga, what I did is to connect it and the install it again18:37
cachiozyga, but same issue18:38
zygathat doesn't help18:38
zygait's not auto-connected18:38
zygabecause the install would likely fail18:38
zygabecause the daemon: notify cannot be installed without successfully talking to systemd18:38
zygacan you show me the test please18:38
cachiozyga, https://paste.ubuntu.com/p/rkf8VXVg5K/18:39
cachiohttps://paste.ubuntu.com/p/wrmrZz2rNY/18:39
zygaok, and what did you expect to happen?18:39
cachiozyga, I am checking logs to see I there is any denial18:40
cachiozyga, still doing it manually18:40
zygathe interface is not auto-connected so as soon as you start the service it is attempting to use a program it cannot use18:41
zygayou can connect it18:41
zygarestart the service18:41
zygabut then it may not work _anyway_ depending on what systemd does18:41
cachiook18:41
zygaif it allows you to talk over the socket (separately from our permission)18:41
cachiozyga, I'll try that, thanks18:45
thirashello19:43
thirasdiscord and spotify are broken19:44
thiras$ snap run discord19:44
thirasln: failed to create symbolic link '/home/thiras/snap/discord/69/.config/gtk-2.0/gtkfilechooser.ini': File exists19:44
thirasGtk-Message: Failed to load module "gail"19:44
thirasGtk-Message: Failed to load module "atk-bridge"19:44
thirasubuntu 18.0419:45
jdstrandabeato: yes. it is on my list. I looked at it and am ok with the approach, but I wanted to check a few things before giving my ack. I apologize for the delay. I've been meaning to get to it and am sprinting this week19:45
thirasspotify has quite similar error log19:47
cachiozyga, I have updated the PR #553520:04
mupPR #5535: tests: fix tests expecting old email address <Critical> <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5535>20:04
zygacachio: I saw just now, thank you!20:13
cachiozyga, np20:13
=== devil is now known as Guest74443
=== Guest74443 is now known as devil_

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!