| babbageclunk | gah, all my tests pass but only when I put in the magic number 3, and I can't work out why! | 04:52 |
|---|---|---|
| veebers | babbageclunk: where is the magic number put? | 05:11 |
| babbageclunk | veebers and anastasiamac: In the call to clock.WaitAdvance - it's the number of things that should be waiting for the clock before we move time forward. But I think it should be 2, and the computer insists it's 3! | 05:12 |
| veebers | babbageclunk: you're not off by one? zero base vs 1 base | 05:13 |
| anastasiamac | babbageclunk: the last time i've encountered something like that was with channels and loops... | 05:13 |
| babbageclunk | maybe you're off by one! | 05:13 |
| babbageclunk | Sorry, that was uncalled for. | 05:13 |
| babbageclunk | anastasiamac: yeah, I've definitely got those. | 05:14 |
| veebers | hah ^_^ | 05:14 |
| anastasiamac | babbageclunk: in my case i had to send my changes twice even tho i only wanted one change... turned out the intialisation was an issue in workers... | 05:14 |
| babbageclunk | anastasiamac: yeah, it's bound to be something like that - I'm about to hack the clock to store tracebacks so I can see where all the waiters are coming from. | 05:18 |
| anastasiamac | babbageclunk: sounds good... keep us posted if u find the reason or if u need to talk at someone | 05:26 |
| === SaMnCo_ is now known as SaMnCo | ||
| === antdillon_ is now known as antdillon | ||
| === cassiocassio_ is now known as cassiocassio | ||
| === rick_h__ is now known as rick_h_ | ||
| === kina____ is now known as kina___ | ||
| === Dmitrii-Sh_ is now known as Dmitrii-Sh | ||
| === iatrou__ is now known as iatrou_ | ||
| === mup_ is now known as mup | ||
| stickupkid | does anyone know what the `cmd/plugins/juju-meteadata` is for? | 09:02 |
| Dmitrii-Sh | Hi, if anybody has time to triage pad.lv/1782236 and review the PR for it https://github.com/juju/juju/pull/8949 I'd really appreciate it | 09:17 |
| === beisner_ is now known as beisner | ||
| anastasiamac | stickupkid: yes, it's for images | 10:16 |
| manadart | Dmitrii-Sh: I will take a look today. | 10:34 |
| Dmitrii-Sh | manadart: thx | 10:34 |
| manadart | stickupkid: Need a review. Shame I didn't get this in for 2.4.1: https://github.com/juju/juju/pull/8952 | 10:44 |
| stickupkid | manadart: just needs a code comment to be addressed | 10:47 |
| manadart | stickupkid: Done. | 11:12 |
| stickupkid | manadart: done | 11:15 |
| stickupkid | LGTM | 11:15 |
| manadart | stickupkid: Pushed another commit. Lock doesn't need a method wrapper. | 11:16 |
| stickupkid | manadart: i quite liked that, but up to you | 11:18 |
| * stickupkid gets auto credentials working without all the hacks - yessss! | 11:54 | |
| manadart | stickupkid: Was also thinking re: the Discourse page. Would it not be simpler to have instructions for the credential use the interactive CLI rather than the file? | 11:55 |
| manadart | Seems to me it would be simpler - don't have to copy certs into another file. | 11:56 |
| stickupkid | Potentially, I don't mind, we can look into that... there are two methods, both work... | 11:57 |
| stickupkid | we could just make an ammendment tbh | 11:58 |
| manadart | I thought to do that... | 11:59 |
| stickupkid | that way you can also improve your discourse kama :p | 12:02 |
| manadart | Dmitrii-Sh: Reviewed/triaged. Just add the test and I'll get it landed. | 12:39 |
| Dmitrii-Sh | manadart: thanks, will | 12:40 |
| Dmitrii-Sh | will do* | 12:44 |
| bdx | https://imgur.com/a/JndWKxu | 18:43 |
| bdx | the outdated and now entirely removed docs still show up when users search for juju* it seems | 18:44 |
| bdx | I have new users telling me this often | 18:44 |
| veebers | yay, with the testing streams generation it updates all the 'updated' entries with now as it's being updated, which means I can't easily expire old entries | 22:33 |
| === valeech_ is now known as valeech | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!