| === thibautr___ is now known as thibautr__ | ||
| === tedg_ is now known as tedg | ||
| === TinoGuest_ is now known as TinoGuest | ||
| === davidcalle_ is now known as davidcalle | ||
| === clemensv_ is now known as clemensv | ||
| === Dmitrii-Sh_ is now known as Dmitrii-Sh | ||
| === iatrou__ is now known as iatrou_ | ||
| === mup_ is now known as mup | ||
| === pstolowski|afk is now known as pstolowski | ||
| pstolowski | mornings | 07:11 |
|---|---|---|
| mvo | hey pstolowski | 07:12 |
| pstolowski | #5474 needs a 2nd review, would be great to land it | 07:43 |
| mup | PR #5474: many: finish sharing a single TaskRunner with all the the managers <Created by pedronis> <https://github.com/snapcore/snapd/pull/5474> | 07:43 |
| mvo | pstolowski: I have a look in a bit | 07:43 |
| pstolowski | ty | 07:43 |
| pstolowski | mvo can #5535 land, or is there more to it? | 07:54 |
| mup | PR #5535: tests: fix tests expecting old email address <Critical> <Simple> <Created by zyga> <https://github.com/snapcore/snapd/pull/5535> | 07:54 |
| Chipaca | buenos días, gente | 08:06 |
| mvo | pstolowski: it can land, I fixed this 2h earlier but for some reason my PR was not visible, oh well | 08:09 |
| mvo | pstolowski: s/not visible/not reviewed/ | 08:10 |
| mvo | pstolowski: if merged, please squash, we need it for the sru | 08:10 |
| pstolowski | mvo: yep, noticed that.. | 08:10 |
| mvo | Chipaca: hey, good morning | 08:10 |
| pstolowski | ouch, i merged a second ago, but not squashed | 08:10 |
| pstolowski | sorry about that | 08:11 |
| mvo | pstolowski: no worries, its just three commits so not a big deal | 08:11 |
| Chipaca | hmm | 08:20 |
| Chipaca | I've got a question about #5535 | 08:21 |
| mup | PR #5535: tests: fix tests expecting old email address <Critical> <Simple> <Created by zyga> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/5535> | 08:21 |
| Chipaca | why the unknown|unset change? | 08:21 |
| Chipaca | that one's wrong | 08:21 |
| Chipaca | and backwards | 08:21 |
| pedronis | pstolowski: thanks for the review | 08:22 |
| mvo | Chipaca: unset is the new one right? | 08:22 |
| Chipaca | yes | 08:23 |
| Chipaca | there should be nothing saying 'unknown' now, ever | 08:23 |
| Chipaca | if there is, it's a bug | 08:23 |
| mvo | Chipaca: did the server side sent it? | 08:24 |
| mvo | Chipaca: or is this entirely local? | 08:24 |
| Chipaca | mvo: server side sends "unset" | 08:24 |
| mvo | Chipaca: sounds like we need a PR then that removes the unknown | 08:24 |
| Chipaca | mvo: for local snaps with no set license snapd sent "unknown" until #5508 | 08:24 |
| mup | PR #5508: cmd/snap: print unset license as "unset", instead of "unknown <Simple> <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5508> | 08:25 |
| Chipaca | mvo: so I'm asking, before just pushing the PR to do it, because it was unset and obviously something broke, I need to understand what broke :-) | 08:25 |
| Chipaca | i mean, i doubt cachio made the change just for fun | 08:26 |
| pedronis | when was this? is this related to the reindex or was from before? | 08:27 |
| * pedronis is going to spend the morning on reviews | 08:27 | |
| Chipaca | pedronis: same pr as the email change | 08:27 |
| pedronis | ah | 08:27 |
| pedronis | maybe something is broken in the store and the reindex put unknown in places again? | 08:28 |
| Chipaca | nope | 08:28 |
| Chipaca | unless this is the fake store? | 08:29 |
| Chipaca | the actual store is sending "Other Open Source" | 08:29 |
| Chipaca | which wouldn't mach either of those :-) | 08:29 |
| pedronis | mmh | 08:30 |
| pedronis | yes | 08:30 |
| pedronis | this is test-snapd-tools ? | 08:30 |
| Chipaca | core, test-snapd-tools, and test-snapd-devmode | 08:30 |
| pedronis | Chipaca: core says unknown here | 08:31 |
| Chipaca | pedronis: where and how? | 08:31 |
| pedronis | snap info core | 08:32 |
| pedronis | with beta | 08:32 |
| pedronis | I mean 2.34.1 | 08:32 |
| Chipaca | pedronis: #5508 is recent, probably only edge | 08:32 |
| mup | PR #5508: cmd/snap: print unset license as "unset", instead of "unknown <Simple> <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5508> | 08:32 |
| pedronis | Chipaca: ah, but cachio is doing an SRU, so it needs still the unknown | 08:33 |
| Chipaca | merged 3 days ago | 08:33 |
| Chipaca | pedronis: on master? | 08:33 |
| pedronis | I'm not quite sure how is running things | 08:33 |
| pedronis | no clue | 08:33 |
| Chipaca | yeah | 08:33 |
| * Chipaca grumbles some more | 08:33 | |
| Chipaca | anyhow | 08:33 |
| Chipaca | pedronis: it's have-another-coffee o'clock | 08:33 |
| pedronis | me I'm fininish my first tea | 08:34 |
| Chipaca | after that i'll be working on snapshotstate conflicts | 08:34 |
| Chipaca | wish me luck :-) | 08:34 |
| pedronis | Chipaca: it should be easy | 08:44 |
| pedronis | Chipaca: afaiu just use AddAffectedSnapsByAttr | 08:45 |
| pedronis | with snapshot-setup | 08:45 |
| jamesh | when calling /v2/interfaces?select=connected&plugs=true&slots=true, is it normal that unconnected plugs and slots are returned? | 08:48 |
| jamesh | it only seems to filter out interface types that have no connected plugs or slots | 08:48 |
| Chipaca | jamesh: I'm not sure. That code was refactored recently, so we might've fudged it | 09:08 |
| Chipaca | zyga: ^ jamesh's question is for you I fear | 09:08 |
| Chipaca | jamesh: zyga is further west than normal so I wouldn't expect a response for a few hours | 09:09 |
| jamesh | Chipaca: Montreal? | 09:10 |
| Chipaca | yah | 09:10 |
| Chipaca | jamesh: OTOH the refactor is probably only on master (so on edge) | 09:10 |
| Chipaca | jamesh: are you talking to edge? | 09:10 |
| jamesh | good point. I'm on edge at the moment. I'll check stable | 09:10 |
| Chipaca | jamesh: even if we didn't change the behaviour it's possible it's wrong :-) i'd be surprised to get unconnected things when i ask for connected ones | 09:12 |
| pedronis | mvo: I don't understand the localSnaps change in the kernel-track branch, it seems to be done for all snaps | 09:12 |
| jamesh | Chipaca: I want to find out if a particular snap has a connected plug for a particular interface, and didn't feel like sifting through the full list of connections. This interface looked like it should do what I want, but didn't seem to be doing the filtering | 09:14 |
| jamesh | Chipaca: okay. Stable (2.33.1) also shows unconnected plugs | 09:14 |
| Chipaca | jamesh: so 'snap interfaces -i theinterface thesnap', but via the api? | 09:15 |
| mvo | pedronis: hm, let me double check, maybe there is a test missing :( | 09:15 |
| pedronis | mvo: did you forget to check that the snap name is the kernel name? | 09:15 |
| mvo | pedronis: yes, silly me. plus a test is missing that should have failed, let me check why this is not failing, I thought I had checked for the channel | 09:16 |
| jamesh | Chipaca: that command does client side filtering. I was thinking of doing the equivalent of "snap interface pulseaudio" and then checking checking if the snap in question was listed as a plug | 09:17 |
| pedronis | pstolowski: I tried to answer your doubt | 09:17 |
| mvo | pedronis: aha, there is a test for two local snaps missing, let me fix that | 09:18 |
| jamesh | that's "interface" rather than "interfaces" | 09:18 |
| Chipaca | jamesh: ah, right, interfaces is the old one | 09:19 |
| Chipaca | (what you get with select="") | 09:19 |
| Chipaca | jamesh: looks like a bug to me | 09:20 |
| Chipaca | jamesh: I have both vlc and firefox snaps, neither of which are connected to camera, yet 'snap interface camera' lists them | 09:21 |
| Chipaca | jamesh: whereas i'd only expect them to appear under 'snap interface --all camera' | 09:21 |
| jamesh | Chipaca: I'd expect them to show with select=all and not with select=connected | 09:21 |
| jamesh | yeah | 09:21 |
| Chipaca | exactly | 09:21 |
| Chipaca | so, yeah, this looks like a bug to me | 09:21 |
| Chipaca | also the output with --all should probably say connected/disconnected | 09:22 |
| jamesh | The json doesn't currently tell you about the connection state, or what they are connected to | 09:23 |
| jamesh | it'd kind of be nice if one of the output formats clearly had a superset of the data of the other | 09:23 |
| mvo | pedronis: thanks again, fix pushed, can't wait to write integration tests for this | 09:25 |
| Chipaca | jamesh: want to raise that last point in the forum? | 09:30 |
| jamesh | Chipaca: sure. | 09:30 |
| Chipaca | jamesh: I know niemeyer had Opinions about this, but I'm not sure the current interface command is that, or if there was going to be a connections command | 09:30 |
| Chipaca | popey: is somebody working on a new minecraft snap? | 09:31 |
| Chipaca | popey: (because I'm going to be asked for it this weekend) | 09:32 |
| popey | @Chipaca looked at it last night, and mentioned to @Wimpress as I am on vacation starting today. he said he'd look at it if he gets time. Looks simple enough to dump the deb into a snap | 09:32 |
| popey | we could put it in edge on the minecraft name | 09:32 |
| Chipaca | popey: there's a deb now? | 09:33 |
| popey | but need to test that it migrates from old minecraft to new properly | 09:33 |
| popey | yes | 09:33 |
| popey | its a chromium embedded (electron like) app | 09:33 |
| Chipaca | saw that in the tarball, but didn't see a deb | 09:33 |
| Chipaca | anyway, good to know | 09:33 |
| Chipaca | popey: enjoy your holidays and your vacationdays | 09:33 |
| popey | thanks. give Wimpress a nudge later when he's online | 09:34 |
| popey | :) | 09:34 |
| pedronis | mvo: not urgent, there's a couple of mispellings of "topic" in the roadmap entry for 2.34 in the forum | 09:36 |
| mvo | pedronis: thank you, will fix in a bit | 09:36 |
| ogra_ | hmm, does aynone know if layouts can be used on top of dirs that are imported via a content interface ? | 09:45 |
| ogra_ | (i wonder if the ordering allows that) | 09:47 |
| pedronis | mvo: 5533 looks good but I think it could be simplified a bit further | 09:50 |
| pedronis | mvo: let me know if the comment/proposal are unclear | 09:53 |
| * Chipaca afk for a while | 09:55 | |
| popey | Chipaca: should snap pack foo/ create a valid snap? | 09:55 |
| Chipaca | popey: snap pack foo/ . should | 09:56 |
| popey | it doesnt | 09:56 |
| Chipaca | dunno how good we are with the defaults | 09:56 |
| popey | https://www.irccloud.com/pastebin/Q4A7E8gz/ | 09:57 |
| Chipaca | sigh | 09:57 |
| Chipaca | popey: i'll take a look when i get back | 09:57 |
| popey | ok :) | 09:57 |
| popey | sorry | 09:57 |
| Chipaca | no probs | 09:57 |
| popey | shall i file a bug? | 09:57 |
| Chipaca | this is part of why we want to have a single way to do this | 09:57 |
| Chipaca | popey: please | 09:57 |
| popey | on snapd? | 09:57 |
| Chipaca | yup | 09:58 |
| popey | kk | 09:58 |
| popey | on it | 09:58 |
| popey | https://bugs.launchpad.net/snapd/+bug/1782545 | 09:58 |
| mup | Bug #1782545: "snap pack" doesn't make a valid snap <snapd:New> <https://launchpad.net/bugs/1782545> | 09:58 |
| mvo | pedronis: thanks, looking | 10:01 |
| pedronis | mvo: btw I think the current code is probably even buggy (it would store the effective channel, instead of the tracking channel in some cases) | 10:07 |
| pedronis | (which I don't think is what we want) | 10:08 |
| mvo | pedronis: oh, you mean the pre-existing code? I will check that too | 10:10 |
| pedronis | mvo: yes, because we store info.Channel in the side, but if you ask for some channel that is closed you might get something different | 10:11 |
| pedronis | is not relevant if channel is stable anyway, that's why probably nobody noticed | 10:11 |
| pedronis | is not a serious bug, but it's conceptually off | 10:11 |
| mvo | pedronis: good catch | 10:11 |
| mvo | pedronis: I do a fix in a bit | 10:11 |
| pedronis | mvo: basically we need to store in seed what we set in dlOpts , not what we got in the info (which then also means the code in localSnaps is not needed) | 10:13 |
| pedronis | should simplify a bunch of code, some tests might need re-tweaks | 10:14 |
| mvo | pedronis: I will do a separate PR for this | 10:15 |
| jamesh | Chipaca: here's the forum post: https://forum.snapcraft.io/t/should-v2-interfaces-select-connected-return-unconnected-plugs-slots/6455 | 10:49 |
| mvo | pedronis: I looked now and it seems we don't need a separate PR, the changes needed look quite small | 10:50 |
| mup | Bug #1619258 changed: netplan should allow NICs to be disconnected and not stall the boot <rls-aa-incoming> <Snappy:Fix Released> <nplan (Ubuntu):In Progress by cyphermox> <systemd (Ubuntu):Fix Released> <https://launchpad.net/bugs/1619258> | 10:58 |
| pedronis | mvo: +1 with some small comments | 11:40 |
| pedronis | mvo: thanks for the other changes | 11:42 |
| mvo | pedronis: thank you, looking and tweaking :) | 11:49 |
| * Chipaca wanders off in search of lunch | 12:04 | |
| zyga | o/ | 12:08 |
| pedronis | Chipaca: I reviewed the state bits of #5514 | 12:13 |
| mup | PR #5514: daemon, overlord/state: warnings pipeline <Created by chipaca> <https://github.com/snapcore/snapd/pull/5514> | 12:13 |
| Chipaca | pedronis: saw that, thank you | 12:14 |
| Chipaca | pedronis: the names of those things were (iirc) taken from the whiteboard, but yeah they're probably not the best | 12:14 |
| Chipaca | especially because the lastSeen is from one pov and the lastShown from another | 12:14 |
| Chipaca | and they're practically synonymous | 12:15 |
| pedronis | yes, Seen doesn't work for me there | 12:15 |
| Chipaca | pedronis: also was thinking we could drop the explicit delete method and just expire them on load | 12:16 |
| Chipaca | anyway, really must lunch | 12:17 |
| pedronis | Chipaca: given that we call the method Add* maybe s/seen/added/ | 12:18 |
| pedronis | seems the most explicit | 12:18 |
| pedronis | comment in the PR | 12:19 |
| pedronis | a 2nd review of #5474 would be great | 12:29 |
| mup | PR #5474: many: finish sharing a single TaskRunner with all the the managers <Created by pedronis> <https://github.com/snapcore/snapd/pull/5474> | 12:29 |
| mvo | cachio: hey, 2.34.2 is uploaded into trusty,xenial,bionic, we need to do the validation this week for it to make it to 18.04.1 | 12:41 |
| cachio | mvo, sure | 12:57 |
| cwayne | mvo: +1 for beta core | 13:40 |
| mvo | cwayne: yay, thank you | 13:40 |
| mvo | cachio: -^ | 13:41 |
| cwayne | mvo: once we get one of these kernel issues on a gateway figured out once and for all it'll go more quickly in the future :) | 13:41 |
| cachio | mvo, promoting | 13:56 |
| zyga | pedronis: thank you for the review, I'm addressing the comments now | 14:07 |
| zyga | mvo: do you have any news on the racy stop mode tests? is that a logging issue at this stage (after all the other fixes?) | 14:07 |
| pedronis | mvo: I added some comments to #5537, it looks good overall | 14:14 |
| mup | PR #5537: snapstate: ensure kernel-track is honored on switch/refresh <Core18> <Created by mvo5> <https://github.com/snapcore/snapd/pull/5537> | 14:14 |
| zyga | I addressed stuff on https://github.com/snapcore/snapd/pull/5527 and it just needs a 2nd review | 14:18 |
| mup | PR #5527: overlord/ifacestate: support implicit slots on snapd <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5527> | 14:18 |
| ogra_ | zyga, would layouts work on top of imported dirs from content interfaces (i suspect there might be ordering issues (if a layout symlink gets created before the interface connects etc)) | 14:29 |
| zyga | layouts are first | 14:29 |
| zyga | but we should reject anything that is overlapping already | 14:30 |
| zyga | if we don't that's a bug | 14:30 |
| ogra_ | k, note i didnt try it just asking conceptually | 14:30 |
| ogra_ | so overlaps arent allowed anyway ... hmm | 14:30 |
| zyga | yes | 14:31 |
| zyga | mvo: can we talk about https://github.com/snapcore/snapd/pull/5518 quickly? | 14:31 |
| mup | PR #5518: systemd: fix snapd.apparmor.service.in dependencies <Created by mvo5> <https://github.com/snapcore/snapd/pull/5518> | 14:31 |
| mvo | pedronis: thank you, will work on those | 14:32 |
| mvo | zyga: stop mode is logging related but its not fully conclusive yet. my file based fix works for me(tm) as does decreasing the sleep | 14:32 |
| mvo | zyga: aha, right, 5518 | 14:32 |
| mvo | zyga: yeah, lets kill the requiste= | 14:33 |
| zyga | thanks! | 14:33 |
| zyga | mvo: should we merge the general fixes I did earlier | 14:33 |
| zyga | mvo: and then pursue logging separately | 14:33 |
| zyga | mvo: or do you want to get to the bottom of the issue entirely | 14:33 |
| mvo | zyga: merging your fix is great | 14:34 |
| mvo | zyga: it fixes a lot of problems already | 14:34 |
| mvo | zyga: and then we can use that to get to the bottom of the issue itself | 14:34 |
| zyga | we need a 2nd review on https://github.com/snapcore/snapd/pull/5521 | 14:41 |
| zyga | Chipaca: ^ perhaps | 14:41 |
| mup | PR #5521: snap-confine: mount internal tooling even for the core snap on core18 <Core18> <Created by mvo5> <https://github.com/snapcore/snapd/pull/5521> | 14:41 |
| Chipaca | zyga: ok | 14:43 |
| zyga | thank you! | 14:43 |
| zyga | Chipaca: please have a look at my comment here https://github.com/snapcore/snapd/pull/5531#pullrequestreview-138710326 | 14:53 |
| mup | PR #5531: cmd/snap: support `--last=<type>?` to mean "no error on empty" <Created by chipaca> <https://github.com/snapcore/snapd/pull/5531> | 14:53 |
| popey | zyga: https://forum.snapcraft.io/t/spotify-doesnt-open-everytime-i-reboot/6460 | 14:53 |
| ogra_ | popey, didnt you say your vacation starts today ? what are you doig here all day ? | 14:54 |
| * popey disappears | 14:54 | |
| ogra_ | popey, here ... a poster for you ... https://www.kotzendes-einhorn.de/blog/wp-content/uploads/2014/04/smartwatch.jpg | 14:54 |
| ogra_ | :) | 14:55 |
| popey | I love that image | 14:55 |
| zyga | popey: looking | 14:55 |
| zyga | ah, | 14:56 |
| odc | hi there | 14:58 |
| zyga | but after the session | 14:58 |
| zyga | hey there odc :) | 14:58 |
| odc | question: i have a C++ app that requires C++14 and thus, can only be compiled on ubuntu bionic (doesn't compile on xenial). I have managed to create a .snap from bionic. Will snapcraft.io accept my snap since it doesn not compile on xenial? | 15:01 |
| popey | it may accept it but it will likely segfault on user computers | 15:02 |
| popey | because it will pull in core (ubuntu 16) | 15:02 |
| odc | o.O it won't include the libstdc++ from bionic? | 15:02 |
| ogra_ | well, depends how you build it ... you would need to override libc and stdc++ an also hack the snapcraft.yaml in a way to get a proper compiler/toolchan | 15:02 |
| Chipaca | zyga: responded | 15:03 |
| ogra_ | *and also hack | 15:03 |
| odc | hm, i may be able to compile some libs as static | 15:03 |
| ogra_ | not sure the ibc/stdc++ overriding works | 15:03 |
| ogra_ | yeah, that might be ok | 15:03 |
| odc | how can i view what files are in my snap? | 15:04 |
| ogra_ | i fthey are linked into your binary ... but even then you will execute on top of xenial | 15:04 |
| ogra_ | unsquashfs -ls /part/to/snap | 15:04 |
| ogra_ | *path | 15:04 |
| popey | or look in prime/ | 15:04 |
| Chipaca | or if you're using snapcraft, look in prime/ | 15:04 |
| popey | which will be whats in the snap | 15:04 |
| popey | sorry | 15:04 |
| ogra_ | right, if you have the source tree look in prime/ | 15:04 |
| * popey shuts up and closes irc | 15:04 | |
| popey | cheerio :) | 15:04 |
| ogra_ | haha | 15:05 |
| odc | cool. thx all | 15:05 |
| ogra_ | go watch planes :) | 15:05 |
| * Chipaca kicks popey off | 15:05 | |
| Chipaca | some people need help vacationing | 15:05 |
| popey | ctrl+q | 15:05 |
| odc | apparently, all the libs but libc are included in the snap :) | 15:09 |
| odc | gonna test on xenial | 15:10 |
| Chipaca | odc: libc is a problem | 15:11 |
| Chipaca | odc: but you can force it to be included as well | 15:11 |
| Chipaca | (i don't remember how though) | 15:11 |
| Chipaca | odc: it's a problem because you'll be getting xenial's libc everywhere, and you built against bionic's, and they have different ABIs | 15:12 |
| Chipaca | unless what you managed to do was build on xenial + backported libs, in which case i should shut up | 15:12 |
| odc | nope, i build my snap in a docker container | 15:13 |
| odc | (with bionic) | 15:13 |
| Chipaca | odc: OTOH, you could use base: core18 | 15:14 |
| Chipaca | odc: in which case you might find bugs in core18 as it's not yet 'ready' :-) but it should work | 15:15 |
| Chipaca | odc: (core18 is bionic-based) | 15:16 |
| odc | interesting ;) | 15:16 |
| odc | and indeed my snap does not work on xenial | 15:17 |
| odc | Chipaca: is there documentation for "base"? I don't know where to put it | 15:19 |
| pedronis | pstolowski: zyga: the issues with 5532 are I think about not checking for Undesired | 15:22 |
| pedronis | there can be an entry in conns that still means the connection is not there | 15:23 |
| pstolowski | pedronis: yes i've a fix ready and testing atm | 15:23 |
| Chipaca | odc: it goes in the top level (next to 'name:'), but if snapcraft doesn't support it yet you might need to put 'passthrough: base: core18' | 15:23 |
| Chipaca | odc: (then once snapcraft supports it it'll let you know to drop it out of passthrough) | 15:24 |
| Chipaca | zyga: I just wrote my longest commit message ever, and I'm blaming you | 15:24 |
| Chipaca | zyga: (even though most of it was copy-paste of logs :-) ) | 15:24 |
| odc | Chipaca: it seems to have worked without passthrough | 15:25 |
| Chipaca | odc: yay | 15:25 |
| odc | it works! | 15:27 |
| odc | well, kindof. The gtk theme is ugly and there is no font/text, but i guess that's because of isolation | 15:28 |
| Chipaca | odc: that should work though | 15:29 |
| Chipaca | odc: the snap should have access to the system's fonts | 15:29 |
| Chipaca | well, assuming the right interfaces | 15:29 |
| ogra_ | just use one of the desktop helpers | 15:29 |
| odc | >Cannot open pixbuf loader module file '/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders.cache': No such file or directory | 15:30 |
| ogra_ | right, the desktop helpers help with that | 15:31 |
| odc | ok | 15:31 |
| ogra_ | but not sure what happens if you try to use them with "base: core18" | 15:31 |
| ogra_ | that might badly explode in your face and leave marks ;) | 15:31 |
| Chipaca | i'm sure there are gnome snaps using core18, but don't know which ones offhand | 15:33 |
| Chipaca | maybe mvo knows | 15:33 |
| ogra_ | well, the questio is if the package names used by the desktop wrappers are still the same etc | 15:33 |
| ogra_ | *question | 15:34 |
| zyga | pedronis: mmm, interesting observation, I will check | 15:34 |
| zyga | Chipaca: *thank you* very much, that really matters | 15:35 |
| pedronis | zyga: pawel said he is on it | 15:35 |
| zyga | pedronis: perfect, I'm just catching up onw | 15:35 |
| zyga | *now | 15:35 |
| odc | ok, i added these: plugs: [desktop, home, network, thumbnailer-service, x11] | 15:41 |
| odc | now my app can load fonts, but i still get the gdk-pixbuf error and ugly theme | 15:41 |
| ogra_ | you need to add a desktop helper | 15:42 |
| odc | o.O | 15:42 |
| * odc looks it up | 15:42 | |
| ogra_ | https://github.com/snapcrafters/wordpress-desktop/blob/master/snap/snapcraft.yaml#L32 | 15:43 |
| ogra_ | here is an example | 15:43 |
| odc | thanks! | 15:45 |
| ogra_ | (the "after:" bit ... | 15:47 |
| ogra_ | = | 15:47 |
| ogra_ | ) | 15:47 |
| odc | ogra_: what will that do? | 15:47 |
| odc | i understand it will build this part first | 15:47 |
| odc | nvm, i saw it in the traces | 15:48 |
| ogra_ | its a remote part ... it pulls and builds it forst and puts everything into your snap | 15:49 |
| ogra_ | *first | 15:49 |
| ogra_ | details are at https://wiki.ubuntu.com/snapcraft/parts (scroll down to snapcraft-desktop-helpers) | 15:50 |
| odc | the result is still the same, but this may be the cause: | 15:51 |
| odc | main.go:192: cannot change mount namespace of snap "ahoviewer" according to change mount (/var/lib/snapd/hostfs/usr/local/share/fonts /usr/local/share/fonts none bind,ro 0 0): cannot create writable mimic over "/usr": cannot create path "/tmp/.snap/usr": cannot mkdir path segment ".snap": permission denied | 15:51 |
| ogra_ | uh | 15:51 |
| odc | bbl | 15:56 |
| Chipaca | zyga: ^ cannot create mimable writer | 16:02 |
| Chipaca | or writable mimic or sth | 16:02 |
| pstolowski | Mount snap "test-snapd-content-circular2" (2) ([start var-lib-snapd-snap-test\x2dsnapd\x2dcontent\x2dcircular2-2.mount] failed with exit status 1: Job for var-lib-snapd-snap-test\x2dsnapd\x2dcontent\x2dcircular2-2.mount failed. | 16:04 |
| pstolowski | these kind of mount failures seem to be recurring | 16:05 |
| === pstolowski is now known as pstolowski|afk | ||
| zyga | odc: hello | 16:22 |
| zyga | odc: sorry, I was busy, we please talk about this now | 16:22 |
| zyga | odc: can you tell me about the snap, what features are you using (content interfaces, layouts, etc) | 16:23 |
| Chipaca | zyga: <odc> bbl | 16:26 |
| zyga | aha, thanks | 16:27 |
| mvo | pedronis: I updated 5537 based on your comments, thanks for those! | 16:51 |
| odc | aaand i'm back @ zyga | 16:59 |
| * odc switches computer | 16:59 | |
| Chipaca | odc: he's having lunch | 17:02 |
| Chipaca | odc: he'll be back in 15' | 17:03 |
| odc | Chipaca: which begs the question, why are you not having lunch? | 17:03 |
| Chipaca | odc: because I'm having tea | 17:03 |
| Chipaca | I'm in London, he's in … somewhere in the east of Canada | 17:04 |
| mvo | yummy tea yummy | 17:04 |
| odc | heh | 17:04 |
| Chipaca | montreal, i think | 17:04 |
| odc | he's not gonna like me then. I'm a "maudit français" | 17:05 |
| Chipaca | odc: hes polish, so most probably dngaf | 17:05 |
| odc | lol | 17:05 |
| pedronis | mvo: +1, need a 2nd review | 17:12 |
| zyga | re | 17:19 |
| zyga | odc: back, thank you for waiting | 17:19 |
| odc | hi zyga | 17:19 |
| zyga | so, I think you pasted some basic information | 17:20 |
| odc | i reproduced the previous error on my desktop | 17:20 |
| odc | 1sec | 17:20 |
| zyga | but because of the risk that I just need to run to another meeting | 17:20 |
| zyga | can you paste all the details agin please | 17:20 |
| zyga | I will copy that and look into it after the event, if necessary | 17:20 |
| odc | https://usercontent.irccloud-cdn.com/file/T6hxxsx5/snapcraft.yaml | 17:20 |
| zyga | I will definitely debug it as this part has to be just work and I'm on point for that | 17:21 |
| odc | i see :) | 17:21 |
| odc | well, the error happens both on ubuntu 16 and 18 | 17:21 |
| odc | i had no issue producing the snap | 17:22 |
| odc | (i build them inside docker) | 17:22 |
| odc | do you need me to paste the output when i run the app? | 17:22 |
| odc | aloso, i got the error even before using "base: core18" | 17:24 |
| pstolowski|afk | zyga: #5532 is fixed | 17:27 |
| mup | PR #5532: api/connect: ignore connect if already connected <Created by stolowski> <https://github.com/snapcore/snapd/pull/5532> | 17:27 |
| zyga | odc: ideally I'd get: | 17:28 |
| zyga | odc: dmesg | grep DENIED # from the device where this just occurred | 17:28 |
| zyga | odc: yaml's for the snap that was used (just the snap yaml, I don't need the snapcraft one) | 17:28 |
| zyga | odc: I will inspect that and perhaps ask some follow up | 17:29 |
| zyga | odc: if you can please share the binary snap file | 17:29 |
| zyga | odc: (in private if you prefer) | 17:29 |
| zyga | odc: as I can then explore this and ensure it's fixed | 17:29 |
| odc | zyga: what is "the snap yaml"? | 17:29 |
| zyga | odc: the file meta/snap.yaml | 17:31 |
| zyga | relative to the snap itself | 17:31 |
| zyga | after installation you can find it in /snap/$snap-name/current/meta/snap.yaml | 17:31 |
| odc | zyga: i think you've found the problem: audit: type=1400 audit(1532020065.397:83): apparmor="DENIED" operation="mkdir" profile="snap-update-ns.ahoviewer" name="/tmp/.snap/" | 17:33 |
| zyga | odc: yes, that's quite what I was looking for | 17:33 |
| zyga | odc: what is your "snap version"? | 17:33 |
| odc | https://www.irccloud.com/pastebin/brSCw3ar/snap%20version | 17:34 |
| zyga | thank you | 17:34 |
| zyga | oh, that's interesting | 17:34 |
| odc | orly? | 17:34 |
| zyga | give me a moment please | 17:35 |
| zyga | ahhh | 17:35 |
| zyga | I see | 17:35 |
| zyga | base: core18 | 17:35 |
| zyga | I think I understand the problem now | 17:35 |
| zyga | can you share some more files: | 17:35 |
| zyga | please collect: /var/lib/snapd/mount/snap.ahoviewer.fstab and /var/lib/snapd/mount/snap.ahoviewer.user-fstab | 17:36 |
| odc | https://usercontent.irccloud-cdn.com/file/vRcLB7Sn/snap.yaml | 17:36 |
| zyga | just paste them here (thank you for using ircloud, much easier) | 17:36 |
| zyga | jdstrand: security question: should devmode snap run snap-update-ns with a non-enforcing policy? | 17:37 |
| odc | https://usercontent.irccloud-cdn.com/file/X28bldY6/snap.ahoviewer.fstab https://usercontent.irccloud-cdn.com/file/ImM9PvMu/snap.ahoviewer.user-fstab | 17:38 |
| zyga | mvo: hey | 17:38 |
| zyga | odc: I know exactly what the problem is now | 17:39 |
| zyga | odc: can you do this to test my theory: | 17:39 |
| odc | \o/ | 17:39 |
| zyga | odc: please edit the snap.ahoviewer.fstab file | 17:39 |
| zyga | odc: you can use sudo and any editor you like (e.g. nano) | 17:40 |
| odc | yup | 17:40 |
| odc | vi | 17:40 |
| zyga | odc: please remove the second row | 17:40 |
| zyga | odc: save the file | 17:40 |
| zyga | and restart your application | 17:40 |
| zyga | (not sure if it ran successfully or died on startup before) | 17:41 |
| * zyga prepares a PR | 17:41 | |
| odc | zyga: it ran faster and i didn't get the error :) | 17:41 |
| zyga | odc: so that was it? that was preventing the startup? | 17:42 |
| zyga | odc: one more thing | 17:42 |
| zyga | odc: please top the app | 17:42 |
| zyga | odc: and run: sudo /usr/lib/snapd/snap-discard-ns ahoviewer | 17:42 |
| zyga | then run the application again | 17:42 |
| zyga | (on command line perhaps) | 17:42 |
| zyga | and see if it starts | 17:42 |
| odc | zyga: the main problem is that the app does not use my gtk theme and there are plenty of gdk-pixbuf errors | 17:43 |
| zyga | odc: the theme part is a separate issue, | 17:43 |
| zyga | odc: for that and the pixbuf issue please go to the forum; I think you need to use the desktop helpers to integrate with that | 17:44 |
| zyga | but I'm not the best person to talk about that so I don't know how to help you immediately | 17:44 |
| odc | k | 17:44 |
| zyga | I will fix this issue for the next release | 17:44 |
| odc | well snap runs fine now :) | 17:44 |
| zyga | on the forum kyrofa or popey can help you with the desktop intetgration | 17:44 |
| zyga | odc: *thank you* | 17:44 |
| zyga | thank you for using core18 early | 17:45 |
| odc | nonono, thank YOU | 17:45 |
| zyga | (we haven't released it fully yet) | 17:45 |
| zyga | snaps would be nothing without people making and using them | 17:46 |
| zyga | I'll get to it now | 17:46 |
| odc | well, i never really liked deb packaging ^^ | 17:47 |
| cachio | mvo, sru is validated | 17:50 |
| cachio | but there is a suite which wasn't executed | 17:50 |
| jdstrand | zyga: I don't see why it should be unconfined | 17:52 |
| cachio | mvo, the rest is everything ok | 17:52 |
| cachio | mvo, should we re-execute this one? | 17:52 |
| jdstrand | zyga: it's an equivalent question to ask if snap-confine should not be confined with devmode | 17:52 |
| jdstrand | zyga: well, roughly equivalent. I mean, we have the profile so that it is limited in what it should do since it is called by root running processes | 17:54 |
| jdstrand | zyga: and snap-confine calls snap-update-ns | 17:54 |
| zyga | jdstrand: ack | 18:00 |
| zyga | thank you | 18:01 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/5527 needs a 2nd review | 18:01 |
| mup | PR #5527: overlord/ifacestate: support implicit slots on snapd <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5527> | 18:01 |
| zyga | and I would love to see it in this week :) | 18:01 |
| Chipaca | zyga: I added a comment in last.go, maybe it helps? (wrt the l==-1) | 18:10 |
| Chipaca | zyga: this is in #5531 | 18:10 |
| mup | PR #5531: cmd/snap: support `--last=<type>?` to mean "no error on empty" <Created by chipaca> <https://github.com/snapcore/snapd/pull/5531> | 18:10 |
| zyga | Chipaca: thanks, I'll check | 18:10 |
| zyga | I'm looking at another branch of yours | 18:10 |
| zyga | :-) | 18:10 |
| Chipaca | zyga: is it very obvious I'm finding the ones I _should_ be doing to be challenging? | 18:11 |
| Chipaca | :-) | 18:11 |
| zyga | Chipaca: I suspect it works in practice | 18:14 |
| zyga | just feels bad | 18:14 |
| zyga | Chipaca: can you please please please review https://github.com/snapcore/snapd/pull/5527 | 18:14 |
| mup | PR #5527: overlord/ifacestate: support implicit slots on snapd <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/5527> | 18:14 |
| Chipaca | zyga: yes, now. | 18:14 |
| Chipaca | zyga: is this the one you asked me before and i forgot? | 18:14 |
| zyga | yes | 18:15 |
| zyga | it's the most important one now | 18:15 |
| zyga | Chipaca: actually, as a general comment, we could use all-hands-on-deck on core18 reviews | 18:16 |
| zyga | we have very little time left | 18:16 |
| zyga | another useful PR to review is https://github.com/snapcore/snapd/pull/5537 | 18:16 |
| mup | PR #5537: snapstate: ensure kernel-track is honored on switch/refresh <Core18> <Created by mvo5> <https://github.com/snapcore/snapd/pull/5537> | 18:16 |
| zyga | but I can do that now | 18:16 |
| === Mirv_ is now known as Mirv | ||
| Chipaca | zyga: #5410 is good to go i think | 18:24 |
| mup | PR #5410: tests: update tests to work on core18 <Core18> <Reviewed> <Created by mvo5> <https://github.com/snapcore/snapd/pull/5410> | 18:24 |
| zyga | Chipaca: yes, it was intertwined with the racy test but that got spun off | 18:24 |
| bdx | hello, where can I file a bug for snapcraft? | 18:43 |
| bdx | ahh got it | 18:45 |
| bdx | somehow I was ending up at https://bugs.launchpad.net/~snapcraft | 18:46 |
| bdx | I'm hitting https://paste.ubuntu.com/p/z8Cc2Pwv2x/ | 18:47 |
| bdx | not sure if its been handled yet ... looking through the bugs now | 18:47 |
| bdx | oooh, possibly thats my bad actually ... | 18:49 |
| bdx | looks like the issue may have been that I left the source-type, source-depth, and source-branch configs set after switching my source to local ... https://paste.ubuntu.com/p/jBBr3rVkT9/ | 18:51 |
| pedronis | Chipaca: where does the "\n" in fron comes in your change to #5537 | 18:51 |
| mup | PR #5537: snapstate: ensure kernel-track is honored on switch/refresh <Core18> <Created by mvo5> <https://github.com/snapcore/snapd/pull/5537> | 18:51 |
| pedronis | the template has kernel%s | 18:52 |
| Chipaca | pedronis: look at how it's used | 18:52 |
| Chipaca | aaand i forgot the initial '\n' myself | 18:53 |
| Chipaca | dangit | 18:53 |
| * Chipaca fixes | 18:53 | |
| pedronis | Chipaca: that's what I'm asking about | 18:53 |
| Chipaca | pedronis: soz | 18:54 |
| Chipaca | pedronis: pushed | 18:54 |
| pedronis | better :) | 18:54 |
| pedronis | Chipaca: you didn't run the tests locally I suppose :) | 18:55 |
| Chipaca | pedronis: not for this one | 18:55 |
| Chipaca | I usually do :-) | 18:55 |
| pedronis | anyway better to stop, I might start to spot inexistent issues | 18:55 |
| Chipaca | otherwise you'd've seen this happen a lot more | 18:55 |
| Chipaca | pedronis: "this PR has no dinner!" | 18:56 |
| pedronis | Chipaca: anyway I was confused, because I thought you would indeed :) so I was wondering what I was missing | 18:56 |
| mvo | zyga: will review either tonight or early in my morning | 18:56 |
| zyga | mvo: thank you very much | 19:00 |
| zyga | mvo: chipaca is helping with reviews | 19:00 |
| zyga | mvo: I think we are very close now | 19:00 |
| mvo | zyga: yay | 19:01 |
| mvo | zyga: yeah, he pushed a very nice fix into 5537 | 19:01 |
| * mvo hugs Chipaca | 19:01 | |
| mvo | zyga: aha and you suggested it :) | 19:02 |
| mvo | zyga: do you want to do a final pass on 5537 or shall I merge? it has two +1 already | 19:02 |
| mvo | zyga: also, whats up with 5529 ? does this need a pass from gustavo? or can it go in? | 19:03 |
| mvo | 5450 also needs a second review … | 19:03 |
| zyga | re | 19:20 |
| zyga | mvo: looking | 19:21 |
| zyga | yeah, let's get it in | 19:21 |
| zyga | that is | 19:21 |
| zyga | let's get 5537 in | 19:21 |
| zyga | mvo: as for 5529 - are you sure that is the PR you were thinking about? it's a integration / test PR that's not meant for landing | 19:22 |
| zyga | mvo: I will review 5450 | 19:22 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/5530 has some conflicts but I didn't do anything to fix it yet | 19:25 |
| mup | PR #5530: tests: use file based markers in snap-service-stop-mode <Blocked> <Core18> <Created by mvo5> <https://github.com/snapcore/snapd/pull/5530> | 19:25 |
| Chipaca | mvo: zyga: back from dinner, what needs reviewing? | 20:34 |
| zyga | hey | 20:34 |
| zyga | let me re-check | 20:35 |
| zyga | I'm reading the hardlink PR | 20:35 |
| zyga | but anything core 18 I suspect | 20:35 |
| zyga | + Chipaca's fantastic small PRs | 20:35 |
| zyga | but don't kill youself over this | 20:35 |
| Chipaca | zyga: totally not killing myself | 20:35 |
| zyga | I'd love to know if we can (or maybe we do already) run main tests on core18 already | 20:35 |
| zyga | ah | 20:35 |
| zyga | I just realized I'm dumb | 20:35 |
| zyga | I didn't understand it was you talking | 20:36 |
| Chipaca | zyga: isn't that #5529 ? | 20:36 |
| mup | PR #5529: many: run all main tests on core18 <Blocked> <Core18> <Created by mvo5> <https://github.com/snapcore/snapd/pull/5529> | 20:36 |
| zyga | I thought that was mvo from his bbq | 20:36 |
| zyga | :D | 20:36 |
| zyga | Chipaca: no, that is a fat integration with lots of (now gone) patches AFAIR | 20:36 |
| Chipaca | mvo + bbq? does not compute | 20:36 |
| zyga | Chipaca: see | 20:36 |
| Chipaca | unless this "bbq" has no meat | 20:36 |
| zyga | maybe they slowly burn potatoes | 20:36 |
| Chipaca | zyga: so... what needs reviewing :-) | 20:43 |
| Chipaca | zyga: now that you know I'm me | 20:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
