[16:09] <jman_38376462> hello, everyone. newcomer here, I'd like to submit a patch to a package
[16:10] <jman_38376462> I'm folling this guide http://packaging.ubuntu.com/html/fixing-a-bug.html
[16:10] <jman_38376462> *following
[16:11] <jman_38376462> and I think I need a bit of help , I'm stuck somewhere in builiding the new package that I've patched
[16:14] <jman_38376462> so, here's the thing. I *think* I've setup my workstation correctly and created+applied the patch. Now the build of the new package for testing fails
[16:14] <jman_38376462> here's the output: https://paste.ubuntu.com/p/N8FS6BzYQv/
[16:15] <jman_38376462> not sure what I need to fix
[16:16] <tsimonq2> That's an interesting one.
[16:16] <tsimonq2> How exactly did you set up your environment?
[16:19] <jman_38376462> Starting from scratch, I've followed this guide http://packaging.ubuntu.com/html/getting-set-up.html
[16:19] <jman_38376462> (I already have a launchpad account and GPG key uploaded)
[16:20] <tsimonq2> Ah.
[16:20] <jman_38376462> basically I've only installed the packages "gnupg pbuilder ubuntu-dev-tools apt-file"
[16:20] <tsimonq2> Hmm.
[16:21] <jman_38376462> let's start with an easy question
[16:21] <jman_38376462> I got this message: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
[16:21] <tsimonq2> Ah, easy one.
[16:22] <jman_38376462> but the output of "update-maintainer" is
[16:22] <tsimonq2> ...that's what I was going to suggest. ;)
[16:22] <jman_38376462> $ update-maintainer The package targets Debian. Doing nothing.
[16:22] <jman_38376462> uff sorry for the bad formatting
[16:22] <jman_38376462> is that output ok?
[16:22] <tsimonq2> No problem.
[16:23] <jman_38376462> ok , cool
[16:23] <tsimonq2> That only means that you need a changelog entry which has "ubuntu" in it.
[16:23] <tsimonq2> So first, run "dch".
[16:23] <tsimonq2> If you're on Ubuntu, that should give you a template.
[16:24] <jman_38376462> yes, I've already run that one and completed the changelog
[16:25] <tsimonq2> Hmm.
[16:25] <jman_38376462> so my current file tree is like this:
[16:26] <jman_38376462> https://paste.ubuntu.com/p/Hk5JZKv5B2/
[16:27] <jman_38376462> I am inside "~/Projects/protracker-2.3d.r126" and try to build the test pkg
[16:28] <jman_38376462> I've manually created the file ../protracker_2.3d.r126.orig.tar.gz because "debuild" complained it was not there
[16:28] <tsimonq2> Have you ever used uscan?
[16:28] <jman_38376462> but I don't think that is the issue
[16:28] <jman_38376462> nope
[16:28] <tsimonq2> That's the Tool To Use. :)
[16:30] <jman_38376462> oh ok, that should build the src package correctly, right?
[16:32] <tsimonq2> It should build the orig correctly.
[16:36] <jman_38376462> I'm afraid (if I understand correctly the instructions) that I need a control file "debian/watch"
[16:36] <jman_38376462> that I have not in the src package I have installed
[16:38] <jman_38376462> I have these files in the "debian" dir
[16:38] <jman_38376462> https://paste.ubuntu.com/p/Xc7XRfJpKG/
[16:39] <jman_38376462> anyway, let's pretend for a sec my src package manually done is ok
[16:39] <jman_38376462> how do I debug this:
[16:39] <jman_38376462> dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -E -b -B .pc/drop-march-mtune/ --reject-file=- < /tmp/temp-lintian-lab-yvm8ijp3T1/pool/p/protracker/protracker_2.3d.r126-1ubuntu1_source/unpacked/debian/patches/drop-march-mtune subprocess returned exit status 1
[16:40] <jman_38376462> internal error: dpkg-source -x failed with status  2 at /usr/share/lintian/collection/unpacked line 72.
[16:40] <jman_38376462> do I need to run "lintian"? is it a requirement?
[16:46] <tsimonq2> jman_38376462: Try just running `debuild -S -d -sa`.
[16:47] <jman_38376462> uhm ... that worked. I mean the `lintian` error is still there but I've Successfully signed dsc, buildinfo, changes files
[16:48] <tsimonq2> You can probably ignore the Lintian error.
[16:48] <jman_38376462> ok
[16:48] <jman_38376462> now, move fwd
[16:50] <jman_38376462> the build command `pbuilder-dist bionic build ../protracker_2.3d.r126-1ubuntu1.dsc` fails with
[16:50] <jman_38376462> https://paste.ubuntu.com/p/kDPcSVRgwb/
[16:51] <jman_38376462> I think I've not cleanly patched the source or ... the src package I've created is not good. opinions?
[16:55] <jman_38376462> well, now I have to go. I'll start from scratch later and carefully go through the steps (or maybe find a tutorial to have a second opinion on the process)
[16:56] <jman_38376462> anyway thanks for the suggestions, I'll investigate them later (src pkg build and patching)
[17:04] <tsimonq2> jman_38376462: Use quilt to refresh your patches.
[17:04] <tsimonq2> jman_38376462: A great guide is here: https://raphaelhertzog.com/2012/08/08/how-to-use-quilt-to-manage-patches-in-debian-packages/
[17:05] <jman_38376462> great, thanks! I'll give it a shot
[19:32] <jman_38376462> Hi again, I'm progressing and understanding the whole process.
[19:33] <jman_38376462> I have another question: do I need to be into the temporary directory created by `edit-patch` to run the `quilt` commands or should I be out of it?
[19:34] <jman_38376462> i.e. does it make any difference running `quilt` without using `edit-patch this_is_my_patch`?
[19:35] <jman_38376462> it looks to me they kind of overlap the same feature (create and edit a patch)
[20:39] <rbasak> jman_38376462: I'm not particularly familiar with edit-patch. The key thing that you'll be delivering is the contents of the debian/ directory. Specifically debian/patches for patching the upstream code. It doesn't matter what tooling you use to get the result - whether quilt direclty or edit_patch - the review will be based on the diff against the source tree (essentially just debian/)
[20:40] <jman_38376462> ok, thanks
[20:40] <jman_38376462> I'm ready to attach a patch to #1769693
[20:41] <jman_38376462> it's my first time so there'll probably be things to fix, your feedback is much appreciated
[20:45] <rbasak> No problem. Thank you for working on this!
[20:45] <jman_38376462> (y)