mborzecki | morning | 05:23 |
---|---|---|
mborzecki | mvo: hi, looks like we might have a bug in time schedule, with some specific days of the month, i'm looking into it | 07:02 |
mvo | mborzecki: ok, thank you | 07:03 |
mborzecki | according to go hmm 2017-08-01 00:00:00 +0200 CEST is Tuesday | 07:18 |
abeato | mvo, hey, I had to make this small change in MM and other interfaces: https://github.com/snapcore/snapd/pull/5572 | 07:18 |
abeato | mvo, would appreciate if this can be incorporated to the nex release | 07:18 |
mvo | abeato: checking | 07:20 |
abeato | thx | 07:20 |
mvo | abeato: we will need jdstrand for this - at least for a second review. but yeah, happy to merge into one of the release PRs once it got that review | 07:21 |
abeato | mvo, sure, we indeed need him | 07:21 |
mvo | abeato: slightly unfortunate timing :/ we did 2.34.3 on Friday so there will be a bit of time before the next regular release. how urgent is this for you? | 07:22 |
abeato | mvo, well, urgent, but can wait a bit in principle. When is the next release planned? | 07:23 |
mvo | abeato: the next regular release would be 2.35 which is ~4-6 weeks away. we can do a point release if its critical which will take ~2 weeks (because the 2.34.3 needs to be released first which is ~1 week) | 07:25 |
abeato | mvo, ok, I see. I need to check these dates with the client, thanks for the info - will let you know | 07:27 |
mvo | abeato: if does do not match we need talk and think about options | 07:27 |
abeato | sure :) | 07:28 |
mvo | mborzecki: woah, the amazon linux packaging is pretty neat, looks like someone (looking at Neal most likely) did a great job on the fedora packaging to make it pretty universal | 07:30 |
mborzecki | mvo: yes, a couple of %if and it built just fine | 07:30 |
mvo | mborzecki: why do we need "storage: preserve-isze" for there? | 07:31 |
mvo | mborzecki: yeah, neat! | 07:31 |
mborzecki | mvo: the default image is 25gb, and iirc if we resize it to 10gb it does not boot anymore | 07:31 |
mvo | mborzecki: aha, right | 07:31 |
mvo | mborzecki: and there is a spread bug that prevents setting this more fine grained(?) | 07:32 |
mborzecki | mvo: cachio knows the details, he's proposed the intial pr to spread | 07:32 |
mvo | mborzecki: ok | 07:32 |
mvo | abeato: 5469 got two +1 but has some conflicts. do you think you have some cycles to look at those conflicts? | 07:42 |
mborzecki | hm weird, so in the tests 2017-08-01 00:00:00 +0200 CEST .Weekday() is Tuesday, when I run a similar sample in play it's wednesday https://play.golang.org/p/i1-tcO-OzBx same sample ran locally is wednesday too :( | 07:42 |
abeato | mvo, sure, let me take a look | 07:43 |
mvo | cjwatson: quick question about building snaps on LP. I tried to build the openstreetmap editor josm directly from their svn in LP but get an error: svn: E170013: Unable to connect to a repository at URL 'https://josm.openstreetmap.de/svn/trunk' | 07:43 |
mvo | cjwatson: is this just not possible or anything I can do to fix it? | 07:43 |
mvo | mborzecki: a second review for 5563 would be great, hopefully straightforward | 07:45 |
mborzecki | mvo: looking | 07:45 |
mvo | and 5450 needs a second review as well but its less important (just a small optimization) | 07:47 |
cjwatson | mvo: It's in principle possible but needs some work in launchpad-buildd - see https://bugs.launchpad.net/launchpad-buildd/+bug/1668358 | 07:53 |
mvo | cjwatson: thank you | 07:57 |
mvo | cjwatson: would it be https://code.launchpad.net/~cjwatson/launchpad-buildd/snap-git-proxy/+merge/323691 for svn? or is there more to it? | 07:59 |
mvo | cjwatson: hm, probably not because this is using plain http for the checkout(?) | 08:01 |
mborzecki | note to self, double check the year before swearing at go time parser | 08:02 |
mvo | mborzecki: haha | 08:02 |
mborzecki | i clearly need more coffee | 08:03 |
cjwatson | mvo: I think it would involve writing out ~/.subversion/servers with proxy info | 08:05 |
cjwatson | Probably not super-hard but needs testing ... | 08:06 |
mborzecki | mvo: #5573 fixes the timers | 08:56 |
mvo | mborzecki: thank you | 08:57 |
Chipaca | moin moin | 09:00 |
* Chipaca started a bit late | 09:00 | |
mborzecki | mvo: i'll label it 2.34 in case we do another .34 release | 09:00 |
mborzecki | Chipaca: hi there, there's always a timezone in which it's early :) | 09:00 |
Chipaca | clearly i'm on UTC and just on time | 09:01 |
mvo | mborzecki: +1 | 09:02 |
mvo | Chipaca: hey, good morning! | 09:02 |
Chipaca | mvo: how're you doing? | 09:02 |
mvo | Chipaca: I'm doing well, thank you! how are you? | 09:03 |
Chipaca | mvo: not bad! anything on fire? | 09:03 |
mvo | Chipaca: no new fire afaict, git deb package builds are unhappy to a varying degree, s390x in particular is unhappy since some time. but thats not yet too much of a problem (it will be once we need to do a new release) | 09:05 |
Chipaca | boo | 09:05 |
mvo | Chipaca: also some review would be great but otherwise things are calm right now. we need to aim for a beta of snapd that supports booting core18 this week | 09:08 |
mvo | Chipaca: so not entirely calm :) | 09:08 |
Chipaca | heh | 09:08 |
Chipaca | mvo: other than 5557 is there anything for core18 that needs a review? | 09:13 |
mvo | Chipaca: only 5549 which will be needed as part of the failover code for snapd but its not super urgent as on its own its not super useful | 09:17 |
mvo | Chipaca: 5570 is an easy win | 09:17 |
mvo | Chipaca: and 4.15 does not boot today again, *maybe* the entropy bug again in a different form, I'm just looking into this | 09:19 |
Chipaca | there's been a bunch of people on 18.04 that found all their snaps stopped working, btw | 09:19 |
Chipaca | not sure if that's already been sorted | 09:20 |
Chipaca | #1757284 | 09:20 |
mborzecki | #5572 probably needs a look from jdstrand | 09:31 |
mvo | Chipaca: is this similar to the forum thread from last week? | 09:37 |
mvo | Chipaca: I think we got a report that after an update there was suddenly havoc | 09:37 |
Chipaca | mvo: ah, probably, i might've merged the two in my head | 09:37 |
Chipaca | yeah sounds like it | 09:37 |
mvo | https://forum.snapcraft.io/t/bug-broken-snaps-after-each-update/6536 | 09:38 |
mborzecki | mvo: Chipaca: have you seen this https://forum.snapcraft.io/t/all-snap-app-crashed-on-ubuntu-18-04/6596/2 ? | 09:55 |
Chipaca | mborzecki: isn't that #1757284? | 09:56 |
Chipaca | mborzecki: and given mvo replied to that thread, my magic ball says he's seen it | 10:01 |
mborzecki | Chipaca: the forum topic feels like a mix of 2 different issues | 10:03 |
mvo | could well be two similar issues, I have not tried to reproduce myself, no time :/ but I think we need to look at this | 10:04 |
mborzecki | nice how firefox has connection refusded on display, chromium gets sigtrap, ohmyfiraffe just segfaults | 10:04 |
mvo | hm, is mup actually back? | 10:07 |
mvo | apparently not, pretty trivial PR https://github.com/snapcore/core18/pull/52 | 10:08 |
mvo | (this is the reason why core18 was hanging in my local spread run, testing this right now) | 10:09 |
mvo | mborzecki, Chipaca did you figure anything out about the bugreport(s) above? sorry, was a bit distracted with looking into kernel hang (tricky to debug, easy once understood :/ | 10:45 |
mborzecki | mvo: left a note in the forum, my bet is on apparmor for now | 10:54 |
mvo | ta | 10:56 |
mvo | 5560 needs a second review (trivial I hope) | 11:05 |
Chipaca | mvo: isn't it superseded? | 11:13 |
mvo | Chipaca: I just updated it | 11:16 |
Chipaca | ohhhh | 11:17 |
Chipaca | mvo: lgtm, then :-) | 11:17 |
mvo | Chipaca: ta | 11:21 |
Chipaca | mvo: want to know something hilarious: the _internal_ copy of runtime has a BigEndian boolean | 11:37 |
Chipaca | ah, no, internal/sys (so syscall) | 11:38 |
mvo | Chipaca: oh, *fun* | 11:43 |
mvo | Chipaca: I remember reading a long discussion why you shouldn't care about endianess in one of the bug bugs and I have given up on anything like official support for this | 11:44 |
Chipaca | mvo: yeah | 11:45 |
Chipaca | mvo: it's entirely possible they're right, and either our test is doing more work than it should, or udev is bonkers, or both | 11:45 |
Chipaca | mvo: ¯\_(ツ)_/¯ | 11:45 |
Chipaca | it's also not outside of the realm of the possible that this particular bit is the exception | 11:46 |
mvo | yeah | 11:46 |
Chipaca | mvo: should I add IsBigEndian to osutil? | 11:47 |
mvo | Chipaca: hm, that sounds like a nice idea | 11:48 |
mvo | Chipaca: fwiw, for practical purposes the check for s390x is fine, we don't support mips and our ppc64 is little endian (I will double check that though) | 11:48 |
mvo | Chipaca: yep - endian-little | 11:49 |
Chipaca | mvo: yep, ppc64 vs ppc64el | 11:50 |
* mvo nods | 11:50 | |
Chipaca | Let's write a cpu that _only_ works in bigendian bcd | 11:50 |
Chipaca | mvo: anyway, just lunchtime rambling, not blocking or anything | 11:52 |
mvo | Chipaca: ta | 11:55 |
mvo | Chipaca: yeah, probably a good idea to make it pretty | 11:55 |
mvo | (prettier than it currently is) | 11:55 |
Chipaca | mvo: also, did you inhale lunch, or are you IRCing while eating, and in either case, dude | 11:55 |
pedronis | mvo: mborzecki: Chipaca: anything I can still do for you today before calling it a week? (after the standup I have a bunch of meetings) | 11:55 |
mvo | Chipaca: was a bit optimist about it, its not quite ready, should be any minute hopefully :) | 11:56 |
Chipaca | mvo: ah :-) | 11:56 |
Chipaca | pedronis: I've got half a mind to drop the horizontal snapshot approach, close snapshotstate, and instead do verticals | 11:57 |
mborzecki | pedronis: i'm finishin up with with some changes to 5561, would be great it you could date a look before you leave, i understand it's a bit mind numbing though so no worries if you cannot make it :) | 11:57 |
Chipaca | pedronis: like, "this pr implements 'snap snapshots'", etc | 11:58 |
Chipaca | and maybe then slice _those_ into horizontals | 11:58 |
Chipaca | and maybe, maybe, i can get reviews | 11:58 |
pedronis | Chipaca: that doesn't sound something like I can help today, unless you propose it this second | 11:58 |
Chipaca | pedronis: no, it's a week's work imo | 11:58 |
Chipaca | OTOH I could also do the arch-indep work | 11:59 |
Chipaca | that's also a week + in my estimate | 11:59 |
Chipaca | dunno | 11:59 |
Chipaca | pedronis: to answer your question: I doubt I'll have anything for you to do for me today before the standup, thank you | 12:00 |
pedronis | ok | 12:00 |
mvo | pedronis: all good from my side | 12:01 |
pedronis | mborzecki: I'll see what I can do, we should chat a bit in the standup about what is not there and the state overall of parallel installs | 12:02 |
rbasak | error: open /var/lib/snapd/hostfs/home/ubuntu/snap/lxd/common/snapcraft7l7sklw8/core_4917.assert: no such file or directory | 12:03 |
rbasak | Known issue? Sounds familiar but my Googling is failing me. | 12:04 |
rbasak | subprocess.CalledProcessError: Command '['lxc', 'file', 'push', '/home/ubuntu/snap/lxd/common/snapcraft7l7sklw8/core_4917.assert', 'local:snapcraft-nondiffidently-overfastidious-luetta/run/core_4917.assert']' returned non-zero exit status 1 | 12:04 |
rbasak | Ah, bug 1746612. | 12:05 |
rbasak | Except that I am using the lxd cnap. | 12:06 |
rbasak | snap | 12:06 |
rbasak | Oh no, I'm not. I thought I was. | 12:06 |
rbasak | Never mind :-/ | 12:06 |
mborzecki | pedronis: regarding https://github.com/snapcore/snapd/pull/5561#discussion_r205805753 do you think it makes sense to verify this again in checkSnap() ? | 12:14 |
pedronis | mborzecki: sorry I don't understand which PR are you referring to? it doesn't seem to check that the name matches | 12:17 |
pedronis | if you mean #5567 | 12:18 |
mborzecki | pedronis: what i meant that it's probably more applicable to snap.Validate(), as it feels like a part of sanity check, and snapstate checks seem more like functional checks | 12:25 |
mborzecki | pedronis: pff nvm, was thinking about something else entirely :) | 12:26 |
pedronis | mborzecki: maybe, but but something has to give, Validate takes an info, either that info already has a full intance name split into it | 12:26 |
pedronis | but then it's late or something needs tweaking in that interface | 12:26 |
pedronis | mborzecki: I removed my -1, don't think I can manage to review it again fully, we can discuss a bit about state in the standup as I said | 12:35 |
mborzecki | pedronis: ack, who do you tnink is equally well familiar with those internals that might take a look too? | 12:36 |
pedronis | mborzecki: mvo, also John, what you are likely to be blocked on is alias stuff | 12:36 |
mborzecki | yeah, i remember pulling my hair on this not long ago | 12:37 |
pedronis | otoh you might be able to attack some of the interface bits | 12:38 |
mborzecki | pedronis: heh, i dug up the changes for that TODO in SetupSnap in some other branch i have, guess I'll refactor this to be in checkSnap instead | 12:56 |
mborzecki | no link in the calendar for the standup? | 12:59 |
mvo | mborzecki: strange | 13:00 |
mborzecki | it's not in my calendar either | 13:00 |
pedronis | mvo: I pinged Gustavo about this last week, it's probably related to hangout vs meet | 13:01 |
abeato | mvo, https://github.com/snapcore/snapd/pull/5469 passed now the spread tests | 13:01 |
mvo | abeato: cool, thank you | 13:01 |
mvo | abeato: I have a look after the meeting | 13:01 |
abeato | mvo, great, thanks | 13:01 |
Chipaca | jdrab: in tty[a-zA-Z]*[0-9]*, doesn't that still match 'tty' (and 'ttyprintk') | 13:06 |
Chipaca | ? | 13:06 |
Chipaca | er | 13:06 |
Chipaca | jdstrand: ^ | 13:06 |
jdstrand | Chipaca: it is shell glob matching, not regex, so, 'no' | 13:11 |
jdstrand | Chipaca: eg: ls /dev/tty[a-zA-Z]*[0-9]* | 13:12 |
Chipaca | jdstrand: ah! i thought it was regexps because of the alternation | 13:12 |
jdstrand | it looks like a regex to be sure | 13:12 |
jdstrand | but it isn't | 13:12 |
Chipaca | :-) ok | 13:12 |
Chipaca | jdstrand: i'll dig out my udev dunce hat in a moment | 13:12 |
jdstrand | Chipaca: well, that is quite the subtlety for that hat! | 13:13 |
jdstrand | I just assume you keep it in the drawer | 13:13 |
Chipaca | jdstrand: under my pillow | 13:14 |
jdstrand | heheh | 13:16 |
=== chihchun_afk is now known as chihchun | ||
cachio | mborzecki, that error on amazon PR is not a problem now | 13:50 |
cachio | I took a look and everything is ready to be landed | 13:50 |
cachio | I'll create the PR today on spread to setup the preserve at system level | 13:50 |
mborzecki | cachio: great | 13:50 |
mborzecki | cachio: could you do another review of #5552 too? | 13:51 |
cachio | mvo, we got the +1 to go to candidate | 13:51 |
cachio | mborzecki, sure | 13:51 |
mborzecki | cachio: thank you | 13:51 |
mvo | cachio: cool, lets do it | 13:52 |
cachio | mvo, 2.34.3 in candidate now | 14:03 |
mborzecki | mvo: could you upload a release tarball for snapd later on? | 14:06 |
mvo | mborzecki: sure, let me do this now | 14:07 |
mborzecki | mvo: thank you! | 14:07 |
mvo | mborzecki: should be there now | 14:09 |
mborzecki | mvo: it is, thanks a lot! | 14:09 |
xnox | mvo, snapd will break on cosmic with usrmerge =) or possibly not, not sure.... https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1784394 | 14:17 |
xnox | there is a small patch there.... =) | 14:18 |
mvo | xnox: thanks, looking | 14:20 |
mvo | xnox: thanks, will do, it probably won't break as this should just be a symlink but its more correct this way | 14:21 |
xnox | yeah | 14:22 |
mvo | xnox: will do a PR shortly! | 14:22 |
mborzecki | arch package updated to 2.34.3 | 14:25 |
mvo | ta | 14:25 |
mborzecki | 5573 is green, if anyone wants to do a 2nd review we could land it soon :) | 14:27 |
cachio | mborzecki, #5552 merged | 14:38 |
mborzecki | cachio: thanks! | 14:42 |
* pedronis eows | 14:59 | |
ogra | EOWing on a monday ... nice :) | 15:29 |
* genii slides ogra a mug of their favourite beverage | 15:43 | |
* ogra slurps | 15:54 | |
* cachio lunch} | 16:10 | |
mvo | Chipaca: this core18 snapd unit writing is a bit of a pita - but thanks a lot for your PR (and thanks to mborzecki as well). I'm slowly moving forward here, the restarting is still a bit fiddly | 16:10 |
Chipaca | mvo: when you say my PR, you mean my review of your PR? | 16:11 |
mvo | Chipaca: yes! the heat make me take mental shortcuts | 16:12 |
Chipaca | mvo: HLQP! :-) | 16:13 |
Chipaca | mvo: why the // FIXME instead of changing the Start to a Restart? | 16:29 |
mvo | Chipaca: because it does not work yet | 16:32 |
mvo | Chipaca: I got errors with exitcode: -1 | 16:32 |
mvo | Chipaca: which is strange | 16:33 |
Chipaca | mvo: boooo 👻👎 | 16:33 |
mvo | Chipaca: looking into this now but wanted to get a spread run with improved tests | 16:33 |
mvo | Chipaca: yeah :) or rather: :( | 16:33 |
Chipaca | mvo: ok :-) | 16:33 |
mvo | Chipaca: the fact that we get -1 is a bug in itself | 16:33 |
Chipaca | mvo: yeah | 16:33 |
mvo | Chipaca: oh well | 16:33 |
ogra | just add a +2 at the top ! | 16:43 |
mvo | Chipaca: you mention ReplaceAllString in pr#5557, content is byte, do you think this is still preferable? or am I misreading your comment? | 17:47 |
cachio | mvo, I have seen the lxd issue | 17:53 |
cachio | let me see the images because lxd should not be pre-installed | 17:54 |
mvo | cachio: thanks, I'm not sure what is going on, the PR is mostly a stab at the problem, I have not run it locally | 18:00 |
cachio | mvo, I'll fix the image | 18:03 |
mvo | cachio: ok, in this case feel free to close my PR once the image is fixed | 18:05 |
cachio | mvo, great, thanks | 18:15 |
cachio | mvo, updating the image for xenial 32 bits, if tests pass I'll close the PR | 18:17 |
mvo | Chipaca: the issue was RequiredBy vs WantedBy - oh well :) hopefully with that the restart is fine! | 19:27 |
cachio | mvo, lxd issue fixed | 19:34 |
cachio | I cloosed the PR and pasted the logs with the test results | 19:36 |
mvo | cachio: great, thank you | 19:37 |
cachio | mvo, np | 19:45 |
jdstrand | tyhicks: fyi, https://github.com/snapcore/snapd/pull/5578 and https://github.com/snapcore/snapd/pull/5579 | 21:15 |
tyhicks | jdstrand: cool, thanks | 21:17 |
jdstrand | tyhicks: hopefully it'll make it into a new 2.34 (the latest stable), but it might not and be only in 2.35. up to mvo | 21:18 |
FreeBDSM | okay, I'm ready to build firefox 52.9.0esr into a snap, how do I do that? | 21:22 |
FreeBDSM | `man snapcraft` `No manual entry for snapcraft` | 21:39 |
FreeBDSM | `autoreconf -i`: `autoreconf: 'configure.ac' or 'configure.in' is required` `Failed to run 'autoreconf -i' for 'firefox': Exited with code 1.` `Verify that the part is using the correct parameters and try again.` | 21:42 |
FreeBDSM | jesus christ, snaps are awful | 21:52 |
FreeBDSM | I just took a look at what is inside skype snap | 21:52 |
FreeBDSM | piles of shite | 21:52 |
kyrofa | Hey cachio, you still around today? | 21:58 |
jdstrand | FreeBDSM: I think that would be an indication that particular snap isn't to your taste. not all snaps are created equal | 22:03 |
cachio | kyrofa, yes | 22:11 |
cachio | kyrofa, what do you need? | 22:11 |
FreeBDSM | jdstrand: true | 22:11 |
FreeBDSM | I think it'll be easier to do `snap install firefox` and just replace firefox files with the ones from ESR 52.9.0 | 22:12 |
FreeBDSM | and just never update | 22:12 |
FreeBDSM | however, that's not much portable | 22:12 |
kyrofa | cachio, I'm trying to learn how snapd does spread testing in autopkgtests | 22:16 |
kyrofa | cachio, I see the `autopkgtest` group in spread.yaml | 22:17 |
kyrofa | Is that all there is to it? | 22:18 |
kyrofa | Basically, just point the test to happen on localhost? | 22:20 |
kyrofa | I don't understand why there are so many systems if that's all that happens, though | 22:21 |
cachio | kyrofa, the systems which you see are the targat systems for autopkgtests | 22:55 |
cachio | kyrofa, first you need to generate the machine with that systems | 22:58 |
cachio | then you run the tests against that one | 22:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!