[05:10] <mborzecki> morning
[06:14] <mborzecki> hmm arch's kernel package changed their LOCALVERSIONing scheme and our checks are failing
[06:33] <CyberManifest> are there any plans to port snapd (snap support) to macOS ?
[06:38] <mborzecki> CyberManifest: snapd is closely tied with linux atm as such i'm not aware of any plans to support other platforms, feel free to experiment though and ping us if you'd like to know more about the internals
[06:38] <mborzecki> CyberManifest: however we have plans to port the utilities for building snaps to windows and macos and this work should commence sooonish, next month most probably
[06:38] <mborzecki> mvo: hi, i've opened #5581 to fix the current problems on arch
[06:39] <CyberManifest> mborzecki: couldn't https://mesonbuild.com be used to contain the linux portions i.e. sandbox the environment?
[06:39] <CyberManifest> mborzecki: building doesn't help me run snap apps on macOS
[06:43] <mborzecki> CyberManifest: meson is a build system, so it could replace the autotools magic we currently use to build one of the elements, the rest of the code is in Go but makes use of systemd, udev, makes certain assumptions about system components and paths and so on
[06:44] <CyberManifest> so snap can't run on non systemd systems that use sysV init?
[06:44] <mborzecki> CyberManifest: we make use of some kernel interfaces like mount namespace, seccomp, i'm not familiar with macos and don't know if there are similar intefaces on macos, though it'd be exciting if anyone wanted to explore this
[06:45] <CyberManifest> mborzecki: and could homebrew not be used to port it?
[06:46] <mborzecki> CyberManifest: afaik homeberew i just for building, you'd still need to provide the functional counterparts of the intefaces we use at the system level
[06:47] <mborzecki> CyberManifest: but as i said, i'm not a mac user and have limited experience with osx
[06:48] <CyberManifest> mborzecki: it's for distribution as well; it's mostly described as a package manager
[06:53] <mvo> mborzecki: good morning! master is failing right now on arch with an "running unexpected kernel version 4.17.11-arch1 error. is that a known issue?
[06:53] <mborzecki> mvo: yes, #5581 addresses that
[06:53] <mvo> mborzecki: cool
[06:54] <mborzecki> i should porbably label it as simple ;)
[06:54] <mborzecki> mvo: https://github.com/snapcore/snapd/pull/5581
[06:54] <mvo> mborzecki: curious, why do we check the kernel version on arch?
[06:55] <mborzecki> mvo: because there's just one kernel version installed at a time, we do an upgrade before the tests, reboot, and just to be extra sure verify that we're running the right kernel (iirc there were some issues at the early beginnign of arch integration with that too)
[06:56] <mvo> mborzecki: aha, ok. makes sense, thank you
[07:07] <mborzecki> mvo: apt-hooks tests is still a bit flaky
[07:07] <mvo> mborzecki: yeah, I noticed yesterday I'm a bit puzzled about the why, the debug output shows the commands.db is populated :/
[07:08] <mborzecki> mvo: yup, but iirc you've added a wait loop in the test right?
[07:08] <mvo> mborzecki: yes
[07:08] <mborzecki> ah right, but the file is there
[07:08] <mborzecki> hm
[07:09] <mborzecki> mvo: maybe we could dump the db in the test debug section?
[07:09] <mborzecki> or it's stale from one of the previous tests
[07:09] <mvo> mborzecki: dump|grep is a good idea
[07:15] <mborzecki> mvo: snap debug commands would be useful
[07:16] <mborzecki> mvo: strings /var/cache/snapd/commands.db is a bit hard to read
[07:17] <mvo> mborzecki: yeah, I think we need a debug dump command or similar
[07:26] <mborzecki> mvo: hm i think i can make it work with strings & some sed magic
[07:28] <mborzecki> mvo: super low tech https://paste.fedoraproject.org/paste/KeXaitkPbRn59wnVakr5ng/raw
[07:28] <CyberManifest> mborzecki: systemd is covered by http://mesonbuild.com/Users.html don't know the rest though.
[07:40] <mvo> mborzecki: heh, nice! I think thats good enough for now
[07:55] <mborzecki> mvo: https://github.com/snapcore/snapd/pull/5582
[07:58] <mvo> mborzecki: nice! and magic :)
[08:10] <mborzecki> mvo: left a comment in https://github.com/snapcore/snapd/pull/5557
[08:11] <mborzecki> mvo: otherwise it's looking good
[08:19] <mborzecki> brb, need to do a quick run by the bike shop to get a new tube
[09:04] <mborzecki> re
[09:04] <Chipaca> mvo: mborzecki's commands.db pr died with an error you might know about or be interested in
[09:05] <Chipaca> - Mount snap "test-snapd-control-consumer" (2) ([start snap-test\x2dsnapd\x2dcontrol\x2dconsumer-2.mount] failed with exit status 1: Job for snap-test\x2dsnapd\x2dcontrol\x2dconsumer-2.mount failed.
[09:05] <Chipaca> in google:ubuntu-core-18-64:tests/main/install-remove-multi
[09:06] <mborzecki> damn
[09:12] <Chipaca> mborzecki: i've got the logs, if you want to just restart your run
[09:22] <mborzecki> btw. i don't recall the mount thing failing on ubuntu
[09:22] <mborzecki> it was always fedora & arch
[09:23] <mvo> Chipaca: hrm, hrm, the protocol error again?
[09:24] <Chipaca> mvo: http://r.chipaca.com/log.txt
[09:25] <Chipaca> mvo: I don't see protocol error in there, but i don't recall the exact error message it would throw
[09:26] <Chipaca> mvo: changing subjects, 16.04 having 2.34.2 and stable being 2.33 is weird :-)
[09:32] <mvo> Chipaca: no kidding
[09:32] <mvo> Chipaca: but yeah, will be fixed soon :)
[09:32] <mvo> Chipaca: the one and only time that the deb is ahead because we had issues on core devices with the refresh (pi2)
[09:32] <mvo> Chipaca: we will release 2.34.3 on Monday
[09:33] <Chipaca> mvo: I'm mostly surprised the sru got there that fast
[09:35] <mvo> Chipaca: yeah, we did all we could this time to get it ready in time for 18.04.1
[09:35] <mvo> Chipaca: and all is fine on "normal" devices
[09:35] <Chipaca> mvo: to be fair I only noticed because my /usr/bin/snap was broken (because I broke it) so it was suddenly crashing
[09:41] <mvo> Chipaca: Jul 31 08:09:10 jul310756-078436 snapd[6023]: Jul 31 08:09:09 jul310756-078436 systemd[1]: snap-test\x2dsnapd\x2dcontrol\x2dconsumer-2.mount: Failed with result 'protocol'.
[09:41] <Chipaca> mvo: ah
[09:41] <mvo> Chipaca: so yeah, this is the error we are hunting since some time
[09:41] <mvo> Chipaca: maybe a systemd bug but so far elusive
[09:47] <abeato> mvo, hey, tests/main/apt-hooks is failing for https://github.com/snapcore/snapd/pull/5572 all the time, is that expected? it does not seem to be related to the PR
[09:47] <Chipaca> abeato: not related
[09:48] <Chipaca> abeato: also, often but not all the time. Sorry... we're looking into it
[09:48] <abeato> nw, good to know
[09:48] <Chipaca> abeato: i'll punch 'retry' for you
[09:48] <abeato> Chipaca, thanks
[09:50] <Chipaca> abeato: actually, if it's happening often for that pr, could you merge master?
[09:50] <Chipaca> abeato: mborzecki added some debug to that test
[09:50] <abeato> Chipaca, I rebased like one hour ago, so mborzecki could take a look at the log
[09:51] <Chipaca> abeato: the debug pr landed seconds ago
[09:51] <abeato> ok
[09:51] <Chipaca> abeato: (i merged it between punching restart, and asking you to merge master)
[09:52] <abeato> Chipaca, I've rebased my branc now
[09:52] <Chipaca> k
[09:52] <Chipaca> now of course it'll just work :-p
[09:53] <abeato> I would prefer that :p
 Chipaca: 5583 is a bit of an rfc, let me know about any obvious holes in the approach
 mborzecki: ^- you are welcome as well of course
[10:13] <mvo> got disconnected, not sure I the above made it to the channel
[10:20] <Chipaca> mvo: it hadn't
[10:20] <Chipaca> mvo: thanks
[10:54] <mvo> Chipaca: thanks for the review! at least no obvious holes in the approach that is good. I'm sure this will have some more iterations once gustavo and samuele get a chnace to look at it :)
[10:54] <Chipaca> mvo: a'yup
[10:54]  * mvo hugs Chipaca 
[10:58] <mborzecki> anyone feeling like looking at some c code? https://github.com/snapcore/snapd/pull/5584
[11:02] <mborzecki> second review for the timers fix? https://github.com/snapcore/snapd/pull/5573
[11:04] <mvo> mborzecki: careful, when I review C code I usually get grumpy ;)
[11:04] <mborzecki> mvo: heh, i get so when writing c code
[11:06] <mborzecki> mvo: i'm thinking about that socket activation code, i'm afraid that the idea behind it may be that snapd must not be started at all
[11:07] <mvo> mborzecki: how do you mean? you mean in an ideal world it would not start at all?
[11:07] <mborzecki> mvo: meaning, it probably goes down to the fact that once started there will be pages allocated on the host anyway, even if you stop it later the ripple effect is on
[11:08] <mborzecki> mvo: at least that's the line of thinking i'd have should i be running a dense vm/container environment
[11:08] <mvo> mborzecki: I don't disagree! however this was discussed a good while ago (not starting at all) and there was pushback from Gustavo for various reasons. so for now the consensus was to start and stop if we can
[11:10] <mborzecki> mvo: well, i agree that you have proposed is a saner solution :P i recall the hack we had before 2.3x release and that was ugly
[11:12] <mvo> mborzecki: I had a PR once that tried to do it all with systemd conditionals but I can't find it right now
[11:13] <mvo> anyway, lunch first
[11:13] <mborzecki> mvo: enjoy
[11:14] <mvo> mborzecki: thank you! and thanks for the review(s)
[11:15] <Chipaca> mvo: mborzecki: what we _could_ do is have snapd touch files that we can then use from conditionals
[11:16] <mborzecki> Chipaca: then gate on ConditionPathExists or like?
[11:17] <Chipaca> mborzecki: say we touch /var/lib/snapd/up-to-date once everything is fine
[11:17] <Chipaca> mborzecki: and we remove that file if it's more than N days old
[11:18] <Chipaca> mborzecki: the problem is the catalog will be stale unless we have a way of triggering snapd to run periodically
[11:19] <mborzecki> Chipaca: hm we have timers now :)
[11:19] <Chipaca> mborzecki: in systemd we've had timers for yonks
[11:19] <Chipaca> there even was a snapd.timer
[11:19] <Chipaca> or was it snapd-service.timer
[11:19] <Chipaca> something like that
[11:19] <mborzecki> repair?
[11:20] <Chipaca> mborzecki: repair only runs in core
[11:24] <Chipaca> in any case, we'll see
[11:24] <Chipaca> maybe if the problem is VMs and clouds we add the dumb conditionals just to there
[11:28] <mborzecki> meanwhile, i've added a temporary label for parallel installs PRs
[12:38] <jdstrand> mvo: would you mind taking a look at https://github.com/snapcore/snapd/pull/5579
[12:40] <jdstrand> mvo: hi btw :)
[12:41] <mvo> jdstrand: in a meeting right now, will do so soon
[12:41] <mvo> jdstrand: and *thnk you*
[12:57] <Chipaca> mborzecki: https://api.travis-ci.org/v3/job/410245666/log.txt
[12:57] <mborzecki> jdstrand: hi, i've requested your review on some of my prs, they should appear in your dashboard
[13:15] <mborzecki> shellchecks part 5 https://github.com/snapcore/snapd/pull/5585 - 'the song of quoting and escaping'
[13:35] <jdstrand> mborzecki: ack
[13:44] <mvo> jdstrand: now I'm back, looking at your PR now
[13:52] <mvo> jdstrand: thanks for the PR - I look forward killing ptrace trace :)
[13:53] <jdstrand> mvo: yes, me too :)
[13:54] <mvo> mborzecki: I cherry picked the arch fix for 2.34 - thanks for this one
[13:54] <mborzecki> mvo: thanks for picking it up for 2.34!
[13:55] <thresh> I wonder why I no longer have a _NET_WM_ICON xprop on a snapped firefox
[13:57] <thresh> =/ snap refresh to a previous revision and back to stable fixed it
[14:23]  * Chipaca takes a break
[14:52] <mvo> mborzecki: I added some comments to your C code PR - just like I said, I got a bit grumpy, sorry for this. hope its still useful.
[14:53] <mborzecki> mvo: sure, thanks for the review and the diff
[14:54] <mvo> mborzecki: I should add, your stuff is fine (the indent is a bit off though) and I think the extra tests would be nice. but the other bits are fine
[14:54] <mvo> mborzecki: this was just my take on this
[14:54] <kyrofa> cachio, picking up where we left off yesterday (autopkgtests), I know I need to generate the system locally, but not when actually running in autopkgtests, right?
[14:54] <mborzecki> mvo: yeah, the indent thing i did not notice even, showed fine in git diff & emacs
[14:55] <cachio> kyrofa, right
[14:55] <kyrofa> That was phrased badly. I mean when running the real deal, the system is generated for us, right?
[14:55] <mvo> mborzecki: iirc we use indent (or was it clang-format?) on the code
[14:55] <cachio> kyrofa, yes
[14:55] <cachio> kyrofa, you generate it when you run it locally
[14:55] <mborzecki> mvo: right, afaik it didn't cover snap-update-ns, probably need to run it manually
[14:56] <mvo> mborzecki: aha, I think you are right. slightly sad
[14:56] <kyrofa> cachio, can you explain why, since all the systems do the same thing, we have so many of them? Why not just call it "my-autopkgtest-system" and use it for everything? I feel like there's something I'm missing
[14:56] <mvo> mborzecki: I just ran indent and the diff was huge so probably best to fix maually and call it a day ;)
[14:57] <mborzecki> mvo: heh, run it now and it basically redid the whole file :(
[14:57] <mvo> mborzecki: yep
[14:57] <cachio> kyrofa, because then we use the system in the tests
[14:57] <kyrofa> Ah, the SPREAD_SYSTEM var or whatever?
[14:57] <cachio> if the system name is ubuntu-14 we do something
[14:57] <cachio> if the system is arch-linux we do something different
[14:58] <cachio> if it is ubuntu-18 the same
[14:58] <kyrofa> That was the only situation I could think of, sounds like we're on the same page. Perfect, thanks cachio, I'm going to proceed to, uh, borrow, all of this
[14:58] <cachio> kyrofa, also we filter tests by systems
[14:59] <cachio> in a task you can define which system you want to run and which to skip
[15:00] <cachio> kyrofa, something like https://github.com/snapcore/snapd/blob/master/tests/main/ubuntu-core-create-user/task.yaml#L2
[15:01] <cachio> this test will be just executed on ubuntu-core-16
[15:01] <mborzecki> mvo: looks like the whole bootstrap.c is using space indentation
[15:02] <kyrofa> cachio, ah, right, I do that too in retrospect
[15:08] <Chipaca> mvo: mborzecki: I _think_ https://github.com/snapcore/snapd/pull/5586 should fix the apt-hooks test breakage
[15:15] <mborzecki> mvo: my guess about not using islower() and friends is that s-c code is almost the same, same function names, code copied and so on
[15:15] <mborzecki> mvo: probably makes it easier to keep the code in sync
[15:30] <mvo> mborzecki: *shrug* no strong opinion but generally I'm not a fan of cargo culting. but then I usually avoid the C review to avoid getting grumpy :)
[15:31] <mvo> Chipaca: oh, nice. looking at your fix
[15:35] <mvo> mborzecki: 5586 is probably an easy win, if you have a moment for this one
[15:43] <cachio> mborzecki, I already pushed the PR to setup the storage at system level
[15:44] <cachio> we will need to wait few weeks for it
[15:53] <mvo> jdstrand: do you think you could review 5340 ? it got a +1 from zyga already but not from you yet
[15:53] <mborzecki> cachio: thank you
[15:54] <jdstrand> mvo: it is on my list, yes
[15:55] <mvo> jdstrand: thank you, I was asked about the status I will relay that then
[15:59] <mborzecki> Chipaca: left some comments in 5586, count that as +1 if i'm pushing too much :)
[16:01] <Chipaca> mborzecki: as i answered there: i can't create a boltdb from a file
[16:01] <Chipaca> so, no
[16:01] <Chipaca> unless we want to actualy fork it
[16:01] <Chipaca> (which AIUI we don't)
[16:02] <mborzecki> Chipaca: very well then
[16:03] <Chipaca> mborzecki: i looked into passing in a file (or a writecloser, or even just a writer), but the only thing that i could do is create the db and then use tx.WriteTo
[16:03] <Chipaca> which seems like a lot of copying around
[16:03] <mborzecki> meh
[16:03] <Chipaca> soz
[16:59] <Chipaca> brb, compiz hates me
[17:21] <om26er> (sorry if this is coming as a repeat message, freenode had an issue and I believe my message were no going through)
[17:21] <om26er> How can we create an Ubuntu Core image for the RPi with one additional snap installed.
[17:21] <om26er> ogra: ^
[17:22] <om26er> in this case, we are using RPi3 and want our privately built snap preinstalled on it.
[17:22] <ogra> by creating a model assertion that has "required-snaps:" populated
[17:22] <ogra> ah, if you dont want to cycle it through the store (or cant) use the --extra-snaps option to ubuntu-image
[17:23] <om26er> we'll probably publish the snap to the store as well, so need to play with mode assertion probably.
[20:03] <Chipaca> abeato: I merged master, with fixes for apt-hooks concurrency from #5586, into #5572 and it's now green. Any reason not to merge it?
[20:05] <Chipaca> abeato: if there is, comment in the PR (you can use the 'blocked' label also)
[20:05] <Chipaca> abeato: otherwise i'll merge it in the mron
[20:05] <Chipaca> morn
[20:05] <Chipaca> g'night
[22:36] <FreeBDSM> how to cut some files from a .snap?
[22:44] <FreeBDSM> can a snap be mounted as an rw mount?
[23:12] <mcphail> FreeBDSM: as far as I know, a snap is just a squashfs file. I think you can unsquash it, adjust it then mount the unsquashed snap with "snap try"
[23:12] <FreeBDSM> why does a firefox snap include usr/share with lots of non-related stuff, like pkgconfig, bash-completion, avahi, alsa, X11, themes, upstart etc?
[23:13] <FreeBDSM> actually, nevermind, fat package is a fat package, I just need it to work