| smoser | rharper or blackboxsw https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/352027 would be nice. should seem non-contentios | 15:07 |
|---|---|---|
| rharper | smoser: did you already confirm that the tab-completion still works for devel now that we have more than one element there ? | 15:09 |
| rharper | smoser: wanted to make sure the bash-compeletion didn't need updating (it shouldn't it should dump the devel schema, which I think you updated already in that branch) | 15:09 |
| smoser | rharper: i did not update bash completion. or look at it at all. | 15:10 |
| rharper | smoser: I don't think we need to, but just wanted to check it out. | 15:10 |
| smoser | powersj: https://jenkins.ubuntu.com/server/job/cloud-init-ci/189/console | 20:30 |
| smoser | that ran, but did not post to https://code.launchpad.net/~sw37th/cloud-init/+git/cloud-init/+merge/350428 | 20:30 |
| powersj | line 4: MERGE_REVISION: unbound variable | 20:31 |
| powersj | when you launched it you did not provide a candidate_revision | 20:31 |
| powersj | https://jenkins.ubuntu.com/server/job/cloud-init-ci/189/parameters/ | 20:31 |
| smoser | where do you see that ? | 20:34 |
| smoser | and fwi, you didn't use to have to provide candidate_revision. it assumed HEAD | 20:34 |
| powersj | smoser, I don't recall the job ever not requiring that | 20:39 |
| powersj | it is how it keeps track of what revision is has tested | 20:39 |
| powersj | I found the unbound variable in the job it kicked off next, the vote job | 20:40 |
| smoser | it just defaults to HEAD | 20:54 |
| smoser | i'm sure of it. | 20:54 |
| smoser | nd why *not* default to head. | 20:56 |
| powersj | tests take time, and if a user quickly pushes another fix it could vote on the wrong version | 21:01 |
| smoser | well no. it would test *a* version and it would log that and report that it tested that veresion. | 21:02 |
| smoser | i'm almost certain that this is why we have this message in there | 21:04 |
| smoser | Checking out Revision 3f8f3249643056c751efe11ce27edfe56d9cec3d (refs/remotes/origin/opennebula_fix_null_gateway6) | 21:04 |
| blackboxsw | approved https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/352010 | 22:12 |
| blackboxsw | lander should get that | 22:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!