| veebers | wallyworld: fyi https://github.com/juju/charmstore-client/pull/175 | 02:58 |
|---|---|---|
| wallyworld | veebers: not sure about the extra dep introduced | 03:00 |
| veebers | wallyworld: as per pr comment, it's a transient dep from charmstore | 03:01 |
| wallyworld | ok | 03:01 |
| wallyworld | normally if not needed to build we can ignore, eg if it's just a charmstore tets dep | 03:02 |
| veebers | ack, it was needed the build failed withou it | 03:04 |
| thumper | https://github.com/juju/worker/pull/5 | 04:14 |
| thumper | anyone... | 04:14 |
| * anastasiamac lloking excitedly \o/ | 04:17 | |
| * anastasiamac stopped looking :( | 04:18 | |
| thumper | why? | 04:19 |
| anastasiamac | thumper: well, i liked the code but without the tests and sample output m scared to +1 :) commented on PR | 04:22 |
| jam | thumper: testing that I'm connected | 04:37 |
| thumper | jam: you are | 04:38 |
| babbageclunk | thumper: not that I'm looking because I should be looking at wallyworld's humongodiff, but it seems weird/upside-down to be implementing a juju/juju interface (worker/dependency.Reporter) in juju/worker? What about exposing some way to iterate over the workers instead? | 05:01 |
| thumper | It doesn't import it, it just mentions it | 05:02 |
| babbageclunk | sure, but still | 05:02 |
| thumper | and I'm planning to move all that code into the worker package | 05:02 |
| thumper | catacomb, dependency and some common workers | 05:02 |
| babbageclunk | ok, if dependency.Report lives there then I'm happy. | 05:03 |
| babbageclunk | *er | 05:03 |
| thumper | it will... | 05:03 |
| thumper | I'm looking at removing the tomb.v1 dep in worker package | 05:03 |
| kelvinliu | thumper, thanks for reviewing the PR, good point for the win os issue, just updated the PR, would you mind take a look again? | 05:03 |
| thumper | it is used in the tests | 05:03 |
| thumper | kelvinliu: ok | 05:03 |
| thumper | is there a doc somewhere about what needs to change for tomb.v1 -> tomb.v2? | 05:03 |
| thumper | veebers: do you remember the tomb changes? | 05:13 |
| === lathiat_ is now known as lathiat | ||
| veebers | thumper: there is no doc I don't think. I recall the changes | 05:46 |
| thumper | I've worked it out I think | 05:47 |
| thumper | but thanks :) | 05:47 |
| veebers | thumper: sorry was on a BS errand :-\ | 05:47 |
| thumper | all good | 05:47 |
| thumper | anastasiamac, babbageclunk test added | 06:09 |
| * thumper is done for today | 06:12 | |
| icey | I've noticed a problem with containers on 4.2.1 represented on: https://pastebin.ubuntu.com/p/bHmBydJ4Hx/ ; basically, "Container 'juju-5099ed-1-lxd-1' already exists" | 06:14 |
| icey | ah, looks like it's fix-committed: https://bugs.launchpad.net/juju/2.4/+bug/1779897 | 06:18 |
| icey | unfortunately, in the edge snap, I can't launch a container with: `0/lxd/0 down pending bionic missing Cancel not valid` | 06:47 |
| magicaltrout | if anyone has any good ideas | 07:46 |
| magicaltrout | er irc fail | 07:46 |
| stickupkid | does anybody know how this has made it's way through go vet (and the CI)? | 08:38 |
| stickupkid | caas/kubernetes/provider/k8s.go:1495: NotValidf format %d has arg v of wrong type k8s.io/apimachinery/pkg/api/resource.Quantity | 08:38 |
| veebers | stickupkid: if it's the same error babbageclunk saw, I think the cleared out his pkg/ dir and it wasn't triggered again (although I think it is an actually error?) | 08:40 |
| stickupkid | veebers: k, i'll try that | 08:40 |
| stickupkid | veebers: the %d is totally wrong though, it should be %v | 08:41 |
| stickupkid | veebers: that worked, for some reason `make clean` didn't fix it | 08:42 |
| veebers | stickupkid: odd. I wonder why having stuff in pkg/ triggers it but not a clean run (even though it's a legit error) | 08:52 |
| stickupkid | veebers: yeah, i don't really know | 09:21 |
| stickupkid | thought I'd ease back in and fix it, the error message doesn't make sense anyway https://github.com/juju/juju/pull/9022 | 09:45 |
| stickupkid | manadart: got a second? | 09:50 |
| manadart | stickupkid: Yep. | 09:51 |
| stickupkid | HO? | 09:51 |
| rick_h_ | stickupkid: after you settle your email and such let me know so we can sync up please | 11:27 |
| stickupkid | rick_h: now? | 11:28 |
| rick_h_ | stickupkid: sure | 11:31 |
| rick_h_ | stickupkid: meet you in the standup HO | 11:31 |
| manadart | stickupkid: Gave you a bit of a bum steer earlier. I was thinking host rather than series. | 13:33 |
| manadart | You just need to change this: https://github.com/juju/juju/blob/832d4e53b51fa10a902a2376b03f776bd2b813af/juju/version/version.go#L11 | 13:35 |
| manadart | ^ ... thinking *arch* rather than series. | 13:35 |
| stickupkid | manadart: if I change that, i wonder what would break :S | 13:44 |
| rick_h_ | stickupkid: bwuahahaha, everything! :P | 13:49 |
| stickupkid | rick_h_: exactly, I think I'll get anastasiamac to review that, feels dangerous | 13:50 |
| rick_h_ | stickupkid: :) | 13:50 |
| stickupkid | i'll do some testing locally, see what's the damage | 13:51 |
| rick_h_ | stickupkid: make sure to give it a few tries from a couple of different series/etc. Also check local lxd vs a cloud for instance | 13:51 |
| rick_h_ | stickupkid: +1 | 13:51 |
| === petevg_ is now known as petevg | ||
| manadart | externalreality: Got a sec for a HO? | 14:59 |
| rick_h_ | hml: ok, second try at working that up. At least raises the idea of an optional-hint as close to the start of the line as I can get it | 18:21 |
| hml | rick_h_: sorry, i’m not following, lost context | 18:23 |
| rick_h_ | hml: the wording for the CA cert question in add-cloud | 18:23 |
| hml | rick_h_: ah, ty! | 18:23 |
| rick_h_ | hml: and looks like jsonschema supports file: paths via uri, but relative paths can be tricky | 18:24 |
| hml | ack | 18:24 |
| rick_h_ | hml: but tracking google cloud credential use is probably best bet there anyway | 18:24 |
| hml | rick_h_: unforunately add-credential works very differently than add-cloud | 18:31 |
| hml | rick_h_: much easier to validate when you read in the entire thing, rather than query the user for each piece | 18:32 |
| hml | :-/ | 18:32 |
| rick_h_ | hml: ? I don't follow | 18:33 |
| hml | rick_h_: add-cred doesn’t use pollster, which is causing the “fun” with add-cloud | 18:34 |
| rick_h_ | hml: ah crap | 18:34 |
| hml | rick_h_:there might be a piece i can use, checking it out | 18:37 |
| knobby | does anyone know of an example bundle that uses storage? I'm trying to make a ceph bundle that uses storage to allocate ebs from aws. I have a deploy line that works, but I want to put this into a bundle.yaml | 19:50 |
| veebers | Morning all o/ | 20:15 |
| hml | morning veebers | 20:16 |
| anastasiamac | veebers: hml: o/ | 20:16 |
| hml | anastasiamac: o/ | 20:17 |
| veebers | Hows things hml, anastasiamac o/ | 20:18 |
| anastasiamac | stickupkid: saw ur PR (9023) will take a look today... i would have wanted to also change some test that ensure that we r bootstapping on latest lts (which is now bionic and was xenial before) | 20:18 |
| hml | veebers: not bad, you | 20:18 |
| veebers | can't complain too much :-) A bit cold this morning, but that's what the fire is for | 20:19 |
| anastasiamac | hml: saw u had some mad weather... r u k? | 20:19 |
| anastasiamac | veebers: u have live fire? (m so jealous!) | 20:19 |
| hml | anastasiamac: yeah. just went by, didn’t cause damage at my house luckily | 20:19 |
| anastasiamac | hml: oh good :D did u cats sensed it was coming? | 20:20 |
| anastasiamac | ur* | 20:20 |
| hml | anastasiamac: i don’t think so, my girls don’t to be bothered by storms. though some friends have a dog who is very frightened by them. the dog even managed to get behind the washing machine one time, no idea how she managed that | 20:21 |
| anastasiamac | hml: :) | 20:22 |
| veebers | anastasiamac: well, it's contained in a fireplace but yes :-) | 20:26 |
| anastasiamac | veebers: niiice | 20:26 |
| veebers | hml: oh wow, glad you're all ok and the house is fine! | 20:37 |
| hml | veebers: all good. | 20:38 |
| thumper | babbageclunk, anastasiamac: updated... https://github.com/juju/worker/pull/5/files | 21:19 |
| babbageclunk | thumper: sorry, just reviewing something else, I'll look at this nect | 21:37 |
| babbageclunk | xt | 21:37 |
| anastasiamac | thumper: looking too | 23:03 |
| anastasiamac | thumper: and un-looking since babbageclunk won that race | 23:09 |
| babbageclunk | (: | 23:09 |
| anastasiamac | babbageclunk doesn't like winning races?.. | 23:10 |
| * anastasiamac likes when babbageclunk wins review races :) | 23:10 | |
| babbageclunk | (: | 23:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!