| === rezroo1 is now known as rezroo | ||
| blackboxsw | smoser: comments are posted on https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/352660. Do you think I should drop the extra check on /var/lib/waagent/ovf-env.xml even though that is where waagent stores the copied file? | 15:43 |
|---|---|---|
| smoser | blackboxsw: i dont know if ip ushed 'save' on my comments... | 16:19 |
| smoser | but there, the presense of that directory should not indicate anything to cloud-init. | 16:20 |
| smoser | it just inidcates that walinux-agent has run at some point | 16:20 |
| blackboxsw | and if /var/lib/cloud/seed/azure/ovf-env.xml exists we are saying this is an azure environment and that's okay right? | 16:22 |
| blackboxsw | because that check is also not currently passed on azure instances I'm able to boot (because we get our data originally from /dev/sr0 right | 16:23 |
| smoser | blackboxsw: i dont care so much about the seed dir. | 16:24 |
| blackboxsw | ok I'll drop both | 16:24 |
| smoser | seed dirs (other than NoCloud) are really just test paths | 16:24 |
| blackboxsw | right | 16:24 |
| smoser | blackboxsw: i think dropping the seed dir support is acceptable | 16:25 |
| smoser | but i think it is not related to your changes | 16:25 |
| smoser | so i'd leave that path un-modified in yours and you can do a separate merge proposal for dropping it entiresly. | 16:26 |
| blackboxsw | smoser: sorry, | 16:29 |
| blackboxsw | smoser: sorry, I added a seed_dir detection to DataSourceAzure._is_platform_viable. | 16:29 |
| blackboxsw | I was going to drop my additions there | 16:29 |
| blackboxsw | and leave ds-identify alone | 16:30 |
| blackboxsw | sound good? | 16:30 |
| smoser | you should not change behavior | 16:34 |
| smoser | is_platform_viable should return True if /var/lib/cloud/seed/zaure/ovf-env.xml exists. | 16:34 |
| smoser | but should not care at all about /var/lib/waagent/ovf-env.xml | 16:34 |
| smoser | sorry if i was confusing above. | 16:34 |
| blackboxsw | ok sounds good. I'll align w/ ds-identify smoser | 17:48 |
| blackboxsw | wow IRC timeout | 17:48 |
| blackboxsw | ok pushed | 17:56 |
| * blackboxsw is working on jinja for #cloud-config unit tests | 17:56 | |
| shaner | Hi all, any chance at getting some reviews on https://code.launchpad.net/~shaner/cloud-init/+git/cloud-init/+merge/352572 | 19:00 |
| blackboxsw | sure shaner, will drop in some comments today | 19:01 |
| shaner | thanks blackboxsw | 19:01 |
| smoser | blackboxsw, rharper ubuntu@129.146.136.219 | 21:16 |
| smoser | if you want to see a oracle instance | 21:16 |
| smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/352921 | 21:16 |
| smoser | and review ^ | 21:16 |
| rharper | smoser: k | 21:16 |
| blackboxsw | Thx | 21:16 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!