=== cpaelzer_ is now known as cpaelzer | ||
didrocks | good morning | 06:37 |
---|---|---|
duflu | Hi didrocks | 06:38 |
duflu | #firstpost as usual | 06:38 |
didrocks | hey duflu ;) | 06:41 |
jibel | Good morning folks | 07:04 |
duflu | Morning jibel | 07:06 |
=== pstolowski|afk is now known as pstolowski | ||
jibel | hi duflu | 07:09 |
didrocks | salut jibel | 07:17 |
jibel | Salut didrocks, ça va? | 07:18 |
didrocks | ça va, et toi ? | 07:19 |
jibel | didrocks, bien, matinée un peu difficile, on a feér mon anniversaire hier :) | 07:20 |
jibel | feté* | 07:20 |
didrocks | oh, bon anniv en retard alors :p | 07:24 |
clobrano | good morning all :) | 07:28 |
didrocks | hey clobrano! | 07:28 |
clobrano | hey didrocks , how's it going? | 07:28 |
didrocks | clobrano: I'm good, thanks! yourself? | 07:29 |
clobrano | nice! I've been better, but it's ok :D | 07:29 |
didrocks | oh? being busy or sick? | 07:30 |
clobrano | the latter :D | 07:31 |
didrocks | argh, get better! | 07:32 |
clobrano | it's been about two months of sciatica pain | 07:32 |
clobrano | thanks! | 07:32 |
clobrano | not ideal for sitting all day at a computer :) | 07:33 |
didrocks | yeah, I hope that some physiotherapist can help you | 07:35 |
clobrano | I tried everything, while waiting for my turn for surgery, hopefully it'll be soon | 07:37 |
clobrano | it's a very long list apparently :( | 07:37 |
didrocks | I can guess… :/ | 07:38 |
didrocks | at least, there are some surgery possiblities? | 07:38 |
clobrano | yes, at the end it is due to an herniated disc that can be removed | 07:41 |
didrocks | that's already a relief :) | 07:42 |
clobrano | :) | 07:47 |
willcooke | morning all | 07:50 |
didrocks | hey willcooke | 07:54 |
willcooke | Où est le garçon d'anniversaire? | 07:57 |
didrocks | il est dans le train à ce que j'ai compris | 07:58 |
willcooke | ah | 07:58 |
willcooke | 794635 | 07:58 |
willcooke | oops | 07:58 |
duflu | Login confirmed | 07:59 |
willcooke | :) | 07:59 |
duflu | Morning willcooke | 08:00 |
willcooke | afternoon duflu! | 08:00 |
Laney | hey hey | 08:01 |
willcooke | morning Laney | 08:04 |
didrocks | hey Laney | 08:06 |
didrocks | clobrano: the dark and light variants are using the same GTK3 assets, correct? | 08:06 |
clobrano | correct | 08:06 |
didrocks | ok, I'll try to use a symlink then on the installed target | 08:07 |
Laney | hey willcooke didrocks clobrano | 08:10 |
clobrano | ciao Laney, willcooke ! | 08:10 |
willcooke | hi clobrano! | 08:11 |
seb128 | good morning desktopers, from a spotty 3g :) | 08:46 |
didrocks | re seb128 | 08:51 |
seb128 | lut didrocks :) | 08:51 |
didrocks | man, meson is making it hard to generate same file name multiple times, but installing it in different dirs… | 08:51 |
didrocks | you have to create directories yourself just for the build system… | 08:51 |
Laney | yep | 09:14 |
Laney | hey seb128 | 09:14 |
Laney | it's because meson always outputs to the build directory | 09:15 |
Laney | there were bugs before where it would silently overwrite your files with the later ones | 09:19 |
Laney | hopefully it at least warns now /o\ | 09:19 |
oSoMoN | seb128, will_cooke recently added a card to the proposed column to specifically target 19.04 (tamil 99 keyboard layout), which is why I used that for the libreoffice/libreoffice-l10n merge, shall we create a "proposed for 19.04" column now? | 09:58 |
seb128 | oSoMoN, as said on the board I've been canonical-desktop-wontdo those so far | 09:58 |
seb128 | the board is difficult enough to follow without stacking next-cycle work in proposed imho | 09:59 |
willcooke | We can create a 19.04 board next week? | 09:59 |
seb128 | so yeah, that sounds like good to me (or we keep wontdoing those and review that column when we start the next board, which works as well) | 09:59 |
seb128 | or that | 09:59 |
seb128 | either way wfm, I just don't want the backlog to be un-usable | 09:59 |
oSoMoN | any of these solutions wfm, let's just make sure we don't loose proposed work items on the way | 10:00 |
seb128 | right | 10:00 |
popey | kenvandine: dunno if it was you that triggered it, but gnome-characters failed to upload to the store - store auth failed. | 10:18 |
popey | https://launchpad.net/~ubuntu-desktop/+snap/gnome-characters/+build/330549 | 10:18 |
popey | "Store upload failed: The request is missing an Authorization header field containing a valid macaroon " | 10:18 |
popey | (also other snaps from that lp group such as gnome-logs) | 10:19 |
=== pstolowski is now known as pstolowski|lunch | ||
clobrano | didrocks: is the UI freeze affected by Travis CI not able to build lastest master (I believe it's not, but...)? | 12:09 |
didrocks | clobrano: no, it's not | 12:12 |
didrocks | clobrano: as Travis CI is anyway only about the snap building | 12:12 |
didrocks | this snapcraft upload to the store issue is annoying btw :/ | 12:13 |
didrocks | clobrano: I'll soon have the dark theme building in // of light one soon for you to review ;) | 12:13 |
clobrano | great! | 12:29 |
clobrano | didrocks: how gtk2.0 works for the dark variant? Is there a new folder with dark assets? | 12:30 |
didrocks | clobrano: I can scaffold the gtk2.0 directory if you wish, I only did gtk3 for now, but yeah, it's a new folder | 12:32 |
didrocks | clobrano: do you want me to add it with the dark assets to bootstrap you? | 12:32 |
clobrano | didrocks: gtk3 is fine, I can use that as example | 12:33 |
didrocks | clobrano: let me PR now then | 12:33 |
clobrano | great, thanks | 12:34 |
didrocks | and add instructions for gtk2 ;) | 12:34 |
clobrano | \0/ | 12:34 |
didrocks | clobrano: https://github.com/ubuntu/yaru/pull/816, that should be it, let me know what you think and if the instructions for gtk2 are clear enough ;) | 12:41 |
gitbot | ubuntu issue (Pull request) 816 in yaru "Support dark variant" [Open] | 12:41 |
=== pstolowski|lunch is now known as pstolowski | ||
clobrano | didrocks: checking it | 12:46 |
clobrano | didrocks: it seems pretty clear | 12:50 |
clobrano | merging it | 12:50 |
didrocks | clobrano: perfect, merged! Thx ;) | 12:51 |
didrocks | clobrano: I notice some other cleanup I can do in the build system, I might have a look today/tomorrow | 12:51 |
kenvandine | popey, i'll look at it | 12:51 |
clobrano | didrocks: ack! | 12:51 |
=== Class7_ is now known as Class7 | ||
clobrano | didrocks: made a fast combo with the new build and gtk2-dark. The build is perfect (y) gtk2-dark a bit less :D | 13:20 |
didrocks | clobrano: do you think it's shippable, like vlc works well with it, and not really? | 13:25 |
didrocks | clobrano: if you want to have a quick look, that was a leftover (dark apps on light theme): https://github.com/ubuntu/yaru/pull/817 | 13:28 |
gitbot | ubuntu issue (Pull request) 817 in yaru "Readd support for GTK3 apps choosing dark theme in a light environment" [Open] | 13:28 |
oSoMoN | didrocks, https://github.com/ubuntu/yaru/pull/818 for your reviewing pleasure, I think that should do the trick but let's see how the next CI run on this PR behaves | 13:46 |
gitbot | ubuntu issue (Pull request) 818 in yaru "Include Yaru in the custom gtk-common-themes snap built by CI jobs." [Open] | 13:46 |
clobrano | didrocks: I think there's some important work to do | 13:48 |
clobrano | it's not shippable | 13:48 |
didrocks | clobrano: ok then! | 13:50 |
didrocks | oSoMoN: looks good, I think however that you should do more cleanup | 13:51 |
didrocks | when building yaru | 13:51 |
didrocks | (same on gtk-common-themes snapcraft.yaml btw) | 13:51 |
didrocks | oSoMoN: look at the override-build: https://github.com/ubuntu/yaru/blob/master/snap/snapcraft.yaml#L22 | 13:52 |
didrocks | I remove everything not needed in the snap, like session files | 13:52 |
didrocks | oSoMoN: I guess you only need to add line 37 & 39 | 13:53 |
oSoMoN | didrocks, ack, I had missed that part, I thought it was all about renaming | 13:53 |
didrocks | (well, with 38 & 40 ;) off by one) | 13:53 |
oSoMoN | didrocks, I'll add that | 13:53 |
didrocks | thanks! | 13:53 |
didrocks | mind doing that as well in gtk-common-themes? | 13:53 |
oSoMoN | sure | 13:53 |
didrocks | oSoMoN: TBH, line 40 is really fresh… like 1h ago ;) | 13:53 |
didrocks | (the dark variant I just added, but not supported) | 13:53 |
didrocks | but line 38 was there. It's not harmful to have it, just useless | 13:54 |
didrocks | (useless in the snap context) | 13:54 |
seb128_ | that's complex build hacking :) | 13:54 |
didrocks | engineering ;) | 13:55 |
didrocks | but at least, all documented and explained! | 13:55 |
seb128_ | yeah | 13:55 |
clobrano | didrocks: however, I'll keep gtk-dark.css as well | 13:57 |
oSoMoN | hackgineering | 13:57 |
oSoMoN | didrocks, updated, will do another PR for similar cleanup for gtk-common-themes | 13:57 |
seb128_ | k, another train change, bbiab | 13:58 |
oSoMoN | didrocks, in case you want to review that one as well: https://github.com/snapcrafters/gtk-common-themes/pull/12 | 14:00 |
gitbot | snapcrafters issue (Pull request) 12 in gtk-common-themes "Yaru part: remove unused build artefacts." [Open] | 14:00 |
didrocks | oSoMoN: thanks, doing both! | 14:07 |
didrocks | clobrano: keeping gtk-dark.css -> that's https://github.com/ubuntu/yaru/pull/817 (just merged) :) | 14:07 |
gitbot | ubuntu issue (Pull request) 817 in yaru "Readd support for GTK3 apps choosing dark theme in a light environment" [Open] | 14:07 |
didrocks | popey: you stole my merge!!! :p | 14:08 |
clobrano | didrocks, popey: yeah, I didn't know if was ok to merge it :D | 14:08 |
clobrano | oSoMoN's PR as well ^ | 14:09 |
clobrano | PR war | 14:09 |
didrocks | oSoMoN: small nitpick: https://github.com/ubuntu/yaru/pull/818#pullrequestreview-154667474 | 14:10 |
gitbot | ubuntu issue (Pull request) 818 in yaru "Include Yaru in the custom gtk-common-themes snap built by CI jobs." [Open] | 14:10 |
didrocks | but if you don't have time, happy to merge, we'll have anyway to remove the delention once we support the -dark variant | 14:10 |
oSoMoN | didrocks, that's ok, pushing the change now | 14:11 |
oSoMoN | didrocks, done | 14:12 |
didrocks | oSoMoN: and merged! Thanks :) | 14:17 |
oSoMoN | cheers | 14:17 |
didrocks | clobrano: and here are the build system simplifications: https://github.com/ubuntu/yaru/pull/819 | 14:40 |
gitbot | ubuntu issue (Pull request) 819 in yaru "Simplify build system by using meson configure project" [Open] | 14:40 |
* clobrano checking | 14:41 | |
didrocks | configure_file() isn't the best wording they found for templating in meson IMHO :p | 14:41 |
didrocks | (in term of finding how to do this) | 14:42 |
clobrano | yeah, I was unsure it was a meson thing at first :D | 14:42 |
didrocks | yeah, it is :p (was first introduced for config.h.in I think) | 14:43 |
didrocks | but couldn't find any doc easily first time, hence the python script at the time | 14:43 |
didrocks | at least, it's built-in, track files removal and supposively faster | 14:43 |
didrocks | I checked the generated file contents, they are the same | 14:43 |
LocutusOfBorg | jbicha, http://launchpadlibrarian.net/386564286/gir-to-d_0.15.0-2_0.16.0-1.diff.gz | 14:44 |
LocutusOfBorg | the diff looks not too scary | 14:44 |
didrocks | clobrano: thanks! ;) Merging | 14:44 |
clobrano | merged | 14:44 |
didrocks | ah, faster than I ;) | 14:44 |
didrocks | great! | 14:44 |
clobrano | eheh | 14:44 |
didrocks | clobrano: So, I want to do an upload to cosmic now, is that fine with you? | 14:44 |
clobrano | didrocks: sure | 14:44 |
clobrano | pity my employer doesn't let me use meson though :( | 14:45 |
didrocks | ok, remember that when UIF is in progress, it's only minor changes now, non visible ones ;) | 14:45 |
didrocks | what are you using? | 14:45 |
didrocks | I hope not autotools/cmake for you ;) | 14:45 |
clobrano | no, luckily just make | 14:45 |
clobrano | makefile with no autotools | 14:45 |
didrocks | ok, still unfun though :p | 14:45 |
clobrano | at all | 14:45 |
didrocks | so, if you are familar with make, I'll let you do the packaging changes in debian/rules | 14:46 |
didrocks | it's just a makefile :p | 14:46 |
clobrano | :O, not familiar with debian/rules though | 14:46 |
seb128 | k, that trip went well, back to my desk :) | 14:46 |
didrocks | seb128: \o/ | 14:46 |
didrocks | clobrano: heh, don't worry about it, even if nowdays, it's really easy with all the helpers | 14:47 |
clobrano | didrocks: I'll have a look then | 14:47 |
* didrocks is using "gbp dch --multimaint-merge" \o/ | 14:48 | |
jibel | andyrock, do you remember the details of the race that caused bug 1751252 ? | 14:53 |
ubot5 | bug 1751252 in cairo (Ubuntu Bionic) "[regression] ubiquity crashed in debconf.py:104 with ValueError: invalid literal for int() with base 10: ''" [High,In progress] https://launchpad.net/bugs/1751252 | 14:53 |
jibel | It could be the same one that causes bug 1771751 | 14:53 |
ubot5 | bug 1771751 in ubiquity (Ubuntu) "autopilot tests - default installation fails in plugininstall with "permission denied" messages" [Medium,Confirmed] https://launchpad.net/bugs/1771751 | 14:53 |
andyrock | jibel: it was not a race | 14:59 |
andyrock | jibel: ubiquity has a system to drop and restore permissions | 15:00 |
andyrock | jibel: that problem was that permissions were not properly stored | 15:00 |
jibel | andyrock, well the description says "Update: Actually the crash occurs on slow-ish systems due to a race condition." | 15:00 |
jibel | andyrock, okay so the problem may be partially fixed then because it still happens if the slideshow is removed | 15:01 |
andyrock | jibel: ah that's because Daniel fixed the bug in cairo | 15:02 |
andyrock | i fixed it in Ubiquity | 15:02 |
jibel | ah ok | 15:03 |
andyrock | maybe the race was in cairo | 15:03 |
didrocks | clobrano: and 18.10.4 uploaded to ubuntu :) | 15:04 |
clobrano | \0/ | 15:04 |
seb128 | andyrock, Daniel wrote that about the cairo issue | 15:13 |
seb128 | "Essentially we have the Xorg server process having its privileges demoted and re-promoted. If the XShmAttach request comes in while it is demoted then it can't complete the request and returns BadAccess to the client" | 15:13 |
seb128 | well, details in https://gitlab.freedesktop.org/cairo/cairo/issues/49 | 15:14 |
gitbot | cairo issue 49 in cairo "BadAccess errors in ShmAttach due to thread races with XNextRequest() usage in cairo-xlib-surface-shm.c" [5. Xlib Backend, Opened] | 15:14 |
=== pstolowski is now known as pstolowski|afk | ||
willcooke | night all | 17:03 |
seb128 | calling it a day, have a good night desktopers! | 18:38 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!