=== cpaelzer_ is now known as cpaelzer [06:37] good morning [06:38] Hi didrocks [06:38] #firstpost as usual [06:41] hey duflu ;) [07:04] Good morning folks [07:06] Morning jibel === pstolowski|afk is now known as pstolowski [07:09] hi duflu [07:17] salut jibel [07:18] Salut didrocks, ça va? [07:19] ça va, et toi ? [07:20] didrocks, bien, matinée un peu difficile, on a feér mon anniversaire hier :) [07:20] feté* [07:24] oh, bon anniv en retard alors :p [07:28] good morning all :) [07:28] hey clobrano! [07:28] hey didrocks , how's it going? [07:29] clobrano: I'm good, thanks! yourself? [07:29] nice! I've been better, but it's ok :D [07:30] oh? being busy or sick? [07:31] the latter :D [07:32] argh, get better! [07:32] it's been about two months of sciatica pain [07:32] thanks! [07:33] not ideal for sitting all day at a computer :) [07:35] yeah, I hope that some physiotherapist can help you [07:37] I tried everything, while waiting for my turn for surgery, hopefully it'll be soon [07:37] it's a very long list apparently :( [07:38] I can guess… :/ [07:38] at least, there are some surgery possiblities? [07:41] yes, at the end it is due to an herniated disc that can be removed [07:42] that's already a relief :) [07:47] :) [07:50] morning all [07:54] hey willcooke [07:57] Où est le garçon d'anniversaire? [07:58] il est dans le train à ce que j'ai compris [07:58] ah [07:58] 794635 [07:58] oops [07:59] Login confirmed [07:59] :) [08:00] Morning willcooke [08:00] afternoon duflu! [08:01] hey hey [08:04] morning Laney [08:06] hey Laney [08:06] clobrano: the dark and light variants are using the same GTK3 assets, correct? [08:06] correct [08:07] ok, I'll try to use a symlink then on the installed target [08:10] hey willcooke didrocks clobrano [08:10] ciao Laney, willcooke ! [08:11] hi clobrano! [08:46] good morning desktopers, from a spotty 3g :) [08:51] re seb128 [08:51] lut didrocks :) [08:51] man, meson is making it hard to generate same file name multiple times, but installing it in different dirs… [08:51] you have to create directories yourself just for the build system… [09:14] yep [09:14] hey seb128 [09:15] it's because meson always outputs to the build directory [09:19] there were bugs before where it would silently overwrite your files with the later ones [09:19] hopefully it at least warns now /o\ [09:58] seb128, will_cooke recently added a card to the proposed column to specifically target 19.04 (tamil 99 keyboard layout), which is why I used that for the libreoffice/libreoffice-l10n merge, shall we create a "proposed for 19.04" column now? [09:58] oSoMoN, as said on the board I've been canonical-desktop-wontdo those so far [09:59] the board is difficult enough to follow without stacking next-cycle work in proposed imho [09:59] We can create a 19.04 board next week? [09:59] so yeah, that sounds like good to me (or we keep wontdoing those and review that column when we start the next board, which works as well) [09:59] or that [09:59] either way wfm, I just don't want the backlog to be un-usable [10:00] any of these solutions wfm, let's just make sure we don't loose proposed work items on the way [10:00] right [10:18] kenvandine: dunno if it was you that triggered it, but gnome-characters failed to upload to the store - store auth failed. [10:18] https://launchpad.net/~ubuntu-desktop/+snap/gnome-characters/+build/330549 [10:18] "Store upload failed: The request is missing an Authorization header field containing a valid macaroon " [10:19] (also other snaps from that lp group such as gnome-logs) === pstolowski is now known as pstolowski|lunch [12:09] didrocks: is the UI freeze affected by Travis CI not able to build lastest master (I believe it's not, but...)? [12:12] clobrano: no, it's not [12:12] clobrano: as Travis CI is anyway only about the snap building [12:13] this snapcraft upload to the store issue is annoying btw :/ [12:13] clobrano: I'll soon have the dark theme building in // of light one soon for you to review ;) [12:29] great! [12:30] didrocks: how gtk2.0 works for the dark variant? Is there a new folder with dark assets? [12:32] clobrano: I can scaffold the gtk2.0 directory if you wish, I only did gtk3 for now, but yeah, it's a new folder [12:32] clobrano: do you want me to add it with the dark assets to bootstrap you? [12:33] didrocks: gtk3 is fine, I can use that as example [12:33] clobrano: let me PR now then [12:34] great, thanks [12:34] and add instructions for gtk2 ;) [12:34] \0/ [12:41] clobrano: https://github.com/ubuntu/yaru/pull/816, that should be it, let me know what you think and if the instructions for gtk2 are clear enough ;) [12:41] ubuntu issue (Pull request) 816 in yaru "Support dark variant" [Open] === pstolowski|lunch is now known as pstolowski [12:46] didrocks: checking it [12:50] didrocks: it seems pretty clear [12:50] merging it [12:51] clobrano: perfect, merged! Thx ;) [12:51] clobrano: I notice some other cleanup I can do in the build system, I might have a look today/tomorrow [12:51] popey, i'll look at it [12:51] didrocks: ack! === Class7_ is now known as Class7 [13:20] didrocks: made a fast combo with the new build and gtk2-dark. The build is perfect (y) gtk2-dark a bit less :D [13:25] clobrano: do you think it's shippable, like vlc works well with it, and not really? [13:28] clobrano: if you want to have a quick look, that was a leftover (dark apps on light theme): https://github.com/ubuntu/yaru/pull/817 [13:28] ubuntu issue (Pull request) 817 in yaru "Readd support for GTK3 apps choosing dark theme in a light environment" [Open] [13:46] didrocks, https://github.com/ubuntu/yaru/pull/818 for your reviewing pleasure, I think that should do the trick but let's see how the next CI run on this PR behaves [13:46] ubuntu issue (Pull request) 818 in yaru "Include Yaru in the custom gtk-common-themes snap built by CI jobs." [Open] [13:48] didrocks: I think there's some important work to do [13:48] it's not shippable [13:50] clobrano: ok then! [13:51] oSoMoN: looks good, I think however that you should do more cleanup [13:51] when building yaru [13:51] (same on gtk-common-themes snapcraft.yaml btw) [13:52] oSoMoN: look at the override-build: https://github.com/ubuntu/yaru/blob/master/snap/snapcraft.yaml#L22 [13:52] I remove everything not needed in the snap, like session files [13:53] oSoMoN: I guess you only need to add line 37 & 39 [13:53] didrocks, ack, I had missed that part, I thought it was all about renaming [13:53] (well, with 38 & 40 ;) off by one) [13:53] didrocks, I'll add that [13:53] thanks! [13:53] mind doing that as well in gtk-common-themes? [13:53] sure [13:53] oSoMoN: TBH, line 40 is really fresh… like 1h ago ;) [13:53] (the dark variant I just added, but not supported) [13:54] but line 38 was there. It's not harmful to have it, just useless [13:54] (useless in the snap context) [13:54] that's complex build hacking :) [13:55] engineering ;) [13:55] but at least, all documented and explained! [13:55] yeah [13:57] didrocks: however, I'll keep gtk-dark.css as well [13:57] hackgineering [13:57] didrocks, updated, will do another PR for similar cleanup for gtk-common-themes [13:58] k, another train change, bbiab [14:00] didrocks, in case you want to review that one as well: https://github.com/snapcrafters/gtk-common-themes/pull/12 [14:00] snapcrafters issue (Pull request) 12 in gtk-common-themes "Yaru part: remove unused build artefacts." [Open] [14:07] oSoMoN: thanks, doing both! [14:07] clobrano: keeping gtk-dark.css -> that's https://github.com/ubuntu/yaru/pull/817 (just merged) :) [14:07] ubuntu issue (Pull request) 817 in yaru "Readd support for GTK3 apps choosing dark theme in a light environment" [Open] [14:08] popey: you stole my merge!!! :p [14:08] didrocks, popey: yeah, I didn't know if was ok to merge it :D [14:09] oSoMoN's PR as well ^ [14:09] PR war [14:10] oSoMoN: small nitpick: https://github.com/ubuntu/yaru/pull/818#pullrequestreview-154667474 [14:10] ubuntu issue (Pull request) 818 in yaru "Include Yaru in the custom gtk-common-themes snap built by CI jobs." [Open] [14:10] but if you don't have time, happy to merge, we'll have anyway to remove the delention once we support the -dark variant [14:11] didrocks, that's ok, pushing the change now [14:12] didrocks, done [14:17] oSoMoN: and merged! Thanks :) [14:17] cheers [14:40] clobrano: and here are the build system simplifications: https://github.com/ubuntu/yaru/pull/819 [14:40] ubuntu issue (Pull request) 819 in yaru "Simplify build system by using meson configure project" [Open] [14:41] * clobrano checking [14:41] configure_file() isn't the best wording they found for templating in meson IMHO :p [14:42] (in term of finding how to do this) [14:42] yeah, I was unsure it was a meson thing at first :D [14:43] yeah, it is :p (was first introduced for config.h.in I think) [14:43] but couldn't find any doc easily first time, hence the python script at the time [14:43] at least, it's built-in, track files removal and supposively faster [14:43] I checked the generated file contents, they are the same [14:44] jbicha, http://launchpadlibrarian.net/386564286/gir-to-d_0.15.0-2_0.16.0-1.diff.gz [14:44] the diff looks not too scary [14:44] clobrano: thanks! ;) Merging [14:44] merged [14:44] ah, faster than I ;) [14:44] great! [14:44] eheh [14:44] clobrano: So, I want to do an upload to cosmic now, is that fine with you? [14:44] didrocks: sure [14:45] pity my employer doesn't let me use meson though :( [14:45] ok, remember that when UIF is in progress, it's only minor changes now, non visible ones ;) [14:45] what are you using? [14:45] I hope not autotools/cmake for you ;) [14:45] no, luckily just make [14:45] makefile with no autotools [14:45] ok, still unfun though :p [14:45] at all [14:46] so, if you are familar with make, I'll let you do the packaging changes in debian/rules [14:46] it's just a makefile :p [14:46] :O, not familiar with debian/rules though [14:46] k, that trip went well, back to my desk :) [14:46] seb128: \o/ [14:47] clobrano: heh, don't worry about it, even if nowdays, it's really easy with all the helpers [14:47] didrocks: I'll have a look then [14:48] * didrocks is using "gbp dch --multimaint-merge" \o/ [14:53] andyrock, do you remember the details of the race that caused bug 1751252 ? [14:53] bug 1751252 in cairo (Ubuntu Bionic) "[regression] ubiquity crashed in debconf.py:104 with ValueError: invalid literal for int() with base 10: ''" [High,In progress] https://launchpad.net/bugs/1751252 [14:53] It could be the same one that causes bug 1771751 [14:53] bug 1771751 in ubiquity (Ubuntu) "autopilot tests - default installation fails in plugininstall with "permission denied" messages" [Medium,Confirmed] https://launchpad.net/bugs/1771751 [14:59] jibel: it was not a race [15:00] jibel: ubiquity has a system to drop and restore permissions [15:00] jibel: that problem was that permissions were not properly stored [15:00] andyrock, well the description says "Update: Actually the crash occurs on slow-ish systems due to a race condition." [15:01] andyrock, okay so the problem may be partially fixed then because it still happens if the slideshow is removed [15:02] jibel: ah that's because Daniel fixed the bug in cairo [15:02] i fixed it in Ubiquity [15:03] ah ok [15:03] maybe the race was in cairo [15:04] clobrano: and 18.10.4 uploaded to ubuntu :) [15:04] \0/ [15:13] andyrock, Daniel wrote that about the cairo issue [15:13] "Essentially we have the Xorg server process having its privileges demoted and re-promoted. If the XShmAttach request comes in while it is demoted then it can't complete the request and returns BadAccess to the client" [15:14] well, details in https://gitlab.freedesktop.org/cairo/cairo/issues/49 [15:14] cairo issue 49 in cairo "BadAccess errors in ShmAttach due to thread races with XNextRequest() usage in cairo-xlib-surface-shm.c" [5. Xlib Backend, Opened] === pstolowski is now known as pstolowski|afk [17:03] night all [18:38] calling it a day, have a good night desktopers!