/srv/irclogs.ubuntu.com/2018/10/02/#snappy.txt

mupPR snapcraft#2310 opened: nodejs plugin: add support for ppc64el and s390x <Created by anthonyfok> <https://github.com/snapcore/snapcraft/pull/2310>00:50
luk3yxWhen will build.snapcraft.io use 18.04 to build snaps?01:03
ilias_grhi all. does anyone maybe know why using skype for ubuntu the systray icon doesn't change when user switch between different system's icon packs?04:27
mborzeckimorning05:06
=== chihchun_afk is now known as chihchun
zygagood morning06:28
* zyga spent way too many hours debugging a simple type error : /06:30
mupPR snapd#5895 closed: client, daemon: support passing of 'unaliased' option when installing from local files <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5895>06:31
zygaerror: received an unexpected http response code (503) when trying to download https://fastly.cdn.snapcraft.io/download-origin/fastly/pYVQrBcKmBa0mZ4CCN7ExT6jH8rY1hza_158.snap?token=1538474400_751f689ba95d256c948c3192959fb3e166ab9c8206:38
zyga+ find '/home/gopath/src/github.com/snapcore/snapd/tests/snapd-state/snapd-lib/*' -maxdepth 0 '!' '(' -name snaps -o -name seed ')' -exec cp -rf '{}' /var/lib/snapd ';'06:38
zygafind: ‘/home/gopath/src/github.com/snapcore/snapd/tests/snapd-state/snapd-lib/*’: No such file or directory06:38
mborzeckiwell, at least the tests failed right?06:46
zygaintegration tests failed, I incorrectly handled one unit test that would work ok because it was mocked06:47
zygaerror types06:47
zygaanyway, sorted out now06:47
zygajust realised it way too late last nighrt06:47
zyga*night06:47
mupPR snapd#5875 closed: interfaces/builtin: avahi interface update <Created by kubiko> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5875>06:53
=== pstolowski|afk is now known as pstolowski
pstolowskimorning07:05
=== chihchun is now known as chihchun_afk
zygahmm hmm07:21
* zyga digs deeper into issues 07:21
=== chihchun_afk is now known as chihchun
zygathere's something wrong with layouts on core1807:38
mupPR snapd#5874 closed: interfaces/builtin: adding missing permission to create /run/wpa_supplicant directory <Created by kubiko> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5874>07:39
zygaI have a hunch I know what is going on but I wasn't expecting this problem yet07:40
mvozyga: tell me more please07:45
zygawell, it's related to trespassing and when we consider it is safe to write to a directory07:45
zygaI started with a conservative decision to only allow writes to a directory when said directory is the mount point of a tmpfs we can trace to snapd07:45
zygaone of the tests exercises a sub-sub directory07:46
zygaand snap-update-ns doesn't consider that a guaranteed tmpfs07:46
zygathis happened because the apparmor generalisation landed07:46
zygaand a test switched from /bin/some-very-weird-place to /bin/some/very/weird/place to show that the apparmor part of it works07:47
zygaI knew about it but didn't realise it would come into reality as a test problem this way (via merging of the other branch)07:47
zygathe question is how to safely extend the logic to allow sub-directories of a tmpfs that is still a tmpfs and not hidden by some other mount operation07:48
Chipacamoin07:48
Chipacamvo: mborzecki: Asplode() -> AsMaps()?07:49
zygaso if /bin is a tmpfs then /bin/very is also a tmpfs unless it's explicitly mounted as something else07:49
zygait's just tricky code because we cannot identify a filesystem instance easily AFAIK07:49
* zyga checks07:49
zygamaybe I'm wrong actually07:49
mborzeckiChipaca: sounds good07:49
mborzeckiChipaca: your #5879 made me dig into go-flags and read what the flag does :)07:50
mupPR #5879: vendor, cmd/snap: refactor to accommodate the new less buggy go-flags <Created by chipaca> <https://github.com/snapcore/snapd/pull/5879>07:50
Chipacamborzecki: I'm so sorry07:50
Chipaca:)07:51
Chipacamborzecki: --posixly-correct07:51
Chipaca¯\_(ツ)_/¯07:51
mborzeckiChipaca: don't be, it was nice07:51
Chipacaheh, that looks like I'm holding mborzecki up on a platter07:52
Chipacamaybe I'm about to throw it into a pool or sth07:52
Chipacazyga: is your pi3 connected and on in The Lab?08:10
zyganope, it's a bit offline actually08:11
zygaI need to reformat all of the things and put them in proper network08:11
zygaif urgent I can bring one online08:11
Chipacanot urgent08:11
zygaI have pi2-2 in my hands08:12
zygaI think it's still running core08:12
ChipacaI was just wondering how long 'snap' took to run on a pi these days08:12
zygahold on08:12
Chipaca(that is: 'time snap > /dev/null'08:12
Chipaca)08:12
Chipacathings that are fun: find -type f -name \*.go \! -name \*_test.go -print0 | xargs -0 perl -pi -we 's/(^func init\(.*)/$1\nprintln("$ARGV")/'08:16
Chipacayaml wins08:16
zygano pikcza08:17
zyga(no picture)08:17
zygait doesn't boot08:17
zygaI think the SD cards degrade pretty rapidly :/08:18
zygaI'll re-flash it08:18
* zyga tries to recall where to get pi2 images08:20
zygaor the magic incantation to make one...08:20
mvozyga: no worries I should have a working pi308:20
zygaI may as well flash it08:21
mvoChipaca: https://paste.ubuntu.com/p/JfZ5NtpJJX/08:22
mvozyga: try http://cdimage.ubuntu.com/ubuntu-core/16/stable/08:22
Chipacamvo: and redirecting to /dev/null?08:22
mvozyga: http://cdimage.ubuntu.com/ubuntu-core/16/stable/current/08:22
Chipacamvo: (thanks!)08:22
mvoChipaca: pretty much the same08:22
mvoChipaca: https://paste.ubuntu.com/p/HTwkZzTGGf/08:23
Chipacamvo: lovely08:23
ChipacaI can stop worrying about this for another year \o/08:23
zygathanks moo!08:23
zygamvo:08:23
zyga(silly tab completion)08:23
zygabut somehow aptpropritate08:23
mvohaha08:24
mupPR snapd#5890 closed: overlord/snapshotstate: small refactor of internal helpers <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/5890>08:31
ChipacaBRB, new kernel08:41
=== kjackal_v2 is now known as kjackal
* zyga tests a tweak that should get out out of the problem 09:17
* zyga forgot to flash pi2, flashing now09:20
mupPR snapd#5896 opened: snapcraft.yaml: set grade to stable and add type: snapd <Created by mvo5> <https://github.com/snapcore/snapd/pull/5896>09:21
zygasigh :/09:24
zygawoah09:24
zygaactually!09:24
mupPR snapd#5897 opened: interfaces/builtin: add gpio-keys interface for accessing events <Created by bergotorino> <https://github.com/snapcore/snapd/pull/5897>09:34
* pstolowski after typing 'go push' for nth time, wishes computers were smart enough to know what i mean wrt to git and go, and simply do the right thing09:36
mupPR snapd#5898 opened: tests: spread tests for aliases with parallel installed snaps <Parallel installs> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5898>09:36
zygaflashed pi2, no picture :/09:37
zygaback to debugging09:37
mborzeckizyga: you got to make an offering to the pi09:38
zygaI have to plug the serial adapter but sigh, not now09:39
zyga2018-10-02 11:39:38 Cannot allocate google:ubuntu-core-18-64: cannot allocate new Google server for ubuntu-core-18-64: quota 'IN_USE_ADDRESSES' exceeded. Limit: 575.0 in region us-east1.09:50
zygawe may have stale machines somewhere?09:50
zygawoot, some improvement09:57
mupPR snapd#5883 closed: tests,cmd/snap-update-ns: add test showing mount update bug <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/5883>10:08
mupPR snapd#5899 opened: tests: shellchecks, final round <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5899>10:18
mvomborzecki: yay for shellcheck10:37
mborzeckimvo: slightly longer than usual, but i figured we should just be done with it10:38
mvomborzecki: +110:40
=== chihchun is now known as chihchun_afk
rogpeppeif i have i've registered a snap, but i want to make it possible for other people (ideally a team) to manage that snap (push updates, etc), how would I do that?10:47
zygarogpeppe: add them as collaborators in the snap dashboard10:50
rogpeppezyga: where do i find the snap dashboard?10:50
zygarogpeppe: login to https://snapcraft.io/ and go to https://snapcraft.io/snaps10:51
rogpeppezyga: i'm currently looking at https://snapcraft.io/mysnapname/listing10:51
zygathen pick the snap name you want to share10:51
rogpeppezyga: click on it?10:52
zygahmm, hold on10:52
zygahttps://dashboard.snapcraft.io/snaps/10:52
rogpeppezyga: ah yes! just found that10:53
zygathat functionality is available in the old dashboard10:53
rogpeppezyga: very confusing10:53
zygathen you can go to collaboration page10:53
zygayeah, I agree10:53
zygaI thought this was one page now10:53
rogpeppezyga: can i add groups?10:53
zygano, only users AFAIK10:53
rogpeppezyga: ok, thanks.10:54
zygamborzecki: I took the logic for updating a namespace into a new package and wrote a mini tool that just displays what would happen given two fstab files10:54
zygaI ran it on the problematic namespace10:54
zygahttps://paste.ubuntu.com/p/QYCsJMkPJg/10:54
zygathe results are sane10:54
rogpeppezyga: thank you10:54
zygaso far so good then10:54
zygaI'll break for coffee and do more digging10:57
ogramvo, sil2100 what happened to the pi3 gadget, there are a bunch of fixes that do not show up in edge (16)11:00
ograall of a sudden the auto-builds seem to build 18.X only11:00
ograwe (ondra mainly) are trying to test the pi3 b+ and the last pi3 gadget build for core16 is from august ... yet the last commits on GH are newer (to pick up the new boot firmware)11:01
ograi see it being built at https://code.launchpad.net/%7Ecanonical-foundations/+snap/pi311:02
ograoh11:02
ogra"Store upload failed: Cannot upload new revisions for name=pi3 series=16 "11:03
ograhttps://code.launchpad.net/~canonical-foundations/+snap/pi3/+build/34395711:03
ograondra_, so seems the builds havent been uploaded since august 2017 :/11:03
ogracjwatson, any idea whats going on there with that "Store upload failed: Cannot upload new revisions for name=pi3 series=16" ? (there is no other error msg anywhere)11:04
ograhrm ... and hitting the retry button gets me "you are not allowed here" ... thats new11:05
ograthis is pretty serious, the boot firmware had plenty of imprtat fixes since aug. 2017 that should go in asap11:08
ogra(power and thermal mgmt ... support for cm3 and pi3b+)11:09
zygaback to digging11:10
Chipacaoh dang11:14
Chipacamborzecki: mvo: do we have a 'stop the line' button?11:15
Chipacamborzecki: mvo: the xdelta tests are failing -- at first I thought it was a transient and was checking with wgrant, but the logs show we aren't enabling deltas, and mborzecki's pr just failed with them as well11:15
Chipacamborzecki: mvo: what have we broken?11:16
mborzeckiChipaca: wasn't there a switch to enable deltas?11:17
mborzeckii vaguely recall a pr (from mvo?)11:17
ondra_ogra ping11:18
pedronisit's generally on now (lat time I checked)11:18
Chipacamborzecki: as long as we have an xdelta3 executable it should be on -- and we nearly always have an xdelta3 executable as it's in core :-)11:18
ograondra_, yo11:18
mborzeckiChipaca: what if the executable is named xdelta?11:18
Chipacamborzecki: the one in core isn't11:19
ograondra_, i can see you now11:19
pedronisChipaca: are they failing everywhere or only some distros?11:19
wgrantmborzecki, Chipaca: Also xdelta is xdelta 1, not xdelta311:19
Chipacapedronis: everywhere11:19
Chipacabah11:19
pedronisdid master became red and we didn't notice?11:20
pedronisor is it on PRs?11:20
Chipacaamazon-linux-2-64,arch-linux-64,debian-9-64,fedora-28-64,opensuse-42.3-64,ubuntu-14.04-64,ubuntu-16.04-64,ubuntu-18.04-64,11:20
mborzeckiw8, but the PRs id opened today were green11:20
Chipacaeverywhere that isn't actually core11:20
Chipacapedronis: on two unrelated PRs that are unrelated to this bit of code11:20
pedronismaster is green fwiw11:21
pedronisatm11:21
Chipacamy epoch.CanRead, which isn't even used anywhere, and mborzecki's shellchecks11:21
mborzeckiyup, but #5898 which was opened 2h ago is green11:21
mupPR #5898: tests: spread tests for aliases with parallel installed snaps <Parallel installs> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5898>11:21
Chipacamborzecki: and the same epochs PR that ran spread just before this last run failed with a silly transient error unrelated to this11:22
Chipacaso whatever it was, it was in the last half hour11:22
Chipacawhich is why the first thing I assumed was store shenanigans11:22
Chipaca(sorry wgrant)11:22
wgrant:)11:23
wgrantNew core snap maybe?11:23
wgrantYeah11:24
wgrantIt had core 561811:24
wgrantWhich is 16-2.36~pre1, and it's 53 minutes old11:24
wgrantmvo: ^^11:24
wgrantMust be that, surely11:24
Chipaca    334             "created-at": "2018-10-02T10:30:33.953597+00:00",11:24
Chipacaheh, yep11:24
pedronislikely, wonder why we decided to drop one package there (or whether we dropped more,  that would be bad)11:24
wgrantxdelta3 is in the build log, though11:25
wgrantBut not the manifest11:25
pedronisit's supposed to have a fixed list of packages11:25
Chipacawgrant: in which build log?11:25
wgranthttps://launchpad.net/~snappy-dev/+snap/core/+build/34474411:25
Chipacaah11:25
pedronisat this point11:25
wgrantThe build log for that core snap11:25
Chipaca$ /snap/core/current/usr/bin/xdelta3 -h11:25
Chipacabash: /snap/core/current/usr/bin/xdelta3: No such file or directory11:25
Chipaca^ that's core from beta11:25
Chipacafuuuuu11:25
Chipacamvo: OHAI11:25
Chipacaor maybe cachio11:26
pedronisfun (not)11:26
Chipacaalso, also, of course cachio today had is laptop go all MCE on him so he's unavailable for a bit11:26
pedronisChipaca: either losing packages out of core is bad (tm) :/11:26
mborzeckigood thing it was caught by the tests after all11:27
pedronisI think core18 has more checks in that area11:27
sil2100ogra: yeah, I'll be looking at that11:27
ograsil2100, thanks ...11:28
wgrantOh11:28
wgrantThe xdelta3 in the log is LP installing it for the snapd in the container to use11:28
wgrantNot the build itself, heh.11:28
Chipacaanother thing, we need to update the tests because we've got refresh-delta and refresh-delta-from-core with the assumption that the former has xdelta3 from the distro and the latter doesn't, but the former doesn't check11:28
ograwgrant, Chipaca that build log shows that the completely wrong livecd-rootfs is used11:30
ograit needs to come from the PPA unless *all* PPA changes have been merged into xenial-updates yet11:30
wgrantHah, indeed,11:30
ogra(probably that was a manual build and whoever did it missed to pick the PPA as archive ?)11:31
wgrantRUN: /usr/share/launchpad-buildd/slavebin/in-target override-sources-list --backend=lxd --series=xenial --arch=amd64 SNAPBUILD-344744 'deb http://ppa.launchpad.net/snappy-dev/tools/ubuntu xenial main' 'deb http://ftpmaster.internal/ubuntu xenial main restricted universe multiverse' 'deb http://ftpmaster.internal/ubuntu xenial-security main restricted universe multiverse' 'deb http://ftpmaster.internal/ubuntu11:31
wgrantxenial-updates main restricted universe multiverse'11:31
wgrantyeah, no, image in there, just tools11:31
wgranthttps://launchpad.net/~snappy-dev/+snap/core/+build/344744 <- indeed, primary archive build11:31
wgrantWorth quickly reverting that at least in beta to avoid bricking everybody?11:32
Chipacano brick, just no deltas11:32
pedronisChipaca: that's a theory, it was built all wrong, so something else might be amiss11:33
ograChipaca, definitely brick ...11:33
ograChipaca, if the build scripts are wrong you get more broken content than xdelta3 missing :)11:33
Chipacaogra: if so then we should definitely revert11:33
Chipacai can do it, but i'd rather a nod from mvo before just doing it :)11:33
=== d__ed is now known as d_ed
* Chipaca telegrams11:34
* Chipaca succeeds11:34
mvoChipaca: here11:37
mvoChipaca: thanks for altering me, I removed ~pre1 from edge11:37
Chipacamvo: nice11:38
Chipacamvo: thanks11:38
mvoChipaca: reading backlog now11:39
Chipacamvo: look for 'stop the line' and down from there11:39
mvoChipaca: hrm, the annoying part is there is a script that checks if the ppa is missing and it should error in this case11:39
* mvo looks why this was not working11:39
Chipacamvo: maybe ogra removed the 'set -e'11:40
* Chipaca hides11:40
mvohaha11:40
ogramvo, whoever buuilt it missed to pick the PPA as archive in the build form ... so the archive livecd-rootfs was used11:40
mvoogra: yes, my fault11:40
mvoogra: I'm looking why it did not error, there is code in there that should make it error :(11:41
ograChipaca, well, for my british friends i nowadays do not remove "set -e" but add "set -eu" :P11:41
ogramvo, thats the outer lxd container ... during build it then pulls the right livecd-rootfs (but then it is already too late)11:42
ogranot sure you can actually have code inside the container that checks the livecd-rootfs version outside11:42
zygaogra: lol11:43
Chipacaogra: +1.3311:43
cjwatsonogra: That means that the user who authorised the upload of that snap is no longer a publisher or a collaborator of the snap.  Get somebody appropriate to go to https://code.launchpad.net/~canonical-foundations/+snap/pi3/+authorize and reauth it11:45
ogracjwatson, ah, seems i lost my credentials when i moved teams or some such ... but sil2100 already said he'd take care11:45
ogra(or the build moved ownership ...)11:46
mupPR core#97 opened: snapcraft.yaml: add check for ppa:snappy-dev/image <Created by mvo5> <https://github.com/snapcore/core/pull/97>11:49
zygaHA11:50
zygathat was super fun to find11:50
axinohi popey, could you please release edge into stable for the sentry snap ?12:06
popeyaxino: done12:07
axinopopey: thanks !12:07
=== pstolowski is now known as pstolowski|lunch
dot-tobiasWhat's the best way to implement an on-demand-service in my snap? Use case: My snapped app needs a DNS server (dnsmasq) if it is in setup mode, so I need to start/stop the server from within my application code. However, it should *not* (re-)start automatically (i.e. like snap daemons) Q1: How would I start the service from within the snap? Q2: And how to stop the service if I don't have access to systemctl?12:27
zygayou can do both by invoking "snapctl"12:27
zygaor by talking to snapd over a socket directly12:27
zyga(but snapctl makes that much easier)12:27
mupPR snapcraft#2309 closed: snap: improve early base detection logic <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2309>12:27
zygaas for the part where you want the service not to restart automatically12:28
zygathere's a word that you can use in the snapcraft.yaml (or snap.yaml) to convey that12:28
zygaI recall that at the level of an application definition you say "refresh: endure" or something like that12:28
zygait will then not be restarted when a snap is refreshed12:28
zygaand it is up to you to manage that12:28
dot-tobiaszyga Ok, thanks. But the service would be started on snap installation?12:29
zygacurrently yes but there's a PR that fixes a bug in this area, which once merged would allow you to disable the service from a configure (or install) hook12:30
zygaso your hook disables the service using snapctl12:30
zygayour snap or configure hook can enable or start it on demand12:30
zygaor actually, as the need arises12:30
zygasuch as when the application logic determines it is now needed12:30
zyganot in the socket-activation meaning of the word12:30
zygabut note that the bug is still in place and snapd will still try to start disabled services12:31
* zyga looks at the PR12:31
zygahttps://github.com/snapcore/snapd/pull/577712:31
mupPR #5777: wrappers/services.go: don't start disabled services <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/5777>12:31
zygait seems that someone needs to pick that up and finish it12:31
zygadot-tobias: does that answer your question?12:32
dot-tobiaszyga (skimming through the PR) yes, that should solve my problem. Any internal ETA on when this will be merged? Need to release an initial beta soon, and depending on that I'd need to find a workaround until then.12:34
dot-tobiasAnd thank you again, of course 😊12:34
zygano ETA, someone just needs to pick it up12:35
mupPR core#97 closed: snapcraft.yaml: add check for ppa:snappy-dev/image <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/core/pull/97>12:41
dot-tobiaszyga Would love to help if I had any proficiency in Go, but I guess I would need to take a weeklong deep dive into Go & snapd to even have a faint idea of what I'd be doing there … While the daemon route seems the way to go when the PR is merged, is it possible to stop a process (dnsmasq in background mode) that's been triggered by my app? The interfaces docs mention that core-support provides access to systemctl, but is reserved for core snaps.12:41
ogramvo, oh, wow ... seems you trashed three of my test Pi's over here ... all of them run 16-2.36~pre1 and there are no network tools in the rootfs (so only serial login)12:42
zygadot-tobias: I think we will handle that , no worries, just cannot give you a timeline12:42
ograinterestingly enough it boots fine to console login12:42
Chipacawaiting for tests is dangerous12:42
Chipacahttps://pastebin.ubuntu.com/p/jR2vnGjZvP/12:42
zygadot-tobias: would dnsmasq be a part of your snap or just any random service in the system?12:42
dot-tobiaszyga dnsmasq is part of my snap.12:42
dot-tobiasorganized to $SNAP/bin/dnsmasq12:43
zygadot-tobias: for that you *can* use snapctl to stop the service from your snap, you don't need any interface for this12:43
zygaI don't recall if this is documented, let me look12:43
zygadot-tobias: have a look at https://forum.snapcraft.io/t/service-management/396512:43
mvoogra: yeah, snap revert12:44
mvoogra: but no network, I reproduced it and the no-network is the killer12:44
mvoogra: sorry for that12:44
dot-tobiaszyga: Thanks, will try it out!12:44
ogramvo, no worries ... i asked for it by choosing edge after all ;)12:45
Chipacaoh dang, lunch12:45
mvoogra: I'm looking into a check for this as we speak to ensure this can't happen again12:45
ogramvo, yeah, i saw your clever PR above already12:45
ograthat looks actually good ...12:46
zygadot-tobias: good luck!12:46
zygadot-tobias: hint: try "snap run --shell your-snap"12:46
zygaand then run snapctl12:47
zygayou should be able to get access to your services12:47
mvoogra: yay, check worked, so this won't ever happen again:https://code.launchpad.net/~snappy-dev/+snap/core/+build/344819  - bad enough that it happend once :(12:48
ograjdstrand, any news for me about dashkiosk-client-browser ?12:48
ogramvo, once ? it happened quite often to me back when i was still in charge ... :) (but i usually noticed before it went to the store)12:49
ograits a bit sad that LP doesnt simply keep the choices you did for the last build as default12:50
mvoogra: heh - indeed12:50
ograperhaps one day someone invents an internet technology that makes it possible to store such data in your local browser ... and callsss them crisps ... or cakes ... or cookies :P12:52
=== Son_Goku is now known as Conan_Kudo
=== Conan_Kudo is now known as Son_Goku
=== pstolowski|lunch is now known as pstolowski
jdstrandogra: oh sorry. I had it on my desk then got distracted13:06
ograno worries ... i thought so :)13:06
mupPR snapd#5900 opened: release: 2.36~pre1 <Created by mvo5> <https://github.com/snapcore/snapd/pull/5900>13:11
ijohnsonHey folks, I'm almost done with handling sockets/timers in #5777, but currently snapctl and snap commands both don't handle stopping services with timers/sockets so that can't be tested in my PR. I'm wondering if I should add support for stopping sockets/timers in this PR or a different one?13:36
mupPR #5777: wrappers/services.go: don't start disabled services <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/5777>13:36
emilenglerWhy snap remove does not remove the cahced snap ?13:40
ogracan you elaborate ?13:40
zygaemilengler: I think we cache the snap on disk for some time13:41
zygaI don't recall the exact condition13:41
zygabut it's deliberate13:41
ograbut only the first installed one, no ?13:42
mborzeckipedronis: can you take a look at https://github.com/snapcore/snapd/pull/5898 later today/tomorrow?13:42
mupPR #5898: tests: spread tests for aliases with parallel installed snaps <Parallel installs> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/5898>13:42
pedronismborzecki: tomorrow, I have some errands today and will finish a bit early13:43
mborzeckipedronis: sure, thank you!13:43
pedronisChipaca: https://github.com/snapcore/snapd/pull/579113:43
mupPR #5791: overlord/snapstate: improve consistency, use validateInfoAndFlags also in InstallPath <Created by pedronis> <https://github.com/snapcore/snapd/pull/5791>13:43
Chipacamvo: with you now having written a juju charm, do we need to add Charming to your honorifics?13:44
Chipacapedronis: looking13:44
Chipacazyga: https://github.com/snapcore/snapd/pull/5891 one to help you with your aim of review more :-D13:45
mupPR #5891: snap: give Epoch a CanRead helper <Created by chipaca> <https://github.com/snapcore/snapd/pull/5891>13:45
zygaChipaca: ack :) looking now13:45
* zyga fired spread with the tmpfs subdirectory fix13:45
zygathe actual fix is tiny, it just took a while to get to13:45
Chipacapedronis: I'm sure I'd seen this one before; +113:46
zygaChipaca: oooh13:47
pedronisChipaca: yes, but just today I went to it to make the spread tests pass, again don't make it too backward incompatible13:47
zygaChipaca: you know I will bike shed around intersect, right?13:47
Chipacazyga: I can show you alternative, worse implementations13:47
Chipacazyga: https://pastebin.ubuntu.com/p/2WwjkPNStG/13:48
Chipacazyga: the only one that is arguably better is F1b13:49
Chipacazyga: F1c,  not shown there, which has two more ifs in it is slower again13:49
mvoChipaca: hahaha13:49
Chipacabah, I might as well add them all13:49
zygaChipaca: did you try sorting the shorter list, then iterating over the longer list while binary-searching in the short list?13:50
Chipacazyga: they're both sorter13:50
Chipacasorted*13:50
zygaoh13:50
zyganice13:50
Chipacazyga: and both non-empty13:50
Chipacazyga: F3 does binary search13:50
zygaanyway, I'll get something to bite on and read this13:51
Chipacazyga: I'll restore the full one so you see all the variations13:51
zygak, brb13:51
mborzeckifunny, cause iirc the list of 10 elements max :)13:53
cachiomvo, 2.35.2 is stable now13:55
mvocachio: thank you13:55
mvocachio: now I just need to nudge the sru guys again about it :/13:56
mborzeckioff to pick up the kids13:56
cachiomvo, good14:01
cachiomvo, I'll start with beta now14:02
kenvandinezyga: any theories on bug 1794953 ?14:05
mupBug #1794953: GNOME Calculator snap has wrong theme in live session <rls-cc-tracking> <snapd:New for zyga> <gnome-calculator (Ubuntu):Invalid by ken-vandine> <snapd (Ubuntu):Confirmed14:05
mupfor zyga> <gnome-calculator (Ubuntu Cosmic):Invalid by ken-vandine> <snapd (Ubuntu Cosmic):Confirmed for zyga> <https://launchpad.net/bugs/1794953>14:05
Chipacazyga: qqq in my home on office.zygoon.pl, fwiw14:34
zygare14:42
zygaChipaca: qqq?14:42
zyga(sorry, I was stolen to participate in family lunch_)14:43
zygaah14:43
* zyga looks14:43
Chipacazyga: I have a random package name generator14:43
Chipacazyga: (it's not very random)14:43
Chipacafor example I also have some other unrelated tests in /tmp/jjj14:43
zygaI need to spend this evening on bringing machines back online14:43
Chipaca(about json)14:43
* zyga sees that now14:44
Chipaca¯\_(ツ)_/¯14:44
zygaoh, BenchmarkF14:44
Chipacait starts with /tmp/q.go being my default scratch file for go stuff14:44
zygaI never tried that14:44
Chipacaand, well, not being good with names means i don't even try unless it's important :-)14:44
zygakenvandine: as for your question, no theory yet, I need to see what's going on in live sessions to begin with14:44
zygakenvandine: is it perhaps related to the fact that theming was broken in those snaps we looked at the last time?14:45
rbasakIs there any known regression in the core beta snap atm? I have one14:46
rbasakAffects beta and edge AFAICT14:47
rbasakhttps://paste.ubuntu.com/p/zqWhpGF8nC/14:47
rbasakmvo: ^14:47
Chipacarbasak: re-refresh14:47
Chipacarbasak: we broke it, and then fixed it14:47
rbasakAh14:47
Chipacarbasak: 1 sec, let me get you a timestamp14:48
Chipacarbasak: 2018-10-02T10:30:33.953597+00:0014:48
Chipacarbasak: that core ^ is buggy14:48
rbasakahasenack: ^14:48
Chipacaer, i should have a revno14:48
mvorbasak: we had a bad core for about 30min14:48
Chipacarbasak: we caught the issue and reverted to a known-good one already, fwiw14:48
Chipacaas mvo says14:49
kenvandinezyga: the theme is fine for those same snaps on a clean 18.10 install14:49
zygaI see14:49
ahasenackrefresh-date: 11 days ago, at 08:50 -0314:49
rbasakbeta (5624) is still broken I think?14:49
ahasenackweird why mine didn't refresh in such a long time14:49
zygait could be a new interaction with how overlayfs is used on 18.10, I need to debug that14:49
mvorbasak: sorry for that, just revert or refresh and it should be fine again. sorry for the trouble. we identified the source and added an extra check during the build to ensure this won't happen again14:49
zygaI didn't have the time to do that yet14:49
ahasenackinstalled:   16-2.35.2                (5548) 92MB core is what I have14:49
Chipaca5618 is the broken one for amd6414:49
ahasenackwhat about 5548?14:50
* Chipaca checks revnos14:50
mvorbasak: what kind of breakage do you see with 5624?14:50
mvoahasenack: 5548 should be good14:50
rbasakI don't have a reproducer with core only. Is there any way of getting a shell on core?14:50
ahasenackI'm tracking beta, I wonder why I didn't get   beta:      16-2.36~pre1             (5624) 92MB -14:50
rbasakMy reproducer is as my pastebin above14:50
mvorbasak: if you have grub you can add "systemd.debug-shell=1" to the cmdline14:50
Chipaca5548 is stable, even14:51
mvorbasak: missed that pastebin let me look14:51
rbasakIt could be git-ubuntu, I don't know.14:51
mvorbasak: let me try this14:51
Chipacarbasak: ahasenack: ah, was about to say, 5624 is what you're on it seems14:51
rbasakBut it seems to be triggered by a core snap update - stable was OK this morning.14:51
mvorbasak: could be us let me look at it14:51
rbasakThanks14:51
mvorbasak: I mean, we had a bad beta today so I'm inclined to first look at our stuff.14:52
zygakenvandine: I can promise you to look at and attempt to debug the issue first thing tomorrow14:52
ahasenackChipaca: https://pastebin.ubuntu.com/p/mw8g8x3qm3/ am I not on 5548?14:52
zygakenvandine: today I plan to finish producing mergeable fixes for other mount related bugs14:52
Chipacaahasenack: ah,  you are, rbasak is not14:52
kenvandinezyga: thanks14:52
ahasenackok, I get the same problem as him14:52
rbasakI've jumped about all over the place today14:52
Chipacaahasenack: so that's confusing, are you talking about the same issue?14:52
Chipacamvo: ahasenack has it and he's on stable14:52
ahasenackyes, I'm getting this:14:53
rbasakI can confirm a specific one for you if you want to focus on a particular version14:53
Chipacawe haven't touched stale in a while, let me get a timestamp14:53
ahasenack10/02/2018 11:50:51 - ERROR:stderr: awk: error while loading shared libraries: libreadline.so.6: cannot open shared object file: No such file or directory14:53
ahasenack  awk: error while loading shared libraries: libreadline.so.6: cannot open shared object file: No such file or directory14:53
ahasenackwhich rbasak streamlined into his pastebin14:53
Chipacastable is from 2018-09-2114:53
Chipacaahasenack: rbasak: 5548 is from 2018-09-21T09:37:27.063407+00:0014:53
mvoahasenack: we had a stable update today14:54
ahasenackthe word "stable" does not appear for core in my snap list --all output14:54
ahasenackand "snap info core" says I'm tracking beta14:54
ahasenackis stable ahead of beta?14:54
rbasakstable is now broken :-/14:54
rbasak554814:55
Chipacasigh14:55
rbasakit was working for me this morning, but I didn't record the version14:55
Chipacaahasenack: you said you were on 554814:55
Chipacaahasenack: or am I losing it14:55
ahasenackChipaca: look at https://pastebin.ubuntu.com/p/mw8g8x3qm3/14:55
mvorbasak: this morning it was 2.35 - now its 2.35.214:55
ahasenack5548 has "beta" next to it14:55
rbasakI did some testing this morning, then was called away, so there was a gap before I reported it here, sorry.14:56
ahasenackso looks like beta was promoted to stable, and now both have 5548, is that it?14:56
mvorbasak: what environment did you run this on? bionic? cosmic?14:56
rbasakmvo: bionic14:56
mvoahasenack: candidate was promoted to stable today, beta should be a different revision (r5624 currently)14:57
* Chipaca was getting confused and only adding confusion so will now keep quiet for a bit14:57
rbasakmvo: I reproduced on a Bionic VM with the edge git-ubuntu snap14:57
mvorbasak: thanks, let me try with git-ubuntu edge14:57
ahasenackrefreshing core14:58
ahasenackI'm getting 5624 now14:58
rbasakI can give you exact steps that work I believe, so let me know if you have any difficulty14:58
mvorbasak: I poke at it now (both on my bionic box and in a VM)14:58
ahasenackstill happens to me with 16-2.36~pre1          562414:58
ahasenackfwiw14:58
mvorbasak: slightly strange is that you and ahasenack  were running beta for a while so nothing should have changed for you14:58
Chipacaahasenack: rbasak: which was the last core that worked ok for you?14:59
mvorbasak: this revision of core that is now in stable was in beta/candidate for a while14:59
ahasenackmvo: I didn't get this just today, it's from last week I think14:59
ahasenackI was on pto14:59
mvoahasenack: oh, ok14:59
mvoahasenack: thanks, that explains this part then14:59
ahasenackI can try reverting core15:00
rbasakmvo: I haven't been using this particular subcommand of git-ubuntu that triggers it, so it's only ahasenack who had noticed it until I tried to reproduce15:00
ahasenackI still have 5486 available15:00
rbasakChipaca: I believe stable from this morning worked, though I don't see exactly how to revert to that right now.15:00
mvorbasak: snap revert core is not working ?15:01
Chipacarbasak: snap list --all core, if you still have the revno you can revert core --revision=...15:01
Chipacawhich is the git-ubuntu subcommand that fails?15:01
ahasenackmvo: Chipaca rbasak with core r5486, it works15:01
Chipacanice15:02
ahasenackChipaca: build-source, when inside an ipsec-tools package, but rbasak's test case is shorter/simpler15:02
rbasakChipaca: thanks. "snap help refresh" said "snap refresh --list" but that didn't work (just said "All snaps up to date."15:02
rbasak)15:02
Chipacarbasak: refresh != revert :)15:02
mvoso far on my bionic main box I can not reproduce it but I am trying in a vm now, my regular machine is heavily customized15:02
rbasakChipaca: nevertheless, that's what "snap help refresh" says!15:03
mvorbasak: I see it in a fresh vm15:03
rbasakUnfortunately I think I've tested too many revisions since, and it has scrolled out of my (three?) history revisions15:03
rbasak(the stable one that worked)15:03
Chipacarbasak: I'm not following, but let's get back to that afterwards (better docs is good, but)15:03
rbasakOK15:05
Chipacarbasak: which was your smaller reproducer?15:06
mupPR snapcraft#2311 opened: snap: legacy needs to now it is legacy for re-exec <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2311>15:07
Chipacarbasak: got it15:08
rbasakFTR, https://paste.ubuntu.com/p/zqWhpGF8nC/15:08
rbasakOn the git-ubuntu edge snap, is the smallest I have15:08
Chipacarbasak: can you install test-snapd-tools, and snap run --shell test-snapd-tools.sh and see awk there?15:09
mvorbasak: it looks like something is not setting the right LD_LIBRARY_PATH, with LD_LIBRARY_PATH=/snap/core/current/lib/x86_64-linux-gnu/ inside the shell things should be ok15:10
mvoChipaca: -^15:11
mvorbasak: the issue is that bionic ships with libreadline.so.715:11
rbasakChipaca: done, and awk works there, contrary to the git-ubuntu snap for the same core snap revision.15:11
mvorbasak: but the awk on core is from xenial which has libreadline.so.6 and the core awk wants this lib.15:11
greybacksergiusens: hey, any ideas why this is failing? https://pastebin.ubuntu.com/p/hxMjKT6VMM/15:12
mvorbasak, Chipaca I think it is related to --classic so test-snapd-tools is fine15:12
Chipacamy next check was the same but with 'go'15:12
mvoChipaca: \o/15:12
Chipacarbasak: if you could do the same (snap install --classic go && snap run --shell go, and see awk)15:13
mvoChipaca: I'm still struggling to understand why that worked before - actually I thnk I know. before it was a symlink in /etc/alternatives that pointed inside the host fs. now its a relative symlink that points into core15:13
sergiusensgreyback: you are on stable?15:13
rbasakChipaca: also works15:13
greybacksergiusens: yes15:13
mvoChipaca: can of worms15:14
greybacksergiusens: but same on edge and beta15:14
rbasakI'm happy to land any change you recommend into git-ubuntu of course15:14
sergiusensgreyback: we haven't changed stable in weeks15:14
sergiusensgreyback: lxd 3.0?15:14
mvorbasak: thanks and again sorry for the trouble, looking at git-ubuntu now to see what its actually doing15:14
sergiusensgreyback: if you run again, does it work?15:14
greybacksergiusens: 3.5 from the stable snap15:14
greybacksergiusens: no, fails same way. Just tried cleanbuild, also errored out with "snapcraft: not found"15:15
sergiusensgreyback: what happens if you wipe "~/.local/share/snapcraft/projects/lxd/"?15:16
sergiusensI mean, can you wipe that and try again15:16
mvosergiusens: I'm just looking at an issue with a classic snap. the issue is that it uses gawk from xenial which uses libreadline.so.6 but runs (in classic mode) on a bionic with just libreadline.so.7. it looks like snapcraft sets the PATH to the /snap/core/current. should we also set the LD_LIBRARY_PATH to the matching pathes?15:18
zygamvo: I don't think that's safe15:18
zygain general15:19
zygathat impacts more than it should15:19
zygaif you set it other things may break15:19
sergiusensmvo: we never set PATH, I we do not set LD_LIBRARY_PATH15:19
sergiusensbecause of what zyga mentions15:19
sergiusenswe leave it up to the dev15:19
mvosergiusens: aha, so thats a snap specific thing? ok15:19
greybacksergiusens: that seemed to have helped (core and snapcraft snaps installed ok), now fails a bit later https://pastebin.ubuntu.com/p/CR26TgZjgg/ - something not done apt update?15:19
sergiusensif they do not intend to ever shell out or dlopen anything random, it can work15:19
mvorbasak: where is the source of git-ubuntu? I will poke a bit15:20
greybacksergiusens: but I can work with that at least15:20
sergiusensgreyback: you are using tech we really haven't supported at all, but try "snapcraft refresh" then go and build away15:20
greybacksergiusens: ok, what should I use? cleanbuild?15:20
mvozyga: yeah, but right now setting path but not the library path seems inconsistent. i will poke at the snap some more15:20
zygamvo: we don't set the PATH15:21
sergiusensmvo rbasak git-ubuntu shells out a lot, if you add library paths you risk it breaking when calling binaries from the host15:21
zygamvo: not for classic snaps15:21
mvosergiusens: well, its broken right now and I'm looking for a way to unbreak it :)15:22
sergiusensmvo: I cannot say in words on how classic has been my biggest pain for the past two years 🙂15:22
mvosergiusens: amen brother15:22
ogra+115:23
sergiusensI still blame zyga for saying "it's easy" 😉15:23
ogra(or rather +10000)15:23
* greyback holds up his ligher15:23
zygait's all about the context15:23
mvozyga: I was under the misconception that this would be something that snapcraft would do automatically15:23
zygamaking a correct snap is hard15:23
sergiusensyeah, a "Hello world" works fine :-P15:23
* ogra hands out hinges to everyone ... so we can actually do something useful with this can of worms15:24
sergiusensmvo: that's the thing, we crawl all the elf files in the snap and set relative RPATHS all over the place15:24
sergiusensmvo: but not PATH or ld_library_path's15:24
mvosergiusens: makes me wonder if I should do the same for core15:24
rbasakmvo: https://code.launchpad.net/~usd-import-team/usd-importer/+git/usd-importer/+ref/master15:24
rbasakotp15:24
sergiusensmvo: but then dlopen and python ctypes and maybe other things need manual patching still as they all have their own implementation on how to find libraries to load15:25
sergiusensmvo: that would solve problems if it is what is causing a segfault15:25
sergiusensmvo: if I can parse the problem, is rbasak calling a binary in core and it is loading the wrong libraries?15:28
mvosergiusens: correct15:28
sergiusensif that is the case, then elf patching is what you need to do, as a classic snap accessing things from core, makes core essentially classic15:29
mvosergiusens: git-ubuntu is running gawk and because PATH is set its the version from core15:29
mvosergiusens: but gawk does not find its library (libreadline.so.6)15:29
sergiusensmvo: the alternative is, disallow calling binaries from core; and only allow libraries; but then, you run into problems of libraries calling binaries (like you know in apt)15:29
sergiusensand also library behavior when it dlopens15:30
mvosergiusens: hrm, hrm, can of worms15:30
sergiusenswe can also discuss and transform what classic means and require you to bundle all your deps except maybe libc6 or maybe even so, and they become baseless snaps15:30
ograjust fix PATH that $SNAP/bin:$SNAP/usr/bin comes first and ship gawk in the snap15:31
sergiusensogra: what if you call a shell out to an app on the host and the host sees that path and makes you call a binary in the snap instead of the host15:32
sergiusenseverything is solvable, but it is really project specific15:32
ograindeed15:32
mvoyeah, the readline problem is really only {g,n}awk and gpg15:33
sergiusenswe cannot throw out ideas without looking at the actual problem15:33
Chipacamvo: and vi?15:34
sergiusensmvo: if core/bases are to support classic, they probably need to do the right thing when it is not the root15:34
mvoChipaca: unless my script is silly vi on core does not use libreadline15:35
mvoChipaca: but yeah, its all the same issue it just happens to work because most  libs have not changed much15:36
mvosergiusens, Chipaca it sounds like for this particular problem we would need something like LD_LIBRARY_PATH_AFTER_LD_SO_CONF=...15:37
Chipacamvo: ah, i was thinking the other way round, but yeah15:37
sergiusensmvo: but the library path will live on the host or how will you set this up?15:39
mvosergiusens: yeah, there is no such a think right now15:39
mvosergiusens: I mean the problem would be solved with LD_LIBRARY_PATH=$HOST_LIBRARY_PATH_FROM_LD_SO_CONF:/snap/core/current/lib...15:40
* mvo scratches head a bit15:40
sergiusensmvo: but the libreadline from the host will be found first15:41
sergiusensmvo: that works if the host does not have the library15:41
mvosergiusens: thats ok in this particular case15:41
mvosergiusens: yeah this would solve this particular problem15:41
* rbasak is back15:41
sergiusensmvo: heh, that last sentence kind of proves it is not a generic solution15:41
mvosergiusens: heh, no15:41
mvosergiusens: I think there is no general solution there is just too much messiness (as you said, ctypes and friends)15:42
sergiusensmvo: this is what we do for snapcraft as a snap to support ctypes https://github.com/snapcore/snapcraft/blob/master/patches/ctypes_init.diff#L115:43
mvosergiusens: woah, you patch it inside the snap?15:44
sergiusensmvo: yes; ctypes works in a way that it finds libraries by doing an ldconfig -p15:45
sergiusenswhich means it will never pick libs in the snap15:45
sergiusensI need to upstream this in a sort of generic way into cpython15:45
mvorbasak: I have not forgotten you, still poking at this15:58
rbasakNo problem, thanks15:59
mvorbasak: could you please try this low-tech "fix": http://paste.ubuntu.com/p/CZkGWz7dzm/   - snapcraft should patchelf gawk to look into core for its libs (cc sergiusens)16:07
* mvo is off for a bit but will read backlog16:08
sergiusensyeah, bundling gawk in the snap will fix it, certainly will be patched correctly too16:08
sergiusensthis is however, a workaround to the core issue (oh a pun)16:09
* zyga runs one more round of spread and goes to make something warm to drink16:11
zygaChipaca: I did not forget16:11
zygaI think I should just approve it and bikes head separately16:11
roadmryum spread16:11
zygayeah, we should add an RPM package16:12
zygaoh16:12
zygadrat, I forgot opensuse, I got my package in16:12
zygaI need to do some paperwork on ti16:12
zygaon *it16:12
mupPR snapcraft#2312 opened: meta: support relocatable prime for path verification (#2287) <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2312>16:16
rbasakmvo: thanks! I created https://code.launchpad.net/~racb/usd-importer/+git/usd-importer/+merge/355995 so I can get a CI run that will produce a test snap for me. Then I can test the generated snap manually for now. Is my commit message accurate? Separately I'll see about adding a test to ensure gawk works for CI in the future before landing it, but I thought I'd throw your patch at CI now to see if it works.16:19
=== pstolowski is now known as pstolowski|afk
mvorbasak: I will write a followup on this, the commit message is mostly fine - I will suggest some tweaks (after dinner :)16:30
Chipacazyga: *doubt*16:32
zyga;-)16:34
morphismvo: just found an issue where the systemd units generated by snapd for socket activation causes my system to not start NetworkManager on startup: https://forum.snapcraft.io/t/networkmanager-doesnt-start-anymore-on-a-fresh-ubuntu-system-after-installing-the-lxd-snap/766616:35
zygaChipaca: review sent16:35
Chipacawee16:36
zygamorphis: I think we dropped the online target16:36
zygabut we don't update existing units16:36
zygawe don't have code for that yet16:36
morphiszyga: I've installed the system a few hours ago so not sure if these are left over units16:37
zygaChipaca: I revised the second comment16:37
zygamorphis: maybe that's 2.36 material16:37
zygaI recall seeing this land16:37
zygaI think we ought to think about doing that16:38
zygabut not sure how TBH16:38
zygasnapd starts up and decides to rewrite all the systemd units?16:38
morphiszyga: only bad thing about this is that it leaves my system starting up with no network, sounds pretty bad for unattended systems16:38
zygano disagreement16:38
Chipacazyga: what's your nitpick?16:39
mupPR snapd#5901 opened: cmd/snap-update-ns: better detection of snapd-made tmpfs <Created by zyga> <https://github.com/snapcore/snapd/pull/5901>16:39
Chipacazyga: I'm merging, but I can amend the comment in a followup :)16:39
zygaChipaca: it's a placeholder for the eventual nitpick about avoiding O(N^2)16:39
Chipacaah16:39
zygabut please merge16:39
zygait's not a problem now16:39
Chipacazyga: nor ever, because N<=1016:39
zygaChipaca: can I ask you to look at the principal idea behind https://github.com/snapcore/snapd/pull/590116:39
Chipaca:)16:39
mupPR #5901: cmd/snap-update-ns: better detection of snapd-made tmpfs <Created by zyga> <https://github.com/snapcore/snapd/pull/5901>16:39
Chipacamuuurged!16:40
mupPR snapd#5891 closed: snap: give Epoch a CanRead helper <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/5891>16:40
zygathat is use of major:minor numbers16:40
zygafeel free to postpone till tomorrow16:40
zygaChipaca: the primary part of the change is https://github.com/snapcore/snapd/pull/5901/files#diff-4096bdaf9890161ea9c6e277d6ec7291R10016:40
zyga+ the commit message16:40
zygaand what is in the next hunk16:40
zygarest is just tests and furnishing16:41
Chipacazyga: allowed allowed16:43
Chipacahttps://github.com/snapcore/snapd/pull/5901/files#diff-72963e5a6ac9e80f645d1c39c1a670d1R18616:43
mupPR #5901: cmd/snap-update-ns: better detection of snapd-made tmpfs <Created by zyga> <https://github.com/snapcore/snapd/pull/5901>16:43
zygaI shall fix fix16:43
zygathanks!16:43
Chipacawow, there's a lot of allowed allowed16:43
Chipacaa lot == at least 216:43
* Chipaca skips ahead to the meat of the pr16:44
zygacorrected locally16:45
zygaI'll push with any updates16:45
zygamborzecki: I understand why the propagation failed16:46
zygait didn't16:46
zygait was a tricky test16:46
zygaI will explain tomorrow16:46
zygabut the good thing is, there are no bugs :)16:46
zygawell16:46
zygait's still not what people may expect16:46
zygaand we can fix the sorting to perhaps handle that (I alluded to a better sort algorithm)16:46
zygabut it's not propagation16:47
Chipacazyga: which was the syscall that qt started using that they didn't take the patch?16:47
zygastatx16:47
Chipacazyga: ta16:47
Chipacaaw, no manpage on xenial16:47
zygaI'll make tea and see if my wife has any plum cake left16:47
zygaChipaca: http://man7.org/linux/man-pages/man2/statx.2.html16:47
Chipacateo16:48
Chipacata*16:48
Chipacanot sure what i tried to write there16:48
Chipacazyga: when is .dev 0?16:50
* ogra hugs jdstrand 17:00
ograjdstrand, is it whitelisted too ? (i might need a few subsequent changes)17:01
zygare17:02
zygaChipaca: ha, in tests17:02
zygathat warrants a comment :)17:02
zygaI only added it so that we don't mistakenly use zero-valued struct data17:02
Chipacazyga: yeh17:02
Chipacazyga: otherwise, looks very sane17:02
zygaadding now17:02
zygaChipaca: pushed17:06
rbasakmvo: the fix only half works. "gawk" now succeeds, but "awk" does not - since usr/bin/awk isn't provided in the snap (I wonder why)17:06
rbasakmvo: snap binary here: https://jenkins.ubuntu.com/server/view/git-ubuntu/job/git-ubuntu-ci/40/17:07
mupBug #1783772 changed: syslog error msgs when running 'snap list' on disabled daemon snap <Snappy:Fix Released by chipaca> <https://launchpad.net/bugs/1783772>17:07
rbasakChipaca: here's the snap refresh doc thing: https://paste.ubuntu.com/p/3pbYj7F9dQ/17:08
rbasakChipaca: from line 40 I expected refresh --list would work17:08
Chipacarbasak: in what sense does it not work?17:08
rbasak"All snaps up to date." is not a list of available snaps for refresh17:09
Chipacarbasak: or rather: what did you expect it would do?17:09
rbasakI expected it to do what "snap list --all git-ubuntu" does17:09
rbasakShow me the snaps I can refresh to17:09
rbasak(versions)17:09
Chipacarbasak: how does --all show you what you can refresh to?17:09
Chipacai mean, list --all17:09
Chipaca"snap list --all" shows you what you can revert to, if you want17:10
rbasaksudo snap refresh --revision=x1 git-ubuntu17:10
rbasakThat works17:10
Chipacasigh17:11
rbasakHow is "All snaps to date." a list of snaps avialable for refresh?17:11
Chipacarbasak: ok, try this17:11
Chipacarbasak: snap switch core --edge17:11
Chipacarbasak: snap refresh --list17:11
rbasakOh, I see17:11
rbasakSnaps that would refresh if I ask for a refresh with no parameters?17:12
Chipacaor even by name17:12
rbasakI suppose the difference is that I can use refresh to switch channels and suchlike17:12
Chipacaso, clearly the doc needs work17:12
rbasakI probably conflate refresh, revert and switch17:13
rbasakAnd the CLI is happy to do what I mean17:13
Chipaca"List snaps that would be updated on the next refresh"?17:13
rbasakBut that leads to confusion in understanding the docs17:13
Chipacarbasak: conflating revert and refresh will lose you data :-/17:13
Chipaca(per-revision data is assumed bad on revert, and left alone, whereas on refresh it's copied along)17:14
Chipacarevert is "omg these idiots broke it"17:15
rbasakThe problem with revert is that it's a one time thing17:15
rbasakIt's not necessarily obvious when it broke17:15
rbasakIt might have been multiple refreshes ago17:15
rbasakOr at least it _seems_ like a one time thing to me17:15
Chipacayes, the revert story isn't complete without health checks17:15
Chipaca(those are coming!)17:15
rbasakWhereas normally I end up having to "hunt" to get back to something working, as I don't necessarily know when it broke; rather all I have is a reproducer17:16
* Chipaca nods17:16
Chipacawhich ties in with xnox's argument about foundations having to keep a copy of every revision of every snap ever17:16
zygaChipaca: just share it on facebook17:17
rbasakAnyway, thank you for helping me understand better what I'm doing17:17
ChipacaI mean, I'm still not sure I agree, but I can see where he's coming from17:17
Chipacarbasak: no problem! thank you for pointing out where things are unclear / surprising17:17
rbasakWe keep a copy of every deb we published ever. It's particular useful when debugging broken upgrade paths, etc.17:18
rbasaksnap refresh --list git-ubuntu17:19
rbasakAll snaps up to date.17:19
zygahmm?17:20
zygarbasak: what were you hoping to see?17:20
zygarbasak: note that the store keeps a copy of every revision17:20
rbasakPerhaps this is the particular case that's confusing? "All" doesn't make sense here. "This snap is up to date." would perhaps be clearer in hinting to me what the command actually does.17:20
Chipacammmm17:20
Chipacathis one might be even more interesting17:20
rbasakHard to translate possibly though17:20
rbasak(for i8n etc)17:20
Chipacarbasak: if --list is given, the argument is ignored completely17:21
ChipacaI'd posit that that's a bug :-)17:21
rbasakAh. Yes :)17:21
Chipacaeither error, or filter17:21
Chipacahmmm hmmm17:21
Chipacai'll error for now (making it filter would be either client-side (ew), or a lot of work on the daemon (ugh))17:24
ChipacaTBF --list is one of the weird ones that we're pretty sure doesn't "go" there (like --times), but we haven't found the right place yet17:27
Chipacarbasak: are you rbasak on github as well?17:34
rbasakChipaca: no, "basak"17:35
Chipacak17:35
rbasakChipaca: how about --dry-run or similar, instead of --list?17:36
rbasakThe same information, but from a "what I would do" perspective which is easier semantically I think since that concept is pretty common rather than being snap-specific.17:37
Chipacarbasak: I'm used to --dry-run and it feels more natural to me, but the output would be wrong (unless refresh did the same)17:37
Chipaca… or does it17:37
* Chipaca hasn't looked at 'refresh' in a while :)17:37
rbasakI don't expect --dry-run to produce exactly the same output17:37
rbasakBut I understand why others might17:37
ChipacaI like rename's behaviour of --dry-run being --verbose17:39
ChipacaOTOH, we _could_ write a --dry-run that just printed nearly the same as a plain refresh, but with "would be updated" instead of "updated"17:39
Chipacaer, refreshed17:39
Chipacacore (edge) 16-2.35.2+git954.b1b6b89 from Canonical✓ available for refresh17:40
Chipacathat sort of thing17:40
Chipacaall the info you want is there17:40
Chipacahmm17:40
Chipacaniemeyer: you around?17:40
mupPR snapd#5902 opened: cmd/snap: tweak UX of snap refresh --list <Created by chipaca> <https://github.com/snapcore/snapd/pull/5902>17:41
Chipacarbasak: ^17:41
rbasakThanks!17:42
Chipacaniemeyer: what do you think of moving from 'snap refresh --list' with its 'snap list'-like output (that's slightly alien-feeling),  to a 'snap refresh --download' that would print summaries very similar to what 'snap refresh' actually does?17:43
Chipacaer17:44
Chipacaer17:44
Chipacaniemeyer: snap refresh --dry-run17:44
Chipacabrain fart there17:44
Chipacaclearly i should eod17:44
mvorbasak: does https://forum.snapcraft.io/t/git-ubuntu-issue-with-core-2-35-2/7668 clarify things? I tried to summarize the issue we hit, I hope this also answers your question in the commit messages17:53
niemeyerChipaca: No problem, happy to help-by-listening :)17:54
Chipacaniemeyer: question stands though :-)17:55
Chipacaniemeyer: 'snap refresh --list' is a bit weird, why isn't it 'snap refresh --dry-run'?17:55
mvorbasak: re gawk> awk is "special" in that it does not ship a awk binary but only a postrm script that uses update-alternatives. let me look into this again17:56
mvorbasak: I pushed an alternative PR18:02
rbasakmvo: thanks! Will read.18:03
mvorbasak: let me know if anything is unclear, its an unfortunate combination of classic, update-alternatives etc18:11
rbasakmvo: that's clear, thanks. I need to EOD now. I'll resume tomorrow. Meanwhile your branch/MP is building a test snap  in CI.18:17
jdstrandogra: part of it has a snap decl. the other part is committed in the review-tools but is not in prod yet18:19
jdstrandroadmr: hi! at whatever time is convenient, can you pull r1131?18:19
mvorbasak: ta18:27
mvorbasak: enjoy your eod18:27
mupPR core-build#11 closed: remove cruft from the writable-paths <Created by mvo5> <https://github.com/snapcore/core-build/pull/11>18:30
mupPR core-build#22 closed: unit testing for sync_dir() <Created by mvo5> <https://github.com/snapcore/core-build/pull/22>18:30
mupPR core-build#26 closed: move most of the customization into the core snap build <Created by mvo5> <https://github.com/snapcore/core-build/pull/26>18:30
mupPR core-build#11 opened: remove cruft from the writable-paths <Created by mvo5> <https://github.com/snapcore/core-build/pull/11>18:31
mupPR core-build#22 opened: unit testing for sync_dir() <Created by mvo5> <https://github.com/snapcore/core-build/pull/22>18:31
mupPR core-build#26 opened: move most of the customization into the core snap build <Created by mvo5> <https://github.com/snapcore/core-build/pull/26>18:31
mupPR snapcraft#2311 closed: snap: legacy needs to now it is legacy for re-exec <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2311>18:43
zygare19:08
roadmrjdstrand: sure thing19:09
zygajdstrand: hey19:10
zygajdstrand: I have two pings for you: one is a quick look on a "input" trigger on udev on an upcoming interface: https://github.com/snapcore/snapd/pull/589719:10
mupPR #5897: interfaces/builtin: add gpio-keys interface for accessing events <Created by bergotorino> <https://github.com/snapcore/snapd/pull/5897>19:10
zygajdstrand: and another is extension of the tmpfs detector for sub-directory support https://github.com/snapcore/snapd/pull/590119:11
mupPR #5901: cmd/snap-update-ns: better detection of snapd-made tmpfs <Created by zyga> <https://github.com/snapcore/snapd/pull/5901>19:11
zyganothing urgent19:11
zygajdstrand: the detector is mostly test changes, look at the non-test part of the patch to see what the interesting thing is, I also tried to make the commit message as useful as I could19:11
zygathat's all, enjoy your work on the road19:12
zygaError: GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: Type of message, '(ssssa{ss})', does not match expected type '(sssa{sv}a{ss})'19:14
zygaanother case of that19:14
zygawell, for tomorrow19:14
* zyga EODs19:14
mupPR snapcraft#2312 closed: meta: support relocatable prime for path verification (#2287) <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2312>19:58
mupPR snapcraft#2305 closed: [legacy] pluginhandler: update build should overwrite organize <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2305>20:01
mupPR snapcraft#2313 opened: meta: link the icon correctly across filesystems <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2313>20:25
sergiusensSaviq: want to give that a review? ^20:26
koala_manwhat are my options if I'm unable to reproduce a build failure locally?20:27
ograkoala_man, how do you not reproduce it locally ? ... did you use snapcraft cleanbuild to do so ?21:00
koala_manYes. Is the intention that this type of build uses the same kinds of http proxies?21:01
ograno, the intention is that you use the same container setup the builders use21:04
ogranot necessarily the proxies21:04
ogradoes your build fail with a proxy error ?21:04
koala_manit fails on 'cabal update' which is supposed to download an index of haskell packages21:05
koala_manI'm not sure how to debug it since it works locally, or how to try any random suggestions without pushing junk commits21:09
ograopen a forum thread and attach a build log (or a link to a pastebin with a build log)21:10
ogra(see the topic for the forum link)21:11
ograif it locally also works when using snapcraft cleanbuild, there is surely somthign wrong21:11
ogratypically cleanbuild shows the same errors as the builders and most of the time this points to some missing build-packages entry ... i.e. if you would download something using wget during your build but did not define wget in your build-packages it will fail in cleanbuild21:17
ograor on the build host21:17
ograbut it wouldnt fail on your desktop because you have wget already installed21:18
ograthis is why i initially asked if you tried cleanbuild21:18
cjwatsonmaybe cabal doesn't honour the usual proxy environment variables21:28
koala_manIt does. I googled it for a while and found some misc older bugs, but nothing concrete and it's hard to test anything21:31
cjwatsondo you have a link to a failing build?21:31
koala_manhere's one with cabal update -v3: https://build.snapcraft.io/user/koalaman/shellcheck/34508621:32
koala_manat least I think that's the failing command.21:33
cjwatsonhttps://launchpadlibrarian.net/391408584/buildlog_snap_ubuntu_xenial_amd64_0dfd7b5345eb70630bdf6240b06280c5-xenial_BUILDING.txt.gz <- direct link21:36
cjwatsonkoala_man: Could you please file a bug on https://bugs.launchpad.net/launchpad-buildd about that?  Not something I've seen before.21:37
koala_mansure21:38
cjwatsonCertainly something odd there, as it claims to be sending GET http://hackage.haskell.org/packages/index.tar.gz but there's no corresponding log message from the internal proxy.21:40
cjwatsonNor from the backend proxy (in our private logs).21:42
cjwatsonChances are it's a bug in the internal proxy in launchpad-buildd, since that's the least well-tested code involved, but it's a surprise that this is the first place I've seen it.21:44
cjwatsonLooks very reproducible given the appropriate setup though, so that'll help.21:45
mupPR snapd#5903 opened: overlord/snapshotstate: store epoch in snapshot, check on restore <Created by chipaca> <https://github.com/snapcore/snapd/pull/5903>23:29
=== genii is now known as Barista

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!