=== JanC_ is now known as JanC
=== JanC is now known as Guest80969
[05:42] <didrocks> good morning
[05:43] <duflu> Morning didrocks
[05:51] <didrocks> hey duflu
[06:00] <jamesh> hi didrocks
[06:03] <didrocks> hey jamesh
[06:03] <didrocks> happy Friday
[06:05] <jamesh> didrocks: I'
[06:05] <jamesh> ve got a snapped GTK 2 app displaying with Yaru: https://forum.snapcraft.io/t/improving-theme-support-for-gtk-2-apps/7693
[06:05] <jamesh> without just copying Yaru theme data into the snap
[06:09] <oSoMoN> good morning desktoppers
[06:13] <didrocks> jamesh: I think the Yaru CI would need some help from you thus to publish the gtk2 variant there (or we can say we don't really care and do regular snapshot on your side)
[06:13] <didrocks> jamesh: ah, "without copying"? how come?
[06:13] <didrocks> hey oSoMoN
[06:14] <didrocks> ah, you wrote more on the thread apparently, you linked to first post that I've read yesterday already :p
[06:14] <jamesh> didrocks: we're creating a gtk2-common-themes snap
[06:14] <jamesh> so I guess we are copying it: just not into the application snap
[06:14] <oSoMoN> salut didrocks, hey jamesh
[06:15] <didrocks> ok, I was puzzled by your "without just copying" :)
[06:15] <didrocks> jamesh: sounds good, you are doing regular snapshot to pick latest Yaru? I wonder if the CI shouldn't be the same than for gtk-common-themes
[06:15] <didrocks> (for any takers…)
[06:16] <jamesh> didrocks: kenvandine set up CI for it here: https://gitlab.gnome.org/Community/Ubuntu/gtk2-common-themes
[06:17] <jamesh> so it is similar to gtk-common-themes
[06:17] <didrocks> jamesh: well, Yaru is building and refreshing gtk-common-themes
[06:18] <didrocks> and it's also creating per PR-snap
[06:18] <didrocks> I doubt you have that already :p
[06:18] <didrocks> (as this is done Yaru-side)
[06:18] <jamesh> ah
[06:19] <didrocks> also, with this split (not shipping gtk2 in gtk-common-themes), I'm pretty sure the Yaru CI reinjects it
[06:19] <didrocks> maybe something that Ken is going to look at?
[06:20] <jamesh> didrocks: the main reason for having a second snap is that gtk-common-themes is arch independent, while gtk2-common-themes can't be
[06:21] <jamesh> although perhaps another option would be to only separate the engines into the arch dependent snap
[06:21] <didrocks> jamesh: yeah, I guess that's fine, but we need to coordonate to ensure that there is no side-effects, like the CI
[06:21] <didrocks> hum, not  bad idea
[06:21] <didrocks> jamesh: I actually prefer that one, if possible at all
[06:21] <didrocks> that way, all assets are in a single place
[06:22] <didrocks> do you think this would be easily feasible? (I think you then need to have 2 connections)
[06:22] <didrocks> (especially as the engines are reused between a lot of themes…)
[06:26] <jamesh> it'd definitely be possible.  We're not locked into anything yet
[06:26] <jamesh> and it would probably simplify things overall.
[06:26] <didrocks> yeah, I'm thinking about "always connect this theme interface" + that one if you are gtk2
[06:26] <didrocks> maybe it's a better story
[06:27] <didrocks> (developer side, ofc, once the autoconnect is done)
[06:29] <jamesh> the gtk2-common-themes is currently 280K, with about half of that being the engines
[06:30] <jamesh> so moving the theme data to gtk-common-themes would be lost in the noise, given all the icon themes.
[06:33] <didrocks> yeah, I think that really makes sense
[06:59] <jamesh> didrocks: Ken also mentioned that snaps using xenial's GTK looked bad under Yaru.  I guess that'd require backporting the theme to GTK 3.18 though :(
[07:01] <RAOF> willcooke: Oh, extra datapoint for logspam not being colord's fault - starting `simple-scan` from the terminal *also* dumps a bunch of SNMP garbage to the console.
[07:46] <duflu> <RAOF> willcooke: Oh, extra datapoint for logspam not being colord's fault - starting `simple-scan` from the terminal *also* dumps a bunch of SNMP garbage to the console.
[07:46] <duflu> Morning willcooke
[07:47] <duflu> And morning seb128
[07:49] <willcooke> hi duflu, thanks
[07:50] <willcooke> duflu, any further discussion on the mozjs issue?
[07:55] <duflu> willcooke, I have a couple now. But the regression, no.
[07:55] <duflu> I am ignoring it.
[07:55] <duflu> gnome-shell (master) seems to crash a lot more now, so waiting for proper bug reports from release binaries to verify it's true
[07:56] <duflu> Mine is running from git so isn't technically a proper Ubuntu bug report
[07:57] <seb128> good morning desktopers
[07:57] <seb128> hey duflu willcooke
[07:58] <duflu> willcooke, on the upside, Gnome guys were surprised and taunting me for how old our gjs/mozjs was. So we can better coordinate bugs with them now
[08:00] <duflu> Now guys, but one guy recently
[08:00] <duflu> -Now +Not
[08:00] <duflu> Sigh. Weekend in 2h
[08:03]  * Laney nod
[08:03] <popey> Good morning
[08:03] <duflu> Hi Laney, popey
[08:03] <seb128> hey Laney
[08:03] <seb128> duflu, we don't have much choice that keeping up with mozjs update for security reasons (same as firefox & co)
[08:04] <seb128> it's unfortunate that the update landed so late yet
[08:04] <seb128> but there is little we could do to change that
[08:04] <duflu> seb128, yeah I read your email saying that simultaneously to your IRC notification :)
[08:04] <seb128> :)
[08:04] <duflu> biab
[08:05] <seb128> Trevinho, Laney, bug #1796238 is a new from the mozjs update, just as a fyi, I tagged as rls-cc-incoming so we review it next week
[08:05] <ubot5> bug 1796238 in mozjs60 (Ubuntu) "[regression] mozjs60 crashes with SIGSEGV on gnome-shell exit, in GetPropertyOperation() from Interpret() from js::RunScript()" [Undecided,Incomplete] https://launchpad.net/bugs/1796238
[08:08] <seb128> didrocks, we had language-selector not prompting to install extras if opened on a new install for "main" locales in bionic right? I did a cosmic daily install yesterday and opening it prompted to install those, https://paste.ubuntu.com/p/3vSDjSsXpw/
[08:08] <seb128> that looks like a regression right?
[08:08] <Laney> ok, is it forwarded?
[08:08] <seb128> duflu, ^
[08:25] <willcooke> duflu, fyi, t_jaalton has a new libinput for cosmic too
[08:25] <duflu> Not forwarded. I'm seeing a few new crashes and don't have time/interest to log them all today. They may be unique to me using git master. If not then wait and see what errors.ubuntu.com says starting next week
[08:37] <Trevinho> Ok I see if can be reproduced here. Andrea had an isauw with --replace, not sure is the same
[08:38] <Trevinho> In case duflu do you have a bt full too?
[08:39] <duflu> Trevinho, no I deleted the core and have had many more since (mostly from using gnome-shell, not shutdown)
[08:41] <duflu> Trevinho, there are some other new issues in 18.10 if you're interested... https://errors.ubuntu.com/?release=Ubuntu 18.10&package=gnome-shell&period=week
[08:41] <duflu> https://errors.ubuntu.com/?release=Ubuntu%2018.10&package=gnome-shell&period=week
[08:43] <Laney> I'm going to upload the gjs point release today, so you might want to wait and see if that makes any difference
[08:46] <duflu> I'm now using gjs master (after the problems started) because I need to make further changes
[08:46] <duflu> And master is crashing too
[08:47] <Laney> I'm really talking about errors.ubuntu.com
=== upmine is now known as niko
[08:56] <jibel> oSoMoN, https://code.launchpad.net/~fitojb/ubiquity-slideshow-ubuntu/logo-refresh/+merge/353025 has already been merged. Can you submit another MP with the updated icons?
[09:38] <willcooke> Laney, is your n-m fix in the new iso?  It seems to be a lot better
[09:38] <willcooke> but might be luck
[09:39] <jibel> willcooke, it's luck
[09:40] <jibel> 1.12.2 is still on the image
[09:42] <Laney> it's in the pending one
[09:42] <jibel> ah sorry, I was looking at currnet
[09:43] <Laney> np
[09:46] <willcooke> woot, thanks Laney
[09:46] <willcooke> it does seem better
[09:48] <Laney> that's good
[10:09] <andyrock> Trevinho: duflu does not looks the same crash I'm getting as I still run mozjs52
[10:41] <Trevinho> ah, ok
[10:42] <Trevinho> duflu: I'm on https://launchpad.net/bugs/1422253 well one case for that, I've a reproducer and debugged everything. Need to decide the strategy though :)
[10:42] <ubot5> Ubuntu bug 1422253 in mutter (Ubuntu Bionic) "gnome-shell crashed with SIGABRT in g_assertion_message("assertion failed: (window->display->focus_window != window)") from g_assertion_message_expr() from meta_window_unmanage() from handle_other_xevent()" [High,Fix released]
[10:43] <duflu> Trevinho, I suggest using the newer bug. So we are not seen to be closing the same one twice
[10:43] <Trevinho> duflu: yeah I just linked the one pointed by e.u.c, but I'm using the new one indeed
[10:43] <Trevinho> just it was the fast link on that page
[11:00] <duflu> Well I'm now overdue for dinner. Night Trevinho. Although you might like these: https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/253 and https://gitlab.gnome.org/GNOME/gjs/merge_requests/236
[11:02] <oSoMoN> jibel, https://code.launchpad.net/~osomon/ubiquity-slideshow-ubuntu/libreoffice-icons-update/+merge/356186
[11:03] <duflu> Laney, if you are updating gjs then try !236
[12:29] <Laney> are ubuntu-session/gnome-session binary packages Arch: any only because of the [linux-any] restriction on xwayland?
[12:39] <Laney> i.e. does https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-session/commit/?id=b0c8f8d0be82c81c3b883556fbaf1d8519115228 make sense?
[12:52] <Laney> bueller
[12:56] <willcooke> Laney, seb is on the road atm, he'll be back in a couple of hours
[12:58] <didrocks> I think it was due to the restrction on xwayland, but IIRC, it's jbicha who did this
[12:59] <didrocks> Laney: for consistency, missing comma on xwayland as you did below, mind doing it? :)
[12:59] <didrocks> #consistency
[13:00]  * Laney feels nitpicked, but ok
[13:00] <didrocks> trailing comma is a real passion of mine :)
[13:00] <didrocks> thx!
[13:01] <Laney> weird passion
[13:01] <Laney> :-)
[13:01] <Laney> anyway if there is any feedback on the actual thing I asked I would like to hear it
[13:01] <didrocks> less diff in future commits :)
[13:01] <didrocks> well, I linked jbicha, that's the best I can do
[13:01] <Laney> yes
[13:04]  * Laney tries to remember how to make bileto run proposed-migration
[13:05] <Laney> Lander Signoff I think
=== chiluk_ is now known as chiluk
[14:40] <seb128> good afternoon desktopers
[14:40] <willcooke> hey seb128
[14:40] <seb128> hey willcooke
[14:40] <seb128> how is the day going around here?
[14:40] <willcooke> Been quiet
[14:41] <willcooke> Laney's n-m fix has made things a lot better for me
[14:41] <oSoMoN> hey seb128
[14:41] <seb128> hey oSoMoN
[14:42] <didrocks> seb128: how was the road?
[14:42] <seb128> uneventfull
[14:42] <oSoMoN> looking forward to the week-end, going to a local microbrewery for dinner, but I've got plenty of things to wrap up before that can happen
[14:42] <seb128> a bit of traffic but not being stopped/blocked
[14:42] <didrocks> seb128: on your langpack/additional languages questions. Indeed, on 16.04, we had no prompt for every languages by default on the iso
[14:42] <didrocks> good :)
[14:42] <seb128> oSoMoN, ah, nice, enjoy!
[14:43] <seb128> didrocks, oh, it was 16.04, not 18.04?
[14:43] <didrocks> seb128: yeah, time flies :)
[14:43]  * didrocks can find the email, maybe
=== Class7_ is now known as Class7
[14:44] <seb128> "Default languages strategy for Ubuntu desktop CD" on ubuntu-devel
[14:44] <didrocks> https://lists.ubuntu.com/archives/ubuntu-devel/2015-December/039028.html
[14:44] <seb128> from 2015
[14:44] <didrocks> yep
[14:44] <didrocks> ;)
[14:44] <didrocks> so 16.04
[14:45] <seb128> I guess it was already regressed in bionic
[14:45] <seb128> what happens when you don't have tests :/
[14:45] <didrocks> could be, I don't think anybody looked at it
[14:45] <didrocks> yeah, when we don't have test infra for this…
[14:47] <didrocks> seb128: you only installed in english, not french?
[14:48] <didrocks> (at least, you could install, unlike me in my qemu :p)
[14:48] <seb128> didrocks, that was a french install, so I guess the french part was correctly installed
[14:49] <didrocks> seb128: this is weird, hunspell-en-ca is part of the seed
[14:49] <Laney> iso tracker test for that would be good meanwhile
[14:49] <seb128> right
[14:50] <didrocks> they are all listed
[14:51] <didrocks> so, could be ubiquity regressed and remove them?
[14:51]  * didrocks looks at the manifest
[14:52] <didrocks> yeah, they are seeded
[14:52] <didrocks> which was the change I did
[14:52] <didrocks> (at the time)
[14:53] <didrocks> so, ubiquity seems to remove them for $reason
[14:54] <seb128> or maybe my install/testing was buggy in some way
[14:54] <seb128> I'm going to look again next time I do an install
[14:54] <didrocks> yeah, I would be surprised if this was a buggy testing though
[14:55] <didrocks> so, some logic should have changed somewhere
[16:04] <k_alam> seb123: Hi, regarding this https://code.launchpad.net/~madsrh/ubiquity-slideshow-ubuntu/Yaru-CSS/+merge/355913 Can you accept a merge proposal for Ambiance like the flavor does, even if unity is not an official flavor? Unity still use Ambiance.
[16:05] <seb128> k_alam, I guess that was for me?
[16:06] <k_alam> Ah, yes.
[16:06] <seb128> sure; submit it and I can review
[16:06] <k_alam> Thanks.
[16:08] <jbicha> Laney: yes, xwayland is why those packages were any instead of all
=== pstolowski is now known as pstolowski|afk
[16:09] <Laney> hi jbicha
[16:09] <Laney> I'm going to upload that then
[17:10] <oSoMoN> have a good week-end everyone!
[17:14] <willcooke> Trevinho, still around?  Do you have a link to that Electron bug that hardcoded some Unity 7 reference for appindicators
[17:16] <didrocks> I have the fix I pushed
[17:16] <didrocks> but should be release since then
[17:16] <didrocks> willcooke: that was fixed in https://github.com/electron/electron/pull/12844
[17:17] <didrocks> automatically backported to Electron 2 via https://github.com/electron/electron/pull/12964
[17:17] <willcooke> thanks didrocks
[17:18] <willcooke> didrocks, there was a specific appindicator issue as well I think
[17:18] <willcooke> do you remember that one?
[17:18] <willcooke> it was more recently?
[17:19] <didrocks> I think Trevinho wanted to avoid the hardcoded list
[17:19] <kenvandine> yeah
[17:19] <didrocks> but this at least make the appindicator working with electron apps on ubuntu
[17:20] <didrocks> (anything that has "ubuntu" in XDG_CURRENT_DESKTOP: https://github.com/electron/electron/pull/12844/files#diff-c43192418c9f922db7cce8d28487445dR175)
[17:21] <didrocks> ofc upstream needs to build with a recent even electron version (one with that fix)
[17:21] <didrocks> but given it's been release in May, I think most of them have
[17:22] <kenvandine> didrocks: i think the question here is for non-ubuntu distributions
[17:23] <kenvandine> maybe dropping the hard coded list improves that
[17:23] <kenvandine> not dropping
[17:23] <kenvandine> but resolving it programmatically
[17:24] <didrocks> ah, for non ubuntu but which have appindicator, is there any apart from people installing the extension manually?
[17:24] <didrocks> isn't that niche?
[17:24] <kenvandine> yeah
[17:41] <willcooke> I seem to remember something about Unity being checked for specifically
[17:41] <willcooke> oh, he's gone :)
[17:41] <willcooke> about time too didrocks :)
[17:43] <kenvandine> yes
[17:44] <kenvandine> i ping marco on telegram
[17:45] <kenvandine> waiting for a reply
[17:45] <kenvandine> i'm about ready to hit send on this message :)
[17:47] <Trevinho> willcooke: I'm here
[17:47] <kenvandine> Trevinho: hey!
[17:47] <kenvandine> didn't you have another electron fix related to appindicators?
[17:47] <Trevinho> So... No I've not a bug. But I wanted to do it
[17:48] <kenvandine> i see
[17:48] <kenvandine> ok
[17:48] <Trevinho> Problem is that IIRC the part to touch was somewhere inside libchormium
[17:48] <Trevinho> But need to check as they changed things a bit recently
[17:48] <kenvandine> ok
[17:49] <Trevinho> Ideally we should just check the presency of a dbus name and call a version method
[17:50] <Trevinho> Something I've in my brain for a while, but never had the time.
[17:50] <Trevinho> Together with supporting launcher emblems
[17:50] <kenvandine> Trevinho: is this something that could help our snaps on other distros?
[17:50] <kenvandine> i guess of course :)
[17:50] <kenvandine> if the extension is available, it would use it
[17:57] <seb128> have a nice w.e desktopers!
[17:58] <Trevinho> kenvandine: yep that's the point
[17:59] <Trevinho> Although one task should also done is a semplificaton of the whole protocol
[18:00] <Trevinho> There were already proposals... With the usage of gmenumodel
[18:00] <willcooke> I wonder if this is what I was thinking of:  https://github.com/electron/electron/commit/dc43dc2a1316d5f96e1c3a9cf6079c4150214f66
[18:03] <Trevinho> Indeed my comment still applies 😅
[18:07] <willcooke> :)
[18:20] <kenvandine> Trevinho: thanks
[18:21] <Trevinho> willcooke: I can allocate some time for that if you and seb are fine, let me know
[18:22] <kenvandine> Trevinho: we'll let you know, that isn't a high priority right now
[18:22] <kenvandine> but might change
[18:27] <willcooke> oh
[18:27] <willcooke> sorry missed the ping
[18:27] <willcooke> thanks Trevinho
[18:28] <willcooke> yeah, dont worry
[19:22] <andyrock> kenvandine:
[19:23] <andyrock> evince from snap does not show the desktop icon
[19:23] <andyrock> is this a known issue?
[19:24] <kenvandine> No... Which theme?
[19:24] <andyrock> ambiance
[19:24] <kenvandine> On 18.04?
[19:24] <andyrock> yep
[19:24] <kenvandine> I'll look into it
[19:25] <andyrock> thx!
[20:39] <kenvandine> andyrock: sigh... yaru provides org.gnome.Evince but humanity doesn't
[20:40] <kenvandine> this application icon situation is terrible
[20:40] <kenvandine> if we want to use themed icons, we need the icon name to be stable
[20:40] <kenvandine> upstream renaming them has screwed things up :(