[01:44] <CarlenWhite> I guess my laptop had a brief moment where it broke the laws of physics and what today's radio could do by having a brief moment where it exceeded 5Gbps.
[06:50] <oSoMoN> good morning desktoppers
[06:52] <duflu> Morning oSoMoN
[06:56] <oSoMoN> hey duflu
[07:19] <didrocks> good morning
[07:28] <oSoMoN> salut didrocks
[07:28] <didrocks> hey oSoMoN
[07:39] <seb128> lut didrocks oSoMoN
[07:39] <seb128> hey duflu
[07:39] <seb128> how are you today?
[07:40] <duflu> Hi seb128. Going well. You?
[07:40] <oSoMoN> salut seb128
[07:40] <seb128> duflu, I'm good!
[07:41] <seb128> could have slept a bit longer, 6:30am :/
[07:41] <duflu> That's not great
[07:41] <seb128> well at least I had emails/backlog done and baby ready to go by 8am
[07:42] <didrocks> hey seb128
[07:42] <seb128> lut didrocks
[07:51] <clobrano> morning all 0/
[07:52] <didrocks> hey clobrano! :)
[07:53] <didrocks> feeling better? No secondary effect from your back surgery?
[07:54] <clobrano> hey didrocks, still full of painkillers :D but I should be fine
[07:54] <didrocks> sounds like everything went fine, great!
[07:55] <willcooke> morning
[07:58] <duflu> Morning willcooke
[07:58] <clobrano> :)
[07:58] <duflu> Morning Class7
[07:58] <duflu> Argh
[07:58] <duflu> Morning clobrano
[07:58] <clobrano> hi duflu
[08:03] <Laney> greetings
[08:05] <didrocks> hey willcooke, Laney
[08:06] <didrocks> clobrano: on my question for the MP, master will release a snap for bionic, so it will end up in bionic as well
[08:06] <didrocks> clobrano: but is this variable read by the bionic version of the dock?
[08:07] <willcooke> damn it, I can't find an actual bug number for the virtualbox issue.  Anyone got any clues? (tjaalton perhaps?)
[08:08] <seb128> hey willcooke, Laney, how is your side of the channel today?
[08:08] <willcooke> hey seb128, quite sunny today \o/
[08:08] <willcooke> The omnipresent grey clouds of Brexit are on the horizon though
[08:08] <willcooke> oh, I made myself sad.
[08:09] <tjaalton> willcooke: bug 1796056
[08:09] <tjaalton> which I can't repro anymore
[08:09] <willcooke> tjaalton, ah, I found that one, but I didnt think it was the right thing.  Since, yeah, it doesnt crash now , but the display is all messed up still
[08:09] <willcooke> should I log a new bug for that one?
[08:10] <seb128> bug #1792932 was the previous week one
[08:10] <tjaalton> willcooke: install updates and check again
[08:10] <tjaalton> with latest kernel vboxvideo.ko is loaded before X is starte
[08:10] <tjaalton> d
[08:12] <Laney> hey didrocks seb128
[08:13] <seb128> tjaalton, do you know what changed? is that a fix or luck?
[08:13] <willcooke> tjaalton, well this is for the live cd - so I should try with a new ISO right?  The one I tried from yesterday morning was still b0rked
[08:14] <tjaalton> seb128: I don't, dozens of updates via 4.18.x
[08:15] <tjaalton> willcooke: ok, so it's not the same then, I was testing with an installed system which this bug was about (regression of the xserver update)
[08:15] <clobrano> didrocks: that's correct, unfortunately. I am not aware of any way to limit the scope of the variable to a specific dock version
[08:15] <willcooke> tjaalton, ok, I will log a new one
[08:15] <willcooke> thanks
[08:16] <Laney> the pending ISO works for me in vbox
[08:18] <didrocks> clobrano: well, we already changed the panel as well, I don't think changing the dock color in bionic is a biggy, it will match as well the panel that way, wdyt?
[08:19] <willcooke> Laney, super!  Downloading and testing....
[08:21] <clobrano> didrocks: I agree. If we ship this in both, cosmic will have the same transparency for panel and dock, while in bionic the dock will be more transparent. Which is way better that having the dock darker like it is now in cosmic with master
[08:23] <didrocks> clobrano: ok, let's do this then :)
[08:23] <clobrano> didrocks: I'll update the PR title
[08:23] <didrocks> thx! let me merge it then
[08:24] <willcooke> Laney, you don't see this?  https://imgur.com/a/rkTId4S
[08:24] <Laney> no
[08:25] <willcooke> Laney, you're running vbox on Cosmic I assume?  (I'm running it on Bionic)
[08:25] <didrocks> clobrano: thanks a lot :)
[08:25] <Laney> that's correct
[08:25] <clobrano> didrocks: yw
[08:26] <willcooke> jibel, can you reproduce this on Bionic running virtualbox, installing cosmic in to a VM: https://imgur.com/a/rkTId4S
[08:26] <Laney> willcooke: is it 100% of the time for you?
[08:26] <willcooke> Laney, yeah
[08:26] <tjaalton> still?
[08:26] <Laney> ho hum
[08:26] <Laney> let me try again
[08:26] <willcooke> yeah, that's with the ISO from this morning
[08:27] <Laney> there's a kernel in *proposed*, dunno if that is what tjaalton was trying with
[08:27] <tjaalton> I installed on a bionic host with an older image from last week and had no such thing
[08:27] <willcooke> tjaalton, did you say  you were running Vbox from upstream?
[08:27] <tjaalton> though it did suffer from the old bug which also required nomodeset..
[08:28] <tjaalton> no, stock distro
[08:28] <tjaalton> once the system is done upgrading I'll try with a current image
[08:28] <willcooke> tjaalton, thx!
[08:29] <tjaalton> willcooke: go to the terminal and check 'dmesg|grep vboxvideo'
[08:29] <tjaalton> check the timestamp
[08:29] <tjaalton> compare to /var/log/Xorg.0.log
[08:31] <willcooke> tjaalton, switching vts gets restores the screen to normal.  Is that going to have messed the logs up?
[08:32] <tjaalton> no
[08:33] <willcooke> xorg log: https://paste.ubuntu.com/p/kgYWct2QP2/
[08:33] <willcooke> dmesg: https://paste.ubuntu.com/p/fbXBC64yHz/
[08:33] <willcooke> [   14.762240] vboxvideo: module is from the staging directory, the quality is unknown, you have been warned.
[08:33] <willcooke> [   14.762271] vboxvideo: module verification failed: signature and/or required key missing - tainting kernel
[08:33] <willcooke> [   14.774141] [drm] VRAM 01800000
[08:33] <willcooke> [   14.789234] [TTM] Zone  kernel: Available graphics memory: 743060 kiB
[08:33] <willcooke> [   14.789235] [TTM] Initializing pool allocator
[08:33] <willcooke> [   14.789238] [TTM] Initializing DMA pool allocator
[08:33] <willcooke> [   14.860361] fbcon: vboxdrmfb (fb0) is primary device
[08:33] <willcooke> [   14.860441] Console: switching to colour frame buffer device 100x37
[08:33] <willcooke> [   14.860446] vboxvideo 0000:00:02.0: fb0: vboxdrmfb frame buffer device
[08:33] <willcooke> [   14.860458] [drm] Initialized vboxvideo 1.0.0 20130823 for 0000:00:02.0 on minor 0
[08:33] <willcooke> vs
[08:33] <willcooke> [    14.592]
[08:34] <willcooke> X.Org X Server 1.20.1
[08:34] <tjaalton> so unlucky :P
[08:34] <willcooke> So looks like xorg is starting too soon again?
[08:34] <tjaalton> yep
[08:34] <willcooke> could this have anything to do with Plymouth?
[08:34] <tjaalton> maybe
[08:35] <willcooke> tjaalton, shall I log a new bug still?
[08:35] <tjaalton> yep
[08:35] <tjaalton> let's use that for discussing with foundations if there's something to be done
[08:36] <willcooke> tjaalton, should I put it against xorg for now?
[08:36] <tjaalton> that's fine
[08:36] <willcooke> thanks tjaalton
[08:38] <didrocks> clobrano: hum, the snaprevs update failures is back for the last few days, I've reasked the snap store team about this: https://forum.snapcraft.io/t/snaprevs-update-failed/7106/11
[08:39] <clobrano> didrocks: yes, also mads was unable to test some changes for this
[08:40] <didrocks> clobrano: actually, I think the snaps are still published, if you follow the pattern, you should get the correct channel
[08:42] <seb128> Trevinho, Laney, hey, is one of you working on getting the gnome-shell .1 update in cosmic?
[08:45]  * didrocks wonders if https://gitlab.gnome.org/GNOME/gdm/commit/a3904bf5f9e6fe6bc3bb2ad9c856cf1361b8194d is maybe related to the gdm issue I'm seeing
[08:46] <didrocks> I don't use autologin, but this code is "on_start_user_session", which is when I start having issues
[08:50] <Laney> seb128: "is" no, it only came out last night. "will you?" yes
[08:50] <duflu> jbicha (and Laney), Since last year mozjs has been built with --disable-optimization because "Copy these build flags from Fedora". Any idea why?
[08:50] <seb128> I need to communicate in a way that comes accross better :/
[08:51] <seb128> Laney, thx, that's what I meant to ask
[08:51] <duflu> Or rather "--disable-optimize"
[08:51] <seb128> Laney, I didn't look at timing of the tarballs, just got reminded because translations are borked in .0 and then I saw that .1 was on version ;)
[08:52] <seb128> good that it's on time for cosmic!
[08:52] <didrocks> annoying that gitlab has the same hidden "patch view" feature than github, without any UI to access it
[08:53] <duflu> didrocks, I found it via the GUI
[08:53] <didrocks> oh?
[08:53] <didrocks> where is it, when you are on the commit view?
[08:53] <didrocks> ohhhhhh
[08:53] <didrocks> in options
[08:53] <didrocks> options -> plain diff
[08:53] <didrocks> would need to remember this
[08:54] <duflu> didrocks, I meant in a merge request -- the cloud icon
[08:54] <didrocks> ah, but this is the .diff, not .patch
[08:54] <duflu> didrocks, cloud icon -> Email patches
[08:54] <didrocks> ok, so "email patch" in options
[08:54] <duflu> Does not "Email" but "Makes email patches"
[08:54] <didrocks> yeah, cloud icon -> weird choice for putting this here
[08:54] <jbicha> duflu: I hoped that Fedora knew what they were doing, but now that you mention it, that sounds like a flag we don't need
[08:54] <seb128> didrocks, you can just add the .patch or .diff to the url no?
[08:55] <didrocks> seb128: right, this is why I called it "hidden" :)
[08:55] <duflu> jbicha, I only found it because I noticed the debug info we publish doesn't work either. So will try building both alternatives
[08:55] <didrocks> so basically, from the UI, options or cloud icons
[08:55] <didrocks> thanks duflu
[08:56] <jbicha> duflu: it's also not set at https://gitlab.gnome.org/GNOME/jhbuild/blob/master/modulesets/gnome-suites-core-deps-latest.modules#L1651-1655
[08:56] <duflu> Well, maybe the tests fail. We shall see
[08:58] <Laney> seb128: np, I was concerned that you were nagging me about an update within 1 hour of beginning the next day after it came out but I shouldn't have been, sorry for coming across grumpy
[08:58] <seb128> np!
[08:58] <jbicha> duflu: https://salsa.debian.org/mozilla-team/firefox/blob/release/master/debian/rules#L90-92 seems reasonable
[08:59] <Laney> what does that disable-optimize flag do?
[08:59] <clobrano> didrocks: oh, ok
[08:59] <duflu> I can't tell yet. I was only looking for usable debug symbols
[08:59] <Laney> mozjs60 is clearly built with -O<something>
[09:00] <Laney> and -g
[09:00] <jbicha> duflu: I wonder what --disable-strip does
[09:00] <didrocks> ok, trying again gdm, then with the patch, getting some debug logs and let's see
[09:01] <duflu> It is presently building with -O2 -O3 -fomit-frame-pointer with optimization enabled.
[09:01] <didrocks> if I don't come back, it's because of the wormhole of this 100% CPU spinning
[09:01] <duflu> I should check the defaults again
[09:02] <Laney> it would certainly not be unheard of for -O3 to break stuff
[09:05] <duflu> lintian seems to be happy with optimization
[09:05] <duflu> Hmm
[09:06] <didrocks> no luck with the autologin patch in master :/
[09:07] <didrocks> at least, I should have some debug logs now
[09:10] <duflu> jbicha, Laney, a quick test reveals: enable-optimize works but doesn't seem to offer measurable improvements. debug fails to run because:
[09:10] <duflu> Assertion failure: isDebugBuild, at /home/dan/src/mozjs60/mozjs60-60.2.3/js/src/vm/Initialization.cpp:74
[09:17] <duflu> Ugh. That just means you can't have debug unless gjs is built the same way
[09:22] <jbicha> didrocks: if you're wanting to do a last minute osinfo-db upload, I think we should finalize the 18.10 xml (remove prerelease & set the URLs) & create a 19.04 xml
[09:23] <jbicha> we might need to distro-patch that since upstream seems to like test data for metadata changes like that but those iso's don't exist yet!
[09:24] <didrocks> jbicha: I think we should focus on fixing the bug first
[09:24] <didrocks> so, let's see teuf's review
[09:24] <didrocks> then, we can see if we distro-patch or not
[09:25] <jbicha> I was only commenting since you were talking about doing an upload :)
[09:25] <didrocks> upstream is happy to cut a release once teuf has reviewed it
[09:26] <didrocks> jbicha: yeah, I don't really care about the pre-release state or such. I'm mostly caring of being able to have VMs that can be installed :)
[09:26] <didrocks> (and also my gdm issue, which is hard to pinpoint :p)
[09:27] <jbicha> didrocks: btw, the Debian maintainer doesn't need a release tag to do his uploads, see comment 17 on Debian bug 908973
[09:27] <didrocks> jbicha: right, but upstream wants to cut a release for us, I won't prevent them from doing it :)
[09:27] <jbicha> when pre-release is set, 18.10 won't show up in the Download an OS feature in GNOME Boxes
[09:27] <jbicha> it doesn't care whether the date is future!
[09:27] <didrocks> I never had that feature working btw
[09:28] <jbicha> it should work in 18.10
[09:28] <jbicha> it downloads to ~/Downloads/
[09:31]  * didrocks tries with another gdm revert
[09:35] <didrocks> nope :/
[09:36] <seb128> didrocks, git bisect? ;)
[09:36] <didrocks> seb128: that's basically what I'm doing, but not every commits builds…
[09:36] <didrocks> issue with not having a mainline
[09:37] <didrocks> I'm unsure what's happening, but a side effect is already ureadahead going crazy
[09:37] <didrocks> like printing
[09:37] <didrocks> oct. 09 11:33:12 casanier ureadahead[320]: ureadahead:: Chemin relatif ignoré
[09:37] <didrocks> oct. 09 11:33:12 casanier ureadahead[320]: ureadahead:sys: Chemin relatif ignoré
[09:37] <didrocks> oct. 09 11:33:12 casanier ureadahead[320]: ureadahead:class: Chemin relatif ignoré
[09:37] <didrocks> oct. 09 11:33:12 casanier ureadahead[320]: ureadahead:dmi: Chemin relatif ignoré
[09:37] <didrocks> in loop
[09:37] <didrocks> (tried on multiple boots, and only boots having the broken gdm triggers this)
[09:42] <tjaalton> willcooke: now I installed on a vbox, and after reboot gdm fails, no x log
[09:42] <tjaalton> needs to be restarted
[09:44] <tjaalton> just the first time though, probably raced against vboxvideo still
[09:44] <willcooke> tjaalton, that could be a known issue,  Do you get a flashing cursor and no gdm?
[09:45] <tjaalton> yep
[09:45] <willcooke> tjaalton, could it be this?  https://gitlab.gnome.org/GNOME/gdm/issues/428
[09:45] <gitbot> GNOME issue 428 in gdm "Ubuntu 18.10 boots to black screen with flashing cursor, no gdm. Switching to tty2 and back to 1 fixes it." [Opened]
[09:45] <tjaalton> it remained dead
[09:49] <seb128> is anyone planning g-c-c changes/fixes before cosmic now?
[09:49] <seb128> andyrock, ^ you maybe?
[09:49] <seb128> (trying to figure out if I need a no change rebuild for translations or wait for a legit upload)
[09:50] <andyrock> I'm working on some g-c-c crashes right now
[09:50] <andyrock> but that would take time
[09:50] <andyrock> *could
[09:50] <willcooke> tjaalton, sounds like a different problem, I will try the daily on a physical machine
[09:50] <andyrock> seb128: ^^^
[09:51] <seb128> andyrock, k, let's see if you have something by tomorrow
[09:51] <seb128> if not I do a no change upload
[09:51] <andyrock> kk
[09:54] <didrocks> found the issue!
[09:54] <didrocks> after an epic bisect on all complicated commits and so on…
[09:55] <didrocks> the issue is "simply" triggered by https://gitlab.gnome.org/GNOME/gdm/commit/5cd78602d3d4c8355869151875fc317e8bcd5f08
[09:55] <didrocks> (I have a dual intel/nvidia card)
[09:55] <didrocks> I wonder if anyone tries to blacklist his card if they get the same issue…
[09:57] <tjaalton> willcooke: adding vboxvideo to initrd should fix all races..
[09:57] <tjaalton> seems to load here at 1.2s and not 6.5s
[09:57] <seb128> tjaalton, did you ask kernel/foundations if they want to do that?
[09:57] <tjaalton> no
[09:57] <seb128> why not?
[09:57] <seb128> if that's the suggested way out
[09:57] <tjaalton> just found out
[09:58] <seb128> I though we already circled around that a week ago during the meeting
[09:58] <seb128> you said the loading time was because the driver was missing from the initrd
[09:58] <tjaalton> it wasn't there before
[09:58] <tjaalton> in bionic
[09:59] <seb128> willcooke, I've your cosmic/pending iso video corruption happening on a xenial/virtualbox VM booting the iso
[09:59] <seb128> tjaalton, right, doesn't hurt to ask if they are wanting to consider adding it to it though, if you think that would be the right thing to do
[10:00] <seb128> tjaalton, there is still a bug on the xorg side though, but seems like that one is harder to get fixed?
[10:00] <tjaalton> yeah I'd say very little chance at least to get it fixed this week
[10:01] <seb128> willcooke, https://pasteboard.co/HHDoqeG.png
[10:04] <didrocks> seb128: I don't remember, do we force Xorg for our gdm session?
[10:04] <didrocks> we don't use WaylandEnable=false because this disables the wayland options for users
[10:05] <didrocks> but I don't remember anymore if we did anything special for gdm
[10:05] <seb128> no
[10:05] <seb128> doing that would make gdm not list wayland sessions
[10:05] <seb128> ah, you said that
[10:05] <didrocks> yep :)
[10:05] <seb128> no, we just use plain default wayland
[10:05] <didrocks> I wonder if we added anything else
[10:06] <didrocks> ok
[10:06] <seb128> no
[10:06] <didrocks> would be great if someone can try to blacklist their card
[10:06] <didrocks> and see if the issue is only nvidia or as soon as you blacklist a card
[10:06] <seb128> tjaalton, willcooke, I replied to that email asking for the initrd/vboxvideo
[10:07] <seb128> didrocks, how do you blacklist a card?
[10:07] <seb128> I'm in middle of reviewing a stack of translations settings in launchpad but I can try to have a go later
[10:08] <didrocks> seb128: modify /lib/udev/rules.d/61-gdm.rules and add something like DRIVER=="<your graphicdriver>", RUN+="/usr/lib/gdm3/gdm-disable-wayland"
[10:08] <seb128> didrocks, is that gdm-disable-wayland command working on an already loaded greeter? would going to a vt and doing that by hand trigger the bug?
[10:09] <didrocks> seb128: I'm unsure how this is ran, by gdm for sure, but as a subprocess it seems?
[10:09] <didrocks> meanwhile, I'm updating the bug and will ping Jonas
[10:09] <seb128> looks like an udev rule no?
[10:09] <Laney> it writes a configuration to /run
[10:09] <Laney> with WaylandEnable=false
[10:10] <didrocks> ah, so you mean, if I set WaylandEnable=false, I should trigger the same issue?
[10:10] <seb128> worth trying
[10:10] <didrocks> yep
[10:10] <didrocks> let me attach my logs first to the bugs
[10:10] <didrocks> so that I don't loose them
[10:10] <tjaalton> seb128: yep
[10:10] <didrocks> I wonder if it's not related to the ICC profile
[10:11] <Laney> I'm on nvidia btw, that udev rule fires for me properly
[10:11] <seb128> shrug, if I know who enabled that launchpad translations setting for all projects :/
[10:11] <seb128> taking hours to review the stack :(
[10:12] <Laney> seb128: :(
[10:12] <didrocks> :/
[10:12] <willcooke> thanks seb128
[10:12] <didrocks> no API?
[10:13] <didrocks> Laney: do you use an ICC profile?
[10:13] <Laney> not knowingly
[10:13] <didrocks> yeah, I bet something like "fallback to Xorg -> ICC profile loaded -> can't load it because on user's home"
[10:13] <oSoMoN> ricotz, for the firefox-next xenial build failures, I think you'll need to patch python/mozbuild/mozbuild/action/check_binary.py to remove the checks on libstdc++, like https://bazaar.launchpad.net/~mozillateam/firefox/firefox-beta.trusty/revision/1243
[10:13] <didrocks> but the whole is world readable though
[10:13] <seb128> didrocks, could be, but I start by checking manually if the imports where outdated or not which is manual work
[10:13] <didrocks> (as the directory)
[10:13] <didrocks> seb128: :(
[10:14] <jbicha> seb128: btw, could you import the polari .pot now? I reverted gnome-recipes to not use langpacks for now since its .pot generation is broken
[10:14] <jbicha> I don't think we're going to end up doing gnome-contacts 3.30 this cycle
[10:15] <seb128> jbicha, done
[10:15] <jbicha> it's late to be changing icon names
[10:15] <seb128> you could revert that part in the packaging
[10:15] <seb128> I mean it's probably late for a serie update
[10:15] <seb128> but the icon issue is easy to workaround
[10:15] <didrocks> ok, trying with WaylandEnable=False
[10:15] <oSoMoN> ricotz, have you tried backporting nodejs 8.11 to trusty and encountered issues, or is it just that you haven't tried yet?
[10:21] <didrocks> WaylandEnable=false triggers it as well, so it's really my machine + Xorg for gdm
[10:21] <didrocks> disabling the color profile hasn't done anything though
[10:21] <ricotz> oSoMoN, I haven't tried yet, but I am currently looking at its builddeps
[10:25] <oSoMoN> this is going to pull in a lot of build deps that aren't in trusty :/
[10:26] <seb128> jbicha, grilo-plugins has no translations in launchpad/doesn't use dh_translations, can you fix it in Debian so we can sync the update?
[10:27] <seb128> didrocks, :(
[10:27] <seb128> didrocks, at least it removes the question of racy behaviour
[10:27] <seb128> if it's in the static config it's not the dynamic change
[10:27]  * duflu attempts to cook Indian
[10:27] <didrocks> seb128: right
[10:27] <didrocks> seb128: quite blocked now though, let's see on #gdm
[10:27] <seb128> right
[10:28] <jbicha> seb128: grilo-plugins is split in Ubuntu because of main/universe issues
[10:28] <seb128> jbicha, ah right, well if you still want to look at fixing it/not having that delta... ;)
[10:28] <seb128> I can have a look later otherwise, still going through those components, that's tedious :/
[10:29] <jbicha> it was a bit difficult to explain to the Debian maintainer the justification for the split
[10:30] <Trevinho> seb128: hey... So yeah, once we've a final review. Also I wanted to backport the fixed for the me leak to bionic... I started this way yesterday, then... The other Issues come up.
[10:30] <seb128> hey Trevinho
[10:31] <seb128> Trevinho, cosmic is a priority over bionic for the next week, please focus full energy on cosmic
[10:31] <seb128> bionic can come in a week when cosmic is frozen/ready to get out
[10:32] <andyrock> seb128: found the problem for https://errors.ubuntu.com/problem/2c64a180c193cbafd37c76a0a6a4885e5322ba64 so you can get a proper upload \o/
[10:32] <Trevinho> Ok. Fair enough.
[10:32] <seb128> andyrock, great!
[10:32] <seb128> Trevinho, thx
[10:36]  * andyrock is wondering if what we do today should go in today bullet list or in the one of next week
[10:51] <seb128> today = next week
[10:52] <seb128> we wrap the summaries on monday evening
[10:52] <seb128> so it's tuesday to monday activity
[10:58] <seb128> k, on that note, lunch!
[11:03] <Trevinho>  didrocks: any clue why we're still hitting https://errors.ubuntu.com/problem/1d505b2589761bfc2d44875a226ee3d3623abd3c
[11:49] <Laney> Trevinho: can you check gnome-shell from lp git pls?
[11:49] <Laney> search cancellation stuff needed some updating, want to know it's ok
[11:59] <Trevinho> Laney: ok, after lunch
[12:00] <Laney> grazie
[12:06] <seb128> andyrock, was moving https://trello.com/c/OZkeMW3b/181-cancelling-snapd-authorization-triggers-error-notification to the proposed column an error and you meant done?
[12:07] <andyrock> seb128: it's done
[12:07] <andyrock> robert updated it
[12:07] <andyrock> *uploaded
[12:07] <andyrock> ah yeah
[12:07] <andyrock> yes done!
[12:07] <andyrock> fixed
[12:07] <seb128> andyrock, right, I just got an email "Andrea Azzarone moved the card Cancelling snapd authorization triggers error notification to Proposed on Ubuntu Desktop 18.10 cycle"
[12:07] <seb128> thx
[12:08] <seb128> :)
[12:08] <andyrock> seb128: so I got a fix for https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1796872
[12:08] <andyrock> this is ubuntu specific
[12:08] <andyrock> I'm preparing a MR againts our git
[12:08] <seb128> +1
[12:08] <seb128> let me know when you have it ready, I'm happy to sponsor
[12:08] <andyrock> it should be quite small
[12:12] <seb128> andyrock, the ibus fix you did in master applies to stable? should we cherry pick it?
[12:12] <andyrock> I think we can wait until 3.30.1 is released
[12:13] <andyrock> *3.30.2
[12:13] <andyrock> I think we should cherry-pick the one in errors.ubuntu.com
[12:14] <seb128> k, wfm
[12:14] <andyrock> seb128: https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1796855 and the one i'm doing now
[12:15] <seb128> it's different from the one you just mentioned a few minutes ago right?
[12:28] <andyrock> yep, 1796855 applies upstream, 1796872 it's just in ubuntu
[12:28] <andyrock> seb128: do you want me to proper an upload or just a MP for 1796872
[12:28] <andyrock> *preper
[12:29] <andyrock> *prepare :)
[12:29] <andyrock> 1796855 is easy to reproduce, 1796872 is not that likely to happen
[12:30] <seb128> andyrock, well, let's batch the fixes you get today and do an upload later/tomorrow?
[12:40] <andyrock> seb128: kk
[13:10] <andyrock> seb128: https://code.launchpad.net/~azzar1/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/356324
[13:10] <andyrock> this is just for one crash
[13:11] <seb128> k
[13:19] <andyrock> Trevinho: https://gitlab.gnome.org/GNOME/gnome-shell/commit/b719744e75e56502cf0340066f9311fdcc755628
[13:19] <didrocks> Trevinho: sorry, didn't see your ping. I'm unsure, is the SRU completely deployed?
[13:19] <andyrock> this could also be related to the "--replace" issue
[13:19] <andyrock> this has just been commited
[13:20] <didrocks> Trevinho: look at the package version, there is very few reports with latest version (which is weird as well)
[13:30] <seb128> hey there, meeting time but not quite, willcooke"s machine has just frozen and he's trying to reboot
[13:30] <seb128> we wait a few min for him and start without him if reboot fails
[13:31]  * didrocks wonders if I should try the gdm patch meanwhile :)
[13:32] <seb128> haha
[13:33] <seb128> wb willcooke!
[13:34] <willcooke> hey!
[13:34] <willcooke> sorry everyone
[13:34] <willcooke> bear with me
[13:34]  * didrocks is bearing :p
[13:34] <willcooke> #startmeeting Desktop Team Weekly Meeting - 2018-10-09
[13:34] <meetingology> Meeting started Tue Oct  9 13:34:58 2018 UTC.  The chair is willcooke. Information about MeetBot at http://wiki.ubuntu.com/meetingology.
[13:34] <meetingology> Available commands: action commands idea info link nick
[13:35] <willcooke> Roll call: andyrock, dgadomski, didrocks, duflu (out), jbicha, jamesh (out), jibel, heber, kenvandine (hols), laney, oSoMoN, seb128, tkamppeter, trevinho, robert_ancell (out), tjaalton, tseliot
[13:35] <seb128> hey o/
[13:36] <oSoMoN> hey ho
[13:36] <andyrock> o/
[13:36] <willcooke> oh, Till is out too
[13:36] <didrocks> o/
[13:36] <jibel> o/
[13:36] <willcooke> While we wait for everyone to arrive, some notes...
[13:36] <tjaalton> o/
[13:37] <willcooke> If you have things to raise, they should have been in your meeting notes.  If you forgot, or find something to talk about now, if it can wait to after the meeting, please do that, otherwise there will be AOB at the end
[13:37] <willcooke> Second thing - release is just over a week away - so naturally Cosmic is the focus.  We still have quite a few issues getting it to boot and start correctly.
[13:38] <willcooke> I'm going to skip Bionic again this week so we focus only on Cosmic
[13:38] <willcooke> Please have a look through the notes and if you can help with sponsoring or reviews, please dive in
[13:38] <willcooke> Notes are here: https://discourse.ubuntu.com/t/monday-8th-october-2018/8221/5
[13:39] <willcooke> ok, so I don't see anything in the notes for people with questions, so lets get stuck in to rls bugs
[13:39] <willcooke> 1st up is: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1796822
[13:40] <willcooke> This is where you get a messed up screen when booting on Virtualbox.
[13:40] <willcooke> We have threads open with tjaalton and foundations about this one, and I think it's a release blocker
[13:40] <willcooke> so I vote to accept it, but then it's not really in our team to fix it.
[13:41] <willcooke> I'm talking to the right people, so I think its under control
[13:41] <willcooke> https://bugs.launchpad.net/ubuntu/+source/cups-pk-helper/+bug/1290533
[13:41] <seb128> +1 for nominating it, we need an owner maybe tjaalton? he/we can reassign if we find another owner?
[13:41] <willcooke> sorry, didnt mean to hit enter on that last line
[13:42] <willcooke> tjaalton, you OK with me assigning it to you for now?
[13:42] <tjaalton> sure
[13:43] <seb128> the cups-pk-helper
[13:43] <seb128> jibel, any reason you think it's a cosmic target bug?
[13:43] <willcooke> Has LP suddently gone down for anyone else?
[13:44] <seb128> e.u.c suggests we got 50k report in xenial, 2.2k in bionic, 131 in cosmic
[13:44] <seb128> willcooke, wfm
[13:44] <tjaalton> willcooke: yep
[13:44] <willcooke> ok, I will assign that bug later
[13:44] <Laney> that cups one could be notfixed but still assigned to Till, seems like it'd be a good one to fix
[13:44] <seb128> I would vote -1 for the cups-pk-helper one, it's not new and numbers are somewhat low
[13:45] <seb128> +1 for what Laney said
[13:45] <didrocks> agreed with Laney
[13:45] <willcooke> agreed
[13:46] <andyrock> it has not been reproduced since end of August
[13:46] <willcooke> k, LP is working again
[13:46] <willcooke> bug updates
[13:46] <willcooke> updated
[13:46] <willcooke> next
[13:46] <willcooke> https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1795637
[13:46] <willcooke> This is the gdm issue where I get a black screen and cursor
[13:46] <seb128> +1 for nominating
[13:46] <willcooke> agreed.
[13:46] <seb128> it's being worked but not moving fast enough imho
[13:46] <didrocks> +1
[13:47] <seb128> as I said previous week I think someone from our side should own it and drive to landing
[13:47] <willcooke> I would like to find a proper owner for that one.  I can help with logs etc, but I think I'm getting in the way at this point
[13:47] <seb128> because we might miss release at the upstream tempo
[13:47] <willcooke> Who would like to help with that one?
[13:48] <seb128> Trevinho, Laney, I think one of you needs to take that one please
[13:48] <seb128> you are the ones who know gdm code/upstream best atm
[13:49] <willcooke> I will assign when that's agreed
[13:49] <willcooke> in the meantime
[13:49] <willcooke> https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1796056
[13:49] <Laney> I've already been helping on the patch that was proposed and stuff, but it's hard to do it blind, so if I can make it happen with the SSD I just got then sure.
[13:50] <seb128> k, let me know
[13:50] <seb128> willcooke, +1 for the xserver one
[13:50] <willcooke> who can we assign it to?
[13:50] <seb128> not starting sessions regression the week before release are concerning
[13:50] <seb128> it's assigned to Timo
[13:51] <tjaalton> just took that
[13:51] <seb128> tjaalton, you are working on driving that one to resolution?
[13:51] <willcooke> ah thanks
[13:51] <seb128> thx
[13:51] <tjaalton> but fixing the vboxvideo loading will fix that too
[13:51] <willcooke> ack
[13:51] <willcooke> last one: https://bugs.launchpad.net/ubuntu/+source/mozjs60/+bug/1796238
[13:51] <Trevinho> I can also look if needed
[13:51] <Laney> -1
[13:51] <Laney> that's niche
[13:52] <seb128> we are confident it's only impacting "debugexit"?
[13:52] <seb128> if so -1
[13:52] <seb128> if we don't know I would vote +1
[13:52] <andyrock> it could happen at shutdown
[13:52] <andyrock> logout, stuff like this
[13:52] <Laney> well, the bug reporter didn't answer my questions.
[13:52] <seb128> better safe than sorry in that case?
[13:52] <Laney> but *I* never made it happen
[13:52] <Laney> other than at debugexit
[13:52] <Laney> shrug
[13:52] <seb128> I would say -0.5 then but to keep an eye on it
[13:53] <andyrock> but we already have branches to *fix* this
[13:53] <andyrock> the true issue is that gnome-shell --replace fails
[13:53] <andyrock> because of the same reason
[13:53] <seb128> you have a fix?
[13:53] <andyrock> partials fixes
[13:53] <Laney> stoppppppppp
[13:53] <Laney> discussing the bugggggggggggggg
[13:54] <andyrock> I'm not discussing ing
[13:54] <andyrock> *it
[13:54] <Laney> k
[13:54] <andyrock> just explaining why it can be problematic to not fix it
[13:54] <seb128> I don't think so :p  it's just that if it's owned/driven to resolution I vote to nominate and land the fix
[13:54] <seb128> like assigned to andyrock and target
[13:54] <seb128> and move on
[13:54] <willcooke> +1 to assign
[13:54] <Laney> you don't need to nominate a fix to upload it
[13:54] <seb128> if others think it's ok?
[13:54] <Laney> in my opinion this is not a release blocker
[13:54] <Laney> but do it if you want to
[13:54] <willcooke> ah, that's a good point
[13:55] <seb128> right, I'm still concerned it has side effect and bite us back
[13:55] <willcooke> ok, deciding to target and move on
[13:55] <seb128> but it's only being cautious
[13:55] <seb128> it might not
[13:55] <seb128> anyway
[13:55] <seb128> it's owned/assigned
[13:55] <seb128> so I think targetted or not is fine either way
[13:55] <willcooke> that's all the desktop-packages ones
[13:55] <seb128> willcooke, you decide :)
[13:55] <willcooke> already did
[13:55] <Trevinho> +1 also
[13:56] <Trevinho> can happen on shutdown too as said
[13:56] <andyrock> +1
[13:56] <willcooke> ok, I think thats all the bugs then
[13:56] <Laney> I object to "I've worked on this bug" being a criterion for release miletoning
[13:56] <seb128> wait
[13:56]  * Laney is clearly out of step with people
[13:56] <Laney> that error bucket has hardly any reports
[13:56] <andyrock> :)
[13:56] <seb128> well, my motivation is
[13:56] <seb128> - could have side effect and bite us back in other situations
[13:56] <didrocks> well, it's going to be fixed, does the nomination discussion so important?
[13:56] <seb128> - logout bugs generate apport noise
[13:56] <didrocks> is*
[13:57] <seb128> which reflects badly on the user perception of the OS
[13:57] <andyrock> my motivation is: gnome-shell replaces completely crashes the X Server atm
[13:57] <Trevinho> yep indeed. we don't need to prioritize more than already it is
[13:57] <seb128> anyway, let's move on
[13:57] <seb128> I've another one which I tagged by didn't hit the refresh in time
[13:57] <seb128> bug #1691649
[13:57] <Trevinho> so, assigned or not, it's still something is in the works. and there to be fixed. Can be later if something is more critical
[13:58] <seb128> it's https://errors.ubuntu.com/problem/70a7581dd245188e74367f2c31a505b664b972c9
[13:58] <didrocks> seb128: bionic?
[13:58] <didrocks> or it got worse recently?
[13:58] <seb128> didrocks, no, we don't have portal in bionic
[13:58] <seb128> didrocks, see ^
[13:58] <seb128> it's cosmic only reports
[13:59]  * didrocks wonders why apport date is earlier thus and added the bionic tag
[13:59] <didrocks> I guess the crash was always there, we just got more because we start seeding it, correct?
[13:59] <seb128> likely
[13:59] <seb128> it seems to at least impact the live session, according to jibel's comment
[13:59] <didrocks> yeah, annoying…
[13:59] <seb128> (just updated the description using the info from the duplicate)
[14:00] <seb128> anyway
[14:00] <seb128> I vote +1
[14:00] <willcooke> Lets ask James in the morning?  I need to chat to him tomorrow about other things anyway
[14:00] <didrocks> +1 thus
[14:00] <willcooke> I can assign it to him now and if something changes we can update it
[14:00] <seb128> willcooke, as you want, I would target/assign to jamesh
[14:00] <seb128> k
[14:00] <willcooke> done
[14:01] <willcooke> #topic AOB
[14:01] <willcooke> Anyone got anything else to talk about>?
[14:01] <seb128> feedback from previous/this meeting
[14:01] <seb128> that meeting reminded me about what Laney wrote in his feedback email
[14:02] <seb128> I think the round of rls bug would be better if we had pre-meeting collecting of opinions
[14:02] <seb128> and the review just be a vote in the meeting
[14:02] <seb128> and not an argument
[14:02] <seb128> e.g +1/0/-1
[14:02] <seb128> and respect the quorum/votes without arguing
[14:03] <Laney> not sure democracy is the best thing for this
[14:03] <seb128> we tend to end up bikeshedding otherwise
[14:03] <Laney> I think, as you might have guessed from what I was saying, that we lean too much to accepting bugs
[14:03] <Laney> easier to +1 everything after all
[14:03] <Laney> especially if it's someone else who is going to be doing whatever the work is
[14:04] <Trevinho> -1 on democracy.
[14:04] <seb128> so having managers to review/assign? still in that meeting?
[14:04] <Laney> doesn't have to be managers
[14:04] <seb128> managers/selected people
[14:05] <Laney> Brian's not one of those as far as I know
[14:05] <Trevinho> well, who's more experienced should be
[14:05] <seb128> I guessed you would say that ;p
[14:05] <didrocks> I guess we started to discuss that in meetings because we weren't happy that it was manager only deciding them
[14:05] <seb128> right, we went circle :)
[14:05] <oSoMoN> people with a good understanding of the bug and its consequences should decide, not everyone
[14:05] <Trevinho> Like managers decide in case there's no decision otherwise
[14:05] <Laney> Someone who is able to assess importance well, whoever that is.
[14:06] <didrocks> sounds a little bit too blury to have anything practical from this statement, no?
[14:06] <seb128> we need to call for an election :)
[14:06] <oSoMoN> a desktop team TB ? ;)
[14:06] <seb128> willcooke, I'm done on the topic, I think I got feedback for my comment and I need some time to think about the feedback
[14:07] <seb128> so I'm not going to have more to say on that now
[14:07] <willcooke> ok, I suggest we continue this thread later / on email.  A pre-meeting review sounds like a good idea.  Not sure when that can happen, but lets work it out
[14:07] <seb128> others might want to keep discussing though, I'm not stopping the topic
[14:07] <Laney> I was totally not lobbying for a pre meeting meeting
[14:07] <Laney> just someone to lead the round with some initial opinions
[14:07] <willcooke> got it
[14:07] <seb128> that sounds good
[14:08] <seb128> but that doesn't resolve the decision problem
[14:08] <seb128> at least it would be one step in the right direction though
[14:08] <Laney> nope, because I would have suggested -1ing that bug and you would have overruled me
[14:08] <Laney> so, no good suggestion I guess.
[14:09] <willcooke> oki, we can continue to think about it
[14:09] <willcooke> Any other topics?
[14:09] <seb128> not from me
[14:09] <willcooke> New notes topic opened here: https://discourse.ubuntu.com/t/monday-15th-october-2018/8296
[14:10] <willcooke> Closing in 5....4...
[14:10] <willcooke> #endmeeting
[14:10] <meetingology> Meeting ended Tue Oct  9 14:10:29 2018 UTC.
[14:10] <meetingology> Minutes:        http://ubottu.com/meetingology/logs/ubuntu-desktop/2018/ubuntu-desktop.2018-10-09-13.34.moin.txt
[14:10] <didrocks> thx!
[14:10] <willcooke> Thanks everyone.  We're getting better
[14:11] <seb128> thx!
[14:11] <Laney> ty
[14:12] <seb128> Laney, so in foundations Brian decide of the nominations for the team?
[14:12] <seb128> or just do the reporting/drive the roundtable with reasons of why he suggests the bug to be nominated or not?
[14:12] <Laney> it looks like he comes to the meeting having browsed the list
[14:12] <Laney> and suggests the ones from there that should be taken
[14:14] <seb128> k, that makes sense
[14:15] <seb128> someone still need to decide at the end though, which is the part where disagreement is coming and I'm unsure how to resolve :/
[14:16] <Laney> he just doesn't bring the ones that he thinks are definitely notfixing I think
[14:16] <Laney> and nobody tries to second guess that afaics
[14:16] <Laney> there's probably manager to manager backchanneling that goes on but that's alright
[14:17] <Laney> I mean a nominator could probably show up at their meeting and argue if one they care about got missed off, that is also an OK way to do it I think
[14:17] <Nafallo> willcooke: you're not at OpenStack Nordic by any chance? :-)
[14:18] <willcooke> Nafallo, nope :)
[14:18] <Nafallo> shame. on my way there now ;-)
[14:18] <Nafallo> well, tomorrow
[14:18] <willcooke> Laney, that sounds like it's worth a try
[14:19] <Trevinho> didrocks: as per that gnome-session migration script error... yes, as you said also ubuntu2 and ubuntu3 which should have the fix are showing up. Can't get why.
[14:19] <willcooke> jibel, I can recreate your "Cosmic doesnt boot", taking Plymouth out of the picture fixes it
[14:19] <willcooke> jibel, could you confirm on your machine?
[14:19] <didrocks> Trevinho: yeah, I'm puzzled, don't really have time to look at it with the other gdm bug for instance
[14:20] <Trevinho> didrocks: sure, sure... not a big deal. I was just wondering if you had any idea.
[14:20] <jibel> willcooke, I cannot make it boot to the live session anymore, it worked only once. I'll confirm the "doesn't boot" issue
[14:20] <jibel> it seems that everything converges to plymouth
[14:51] <jibel> willcooke, I confirm the "doesn't boot" issue with C on vbox on C
[14:52] <jibel> it boots with nomodeset
[14:54] <willcooke> and now I can't recreate it
[14:54] <willcooke> sigh
[15:07] <willcooke> Were there any important fixes in the latest mutter?
[15:08] <willcooke> jibel, perhaps by luck, but once I've upgraded this vm and got a new version of mutter amongst other things, I can't recreate the "can boot cosmic on a vm" issue
[15:13] <tjaalton> willcooke:   * Do not include graphical drivers when FRAMEBUFFER is not set (LP: #1561643)
[15:14] <tjaalton> willcooke: looks like the installer initrd did have framebuffer drivers in the past..
[15:14] <tjaalton> just not vboxvideo
[15:17] <tjaalton> uh, it still does
[15:17] <tjaalton> nevermind
[15:18] <willcooke> heh
[15:25] <jibel> willcooke, I cannot reproduce it either after the first boot, and I didn't change anything.
[15:26] <willcooke> darn races
[15:33] <willcooke> ok, it's back again, with the updates.  So false alarm, everything is as it was
[15:34] <willcooke> i.e mutter was nothing to do with it
[15:34] <willcooke> probably
[15:34] <Laney> good news, I can get that other gdm bug with the ssd
[15:34] <willcooke> Laney, yay!
[15:35] <willcooke> Laney, did you have fun taking the laptop to bits?
[15:35] <Laney> pretty sure I don't have as many screws as I started with
[15:35] <Laney> /o\
[15:36] <willcooke> haha
[15:36] <willcooke> They always put too many in
[15:36] <willcooke> You'll find it when you step on it in bare feet
[15:39] <jibel> ah reproduced again
[15:40] <willcooke> same, and this time I have ssh installed
[15:40] <jibel> so it happens only with plymouth
[15:40] <willcooke> so could be framebuffer related?
[15:40] <jibel> it doesn't happen when the ubuntu logo is not displayed
[15:41] <Laney> one of you want to raise it with foundations?
[15:42] <willcooke> yeah, will do
[15:43] <willcooke> jibel, did you already have a bug open for this one?
[15:45] <jibel> willcooke, no, I'll collect the journal and open one
[15:46] <willcooke> jibel, thanks
[15:46] <willcooke> I just looked at systemd to see if anything was stuck, but looks ok
[15:46] <willcooke> I restarted gdm and it sprung to life
[15:47] <willcooke> so could be related to the other gdm issue
[15:47] <jibel> could be the same gdm bug
[15:47] <jibel> yeah
[16:29] <willcooke> jibel, we could reuse this bug: https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1794280
[16:50] <jibel> willcooke, I cannot find a difference from the journal between a successful and a failed boot. Only that in one case gdm doesnt start
[17:05] <willcooke> jibel, did you turn on extra gdm debugging? Also halfline suggested I add:
 willcooke: posting an udpated journal -b with plymouth.debug=stream:/dev/kmsg would be good, throw a drm.debug=0x1e on there too i guess
[17:17] <jibel> no, I didn't. I'll try that
[17:26] <willcooke> I failed to make much sense of the extra stuff
[17:26] <willcooke> Now that L_aney can reproduce the other gdm, the calvary have arrived :)
[17:31] <jibel> does it fail only on odd hours .... cannot make it fail with the extra boot parameters
[17:34] <willcooke> heh
[17:34] <willcooke> I'm giving up for the day
[17:34] <willcooke> let's try again tomorrow
[17:34] <willcooke> catch you later
[17:54] <Laney> https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1794280 and https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1795637 will probably end up being the same
[17:54] <Laney> and something that only happens when plymouth is in use, although I don't think plymouth is the actual cause
[19:15] <xnox> Laney, am I delusional, or did we used to have fallback-x thing on the desktop, in case display-manager/X fails to start?
[19:15] <xnox> cause atm, after friendly-recovery, `resuming` boot fails, and gdm3 clearly fails, yet is always autorestarted or even claims to be running despite X server failed.
[19:16] <sarnold> still do, I hit that when my xenial->bionic update failed catastrophically
[19:16] <xnox> i was hoping that like emergency target would kick in after a while, or like getty@tty1 would be started.
[19:38] <czajkowski> popey: ping
[20:58] <ahasenack> hi, is fractional scaling (for high dpi screens) available in cosmic?
[21:02] <seb128> Trevinho probably knows the detail, but afaik it didn't get fully merged upstream yet
[21:02] <seb128> robert_ancell, hey! how are you?
[21:02] <robert_ancell> seb128, hi
[21:02] <seb128> robert_ancell, what was the vcs workflow issue you had with gnome-software?
[21:02] <robert_ancell> seb128, working out the damn git branch workflow
[21:02] <seb128> it's on the wiki :p
[21:02] <robert_ancell> seb128, rtfm?
[21:03] <seb128> doing an update should be basically "gbp import-orig <tarball>"
[21:03] <seb128> that update the upstream/pristine-tar/ubuntu branches
[21:03] <seb128> then you need to deal with refreshing patches and updating changelog
[21:03] <seb128> unsure if you did hit a specific problem?
[21:04] <seb128> I'm not the best person to ask about git, I still hate it, but I did a bunch of updates this cycle so I might be able to help you :)
[21:05]  * robert_ancell  is reading the wiki page
[21:07] <seb128> yeah, it's long/not a "easy way to get started"
[21:08] <robert_ancell> seb128, did you modify existing checkouts or start new ones?
[21:08] <seb128> Trevinho/Laney/didrocks did the imports, I only worked on modifying existing ones
[21:08] <seb128> robert_ancell, I think you basically want to
[21:09] <seb128> $ gbp clone lp:~ubuntu-desktop/ubuntu/+source/gnome-software
[21:09]  * robert_ancell edits Wiki page: "First get a Trevinho/Laney/didrocks and get them to do the first step"
[21:09] <robert_ancell> seb128, right, so that will make a new checkout, but I already have all the checkouts from upstream.
[21:09] <seb128> well you can just add a remote for ubuntu then
[21:10] <seb128> $ git remote add -f ubuntu lp:~ubuntu-desktop/ubuntu/+source/gnome-software
[21:10] <robert_ancell> seb128, import-orig says "Repository does not have branch 'upstream' for upstream sources"
[21:10] <robert_ancell> Which should be the salsa branch?
[21:11] <seb128> no
[21:11] <seb128> see https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-software
[21:11] <seb128> the repo has pristine-tar ubuntu/master upstream/latest
[21:11] <seb128> add the ubuntu remote and checkout the ubuntu/master branch and do the import from there?
[21:12] <seb128> since you did a source upload you might want to do an import-dsc instead
[21:12] <robert_ancell> seb128, what is the local branch called for you?
[21:12] <seb128> and give it the .dsc of your upload
[21:12] <seb128> ubuntu/master is the default branch/where we do the packaging
[21:15] <robert_ancell> seb128, import-dsc says "gbp:error: Repository has uncommitted changes, commit these first: On branch ubuntu/master"
[21:18] <robert_ancell> and if I do a import-orig I get "Repository does not have branch 'upstream' for upstream sources"
[21:19] <seb128> robert_ancell, git checkout -b upstream/latest ubuntu/upstream/latest?
[21:20] <seb128> I'm just random guessing git
[21:20] <seb128> gbp clone is setting up those branches for you
[21:20] <seb128> if you don't use it you have to do the manual work
[21:20] <seb128> same for -b pristine-tar ubuntu/pristine-tar
[21:20] <seb128> assuming you named the remote ubuntu
[21:21] <robert_ancell> I got upstream/latest, but then it complained about 'upstream'
[21:22]  * robert_ancell tries gbp clone
[21:30] <robert_ancell> import-dsc makes a crazy commit with a bunch of unrelated chanes
[21:33] <seb128> unsure about the "upstream" thing :/
[21:33] <seb128> weird
[21:33] <seb128> it should import what was in your upload and match that with the upstream commits
[21:33] <seb128> what sort of changes do you see?
[21:35] <robert_ancell> seb128, the changelog had every change since 3.14.0-1
[21:36] <seb128> urg
[21:37] <seb128> let me try
[21:37] <robert_ancell> oh wait, I think I might be getting mixed up between g-s and g-c-c
[21:37] <seb128> ha
[21:38] <robert_ancell> seb128, so a gbp clone for g-s gives "gbp:error: Git command failed: Error running git checkout: error: pathspec 'master' did not match any file(s) known to git.
[21:38] <robert_ancell> "
[21:39] <seb128> right, same here :/
[21:39] <robert_ancell> Is there a g-s branch?
[21:40] <seb128> yes, usually the issue for those error (at least I thought) is that the "default branch" is misconfigured on the server
[21:40] <seb128> but https://code.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-software/+git/gnome-software/+edit looks fine
[21:40] <seb128> well the clone works
[21:40] <seb128> you can git checkout -b upstream/latest origin/upstream/latest
[21:41] <seb128> git checkout -b pristine-tar origin/pristine-tar
[21:42] <seb128> shrug
[21:42] <seb128> Repository does not have branch 'upstream' for upstream sources. If there is none see
[21:44] <seb128> ah
[21:45] <robert_ancell> git import-dsc says 'gbp:error: Repository has uncommitted changes, commit these first: On branch ubuntu/master'
[21:45] <robert_ancell> But there's nothing uncommitted that I can see
[21:46] <seb128> git status?
[21:48] <seb128> robert_ancell, you want to add one of those to debian/
[21:48] <seb128> https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/nautilus/tree/debian/gbp.conf
[21:48] <seb128> with upstream being upstream/3.30.x
[21:49] <seb128> unsure why Laney didn't need it to do his update
[21:49] <seb128> robert_ancell, with that added the gbp import-dsc works here
[21:50] <robert_ancell> seb128, do you want to commit that change and then I'll do a pull?
[21:50] <seb128> k
[21:52] <seb128> robert_ancell, done
[21:55] <robert_ancell> ta
[21:56] <seb128> bah
[21:56] <seb128> robert_ancell, pull again
[21:56] <seb128> better to use upstream/latest for now
[21:57] <robert_ancell> I'm still getting "gbp:error: Repository has uncommitted changes" with the import-dsc
[21:57] <seb128> git status ?
[21:57] <robert_ancell> just untracked files
[21:57] <robert_ancell> Is it whining about those?
[21:57] <seb128> I guess?
[21:58] <seb128> also don't do the import yet :p
[21:58] <robert_ancell> Doesn't seem to have a flag to ignore that
[21:59] <seb128> you need --upstream-vcs-tag=GNOME_SOFTWARE_3_30_2
[21:59] <seb128> I think
[21:59] <seb128> to the gbp import-dsc
[22:00] <seb128> it relies on having the upstream tags "well named" which gnome-software doesn't seem to do
[22:00] <seb128> or it does
[22:01] <seb128> hum, unsure why it didn't properly update the upstream/latest branch for me then :/
[22:01] <robert_ancell> and this is why I didn't do the release with the git branch... :)
[22:01] <seb128> robert_ancell, oh, gbp clone works correctly now with the conf added
[22:02] <robert_ancell> seb128, so I do a gbp clone, then an import-dsc and just push it?
[22:03] <seb128> yes
[22:03] <seb128> I'm unsure why the upstream/latest doesn't have the proper history then
[22:03] <seb128> I need Trevinho or Laney for that, I can sort it out with them tomorrow
[22:03] <robert_ancell> seb128, so how do you build the package? I run 'gbp buildpackage' and get gbp:error: You are not on branch 'master' but on 'ubuntu/master
[22:03] <seb128> robert_ancell, or maybe don't, I wonder if that's going to create more issue than helping ...
[22:06] <seb128> robert_ancell, your commit reverted my gbp.conf adding :p
[22:07] <robert_ancell> huh? How did that happen?
[22:07] <seb128> the dsc import put it in the state of the source upload
[22:07] <seb128> which didn't have that file
[22:07] <seb128> so in that sense it's right to have done that
[22:08] <seb128> if you add it back "gbp buildpackage" should work
[22:08] <seb128> the conf tells it what branches to use
[22:08] <seb128> e.g ubuntu/master instead of master
[22:10] <seb128> robert_ancell, oh, you need to push the pristine-tar and upstream/latest branches, you only pushed ubuntu/master
[22:10] <seb128> (yeah, workflow is complex :/
[22:11] <seb128> on that note I call it a day
[22:11] <robert_ancell> seb128, thanks for staying up!
[22:11] <seb128> robert_ancell, good luck, I sort out the remaining issues with the guys who know more about the git details tomorrow
[22:11] <seb128> np! night desktopers