| Laney | so localechooser/supported-locales | 10:38 |
|---|---|---|
| Laney | is something supposed to update this? | 10:39 |
| Laney | I'm noticing that (for example) xxx-en-gb packages are removed by ubiquity, because that contains "en_US.UTF-8" and then that's passed on to check-language-support -l. | 10:40 |
| Laney | ah debian-installer/locale too, but this is apparently not set in the en_GB case? | 10:48 |
| Laney | hmm, it is, but something's overwriting it | 11:07 |
| Laney | I guess | 11:08 |
| Laney | xnox: want to help me? :-) | 11:09 |
| Laney | https://paste.debian.net/1046987 | 11:10 |
| Laney | between line 13 and 24 it got changed back | 11:10 |
| xnox | localechooser/supported-locales horum... i can't recall how it was done. either like at localechooser built-time or like at ubiquity built-time or like at langpack/language updates time | 12:20 |
| xnox | i think i never learned how to do translations (and supported locales) updates in ubiquity. | 12:21 |
| xnox | cause somebody else picked it up on the team, or like i rage quit working for the company, or some such. | 12:21 |
| xnox | better luck with infinity maybe?! | 12:21 |
| Laney | something is making it get reverted back to en_US | 12:28 |
| Laney | I don't yet understand all this debconf business | 12:29 |
| xnox | Laney, all i know that it is `different` given the monkey-patch at ./d-i/patches/localechooser-post-base-installer.patch | 12:31 |
| xnox | cause langpacks are done differently in ubiquity, but we still wanted to support the same d-i preseed questions or some such | 12:31 |
| Laney | yeah I don't think it is localechooser itself | 12:32 |
| Laney | it's fine after that finishes (line 13) | 12:32 |
| Laney | I'm looking for something in ubiquity I think | 12:32 |
| xnox | ooooh. there mayhave been cdimage stuff as well, cause i think it writes out to disk as to what langauge packs are included on the cd. | 12:54 |
| xnox | cause i think it we did (at one point) supported "re-rolling" the iso with more or less language packs without like rebuilding ubiquity. | 12:54 |
| xnox | literarly cannot remember any of those details. | 12:55 |
| Laney | it's to do with the debconf database in install.py not seeing the updates that happen from the timezone page | 12:56 |
| xnox | juliank was working on those sort of things lately (frontend database locking stuff, but maybe that was dpkg/apt rather than debconf) | 12:59 |
| Laney | ok, I found a change that fixes it I think, not sure if it's right though | 13:05 |
| * Laney fake news :( | 13:18 | |
| Laney | https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1797579 | 15:33 |
| Laney | cyphermox: xnox: maybe one of you knows the debconf stuff in ubiquity better than me and can tell me why that patch is wrong and/or how to do it better | 15:34 |
| Laney | would be nice to fix in cosmic if we can | 15:34 |
| xnox | i think we need juliank for this. | 15:34 |
| Laney | 😱 | 15:36 |
| Laney | the cavalry | 15:36 |
| cyphermox | yeah, there's only one instance of debconf somewhere at the beginning | 15:36 |
| Laney | there's this parallel db thing | 15:36 |
| Laney | I don't know what on earth that is | 15:37 |
| cyphermox | no clue. | 15:37 |
| cyphermox | wasn't this working before though? | 15:37 |
| Laney | presumably it was at some time | 15:38 |
| Laney | I didn't try previous releases tho | 15:38 |
| cyphermox | I'm suspicious of console-setup | 15:38 |
| Laney | maybe I have a old iso or something | 15:38 |
| cyphermox | that could have gone broken, as it tends to every release in some obscure way | 15:38 |
| * Laney has wily | 15:38 | |
| Laney | actually, trusty | 15:38 |
| cyphermox | Laney: in your bug, which part of the log says the installer forgot about the language? or is it not shown? | 15:41 |
| cyphermox | oh, right, only install.py | 15:41 |
| Laney | cyphermox: where it says Oct 12 15:48:42 ubuntu /install.py[9568]: keeping language packs for: en_US.UTF-8 | 15:41 |
| Laney | it's not actually completely forgotten | 15:41 |
| Laney | e.g. I get en_GB locale | 15:41 |
| cyphermox | yeah | 15:41 |
| cyphermox | well, I can see install.py having a separate, wrong debconf | 15:42 |
| Laney | it does have that | 15:42 |
| Laney | I ended up booting a xenial iso | 15:43 |
| Laney | it has this bug | 15:43 |
| Laney | bit different though, in that one localechooser is run too late | 15:44 |
| cyphermox | hold on | 15:46 |
| cyphermox | is that when you pick language in the selector in ubiquity? | 15:47 |
| cyphermox | or when you pick language from gfxboot? | 15:47 |
| cyphermox | the two might behave differently. | 15:47 |
| cyphermox | (it's wrong, but I think I see why they would behave differently) | 15:47 |
| Laney | I did pick english at gfxboot, and then english and english(uk) and clicked on the UK in ubiquity | 15:48 |
| cyphermox | well, timezone won't change anything but timezone | 15:49 |
| cyphermox | english in gfxboot I don't remember what it sets | 15:50 |
| Laney | me neither | 15:50 |
| Laney | but it does at least know that I chose en_GB after running localechooser | 15:50 |
| cyphermox | yeah, but I wonder if the issue is that one of the code paths doesn't set debian-installer/locale somewhere it should be set | 15:51 |
| Laney | db_get can see it right up until it can't any more (in install.py) | 15:54 |
| cyphermox | ok | 15:55 |
| cyphermox | can you check what pkgsel/language-packs is set to? | 15:55 |
| Laney | sure, at which point? | 15:56 |
| cyphermox | uh, anywhere after picking language, and then around the end of the install (when install.py runs) | 16:00 |
| cyphermox | I don't think it'd be much different between the two | 16:00 |
| cyphermox | wait, no | 16:00 |
| cyphermox | don't bother | 16:00 |
| cyphermox | I remember this is a preseeded thing on CD | 16:01 |
| cyphermox | it's not? | 16:08 |
| cyphermox | hrm | 16:08 |
| Laney | what's this? | 16:08 |
| cyphermox | I expected pkgsel/language-packs to be preseeded to something | 16:09 |
| cyphermox | but I went to check all the way back to precise | 16:09 |
| Laney | that codepath is not used in a regular iso install | 16:12 |
| Laney | it's the localechooser/supported-locales one | 16:12 |
| Laney | supplemented with debian-installer/locale which is what ubiquity decided you wanted | 16:12 |
| Laney | (that last one is the one that is buggily not set properly) | 16:14 |
| cyphermox | well, either one should be set to /something/ | 16:18 |
| Laney | supported-locales is en_US.UTF-8 for me | 16:18 |
| cyphermox | ok | 16:20 |
| cyphermox | so maybe we screwed up localechooser? | 16:20 |
| Laney | ohhhh | 17:03 |
| Laney | is this a race? | 17:03 |
| Laney | we start installing in the background right? | 17:03 |
| cyphermox | yeah | 18:15 |
| cyphermox | but like I said, the timezone doesn't really matter | 18:15 |
| cyphermox | you don't start install until after partitioning, which is after picking language | 18:15 |
| cyphermox | (but before picking keyboard) | 18:15 |
| cyphermox | that said, you did point out what matters is localchooser, which is run as you pick language, not when you pick keybaord | 18:15 |
| cyphermox | (and it's preseeded even earlier if you pick language at gfxboot) | 18:16 |
| cyphermox | I think we should debug this further, add enought prints in the code to output what the debconf values are at the time install_misc.py runs | 18:17 |
| cyphermox | Laney: could be racey | 18:42 |
| cyphermox | looks like I got fr_CA working first try | 18:42 |
| Laney | cyphermox: it takes the country you pick in the timezone step into account | 22:31 |
| Laney | I think the fix would be basically to not start installing until after ubi-tiemzone | 22:31 |
| Laney | but you have to do that weird debconf stop / start thing to make sure it is committed at that time afaics | 22:32 |
| Laney | will test it a bit more and probably propose something over the weekend | 22:32 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!