[01:04] PR snapd#5969 closed: apparmor: add unit test for probeAppArmorParser and simplify code [01:27] PR snapcraft#2356 closed: nodejs plugin: add support for bases === chihchun_afk is now known as chihchun [05:00] morning === chihchun is now known as chihchun_afk [06:15] Good morning [06:17] zyga: hey [06:19] Cold morning [06:21] hey zyga [06:22] Hey, how are you? [06:24] zyga: good, thank you - how are you? [06:25] mvo: morning [06:26] Good, last evening was fun :-) we loved the movie [06:26] hey mborzecki [06:26] lots of green tests today? [06:31] finally :) [06:32] PR snapd#5948 closed: asserts, image: ensure kernel, gadget, base and required-snaps use valid snap names [06:49] PR snapd#6003 closed: cmd/snap: block 'snap help --all' [06:50] PR snapd#6005 closed: snap/pack, snap/squashfs: remove extra copy before mksquashfs [06:51] PR snapd#5999 closed: tests: ensure that goa-daemon is off [06:51] Hey, my 10 snaps games are published for a while. Only two of them appear in the listing of snapcraft.io when searching in "Games", but appears in "All snaps". It seems Categories Game is not correctly detected. It happens also for many other Snaps. [06:54] Hey, slvn_ - I would recommend to ask in the four of you don’t get a reply here. It is still early and store people are in other time zones as well [06:54] slvn_: s/four/forum/ [06:55] But do come back if you don’t get a reply! Thank you for making snaps :-) [06:55] * zyga responds from a phone [06:56] mornings [06:57] Dzień dobry [06:59] PR snapd#5997 closed: ifacestate: simplify task chaining in ifacestate.Connect [07:16] thanks, ok! I'll repost in a few hours [07:18] pstolowski: cześć :) [07:18] guten tag mvo :) [07:18] (not to force one minority language upon others) [07:20] https://www.reddit.com/r/linux/comments/9ool14/xdgportal_support_landed_on_firefox_nightly/ [07:21] that's cool [07:35] Download (curl) error for 'http://download.opensuse.org/update/leap/42.3/oss/x86_64/libgcrypt20-32bit-1.6.1-45.1.x86_64.rpm': [07:35] heh [07:40] zyga, btw, who should be contacted for http://snapcraft.io issue ? === sparkieg` is now known as sparkiegeek [07:49] slvn_: if you look in the footer, you'll see links to where to file bugs [08:01] PR snapd#5979 closed: install: don't start disabled services [08:03] mvo: could you please review https://github.com/snapcore/snapd/pull/5727 - this is affecting Firefox in the wild and it would be good to have in 2.36 [08:03] PR #5727: interfaces/builtin, cmd/snap-seccomp: Allow read-only ptrace, for the Breakpad crash reporter [08:05] zyga: this is waiting for a security review, no? happy to do a review but it seems we need jamie, no? [08:05] yeah, I suppose you are right [08:07] https://github.com/snapcore/snapd/pull/6004 is green and I'd love to land it - it is just tweaking debug messages [08:07] PR #6004: cmd/snap-confine: reduce verbosity of debug and error messages [08:13] * zyga goes to bring a heater into the office [08:13] I miss the days of Pentium 4 heaters [08:28] mvo, zyga: hey, could you fill in a bug for the non-working wifi here if you have a moment? https://bugs.launchpad.net/snap-core18 [08:29] sure [08:29] wow [08:29] no bugs [08:29] must be some decent software! [08:31] Chipaca: what if we move static checks to a separate job? [08:31] (/me deletes all bugs after they pop up) [08:32] sil2100: added a bug (cc zyga) [08:32] Chipaca: unit tests already take ~8 minutes, so the stage is 8+ minutes anyway [08:32] oh [08:32] do you want both? :) [08:32] I just wrote mine but haven't sent it [08:32] well, you have two now [08:32] :) [08:32] sorry! [08:32] mborzecki: 1/8th is still a serious chunk in the wrong direction [08:33] mborzecki: static checks in a separate job would work, but I worry about using too many jobs [08:33] Chipaca: if you take the 1-2m off unit tests & static checks, and put it in a separate job, the total of the 1st stage should not be significantly affected [08:34] Chipaca: probably only way to know is to arrange it that way :) [08:34] mborzecki: I'll do it, and then we see :-) [08:34] Chipaca: ok [08:34] static checks shouldn't need the build-dep [08:35] hm we do run some go tools as static checks though [08:35] misspel, vet? [08:35] a lot [08:35] but go is there already [08:35] we need the build deps for the c libs [08:35] oh, btw. i had that branch with gometalinter a while ago [08:36] also we could move the travis-sie unit tests to 1.10 and it might be a little bit faster [08:36] travis-side* [08:37] and, yes i can install shellcheck from snap, will need to tweak the python to look there first [08:37] or fiddle with PATH [08:37] hm [08:38] you can set SHELLCHECK=/some/path for spread-shellcheck [08:38] uh, or not [08:38] :-) [08:38] ok, that should be a trivial change :P [08:38] sil2100: added one more for you in snap-core18 bugs :) [08:39] there's SHELLCHECK_SHELL which is kind of useless because spread does bash anywya [08:39] mvo: thanks! ;) [08:39] The more bugs the merrier, right?! [08:40] mborzecki: doesn't spread run with -u on also? [08:41] PR snapd#6001 closed: interfaces: typo 'allows' for consistency with other ifaces [08:41] mvo, zyga: btw... core18 dailies! http://cdimage.ubuntu.com/ubuntu-core/18/pending/ [08:41] thanks pawel! [08:41] (didn't check if they actually work yet, since still sprinting) [08:41] I can check later today [08:44] sil2100: nice! build from what channel? [08:45] sil2100: good stuff in any case [08:45] mvo: edge by default as for 16 [08:50] Chipaca: yup, looks like -u is set [08:50] sil2100: interessting, thats a pretty high risk level. I wonder if we should reconsider this as the default (more so if that the default for uc16) [08:50] sil2100: but not now :) [08:51] It's a daily, it's like how we usually build regular images with PROPOSED enabled [08:52] But yeah, we can have a discussion about that, right now an edge-build is just what we need for testing purposes! [08:52] sil2100: ok, if it matches then thats ok I guess. edge is very edgy, probably more so than proposed. but not supper important right now [08:52] sil2100: +1 :) [08:52] Like the edge is edgy idea ;) [08:53] sil2100: in the (very) old days the term was "crack of the day" :P but of course for our stuff the CI is a huge and effective filter so that term does no longer make sense (still amusing though) [08:53] sil2100: anyway, great progress, thank you! [08:53] sil2100: does it also include detection of changes in the core18 packageset? or is that something that will come later? [08:54] i m having font problems. no fonts are availble when using colibri or flock-chat in snap. i m on fedora 28 selinux disabled. [08:55] tryed to mount the font directories as specified in mount-snap.fstab but not succeeded. [08:55] any idea [09:00] mborzecki: hehe, if I run the checks using apt-provided shellcheck on 16.04, that shellcheck has no -x option, so the lack of a stdout lock makes it look like it's had too many mushrooms [09:01] mborzecki: e.g., [09:01] el l =SHELL-NAeM CEO D E1 , C O D E2Sp..e c ify-- edxicalluedce=tC (ODbEa1s,hC,OsDh,Ek2.s.h ) [09:04] Chipaca: lol [09:05] mborzecki: thanks for the review, updated [09:10] Chipaca: haha [09:11] https://github.com/features/actions <- missing a "push to snap store" [09:13] Yo [09:13] Wa [09:13] zyga: Yeah, I thought the same thing when I saw it.. this opens up some nice possibilities [09:23] I don't know if this is powered by or simply integrated with hashicorp tech though [09:23] but something to look at for sure [09:24] Chipaca: did you see https://bugs.launchpad.net/snapd/+bug/1796125 [09:24] Bug #1796125: services in a snap with dependencies aren't started in correct order on install [09:25] anyone up for a review of #5959? [09:25] PR #5959: systemd: extend Status() to work for socket and timer units [09:25] looking [09:25] ah [09:25] I did :< [09:25] sorry [09:25] mborzecki: it has a conflict [09:27] I could really use reviews on #5957 [09:27] PR #5957: overlord/snapshotstate/backend: fall back on sudo when no runuser [09:28] zyga: didn't notice, thanks [09:29] and pushed [09:31] zyga: commented on ipc/helper pr [09:31] thanks [09:36] pstolowski: replied, thank you [09:47] zyga: I think it's completely unrelated to HashiCorp.. they just reused the HCL, which is a JSON-like format that is nicer to type by hand [09:47] ah, I didn't know that [09:48] zyga: Chipaca: left a note in #1796125, looks like this is a problem in systemd but i has gone unnoticed for years now, doesn't change the fact we should do something about that [09:48] It's a nice format.. [09:48] Bug #1796125: services in a snap with dependencies aren't started in correct order on install [09:48] just trying to figure out what fonts does and snap app use ? [09:49] zyga: Chipaca: btw. https://github.com/systemd/systemd/pull/7947 is fun to read [09:49] PR systemd/systemd#7947: man: systemctl doesn't operate multiple units in a single transaction [09:52] fwiw https://lists.freedesktop.org/archives/systemd-devel/2018-January/040122.html is fun too [09:52] alocer: sorry, what's that again? [09:52] mborzecki: sounds like we need to work around the systemd bug by ordering things ourselves as well [09:54] mborzecki: zyga: either of you have a fedora 28 so you could look into reproducing alocer's issue? [09:54] Chipaca: either that or adding Requires/RequiredBy [09:54] mborzecki: requires/requiredby means you can't stop one without t'other [09:54] Chipaca: hmm? which issue is taht [09:54] Chipaca: yeah [09:54] alocer: what's the output of 'snap version'? [09:55] zyga: no fonts in colibri [09:55] zyga: fonts ^^ ~10:53 [09:55] mborzecki: wow, I don't see that message, can you paste it again [09:55] IRC WTH? [09:55] zyga: search for alocer? [09:55] Chipaca: I looked [09:56] zyga: IRC is fine, your async client is wacko [09:56] 10:55:20 alocer | any idea [09:56] i m having font problems. no fonts are availble when using colibri or flock-chat in snap. i m on fedora 28 selinux disabled. [09:56] tryed to mount the font directories as specified in mount-snap.fstab but not succeeded. [09:56] zyga: ^ [09:56] thanks [09:56] * zyga looks [09:56] alocer: hold on please [09:56] alocer: so just install colibri and run it? [09:57] zyga: seriously it's not the first time i see irccloud mess up basic message delivery on you [09:59] alocer quit on ping timeout here [09:59] :/ [09:59] zyga: here as well [10:05] hmm https://www.irccloud.com/pastebin/uC4kEeDp/ [10:06] I see a gazillion fonts in /usr/share/fonts [10:07] when I do snap run --shell colibri I cannot get the app to start [10:07] desktophelpers quit [10:08] as I cannot reproduce the issue and I suspect the desktop-launch is at fault I would recommend someone that maintains it to look deeper [10:09] I can launch colibri by running the real command though [10:11] * zyga sighs that pastebinit is broken out of the box for several releases on fedora :/ [10:12] willcooke: hey, do you know who maintains desktop-launch? [10:12] https://paste.ubuntu.com/p/bCfTD2k65M/ <- shellcheck on the desktop helpers [10:12] I didn't investigate what failed [10:12] zyga, kenvandine [10:12] thanks! [10:13] zyga, well, desktop team, but Ken is the main man [10:13] kenvandine: hey, could you give me a hand debugging app startup issue on fedora [10:13] I can run the app just fine manually in snap run --shell [10:13] but when invoked through desktop-launch it doesn't start at all [10:13] willcooke: super, I'll work with ken on this [10:13] oSoMoN, are you able to offer any advice there too? ^ [10:16] zyga, maybe I can help, how does it fail? [10:16] oSoMoN: prints nothing at all [10:16] let me see if I can massage it to run with set -x [10:19] oSoMoN: https://paste.ubuntu.com/p/cjHb2cGhMg/ [10:19] this is from snap run --shell [10:19] oSoMoN: if I just run ./colibri it does start [10:19] but fonts look wrong [10:19] and it shows this text: [10:20] colibri invoked without desktop helpers on fedora 28 https://www.irccloud.com/pastebin/XP18dwTR/ [10:23] zyga, so it looks like it's going through the entire desktop-launch script fine, and then fails on the exec? [10:23] dunno [10:24] zyga: the fonts look a bit odd here too, a bit fuzzy i'd say [10:24] I see huge fonts [10:24] btw I have a hi-dpi setup [10:24] and the size is off too [10:24] zyga, can you comment out all of the contents of desktop-launch but the last line (exec), and see if that works? [10:25] pstolowski: can you look at https://github.com/snapcore/snapd/pull/6004#discussion_r225866841 please [10:25] PR #6004: cmd/snap-confine: reduce verbosity of debug and error messages [10:25] oSoMoN: sure [10:26] oSoMoN: done, what did you expect to happen? [10:26] I got https://paste.ubuntu.com/p/BbTqzyXmCt/ [10:26] zyga: replied [10:27] ++ cat /home/zyga/snap/colibri/8/.config/user-dirs.dirs.md5sum [10:27] + [[ 7b7b9530d5860d479bc2941ec3351c69 - != \7\b\7\b\9\5\3\0\d\5\8\6\0\d\4\7\9\b\c\2\9\4\1\e\c\3\3\5\1\c\6\9\ \ \- ]] [10:27] [10:27] this looks ... od? [10:27] odd [10:27] sorry for confusion ;) [10:27] thanks, will do :) [10:28] oSoMoN: I'n not an expert on the desktop stack but since this is a shell script and I am terrible with shell I started by running shellcheck on it, perhaps it would be good to look at the list and see if anything could be a factor [10:37] zyga, I'm not a shell script expert either [10:37] zyga, I meant to comment out everything except for the last line, looks like you did the opposite [10:37] wait, what? [10:37] so just exec? [10:38] if so then I tried that and then the application does start [10:38] so something set along the way makes it not start [10:38] niemeyer: could you please add github.com/snapcore/classic-snap to the list of things that mup watches? [10:38] mvo: Of course [10:38] thank you [10:39] https://github.com/snapcore/classic-snap/pull/20 is the PR that made me ask about it. reviews welcome :) [10:39] PR classic-snap#20: port classic to UC18 [10:41] mvo: That's done [10:41] ta [10:43] Woah... [10:43] https://usercontent.irccloud-cdn.com/file/WHV6Qd8P/image.png [10:43] That makes the day... [10:43] niemeyer: yeah! Chipaca already used it to fix typos :) [10:43] Super cool [10:44] :-) [10:45] * Chipaca wonders if "you will be attributed in the commit" is satisfied by a commit log of "$you is a fool" [10:45] mvo: reviewed [10:46] niemeyer: yeah, I saw that too, it's awesome to have that :) [10:46] perfect for typo and other things [10:46] mborzecki: snaps work on travis, but snapd isn't there by default. shellcheck on travis is 0.46, which is sufficiently new i think? [10:46] mborzecki: it's not 0.50, but 0.50 isn't even out yet :) [10:47] zyga, can I easily reproduce in a fedora VM, or does this require some preliminary set-up? [10:47] oSoMoN: just install and run [10:47] ok, I'll try that [10:48] thanks! let me know if I can help [10:49] I'm downloading a fedora ISO, I'll let you know when I reproduce the issue and start investigating it [10:49] ok [10:53] Chipaca: any chance of getting a more recent version? iirc 0.5 i had here was more picky about out code than the version in 18.04 which is 0.4.6 [10:56] mborzecki: grmbl. ok. [10:56] indeed 0.4.6 not 0.46 [11:00] hm to do start the after/before services correctly then, we'd need to do the topo sort again [11:00] s/to do/to/ [11:01] wonder if we could make that sort generic, iirc zyga will need something like this for mounts [11:01] yes please [11:01] we shoud [11:01] lattice or whatever [11:01] mborzecki: remind me, do we validate before/afters? [11:01] for cycles, i mean [11:02] Chipaca: yes, we do the 'sorting' but we're more interested in finding cycles [11:02] ah ok [11:02] Chipaca: but the algo is there [11:02] iirc we're using kahn [11:02] hah, validateAppOrderCycles [11:02] "más claro, echale agua" [11:03] i added it so i should probably be the one to fix it now :) [11:10] mborzecki: it's a lovely little algo tho [11:12] _please_ can i have reviews of #5957 [11:12] PR #5957: overlord/snapshotstate/backend: fall back on sudo when no runuser [11:13] pedronis: what's #5712 waiting for? [11:13] PR #5712: overlord: make InstallMany work like UpdateMany, issuing a single request to get candidates [11:14] Chipaca: more tests and a refactoring [11:15] Chipaca: related to the Validate*Flags helpers, if you remember I used them more uniformly now [11:15] pedronis: ah. Should it get marked Blocked? [11:15] otherwise a trigger-happy me might merge it :) [11:16] Chipaca: well, it wouldn't hurt anything [11:16] it would just need a follow up [11:16] hmm [11:16] sorry, I always hope to have that 30mins [11:16] :-D [11:16] to do the thing [11:16] but hasn't happened yet [11:17] if it's annoying I can also temporarely close it [11:17] Chipaca: done [11:17] pedronis: no planning to have 30 minutes around ubuntu release time [11:17] brb, coffee time [11:25] PR classic-snap#21 opened: create: improve user information [11:28] yay, thanks mup! [11:28] mvo: done [11:29] ta [11:29] * mvo hugs zyga [11:30] I didn't get the coffee [11:32] ok, really coffee [11:45] jdstrand: #5727 could use a once-over from you i think [11:45] PR #5727: interfaces/builtin, cmd/snap-seccomp: Allow read-only ptrace, for the Breakpad crash reporter [11:51] off to pick up the kids [12:08] re [12:08] coffee expanded into lunch [12:09] lunch? so early? [12:09] … oh wait [12:09] drat [12:09] i had a morning, once [12:11] zyga: should I do the rename I mention in #5957? [12:11] Chipaca: looking [12:11] PR #5957: overlord/snapshotstate/backend: fall back on sudo when no runuser [12:12] zyga: the 'unify' comment [12:13] thinking [12:13] I added an idea but really this is bike shed hue now :) [12:13] Chipaca: is 2PM early for lunch? [12:19] it's not [12:19] * pstolowski lunches [12:36] hi [12:37] is there a "snap" command knob to tell me if an installed snap has "strict" or "classic" confinement ? [12:40] axino: `snap info snap-name --verbose` and under "notes" [12:41] ijohnson: nice, thanks ! [12:42] Hey folks, we've got a conflict today in our standup, but would be nice to run that exercise for defining the features for the upcoming cycle.. should we/can we postpone the meeting today for an hour? [12:48] axino: if it's installed, 'snap list snap-name', if it's classic it says 'classic' in the Notes column [12:49] Chipaca: ack, thanks [12:49] niemeyer: fine by me [12:50] niemeyer: works for me [12:56] Thanks, I've moved the calendar event [12:57] Chipaca: ack, yes [13:01] uh [13:01] did standup move? [13:01] ah, I see [13:01] * zyga gets back to coding [13:01] jdstrand: thanks! :-) [13:09] PR snapd#5959 closed: systemd: extend Status() to work for socket and timer units [13:10] zyga: oSoMoN I wouldn't put too much effort in the shellcheck stuff, you might as well copy over from the extensions work (which has been shellchecked) https://github.com/snapcore/snapcraft/pull/2359/files [13:10] PR snapcraft#2359: [WIP] extensions: add glib [13:10] sergiusens: nice, thank you for the tip! [13:13] PR snapd#6007 opened: tests/lib: add an @mozilla.com exception to the CLA checker