| === Class7_ is now known as Class7 | ||
| didrocks | good morning | 07:17 |
|---|---|---|
| duflu | Morning didrocks | 07:21 |
| didrocks | hey duflu | 07:26 |
| oSoMoN | good morning desktoppers | 07:33 |
| didrocks | salut oSoMoN, bon week-end ? | 07:40 |
| oSoMoN | didrocks, très bon week-end en famille à la montagne, et toi? | 07:45 |
| didrocks | oSoMoN: pareil, mes parents sont passés pour le week-end, montré où on va faire construire, etc, c'était sympa :) | 07:45 |
| duflu | Hi oSoMoN | 07:59 |
| oSoMoN | hey duflu | 08:00 |
| seb128 | k, back, good morning IRC | 08:00 |
| seb128 | hey duflu, lut didrocks oSoMoN, did you guys had a good w.e? | 08:01 |
| duflu | Morning seb128. Not great. Half of it at the hospital. You? | 08:01 |
| seb128 | urg, sorry for you duflu :-( | 08:02 |
| oSoMoN | salut seb128, I had a great week-end, and you? | 08:02 |
| Laney | hey | 08:02 |
| seb128 | w.e was fine here, weather is still nice for the season, we spent some time outside/at the playgrounds and had friends over for dinner on saturday | 08:03 |
| seb128 | hey Laney, had a good beer festival? | 08:04 |
| didrocks | salut seb128, yeah, good week-end, great that you were able to spend time outside :) | 08:04 |
| didrocks | hey Laney! | 08:04 |
| seb128 | oh, we also went to the theatre on friday evening, that was nice as well | 08:04 |
| Laney | hey seb128 didrocks | 08:08 |
| Laney | festival was good, next morning not so much :-) | 08:08 |
| duflu | Hi Laney | 08:10 |
| Laney | what's up duflu | 08:11 |
| duflu | Stuff | 08:11 |
| duflu | n things | 08:11 |
| Laney | ah yes | 08:13 |
| didrocks | Laney: Heidelberg's effect? :) | 08:14 |
| Laney | didrocks: nothing will ever beat that | 08:15 |
| didrocks | heh | 08:15 |
| Laney | at least i hope not | 08:15 |
| didrocks | same ;) | 08:16 |
| Laney | 💀💀💀💀💀 | 08:16 |
| didrocks | "on a scale from 0 to Heidelberg, how was it?" :)) | 08:16 |
| Laney | ah that's easy, Heidelberg * 0.25 | 08:23 |
| didrocks | heh | 08:24 |
| === ecloud is now known as ecloud_wfh | ||
| didrocks | Trevinho: I would like your opinion on my fix in https://code.launchpad.net/~didrocks/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/357609 (this is why I did a MP). I don't see any other way to have realpath() accessible to gjs. This is to fix bug #1798747. I don't think this is really upstreamable as there is no support for theming (and even less for symlinks/alternatives…) | 08:50 |
| ubot5 | bug 1798747 in gnome-shell (Ubuntu) "Ticks in gdm do not show" [Medium,In progress] https://launchpad.net/bugs/1798747 | 08:50 |
| andyrock | didrocks: are you using gbp? | 09:08 |
| didrocks | andyrock: I didn't on that one, because I worked on the source package | 09:11 |
| didrocks | directly (other machine, vm, as --replace is broken in GNOME Shell :/) | 09:12 |
| didrocks | the patch applies though, shouldn't change its content :p | 09:12 |
| Laney | didrocks: that looks like it leaks to me, realpath() is transfer full afaik | 09:49 |
| Laney | no comment on the rest of it, just drive by :P | 09:49 |
| didrocks | Laney: exactly! | 09:52 |
| didrocks | but I don't know if gjs will GC it | 09:52 |
| didrocks | or how you can do it to pass the value back to gjs which isn't invalidated | 09:52 |
| didrocks | (this is why I'm asking from some people who might be more familiar than I am with C/gjs interaction) | 09:52 |
| didrocks | I didn't find any example in the code of passing back something which has to be allocated on the heap… | 09:53 |
| Laney | didrocks: char * not const char * and strdup in the second case, maybe you need to write "Returns (transfer full):" too for the annotations? | 10:00 |
| Laney | (g_strdup) | 10:01 |
| didrocks | Laney: well, g_strdup will still allocate on the heap another variable on the heap, wouldn't it? I don't see the difference with the one allocated by realpath(), but yeah, maybe "Returns (transfer full):" annotation is what I'm missing? | 10:03 |
| didrocks | I'm sure Trevinho knows about all this if you are unsure :) | 10:04 |
| Laney | I'm not really unsure | 10:04 |
| didrocks | why doing a g_strdup? Wouldn't the annotation be sufficient without another alloc? | 10:05 |
| * didrocks adds the annotation thus | 10:05 | |
| Laney | if you add that you are telling the caller to free the return value | 10:05 |
| didrocks | sure, so, I need to remove the const | 10:06 |
| Laney | in the "return path" case that is the value that the caller passed in | 10:06 |
| Laney | so you free their string | 10:06 |
| didrocks | oh correct | 10:06 |
| didrocks | ok, didn't get where you wanted to strdup() | 10:06 |
| didrocks | makes sense thus | 10:06 |
| Laney | nod | 10:06 |
| didrocks | thanks Laney! I'll change this after lunch and have a test run | 10:06 |
| Laney | np! | 10:07 |
| didrocks | Laney: is that documented anywhere? My google foo didn't find the annotation part for gjs? | 10:07 |
| Laney | don't know about gjs, those are gobject-introspection annotations | 10:08 |
| didrocks | oh ok, maybe googling with gobject-introspection would have been better than gjs | 10:08 |
| Laney | yah, although that doesn't have the world's best documentation either :( | 10:09 |
| didrocks | ok :( at least I know, now, thanks! | 10:10 |
| didrocks | changed, tested and pushed the new rev, works well | 10:19 |
| didrocks | let's now just wait if there is an alternative without exposing realpath() manually | 10:19 |
| jibel | sil2100, did you see bug 1799097 | 10:36 |
| ubot5 | bug 1799097 in ubiquity (Ubuntu) "Install selected time zone city (Seattle) hit next hit back hit next then crash" [High,Triaged] https://launchpad.net/bugs/1799097 | 10:36 |
| jibel | ? | 10:36 |
| jibel | we missed it last week | 10:37 |
| clobrano | good morning all o/ | 10:42 |
| clobrano | didrocks: it seems that Yaru-dark has been released with Cosmic, but only gtk3 part :| | 10:43 |
| sil2100 | Ouchy | 10:59 |
| Trevinho | didrocks: when you've a sec https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-session/+git/gnome-session/+merge/357620 :) | 11:34 |
| seb128 | good morning Trevinho :) | 11:46 |
| didrocks | clobrano: I don't think so, why are yo saying this? | 12:30 |
| didrocks | Trevinho: only when you reviewed mine (see above) :) | 12:31 |
| didrocks | clobrano: I guess you mean /usr/share/themes/Yaru-dark/gtk-3.0/gtk.css, but that's needed for application which are choosing the "dark" variant of current theme | 12:32 |
| didrocks | like GNOME Boxes | 12:32 |
| didrocks | even if you selected the "light theme" | 12:32 |
| didrocks | side effect is that I bet tools like Tweaks are showing them :/ | 12:32 |
| clobrano | didrocks: I see, but it seems that users can select it from tweaks | 12:33 |
| clobrano | https://github.com/ubuntu/yaru/issues/654#issuecomment-431567204 | 12:33 |
| gitbot | ubuntu issue 654 in yaru "Missing gtk2 theme in Yaru" [Closed] | 12:33 |
| clobrano | ^ having problem when using gtk2 applications of course | 12:33 |
| didrocks | clobrano: yeah, but well, there are reasons we don't ship Tweaks and such… | 12:34 |
| didrocks | so, people are expected to know what they do when they install additional software, and nothing we can from preventing them shooting in their feet (only closing bugs…) | 12:35 |
| clobrano | didrocks: :D I understand | 12:35 |
| clobrano | yes, I read your other post about this, I was indeed expecting that the reason was the same | 12:35 |
| ahayzen | defaulting to adwaita rather than raleigh when the theme is missing for gtk2 apps, can make it less horrible :-) | 12:36 |
| didrocks | clobrano: actually /usr/share/themes/Yaru/gtk-3.0/gtk-dark.css might be enough… | 12:37 |
| clobrano | ahayzen: indeed, it would be an improvement | 12:37 |
| didrocks | clobrano: and indeed, there is an issue in the packaging | 12:37 |
| didrocks | grrr | 12:37 |
| clobrano | doh | 12:38 |
| didrocks | I rm after dh_install | 12:38 |
| didrocks | so, I indeed tested that /usr/share/themes/Yaru/gtk-3.0/gtk-dark.css was enough, my bad | 12:38 |
| didrocks | clobrano: mind opening a bug? | 12:38 |
| didrocks | (on launchpad) | 12:38 |
| didrocks | I will fix it/turn it into a SRU | 12:38 |
| clobrano | didrocks: sure | 12:38 |
| didrocks | clobrano: so, if we do a SRU upload, I'll check again, but everything in master is compatible with a SRU, correct? Anything I should wait on? | 12:39 |
| clobrano | didrocks: I just double checked, the master is the same as Cosmic release now | 12:40 |
| clobrano | no new content, we were actually waiting to be sure we can go on | 12:40 |
| jbicha | Tweaks intentionally doesn't require a gtk2 theme any more to show a theme in the theme chooser since it's quite possible to use a system without gtk2 now | 12:41 |
| jbicha | we could override that for Yaru if we really wanted to though | 12:41 |
| didrocks | clobrano: hum, there is the poperover fix + treeview + evolution: https://github.com/ubuntu/yaru/commits/master | 12:41 |
| didrocks | but they are fine | 12:41 |
| didrocks | popover* | 12:41 |
| clobrano | ok | 12:42 |
| didrocks | clobrano: anything particular you want to fix before we release? (could be later this week) | 12:42 |
| didrocks | (or pending on someone to fix? :)) | 12:42 |
| clobrano | didrocks: there is the suru icons update ready to be merged and this one as well https://github.com/ubuntu/yaru/pull/899 | 12:44 |
| gitbot | ubuntu issue (Pull request) 899 in yaru "Post cosmic release: infobars request color change & less upstream diff" [Open] | 12:44 |
| didrocks | clobrano: hum, a little bit large for a SRU (and more cleanups) | 12:44 |
| didrocks | + color changes | 12:45 |
| didrocks | which isn't really SRU-materials | 12:45 |
| clobrano | didrocks: I see | 12:45 |
| didrocks | (minor adjustements are ok, if there is a rationale) | 12:45 |
| didrocks | unsure what sil2100 thinks for instance ^ | 12:45 |
| clobrano | I understand, then no, no other PRs | 12:45 |
| ahayzen | didrocks, what happens to someone that has selected Yaru-dark as their theme and then this update occurs ? I know it is effectively an unsupported path as they used Tweaks, but does it fallback to the default theme or something? | 12:47 |
| didrocks | clobrano: ok, I will cut a release later today | 12:47 |
| clobrano | thanks | 12:47 |
| didrocks | ahayzen: that's a good question, I'm afraid it will fallback to Adwaita, as for people who have manually set communitheme by default | 12:47 |
| didrocks | rather than using the session | 12:48 |
| ahayzen | ok, well they managed to use Tweaks to change to Yaru-dark so they can probably figure out how to change it to something else if it does go to Adwaita. Just as long as they aren't in a totally broken state :-) | 12:48 |
| didrocks | ahayzen: that's the rationale :) | 12:49 |
| didrocks | funny, we just had that discussion on the hub btw (but with "communitheme") | 12:50 |
| jbicha | didrocks: what about just installing the Yaru (non-dark) gtk2 theme to Yaru-dark? | 12:50 |
| clobrano | didrocks: it seems that communitheme project on launchpad is not completely configured, is that possible? | 12:50 |
| clobrano | ^ configured to open bugs | 12:50 |
| didrocks | jbicha: we didn't intend to ship -dark anyway for now | 12:51 |
| didrocks | clobrano: "yaru-theme" package: https://launchpad.net/ubuntu/+source/yaru-theme | 12:51 |
| clobrano | oh, looking for "yaru" did't find any project... | 12:51 |
| didrocks | yeah, the source package has -theme | 12:52 |
| didrocks | clobrano: and then, mind reviewing this very complicated change to not ship dark theme? https://github.com/ubuntu/yaru/pull/929 :p | 12:55 |
| gitbot | didrocks: Error: ubuntu: Impossible to get infos for ubuntu/yaru issue 929: 404 {'message': 'Not Found', 'documentation_url': 'https://developer.github.com/v3/issues/#get-a-single-issue'} | 12:55 |
| didrocks | (the idea is: "really install in package AFTER removing the files…) | 12:56 |
| didrocks | " | 12:56 |
| didrocks | did a local build, and indeed, works as expected… | 12:56 |
| clobrano | didrocks: it seems that the link is wrong | 12:57 |
| Trevinho | didrocks: ah, I noticed the mention for the gjs thing but not the one for the mp, on it on that | 12:57 |
| clobrano | didrocks: in the meantime https://bugs.launchpad.net/ubuntu/+source/yaru-theme/+bug/1799217 | 12:57 |
| ubot5 | Ubuntu bug 1799217 in yaru-theme (Ubuntu) "Yaru-dark packaged even if not complete, nor necessary" [Undecided,New] | 12:57 |
| didrocks | clobrano: waow, I just copied the PR once opened, and I still have it here with that URL | 12:58 |
| didrocks | but it disappeared, wth? | 12:58 |
| didrocks | clobrano: thanks for the bug! | 12:58 |
| didrocks | Trevinho: thx ;) | 12:58 |
| clobrano | yeah, gh is looking for an issue929 instead of a pull, but in the PR list there is nothing anyway | 12:59 |
| didrocks | right… | 12:59 |
| didrocks | that's crazy | 12:59 |
| didrocks | wonder if it's related to yeserday's evening issue | 12:59 |
| didrocks | really really weird | 12:59 |
| didrocks | opening a new one | 12:59 |
| didrocks | Pull request creation failed. Validation failed: A pull request already exists for ubuntu:dont-ship-dark-theme. | 13:00 |
| didrocks | grrrr | 13:00 |
| didrocks | NONE LISTED | 13:00 |
| clobrano | didrocks: I even got the email about the PR... weird | 13:00 |
| didrocks | clobrano: I guess just click on the branch and the commit: https://github.com/ubuntu/yaru/branches | 13:00 |
| didrocks | "shadow PR" | 13:00 |
| didrocks | "turned into an issue before getting killed" :p | 13:00 |
| didrocks | so, the funny part | 13:01 |
| didrocks | try to click on "New pull request" | 13:01 |
| clobrano | didrocks: btw, I approve this very risky change :D | 13:01 |
| didrocks | you will get the message I showed above ^ | 13:02 |
| didrocks | but there is a "View pull request" button | 13:02 |
| didrocks | which shows it, with the same URL than initially | 13:02 |
| didrocks | copy the link, open a new tab, paste it -> redirect to /issues/929 | 13:02 |
| didrocks | crazyyyyy | 13:02 |
| clobrano | indeed | 13:02 |
| didrocks | someone messed up their router I guess :p | 13:03 |
| clobrano | there's an easter egg for PR 929 | 13:03 |
| didrocks | clobrano: thanks for looking at it and mentioning it! Pushing directly thus :p | 13:03 |
| didrocks | heh | 13:03 |
| didrocks | oh, even better, let me try to merge from this shadow route ^ | 13:03 |
| clobrano | alright 👍 | 13:03 |
| clobrano | uhu, pioneer of shadow pr | 13:03 |
| didrocks | it worked! :p | 13:03 |
| clobrano | \0/ | 13:04 |
| didrocks | achievement unlocked: merging from an unexisting PR | 13:04 |
| clobrano | :D | 13:20 |
| didrocks | clobrano: yaru-theme in UNAPPROVED (waiting for a SRU team member to review/ack) and bug changed to follow the SRU format | 13:58 |
| clobrano | didrocks: damn, sorry, should have done it myself | 13:59 |
| didrocks | clobrano: no worry at all :) | 13:59 |
| didrocks | Trevinho: get_symlink_target(), this was what I was trying to furiously find in glib! Thanks for the review | 14:04 |
| Trevinho | didrocks: np :) | 14:06 |
| Laney | doing that with a loop feels bad | 14:13 |
| Laney | when realpath exists | 14:14 |
| didrocks | at least, needs a good comment | 14:14 |
| didrocks | not crossing the C -> js barrier makes sense | 14:14 |
| didrocks | well… actually Glib. does it… | 14:14 |
| didrocks | so yeah, unsure as well | 14:14 |
| didrocks | I guess it's either we stay in the Glib realm or not… | 14:14 |
| === Class7_ is now known as Class7 | ||
| jibel | didrocks, I'm updating some iso test cases and i've a question about minimal installation: after a minimal installation "apt autoremove" should be empty? | 15:29 |
| tomreyn | thanks for looking into my bug report :) | 15:56 |
| jibel | yw :) | 16:01 |
| didrocks | jibel: yes, that's how I did the initial list. Unsure it's been updated for cosmic though as they enhance the autoremove algorithm | 16:05 |
| didrocks | when doing dogfooding, I only tested that thunderbird & co weren't here | 16:06 |
| jibel | didrocks, ta | 16:14 |
| Laney | whoopsie | 16:33 |
| Laney | I posted on last week's topic by mistake! | 16:33 |
| === pstolowski is now known as pstolowski|afk | ||
| kenvandine | Trevinho: do you know of any bugs that would cause scaling to be reset from 200% to 100% on resume under X? | 21:40 |
| kenvandine | elmo is seeing that on 18.10 | 21:41 |
| kenvandine | sounds like a really annoying bug :/ | 21:41 |
| kenvandine | Trevinho: he said it is a regression since 18.04 | 21:42 |
| mpt | andyrock, hi, maybe the various upgrade UIs should warn you if you’re using Livepatch and are about to upgrade to a version that doesn’t have it. What do you think? <https://launchpad.net/bugs/1798839> | 22:14 |
| ubot5 | Ubuntu bug 1798839 in software-properties (Ubuntu) "Canonical Livepatch doesn't appear in "Updates" tab." [Undecided,New] | 22:14 |
| mpt | (i.e., ubuntu-release-upgrader-*) | 22:18 |
| mpt | Reported as bug 1799310 | 22:24 |
| ubot5 | bug 1799310 in ubuntu-release-upgrader (Ubuntu) "No warning when upgrading OS will turn off Livepatch" [Undecided,New] https://launchpad.net/bugs/1799310 | 22:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!