=== Class7_ is now known as Class7
didrocksgood morning07:17
dufluMorning didrocks07:21
didrockshey duflu07:26
oSoMoNgood morning desktoppers07:33
didrockssalut oSoMoN, bon week-end ?07:40
oSoMoNdidrocks, très bon week-end en famille à la montagne, et toi?07:45
didrocksoSoMoN: pareil, mes parents sont passés pour le week-end, montré où on va faire construire, etc, c'était sympa :)07:45
dufluHi oSoMoN07:59
oSoMoNhey duflu08:00
seb128k, back, good morning IRC08:00
seb128hey duflu, lut didrocks oSoMoN, did you guys had a good w.e?08:01
dufluMorning seb128. Not great. Half of it at the hospital. You?08:01
seb128urg, sorry for you duflu :-(08:02
oSoMoNsalut seb128, I had a great week-end, and you?08:02
seb128w.e was fine here, weather is still nice for the season, we spent some time outside/at the playgrounds and had friends over for dinner on saturday08:03
seb128hey Laney, had a good beer festival?08:04
didrockssalut seb128, yeah, good week-end, great that you were able to spend time outside :)08:04
didrockshey Laney!08:04
seb128oh, we also went to the theatre on friday evening, that was nice as well08:04
Laneyhey seb128 didrocks08:08
Laneyfestival was good, next morning not so much :-)08:08
dufluHi Laney08:10
Laneywhat's up duflu08:11
duflun things08:11
Laneyah yes08:13
didrocksLaney: Heidelberg's effect? :)08:14
Laneydidrocks: nothing will ever beat that08:15
Laneyat least i hope not08:15
didrockssame ;)08:16
didrocks"on a scale from 0 to Heidelberg, how was it?" :))08:16
Laneyah that's easy, Heidelberg * 0.2508:23
=== ecloud is now known as ecloud_wfh
didrocksTrevinho: I would like your opinion on my fix in https://code.launchpad.net/~didrocks/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/357609 (this is why I did a MP). I don't see any other way to have realpath() accessible to gjs. This is to fix bug #1798747. I don't think this is really upstreamable as there is no support for theming (and even less for symlinks/alternatives…)08:50
ubot5bug 1798747 in gnome-shell (Ubuntu) "Ticks in gdm do not show" [Medium,In progress] https://launchpad.net/bugs/179874708:50
andyrockdidrocks: are you using gbp?09:08
didrocksandyrock: I didn't on that one, because I worked on the source package09:11
didrocksdirectly (other machine, vm, as --replace is broken in GNOME Shell :/)09:12
didrocksthe patch applies though, shouldn't change its content :p09:12
Laneydidrocks: that looks like it leaks to me, realpath() is transfer full afaik09:49
Laneyno comment on the rest of it, just drive by :P09:49
didrocksLaney: exactly!09:52
didrocksbut I don't know if gjs will GC it09:52
didrocksor how you can do it to pass the value back to gjs which isn't invalidated09:52
didrocks(this is why I'm asking from some people who might be more familiar than I am with C/gjs interaction)09:52
didrocksI didn't find any example in the code of passing back something which has to be allocated on the heap…09:53
Laneydidrocks: char * not const char * and strdup in the second case, maybe you need to write "Returns (transfer full):" too for the annotations?10:00
didrocksLaney: well, g_strdup will still allocate on the heap another variable on the heap, wouldn't it? I don't see the difference with the one allocated by realpath(), but yeah, maybe "Returns (transfer full):" annotation is what I'm missing?10:03
didrocksI'm sure Trevinho knows about all this if you are unsure :)10:04
LaneyI'm not really unsure10:04
didrockswhy doing a g_strdup? Wouldn't the annotation be sufficient without another alloc?10:05
* didrocks adds the annotation thus10:05
Laneyif you add that you are telling the caller to free the return value10:05
didrockssure, so, I need to remove the const10:06
Laneyin the "return path" case that is the value that the caller passed in10:06
Laneyso you free their string10:06
didrocksoh correct10:06
didrocksok, didn't get where you wanted to strdup()10:06
didrocksmakes sense thus10:06
didrocksthanks Laney! I'll change this after lunch and have a test run10:06
didrocksLaney: is that documented anywhere? My google foo didn't find the annotation part for gjs?10:07
Laneydon't know about gjs, those are gobject-introspection annotations10:08
didrocksoh ok, maybe googling with gobject-introspection would have been better than gjs10:08
Laneyyah, although that doesn't have the world's best documentation either :(10:09
didrocksok :( at least I know, now, thanks!10:10
didrockschanged, tested and pushed the new rev, works well10:19
didrockslet's now just wait if there is an alternative without exposing realpath() manually10:19
jibelsil2100, did you see bug 179909710:36
ubot5bug 1799097 in ubiquity (Ubuntu) "Install selected time zone city (Seattle) hit next hit back hit next then crash" [High,Triaged] https://launchpad.net/bugs/179909710:36
jibelwe missed it last week10:37
clobranogood morning all o/10:42
clobranodidrocks: it seems that Yaru-dark has been released with Cosmic, but only gtk3 part :|10:43
Trevinhodidrocks: when you've a sec https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-session/+git/gnome-session/+merge/357620 :)11:34
seb128good morning Trevinho :)11:46
didrocksclobrano: I don't think so, why are yo saying this?12:30
didrocksTrevinho: only when you reviewed mine (see above) :)12:31
didrocksclobrano: I guess you mean /usr/share/themes/Yaru-dark/gtk-3.0/gtk.css, but that's needed for application which are choosing the "dark" variant of current theme12:32
didrockslike GNOME Boxes12:32
didrockseven if you selected the "light theme"12:32
didrocksside effect is that I bet tools like Tweaks are showing them :/12:32
clobranodidrocks: I see, but it seems that users can select it from tweaks12:33
gitbotubuntu issue 654 in yaru "Missing gtk2 theme in Yaru" [Closed]12:33
clobrano^ having problem when using gtk2 applications of course12:33
didrocksclobrano: yeah, but well, there are reasons we don't ship Tweaks and such…12:34
didrocksso, people are expected to know what they do when they install additional software, and nothing we can from preventing them shooting in their feet (only closing bugs…)12:35
clobranodidrocks: :D I understand12:35
clobranoyes, I read your other post about this, I was indeed expecting that the reason was the same12:35
ahayzendefaulting to adwaita rather than raleigh when the theme is missing for gtk2 apps, can make it less horrible :-)12:36
didrocksclobrano: actually /usr/share/themes/Yaru/gtk-3.0/gtk-dark.css might be enough…12:37
clobranoahayzen: indeed, it would be an improvement12:37
didrocksclobrano: and indeed, there is an issue in the packaging12:37
didrocksI rm after dh_install12:38
didrocksso, I indeed tested that /usr/share/themes/Yaru/gtk-3.0/gtk-dark.css was enough, my bad12:38
didrocksclobrano: mind opening a bug?12:38
didrocks(on launchpad)12:38
didrocksI will fix it/turn it into a SRU12:38
clobranodidrocks: sure12:38
didrocksclobrano: so, if we do a SRU upload, I'll check again, but everything in master is compatible with a SRU, correct? Anything I should wait on?12:39
clobranodidrocks: I just double checked, the master is the same as Cosmic release now12:40
clobranono new content, we were actually waiting to be sure we can go on12:40
jbichaTweaks intentionally doesn't require a gtk2 theme any more to show a theme in the theme chooser since it's quite possible to use a system without gtk2 now12:41
jbichawe could override that for Yaru if we really wanted to though12:41
didrocksclobrano: hum, there is the poperover fix + treeview + evolution: https://github.com/ubuntu/yaru/commits/master12:41
didrocksbut they are fine12:41
didrocksclobrano: anything particular you want to fix before we release? (could be later this week)12:42
didrocks(or pending on someone to fix? :))12:42
clobranodidrocks: there is the suru icons update ready to be merged and this one as well https://github.com/ubuntu/yaru/pull/89912:44
gitbotubuntu issue (Pull request) 899 in yaru "Post cosmic release: infobars request color change & less upstream diff" [Open]12:44
didrocksclobrano: hum, a little bit large for a SRU (and more cleanups)12:44
didrocks+ color changes12:45
didrockswhich isn't really SRU-materials12:45
clobranodidrocks: I see12:45
didrocks(minor adjustements are ok, if there is a rationale)12:45
didrocksunsure what sil2100 thinks for instance ^12:45
clobranoI understand, then no, no other PRs12:45
ahayzendidrocks, what happens to someone that has selected Yaru-dark as their theme and then this update occurs ?  I know it is effectively an unsupported path as they used Tweaks, but does it fallback to the default theme or something?12:47
didrocksclobrano: ok, I will cut a release later today12:47
didrocksahayzen: that's a good question, I'm afraid it will fallback to Adwaita, as for people who have manually set communitheme by default12:47
didrocksrather than using the session12:48
ahayzenok, well they managed to use Tweaks to change to Yaru-dark so they can probably figure out how to change it to something else if it does go to Adwaita. Just as long as they aren't in a totally broken state :-)12:48
didrocksahayzen: that's the rationale :)12:49
didrocksfunny, we just had that discussion on the hub btw (but with "communitheme")12:50
jbichadidrocks: what about just installing the Yaru (non-dark) gtk2 theme to Yaru-dark?12:50
clobranodidrocks: it seems that communitheme project on launchpad is not completely configured, is that possible?12:50
clobrano^ configured to open bugs12:50
didrocksjbicha: we didn't intend to ship -dark anyway for now12:51
didrocksclobrano: "yaru-theme" package: https://launchpad.net/ubuntu/+source/yaru-theme12:51
clobranooh, looking for "yaru" did't find any project...12:51
didrocksyeah, the source package has -theme12:52
didrocksclobrano: and then, mind reviewing this very complicated change to not ship dark theme? https://github.com/ubuntu/yaru/pull/929 :p12:55
gitbotdidrocks: Error: ubuntu: Impossible to get infos for ubuntu/yaru issue 929: 404 {'message': 'Not Found', 'documentation_url': 'https://developer.github.com/v3/issues/#get-a-single-issue'}12:55
didrocks(the idea is: "really install in package AFTER removing the files…)12:56
didrocksdid a local build, and indeed, works as expected…12:56
clobranodidrocks: it seems that the link is wrong12:57
Trevinhodidrocks: ah, I noticed the mention for the gjs thing but not the one for the mp, on it on that12:57
clobranodidrocks: in the meantime https://bugs.launchpad.net/ubuntu/+source/yaru-theme/+bug/179921712:57
ubot5Ubuntu bug 1799217 in yaru-theme (Ubuntu) "Yaru-dark packaged even if not complete, nor necessary" [Undecided,New]12:57
didrocksclobrano: waow, I just copied the PR once opened, and I still have it here with that URL12:58
didrocksbut it disappeared, wth?12:58
didrocksclobrano: thanks for the bug!12:58
didrocksTrevinho: thx ;)12:58
clobranoyeah, gh is looking for an issue929 instead of a pull, but in the PR list there is nothing anyway12:59
didrocksthat's crazy12:59
didrockswonder if it's related to yeserday's evening issue12:59
didrocksreally really weird12:59
didrocksopening a new one12:59
didrocksPull request creation failed. Validation failed: A pull request already exists for ubuntu:dont-ship-dark-theme.13:00
didrocksNONE LISTED13:00
clobranodidrocks: I even got the email about the PR... weird13:00
didrocksclobrano: I guess just click on the branch and the commit: https://github.com/ubuntu/yaru/branches13:00
didrocks"shadow PR"13:00
didrocks"turned into an issue before getting killed" :p13:00
didrocksso, the funny part13:01
didrockstry to click on "New pull request"13:01
clobranodidrocks: btw, I approve this very risky change :D13:01
didrocksyou will get the message I showed above ^13:02
didrocksbut there is a "View pull request" button13:02
didrockswhich shows it, with the same URL than initially13:02
didrockscopy the link, open a new tab, paste it -> redirect to /issues/92913:02
didrockssomeone messed up their router I guess :p13:03
clobranothere's an easter egg for PR 92913:03
didrocksclobrano: thanks for looking at it and mentioning it! Pushing directly thus :p13:03
didrocksoh, even better, let me try to merge from this shadow route ^13:03
clobranoalright 👍13:03
clobranouhu, pioneer of shadow pr13:03
didrocksit worked! :p13:03
didrocksachievement unlocked: merging from an unexisting PR13:04
didrocksclobrano: yaru-theme in UNAPPROVED (waiting for a SRU team member to review/ack) and bug changed to follow the SRU format13:58
clobranodidrocks: damn, sorry, should have done it myself13:59
didrocksclobrano: no worry at all :)13:59
didrocksTrevinho: get_symlink_target(), this was what I was trying to furiously find in glib! Thanks for the review14:04
Trevinhodidrocks: np :)14:06
Laneydoing that with a loop feels bad14:13
Laneywhen realpath exists14:14
didrocksat least, needs a good comment14:14
didrocksnot crossing the C -> js barrier makes sense14:14
didrockswell… actually Glib. does it…14:14
didrocksso yeah, unsure as well14:14
didrocksI guess it's either we stay in the Glib realm or not…14:14
=== Class7_ is now known as Class7
jibeldidrocks, I'm updating some iso test cases and i've a question about minimal installation: after a minimal installation "apt autoremove" should be empty?15:29
tomreynthanks for looking into my bug report :)15:56
jibelyw :)16:01
didrocksjibel: yes, that's how I did the initial list. Unsure it's been updated for cosmic though as they enhance the autoremove algorithm16:05
didrockswhen doing dogfooding, I only tested that thunderbird & co weren't here16:06
jibeldidrocks, ta16:14
LaneyI posted on last week's topic by mistake!16:33
=== pstolowski is now known as pstolowski|afk
kenvandineTrevinho: do you know of any bugs that would cause scaling to be reset from 200% to 100% on resume under X?21:40
kenvandineelmo is seeing that on 18.1021:41
kenvandinesounds like a really annoying bug :/21:41
kenvandineTrevinho: he said it is a regression since 18.0421:42
mptandyrock, hi, maybe the various upgrade UIs should warn you if you’re using Livepatch and are about to upgrade to a version that doesn’t have it. What do you think? <https://launchpad.net/bugs/1798839>22:14
ubot5Ubuntu bug 1798839 in software-properties (Ubuntu) "Canonical Livepatch doesn't appear in "Updates" tab." [Undecided,New]22:14
mpt(i.e., ubuntu-release-upgrader-*)22:18
mptReported as bug 179931022:24
ubot5bug 1799310 in ubuntu-release-upgrader (Ubuntu) "No warning when upgrading OS will turn off Livepatch" [Undecided,New] https://launchpad.net/bugs/179931022:24

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!