/srv/irclogs.ubuntu.com/2018/10/29/#snappy.txt

mupPR snapcraft#2381 closed: tools: copy in spread-shellcheck from snapd <Created by chipaca> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2381>00:36
AuroraAvenueseems to a docker issue.05:40
AuroraAvenuehttps://askubuntu.com/questions/1088170/docker-volume-error-over-snaps05:40
=== cpaelzer_ is now known as cpaelzer
mborzeckimorning06:06
=== chihchun_afk is now known as chihchun
zygaHello06:58
mborzeckizyga: hey06:59
mborzeckizyga: seen the news/06:59
zygaYes, interesting times07:36
zygaSome small errands in the morning07:36
zygaBut I will be around shortly07:36
mvohey zyga !07:36
mvozyga: good morning07:37
mvozyga: interessting times indeed07:37
zygaHey mvo07:37
zygaHow are you feeling?07:37
zygaWe have one page of reviews :-)07:37
mborzeckimvo: hey, nice to have you back :)07:38
sil2100mvo: welcome back! ;)07:41
mvomborzecki, sil2100 thank you!07:42
mvozyga: \o/ one page of reviews - awesome07:42
mvozyga: I feel very tired :)07:42
mvobut beside that very happy to be back and being able to code again07:42
mborzeckimvo: i've took the liberty and pushed some changes to #6039, hope you don't mind07:43
mupPR #6039: snapstate: do not allow classic mode for strict snaps <Created by mvo5> <https://github.com/snapcore/snapd/pull/6039>07:43
mvomborzecki: thank you!07:44
mvomborzecki: I have a look07:44
zygaI tried to as well but I could not make it pass so I aborted07:45
mvomborzecki, zyga thank you guys! sorry that the tests were in a bad state, it was just hard to focus during the sprint but I get back to it today :)07:46
mvoI hope you had a good time?07:46
mvoanything I should know and missed?07:46
mvosil2100: how are the stable images looking? I just promoted snapd 2.36 to stable (after a quick smoke test)07:47
zygare07:59
zygamvo: no worries man, you did great08:00
zygamvo: I meant that I failed to make it better08:00
zygait was late that night08:00
zygamvo: we need to cherry pick one patch into stable08:00
zygamvo: please ensure this is in the next release https://github.com/snapcore/snapd/pull/604408:00
mupPR #6044: cmd/snap-confine: remove stale mount profile along stale namespace <āš  Critical> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6044>08:00
zyga(of any kind)08:00
=== pstolowski|afk is now known as pstolowski
pstolowskimorning guys, hey mvo, welcome back!08:01
zygahey pawel!08:01
zygapstolowski: did you read the news?08:02
zygatoday is going to be interesting08:02
zygaand hey,08:02
zygafedora 29 ships tomorrow08:02
zygaI wonder if people will notice that :)08:02
zyga(timing is a bit unfortunate)08:02
zygamvo: not sure if good morning material08:02
zygahttps://github.com/snapcore/snapd/pull/517008:02
zygathis is ready and green08:02
zygaand only missing an ack from gustavo08:02
mupPR #5170: interfaces/builtin: add adb-support interface <Created by zyga> <https://github.com/snapcore/snapd/pull/5170>08:02
zygabut it implements exactly what he asked for08:02
zygaso maybe we can land it?08:03
mvohey pstolowski !08:03
mvozyga: nice, I have a look over the open PRs next08:04
zygawoot, thank you :)08:04
zygaI will work on user mounts, so many little things have landed already08:04
zygaI need to run an errand around 11-1308:04
zygabut otherwise I will be here08:04
mvozyga: anything else we need in 2.36?08:05
zygamvo: perhaps but not from me08:05
zygamvo: I think there are some things though08:05
zygabut my mind is very rusty still08:05
zygawe need to check the regression08:05
pstolowskizyga: ibm&redhat, or something else?08:05
zygabut I believe there was something else as well08:05
zygapstolowski: yep08:05
mvozyga: no worries, I will check if anything is marked08:05
zygapstolowski: anything from you for 2.36?08:05
pstolowskiright08:05
kjackalhttps://github.com/kubeflow/kubeflow/issues/185408:06
zygamvo: perhaps cherry pick https://github.com/snapcore/snapd/pull/5739 if feasible08:07
mupPR #5739: interfaces/default: don't scrub with change_profile with classic <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5739>08:07
pstolowskizyga: nothing new from me for 2.36, the 2 criticals i had are there already08:08
zygapstolowski: great08:09
zygapstolowski: in 2.36 or in edge?08:09
zyga(master)08:09
pstolowskizyga: in release/2.3608:15
zygamborzecki: anything for 2.36 you want in badly?08:23
mborzeckizyga: not really08:24
mborzeckiwe're doing .1 already?08:24
mvomborzecki: yeah, I think we need a .1 anyway08:26
mvomborzecki: iirc zyga mentioned something critical, need to log at the branch to remember what it was exactly08:27
sil2100mvo: thanks! So far so good, they're still in testing by the cert team, I'm waiting for the US to wake up to get more info08:27
sil2100mvo: didn't see any news since Friday08:27
zygamvo: there's this as well: https://github.com/snapcore/snapd/pull/602608:28
mupPR #6026: cmd/snap: try not to panic on error from "snap try" <āš  Critical> <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6026>08:28
mvosil2100: thank you08:28
mvosil2100: fwiw, the pi3 b+ works for me now with 4.1508:28
sil2100mvo: should we re-spin for the new snapd? Is there anything critical in the 2.36 for core18 GA?08:28
zygaand this but I presume this is in the release branch as well https://github.com/snapcore/snapd/pull/6027 (didn't check)08:28
sil2100mvo: \o/ ;)08:28
mupPR #6027: overlord/ifacestate: don't conflict on own discard-snap tasks when refreshing & doing garbage collection <Squash-merge> <āš  Critical> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6027>08:28
mupPR snapd#6053 closed: cmd/snap, daemon, strutil: use CommaSeparatedList to split a CSL <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6053>08:29
mborzeckimvo: in that case https://github.com/snapcore/snapd/pull/6030 is a nice improvement and https://github.com/snapcore/snapd/pull/6049 may help resolve dbus issues we were seeing under spread08:30
mupPR #6030: cmd/snap: tweak `snap services` output when there is no services <Simple šŸ˜ƒ> <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6030>08:30
mupPR #6049: cmd/snap, userd, testutil: tweak DBus tests to use private session bus connection <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6049>08:30
mupPR snapd#6054 opened: strutil: add extra test to CommaSeparatedList as suggested by mborzecki <Created by mvo5> <https://github.com/snapcore/snapd/pull/6054>08:32
zygamvo: you can also perhaps consider https://github.com/snapcore/snapd/pull/6048 for 2.36 - it is a low risk bugfix08:41
mupPR #6048: cmd/snap-exec: don't fail on some try mode snaps <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6048>08:41
mvozyga: thanks, I check that (and the ones from mborzecki) out now08:46
mupPR snapd#6055 opened: tests/main: fixes for the new shellcheck <Created by mvo5> <https://github.com/snapcore/snapd/pull/6055>09:01
zygaHey Chipaca09:09
Chipacazyga: oi music turtle09:30
zygaNice, each?09:32
zygaEh :-)09:32
Chipacayeah09:33
Chipacai think this just nerd-sniped my brother :-)09:33
zygaIā€™m waking up, slow day ahead09:33
zygaI love things like that,09:33
zygaExactly the software that shapes imagination09:33
chestyHi, I was chatting to Chipaca earlier, he pin pointed the problem I'm having with an x2goclient snap I'm playing with. x2goclient is trying to open /var/lib/gdm3/.ssh/known_hosts when trying to open a connection (it uses libssh), my user isn't in /etc/passwd, it's on freeipa and the last entry in /etc/passwd is the gdm user with the home /var/lib/g09:34
chestydm3. So it appears libssh is trying to find my users home dir, it isn't found in /etc/passwd so it uses the home dir of the last entry in /etc/passwd.09:34
Chipacazyga: ^ is anything we're doing using the last entry in /etc/passwd when it doesn't find something?09:35
Chipacaor is that libssh?09:35
zygaHmmmmm09:35
zygaThat would be weird, let me think and look09:35
Chipacachesty: did you add a line to /etc/passwd to check it was the last line and not some even weirder fluke?09:35
Chipacachesty: when we talked last we were talking about the qt libs, where did libssh enter? is libssh qt?  (i wouldn't think so)09:36
zyga^ smart idea!09:36
Chipacamaybe it was there all the time and i missed it =)09:36
chestyChipaca, I'll do that now. btw before I was looking at x2goclients source code, it is using QDir::homePath, but I believe opening known_hosts would be done by libssh which x2goclient uses, it tunnels everything through ssh09:37
mvoChipaca: hey, good morning (have nothing for you, just want to friendly say hello :)09:39
Chipacamvo: hey! good morning =) aren't you going to take a day off or seven?09:40
mvoChipaca: yes! wed->fri I will be off09:41
mvoChipaca: but today and tomorrow I work or I will fall asleep the entire day, i.e. fighting jetlag this way :)09:42
mvoChipaca: and it works great so far (together with copious amounts of tea)09:42
Chipacachesty: https://git.libssh.org/projects/libssh.git/tree/src/misc.c#n223 says it should be falling back to HOME if getpwuid_r fails09:42
Chipacamvo: ok09:42
mvoChipaca: *but* please bear with me if I'm a bit slow today09:42
mvo(mentally)09:42
Chipacamvo: we managed to get the PRs down to one page! despite my efforts09:42
mvoChipaca: I notied, I was super impressed. I think this means that gustavo/samuelle/mvo should be away more often ;)09:43
Chipacamvo: some of the ones not closed are waiting for your (plural) reviews09:44
mvoChipaca: ok - I have a look and see what I can do to fix that :)09:45
Chipacamvo: #6054 is gtg fwiw09:46
mupPR #6054: strutil: add extra test to CommaSeparatedList as suggested by mborzecki <Simple šŸ˜ƒ> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6054>09:46
chestyI added a new user to /etc/passwd which is now the last entry and x2goclient/libssh now tries to open known_hosts in that users home dir09:46
mupPR snapd#6054 closed: strutil: add extra test to CommaSeparatedList as suggested by mborzecki <Simple šŸ˜ƒ> <Created by mvo5> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6054>09:47
mvoChipaca: looks like it got merged already :)09:47
Chipacachesty: are you running this on amd64, and is the snap you're trying to use based on 'core'?09:52
chestyyes and idk, it's ubuntu 18.04 using the 16.04 base for the snap built in a docker09:54
mupPR snapd#6055 closed: tests/main: fixes for the new shellcheck <Created by mvo5> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6055>09:54
Chipacachesty: right09:55
Chipacaso09:55
Chipacathat ssh_get_user_home_dir is buggy09:55
chestyand I believe this might  explain why things like spotify and skype snaps didn't work for me09:55
Chipacachesty: I did this: https://pastebin.ubuntu.com/p/nwTc45hDft/09:55
Chipacachesty: then I build and run it like this: gcc -Wall -o q q.c && sudo -u \#12345 ./q09:56
mupBug #12345: isdn does not work, fritz avm (pnp?) <isdnutils (Ubuntu):Fix Released by doko> <https://launchpad.net/bugs/12345>09:56
Chipacachesty: and that returns the last entry in /etc/passwd09:56
chestywow, you're a machine. I can't even open my editor that quick09:57
Chipacaand indeed, the manpage for getpwuid_r says09:57
ChipacaIf no matching password record was found,  these  functions  return  0  and09:57
Chipaca       store NULL in *result.  In case of error, an error number is returned, and NULL is st09:57
Chipacait's checking for error, but not for nothing-found09:58
chestysounds like you get to submit a pull request to libssh and earn another notch on your belt09:58
Chipacathat check hsould be   if (rc != 0 || pwdbuf == NULL) {09:58
Chipacayeah, i'm on it09:59
ChipacaI wonder if actual ssh has the same issue09:59
Chipacahow do i send a pull request to libssh though09:59
* Chipaca looks09:59
mborzeckiChipaca: hopefully not another cve for libssh :)10:01
mupPR snapd#6056 opened:  cmd/snap, userd, testutil: tweak DBus tests to use private session bus connection (2.36) <Created by mvo5> <https://github.com/snapcore/snapd/pull/6056>10:05
mborzecki#6039 is green :)10:14
mupPR #6039: snapstate: do not allow classic mode for strict snaps <Created by mvo5> <https://github.com/snapcore/snapd/pull/6039>10:14
zygamborzecki: approve it :)10:18
mborzeckizyga: heh pushed too many patches there10:19
zygaindeed,10:19
* zyga did 2nd coffee10:19
zygatoday I feel so sleepy I can barely keep my eyes open10:19
zygawhat's wrong :/10:19
zygamvo: are there any agreements on 5845 (dot-files)10:22
mvozyga: unfortunately not, I will try to come up with a better name today10:25
mvozyga: and propose that and see what happens10:25
zygano worries, thank you for letting me know10:25
mvomborzecki: \o/ for 603910:25
zygawith 23 PRs left we can easily go after what's left :)10:25
mvozyga: yeah10:27
Chipacachesty: https://bugs.libssh.org/T11810:28
Chipacachesty: and if you want you can apply that patch locally to build your snap10:29
chestyfirstly, legen, wait for it,  dary.  Secondly, I might do that soon, I will need to learn how to build a package in a snap first.  In the meantime I'm going to work around it by modifying /etc/passwd. I still haven't got x2goclient to work, now it's complaining about a missing lib, /usr/lib/libXcomp.so.3, I added ilibxcomp3 to stage-packages but it10:40
chesty's still complaining about it missing, ldding it it looks like libpng12.so.0 is missing. I wonder if that's a package dependency bug10:40
mupPR snapd#6057 opened: snap-exec: add comment about usage of ReadInfoExceptSize() <Simple šŸ˜ƒ> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6057>10:44
cjwatsonChipaca: OpenSSH does not have the same problem, as far as I can see10:45
cjwatsonI don't think they have much if any code in common10:46
Chipacacjwatson: tks10:46
mupPR snapd#6058 opened:  cmd/snap-exec: don't fail on some try mode snaps (2.36) <Created by mvo5> <https://github.com/snapcore/snapd/pull/6058>10:46
mborzeckihm postgresql* snap does not have ny services declared10:50
Chipacamborzecki: I think that's because they need to run as non-root10:54
mupPR snapd#6056 closed:  cmd/snap, userd, testutil: tweak DBus tests to use private session bus connection (2.36) <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6056>10:54
chestyI don't understand what's going on, I added libpng12-0 to stage-packages but it's not finding its way into the snap.10:57
tomwardillhi! pre-refresh hooks (again). I have a snap installed that does not have a pre-refresh hook. If i then install a new version that does, the hook does not run. It looks like the pre-refresh hook runs in the 'installed' context, not the 'to-be-installed' context. Anything I can do to fix that?11:04
Chipacatomwardill: that does not sound like something that needs fixing11:07
pstolowskitomwardill: use post-refresh hook11:07
pstolowskiit runs in the new snap11:07
tomwardillpstolowski: can a post-refresh hook reject the refresh?11:07
tomwardillcontextL I11:08
tomwardillcontext: I'm trying to avoid upgrading to a version that requires database features that we don't have in the old version11:08
zygatomwardill: who ships the database4?11:10
zygatomwardill: perhaps epochs could be used to solve that?11:10
tomwardillzyga: not us, we configure it, but using a connection that is provided by the machine admin11:11
pstolowskitomwardill: yes it should, it's run as one of many tasks handling the transition to a new revision and if it fails, we undo everything and go back to the previous revisions11:11
tomwardillyeah, it's starting to look like an epochs use case11:11
zygaaha11:11
zygatomwardill: given what you said I don't think epochs can do that11:11
tomwardillexcept we don't have superuser control, so there's not a lot we can do about it either way11:11
chestyshould libraries in usr/lib/x86_64-linux-gnu/ in the snap be found?11:11
tomwardillzyga: ah, right.11:12
tomwardillpstolowski: aha, I didn't realise post-refresh could do that, that sounds more like what I'm after then.11:12
zygachesty: if snapcraft arranges for it yes11:12
zygathey are not added to LD_LIBRARY_PATH automatically11:12
chestyoh, well there's my problem11:12
tomwardillpstolowski, zyga: I'll give post-refresh a poke and see if that will do what I'm after. Thanks for the help :)11:13
pstolowskitomwardill: sure, yw. simply make it exit with !=0 to make entire change fail11:13
Chipacachesty: that's usually done by a wrapper script11:16
Chipacatomwardill: pstolowski: zyga: note epochs aren't there yet11:17
chestyChipaca, will this work too? https://stackoverflow.com/questions/42991501/snapcraft-custom-ld-library-path11:17
tomwardillah yeah, that is also a problem for that approach :)11:17
Chipacachesty: given that that kyle is this kyrofa, i'd say it'll either work or you can harass him (you win either way!)11:18
Chipacachesty: although you two are mutually antipodean11:19
Chipacaso good luck11:19
Chipaca(well, not exactly, kyrofa might be -8 or something)11:19
pstolowskicachio: hey!11:25
pstolowskicachio: fyi, i've found the way for passing custom serial number to serial port adapters created with qemu11:25
mvohas anyone seen:11:28
mvoFAIL: <autogenerated>:1: ctxSuite.TestWriter11:28
mvocontext_test.go:50:11:28
mvo    // but we copied things until the deadline hit11:28
mvo    c.Check(n, check.Not(check.Equals), int64(0))11:28
mvo... obtained int64 = 011:28
mvo... expected int64 = 011:28
mvoyet?11:28
zygawaaaht?11:28
mvolooks like a racy test, just happend in the snpad autobuild11:28
zyganope11:28
Chipacawhat's the what about?11:29
zygawe could use the new int checker btw but that's unrelated11:29
Chipacathat's Not() output11:29
Chipacait can be confusing11:29
Chipacait obtained int64(0), and it expected _not_ to obtain the "expected int64(0)"11:29
zygayeah, I read this now11:29
Chipacaah ok11:30
Chipacamaybe we can patch Not to prepend NOT to the 'expected' line =)11:30
Chipacaor append "... NOT!"11:30
cachiopstolowski, nice11:30
cachiodo yo have an example?11:30
Chipaca... obtained int64 = 011:31
Chipaca... expected int64 = 0 ... NOT!11:31
cachioI was playing with confiugration failes11:31
zygaChipaca: that's a nice idea11:31
zygaNOT :D11:31
zyga(it's a nice idea)11:31
cachiopstolowski, to configure any kind of device11:31
mvoChipaca, zyga btw, did we find out more about the kernel permission issue that cachio  found in 2.36 testing?11:31
zygano11:31
Chipacamvo: that's not on my radar at all11:31
pstolowskihttps://www.irccloud.com/pastebin/fDLL0JuA/11:31
pstolowskicachio: ^11:31
pstolowskicachio: and it seems undocumented.. they depcreated -serial=... option but didn't document that new one11:33
mvoChipaca: ok, no worries, lets talk about it during the standup. I may have (sleepy) cycles for this :)11:34
mupPR snapd#6058 closed:  cmd/snap-exec: don't fail on some try mode snaps (2.36) <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6058>11:35
zygaChipaca: https://api.travis-ci.org/v3/job/447722772/log.txt11:35
zygahttps://www.irccloud.com/pastebin/PyCaVZMe/11:35
mvoChipaca: sorry for bothering you so much today, but have you seen http://paste.ubuntu.com/p/P2zHPvrFMJ/ before?11:35
zygaI think the test should have failed when "snap save. .." failed11:35
zygamissing error check?11:36
zygaChipaca: ^ FYI that's exactly the same problem :}11:36
mvoheh11:36
Chipacamvo: no worries11:38
Chipacamvo: I have seen that error, but not in that test since I added the "run something from the snap" step11:38
Chipacamvo: zyga: I'll push a PR so we get more logs if it happens again11:39
mvoChipaca: ta11:39
cachiopstolowski, nice11:43
cachiopstolowski, is it iportant ofor you to have other information such as vendor?11:44
Chipacamvo: zyga: there was also one that happened sporadically on amazon linux,  where the uid was -211:47
zygaoh11:47
zygaright11:47
zygalast night11:47
pstolowskicachio: only important factor is that vendor is present and constant (doesn't get random values like serial by default), which seems to be the case11:47
zygawell, apart from the weekend that is11:47
Chipacamvo: zyga: I maintain what I said on Friday about that: it's my considered opinion, after much and careful thought, that i can't even.11:48
Chipaca* not that much thought11:48
Chipacazyga: question: given that the size from ReadInfo wouldn't be useful for trys even if it weren't dangling, why not use an Lstat instead of a Stat?11:51
zygahmmm11:51
zygahow would stat make it better?11:51
zygalstat that is you silly spellchecker11:51
Chipacazyga: the problem is that the symlink is dangling, right?11:51
zygayou would stat the symbolic link itself, and?11:51
Chipacazyga: so it doesn't error out11:52
zygano, the problem is that symlink is controlled by the user11:52
zygaand we are in a mount namespace11:52
zygaso the user can point it a nearly arbitrary things11:52
zygawe cannot traverse it, period11:52
Chipacazyga: how is the symlink controlled by the user?11:52
zygaChipaca: because whoever "snap try"ies controls it11:52
Chipacazyga: how?11:52
Chipacazyga: the symlink is created by snapd, not by the user11:53
zygathe symlink is created by snapd to point to the directory picked by the user11:53
zygalook at the test case in that branch11:53
Chipacaok, hold on11:53
Chipacabefore we go there11:53
cachiopstolowski, ok11:53
cachiovendor is fixed11:53
zygayou can come up with creative use of "snap try /proc/..."11:53
Chipacazyga: the stat is done to get the size of the snap11:53
zygamhm11:53
cachiopstolowski, so it should not be  a problem11:53
Chipacazyga: that won't work for trys11:53
zygabut under the assumption that it points to a file11:54
zygawhich is not the case in try mode snaps11:54
Chipacazyga: hold on let me finish11:54
zygaok11:54
pstolowskicachio: most likely not, i'll now for sure when i've the test passing11:54
Chipacazyga: if it's a symlink, we should not follow it for two reasons, it won't be what we need to get the size,  and the user  might have tricked snapd somehow11:54
zygaaha, I see the reasoning now11:54
zygaso just lstat all the time11:54
Chipacazyga: in both cases, using lstat fixes the issue11:55
zygaand if it was a symlink, don't do more11:55
zygayep11:55
zygaI agree11:55
Chipacazyga: the right thing would be to do lstat, check the filename,  and fill in size if it's a regular file11:55
Chipacakeeps the api  simpler11:55
Chipacazyga: now, about the other thing, how would you trick snapd into pointing the symlink to something it shouldn't? via a race?11:55
Chipacahmmmm11:55
zygano11:56
zyganot really11:56
Chipacawell, snapd does a validation before enabling it11:56
zygawhat kind of validation?11:56
zygathat it looks like a snap11:56
Chipacamaybe it's a toctou11:56
Chipacayeh11:56
zygado we check that there are no symlinks along the way?11:56
zygado we check afterwards?11:56
zygacan we then rm -rf /old/path11:56
Chipacawhat happens if we tell it to snap try a symlink? does it normalize?11:56
zygaand then ln -s /proc/evil ?11:56
Chipacayeah11:56
zygayep11:56
Chipacalots of questions11:56
Chipacain any case the lstat is the right approach here i think11:57
Chipacabut i'd like to know the answers to these other things as well =)11:57
Chipacazyga: should I push a pr?11:57
zygaor I can if you want me to11:58
zygaI feel sleepy and this is a good think to wake up with11:58
Chipacazyga: +1, i'm in snapshot-ate-my-brunch land11:58
* zyga hugs chipaca11:59
zygaand takes a snapshot11:59
Chipacaalso need to get lunch going11:59
zygaChipaca: https://github.com/snapcore/snapd/pull/605912:20
mupPR #6059: snap: use Lstat to determine snap size, remove ReadSnapInfoExceptSize <Created by zyga> <https://github.com/snapcore/snapd/pull/6059>12:20
mupPR snapd#6059 opened: snap: use Lstat to determine snap size, remove ReadSnapInfoExceptSize <Created by zyga> <https://github.com/snapcore/snapd/pull/6059>12:21
Chipacazyga: I had too much on my plate last week, but I _think_ pstolowski suggested lstat on the original pr12:21
zygaperhaps but I didn't get the idea then12:22
Chipacai'm just now getting the bandwidth to think about it =)12:22
Chipacazyga: it was kyrofa !12:24
Chipacaheh12:24
zygabrb12:26
cachiozyga, hey https://paste.ubuntu.com/p/9W39q9S2H4/12:32
cachioI am getting that denial on the cifs test12:32
cachiozyga, any idea if I should need to plug any other interface?12:33
diddledancachio: https://forum.snapcraft.io/t/namespace-awareness-of-run-mount-utab-and-libmount/598712:36
mupPR snapd#6057 closed: [RFC] snap-exec: add comment about usage of ReadInfoExceptSize() <Simple šŸ˜ƒ> <Created by mvo5> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/6057>12:37
mborzeckizyga: i'm runnig spread tests with centos branch rebased on current master and got a problem with parallel services, we do bind mounts from snap_foo to snap, seems like that whenerver the mount ns of a snap exists and we try to remove a location on the host that is bind mounted inside snap's ns we get device os resource busy12:38
mborzeckizyga: snap-discard-ns makes the problem go away12:38
cachiodiddledan, nice, thanks12:39
zygamborzecki: this is a kernel bug12:46
zygaIt was fixed later12:46
zygaI doubt we can work around it12:46
zygacachio: let me look12:46
zygaAh, I see12:47
zygacachio: let me know if we should do utab mount12:48
cachiozyga, I just have pushed the changes for the test12:50
mborzeckizyga: do you have a link to lp? something i could use to open a bug in rh bugzilla12:50
Chipacastandup is in ten minutes?12:51
Chipacadang12:51
Chipacaneed to re-get-used to it12:51
mborzeckiw8, in 10 minutes now?12:52
mborzeckihmm, dst change12:53
Dmitrii-Shmvo, Chipaca: tested on 2.36 https://bugs.launchpad.net/snapd/+bug/1791587/comments/7. Something is still wrong there12:53
mupBug #1791587: snapd ignores proxy settings set via core snap <cpe-onsite> <snapd:New> <https://launchpad.net/bugs/1791587>12:53
ChipacaDmitrii-Sh: did you (or somebody from your team) talk in SLC as we last discussed?12:53
Dmitrii-ShChipaca: yes, I talked to mvo about this12:54
Dmitrii-Shhe asked me to test on 2.3612:54
Dmitrii-Shjust following up12:54
Chipacaah ok12:54
Dmitrii-Shwhat we agreed on is that /etc/environment should not be touched on classic systems (it isn't now by the looks of it)12:54
Dmitrii-Shand that this is a bug indeed \12:55
Dmitrii-Shjust needed to test on the latest to make sure as there are release notes suggesting that it was fixed12:55
mvoDmitrii-Sh: thanks, I look into it then12:56
mvoChipaca: context> we have the in-config proxy config now, this should work so I need to figure out where the gap is12:57
Chipacamvo: AFAIK it fails when core isn't installed;  works ok after12:58
Dmitrii-Shmvo: there's a simple test: install a squid proxy on a host system, launch a container with snapd and squashfuse, remove the default gateway in that container12:58
Chipacamvo: at least that's what I got from Dmitrii-Sh week before last =)12:58
Dmitrii-Shthe container will have a route only to the local subnet for communication with the host and will be able to use a proxy12:59
Dmitrii-ShChipaca: I can try again12:59
mvoChipaca: yeeah, sounds reasonable, still puzzling that it does not work without core but something to figure out :)13:00
ChipacaDmitrii-Sh: when you built 2.36, how did you then run it?13:00
mborzeckistandup?13:01
Chipacaomw13:01
mborzeckizyga: ^^13:01
Chipacamvo: ^13:02
Chipacacachio: ^?13:02
mvoChipaca: need to restart pulseaduio first13:02
Dmitrii-ShChipaca, mvo: yes, enabling default gateway, installing core, disabling gateway and trying to download other snaps works. I can also see that snapd connects to the proxy via strace13:02
mvoJamieBennett: want to join the standup?13:02
zygawhat, already?13:02
zygasorry, joining13:02
Chipacamvo: i thought jamie was on holiday13:02
Chipacadunno about niemeyer13:02
Dmitrii-ShChipaca: ran snapcraft cleanbuild, then I copied the resulting snap to the target system, unsquashfs-ed it and rsynced the /usr/lib/snapd/* and /usr/bin/snap* to relevant system dirs13:03
Dmitrii-ShChipaca: snapcraft also builds a deb but it got deleted after cleanbuild13:03
ChipacaDmitrii-Sh: this was with no snaps installed?13:04
Dmitrii-ShChipaca: yes, no snaps installed at first. Then I installed the core snap only and disabled the gateway13:04
Dmitrii-Shit then started to respect the proxy settings13:04
ChipacaDmitrii-Sh: the output of 'snap version' would be good, if you do over13:11
Dmitrii-Shsnap --version13:17
Dmitrii-Shsnap 2.3613:17
Dmitrii-Shsnapd 2.3613:17
Dmitrii-Shseries 1613:17
Dmitrii-Shubuntu 18.0413:17
Dmitrii-Shkernel 4.15.0-34-generic13:17
Dmitrii-ShChipaca: it's in the comment here https://bugs.launchpad.net/snapd/+bug/179158713:17
mupBug #1791587: snapd ignores proxy settings set via core snap <cpe-onsite> <snapd:New> <https://launchpad.net/bugs/1791587>13:17
Dmitrii-Shbtw, might be worthwhile to triage this bug for tracking13:18
mupPR snapd#6060 opened: overlord/snapshotstate/backend: be more verbose when SNAPPY_TESTING=1 <Created by chipaca> <https://github.com/snapcore/snapd/pull/6060>13:55
mborzeckioff to pick up the kids14:15
zygamvo: can you look at https://github.com/snapcore/snapd/pull/5170 as a satiny check before we merge it please14:15
mupPR #5170: interfaces/builtin: add adb-support interface <Created by zyga> <https://github.com/snapcore/snapd/pull/5170>14:15
zygamvo: and if you consider it sane we could even add it to 2.36.114:16
zygasince it is a new feature14:16
niemeyerHey, I forgot to ask: how was the mic volume/quality?14:16
mvozyga: I have a look, for 2.36.1 we need to squash merge it14:16
zygathat's ok14:16
mvoniemeyer: quality was good afaict14:16
niemeyermvo: Thanks, it was an external USB mic, so wondering if it's good for htat kind of meeting too14:17
* pstolowski lunch14:25
* cachio lunch14:26
* zyga -> lunch14:34
mvozyga: 5170 looks fine, wonder if it makes sense to have a spread test that just double checks that the right files are created on connect etc?14:41
mborzeckimvo: thanks for pushing that patch to 6039, i missed that comment from zyga14:48
mvomborzecki: my pleasure - thanks for all your help with this one, much more tricky than I anticipated14:49
Chipacapstolowski: when do you want to talk about that pr?15:02
=== Sir_Gallantmon is now known as Son_Goku
=== chihchun is now known as chihchun_afk
zygamvo: I can look into that15:17
mvozyga: thanks! something simple if fine15:18
mvozyga: is fine15:18
pstolowskiChipaca: in 30?15:21
zygare15:28
zygaChipaca, pstolowski: do you want me to participate as well?15:41
zygamvo: I wrote a test, if it passes I'll push it and merge when green15:45
Chipacapstolowski: zyga: fine by me15:46
zygajust tell me when :)15:46
Chipacain 12 minutes would be ok. In 2 hours would be better =) but probably too late15:47
* zyga found a bug in snaps.sh make_snap15:52
zyga12 minutes would be ok but if you want we can also do tomorrow15:52
mvozyga: cool15:52
pstolowskiit can be tomorrow morning if you prefere that Chipaca, zyga15:53
Chipacapstolowski: zyga: tomorrow morning \o/15:53
zygayeah, I prefer to do reviews in the morning15:53
zygaand coding in the evening15:54
Chipacaye15:54
pstolowskisure15:54
zygaChipaca: remember the lstat thing?16:09
zygait regresses :D16:09
zygahttps://www.irccloud.com/pastebin/xJJ4C4SL/16:09
zygabut I'd argue it doesn't regress because bind mounts are magic16:09
sil2100uugh16:10
zygasil2100: ?16:11
Chipacazyga: what the wha?16:15
zygaChipaca: Lstat now shows a snap the _used_ to be broken as not broken16:15
zygabut not really because it's not really broken16:15
zygabecause it works after the mv16:15
zygaso ... :)16:16
Chipacaheheh16:16
Chipacazyga: and does it _actually_ work?16:17
Chipacazyga: or is that snap now broken?16:17
zygaI suspect so, it's the next thing in my pipe16:17
zygabecause the symlink is broke16:17
zygabut the bind mount is not16:17
zygaso why would it break?16:17
zygajust found it funny :)16:17
mupPR snapd#6061 opened: tests: fail if install_snap_local fails <Created by zyga> <https://github.com/snapcore/snapd/pull/6061>16:25
zygaChipaca: one small for you https://github.com/snapcore/snapd/pull/6061 :)16:26
mupPR #6061: tests: fail if install_snap_local fails <Simple šŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6061>16:26
* Chipaca goes for a run16:35
zygacachio: hey16:35
zygacachio: the cifs test failed with16:35
zygahttps://www.irccloud.com/pastebin/I87puih6/16:35
zygaChipaca: it works,16:38
zygahttps://www.irccloud.com/pastebin/UR39vPVm/16:38
Chipacazyga: and with a non-trivial snap? =)16:41
* Chipaca is picky16:41
cachiozyga, yes this is the error I mentioned before16:44
cachiozyga, let me re-xecute it here16:45
cachiozyga, I see this error16:57
cachio[  607.220089] audit: type=1400 audit(1540832191.979:52): apparmor="DENIED" operation="open" profile="snap.test-snapd-cifs-mount.sh" name="/run/mount/utab" pid=23728 comm="mount" requested_mask="wrc" denied_mask="wrc" fsuid=0 ouid=016:57
cachiothis denial appears with the error you displayed before16:57
mupPR snapd#6062 opened: tests: add test to ensure proxy is used even without core <Created by mvo5> <https://github.com/snapcore/snapd/pull/6062>17:04
zygaChipaca: re17:09
zygaI think it would work with any snap because:17:09
zygaaww, I wanted to paste something but then spread session ended17:09
zygabecause the mount point shows what was there originally17:09
zygaunless you start to rm file by file17:09
zygacachio: that's an attempt to modify utab17:10
zygacachio: we share utab with the host today so we should not modify it17:10
zygacachio: we should probably change the interface and debug this more17:10
cachiozyga, you mean to allow access to this file as part of the interface?17:12
zygacachio: not really, we would have to make sure that file is not really there17:13
zygaand allow the snap to read and write a fake copy17:13
mupPR snapd#6061 closed: tests: fail if install_snap_local fails <Simple šŸ˜ƒ> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6061>17:17
cachiozyga, ah, ok, I'll try that17:21
zygacachio: I think this needs some changes to the interface17:21
zygacachio: I can look at that tomorrow17:21
zygaChipaca: so to respond to your question:17:21
zygahttps://www.irccloud.com/pastebin/xgHWy2hn/17:21
zygacachio: I was trying to say that I think the test shows that some things are probably wrong and we need to revisit the interface17:21
zygaChipaca: as you can see the snap is not broken17:22
zygaChipaca: not sure if I should change the test to instead rm the snap.yaml file17:22
zygaChipaca: like this:17:22
zygahttps://www.irccloud.com/pastebin/9fhnCc46/17:22
zygawe need a 2nd review on https://github.com/snapcore/snapd/pull/598217:41
mupPR #5982: interfaces/many: conditionally use 'unsafe' with docker-support change_profile rules <Created by jdstrand> <https://github.com/snapcore/snapd/pull/5982>17:41
* zyga EODs17:49
zygattyl!17:49
Chipacazyga: change the test, but RFC it so we talk about what is going on when this happens18:27
Chipacazyga: the question is: if this happens, and it happened by accident, what's the least surprising thing we can do so the user knows what's up18:28
Chipacazyga: and if it happens on purpose, double-check we're not opening the door for something dumb18:29
zygaChipaca: I pushed the change18:42
Chipacazyga: ack18:59
* Chipaca EODs, mostly18:59
cachiopstolowski, I think I have a good solution to speedup nested vm executions19:02
cachiopstolowski, I'll send you an email with the details after I can test the solution works properly19:03
zygahttps://www.irccloud.com/pastebin/4tieerHP/19:13
zygaChipaca: ^ is that the additional logs you were looking for?19:13
Chipacazyga: they'll be in the snapd log19:13
zygaone sec19:13
zygahmm19:15
zygaI cannot see that19:15
zygaperhaps this is the partial log from before the feature landed?19:15
Chipacaum19:15
Chipacazyga: the feature isn't landed19:15
Chipacait's got .99 of a review19:16
zygaaaah19:16
zygaright19:16
zygaso that's all I know :)19:16
Chipaca=)19:16
zygaI'll re-trigger it19:16
Chipacayeah, need moar logs19:16
zygaand we should both EOD19:16
Chipacayes19:16
Chipacai need to make dinner19:16
zygaenjoy the evening :)19:16
Chipacaor i'll be eaten alive by feral teenagers19:16
Chipacattfn19:16
cachiokyrofa, hey19:20
kyrofaHey cachio, what's up?20:22
cachiokyrofa, tomorrow I'll update images and the nested vm will change the name20:27
cachioon gce20:27
cachioit already exists and it is called ubuntu-1604-64-virt-enabled20:28
cachioand ubuntu-1804-64-virt-enabled20:28
cachioit is part of a reorg I am doing20:28
cachioboth image names will be available the whole week20:29
cachiothe idea is that this week we chagne the image names20:30
cachiodoes it work for you?20:30
kyrofacachio, no problem at all, I'll propose the change now21:27
mupPR snapd#5170 closed: interfaces/builtin: add adb-support interface <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5170>21:27
kyrofaThanks for the heads up!21:28
mupPR snapcraft#2387 opened: spread: change virt-enabled image name <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/2387>21:35
kyrofacachio, that ^ look okay?21:35
cachiokyrofa, the image is ready22:08
cachioso if you want to test the xenial one22:08
cachioyou can so it, I'll create the bionic one now22:08
cachiokyrofa, image for bionic is ready22:17
Chipacacachio: o/22:39
Chipacacachio: could you send me steps for creating the image so I can repro https://forum.snapcraft.io/t/8176 ?22:40
cachioChipaca, sure22:46
cachioChipaca, https://github.com/sergiocazzolato/snappy-qa-jobs22:47
cachiogit clone https://github.com/sergiocazzolato/validator.git22:47
cachiocd validator22:47
cachiosudo ./create.sh beta22:47
cachioChipaca, sudo ./create.sh beta pc-amd6422:48
cachiothat will create the image you need22:48
Chipacanice22:48
Chipacathanks22:48
cachioamd64: sudo kvm -snapshot -smp 2 -m 1500 -net nic,model=virtio -net user,hostfwd=tcp::8022-:22 -nographic -serial mon:stdio <PATH_TO_VM_IMAGE>22:48
cachioI use that command for the vm22:48
cachioChipaca, np22:49
Chipacacachio: this is uses ubuntu-image as in 16.04?22:49
cachioyes22:52
cachioit uses ubuntu image22:52
cachiothe .deb one22:53
Chipacacachio: how do i get the new kernel?22:57
cachioChipaca, ahh22:59
cachio:)22:59
cachiothe problem is that I created my images with the old kernel on beta22:59
cachiowhich was updated22:59
cachionow you can't reproduce that23:00
Chipacacachio: well i can refresh to 18/stable or sth23:00
cachioI can share my image with you perhaps23:00
cachioyes23:00
Chipacabut that doesn't give me a delta23:00
Chipacawhich might be the key difference23:00
ChipacaI'm looking at that23:01
Chipacacachio: is it easy to build an image with beta snapd but stable kernel?23:01
cachiootherwise I can share the image I have23:01
cachiobut it is gonna take some time23:01
cachioChipaca, let me check23:02
ChipacaHAH23:04
Chipacait's the deltas23:04
Chipacacachio: no worrries23:04
Chipacacachio: this is not a regression, but it is a bug23:05
Chipacai shall fix23:05
Chipacaā€¦ somehow =)23:05
cachioChipaca, as I see you can add which snaps you want to use23:07
cachioas a parameter23:07
cachiobut I didn't test it with the kernel23:08
cachio        --channel "$CORE_CHANNEL" \23:08
cachio        --output "$WORK_DIR/ubuntu-core.img" "$EXTRA_SNAPS"23:08
cachioChipaca, you can try that23:08
Chipacacachio: no worries23:08
Chipacacachio: I found the bug, as I said ^23:08
cachioChipaca, ok23:08
cachioChipaca, hehe23:08
cachiomuch better23:08
cachioChipaca, thanks for chasing this23:09
Chipacanp23:09
cachioI'll go to the gym now :)23:09
cachiosee you tomorrow23:09
* cachio afk23:10
mupPR snapd#6063 opened: store: also make snaps downloaded via deltas 0600 <Simple šŸ˜ƒ> <Created by chipaca> <https://github.com/snapcore/snapd/pull/6063>23:20
Chipacacachio: ^ fwiw23:20
mupPR snapd#6064 opened: many: move regexp.(Must)Compile out of non-init functions into variables <Created by chipaca> <https://github.com/snapcore/snapd/pull/6064>23:55

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!