| nacc | cjwatson: fair enough :) | 03:26 |
|---|---|---|
| teward | cjwatson: well i've got tsimonq2 being adamant "But the regex is verbatim and i'm not changing it because that's what the system says" | 15:09 |
| teward | whereas some of my python checkers are complaining :p | 15:09 |
| teward | wasn't sure if it was critical or not. | 15:09 |
| teward | nacc: not if you pass the pattern as a raw string - r"pattern#goes#here" apparently. | 15:09 |
| cjwatson | This is really not critical | 15:10 |
| cjwatson | Remove the backslash or not, I don't care | 15:10 |
| teward | yep, i was just being overly complaining because i was reviewing one of Lubuntu's irc bots' code as a favor :) | 15:11 |
| teward | no problem. *goes back to working on things* | 15:11 |
| cjwatson | And it has nothing to do with whether the pattern is passed as a raw string | 15:11 |
| cjwatson | Comment support is controlled by the re.X == re.VERBOSE flag | 15:12 |
| cjwatson | If anyone wants the regex to change, they can propose an MP changing it in lib/lp/soyuz/enums.py | 15:12 |
| cjwatson | I've got no problem with that but won't be spending my own time on it | 15:13 |
| tsimonq2 | teward: Do that before messing with Lubuntu's regex. :P | 15:13 |
| teward | cjwatson: do we enable re.X though? I thought we didn't enable that? | 15:17 |
| teward | *drags tsimonq2 through the mud anyways* | 15:17 |
| teward | because it looks to me we don't enable re.X in enums.py :P | 15:19 |
| teward | (and I prefer NOT having that enabled unless necessary lol) | 15:19 |
| cjwatson | We do not | 15:19 |
| cjwatson | I wasn't saying we did | 15:19 |
| teward | i'm not awake yet heh :P | 15:20 |
| teward | but that answers the question :) | 15:20 |
| cjwatson | Just that that's what governs whether # introduces a comment, not whether the pattern is passed as a raw string | 15:20 |
| teward | *goes for more coffee* | 15:20 |
| teward | ah I see | 15:20 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!