| didrocks | good morning | 07:16 |
|---|---|---|
| oSoMoN | good morning desktoppers | 07:19 |
| didrocks | salut oSoMoN, ça va ? | 07:21 |
| oSoMoN | didrocks, ça va, et toi? | 07:24 |
| oSoMoN | il a plu toute la nuit et il continue à pleuvoir fort, je me prépare à affronter les éléments pour aller à l’école… | 07:25 |
| didrocks | oSoMoN: à part les acouphènes, ça va. La pluie est passée ici (c'était ce week-end et lundi) | 07:26 |
| jibel | Good morning | 07:56 |
| seb128 | good morning desktopers | 08:41 |
| didrocks | salut seb128 | 08:42 |
| seb128 | lut didrocks, en forme ? | 08:42 |
| seb128 | I saw a long discussion on #ubuntu-devel yesterday about the overlay for the iso, was there any useful outcome? | 08:42 |
| didrocks | seb128: yeah, at least, we know what can or cannot be done | 08:44 |
| seb128 | so what can be done? ;) | 08:44 |
| didrocks | meaning: some of the really niceness we could have get from the layer approach isn't feasable in how it's implemented, sadely :/ | 08:44 |
| seb128 | I wonder if we should start collecting those notes in a shared document | 08:44 |
| seb128 | :( | 08:44 |
| seb128 | or maybe that ends up in the blueprint/spec | 08:44 |
| didrocks | right now it's some notes on a text file in my disk | 08:45 |
| didrocks | my goal was to put that in the blueprint itself | 08:45 |
| didrocks | less volatile than a google doc somewhere IMHO | 08:45 |
| didrocks | I have diagrams btw | 08:45 |
| seb128 | sounds good | 08:48 |
| seb128 | thx! | 08:48 |
| didrocks | yw | 08:53 |
| Laney | hey | 09:02 |
| didrocks | hey Laney | 09:04 |
| willcooke | morning | 09:09 |
| seb128 | hey willcooke Laney, how is u.k today? | 09:10 |
| willcooke | seb128, it's sunny but zero degrees | 09:14 |
| seb128 | same here, cold & sunny | 09:15 |
| seb128 | which is much better than yesterday's cold&rainy | 09:15 |
| willcooke | :)) | 09:15 |
| Laney | hey didrocks seb128 willcooke 🧟 🧠 🧛 🎃 | 09:19 |
| willcooke | :) | 09:20 |
| === Class7_ is now known as Class7 | ||
| === caravena_ is now known as caravena | ||
| andyrock | seb128: thx for the reviews :) | 11:38 |
| seb128 | andyrock, np! | 11:39 |
| seb128 | does anyone can hint me on how to easily tweak/Edit a patch with gbp pq? | 14:17 |
| seb128 | like give me a branch with the diff applied when I can hack and do a refresh | 14:18 |
| xnox | gbp pq import --force; git rebase -i, select a thing to edit, edit; gbp pq export | 14:19 |
| xnox | seb128, is a `general recipe` | 14:19 |
| seb128 | xnox, I tried that (thx to google) but rebase -i coplains about having no info about the current branch | 14:20 |
| xnox | odd | 14:20 |
| * xnox ponders which branch you are on | 14:20 | |
| seb128 | $ git rebase -i | 14:20 |
| seb128 | There is no tracking information for the current branch. | 14:20 |
| seb128 | Please specify which branch you want to rebase against. | 14:20 |
| xnox | seb128, ah | 14:21 |
| seb128 | * patch-queue/ubuntu/bionic | 14:21 |
| seb128 | so that one? | 14:21 |
| xnox | seb128, git rebase -i <committish> =) sorry, you need to do something like $ git rebase -i HEAD^^^^ -> to rebase the last four patches. | 14:21 |
| xnox | good. | 14:21 |
| xnox | or like do $ git log | 14:21 |
| xnox | to look up the commit id, before the one you want to tweak. | 14:21 |
| seb128 | k, thx | 14:22 |
| * xnox hopes above makes sense. | 14:22 | |
| Laney | for a non-pushed branch like this one I'd just give the original branch name (ubuntu/bionic) | 14:22 |
| Laney | doesn't matter if you rebase "too much" in this case | 14:22 |
| * xnox likes Laney's comment too | 14:22 | |
| Laney | :3 | 14:22 |
| Laney | TIL rebase -i with no branch though | 14:23 |
| seb128 | I need to learn more git | 14:24 |
| seb128 | that was a fail | 14:27 |
| seb128 | export doesn't include my changes ^^ | 14:27 |
| seb128 | was "git rebase --abort" maybe not the right way to end the rebasing? | 14:27 |
| Laney | nope, --continue after amending the commit | 14:27 |
| seb128 | Laney, xnox, thx, I managed to do it | 14:31 |
| seb128 | never used rebase -i, I first started by deleting all the line I was not interested in and changing a "pick" to "edit", that didn't work great | 14:31 |
| seb128 | it eventually worked by keeping the other line and just changing the line I was interested in | 14:31 |
| Laney | nod | 14:32 |
| Laney | it's like "do these actions on top of the base I chose" | 14:32 |
| Laney | so if you delete a pick, it is lost | 14:32 |
| Laney | that is actually useful to do intentionally sometimes of course | 14:33 |
| Laney | in patch-queue terms it means dropping this patch | 14:33 |
| seb128 | k, I understand now, thx :) | 14:34 |
| jdstrand | seb128: fyi, will be uploading a fix for the thumbnailer bug today | 14:36 |
| jdstrand | (sprint last week, off last two days) | 14:36 |
| seb128 | jdstrand, hey, I did for cosmic yesterday since you were not around and I think my change makes sense, let me know if that looks wrong though, http://launchpadlibrarian.net/395375642/evince_3.30.1-1ubuntu1_3.30.1-1ubuntu1.1.diff.gz | 14:37 |
| jdstrand | seb128: I wanted to use: owner /tmp/{,.}gnome{_,-}desktop{_,-}-thumbnailer.* w, | 14:39 |
| jdstrand | seb128: since I've seen _ used elsewhere | 14:39 |
| jdstrand | it was probably a gnome-desktop change, but the above rule is forward and backward compatible | 14:39 |
| seb128 | jdstrand, cf my comment on the bug / https://gitlab.gnome.org/GNOME/gnome-desktop/blob/master/libgnome-desktop/gnome-desktop-thumbnail-script.c#L730 | 14:39 |
| jdstrand | I gotta run atm though. I'll read backscroll | 14:40 |
| seb128 | jdstrand, the different is bubblewrap codepath or not I think | 14:40 |
| seb128 | jdstrand, but if you want to replaced my upload with yours wfm | 14:40 |
| seb128 | jdstrand, thx | 14:40 |
| andyrock | finally fixed the crash with 'gnome-shell --replace' \o/ | 14:55 |
| andyrock | well at least proposed a fix | 14:55 |
| seb128 | nice | 14:56 |
| seb128 | andyrock, so I found a problem with livepatch notification, I wanted to look at fixing it today but looks like I'm not going to be able to squeeze that | 14:57 |
| seb128 | I did upload fixes for update-managers/g-i-s/etc though | 14:57 |
| andyrock | seb128: what problem? | 14:58 |
| seb128 | andyrock, https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1800862 | 15:00 |
| ubot5 | Ubuntu bug 1800862 in update-notifier (Ubuntu) "Doesn't communicate about applied livepatch on start" [Undecided,New] | 15:00 |
| andyrock | seb128: mmm I'm not sure canonical-livepatch daemon deletes the status file if no patch is applied | 15:01 |
| seb128 | andyrock, ? | 15:02 |
| andyrock | seb128: that means that once the file is there it's going to stay there, even if there is no patch applied | 15:02 |
| seb128 | the problem is rather that if you have an update, the status is updated on boot/when system gets online | 15:02 |
| seb128 | so the event happens before update-notifier is loaded | 15:02 |
| seb128 | (maybe before user login) | 15:02 |
| seb128 | so you don't get the notification | 15:03 |
| andyrock | seb128: I see the problem but checking for the file when update-notifier starts it's going to create other issues | 15:03 |
| seb128 | would make sense to notification if the status had some applied? | 15:03 |
| seb128 | whcih one? | 15:03 |
| andyrock | seb128: imagine this scenario | 15:03 |
| andyrock | 1) you get a livepatch update | 15:03 |
| andyrock | 2) lp daemon creates a status file | 15:04 |
| andyrock | 3) update-notifier shows a notification | 15:04 |
| andyrock | 4) you update the kernel | 15:04 |
| andyrock | 5) now no lp patch is applied but the file is still there | 15:04 |
| andyrock | 6) on next reboot update-notifier will show a notification even if no patch is applied | 15:05 |
| seb128 | the lp is applied no? | 15:05 |
| andyrock | nope | 15:05 |
| seb128 | until you reboot you are on the pre-update kernel no? | 15:05 |
| andyrock | yeah | 15:05 |
| andyrock | once you reboot you get a new kernel, no lp patches | 15:06 |
| andyrock | there is no point in showing a notification | 15:06 |
| seb128 | that's already an issue today no? | 15:06 |
| seb128 | ah | 15:06 |
| seb128 | I see | 15:06 |
| seb128 | I would argue that that status file should be deleted on boot | 15:06 |
| seb128 | but are you sure it's going to be there wrong? | 15:07 |
| andyrock | seb128: that or we need a serial number | 15:07 |
| seb128 | on next boot, lp refresh should happen | 15:07 |
| seb128 | and the status should be "no update" | 15:07 |
| seb128 | and not "applied <n>" | 15:07 |
| seb128 | no? | 15:07 |
| andyrock | in theory yes, but for the moment it's just used to notify applied patches | 15:07 |
| andyrock | we need to fix canonical-livepatch | 15:07 |
| seb128 | we could compare timestamp of the status and of the boot | 15:08 |
| seb128 | and notify on start if status is newer than boot? | 15:08 |
| seb128 | like compare age to uptime | 15:09 |
| andyrock | that too, we just need to make sure that the squashfs thing does not mess up with timestamps | 15:09 |
| seb128 | the status in /var, that's not in a squashfs no? | 15:09 |
| andyrock | ah yeah so we're saafe | 15:12 |
| andyrock | yeah that would work | 15:12 |
| seb128 | andyrock, I commented on the bug | 15:14 |
| andyrock | seb128: I'll add it to my todo list | 15:16 |
| seb128 | andyrock, thx, if you are too busy I can have a look next week | 15:16 |
| seb128 | but I'm off tomorrow and friday | 15:16 |
| andyrock | tomorrow is national holiday for me too | 15:16 |
| andyrock | I'll add a trello card | 15:16 |
| seb128 | thx | 15:17 |
| seb128 | enjoy the day off :) | 15:17 |
| seb128 | k, desktopers, I'm going to call it a day in 10 min or so, driving for the w.e. I might checkout emails later/tomorrow morning but otherwise I'm off until monday | 16:23 |
| seb128 | good luck for those who work those days, enjoy those who have days off, swaps, etc | 16:23 |
| Laney | byeeeeeeeeeeeeeeeeeeeee | 16:25 |
| Laney | have fun! | 16:25 |
| seb128 | bye | 16:34 |
| seb128 | thx, you too | 16:34 |
| seb128 | :) | 16:34 |
| caravena | Trevinho: Hello, please review: https://bugs.launchpad.net/bugs/1799994 (For GDM3) | 16:38 |
| ubot5 | Ubuntu bug 1799994 in nvidia-graphics-drivers-390 (Ubuntu) "Xorg loads, no display on nvidia 390.77-0ubuntu0.18.04.1" [Undecided,New] | 16:38 |
| caravena | ¿Bug in gdm3? | 16:41 |
| caravena | Thanks! | 16:42 |
| oSoMoN | ricotz, FYI, I'm going to create disco bzr branches for firefox | 17:23 |
| willcooke | I'm off, night out tonight \o/ | 17:26 |
| willcooke | night all | 17:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!