[00:14] <mup> Bug #1801201 opened: Installed snap icons missing if using pixmap <Snappy:New> <https://launchpad.net/bugs/1801201>
=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
[08:05] <pstolowski> morning
[08:43] <sil2100> Morning o/
[08:43] <sil2100> Are zyga or mvo around today?
[09:05] <pstolowski> hey sil2100!
[09:06] <pstolowski> sil2100: no, he has a day off
[09:07] <pstolowski> sil2100: zyga thats is; don't remember about mvo, but probably off as well
[09:08] <pstolowski> morning Chipaca!
[09:09] <sil2100> :<
[09:09] <Chipaca> pstolowski: morning!
[09:11] <Chipaca> pstolowski: thank you for the review!
[09:12] <Chipaca> pstolowski: if you still have room for more, #6074 would be nice
[09:12] <mup> PR #6074: strutil: make VersionCompare faster <Created by chipaca> <https://github.com/snapcore/snapd/pull/6074>
[09:12] <Chipaca> pstolowski: yesterday I was wondering if you'd be taking today off as well
[09:12] <pstolowski> Chipaca: added a few comments to your "survive missing..." PR; i need 2nd cup of coffee though, so if i suggested something silly, it's because of not enough coffee
[09:13] <Chipaca> pstolowski: :-)
[09:13] <Chipaca> pstolowski: I'll think about the  !(err == nil && exists && isDir)  vs  err != nil || !exists || !isDir
[09:14] <Chipaca> pstolowski: it used to be the second way, fwiw
[09:14] <Chipaca> i changed it because i thought it was clearer
[09:14] <Chipaca> so maybe i was wrong =)
[09:15] <Chipaca> i'll try splitting it out and see what it looks like
[09:18] <pstolowski> Chipaca: thanks.
[09:18] <pstolowski> Chipaca: will look at this other PR.
[09:20]  * zyga is off
[09:20] <zyga> (just having wifi)
[09:21] <pstolowski> + pacman -Rnsc --noconfirm xdg-utils
[09:21] <pstolowski> error: target not found: xdg-utils
[09:21] <pstolowski> hmm
[10:20] <pstolowski> Chipaca: +1 for version check optimization, with tiny suggestions
[10:20] <Chipaca> pstolowski: ok
[10:20] <Chipaca> pstolowski: ok to do them in a followup?
[10:20] <pstolowski> Chipaca: sure
[10:21] <pstolowski> Chipaca: although you'll probably not get second +1 today :}
[10:21] <Chipaca> pstolowski: didn't it already have one?
[10:21] <pstolowski> Chipaca: that one has
[10:21] <pstolowski> Chipaca: but followup won't
[10:21] <Chipaca> pstolowski: ah, you mean for the followup
[10:22] <Chipaca> pstolowski: but the followup is happening anyway :)
[10:22] <pstolowski> ah, ok
[10:22] <Chipaca> pstolowski: (it's the rewrite of #6065 using the new version compare)
[10:22] <mup> PR #6065: cmd, strutil: make coreSupportsReExec faster <Created by chipaca> <https://github.com/snapcore/snapd/pull/6065>
[10:22] <Chipaca> ah, actually that one already has a +1 :-D
[10:23] <Chipaca> but, yeah, it's a rewrite so i'd be cheating if i used that
[10:23] <Chipaca> hmmmmmmmmm
[10:23] <Chipaca> mm
[10:23] <Chipaca> m
[10:26] <Chipaca> pstolowski: https://pastebin.ubuntu.com/p/gb9TR4268y/
[10:26] <Chipaca> pstolowski: strings.Trim* is unideal
[10:26] <pstolowski> jeeez
[10:27] <pstolowski> ok, leave it as is ;)
[10:28] <pstolowski> Chipaca: uh, i presume your earlier PR fixes the occasional error i see on travis today:
[10:28] <pstolowski> - Save data of snap "test-snapd-tools" in snapshot set #1 (cannot create archive: tar: common: Cannot stat: No such file or directory (and 1 more))
[10:29] <pstolowski> and everything below collapses
[10:29] <Chipaca> pstolowski: yes
[10:29] <pstolowski> and we won't land it today :(
[10:30] <Chipaca> pstolowski: I'll push your suggestions in a bit, and then I'll land it once green
[10:30] <Chipaca> it's tripping up tests too much
[10:30] <Chipaca> we can always revert if it was Wrong
[10:31] <Chipaca> pstolowski: btw if instead of TrimLeft I use TrimLeftFunc, it's only 10% slower and doesn't use any more memory
[10:31] <Chipaca> the problem seems to be TrimLeft, which makes a cutset object
[10:31] <Chipaca> cuset function object thing
[10:33] <pstolowski> ack. i expected it would be slightly slower as it supports substring match.. but that's beyond my wildest expectations
[10:34] <pstolowski> thanks for checking. good to know
[10:49] <pstolowski> Chipaca: thanks for the changes #6086, i find these conditions much more readable now (but again, it might be personal preference)
[10:49] <mup> PR #6086: overlord/snapshotstate/backend: survive missing directories <Created by chipaca> <https://github.com/snapcore/snapd/pull/6086>
[10:49] <Chipaca> pstolowski: yep, i get it
[11:08] <pstolowski> Chipaca: restartin #6086, travis failed with "null"
[11:08] <mup> PR #6086: overlord/snapshotstate/backend: survive missing directories <Created by chipaca> <https://github.com/snapcore/snapd/pull/6086>
[11:15] <mup> PR core#38 closed: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38>
[11:15] <mup> PR core#83 closed: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83>
[11:15] <mup> PR core#98 closed: Add force_turbo rpi option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/98>
[11:16] <mup> PR core#38 opened: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38>
[11:16] <mup> PR core#83 opened: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83>
[11:16] <mup> PR core#98 opened: Add force_turbo rpi option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/98>
[11:29] <mup> PR snapd#6087 opened: tests: core 18 does not support classic confinement <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6087>
[11:44] <ogra> cjwatson, jut FYI i think your theory about the proxy token timeout and my 2h kernel build was wrong, a 3h build finished fine yeterday (same snapcraft.yaml) https://launchpad.net/~build.snapcraft.io/+snap/0e2b1c47138b20d1431cf32b24b68bb3-xenial/+build/367710
[11:45] <cjwatson> ogra: It's probably marginal and just happened to reach the relevant pull stage before the two-hour cutoff
[11:45] <cjwatson> ogra: I've checked and the proxy auth token does indeed time out after two hours, as I remembered
[11:46] <cjwatson> ogra: In fact, there are enough timestamps in that log that you can see it
[11:46] <ogra> well, the last part in that snapcraft.yaml is a single external module build, i doubt that takes 1.5h
[11:46] <cjwatson>  1 Nov 23:27:40 ntpdate[1830]: adjust time server 10.211.37.1 offset -0.010249 sec
[11:46] <cjwatson> [02/Nov/2018:01:23:03 +0000] "CONNECT github.com:443 HTTP/1.1" 200 161369 "-" "git/2.7.4"
[11:46] <cjwatson> just under two hours difference
[11:47] <ogra> hmm, weird
[11:47] <cjwatson> ogra: the slow bit might be actually packing up the snap maybe?  not sure
[11:47] <cjwatson> there's not much else at that point that could be slow
[11:48] <ogra> yeah and that bit has no timetamps
[11:49] <cjwatson> Indeed, unfortunately
[11:58] <ackk> hi, does anyone know how to make nginx run inside a snap? if I specify "user root" it tries to initgroups() and fails
[12:04] <cjwatson> ackk: lp:snapstore-snap (Canonical-private) has some very hacky stuff to make that work
[12:04] <ackk> cjwatson, are you using nginx from the deb or building your own?
[12:04] <cjwatson> Basically shoving in https://paste.ubuntu.com/p/GK6GtfDbzh/ to stub it
[12:05] <cjwatson> ackk: we use stage-packages: nginx-light
[12:05] <cjwatson> and use that
[12:06] <ackk> cjwatson, I see
[12:06] <cjwatson> It's not pretty, but it works.  See https://forum.snapcraft.io/t/seccomp-filtering-for-setgroups/2109/7
[12:07] <ackk> cjwatson, thanks
[12:07] <cjwatson> np
[12:17] <mup> PR snapd#6077 closed: overlord/ifacestate: use map[string]*connState when passing conns around <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6077>
[12:54] <pstolowski> Chipaca: cachio are we skipping the standup?
[12:54] <Chipaca> I wouldn't mind, nothing new since yesterday I don't think
[12:57] <cachio> pstolowski, no idea
[12:57] <pstolowski> cachio: it's up to us, there is no one else today
[12:58] <cachio> pstolowski, let's skip it in that case
[12:59] <cachio> pstolowski, I am working fixing tests now
[13:00] <Chipaca> pstolowski: I thought degville was also with us today
[13:01] <degville> Chipaca: pstolowski: yep, I'm here.
[13:01] <degville> (there)
[13:01] <pstolowski> Chipaca: ah, you may be right, sorry!
[13:01] <Chipaca> degville: let's skip it unless you have more news for us than can fit on irc =)
[13:01] <degville> that's fine :)
[14:07] <mup> PR snapd#6086 closed: overlord/snapshotstate/backend: survive missing directories <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6086>
[14:10] <mup> PR snapd#6088 opened: tests: add debug output for degraded test <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6088>
[14:12] <mup> PR snapd#6074 closed: strutil: make VersionCompare faster <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6074>
[14:31]  * cachio afk
=== alan_g is now known as alan_g_
[15:12] <mup> PR snapd#6088 closed: tests: add debug output for degraded test <Simple 😃> <Created by sergiocazzolato> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6088>
[15:42] <diddledan> so, someone who shall remain nameless managed to figure out how to get GTK2 and GTK3 to both work from the same snap
[15:43] <diddledan> hint, it involves removing GTK_PATH ;-p
[15:44]  * diddledan pings kenvandine about that one
[15:44] <diddledan> I'm just off out, but I'll write it up later
[15:45] <kenvandine> hey diddledan
[15:45] <diddledan> ello :-)
[15:47] <diddledan> the customised desktop-gtk part (patch coming in a second message) https://www.irccloud.com/pastebin/d2kIJ3Va/
[15:47] <diddledan> the patch referenced in the part https://www.irccloud.com/pastebin/nuqbPhB8/
[15:48] <diddledan> add this environment somewhere that it takes hold - could just as easily be added to the patch https://www.irccloud.com/pastebin/VgcQ5ALO/
[15:50] <diddledan> obviously the patch is only a patch for my use case where I'm reusing the desktop-helpers as source but to add to the desktop-helpers it can be added directly to the gtk script rather than maintained as a separate patch
[15:51] <diddledan> anywho, that's all I got, I need to jet now. bbiab
[15:51] <kenvandine> diddledan: cool
[16:21] <mup> PR snapd#6087 closed: tests: core 18 does not support classic confinement <Simple 😃> <Created by sergiocazzolato> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6087>
[16:22] <Chipaca> cachio: ^
[16:22] <cachio> Chipaca, good
[16:22] <cachio> thanks
[16:50] <diddledan> is something wrong with build.snapcraft.io? https://usercontent.irccloud-cdn.com/file/3vIFFkBZ/image.png
[16:55] <popey> refresh? turn of ad blocker?
[16:58] <diddledan> no ad blocker, though I am using firefox which might be blocking stuff through it's "don't track me" features
[16:59] <popey> i just logged in and it worked here
[16:59] <diddledan> aha. it's https everywhere extension
[16:59] <popey> that stuff is all js locally
[16:59] <popey> ahhhh
[16:59] <diddledan> so something is being forced to https that isn't responding...
[17:00] <diddledan> or not. it's working now even after re-enabling https-everywhere
[17:00] <diddledan> perhaps a stodgy cache then
[17:06] <kyrofa> diddledan, do you have privacy badger as well?
[17:06] <diddledan> no, I haven't got that currently
=== pstolowski is now known as pstolowski|afk
[17:30] <mup> PR snapd#6062 closed: tests,store,daemon: ensure proxy settings are honored in auth/userinfo too <Created by mvo5> <https://github.com/snapcore/snapd/pull/6062>
[17:44] <mup> PR snapd#6089 opened: tests: install dependencies during prepare <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6089>
[18:14] <mup> PR snapcraft#2359 closed: [WIP] extensions: add glib <Created by kyrofa> <Closed by kyrofa> <https://github.com/snapcore/snapcraft/pull/2359>
[18:38] <mup> PR snapcraft#2388 opened: project: early snapcraft.yaml validation <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2388>
[22:20] <kyrofa> Of course, the first time I actually try layouts I need to create new entries in / :P