| === Class7_ is now known as Class7 | ||
| didrocks | good morning | 07:11 |
|---|---|---|
| jibel | Salut didrocks | 07:14 |
| didrocks | hello jibel | 07:15 |
| === pstolowski|afk is now known as pstolowski | ||
| seb128 | good morning desktopers | 08:41 |
| Laney | hi | 09:01 |
| seb128 | hey Laney! wie gehts? | 09:02 |
| Laney | hey seb128 | 09:08 |
| Laney | doin' goooooooooooooooooood | 09:08 |
| Laney | looks like a nice day! | 09:10 |
| Laney | what about you? | 09:10 |
| Wimpress | Morning desktopers | 09:12 |
| seb128 | hey Wimpress, how are you? | 09:16 |
| seb128 | Laney, doing good! I had tennis lesson yesterday, it's nice and sunny today and I just manage to sponsor nautilus fixes from Marco without hitting any git stone on the way :p | 09:19 |
| Laney | truly one for the CV | 09:23 |
| andyrock | good morning! | 09:56 |
| seb128 | hey andyrock, how are you? | 09:56 |
| seb128 | tseliot, hey! sorry about the extra email rounds on that nvidia SRU, I'm not familiar with those drivers and they versioning and the difference between e.g -361 -375 -390, so I looked a thing from a wrong angle at first. You are right that this issue is not need, I followed up now and hopefully it's good enough to unblock the SRU | 09:57 |
| andyrock | seb128: good thanks. Planning to prepare a gjs upload to make "gnome-shell --replace" work again | 09:58 |
| andyrock | seb128: what about you? | 09:58 |
| seb128 | woot | 09:58 |
| seb128 | that was an small diff from what I saw to adapt to some mozjs changes, right? | 09:58 |
| seb128 | I'm good :) | 09:58 |
| tseliot | seb128: ok, thanks | 09:58 |
| seb128 | is not *new* | 09:58 |
| andyrock | seb128: yeah. We also need another fix from Trevinho | 09:59 |
| andyrock | seb128: not sure if I need to that in salsa before | 09:59 |
| andyrock | wdyt? | 09:59 |
| seb128 | andyrock, there are also some leak fixes in the stable serie so it might be worth doing the point update | 09:59 |
| seb128 | you don't *need* to | 09:59 |
| andyrock | seb128: can we SRU the full release to cosmic? | 10:00 |
| seb128 | it's a point bug fix release so I would say yes | 10:00 |
| seb128 | but I'm not the expert in that stack and I don't know how well tested their updates and how risky it can be | 10:00 |
| seb128 | we can always try, we have the testing in proposed for that :) | 10:01 |
| andyrock | kk I'll ask ptomato if I can do a point release once he's online | 10:01 |
| seb128 | andyrock, well there is one, a .2 | 10:02 |
| andyrock | seb128: not enough | 10:02 |
| andyrock | seb128: otherwise I can do a .2 + my fix | 10:02 |
| seb128 | that's what I was suggesting | 10:03 |
| seb128 | there is no commit in https://gitlab.gnome.org/GNOME/gjs/commits/gnome-3-30 since .2 | 10:03 |
| seb128 | so imho no need to point them for another tarball | 10:03 |
| seb128 | just do .2 + your fix | 10:03 |
| andyrock | kk, I'll propose my fix in gnome-3-30 branch | 10:03 |
| Laney | if that fix affects the 3.30 branch then it ought to be taken into it as well | 10:03 |
| Laney | indeed | 10:04 |
| andyrock | Laney: yeah | 10:04 |
| andyrock | debian already got the .2 | 10:04 |
| seb128 | right, I was not arguing against having it commited to stable upstream | 10:04 |
| seb128 | just maybe that's not worth pushing for a new release by itself | 10:04 |
| seb128 | anyway, you guys know how to sort that out :) | 10:04 |
| andyrock | I can merge from debian and add my fix | 10:04 |
| seb128 | Laney, you said you would do the g-c-c update review in salsa for andyrock right? do you plan to handle the cosmic SRU as well? | 10:05 |
| seb128 | (if not I add that to my backlog) | 10:05 |
| andyrock | I can prepare the branches for D and for the SRU | 10:06 |
| Laney | I did, that's all going to be the same I hope | 10:06 |
| seb128 | great, thx | 10:06 |
| Laney | pls | 10:06 |
| Laney | andyrock: gjs is in sync, please propose to salsa too | 10:06 |
| andyrock | Laney: sure | 10:07 |
| andyrock | regarding g-c-c I added a commit that we forgot to push to gnome-3-30 branch before the point release | 10:07 |
| andyrock | it's merged now so we're going to get in the next point release if any | 10:07 |
| andyrock | I'm preparing an upload to mutter with https://gitlab.gnome.org/GNOME/mutter/commit/1d863f4d3e102c3100ca879224a2d0c6dcb45674 | 11:08 |
| andyrock | to salsa | 11:08 |
| andyrock | maybe that's enough to fix the "gnome-shell --replace" even without the gjs changes | 11:09 |
| andyrock | because Marco want me to include also the commit here in gjs: https://gitlab.gnome.org/GNOME/gjs/merge_requests/240/commits | 11:09 |
| gitbot | GNOME issue (Merge request) 240 in gjs "Fix ParamSpec refcounting" [Closed] | 11:09 |
| Laney | comes a point when a release is better | 11:18 |
| andyrock | yeah I'll talk to ptomato and ask him to do a point release with those fixes | 11:28 |
| seb128 | andyrock, Laney, snapd change to allow /run/snap.$snapname is merged in master now :) | 11:36 |
| Laney | what a world | 11:37 |
| Laney | ! | 11:37 |
| andyrock | \o/ | 11:48 |
| andyrock | we still need to wait for it to be released in bionic | 11:49 |
| Laney | autotooooooollllllllllsssssssss | 14:50 |
| seb128 | andyrock, update-notifier looks fine to me now and I tested it works fine (I tested on a file where I changed the timestamp to be 1 day ago, knowing I rebooted this morning, and it didn't display the notification again) | 15:27 |
| seb128 | so I can sponsor if Laney is +1 as well | 15:27 |
| andyrock | nice, thx for reviews | 15:28 |
| andyrock | both of you <3 | 15:28 |
| Laney | how does that fix fix the second warning? | 15:31 |
| Laney | oh | 15:32 |
| Laney | they were both warnings from g_strdup_printf(), I thought one of them was from ngettext() | 15:32 |
| seb128 | right | 15:32 |
| andyrock | we could also do "1 bla bla" | 15:33 |
| andyrock | instead of "% lu" for the first case | 15:33 |
| * Laney misunderstood the "yes" | 15:33 | |
| Laney | good if it doesn't warn, kind of expected it to do so | 15:34 |
| * Laney looks quickly | 15:39 | |
| Laney | I should fix spice-vdagent for systemd --user, sucks losing that functionality | 15:45 |
| didrocks | yes please! :) | 15:47 |
| Laney | :> | 15:49 |
| seb128 | andyrock, k, your got one extra round of polish to do for L_aney and we are good to upload :) | 15:49 |
| === dkessel_ is now known as dkessel | ||
| === pstolowski is now known as pstolowski|afk | ||
| andyrock | seb128: Laney: oh I would got with this check "if (num_updates != 0 && errno == 0)" | 17:39 |
| andyrock | setting errno before to 0 | 17:39 |
| andyrock | num_updates will be 0 if we have "applied 0" or "applied invalid-number" | 17:40 |
| andyrock | and errno will be != 0 if there was an overflow or something else | 17:40 |
| seb128 | andyrock, that would probably work as well yes | 17:47 |
| Laney | I prefer positive error checking, going by what the documentation says | 17:50 |
| Laney | but if you feel strongly then that's fine | 17:57 |
| andyrock | https://www.irccloud.com/pastebin/rGwGLvXI/ | 17:58 |
| andyrock | Laney: ^^^ | 17:58 |
| Laney | andyrock: I'd probably make those separate variables so the code is more readable, but up to you - looks good to me! | 17:59 |
| Laney | 😘 | 18:00 |
| andyrock | tomorrow <3 | 18:04 |
| andyrock | EOD for me | 18:04 |
| Laney | me too | 18:05 |
| Laney | CLIMBING TIME 🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗🧗 | 18:06 |
| JanC | is gnome-shell crashing often a known issue in cosmic? | 23:44 |
| sarnold | I've heard it's easy for extensions to crash it -- if you have any extensions enabled, try disabling them | 23:46 |
| JanC | egh? | 23:46 |
| JanC | JavaScript causing a segfault sounds like a big issue to me... | 23:47 |
| JanC | big security issue too... | 23:48 |
| sarnold | that's one reason why we (security team) said "no" to the MIR to let browsers install shell extensions with one click | 23:50 |
| JanC | as opposed to just showing up in the software installer where they look "trusted"? | 23:51 |
| sarnold | yes; hopefully someone from debian and or ubuntu's read the ones we ship | 23:52 |
| JanC | you mean those in Gnome's repository? | 23:52 |
| JanC | because that's where it pulls them from... | 23:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!