| michael-vb | Hello there. I wanted to ask about a crash I am seeing with Ubuntu 18.10 in VirtualBox with Additions installed and 3D pass-through enabled. The crash is in strstr, seemingly called from glamour_egl_init. | 08:48 |
|---|---|---|
| michael-vb | It looks like what this patch: <https://lists.x.org/archives/xorg-commit/2018-April/041045.html> is meant to prevent. I see that check in the "apt source" sources, but I can't see it in the disassembly. | 08:48 |
| michael-vb | (Caveat that I am not good at reading disassembly.) Also, the line numbers in the debug symbols do not seem to match the apt source source, though the version numbers do. | 08:48 |
| michael-vb | Can anyone comment there? Didn't want to go reporting a bug before I know that it is not a problem at my end. | 08:48 |
| tjaalton | doubt anyone here uses such a setup | 09:43 |
| michael-vb | I am wondering about rebuilding the xserver-xorg-core package from the apt source sources to see if the problem goes away... but does it sound very silly that the binaries and sources do not match? | 09:45 |
| tjaalton | yes | 10:00 |
| michael-vb | Still rebuilding. Can you think of anything else I might have done to cause a mismatch? | 10:02 |
| tjaalton | you just assume that patch would help | 10:03 |
| jcristau | silly question.. are you sure you're looking at source and disassembly of the same version? | 10:03 |
| tjaalton | it's in 1.20.1, a rebuild won't help | 10:03 |
| jcristau | apt-get source sometimes does weird things | 10:03 |
| michael-vb | jcristau: that is roughly the lines I am thinking along. | 10:04 |
| michael-vb | tjaalton: it may still help me to match up line numbers. | 10:04 |
| michael-vb | Worst case it behaves exactly as it did. | 10:04 |
| tjaalton | if you have the source and a proper backtrace, you should be able to match the lines without a rebuild, no? | 10:10 |
| michael-vb | I have debug symbols installed and can reproduce the crash in gdb, but the line number is inside a comment in the source. | 10:12 |
| tjaalton | apply patches | 10:13 |
| tjaalton | which file | 10:13 |
| tjaalton | ? | 10:13 |
| tjaalton | source file | 10:13 |
| tjaalton | debian/patches/dont-init-glamor-on-llvmpipe.diff modifies glamor/glamor_egl.c | 10:14 |
| michael-vb | The source file as unpacked by apt source. Might that be missing patches? I thought it applied them on unpacking, but I often get confused with Debian source packages. | 10:14 |
| tjaalton | quilt push -a | 10:15 |
| jcristau | patching on unpack is not universal | 10:15 |
| tjaalton | and happens only on source 3.0 packages iirc | 10:16 |
| tjaalton | xorg-server isn't | 10:16 |
| michael-vb | quilt push -a applies the patches? | 10:16 |
| tjaalton | should | 10:17 |
| michael-vb | In which folder? | 10:18 |
| tjaalton | source root | 10:18 |
| michael-vb | Says "No series file found". | 10:18 |
| tjaalton | QUILT_PATCHES="debian/patche | 10:18 |
| tjaalton | s | 10:18 |
| tjaalton | QUILT_PATCHES="debian/patches" quilt push -a | 10:19 |
| michael-vb | It liked that better. | 10:19 |
| tjaalton | now check the line | 10:19 |
| michael-vb | Ah... | 10:19 |
| michael-vb | Yes, that adds a new strstr. | 10:20 |
| michael-vb | renderer = glGetString(GL_RENDERER); | 10:20 |
| michael-vb | if (strstr((const char *)renderer, "llvmpipe")) { | 10:20 |
| tjaalton | that patch is in current master | 10:20 |
| tjaalton | so file a bug upstream | 10:20 |
| tjaalton | and also in 1.20.2 | 10:21 |
| michael-vb | Not until I am sure that the problem is not on my end. | 10:21 |
| tjaalton | though, maybe it sholud be tested with 1.20.3 just in case | 10:21 |
| michael-vb | Thanks. | 10:21 |
| michael-vb | Now it looks a lot more like our Additions messing something up. | 10:24 |
| tjaalton | I could push 1.20.3 to a ppa if you like | 10:27 |
| tjaalton | well, I'll do it anyway because we want that in 18.10 and then in hwe-18.04 | 10:27 |
| michael-vb | I could give it a test if I can't quickly solve it in my own code. Shall I wait on IRC? You could also drop me an e-mail at michael dot thayer at oracle. | 10:30 |
| tjaalton | I'll push it to ppa:canonical-x/x-staging | 10:30 |
| tjaalton | in a bit | 10:30 |
| tjaalton | michael-vb: uploaded | 10:57 |
| michael-vb | Thanks. Will check later if I don't find anything in my code. | 10:58 |
| michael-vb | tjaalton: I fixed the problem in my code. I can still give the updated X server package a sanity run on my host system though if you like. | 14:27 |
| michael-vb | I assume it is mainly for Xwayland? | 14:27 |
| tjaalton | michael-vb: updates in it? mostly | 16:25 |
| michael-vb | I will give it a try out on my laptop when I have a chance. Don't know if that will be tomorrow though. | 16:26 |
| tjaalton | no worries | 16:39 |
| soee | hi, there is new driver version :) | 18:30 |
| mamarley | soee: What driver? :P | 19:06 |
| soee | mamarley: oh you... :D | 19:43 |
| soee | https://www.phoronix.com/scan.php?page=news_item&px=NVIDIA-415.13-Linux-Released | 19:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!