/srv/irclogs.ubuntu.com/2018/11/12/#snappy.txt

dokohttps://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/s/snapcraft/20181108_122554_7d4c2@/log.gz07:32
dokoraceback (most recent call last):07:32
doko  File "/tmp/autopkgtest.P8IYeA/build.5xT/src/tests/integration/plugins/test_rust_plugin.py", line 107, in test_cross_compiling07:32
doko    self.assertThat(binary, HasArchitecture("aarch64"))07:32
doko  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat07:32
doko    raise mismatch_error07:32
dokotesttools.matchers._impl.MismatchError: Expected 'aarch64' to be in ' x86-64'07:32
doko----------------------------------------------------------------------07:32
dokoRan 26 tests in 2831.729s07:32
dokoFAILED (failures=1, errors=1)07:32
dokoautopkgtest [11:08:32]: test integrationtests-plugins: -----------------------]07:32
dokoautopkgtest [11:08:33]: test integrationtests-plugins:  - - - - - - - - - - results - - - - - - - - - -07:32
dokointegrationtests-plugins FAIL non-zero exit status 107:32
dokozyga: ^^^ and armhf fails due to some cross compilation stuff07:48
pitfdtest08:31
pitfdhi everybody, can somebody be of any help with the following question?08:31
pitfdwhen I install Firefox via snap infrastructure, will it touch home directory of my currently installed FF ESR?08:32
pitfdstill running FF ESR 52 because of much needed adddon08:33
dokomvo: so snapcraft autopkg tests still fail trying to build some obscure rust code downloaded from the net, and due to some cross compile failure08:48
mvodoko: good morning! this is probably best discussed with sergiusens - but let me have a quick look, maybe something trivial could be done to unblock things08:55
mvohey Chipaca ! good morning08:55
Chipacamvo: hey! how're you doing?08:55
mvoChipaca: good, thank you! had a nice and refreshing weekend08:56
mvoChipaca: didn't play hockey for family reasons, that made me slightly sad08:56
mvoChipaca: but otoh family  made me happy so a overall a net plus :)08:56
mvoChipaca: and you?08:56
Chipacamvo: :-)08:57
Chipacamvo: I didn't play hockey either!08:57
Chipaca:-D08:57
mvolol08:57
dokomvo: well, at least he's highlighted08:57
Chipacamvo: but a good weekend, yes. Planning a break early december though.08:57
mvodoko: I think he got highlighted last week already :/08:58
mvoChipaca: uh, I need to plan my break as well08:58
pedronislast week was the summit though08:58
mvopedronis: aha, good point08:58
pedronisChipaca: when?08:58
Chipacapedronis: i've got 15 days to use-or-lose. Do you remember if it was 3, or 5 that could be carried over?09:01
Chipacapedronis: in any case: the week from 3-7 december, for sure09:02
mvodoko: quite a few errors, I think I leave this best to sergio, I could disable some of the tests that look like upstream changes but other bits look like they have different causes :/09:03
mvoChipaca: 509:03
Chipacamvo: ta09:04
mvoChipaca: sounds like you will enjoy a long vac in dec then :)09:04
mvoChipaca: good for you (not so good for us ;)09:04
Chipacambuahaha09:04
* Chipaca takes all december off09:04
Chipaca(no)09:04
mvofwiw 6127 needs a review, apparently this helps bringing a machine  back to life that got into a bad state by disabling a snap on arm that uses gpio09:05
pedronismvo: it has so tests atm tough,  zyga said he was working on some09:06
mvopedronis: :( ok, I can look at this, zyga is off today09:06
pedronismvo: we also need to decide how to distribute the fix09:09
Chipacapedronis: mvo: what's the bug?09:10
mvopedronis: my understand is that putting it into the edge core is ok for now. then the user can snap refresh --edge core, snap enable affected snap and snap refresh --stable core09:11
pedronisChipaca: gpio interface require some order dependency across the systemd and the apparmor backend for slot and plug09:11
pedronisseems we fix some part of that, but enable/disable of affected snaps atm is broken09:11
Chipacaah09:12
pedronismvo: ok, that assumes they are happy to try edge for this09:12
pedronisanyway we need on edge to start either way09:12
Chipacareminds me, from the summit: we need a way to install a snap with its services disabled09:12
mvopedronis: it does, we could use a hotfix branch, not sure if all the bits are in place for this though09:13
pedronis?09:13
mvopedronis: sorry if I was unclear, a store branch in a channel09:14
pedronisyes09:14
pedronisthose are supported09:14
pedronisyou mean building it on our side?09:14
mvoI think we have not used one for us yet09:14
mvopedronis: yeah, we could take a stable core and do a one-off build for them, its a bit of work though (mostly because we need this for arm)09:15
mvoso not sure its really worth it09:15
=== cpaelzer_ is now known as cpaelzer
pedronisas I said we need to ask09:15
mvook09:15
mvoChipaca: I updated 6039 with your suggested error message (I think its a good choice)09:18
Chipacamvo: over the weekend I was reminded of #166900009:22
mupBug #1669000: classic snap can't use confinement override <amd64> <apport-bug> <xenial> <Snappy:New> <snapd (Ubuntu):Confirmed> <https://launchpad.net/bugs/1669000>09:22
mvoChipaca: is jacknorriswebserver a classic snap?09:24
mvoChipaca: we need to adjust our error message here, correct?09:25
mvoChipaca: or is there more to it?09:25
Chipacamvo: ignore the last comment, i think they're off piste09:25
mvoChipaca: ok09:25
Chipacamvo: it's very close to 6039, but from the other side09:26
Chipacamvo: yes we probably should check and return a better error, like with --classic, but i'm not sure how current the problem is09:26
Chipacai haven't tried09:26
Chipacai just saw it, thought "oh that's similar to 6039" and went on with my weekend09:26
mvoChipaca: heh, ok09:27
pedronisChipaca: heh09:27
pedronisanyway doesn't sound super urgent09:27
Chipacacorrect09:28
Chipacatalking about urgent, i'm off to epochs land09:28
pedronisChipaca: let me know how that goes,  we should chat about how to do the further requests bit09:41
pedronissoon09:41
Chipacapedronis: yep09:43
zygahey09:46
zygaI'm off, just wanted to say a few words09:46
zygaI ran into some interesting bugs while reinstalling my devices09:46
zygahttps://bugs.launchpad.net/snapd/+bug/180277309:47
mupBug #1802773: Cannot refresh from ubuntu-core 2.15.2 on raspberry pi "ubuntu core 16" image - snap-declaration for "snapweb": parsing assertion headers: expected 4 chars nesting prefix after multiline introduction "plugs:": "  network:" <snapd:Confirmed> <https://launchpad.net/bugs/1802773>09:47
zygaour stable images cannot update09:47
zygawith that I'm off to fix the printer09:51
zygattyl09:51
pedroniszyga: that's a store problem I think09:52
zygayes09:52
Chipacapedronis: the action context does need to carry epochs always, right?09:59
pedronisChipaca: correct10:00
pedronisafaiu10:00
Chipacapedronis: a lot of the test changes are going to remain ¯\_(ツ)_/¯10:00
pedronisoh well10:01
pedroniswe still want the change10:01
pedronissaner api use10:01
* Chipaca ~> afk10:08
* Chipaca ~> really afk10:12
=== chihchun_afk is now known as chihchun
ackkChipaca, hi, FWIW I filed https://bugs.launchpad.net/snapd/+bug/1802721 about that issue I'm having with bash completion11:29
mupBug #1802721: bash-completion not working on core18-base classic snap <snapd:New> <https://launchpad.net/bugs/1802721>11:29
=== chihchun is now known as chihchun_afk
pedronisChipaca: were snapshots done in 2.36 or will in 2.37 ?12:09
cachiomvo, hey12:20
mvohey cachio12:21
cachiomvo, about beta validation12:21
cachiothere were some issues on dragonboard12:22
mvocachio: oh, tell me more please12:22
cachiomvo, first I saw this error12:22
cachioon 2 executions12:22
cachiosame error12:23
mvocachio: do you have a link to the error text?12:23
cachiohttps://paste.ubuntu.com/p/jZbsWd7x36/12:24
cachionext execution 13 tests failed12:24
cachiomvo, I am gonna debug nor12:24
cachionow12:25
cachiomvo, I go slow with the db because mine is broken so I am using a remote one12:25
cachiomvo, now I'll try to use mine with external display and usb keyboard12:25
mvocachio: hm, Cannot access MTD device /boot/uboot/uboot.env: No such file or directory look scary12:26
cachiomvo, the rest of the devies are ok12:26
cachiomvo, yes12:26
mvocachio: please check if /boot is mounted once you have a debug session12:26
mvoI check back after lunch12:26
cachiomvo, I could reproduce that in 2 different devices12:27
cachiomvo, sure12:28
cachioI'll continur with this12:28
jamespagesergiusens: o/13:03
jamespagesergiusens: does snapcraft support use of the before/after stanzas for daemon application startup ordering within a snap yet?13:03
jamespageor have I got the wrong end if the stick on that feature being implemented13:03
pedroniscachio: mvo: what were the errors during the weekend about snapd-vendor-daily?13:09
cachiopedronis, checking13:16
cachiopedronis, I dont see any error on snapd-vendor-sync13:17
cachioat least the spread cron branches worked13:17
cachioand all of them are in green13:18
pedroniscachio: I'm talking about the recipes on LP13:18
pedronis[recipe build #1985875] of ~snappy-dev snapd-vendor-daily-cosmic in cosmic: Failed to build13:18
pedronisetc13:18
cachiopedronis, ahh, ok, the recipe failed to build13:19
cachioI'll check that13:20
cachioI am gonna add a new spread cron branch to check the result of that recipe13:20
cachiocurrently we are just triggering but not checking the resutls13:20
cachiopedronis, seems to be a infrastructure issue13:25
cachiofailed doing "git fetch"13:26
cachioon xenial and cosmic as well13:26
Chipacaackk: yes that issue is true. For now, install core to get tab completion even if your snap is core1813:36
Chipacaackk: #6126 addresses it13:36
mupPR #6126: dirs, wrappers, overlord/snapstate: make completion + bases work <Created by chipaca> <https://github.com/snapcore/snapd/pull/6126>13:36
ackkChipaca, as noted in that LP bug, even with core it doesn't work13:37
Chipacaackk: with core, it works13:38
ackkChipaca, not in my case, see the bug13:38
Chipacasigh13:38
Chipacaackk: the bug just says "it doesn't work"13:38
Chipacaackk: https://forum.snapcraft.io/t/debugging-tab-completion/419813:39
ackkChipaca, well, no also says I followed the forum thread, and everything except step 4 works13:39
ackkChipaca, including the last step, if I load completion in the snap manually13:39
Chipacaackk: ah sorry13:39
Chipacaackk: I'd misread and misremembered it and just scanned it and jumped to conclusions and now I feel terrible and I'm sorry13:40
Chipacagive me a sec to recover and i'll walk through it with you in a moment13:40
ackkChipaca, heh, np13:40
Chipacaackk: for step 4, where's the -x output?13:41
ackkChipaca, you want the full output or just the output of  compelte -P?13:41
ackkChipaca, https://paste.ubuntu.com/p/wdfXH7yHcf/13:42
mupPR snapd#6128 opened: overlord/ifacestate: setup security backends phased by backends first <Created by mvo5> <https://github.com/snapcore/snapd/pull/6128>13:43
Chipacaackk: right13:43
Chipacaackk: so there's something missing13:43
Chipacaackk: in that pastebin, see how the returned string points to a "cannot"13:43
ackkChipaca, yeah but that's in the script13:43
ackkI mean that's not the output of complete, it's the script tha compares with "cannot"13:44
Chipacaackk: so there _probably_ is a "cannot find completion specification for yadda.yadda"13:44
Chipacahmm13:44
* Chipaca looks13:44
Chipacaackk: you're right13:45
ackkChipaca, the problem I think is that complete -P only returns "default" and empty lines (as mentioned in the bug )13:45
ackkChipaca, but if I run it in the --shell it works13:45
ackk(hence I was suspecting that --command=complete does something different13:45
Chipacaackk: so13:49
Chipacaackk: if you run snap run --command=complete sshoot 9 9 7 1 ' ' 'sshoot ' sshoot ''13:49
Chipacaackk: what do you get?13:50
Chipacaackk: because I get a clear indication of where the problem is13:51
Chipacaackk: so I was wondering what you saw :-)13:51
ackkChipaca, https://paste.ubuntu.com/p/tntr3dNtSW/13:57
ackkChipaca, with multiple blank lines13:57
Chipacagah pastebin is very slow here13:58
Chipacanot sure why13:58
Chipacaackk: https://dpaste.de/jr9h13:59
ackkChipaca, are you running on bionic?13:59
Chipacaackk: no13:59
ackkChipaca, that's another bug I filed, that mvo is fixing, classic bionic snaps don't work on xenial14:00
Chipacaah this is the bad symlink thing?14:00
ackkyeah14:00
Chipacamvo: is that fixed on core18 edge?14:00
* Chipaca checks14:00
Chipacai'm on edge14:00
Chipacaso probably no :-)14:00
pedronisChipaca: standup? :)14:01
=== chihchun_afk is now known as chihchun
Chipacagah, standup o'clock14:01
Chipacapedronis: omw14:01
Chipacaackk: so the next step would be to do the 'snap run --shell', and run etelpmoc.sh14:21
Chipacaackk: which takes a lot of arguments, but it's got a comment explaining them14:22
Chipacaackk: that's what 'snap run --command=complete' thing does, once it's 'inside'14:22
ackkChipaca, /snap/core/current/usr/lib/snapd/etelpmoc.sh is not executable, is that right?14:23
ackkdoes snap run run it with "bash" ?14:23
Chipacaackk: yes14:25
ackkChipaca, https://paste.ubuntu.com/p/PYy443Xw9S/14:25
ackkChipaca, note that if I actually source the sshoot-completion script inside a --shell, it works14:26
ackkChipaca, why is it not found?14:26
Chipacaackk: because I don't think the arguments are right14:26
ackkuhm14:26
Chipacaackk: dunno14:26
Chipacaackk: i'm technically in a meeting14:26
ackkI passed the same as the --command=complete, plus the completion script name at the beginning14:26
Chipacaackk: half a neuron on this14:26
ackkChipaca, ok sorry14:26
Chipaca:-)14:26
Chipaca    _die "USAGE: $0 <script> <COMP_TYPE> <COMP_KEY> <COMP_POINT> <COMP_CWORD> <COMP_WORDBREAKS> <COMP_LINE> cmd [args...]"14:27
Chipacaackk: OTOH if the arguments are wrong, that'd be consistent with what it's seeing14:28
Chipacadunno14:28
ackkChipaca, is there a way to grab the actuall command that snapd runs?14:28
Chipacaackk: let me look at the plumbing14:30
ackkChipaca, found it from strace: /bin/bash /usr/lib/snapd/etelpmoc.sh /snap/sshoot/78/sshoot-completion 9 9 7 1 "sshoot " sshoot ""14:31
ackkChipaca, this returns empty lines when run in the snap14:31
Chipacaackk: was about to say, you just need the abs path on the completion script14:31
Chipacaackk: time to bash -x it :-)14:32
ackkChipaca, https://paste.ubuntu.com/p/xBZ6j7Gqvm/14:34
Chipacaackk: could you copy etelpmoc.sh somewhere, and set -x after it sources bash-completion?14:36
Chipacaackk: because at least I can't make sense of the whole thing :-)14:37
ackkChipaca, https://paste.ubuntu.com/p/qGfvRhqVHR/14:38
Chipacaackk: there's a problem with the complete -p call14:41
Chipacaackk: +++ complete -p ''14:41
Chipacaackk: that '' should be 'sshoot'14:41
ackkChipaca, yeah but it's called with "$1" after a whole lot of shift's14:42
Chipacaackk: ah!14:43
Chipacaackk: you're missing a " " between the 1 and the "sshoot "14:43
ChipacaCOMP_WORDBREAKS14:43
ackkChipaca, https://paste.ubuntu.com/p/gHbdhWyxqW/14:46
ackkChipaca, hold on, sorry, wrong arg14:47
ackkChipaca, https://paste.ubuntu.com/p/yX6bdF29Kx/ should be the one14:47
ackk__python_argcomplete_run '' looks suspicious14:48
mvoackk: the core18 thing should be fixed with core in edge (the bug you mentioned friday)14:49
Chipacaackk: yes14:49
ackkChipaca, because _python_argcomplete is called with no argument14:51
ackkit should get "sshoot" afaiu14:51
Chipacaackk: try it -- you have all the args it gets14:51
ackkChipaca, what should I try?14:52
ackkmvo, ah thanks14:52
Chipacaackk: IFS=$'\v' COMP_LINE='sshoot ' COMP_POINT=7 COMP_TYPE=9 _ARGCOMPLETE_COMP_WORDBREAKS=' ' _ARGCOMPLETE=1 _ARGCOMPLETE_SUPPRESS_SPACE=1 __python_argcomplete_run ''14:53
ackkChipaca, I need to source the completion file first right?14:54
Chipacaackk: yes14:54
ackkChipaca, ok, so that returns empty, if I pass 'sshoot' as argument, it returns the options14:55
ackkChipaca, the first argument is the command14:55
Chipacaackk: so why is that getting lost?14:55
popeydegville: I'm trying to find a link at https://docs.snapcraft.io/snap-documentation/3781 which helps me help a developerrequest classic.14:56
popeydegville: I have clicked everywhere I think, and can't find a doc, should that not be exposed?14:56
ackkChipaca, IDK, that's snap's autocompletion I think14:57
Chipacaackk: could you pastebin the script that's generated?14:58
popeydegville: never mind, I'll file a bug :)14:58
ackkChipaca, well actually it's basically what you see in the previous pastebin, those two __python_* functions14:59
Chipacaah obvs14:59
degvillepopey: yes, it should be. The publishing side is next on my todo list (I promise)...15:01
popey:)15:01
ackkChipaca, https://paste.ubuntu.com/p/rFVJpP84yn/15:01
Chipacaackk: what happens if you add "$@" to $_compfunc ?15:02
ackkChipaca, sorry, where?15:03
Chipacaackk: etelpmoc.sh, after the $bounce check15:04
Chipaca$_bounce15:04
ackkChipaca, that works15:04
Chipacaackk: dammit15:04
Chipacaackk: so I need to fix this, but you can fix it at your end as well15:05
Chipacaackk: so if instead of calling the python generator you generate the script, and edit it to not need $1 but hardcode sshoot, it will work15:07
Chipacaackk: also you'll avoid a python code in completion which will make it suck less :-)15:07
ackkChipaca, sure, but that's bound to happen to any python script :)15:07
Chipacaackk: oh, i'm fixing it, but it'll be a month at least before you get it in stable15:08
Chipacaackk: OTOH I'd tell anybody using python there to stop :-)15:08
ackkwhy, argcomplete is so nice15:08
Chipacaackk: agcomplete yes15:08
ackkyou get autocompletion for free15:08
Chipacaackk: i'm not saying don't use argomplete15:08
Chipacaackk: i'm saying don't call python to generate a shell script that calls python15:09
ackkah yeah I see, I can call it on snap build I guess15:09
Chipacaackk: that will easily put you below the 200ms threshold of "fast"15:09
ackkChipaca, why does this only seem to affect this case?15:09
Chipacaackk: because most completion scripts don't look at $1 i guess :-)15:10
Chipaca_complete_potato doesn't check that it's called as potato15:10
ackksure but if $1 isn't there, everthing is shifted  ?15:10
ackkah you mean it's only using vars15:10
Chipacaackk: no because everything the completer looks at is in COMP_ variables15:10
ackkok15:10
ackkI see15:10
Chipacaexactly15:10
ChipacaI didn't even know bash passed $115:11
Chipacait's not like any of this is specced anywhere15:11
Chipaca:-)15:11
ackkChipaca, ok, thanks for the help debugging, I'll workaround it15:11
Chipacai'll push a fix in a bit15:11
ackkChipaca, it makes sense, if you have multiple commands that use the same completion15:11
Chipacafirst i'll get a cuppa tea and i'll turn on the heating because somebody turned off the sun15:11
ackkI see how it's not widely used15:11
cachiomvo, this last run is running well on dragonboard15:24
cachiomvo, perhaps we need to build our image in another way15:24
cachioinstead of using beta channel15:25
mvocachio: interessting, what did you change?15:25
cachioin general15:25
cachiowe can use just core from beta15:25
cachioan the rest from stable15:25
cachiomvo, it is a new image15:25
cachiomvo, do you know if there was any change for the kernel snap?15:27
cachiomvo, I am havin lunch15:30
cachioI'll research a bit about the diff on the images15:30
cachioto see what could happen15:31
* cachio lunch15:31
mvocachio: not sure, let me check if the kernel has changed recently15:37
pedronisniemeyer: here's the discussion I mentioned about service order: https://forum.snapcraft.io/t/cross-snap-service-ordering/831915:38
mvocachio: one week and 5 days ago was the last upload15:38
mupPR snapd#6129 opened: data/completion: pass documented arguments to completion functions <Created by chipaca> <https://github.com/snapcore/snapd/pull/6129>15:57
Chipacaackk: ^15:57
ackkChipaca, nice, thanks15:57
Chipacaackk: a big difference that makes argcomplete's eval(<some python>) approach slow with snaps is that the whole environment is discarded every time15:58
Chipacaackk: whereas outside of snap you'd only do the eval the first time you tap tab15:58
ackkChipaca, sigh, I was trying to put the generated completion file in snap/local, but snapcraft looks for it before actually filling snap/15:58
ackkChipaca, ah yeah I had noticed completion was slow15:58
Chipacaye15:59
sergiusensjamespage: you can use passthrough. I would explain more but I am sitting on a plane waiting on news on my diverted flight due to failed landing16:02
ackkis there a way to access the snap/ dir (IOW $PWD/snap from where "snapcraft" is run) inside a part?16:05
mupPR # closed: core-build#11, core-build#22, core-build#26, core-build#3716:13
mupPR # opened: core-build#11, core-build#22, core-build#26, core-build#3716:14
ackkChipaca, got it working with the generated shell completion16:17
Chipacaackk: woo16:17
Chipacaackk: any faster?16:17
ackkChipaca, can't really tell 'cause I haven't been using the old one, but it seems fast enough16:18
Chipacaackk: fair enough16:19
Chipacaackk: next you may want to look into whether passing some of the don't-load-site-libaries options still works and speeds up your python, or not16:20
Chipacaackk: in the http snap I found it sped things up by quite a bit16:20
Chipaca(but i had to fiddle with sys.path in the script)16:20
ackkmvo, in which core18 version is the ldd link fixed?16:22
ackkI still see it broken in edge16:22
ackk(449)16:22
mvoackk: yeah, its not merged yet, I was hoping for a review from foundations. if there is none by tomorrow I will merge, could you please remind me in our morning again?16:23
ackkmvo, ah I see, I thought it was pushed to edge already16:24
ackkmvo, sure, thanks16:24
mvoackk: this fix is not, just the other one in core when there "core18" only and no core (the fix for the configure script)16:24
ackkmvo, oh, that one, I see16:25
cachiomvo, I am making some tests to see how it works changing the way we create the image16:36
mvook16:37
cachiomvo, because the test process is the same, what could change is the image we use16:40
cachiomvo, or testflinger is having some troubles to build the image16:41
cachiobut no error shown in the logs16:41
mvocachio: hm, thanks. is it worth checking with plars  if there might be any testfilinger issues?16:43
plarscachio: we don't typically build images, we install them from url16:45
plarscachio: I'm happy to try it out if you email me some info though... I'm sprinting right now though, so email preferred since it's 12:30am16:46
cachioplars, sure16:47
cachioplars, I'll write an email16:48
mupPR snapd#6130 opened: snap: make Epoch's MarshalJSON not simplify <Created by chipaca> <https://github.com/snapcore/snapd/pull/6130>16:53
pedronismvo: mmh, we are getting timeouts in travis, for example your #603916:53
mupPR #6039: snapstate: do not allow classic mode for strict snaps <Created by mvo5> <https://github.com/snapcore/snapd/pull/6039>16:53
mvo:/16:54
cachiopedronis, mvo checking16:56
pedroniscachio: thx16:56
cachiopedronis, mvo it is the opensuse issue I mentioned on friday16:56
cachioI was trying to update it today but still getting some errors16:57
cachiopedronis, in case I can't create a new image today I'll move to manual until it works again properly16:57
pedronisthanks16:57
cachionp16:57
mupPR snapd#6131 opened: store:  remove unused currentSnap and currentSnapJSON <Simple 😃> <Created by chipaca> <https://github.com/snapcore/snapd/pull/6131>17:02
mupPR snapd#6132 opened: many: some small doc comment fixes in recent hotplug code <Created by pedronis> <https://github.com/snapcore/snapd/pull/6132>17:04
mvozyga: for tomorrow - I pushed a spread test for 6128 (the gpio bug). it hopefully simulates things good enough, fails on master (so triggers the bug), I'm waiting for the successful run and will check after hockey17:17
cachiomvo, last run on dragonboard passed17:26
cachioit is running on my device17:27
cachiothe diff as I said the the source image17:27
mupBug #1803002 opened: Multiple SELinux alerts on install / uninstall on Fedora 29 <Snappy:New> <https://launchpad.net/bugs/1803002>23:30

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!