=== Class7_ is now known as Class7
didrocksgood morning07:26
dufluHi didrocks07:34
didrockshey duflu07:35
=== pstolowski|afk is now known as pstolowski
oSoMoNgood morning desktoppers08:36
dufluHi oSoMoN08:42
oSoMoNhey duflu08:42
willcookemorning Laney09:02
seb128good morning desktopers09:04
Laneyhey willcooke, what's up? good holiday?09:04
Laneyhey seb12809:04
seb128hey willcooke, Laney, how is the u.k?09:05
Laneystill here, no tanks on the streets just yet09:06
Laneyhow are you? good weekend?09:07
seb128yeah, a bit busy prospecting for buying some furnitures but also relaxing, it also feels like winter now, brrrrr09:09
dufluMorning willcooke, Laney, seb12809:09
dufluseb128, if there's a deb in disco that works perfectly as an SRU for cosmic, how would you propose that?09:10
seb128duflu, you need a bug with the SRU info (impact/test case/regression potential) and point to the disco version/the launchpad debdiff09:12
seb128if the diff has no "side changes" just reuploading with a ~18.10 version or such should be enough09:12
dufluseb128, well, there are other bugfix changes. It's a bugfix only release. Does that matter?09:13
duflu(gjs 1.54.2)09:13
seb128if it's a GNOME point update it's fine, those have special rules that it's ok to do the version update09:13
seb128still need a SRU like bug09:13
dufluseb128, so the only requirement is that the version string is unique to cosmic?09:14
dufludifferent to disco09:14
seb128right, lower to disco, also that it has a SRU bug number reference in its changelog09:15
dufluOK. I'm guessing lower means 1.54.2-0...09:16
seb128duflu, versioning recommendations are documented on https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging09:21
seb128so yeah that would be a -0ubuntu0.18.10.1 version09:21
Laneythere's a gjs 1.54.3 by the way09:27
LaneyI was just building that09:27
dufluLaney, I know but pushing cosmic ahead of disco isn't allowed, or useful in this case09:32
Laneyit won't be ahead in a few minutes :-)09:33
Laneyreally annoying10:56
LaneyI've got empty window 19 and window 4510:57
Laneyapparently forgot to save whatever channel I used to have in there10:57
Laneylong uptime problems10:57
=== jdstrand_ is now known as jdstrand
andyrockLaney: do I need an SRU to backport this to cosmic? https://bugs.launchpad.net/ubuntu/+source/mozjs60/+bug/179623814:22
ubot5Ubuntu bug 1796238 in gjs (Ubuntu Cosmic) "[regression] mozjs60 crashes with SIGSEGV on gnome-shell exit, in GetPropertyOperation() from Interpret() from js::RunScript()" [Medium,In progress]14:22
Laneyandyrock: if it's in the upstream release, not explicitly15:02
andyrockLaney: yeah it's the upstream release15:03
andyrockwho should I ask to sync it?15:03
Laneyit should be converted to an SRU bug yes, but the test case can just say it's covered by https://wiki.ubuntu.com/StableReleaseUpdates/GNOME and doesn't need to be tested specifically15:03
Laneyit is synced to disco, still needs uploading to cosmic though15:06
Laneyduflu mentioned that earlier so I would check with him that he didn't start working on that15:06
andyrockwell I just need to convert the bug, so no big deal15:10
Laneyyeh, someone does need to prepare & upload though15:11
* Laney fixes things to build with --std=c11, thanks nautilus15:39
andyrockseb128: what's the correct link here https://bugs.launchpad.net/ubuntu/+source/gnome-initial-setup/+bug/178992517:10
ubot5Ubuntu bug 1789925 in gnome-initial-setup (Ubuntu Bionic) "Link to Ubuntu Report legal notice points at the wrong page" [High,Fix committed]17:10
andyrockseb128: the test case says "https://www.ubuntu.com/legal/terms-and-policies/systems-information-notice" but I'm getting https://www.ubuntu.com/legal/data-privacy17:10
Laneythe one in the test case is right17:11
andyrockso the package is broken17:11
Laneythat would be surprising looking at the diff17:12
andyrockI'm checking bionic17:12
Laneydouble checked the version?17:12
andyrockdisco and cosmic are not relevant considering that livepatch is not supported17:12
andyrockI did apt source ...17:13
andyrockand in the changelog it says: gnome-initial-setup (3.28.0-2ubuntu6.16.04.4) bionic; urgency=medium17:13
LaneyI'd use apt policy to see which version is installed17:14
Laneybut I only looked at cosmic indeed17:14
andyrockhere: http://launchpadlibrarian.net/396483675/gnome-initial-setup_3.28.0-2ubuntu6.16.04.3_3.28.0-2ubuntu6.16.04.4.diff.gz17:15
Laney                               "https://www.ubuntu.com/legal/dataprivacy",17:16
Laneylooks buggy17:16
andyrockI'm checking here: https://code.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-initial-setup/+git/gnome-initial-setup/+ref/ubuntu/bionic17:16
=== pstolowski is now known as pstolowski|afk
andyrockI'm a little bit confused17:17
Laneyme too17:21
Laneyisn't that right?17:22
willcookeLivepatch page should point to: https://www.ubuntu.com/legal/dataprivacy17:25
willcookeUbuntu Report should point to: https://www.ubuntu.com/legal/terms-and-policies/systems-information-notice17:25
willcookevia: https://bugs.launchpad.net/ubuntu/+source/gnome-initial-setup/+bug/1789925/comments/517:25
ubot5Ubuntu bug 1789925 in gnome-initial-setup (Ubuntu Bionic) "Link to Ubuntu Report legal notice points at the wrong page" [High,Fix committed]17:25
Laneythat's what that pastebin shows no?17:25
willcookeso testcase is wrong17:25
willcookeI will fix the test case, one sec17:26
Laneyoh ok it should say ubuntu report page17:26
willcooketest case fixed17:27
willcookesorry for the confusion, seb and I tripped over that one17:27
willcookeI've updated my bionic proposed machine today, so I will do a round of verification tomorrow17:27
Laneydisco looks bad though17:31
Laneythought we had code to get that from /etc/os-release :(17:31
jbichaseb128: could you look into subscribing the bugs team to libcue & libsf ? LP: #1770871, LP: #177087417:33
ubot5Launchpad bug 1770871 in libcue (Ubuntu) "[MIR] libcue" [Undecided,Incomplete] https://launchpad.net/bugs/177087117:33
ubot5Launchpad bug 1770874 in libgsf (Ubuntu) "[MIR] libgsf" [Undecided,Incomplete] https://launchpad.net/bugs/177087417:33
jbichaLaney: os-release ultimately points to https://www.ubuntu.com/legal/data-privacy It looks like neither of those privacy policies link to the other17:35
Laneyok, not sure what you're getting at17:36
Laneywe used to read os-release and now it hardcodes the url that's in there17:36
jbichaI don't know what I'm getting at either17:39
andyrockso that patch removed the code to read from /etc/os-release to read from an hard-coded link17:40
andyrockI'm still confused17:40
LaneyI think it should be hardcoded in the ubuntu-report page and use os-release in livepatch17:41
Laneyit looks to me like the livepatch page has bionic hardcoded right and cosmic/disco hardcoded wrong17:41
LaneyI would fix it in disco, not like it matters for cosmic since you don't get the page there anyway17:42
Laneyimho anyway17:42
andyrockk makes sense now17:42
Laneywhere "fix" means "go back to using os-release" (again imho)17:42
Laney(but I'm not sure why it was deleted, maybe an accident?)17:43
andyrockmmm it looks like it never read from /etc/os-release17:44
andyrockit was always hardcoded in livepatch page17:44
andyrockI can prepare a patch17:45
Laneythat was only in the report page?17:45
andyrockyeah report page was reading from /etc/os-release17:45
andyrockI can prepare a patch to read it from /etc/os-release in disco17:46
andyrockand later we can SRU it17:46
Laneyit looks like it has the functions to do that already17:46
Laneyso patch should be quite easy17:46
andyrockin a different page17:46
andyrockmaybe we can move the all code in a shared file too17:47
andyrockbut we should not block the current deb in bionic-proposed as it is "correct"17:47
Laneyits there17:47
Laneyyou already use os-release for the is_lts() thing17:48
andyrockmmm where?17:48
andyrockah right17:49
andyrockkk nice17:49
andyrockI'll mark it as verification-done and prepare the upload to disco17:49
* Laney has been failing a lot today17:51
Laneyit's fun, you can replay those backwards and it's like an epic journey of failure17:51
andyrockk so the bug is confusing because it says in the title "Ubuntu Report" but in the test case it says "livepatch"17:52
andyrockI'll make it less ambigous17:52
Laneyyeah typo/thinko I think17:52
Laneywillcooke just said he fixed it17:52
Laneydoesn't seem to be though ;-)17:53
andyrockI'm chaning it17:53
willcookesorry was eating, back now17:55
willcookeare we all sorted?17:55
willcookethank you!17:55
andyrockand verified that it works17:55
andyrockLaney: can you create an ubuntu/cosmic branch in gnome-control-center ?18:39
willcookenight all18:54
seb128andyrock, Laney, was the SRU good or buggy at the end?19:30
andyrockseb128: the SRU was good21:03
andyrockI marked it as verified21:03
andyrockbut it still makes sense to read it from /etc/os-release (in livepatch not in ubuntu report)21:03
andyrockit's low priority considering that disco will not have livepatch support21:04
andyrockbut it's better to merge it otherwise we'll forgot :)21:04
andyrocksaid that it's EOD for me :)21:04

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!