[00:00] ok. It threw an error for me. but `mount.cifs` did not. I did have to install !cifs-utils [00:00] my question, how, who, where decide to put things like a removable drive or not. [00:01] kc2bez, mount.cifs and mount -t cifs are synonymous [00:01] mount -t cifs calls mount.cifs [00:01] just how mount -t ext4 calls the corresponding mount. command [00:01] (sorry late reply) [00:02] it'd help to know the error you're seeing though [00:02] for better diagnosis [00:02] I'd help but E:NOVMs [00:03] thanks. I will run it again. It may have been the cifs-utils or lack of. [00:03] almots 100% certain it's the cifs-utils not being present [00:13] kc2bez, once I'm at work tomorrow I Can do a test to see if it works, I've got anh 18.10 test VM there and the workplace cifs shares [00:13] if it works with cifs-utils installed then I'd chalk it up to not having that installed [00:14] (it's one of the things I ALWAYS install with my bootstrapper post-install scripts) [00:14] I just tested it, it works either way. Still doesn't show on the desktop which was the original bug report. [00:15] wxl: re: lxde & center/centre; I'm testing 19.04 so LXQt - but i believe that would fix main issue [00:15] They were on 18.04 [00:15] kc2bez, can you do me a favor and do a test? [00:15] yes [00:15] create a dedicated dir under /media/ called testing [00:15] mount to that dir [00:15] IIRC things under /mnt/ don't list [00:15] and that's always been the case since 14.04 on all variants [00:16] since (guaranteed as recently as)* [00:16] ok makes sense, I put it in /mnt force of habit I guess [00:16] kc2bez, yep, hence the additional test dir for /media/ [00:16] upstream super key bug closed as won't fix so workaround it is [00:16] got a link to the bug/task? [00:16] i'll make a comment [00:17] https://bugs.launchpad.net/ubuntu/+source/pcmanfm/+bug/1790924 [00:17] Launchpad bug 1790924 in pcmanfm (Ubuntu) "pcmanfm desktop shortcut cifs mount volumes" [Undecided, New] [00:17] major premise is that openbox is NOT the canonical window manager of openbox so where there are conflicts with how openbox does things shouldn't be an lxqt issue https://github.com/lxqt/lxqt/issues/1605#issuecomment-440473609 [00:17] Issue 1605 in lxqt/lxqt "lxqt-globalkeys and Super key problems" [Closed] [00:18] They were mounting to /Public which may not show either I guess. [00:19] /Public is a thing? [00:19] last I saw that, that was a Mac thing [00:19] unless they made it themselves [00:20] wxl: "major premise is that openbox is NOT the canonical window manager of openbox" lolwat [00:20] kc2bez, once I get a VM back up I'll see if I can reproduce or fix [00:20] of lxqt [00:20] it may be related to *where* the mountpoint sits on-disk [00:21] or if it's /etc/fstab'd [00:21] (I know we're crosstalking sorry!) [00:21] I'm following [00:22] Typing in my terminal too. [00:24] (my apology was to wxl heh) [00:24] Sorry wxl [00:24] *sits on wxl in the interim* [00:25] * wxl bites [00:25] It worked in /media I think the issue is the mount point. [00:25] kc2bez, i'm almost certain it is, system automount is to /media/* [00:25] kc2bez, make another dir outside of mnt and add it to /etc/fstab [00:25] then try and mount it [00:25] see if it works then [00:26] Hey wxl I'm about to fix our langpack issue completely, once and for all. [00:27] orly [00:27] mhhhhhm [00:27] *won't believe until he sees it8 [00:29] i saw that [00:29] excited [00:31] docEbrown: Heya [00:31] yo [00:31] One other issue I've been having is the mouse clicks near the taskbar that would click and drag a program ie firefox and kill the process [00:31] Same goes with actual Firefox tabs [00:32] Is there any way to make lubuntu less sensitive to click and drag events? [00:32] docEbrown: https://paste.ubuntu.com/p/ZFXM9T3qVr/ [00:32] kc2bez, or even just create a dir at /Public and mount there and see [00:32] Like any click event at the slightest will kill a process [00:32] i'll bet you it's that mountponit problem [00:33] OHHHHHHH docEbrown [00:33] run_lugito doesn't actually run Lugito, does it? :P [00:34] ha sorry! There are a couple of ways. If you pip install -e . [00:34] i could have told you that tsimonq2 i discovered that an eon ago LOL [00:34] you can just type lugito [00:34] and it will run [00:34] ahhhhhhhhhhhhhh [00:35] @teward you are right. No go on /Public nor anything else I have tried. [00:36] I got the paste, I'll have a look after work this afternoon if thats ok [00:37] Sure. [00:37] just to confirm the quotes are actually characters in the password right e.g. abc123"some"stuff [00:37] docEbrown: ...so you said I can just type "lugito"? [00:37] No, the characters are not part of the password. [00:37] The password is something like this: foo-bar_baz [00:37] ahh, take the quotes out [00:39] Aha [00:39] Aaaand it's in I think! [00:39] https://paste.ubuntu.com/p/NCFxRR78k2/ [00:39] * docEbrown ;) [00:40] Except segfaults. [00:40] https://paste.ubuntu.com/p/fj9jP7p3MY/ [00:40] really!? [00:41] yup [00:42] hmm [00:43] can you post a pip freeze for me? [00:43] Working on it [00:43] or just try pip install -r requirements.txt [00:43] I may have missed a package out of the setup.py [00:44] So, I blame teward [00:44] Because [00:44] Successfully installed Click-7.0 Flask-1.0.2 Jinja2-2.10 MarkupSafe-1.1.0 Werkzeug-0.14.1 asn1crypto-0.24.0 cffi-1.11.5 cryptography-2.4.1 distro-1.3.0 entrypoints-0.2.3 httplib2-0.11.3 idna-2.7 itsdangerous-1.1.0 jeepney-0.4 keyring-16.1.0 launchpadlib-1.10.6 lazr.restfulclient-0.14.2 lazr.uri-1.0.3 lugito oauthlib-2.1.0 pbr-5.1.1 phabricator-0.7.0 pycparser-2.19 secretstorage-3.1.0 [00:44] setuptools-40.6.2 six-1.11.0 testresources-2.0.1 versioneer-0.18 wadllib-1.3.3 [00:44] Segmentation fault (core dumped) [00:44] :P [00:44] pip freeze gave you a seg fault? [00:44] the heck are you blaming me for now [00:45] Because you did it teward [00:45] did what [00:45] other than drop a nuke on the server [00:45] docEbrown: No, pip3 install -e . [00:45] that is very strange.... [00:46] is this 18.04? [00:46] or 18.10? [00:46] 18.04 [00:46] *tests something on his stationary cruddy desktop* [00:46] is this in a virtualenv? [00:46] s/desktop/workstation/ [00:46] pip3 install keyring [00:46] that works [00:46] docEbrown: no [00:46] *shot* teward [00:47] tsimonq2, whats the requirements.txt content [00:47] ModuleNotFoundError: No module named 'keyring.util.escape' [00:47] teward: uh [00:47] sec [00:47] thats what she said [00:47] *shot* [00:47] * tsimonq2 yeets https://phab.lubuntu.me/source/lugito/ at teward [00:47] do a pip uninstall lugito, pip install -r requirements.txt [00:47] pip install . [00:47] * tsimonq2 throws a banana peel at teward [00:49] tsimonq2, send me test perms to use? [00:50] i'mma test locally to see if I can repro [00:50] or is its data already in the repo [00:52] FIXED IT [00:52] boom! What was it?! [00:53] I blame teward [00:53] pip3 installed local packages that were broken [00:53] Archive versions worked. [00:53] simon sacrificed a goat lol. [00:53] just kidding [00:53] seriously what was it [00:53] -lugito:#lubuntu-devel- [T154: Fix shortcuts related to Super key] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T154#3413 [00:53] tsimonq2, LOL so NOT my fault [00:53] -lugito:#lubuntu-devel- [T169: Python 3.7 Package Migrations] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T169#3408 [00:53] teward: You could have told me LOL [00:53] Reminded me [00:53] were the broken packages in the requirements.txt file? [00:53] -lugito:#lubuntu-devel- [rMANUALa180efc2ebde: Add descrption of qtransmission icon] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALa180efc2ebde [00:53] tsimonq2, thought you needed another reminder of why you asked me to help out with sysadmin ;) [00:53] cc wxl [00:54] -lugito:#lubuntu-devel- [rMANUAL5de8a014c55c: Add icon for lximage] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL5de8a014c55c [00:54] -lugito:#lubuntu-devel- [T154: Fix shortcuts related to Super key] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T154#3410 [00:55] docEbrown: Yeah, but not the fault of the requirements.txt file. [00:55] * Serving Flask app "lugito" (lazy loading) [00:55] 2018-11-20 18:55:19,971 - lugito.connector.IRCConnector - DEBUG - :ChanServ!ChanServ@services. NOTICE lugito :[#lubuntu-devel] Welcome to #lubuntu-devel. This channel is logged. Use of this channel implies acceptance of terms at https://wiki.ubuntu.com/IRC/TermsOfService [00:55] * Environment: production [00:55] -lugito:#lubuntu-devel- [rCALASETTINGS3ac42b4e2555: Write a workaround to fix the support and release notes links on the welcome…] tsimonq2 (Simon Quigley) committed: https://phab.lubuntu.me/rCALASETTINGS3ac42b4e2555 [00:55] WARNING: Do not use the development server in a production environment. [00:55] -lugito:#lubuntu-devel- [rCALASETTINGS48ccf8291f6c: Upload to Disco.] tsimonq2 (Simon Quigley) committed: https://phab.lubuntu.me/rCALASETTINGS48ccf8291f6c [00:55] ok cool [00:56] I'm going to have fingers crossed for a while.... hoping lugito stays up ;) [00:56] *watches it die, then laughs evilly because he caused it* [00:57] -lugito:#lubuntu-devel- [T154: Fix shortcuts related to Super key] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T154#3411 [00:59] * docEbrown sweating ;) [01:00] -lugito:#lubuntu-devel- [rMANUAL15bf2c8415f8: Add 2048-qt icon description] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL15bf2c8415f8 [01:02] -lugito:#lubuntu-devel- [rMANUALab37b6cb9fbd: screenshot.rst] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALab37b6cb9fbd [01:22] Rebuilding ISOs to test the Cala change. [01:31] hey simon does your ISO build script also generate the correspnding files necessary to run the 'mirror' portion of LUbuntu? just curious [01:31] uh wat? [01:33] yeah thought not [01:33] i'll bug xnox [01:33] tomorrow [01:34] @tsimonq2 that was probably the easiest "No idea" in the world :P [01:34] or my brain is failing [01:38] -lugito:#lubuntu-devel- [T75: Lugito doesn't publish new posts] doc-E-brown (Ben Johnston) commented on the task: https://phab.lubuntu.me/T75#3416 [01:40] I appreciate the kind words @kc2bez :) https://community.ubuntu.com/t/ubuntu-community-appreciation-day-2018/8813/6 [01:42] -lugito:#lubuntu-devel- [T75: Lugito doesn't publish new posts] tsimonq2 (Simon Quigley) commented on the task: https://phab.lubuntu.me/T75#3417 [01:43] You are most welcome. You make it easy to give them. It doesn't go unnoticed. [01:44] Thanks :) [02:17] Redious was added by: Redious [02:18] Hi [02:18] Hey! [02:18] Looking to help out or just lurk? [02:19] just lurk , hhh [02:20] Cool :) [02:20] Do you use Lubuntu? [02:20] And if so, what version? [02:21] yes [02:21] @kc2bez apparently I'm late, but I have mounted wuth ect/fstab in /mnt and didn't show, so it should be the mount point not fstab that decide to handled as a removable media or not. [02:21] I am a developer [02:22] C++/Qt Developer and emacs user. [02:22] this is my github: https://github.com/rekols [02:22] Cool :) [02:23] You'll find yourself to be the minority here; wxl and I use Vim. :P [02:23] @hmollercl I think the key is that it needs to be in /media . It will show on the desktop then. [02:23] Anyway, wow, that's an impressive GitHub portfolio [02:24] @kc2bez [ @hmollercl I think the key is that it needs to be in /media . It will s …], I ask him to try that. [02:27] -lugito:#lubuntu-devel- [T154: Fix shortcuts related to Super key] Steedalion (Steed) commented on the task: https://phab.lubuntu.me/T154#3418 [02:27] It doesn't work in 18.10 though. It shows as a device in pcmanfm but not on the desktop. [02:27] -lugito:#lubuntu-devel- [T166: Package update notification] hmollercl (Hans P. Möller) commented on the task: https://phab.lubuntu.me/T166#3419 [02:28] 19.04 qa-test. media keys work perfectly when vlc is active (@ top), but not if other windows are active.. shouldn't they regardless of window being used at the moment pressed? [02:29] @tsimonq2 [You'll find yourself to be the minority here; wxl and I use Vim. :P], emacser and vimer are controversial, hmmm [02:29] @tsimonq2 [You'll find yourself to be the minority here; wxl and I use Vim.] vim all the way ;) [02:30] are you developer? @tsimonq2 [02:31] @Redious [are you developer? @tsimonq2] he is a wunderkind dev! [02:32] wow, he is a year old ? [02:33] no but a very clever cookie [02:37] guiverc What was the other window you had active? [02:39] kc2bez, i'm sure they worked everywhere last x86 test (this is x86_64), term but I tried selecting desktop (ie. wanted none) [02:39] no work on lximage-qt, pcmanfm-qt - appears everywhere but vlc as active (top) [02:41] Ok, I will give it a whirl here too. I was just curious what you had open. [02:45] Same results here in 18.10 [02:50] kc2bez, :( the mute key works everywhere, I'm sure I tested this the same way on other machines yesterday & got different results; maybe I didn't... but thanks [02:51] -lugito:#lubuntu-devel- [rMANUALb64a2a3e3fc5: Add pictures can be scrolled through with the scrollwheel] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALb64a2a3e3fc5 [02:52] does emacs have rst highlighting? [04:36] Can someone look into this? https://askubuntu.com/questions/1093862/lubuntu-brightness-backlight-issue [04:36] guiverc, @HMollerCl, et. al ^ [04:39] -lugito:#lubuntu-devel- [T170: properly launch desktop entries in terminal] tsimonq2 (Simon Quigley) commented on the task: https://phab.lubuntu.me/T170#3420 [04:42] ack. it'll have to be a 'live' image for me to look (i only have 18.10 on desktop) [05:06] -lugito:#lubuntu-devel- [T170: properly launch desktop entries in terminal] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T170#3421 [05:10] @Redious do you work for Wuhan Deepin? [05:14] -lugito:#lubuntu-devel- [T170: properly launch desktop entries in terminal] tsimonq2 (Simon Quigley) commented on the task: https://phab.lubuntu.me/T170#3422 [05:15] -lugito:#lubuntu-devel- [T170: properly launch desktop entries in terminal] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T170#3423 [05:16] Anyone want some low hanging fruit to work on? [05:16] We have two patches that need cherry-picking [05:16] FREE TRAINING PROVIDED FOR ANYONE THAT DOESN"T HAVE THE EXPERIENCE [05:16] Was just about to say that [05:17] We'll walk you through and everything [05:17] Just speak up :) [05:26] Sounds fun. Heading for some zzz's right now. Maybe tomorrow. [05:50] -lugito:#lubuntu-devel- [rMANUALaa3b648783f3: Add delete button to monitor settings] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALaa3b648783f3 [05:52] rajesindia was added by: rajesindia [05:55] Packaging? Low hanging fruit? ME, ME, ME, ME! [05:57] @aptghetto you get it if no other newbies jump on it [05:59] Wish this was at a time I wasn't headed home for a weekend with the fam lol [05:59] Another time [05:59] I woulda helped tbh [06:10] -lugito:#lubuntu-devel- [rMANUALecc6fa834987: Add file saving to qpdfview] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALecc6fa834987 [06:12] tsimonq2: fyi: that askubu link now has an answer (rough one anyway) [06:20] -lugito:#lubuntu-devel- [rMANUAL19c1f5f6e372: Add howto doublespace libreoffice_writer] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL19c1f5f6e372 [06:27] -lugito:#lubuntu-devel- [rMANUAL0e7e105b4ff3: Add missing keyboard shortcut for redo] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL0e7e105b4ff3 [06:33] -lugito:#lubuntu-devel- [T172: software-properties-qt doesn't manually add software sources] wxl (Walter Lapchynski) just created this task: https://phab.lubuntu.me/T172 [07:15] @wxl [ @Redious do you work for Wuhan Deepin?], yes. [08:16] @Redious you folks have your own DE and a good looking one at that! What good is Lubuntu to you? [08:17] hello and welcome @rajesindia ! introduce yourself and tell us about your interest in lubuntu! [09:05] wxl: No problem. ... At the moment I do not have much time, so anyone else will be quicker. But if you have some packaging work to be done, which is not urgent, you can assign it to me. [18:07] so no takers on an easy-breezy packaging task besides @aptghetto ??? he's going to get it unless someone jumps. be happy to train! [18:08] I'll bite [18:08] ok cool [18:08] you done any packaging before? seen the packaing tutorial? [18:09] I've seen the tutorial and the only thing I have done is updates for the manual. [18:09] ok so we'll need to do a few more steps than that [18:10] take a look at the example that's on there and read through it and make sure the logic makes sense [18:10] that's exactly what we're going to do-- pull down some upstream patches [18:14] I think I follow. [18:16] 2 questions. which phab repo and which package? [18:18] ok let me dig it up [18:18] https://phab.lubuntu.me/source/libfm-qt/ and https://phab.lubuntu.me/source/pcmanfm-qt/ [18:18] right but let me get the task which explains the whole deal so you have the context [18:19] https://phab.lubuntu.me/T170 [18:19] the enumerated links are the patches to pull down [18:20] one thing i think i need to fix about the tutorial in case it's not obvious: we're not on cosmic anymore [18:21] disco [18:21] yep [18:22] oh good i didn't hardcode that in there [18:23] It just says CODENAME [18:30] @tsimonq2: i think we need to work out a plan with release notes so that all point releases end up on the same page or are linked to one another somehow [18:39] I want to wish everyone an awesome Thanksgiving to our teammates in the states. Waiting for the bus home. [18:39] wxl not sure where I went wrong. I got "No series file found" after quilt push -a [18:41] @kc2bez debian/patches is empty right? [18:42] no. should it be? [18:43] what does `git branch` tell you? [18:43] ubuntu/disco [18:43] this is libfm-qt? [18:43] yes [18:44] ok and i assume there IS a series file in debian/patches [18:44] that said, it's probably a matter of where you're at [18:44] quilt is particularly sensitive about where in the tree you are [18:44] which is why the tutorial is written exactly the way it is [18:44] you should be in WORKDIR/libfm-qt which has debian in it [18:45] and you have a .quiltrc file in your home directory? [18:45] ahhh good point [18:45] yes all the requirements must be satisified [18:46] that's in the "digging deeper" [18:48] ok let me dig a bit deeper. [18:48] brb [18:49] i dont know if this is the right place, but does anybody else have a bad experience with weblate of lubuntu? [18:49] it's so slow for me, sometimes i can't even log in [18:49] and i can say that my internet works perfectly [18:49] weblate? it's probably because @tsimonq2 keeps breaking it. :) [18:50] lol [18:50] i keep reading those "Jokes" about tsimonq2 [18:50] every joke has a hint of truth in it XD [18:50] lmao [18:51] i've been trying to log into weblate for like an hour [18:53] @teward001 ^^ do you have any insight on these weblate problems? [18:54] WFM [18:54] does that answer the question? [18:54] where're you located xdrup [18:54] xdruppi * [18:54] south america [18:55] wxl: where's this box located? [18:55] ok it finally logged in [18:55] lol [18:56] well I am going to kick it in about an hour for 20 minutes of performance enhancement [18:56] i made a note about that in the admin home yesterday but apparently Simon felt to NOT share the info [18:56] now that my computer is back and operational again that is ^.^ [18:56] FULLY OPERATIONAL WHOOHOO [18:58] i THOUGHT weblate was running on the same server as phab but i could be wrong [18:58] it is [18:58] so i ask again where's that server located [18:59] you mean physically? XD [18:59] ... [18:59] *yes* [18:59] um [18:59] *smacks wxl* [18:59] where's the "let me geoip that for you" button? [19:00] ah looks like it's a digital ocean droplet in nj [19:01] wxl: that button is right behind the 'Destroy Everything" button. [19:02] uhhhhh huh [19:02] sounds like maybe the internet links between US and South America might be being derpy [19:02] but hopefully you aren't still inside Weblate within an hour [19:02] because i'mma kick it briefly then [19:02] now that my computer is back up and usable [19:06] is it running on the same server? i mean i tried logging in with my phab account but I got rejected, many times [19:07] maybe it simply uses different accounts... [19:08] those are different accounts [19:08] my guess is some general connectivity in the backbone [19:08] that sort of thing happens [19:08] alright [19:09] i have never had issues with phab loading... ever. [19:09] except when @tsimonq2 broke the server [19:09] @Wafficus [I want to wish everyone an awesome Thanksgiving to our teammates in the states. …], You too man :) [19:10] @wxl [ @tsimonq2: i think we need to work out a plan with release notes so that a …], Sure [19:10] @teward001 [wxl: where's this box located?], North America :P [19:10] Atlanta [19:10] @tsimonq2: we should document that, too, so we don't mess it up. maybe i'll make a task and we can discuss it further [19:10] @tsimonq2: you sure about that? geoip said nj [19:11] Hmm [19:11] geoip isn't 100% accurate, but still [19:27] does lubuntu include Software Updater? if so, i can't find it [19:27] im just trying to translate from english to spanish, but can't find it on my system [19:28] It doesn't currently but we have a task: https://phab.lubuntu.me/T166 [19:29] I assume it's going to be added, so manual should just stay the way it is. [19:31] I don't see it in the manual currently. [19:31] probably why it should stay the way it is XD [19:32] kc2bez you can't see what? [19:32] anything in the manual to do with software updater [19:32] any mention of software updater [19:33] on appendix D theres quite a few mentions of software updtaer so that someone can upgrade to a new version of ubuntu or simply update packages [19:33] at least, thats what shows up for me to translate [19:34] ok let me take a peek. [19:34] oh yeah, that is valid. That is upgrading from 18.04 to 18.10 [19:35] 18.04 has software updater. [19:35] 18.10 does not. [19:35] alright [19:42] wxl I think I made some progress. Stuck at what my next step should be. quilt push -a worked, I needed .quiltrc [20:39] wow that was a lot of weblate commits [20:56] ^^ no go on lugito [20:56] wxl let me know when you make it back. [21:01] nacl @lc2nez [21:01] wow [21:01] um [21:02] ok [21:02] getting salty i guess [21:02] you figured it out i take it XD [21:02] um stuck at my next step. [21:02] I am not actually making the patch so should I skip a step here. [21:03] well you are [21:03] you're making the patch in our packaging [21:03] so you do want to do `quilt new NAME.patch` [21:03] give it a reasonable name describing briefly what it does [21:03] feel free to be creative :) [21:04] err [21:04] wait [21:04] no that's wrong [21:04] `quilt new 000-WXLISCRAZY.patch` *shot* [21:04] i mean you COULD do that [21:04] (i'm just being annoying to wxl, ignore me) [21:04] but if you have the patch saved somewhere (see the example), `quilt import /path/to/patch` would be better [21:05] ^ this, however you might want to rename the patch afterwards if the patch file's naming is... ambiguous [21:05] just a thought :) [21:05] this --> is_sparta(); should probably not be in your C++ code base [21:14] There are actually 6 patches in debian/patches should I import them all? Sorry for being dense. [21:15] that's what `quilt push -a` does [21:17] @lynorian> this -- [ this --> is_sparta(); should probably not be in your C++ code base], I disagree, that should be the proper way to end threads. [21:27] wxl so quilt refresh next? [21:27] yep [22:11] wxl so I actually messed that up and went back and re did it using the real world example as a guide. I did get some errors out of importing the patch however. [22:20] I have to run for a bit, I will hit you up in about an hour or so. [22:44] kc2bez: when you have the patch import errors up pastebin them so we can see the errors [22:44] it's probably something simple [23:06] I'm sure. Here is the paste https://paste.ubuntu.com/p/b9zG57x3CM/ [23:07] just for kicks, try `quilt import -p1 /path/to/patch` and then see if it works [23:07] might be as simple as needing a tier of stripping added :P [23:07] i've had a few git patches that i've had to add using -p1 as a strip argument [23:08] "Patch fix-launching-desktop-files.patch exists. Replace with -f" should I force it? [23:09] quilt delete fix-launching-desktop-files.patch [23:09] then try and reimport the patch AFTER a `quilt push -a` [23:13] so it actually imports I guess, it is the quilt push after the import that has the errors. Still the same. Must be the patch I created? [23:13] possibly. [23:13] same or different errors this time? [23:13] quilt import always imports quilt push is the test :P [23:14] same errors [23:20] I figured it out I think. I re-created the patch. [23:31] qa-testing - how to view prior test-comments I've written; recent anyway .. doco says to click "See removed and superseded builds too" but blind me can't find it :( [23:43] never mind - found it :) [23:48] Is this a sufficient quilt header? https://paste.ubuntu.com/p/rJ6bZR42Rf/ [23:49] is that 'author' yours or the original patch author? [23:49] original [23:49] if it's not yours, you should use `Origin: upstream, ` if I remember my DEP3 right [23:50] typically you'd use Origin if you snagged it from an upstream patch [23:50] unless wxl or @tsimonq2 are using nonstandard DEP3 stuff [23:51] no we don't use non-standard [23:51] you can delete lines 5-6 [23:51] *shrugs, and goes back to compiling code* [23:51] applied-upstream and origin are a bit interchangable or rather the difference is slight [23:53] So other than 5-6 it is good? [23:54] yeah