[01:51] <mup> PR snapd#6186 opened: interfaces/avahi_observe: Fix typo in comment <Created by Lin-Buo-Ren> <https://github.com/snapcore/snapd/pull/6186>
[06:05] <mborzecki> morning
[07:15] <mup> PR snapd#6187 opened: packaging/fedora: use %_sysctldir macro <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6187>
[07:55] <mborzecki> mvo: hey, we'll have some trouble with github.com/coreos/go-systemd/activation package, the changed the API of activation.Listeners(bool) to activation.Listeners() and the default is different now
[07:56] <mborzecki> mvo: any clue why we didn'g want to have go-systemd unset LISTEN_FDS, LISTEN_PID and LISTEN_FDNAMES ?
[07:59] <mvo> mborzecki: I don't know, maybe chipaca remembers
[08:01] <mborzecki> mvo: hm, from the looks of it, we could drop the activation package, our use case is super simple and could be easily done ourselves without external dep
[08:02] <mborzecki> mvo: and fedora has bumped their pacakge version in f29 and rawhide, soe snapd will not build there anymore without a patch
[08:04] <mvo> mborzecki: right
[08:04] <mborzecki> i'll prep a pr to unblock this
[08:04] <mvo> mborzecki: I'm inclined to just to our own implementation or is there another packaged option out there with a more stable api?
[08:04] <mvo> mborzecki: thank you
[08:06] <pstolowski> mornings
[08:06] <mvo> hey pstolowski - good morning
[08:06] <mborzecki> pstolowski: hey
[08:14] <zyga> Hey
[08:15] <zyga> Will start late, I’m stuck in traffic
[08:15] <mvo> zyga: good morning
[08:15] <zyga> Had a late night :/
[08:16] <mvo> zyga: I have a bit of a conundrum, maybe you have an idea. strace -f snap run test-snapd-tools.echo does not show snap-update-ns in my log, I wonder why
[08:16] <zyga> Please review my PRs if possible
[08:16] <mvo> zyga: yeah, I noticed some reviews were late. what happend, did you got carried away?
[08:16] <mvo> zyga: yeah, will do
[08:17] <zyga> Mvo: is the mount namespace ready? We only call s-u-n once
[08:17] <zyga> Combination of factors, I stopped after 3AM
[08:18] <zyga> Mvo: I merged one branch that had one review and was hanging for days
[08:18] <zyga> The one removing useless unshare
[08:18] <zyga> You asked it
[08:18] <zyga> Acknowledged it
[08:18] <mvo> zyga: I remember this one, iirc I reviewed it
[08:18] <zyga> Still in traffic
[08:19] <zyga> Yep
[08:19] <mvo> zyga: no worries
[08:19] <zyga> Just wanted to make sure you know
[08:27] <mborzecki> mvo: maybe it's because s-u-n goes through fexecve, you can actually see clone() and with -k you see which s-c function is calling it but not much more
[08:28] <mvo> mborzecki: yeah, its slightly annoying, I though internally this all goes through execve into the kernel but apparently not :/
[08:32] <mvo> mborzecki: aha, apparently I can get execveat
[08:33]  * mvo reviews first
[08:33]  * mvo must resist temptation
[08:34] <mborzecki> mvo: hmm looking at glibc, there's a path for execvat and a separate one for that calls execve("/proc/self/fd/<num>",..) where num is the fd
[08:34] <mvo> zyga: 6170 and 6181 were the critical ones?
[08:35] <mvo> mborzecki: interessting
[08:35] <mvo> mborzecki: what I see (just from experimenting) here on 18.10 is execveat
[08:35] <mvo> mborzecki: but maybe it depends on kernel or something?
[08:35] <mborzecki> mvo: https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/fexecve.c;h=3560b711ca2c6d1a61330d91099a3fc2201c583e;hb=HEAD
[08:35] <mborzecki> mvo: yes, kernel and glibc
[08:45] <mvo> mborzecki: nice, thnak you
[08:45] <mborzecki> fedora is the only distro where deps aren't bundled, right?
[08:46] <mvo> mborzecki: debian too
[08:46] <mborzecki> ah
[08:46] <zyga> mvo: in 10 min
[08:48] <mborzecki> mvo: ok, so buster is a problem too then
[08:51] <mvo> mborzecki: the systemd stuff?
[08:51] <mvo> mborzecki: well, breaking api is not nice
[08:51] <mvo> bad people
[08:51] <mborzecki> mvo: yes, buster has v17 version which has the API change
[08:51] <mborzecki> mvo: coreos, move fast, break things, get bought :)
[09:13] <mup> PR snapd#6188 opened: daemon, vendor: bump github.com/coreos/go-systemd/activation, handle API changes <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6188>
[09:17] <zyga> mvo: sorry, now installed and ready for work
[09:17] <zyga> mvo: let me read the backlog now
[09:17] <zyga> mvo: so https://github.com/snapcore/snapd/pull/6170 is the snapd side part of features
[09:17] <mup> PR #6170: overlord,tests: expose enabled features to /var/lib/snapd/features <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6170>
[09:18] <zyga> I think it's not controversial
[09:18] <Chipaca> 𝔊𝔬𝔬𝔡 𝔐𝔬𝔯𝔫𝔦𝔫𝔤
[09:18] <zyga> it's the design gustavo wanted
[09:18] <zyga> holly smokes
[09:18] <zyga> now you must tell me, dir sir Chipaca, how that works
[09:18] <Chipaca> 𝐬𝐧𝐚𝐩 𝐢𝐧𝐬𝐭𝐚𝐥𝐥 𝐮𝐧𝐢𝐟𝐨𝐧𝐭𝐞𝐫
[09:18] <mborzecki> wow
[09:18] <Chipaca> 𝚝𝚑𝚎 𝚛𝚎𝚜𝚝 𝚒𝚜 𝚎𝚊𝚜𝚢
[09:19] <zyga> Chipaca: but technically
[09:19] <zyga> are those just unicode glyphs that have a specific look?
[09:19] <Chipaca> yes
[09:20] <Chipaca> 𝓉𝒽ℯ𝓇ℯ ℯ𝓋ℯ𝓃 𝒾𝓈 ℴ𝓃ℯ 𝓁𝒾𝓀ℯ 𝓉𝒽𝒾𝓈
[09:20] <zyga> mvo: https://github.com/snapcore/snapd/pull/6181 is the second part of that for Go programs
[09:20] <zyga> I wasn't sure where to put it
[09:20] <mup> PR #6181: features: add feature test methods <Per-user mount ns  🐎> <Performance 🚀> <Created by zyga> <https://github.com/snapcore/snapd/pull/6181>
[09:20] <zyga> As in, which package
[09:21] <Chipaca> zyga: in gucharmap, search for 'fraktur' to get to the majority of them
[09:21] <zyga> ahhh
[09:21] <zyga> fraktur, I love it
[09:21] <zyga> thank you :)
[09:21] <Chipaca> usage: unifonter [-h] [-i INPUT] [-o OUTPUT]
[09:21] <Chipaca>                  [-k {b,bc,bf,bi,c,d,f,i,m,s,sb,sbi,si,w}]
[09:21] <Chipaca>                  [text [text ...]]
[09:21] <Chipaca> unifonter: error: argument -k: invalid choice: 'k' (choose from 'b', 'bc', 'bf', 'bi', 'c', 'd', 'f', 'i', 'm', 's', 'sb', 'sbi', 'si', 'w')
[09:21] <Chipaca> augh
[09:21] <zyga> mvo: after writing the features/ PR I wanted to combine the two so that there's a canonical definition of features
[09:21] <Chipaca> (𝔱𝔥𝔦𝔰 𝔦𝔰 𝔣𝔯𝔞𝔨𝔱𝔲𝔯)
[09:21] <zyga> so that coreconfig references the same names, I will do that as a follow-up
[09:22] <Chipaca> (𝖙𝖍𝖎𝖘 𝖎𝖘 *𝖇𝖔𝖑𝖉* 𝖋𝖗𝖆𝖐𝖙𝖚𝖗)
[09:22]  * Chipaca stops having fun and has coffee instead
[09:23] <mvo> zyga: ok, I just finished the first going to the second now
[09:23] <zyga> thank you, looking
[09:23] <zyga> mvo: I will kindly ask you to do more reviews after that - I really want to land this thing
[09:26] <zyga> mborzecki: can you do a quick check on https://github.com/snapcore/snapd/pull/6182
[09:26] <mup> PR #6182: Revert "cmd/snap-confine: don't allow mapping lib{uuid,blkid}" <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/6182>
[09:26] <zyga> this may fix the TW testing PR
[09:27] <mup> PR snapd#6187 closed: packaging/fedora: use %_sysctldir macro <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6187>
[09:28] <zyga> do we need CLA for a typo?
[09:28] <zyga> I guess not
[09:28] <zyga> I'm looking at https://github.com/snapcore/snapd/pull/6186
[09:28] <mup> PR #6186: interfaces/avahi_observe: Fix typo in comment <Simple 😃> <Created by Lin-Buo-Ren> <https://github.com/snapcore/snapd/pull/6186>
[09:29] <mup> PR snapd#6182 closed: Revert "cmd/snap-confine: don't allow mapping lib{uuid,blkid}" <⚠ Critical> <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6182>
[09:35] <zyga> mvo: replied to https://github.com/snapcore/snapd/pull/6170
[09:35] <zyga> let me know if the suggested comment is ok
[09:35] <mup> PR #6170: overlord,tests: expose enabled features to /var/lib/snapd/features <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6170>
[09:36] <zyga> I will update it quickly :)
[09:38] <mvo> zyga: ok, I am at the other one right now
[09:38] <zyga> mvo: if you still have a moment for reviews then please look at https://github.com/snapcore/snapd/pull/6147 next
[09:38] <mup> PR #6147: cmd/snap-confine: use snap-discard-ns ns to discard stale namespaces <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6147>
[09:38] <zyga> I will work on the feedback
[09:42] <mvo> zyga: thanks, replied and added feedback for 6181
[09:42] <zyga> thanks!
[09:42] <mvo> zyga: thanks for your patience
[09:43] <mborzecki> zyga: left some comments in #6170, sorry for the delay, had it opened in a tab a while now, buried among a bunch of other tabs
[09:43] <mup> PR #6170: overlord,tests: expose enabled features to /var/lib/snapd/features <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6170>
[09:43] <mborzecki> wish ff had a way to label/mark tabs, like TODO and so on
[09:44] <zyga> mvo: about the two feature PRs
[09:44] <zyga> shall I merge them together
[09:44] <zyga> or do you want to see a 3rd PR on top
[09:47] <zyga> mvo: I just saw your comment in the PR, I will do a follow up
[09:47] <vidal72[m]> is core snap needed when all installed snaps use core 18?
[09:47] <zyga> so quick pass over the simple feedback and then merge the two and continue
[09:47] <zyga> vidal72[m]: no but some bugs in stable mean that yes
[09:47] <zyga> vidal72[m]: in master this is (I believe) all fixed now
[09:49] <vidal72[m]> zyga: is there a way to remove core snap?
[09:49] <zyga> not at present
[09:49] <vidal72[m]> :(
[09:51] <mvo> https://github.com/snapcore/core/pull/99 <- needs a review from someone from the snapd team
[09:51] <mup> PR core#99: snapcraft: add fc-cache-{6,7} <Created by mvo5> <https://github.com/snapcore/core/pull/99>
[09:56] <zyga> mvo: I had a look last night
[09:56] <zyga> but after midnight I didn't want to comment
[09:56] <zyga> vidal72[m]: is there an issue with that?
[09:57] <zyga> vidal72[m]: eventually the core snap will be phased out
[09:57] <zyga> vidal72[m]: snapd will install and remove required base snaps automatically
[09:58] <zyga> mvo: updated https://github.com/snapcore/snapd/pull/6181 - I think it's good to do now
[09:58] <mup> PR #6181: features: add feature test methods <Per-user mount ns  🐎> <Performance 🚀> <Created by zyga> <https://github.com/snapcore/snapd/pull/6181>
[09:58] <zyga> mvo: if this lands I can merge it into the other PR (snapd side) and remove the duplication there
[10:00] <zyga> why is the core configuration package called configcore and not coreconfig?
[10:04] <mvo> zyga: iirc gustavo liked the name better
[10:06] <mvo> zyga: re 6181> please push the followup once its ready I'm keen to see it playing together and I would love to also land it together
[10:06] <zyga> sure
[10:07] <zyga> uh
[10:08] <zyga> pedronis: replied to your comment on 6181
[10:08] <zyga> pedronis: please let me know if you want to discuss this
[10:10] <Chipaca> mvo: wrt core#99, how's the insecure access thing going to be addressed?
[10:10] <mup> PR core#99: snapcraft: add fc-cache-{6,7} <Created by mvo5> <https://github.com/snapcore/core/pull/99>
[10:10] <mvo> Chipaca: I thought I pushed the fix for this, let me double check
[10:10] <zyga> pedronis: so, can you help me understand please
[10:11] <mvo> Chipaca: uh, silly me
[10:11] <Chipaca> :-)
[10:11] <mvo> Chipaca: now the fix is pushed *cough*
[10:11] <zyga> pedronis: shall I merge 6170 into 6181
[10:11]  * Chipaca sends mvo a 4x-strength green tea
[10:11] <mvo> Chipaca: actually - silly git and silly me to equal parts
[10:11] <zyga> pedronis: and have configcore use the features in one PR
[10:11] <zyga> pedronis: is that what you want?
[10:11] <mvo> Chipaca: heh, great! I need it, didn't sleep well
[10:11] <Chipaca> same
[10:12] <Chipaca> I tweaked my back yesterday again :-(
[10:12] <mvo> Chipaca: :(
[10:13] <Chipaca> mvo: is armhf security also on ports?
[10:13] <mvo> Chipaca: I am pretty sure it is, let me double check
[10:13] <Chipaca> k
[10:14] <mvo> Chipaca: http://ports.ubuntu.com/ubuntu-ports/dists/bionic-security/main/binary-armhf/
[10:14] <Chipaca> \o/
[10:15]  * zyga is unsure what to do about features now
[10:15] <zyga> eh
[10:16] <mvo> zyga: just make a combined PR with 6170, 6181 and the followup that uses features in configcore
[10:16] <zyga> mvo: and the package?
[10:16] <mvo> zyga: I think that the easiest way forward, then we can see the bigger picture
[10:16] <zyga> pedronis didn't want to add a new package but didn't respond to how to structure it
[10:16] <mvo> zyga: not sure, maybe it could be a sub-package of something?
[10:17] <zyga> like?
[10:17] <mvo> zyga: heh, you ask hard questions :)
[10:17] <mvo> zyga: let me look and think
[10:19] <mvo> zyga: I am not sure maybe a sub package of configstate ? otoh it has nothing to do with overlord. but then it fits the oconfig schema. its a bit of an import otoh :/ "overlord/configstate/features"
[10:20] <zyga> mvo: then we need to import that from snap-update-ns
[10:20] <zyga> mvo: I didn't want to do that
[10:21] <mvo> zyga: fair enough, but maybe we can move forward and do the other bits (using feature in corecfg etc) and address this package name/locaiton as the last step?
[10:21] <mvo> zyga: (assuming samuele is ok with this but I guess he will be)
[10:21] <zyga> mvo: yes, I'm working on that now
[10:21] <mvo> zyga: great, thank you
[10:21] <zyga> well, adding test that maciej requested firts
[10:24] <mvo> zyga: +1
[10:26] <mup> PR snapd#6188 closed: daemon, vendor: bump github.com/coreos/go-systemd/activation, handle API changes <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6188>
[10:26] <mborzecki> mvo: left some comments under #6185, really like it
[10:26] <mup> PR #6185: snap: add new `snap run --perf` call <Performance 🚀> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6185>
[10:29] <mvo> mborzecki: thanks, I'm working on tests now
[10:29] <mvo> mborzecki: more
[10:32] <mup> PR snapcraft#2415 opened: tools: pull in imporved cla_check.py from snapd <Created by chipaca> <https://github.com/snapcore/snapcraft/pull/2415>
[10:32] <Chipaca> 'imporved'
[10:33] <Chipaca> 🤦
[10:33]  * Chipaca leaves it
[10:47] <zyga> mvo: I addressed all comments in https://github.com/snapcore/snapd/pull/6170
[10:47] <mup> PR #6170: overlord,tests: expose enabled features to /var/lib/snapd/features <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6170>
[10:47] <zyga> mvo: shall I close https://github.com/snapcore/snapd/pull/6181 now and merge it into 6170?
[10:47] <mup> PR #6181: features: add feature test methods <Per-user mount ns  🐎> <Performance 🚀> <Created by zyga> <https://github.com/snapcore/snapd/pull/6181>
[10:51] <mup> PR snapd#6171 closed: tests: add SPREAD_JOB to the description of systemd_create_and_start_unit <Created by mvo5> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6171>
[10:52] <zyga> mvo: ?
[10:56] <mvo> zyga: sorry, looking
[10:56] <zyga> thanks
[10:59] <mvo> zyga: how about just creating a new branch that combines 6181 and 6170 and build on top of that?
[11:00] <mvo> zyga: we can have a HO if you feel this is all a bit unclear
[11:00] <zyga> no, that's fine
[11:00] <zyga> let me make one
[11:00] <zyga> and the two branches can be closed,
[11:01] <mvo> zyga: yeah or just keep them for reference as they have useful comments and we close once the final one is in - but no strong preferences, if you just refer to them in the new PR thats fine as well of curse
[11:01] <mvo> course
[11:02] <mup> PR snapd#6170 closed: overlord,tests: expose enabled features to /var/lib/snapd/features <Per-user mount ns  🐎> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6170>
[11:02] <mup> PR snapd#6181 closed: features: add feature test methods <Per-user mount ns  🐎> <Performance 🚀> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6181>
[11:02] <zyga> uh :)
[11:02] <zyga> too late
[11:07] <mup> PR snapd#6189 opened: daemon, vendor: bump github.com/coreos/go-systemd/activation, handle API changes (2.36) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6189>
[11:07] <Chipaca> zyga: when you want a break from easy things, #6034 is ready for another look :-p
[11:07] <mup> PR #6034: many: save media info when installing, show it when listing <Created by chipaca> <https://github.com/snapcore/snapd/pull/6034>
[11:07] <zyga> Chipaca: I'll do that after the combination PR
[11:08] <Chipaca> zyga: :-) ok. No rush anyway, but didn't know if you'd seen that I'd pushed it.
[11:14] <mup> PR snapd#6190 opened: overlord/configstate,features: expose features to snapd tools <Created by zyga> <https://github.com/snapcore/snapd/pull/6190>
[11:15] <zyga> mvo: https://github.com/snapcore/snapd/pull/6190
[11:15] <zyga> this is the combination without the duplication
[11:15] <mup> PR #6190: overlord/configstate,features: expose features to snapd tools <Created by zyga> <https://github.com/snapcore/snapd/pull/6190>
[11:15] <pstolowski> mvo: i've proposed a fix for kr/pretty https://github.com/kr/pretty/pull/58 , but the list of PRs there from the period of 2014-2017 is not encouraging :/
[11:15] <mup> PR kr/pretty#58: Fix infinite recursion when diffing structs with cycles <Created by stolowski> <https://github.com/kr/pretty/pull/58>
[11:18] <zyga> Chipaca: looking now
[11:18] <zyga> I re-read my comments to remind myself about that work
[11:21] <mvo> pstolowski: thank you! we can always use a fork if we have to (but it would suck)
[11:22] <pstolowski> mvo: yeah, i'm not sure the fix is 100% correct, the stuff is a bit tricky. for sure it fixes the case i hit in our tests, but i wonder if there are edge cases
[11:22] <pstolowski> mvo: so feedback from the author would be good
[11:30] <zyga> Chipaca: reviewed
[11:32] <Chipaca> zyga: thanks
[11:34] <zyga> mvo: about the features branch, all of the new code is here https://github.com/snapcore/snapd/pull/6190/commits/dddc6d68ee0f492a45b48e61431fa6d9f55e66b3
[11:34] <mup> PR #6190: overlord/configstate,features: expose features to snapd tools <Created by zyga> <https://github.com/snapcore/snapd/pull/6190>
[11:39] <mup> PR snapd#6186 closed: interfaces/avahi_observe: Fix typo in comment <Simple 😃> <Created by Lin-Buo-Ren> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6186>
[11:45] <zyga> mborzecki: ping about https://github.com/snapcore/snapd/pull/6111
[11:45] <mup> PR #6111: packaging/opensuse: move most logic to snapd.mk <Created by zyga> <https://github.com/snapcore/snapd/pull/6111>
[11:46] <zyga> mvo: I don't know if this is the case for sure but perhaps 6110 is failing for the same general reason fedora29 does
[11:46] <zyga> mvo: we never addressed that issue in the end
[12:02] <zyga> mborzecki: I ran ubuntu-core-16-64:tests/regression/lp-1803542 alone and it obviously passed
[12:02] <zyga> I hate our test suite
[12:02] <zyga> it's a constant source of misery
[12:03] <zyga> eh
[12:05] <mup> PR snapcraft#2414 closed: yaml_utils: allow unicode while encoding <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2414>
[12:05] <mup> PR snapd#6179 closed: snap: epoch lists must contain no duplicate entries <Created by chipaca> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6179>
[12:08] <zyga> mvo: snapd update in suse shows some errors
[12:08] <zyga> syntax error in /var/lib/snapd/desktop/applications/test-snapd-policy-app-consumer_test-desktop.desktop, line 1
[12:08] <zyga> the destkop file has no [Foo] section
[12:08] <zyga> is that something we mangle or is that a broken test def? (the snap is from the test suite)
[12:10] <mvo> zyga: no [Foo] section or no [Desktop] section?
[12:11] <zyga> no [Desktop] section
[12:11] <zyga> I will check if the original file has one
[12:11] <mvo> hm, the test snap has one
[12:11] <mvo> so that is odd
[12:11] <zyga> yes
[12:11] <zyga> it has one
[12:11] <zyga> something is borken
[12:13] <mvo> :(
[12:13] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/6147#discussion_r235696283
[12:13] <zyga> what did you mean there?
[12:13] <mup> PR #6147: cmd/snap-confine: use snap-discard-ns ns to discard stale namespaces <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6147>
[12:14] <mup> PR snapcraft#2416 opened: yaml_utils: allow unicode while encoding (#2414) <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2416>
[12:15] <mborzecki> zyga: whether it'd be possible to roll sc_setup_mount_profiles and that call into something generic that runs s-u-n
[12:15] <mborzecki> zyga: or s-d-n
[12:15] <mborzecki> in that case
[12:16] <zyga> one bigger function?
[12:16] <zyga> I'm sorry, I don't follow
[12:18] <mborzecki> zyga: yeah, like run_this_helper_for_snap(fd, snap_name, aa)
[12:19] <zyga> yeah perhaps
[12:19] <zyga> the fork / exec /wait part could be shared
[12:19] <mborzecki> mhm
[12:19] <zyga> the arg handling could stay in each dedicated function
[12:20] <mborzecki> idk, soemthing to think about
[12:20] <mborzecki> although that doesn't strictly follow the rule of 3s :)
[12:22] <zyga> 3s?
[12:23] <mborzecki> zyga: https://erikbern.com/2017/08/29/the-software-engineering-rule-of-3.html
[12:24] <mborzecki> zyga: fwiw there's even a wikipedia page https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming) :)
[12:26] <zyga> ah, cool
[12:27] <zyga> see :)
[12:27] <pedronis> zyga: mvo: to be clear my point was more that it needs to do more, be more the one source of truth/authorative place to merit a top level package, and also that having two authorative places about the different bits of the same things is confusing
[12:28] <mborzecki> selinux makes my head hurt :/
[12:30] <zyga> pedronis: the top-level package was just a quick idea since it has to be imported from snap-update-ns and I didn't want to drag all of configcore with it. I'm open to suggestions on where to place it
[12:30] <zyga> pedronis: the duplication aspect is addressed now
[12:30] <zyga> pedronis: though we don't have one element yet, the default if absent value (what does it mean for that value to be unset)
[12:31] <zyga> but this problem is only specific to snapd internals
[12:31] <zyga> the outside-of-snapd API is unambiguous
[12:32] <niemeyer> Hello there
[12:32] <zyga> hey!
[12:32] <niemeyer> FOlks, we need to rollback or improve that change of "snap info" that is highlighting a channel
[12:32] <zyga> is it breaking parsing of the input?
[12:32] <niemeyer> I would suggest just rolling it back for the time being
[12:33] <niemeyer> At least until we can discuss in more detail the design aspects involved
[12:33] <niemeyer> zyga: Not for me, at least, but it's very misleading
[12:33] <niemeyer> Here is an example from my terminal just now:
[12:33] <niemeyer> channels:
[12:33] <niemeyer>   stable:    2.79b            (20) 129MB classic <
[12:33] <niemeyer>   candidate: ↑
[12:33] <niemeyer>   beta:      ↑
[12:33] <niemeyer>   edge:      2.80-f021536babb (19) 106MB classic
[12:33] <niemeyer> installed:   2.80-f021536babb (19) 106MB classic
[12:34] <niemeyer> That "stable" line stands out from everything else in the output, for no good reason
[12:34] <niemeyer> This is not even my installed version
[12:34] <zyga> mmm, I see - I didn't notice that before
[12:35] <niemeyer> We have the fields tracking, installed, and channel map.. each with different meaning
[12:37] <pedronis> I don't know what that landed, I don't remember that changed being discussed, or reviewing it
[12:38] <pedronis> Chipaca: ^ is that something you did? or somebody else? when did it land?
[12:38] <pstolowski> related to this: https://bugs.launchpad.net/snapd/+bug/1795840
[12:38] <zyga> 40e299154324315957d31eb89823c5267c0d9e85
[12:38] <mup> Bug #1795840: `snap info` highlights the wrong version as installed when `snap try`ing <snapd:New> <https://launchpad.net/bugs/1795840>
[12:38] <zyga> https://github.com/snapcore/snapd/commit/40e299154324315957d31eb89823c5267c0d9e85
[12:39] <Chipaca> pedronis: that's something I did yes
[12:39] <Chipaca> it highlights the current channel
[12:39] <pedronis> Chipaca: mvo: it's 2.36 ?
[12:40] <pedronis> Chipaca: current as in tracking?
[12:41] <Chipaca> yes
[12:41] <pedronis> but not always ?
[12:41] <pedronis> niemeyer said is highlighting not his installed version?
[12:41] <pedronis> or is that because of a switch?
[12:41] <pedronis> anyway is not very self explanatory
[12:42] <Chipaca> there was a request (somewhere) about highlighting current channel and current revision  differently when they differend, i think
[12:42] <niemeyer> Right, it highlights the channel map, although this version is not the current one
[12:42] <Chipaca> either a switch, or an update not run
[12:42] <pedronis> we are trying to pack too much stuff there
[12:42] <pedronis> it's cute
[12:42] <pedronis> but not sure learnable
[12:43] <Chipaca> if you're on core edge, 'snap info core' is the most likely to show a difference between highlighted and current revision
[12:43] <niemeyer> Which doesn't make much sense in that case it seems.. the "arrowing" and highlighting makes it standout more than anything else, even though that channel map entry is not current
[12:44] <pedronis> Chipaca: so it's trying to pack snap refresh --list information into snap info?
[12:44] <Chipaca> no
[12:44] <pedronis> but doesn't really tell?
[12:44] <Chipaca> what
[12:44] <Chipaca> no
[12:45] <pedronis> then I'm very confused
[12:45] <pedronis> that's not good :)
[12:45] <Chipaca> it just highlights the channel you are tracking
[12:45] <Chipaca> that's it
[12:45] <pedronis> wich bit ?
[12:45] <pedronis> the bold and the <
[12:45] <niemeyer> Chipaca: No, it highlights the content of the channel that you are tracking
[12:45] <pedronis> they point at the same thing? or not?
[12:45] <Chipaca> bold and < are always the same right now yes
[12:45] <zyga> niemeyer: ah, so perhaps we could highlight the channel name alone
[12:45] <Chipaca> niemeyer: what
[12:45] <niemeyer> Chipaca: Strawman: how about dropping that arrow and making the highlighting on the channel *name* only
[12:45] <zyga> ha
[12:45] <niemeyer> zyga: ! :)
[12:46]  * zyga is happy to get something aligned for a change
[12:46] <pedronis> niemeyer: Chipaca: yes, that would seem better, it's still a bit unclear how understanble it is
[12:46] <Chipaca> what's the "content of the channel that you are tracking" that isn't "the channel you are tracking"?
[12:46] <niemeyer> Chipaca: and then maybe also highlight the *value* of "installed"
[12:47] <pedronis> maybe
[12:47] <pedronis> I start to think we need to step back
[12:47] <niemeyer> Chipaca: I'm tracking stable, my version is not the one on stable..
[12:47] <pedronis> and pack less in there :)
[12:47] <zyga> name: foo \n installed: v123 from stable but tracking edge
[12:47] <niemeyer> Chipaca: The channel map shows the version that is in stable, not the one I have
[12:47] <niemeyer> Chipaca: Just confusing
[12:47]  * Chipaca was happy for a month
[12:47] <niemeyer> :)
[12:49] <Chipaca> niemeyer: just because you haven't refreshed lately, that does not change the channel map
[12:50] <pedronis> Chipaca: well we are all confused what it means, that's the reality
[12:50] <pedronis> that shows maybe we shouldn't do it
[12:50] <zyga> while on second though I agree it is confusing I must also say I like how it looks like
[12:50] <zyga> the output is long so visual cues like that help to find things
[12:51] <zyga> we just need to make it precise
[12:51] <Chipaca> maybe change the < to <- tracking
[12:51] <Chipaca> ?
[12:51] <zyga> 🛤
[12:51] <Chipaca> zyga: that's undistinguishable from a 💩 at least on xenial terminals
[12:52] <Chipaca> well, maybe not 💩 -- they got that one nice and distinctive
[12:53] <zyga> mvo: http://smackerelofopinion.blogspot.com/2018/11/high-level-tracing-with-bpftrace.html
[12:53] <zyga> mvo: I wanted to read this because, hey, tracing
[12:53] <zyga> maybe useful for snaps
[12:53] <zyga> look at what it says :D
[12:54] <pstolowski> mvo: i'm going to do some bug triaging, hope i'm not getting into your way again (anyone else doing this?)
[12:55] <Chipaca> zyga: :-D
[12:55] <Chipaca> zyga: well, that is cking's blog
[13:03] <mborzecki> off to pick up the kids
[13:25] <pstolowski> zyga: do you know if that exec call error reached any conclusion - https://bugs.launchpad.net/snapd/+bug/1705988 ? i think you were investigating this error at some point but maybe i'm wrong
[13:25] <mup> Bug #1705988: snap install --classic juju fails <canonical-is> <juju:Incomplete> <snapd:New> <snapd (Ubuntu):New> <https://launchpad.net/bugs/1705988>
[13:26] <zyga> pstolowski: no
[13:26] <zyga> pstolowski: I mean, no conclusion
[13:29] <pstolowski> zyga: k thanks
[13:29] <pstolowski> pedronis: related to the snap info, there is also an old enhancement request from Mark https://bugs.launchpad.net/snapd/+bug/1758288
[13:29] <mup> Bug #1758288: 'snap info' should show date of release into channel <snapd:New> <https://launchpad.net/bugs/1758288>
[13:33] <zyga> I see store errors in tests
[13:33] <zyga> timeouts
[13:34] <zyga> break / walk before the call
[13:40] <mvo> zyga: thanks for the ebpf pointer, this looks pretty cool
[13:41] <mvo> pstolowski: no bug triage right now on my side, go wild, and thank you!
[13:44] <mup> PR snapd#6191 opened: cmd/snap: fix missing newline in "snap keys" error message <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6191>
[13:45] <mvo> pstolowski: bug triage already successful :)
[13:45] <pstolowski> :)
[13:47] <mup> PR core#99 closed: snapcraft: add fc-cache-{6,7} <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/core/pull/99>
[13:51] <mup> PR snapd#6192 opened: overlord/snapstate: on refresh, check new rev can read current <Created by chipaca> <https://github.com/snapcore/snapd/pull/6192>
[13:52] <Chipaca> zyga: links to logs for the store timeouts?
[13:56] <zyga> Er, gonsky
[13:57]  * cachio lunch
[14:00] <zyga> ha
[14:00] <zyga> reproduced
[14:00] <zyga> something buggy in test cleanup
[14:02] <zyga> mvo: hangous still buggy
[14:02] <zyga> I clicked join
[14:02] <zyga> see my camera
[14:02] <zyga> and nothing else happens
[14:05] <zyga> trying to join from regular account
[14:05] <zyga> same
[14:05] <zyga> eh
[14:08] <zyga> mvo: restarted browser, logged out
[14:08] <zyga> no change
[14:09] <zyga> how do I join from the phone?
[14:13] <niemeyer> Chipaca: Re. "niemeyer: just because you haven't refreshed lately, that does not change the channel map".. exactly.. the point is that the *channel map* is now highlighting a *version* and other details like "classic", etc, and it's very unclear why. It certainly doesn't feel like the reason why is "because you are tracking that channel and will eventually get that version, probably".
[14:17] <mup> PR snapd#6178 closed: snap,snap-exec: add SNAP_DEBUG_START_TIME environment <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/6178>
[14:18] <zyga> pstolowski: oh, that missing newline
[14:18] <zyga> it was in the TW branch
[14:18] <zyga> forgot to push it separately
[14:18] <zyga> thanks for doing that!
[14:25] <mup> PR snapd#6193 opened: spread: drop Fedora 27, add Fedora 29 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6193>
[14:25] <sergiusens> niemeyer: hi there, I would appreciate your opinion on https://forum.snapcraft.io/t/title-length-in-snapcraft-yaml-snap-yaml/8625 given that it seems we have no well defined length for the "title" field.
[14:26] <sergiusens> I think the Gnome Software screenshots there could be used as a guideline on what we want that value to be
[14:27] <niemeyer> sergiusens: Will discuss here and provide some feedback there, thanks for the pointer
[14:28] <sergiusens> thanks!
[14:38] <zyga> https://github.com/snapcore/snapd/pull/6190 is green :)
[14:38] <mup> PR #6190: overlord/configstate,features: expose features to snapd tools <Created by zyga> <https://github.com/snapcore/snapd/pull/6190>
[14:38] <zyga> pstolowski: found a bug :)
[14:38] <zyga> 942 127 0:3 mnt:[4026532154] /run/snapd/ns/failing-config-hooks.mnt rw - nsfs nsfs rw
[14:39] <zyga> I bet that when the config hook fails
[14:39] <zyga> we don't cleanup after the snap :)
[14:39] <zyga> I'll look at fixing that
[14:40] <pstolowski> zyga: great, this is with relation to what?
[14:42] <Son_Goku> zyga, https://forum.snapcraft.io/t/issue-with-repackaged-core-and-testing/8394/9
[14:42] <Son_Goku> niemeyer, mborzecki, mvo: golang is moving back to Fedora EPEL
[14:43] <zyga> pstolowski: the bug I just mentioned in the call
[14:43] <zyga> Son_Goku: hey
[14:43] <zyga> Son_Goku: do you have a sec for a call?
[14:43] <zyga> Son_Goku: not urgent, just want to explain what that issue is about
[14:43] <Son_Goku> sure
[14:43] <pstolowski> zyga: ah, that one about finding leftovers
[14:43] <Son_Goku> I do now
[14:44] <mborzecki> Son_Goku: do you know if there's any immediate action needed for 7.6?
[14:44] <Son_Goku> niemeyer, mborzecki, mvo: https://pagure.io/releng/issue/7919
[14:44] <Son_Goku> mborzecki, not yet
[14:44] <zyga> Son_Goku: https://meet.google.com/exu-zttk-ynz?authuser=0
[14:47] <pstolowski> zyga: can you ack https://github.com/snapcore/snapd/pull/6191 ?
[14:47] <mup> PR #6191: cmd/snap: fix missing newline in "snap keys" error message <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6191>
[14:49] <niemeyer> Son_Goku: Nice!
[14:49] <niemeyer> sergiusens: Responded
[14:59] <Chipaca> FTR: diff-highlight rocks
[15:11] <zyga> pstolowski: looking
[15:11] <pstolowski> zyga: go +2, thanks
[15:11] <pstolowski> *got
[15:26] <pedronis> zyga: I asked some question in the features PR
[15:26] <pedronis> questions
[15:26] <pedronis> I am a bit confused
[15:27] <pedronis> about things that are not experimental anymore
[15:27] <pedronis> and how the various bits should work for them
[15:27] <pedronis> they don't seem consistent atm
[15:44]  * cachio lunch
[15:48] <roadmr> if a snap uses a tar.gz as its source, and I want it to build via build.snapcraft.io, can I create a github repo with just the snap/snapcraft.yaml file whose source: points to the tar.gz upstream?
[15:51] <Chipaca> roadmr: aren't most of them that?
[15:51] <Chipaca> bah
[15:51] <Chipaca> change 'tar.gz' to 'github repo' and it's the majority of snapcrafters, afaik
[15:51] <Chipaca> roadmr: e.g. https://github.com/snapcrafters/offlineimap
[15:51] <Chipaca> (first one i clicked on)
[15:52] <roadmr> Chipaca: but that's the thing - I don't want to change 'tar.gz' to 'github repo'
[15:52] <roadmr> I specifically want to use the tar.gz because that lets me use the make plugin; the github repo requires some auto* evil I don't have time to wrestle right now
[15:52] <zyga> pedronis: thanks, I'll look
[15:53] <zyga> pedronis: we kept the experimental prefix for layouts for example
[15:53] <zyga> pedronis: but open to suggestions
[15:54] <Chipaca> roadmr: AIUI source: <url to tar.gz> should work (maybe needs source-type:)
[15:54] <Chipaca> roadmr: source-type: tar
[15:54] <roadmr> Chipaca: right; that looks like it'll work. I can fiddle with things from here :) thanks
[15:55] <Chipaca> roadmr: https://github.com/snapcrafters/postman does that
[15:55] <roadmr> thanks for tracking down an example, Chipaca !
[15:55] <Chipaca> np
[15:59] <mup> PR snapd#6194 opened: snap: make description maximum in runes, not bytes <Created by chipaca> <https://github.com/snapcore/snapd/pull/6194>
[16:00] <zyga> Network issues
[16:01] <pedronis> zyga: I think the code doesn't behave correctly where things that were experimental but now default to on
[16:01] <zyga> Mvo, pedronis I’m trying to answer from my laptop
[16:01] <zyga> I agree, I will fix that
[16:01] <pedronis> zyga: maybe we should have a quick HO today or tomorrow on thhis
[16:02] <Chipaca> giggle
[16:03] <pedronis> zyga: it seems we need files that mean negative for those, or we need run that Ensure were early in snapd, but we can't assume snapd will run before snaps
[16:03] <niemeyer> Chipaca: That reflects very well the state of my brain right now :)
[16:06] <zyga> re
[16:06] <zyga> reconnected
[16:08] <zyga> pedronis: gladly
[16:09] <zyga> pedronis: hopefully my network will behave
[16:09] <zyga> I have plenty of data left, just fiddled with the modem box
[16:10] <pedronis> zyga: we can chat now
[16:11] <zyga> HO or here on IRC?
[16:11] <zyga> maybe meet, ho didn't work for me
[16:11] <pedronis> meet is ok, but let me see if I can find a room for me here
[16:13] <pedronis> zyga: I found a room (hopefully)
[16:18] <Saviq> cachio: do you have 1910 images available for spread yet?
[16:29] <mup> PR snapd#6195 opened: snapstate: update fontconfig caches on install <Created by mvo5> <https://github.com/snapcore/snapd/pull/6195>
[16:30] <mvo> pedronis: ^- is probaly something you want to look at, its very simplistic right now, your input would be welcome what direction to take
[16:30] <mvo> pedronis: but no rush
[16:32] <pedronis> mvo: thx, I'll try to look at it today or tomorrow
[16:33] <mup> PR snapd#6196 opened: Validate title <Created by chipaca> <https://github.com/snapcore/snapd/pull/6196>
[16:35] <Chipaca> sergiusens: ^ title validation as per forum topic
[16:36] <Chipaca> fwiw, fyi, tanstaaomb, etc
[16:36] <sergiusens> 👍
[16:36] <sergiusens> adding tests here as well
[16:39] <zyga> Heading home
[16:42] <mup> PR snapcraft#2415 closed: tools: pull in imporved cla_check.py from snapd <Created by chipaca> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2415>
[16:42] <sergiusens> Chipaca: https://github.com/snapcore/snapcraft/pull/2412
[16:42] <mup> PR snapcraft#2412: schema: add support for title <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2412>
[16:43] <mup> PR snapd#6197 opened: tests/lib: sync cla check back from snapcraft <Created by chipaca> <https://github.com/snapcore/snapd/pull/6197>
[16:50] <mup> PR snapd#6198 opened: Revert "cmd/snap, tests/main/snap-info: highlight the current channel" <Created by chipaca> <https://github.com/snapcore/snapd/pull/6198>
[16:53] <mup> PR snapd#6199 opened: Revert "cmd/snap, tests/main/snap-info: highlight the current channel" (2.36) <Created by chipaca> <https://github.com/snapcore/snapd/pull/6199>
[16:57] <Chipaca> mvo: is that's what needed for 2.36 ^?
[17:31] <mup> PR snapd#6191 closed: cmd/snap: fix missing newline in "snap keys" error message <Simple 😃> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6191>
[17:47] <zyga> re
[17:47] <zyga> arrived home
[17:50] <mvo> Chipaca: I think so
[17:52] <zyga> hey mvo
[17:52] <zyga> how's stuff?
[17:53] <mvo> zyga: good, good - how are you?
[17:53] <zyga> mvo: how's the experiment
[17:55] <mvo> zyga: the fc-cache work? a super simple version is up for review
[17:57] <zyga> oh
[17:57] <zyga> looking
[17:57] <zyga> just unpacking
[17:58] <zyga> found it
[18:09] <zyga> mvo: is that all?
[18:09] <zyga> feels like a file is missing
[18:09] <zyga> ah, link.go
[18:10] <mvo> zyga: well, its the most simple approach I could think of
[18:10] <mvo> zyga: and that means something ;)
[18:10] <zyga> review sent
[18:15] <mvo> ta
[20:42] <zyga> Zzzz
[20:44] <mwhudson> how do snapd tests test refresh?
[20:44] <mwhudson> do you have a fake store or something?
[20:44] <mwhudson> s/tests/integration tests/
[20:46] <cachio> mwhudson, hi, there are many tests for refreshes
[20:47] <cachio> some of them use the fake store
[20:47] <cachio> others no
[20:47] <cachio> we test core refresh and snaps refreshes
[20:47] <cachio> mwhudson, what do you need?
[20:48] <mwhudson> cachio: well i'm just wondering how you arrange for snap refresh to do something
[20:48] <mwhudson> cachio: as that requires the store to have a new revision of a snap
[20:48] <mwhudson> in my understanding anyway
[20:48] <cachio> mwhudson, for that we use the fake store
[20:48] <mwhudson> (context here is that i am working on a subiquity feature to offer an upgrade to a new version)
[20:48] <mwhudson> cachio: is the fake store something i could run locally?
[20:49] <cachio> mwhudson, yes
[20:49] <mwhudson> cachio: is it documented? :)
[20:49] <cachio> there are some tests on snapd which show that
[20:49] <mwhudson> or at least, can you tell me where to find it
[20:49] <mwhudson> is it in the snapd tree?
[20:50] <cachio> tests/main/refresh/task.yaml
[20:50] <cachio> in the snapd project
[20:50] <mwhudson> ok
[20:50] <mwhudson> i can start from there thanks :)
[20:50] <cachio> basically it sets up a fake store which is configured with the snaps to refresh
[20:51] <cachio> mwhudson, perhaps you should see first the refresh-all test
[20:51] <cachio> tests/main/refresh-all/task.yaml
[20:52] <cachio> it is much simpler
[20:53] <mwhudson> is fakestore in test-snapd-tools ?
[20:54] <mup> PR snapcraft#2416 closed: yaml_utils: allow unicode while encoding (#2414) <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2416>
[20:54] <mwhudson> ah no
[20:54] <cachio> no
[20:55] <mwhudson> its in the snapd tree i see
[20:55] <mwhudson> oops gotta run for a call
[20:55] <cachio> test-snapd-tools is the snap to refresh
[20:55] <mwhudson> cachio: thanks for the pointers so far
[21:04] <cachio> mwhudson, np
[21:04] <cachio> yaw
[21:20] <mup> PR snapd#6200 opened: tests: fix for tests test-*-cgroup <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6200>