| AuroraAvenue | Hello Can someon tell me what the snap is called for this snap ? https://uappexplorer.com/snap/ubuntu/tor | 02:13 |
|---|---|---|
| AuroraAvenue | Or how I get on tor on Solus OS ? | 02:13 |
| AuroraAvenue | And why is sabdfl on this channel tonite? Is he usually here ? | 02:16 |
| AuroraAvenue | robert_ancell ping | 02:18 |
| robert_ancell | AuroraAvenue, hello | 02:18 |
| AuroraAvenue | Hiya - hows the far-east these days ? Anyway I waned to ask how to gt this on my Solus OS i.e. what is the snap called ? https://uappexplorer.com/snap/ubuntu/tor | 02:19 |
| robert_ancell | AuroraAvenue, I think it's just called 'tor' (https://snapcraft.io/tor) | 02:19 |
| AuroraAvenue | is that the client or what ? | 02:20 |
| robert_ancell | I don't know any more than what it says in the description | 02:20 |
| AuroraAvenue | because it says 'client' on that wesite. | 02:20 |
| AuroraAvenue | robert_ancell, I need help - who do I ask here ? Who knows snaps thats in the US ? | 02:21 |
| robert_ancell | Not sure who's online now | 02:21 |
| AuroraAvenue | Well hows NZ anyways ? | 02:21 |
| robert_ancell | Nice any sunny today | 02:21 |
| robert_ancell | and | 02:22 |
| AuroraAvenue | cool stuff - sorry to bother you. | 02:22 |
| robert_ancell | np | 02:22 |
| AuroraAvenue | elopio, ping (maybe) | 02:23 |
| AuroraAvenue | oh wait - it is that one. https://paste.ubuntu.com/p/8xCc8SDYmV/ | 02:28 |
| AuroraAvenue | Wit x2 there is no client | 02:31 |
| AuroraAvenue | **Wait | 02:31 |
| AuroraAvenue | damn it. | 02:31 |
| AuroraAvenue | http://pasteall.org/pic/aa8ff4298c2c6315886afe1e236c8662 | 02:31 |
| AuroraAvenue | there is no client. | 02:32 |
| AuroraAvenue | no Tor client anyway - no GUI ! | 02:32 |
| AuroraAvenue | feel lied to by Ubuntu again. | 02:32 |
| AuroraAvenue | grumbles. | 02:32 |
| mborzecki | morning | 06:05 |
| dot-tobias | morning | 07:28 |
| === pstolowski|afk is now known as pstolowski | ||
| pstolowski | mornings | 08:04 |
| mborzecki | pstolowski: mvo: Chipaca: morning guys | 08:05 |
| mvo | hey pstolowski and mborzecki and zyga | 08:10 |
| mvo | Chipaca: and good morning to you as well | 08:10 |
| dot-tobias | morning everyone | 08:12 |
| mborzecki | anyone objects to moving sanity check mount point to /run/snapd instead of /tmp? | 08:15 |
| mborzecki | eg. /run/snapd/sanity-<num> | 08:15 |
| mvo | mborzecki: that sounds fine | 08:17 |
| mborzecki | mvo: from selinux perspective it'd probably be cleaner if we had a helper to check the mounts :/ | 08:17 |
| mborzecki | otherwise we're handing out permissions to snapd, and they don't feel enough fine grained | 08:18 |
| zyga | hey mvo | 08:23 |
| zyga | sorry for starting late, I needed to catch up sleep after the night before | 08:23 |
| zyga | but all set | 08:23 |
| zyga | mvo: I had a call with pedronis yesterday, we discussed all that's needed to get feature's exported | 08:24 |
| zyga | I'll attack that now :) | 08:24 |
| mvo | zyga: awesome | 08:24 |
| mvo | zyga: I'm ready for reviews for those | 08:25 |
| zyga | mvo: I summarized that on the PR - though in abbreviated form | 08:25 |
| zyga | let me know if you want to know more | 08:25 |
| zyga | but I think this is a very good design and we will be able to learn from that | 08:25 |
| zyga | in case we need to export more stuff like I wanted with facts originally | 08:25 |
| zyga | (facts will have the same properties) | 08:25 |
| mvo | cool | 08:27 |
| zyga | I think I found the cause of the bug I saw last night | 09:22 |
| zyga | tl;dr; broken cleanup | 09:22 |
| mborzecki | zyga: on fedora https://paste.ubuntu.com/p/8nYxtc2nHh/ | 09:31 |
| zyga | mmm, mount unit with selinux context? | 09:31 |
| mborzecki | yes | 09:32 |
| mborzecki | zyga: it gets more interesting https://paste.ubuntu.com/p/bRk8qdcrpM/ | 09:35 |
| zyga | mborzecki: https://github.com/snapcore/snapd/pull/6201 | 09:53 |
| mup | PR snapd#6201 opened: tests: remove test-snapd-with-configure on restore <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6201> | 09:53 |
| mup | PR #6201: tests: remove test-snapd-with-configure on restore <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6201> | 09:53 |
| zyga | I need a 2nd review on https://github.com/snapcore/snapd/pull/6159 | 09:54 |
| mborzecki | zyga: discarding ns in snap-mgmt would fix that too i think | 09:54 |
| mup | PR #6159: cmd/snap-confine: handle mounted shared /run/snapd/ns <Created by zyga> <https://github.com/snapcore/snapd/pull/6159> | 09:55 |
| zyga | we do that but the test breaks the assumptions | 09:55 |
| zyga | it removes the snap "by hand" | 09:55 |
| zyga | I really think we should go over all tests | 09:55 |
| zyga | and over the prep/restore logic for all system | 09:55 |
| zyga | and get rid of hacks | 09:55 |
| zyga | time saved in one test is lost by time wasted debugging lots of random failures | 09:56 |
| mvo | zyga: could we discard all namespaces in restore? | 09:57 |
| zyga | mvo: do you know my position on prepare/restore? | 09:59 |
| zyga | it's all broken and backwards | 09:59 |
| zyga | pre restore in prepare | 09:59 |
| zyga | and do nothing in restore | 09:59 |
| zyga | we don't discard namespaces on core, looking at the maze that our restore logic is | 10:00 |
| zyga | s/pre restore/we restore/ | 10:00 |
| zyga | restore_suite_each is { true } | 10:00 |
| zyga | prepare_suite_each is calling reset.sh with a --reuse-core | 10:01 |
| zyga | mvo: if you are asking if we could do this better then the answer is yes | 10:01 |
| mborzecki | zyga: #6201 should probably go to 2.36 | 10:02 |
| mup | PR #6201: tests: remove test-snapd-with-configure on restore <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6201> | 10:02 |
| zyga | mborzecki: as in for stable update? won't hurt I suppose | 10:03 |
| mborzecki | zyga: can you take a look at the build log in https://github.com/snapcore/snapd/pull/6189 ? | 10:04 |
| mup | PR #6189: daemon, vendor: bump github.com/coreos/go-systemd/activation, handle API changes (2.36) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6189> | 10:04 |
| zyga | mvo: I'm happy to make parepare/restore measureably better at some point | 10:04 |
| zyga | mborzecki: sure | 10:04 |
| zyga | build log or task failures? | 10:04 |
| mvo | zyga: ok | 10:04 |
| mborzecki | task failure | 10:04 |
| zyga | mborzecki: I saw that myself once | 10:05 |
| zyga | mborzecki: not 100% sure but I suspect it's a bug in how we prepare against the snapd in edge | 10:05 |
| zyga | is this branch based on older master? | 10:05 |
| zyga | mborzecki: after we removed quirks | 10:05 |
| mborzecki | it's 2.36 + a backport of some commits unrelated to what's failing | 10:05 |
| zyga | this bug started to show up on branches | 10:05 |
| zyga | that were using old master (before quirk removal) | 10:05 |
| zyga | mborzecki: it looks like we are taking snap-confine apparmor profile | 10:06 |
| zyga | from edge | 10:06 |
| zyga | where it has fewer permissions | 10:06 |
| zyga | I didn't debug it further though | 10:06 |
| zyga | perhaps after the repackaging magic | 10:06 |
| zyga | after snapd has ran and loaded the per-core-rev snap-confine profile | 10:06 |
| zyga | it doesn't do that again | 10:06 |
| zyga | and we run with profile from edge with code from master | 10:07 |
| zyga | er | 10:07 |
| zyga | not from master, from the branch being tested | 10:07 |
| zyga | and the branch being tested needs more permissions | 10:07 |
| zyga | I suspect if you run this with debug | 10:07 |
| zyga | and inspect the on disk per-revision profile | 10:07 |
| mborzecki | zyga: funny thing is, there's nothing in dmesg about denials, idk if it's surpressed or sth | 10:07 |
| zyga | you will not see the quirks permissions anymore | 10:07 |
| zyga | but that branch surely needs them since it is 2.36 | 10:08 |
| zyga | mborzecki: yes, they are supressed | 10:08 |
| zyga | they easily get rate limited-lost | 10:08 |
| mborzecki | maybe we should use audit instead | 10:08 |
| mborzecki | configure auditd with a reasoanble buffer | 10:08 |
| zyga | dunno | 10:08 |
| zyga | I use audit on suse because dmesg doesn't have denial messages | 10:08 |
| mborzecki | (actually have a change like this for fedora/centos) | 10:08 |
| mborzecki | yeah, afaik once auditd is urnning denials go there | 10:09 |
| zyga | mborzecki: if you debug this I'd love to know where the mistake is | 10:09 |
| zyga | is it in snapd | 10:09 |
| zyga | or is it in the repackaging magic | 10:09 |
| zyga | mvo: I double checked, we remove each snap in prepare | 10:16 |
| zyga | mvo: except bases | 10:16 |
| zyga | mvo: which we collect and remove at the end | 10:17 |
| zyga | mborzecki: https://botland.com.pl/pl/raspberry-pi-hat-komunikacja/10602-pi-top-laptop-modulowy-raspberry-pi-3-model-b-v2.html | 10:38 |
| zyga | :D | 10:38 |
| zyga | pi3 laptop for 446zł net | 10:38 |
| zyga | maybe ;D | 10:38 |
| zyga | would be nice for debugging pi issues without having to worry about screen/keyboard as always? | 10:38 |
| mborzecki | heh :) | 10:38 |
| mborzecki | zyga: i'm more into this https://botland.com.pl/pl/microbit-zestawy-edukacyjne/8574-microbit-go-bbc-modul-edukacyjny-cortex-m0-akcelerometr-bluetooth-led-5x5-akcesoria.html | 10:39 |
| zyga | 95zł! | 10:39 |
| zyga | not sure | 10:39 |
| zyga | what for, for kids? | 10:39 |
| mborzecki | yeah | 10:39 |
| mborzecki | have various stm32f{0,1,3} boards around but too complicated to give those to the kids | 10:40 |
| zyga | yeah | 10:41 |
| zyga | well | 10:41 |
| zyga | either your kids speak englisb | 10:42 |
| zyga | or the bbc micro has nice localized material to follow | 10:42 |
| zyga | not sure if worth the money TBH | 10:42 |
| pstolowski | ic Chipaca off today? | 10:44 |
| zyga | not sure | 10:47 |
| zyga | haven't seen him though | 10:47 |
| zyga | pstolowski: ^ what do you think about pi-top deal above? | 10:48 |
| pstolowski | zyga: oh wow, interesting! but i'd rather pick regular rpi3 | 10:50 |
| zyga | pstolowski: pi is inside :) | 10:51 |
| zyga | it's just a hat on top a regular pi | 10:51 |
| zyga | (you can also upgrade the pi eventually though given what the foundation has said I think pi3 is the end of the current line) | 10:51 |
| pstolowski | zyga: i know i know, but pi3 will be 3x cheaper (although, the price for this thing is very good - if that's what you want) | 10:51 |
| zyga | yeah :-) | 10:52 |
| zyga | convenience for having pi with screen/keyboard/power and less cables and fuss to worry about | 10:52 |
| Chipaca | pstolowski: not away, but not 100% here yet | 10:59 |
| mup | PR snapd#6202 opened: tests: restore in restore, not in prepare <Created by zyga> <https://github.com/snapcore/snapd/pull/6202> | 11:07 |
| zyga | brb, cold, making hot tea | 11:08 |
| mup | PR snapd#6201 closed: tests: remove test-snapd-with-configure on restore <Simple 😃> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6201> | 11:35 |
| Chipaca | snap run test-snapd-xdg-autostart.foo | 11:35 |
| Chipaca | cannot create temporary directory for /var/lib/snapd mount point: Permission denied | 11:35 |
| Chipaca | zyga: ^ is that interesting to you? | 11:35 |
| zyga | nah, why would it be :) | 11:35 |
| zyga | Chipaca: this is the same as mborzecki noticed earlier today | 11:35 |
| pstolowski | mborzecki: didn't you look at https://bugs.launchpad.net/snapd/+bug/1775340 ? | 11:35 |
| zyga | let me find that | 11:35 |
| mup | Bug #1775340: Make snapd zsh aware <snapd:Triaged> <https://launchpad.net/bugs/1775340> | 11:35 |
| zyga | Chipaca: https://pastebin.ubuntu.com/p/rmcTXPjYfx/ | 11:36 |
| zyga | Chipaca: it's a bug in our prepare restore as far as I know | 11:36 |
| zyga | Chipaca: but not 100% sure as I didn't debug further | 11:36 |
| pstolowski | Chipaca: did https://bugs.launchpad.net/snapd/+bug/1801955 land in 2.36.1 already? | 11:36 |
| mup | Bug #1801955: snapshot fails if unknown user in /home <snapd:In Progress by chipaca> <https://launchpad.net/bugs/1801955> | 11:37 |
| zyga | Chipaca: is this also on 2.36 -based branch? | 11:37 |
| * Chipaca hugs pstolowski for doing this bug thing | 11:37 | |
| Chipaca | zyga: yes | 11:37 |
| zyga | Chipaca: so very likely the same issue | 11:37 |
| pstolowski | Chipaca: you will hate me by eod ;) | 11:37 |
| zyga | Chipaca: if you cannot fix it in 30 mintues I can look, just trying to wrap up this thing that spawned into a chain of other things | 11:38 |
| Chipaca | pstolowski: nope | 11:38 |
| * Chipaca EODs | 11:38 | |
| zyga | Chipaca: (pawel will assign all open bugs to you ;) | 11:38 |
| zyga | ha | 11:38 |
| zyga | hahaha | 11:38 |
| zyga | :D | 11:38 |
| pstolowski | lol | 11:38 |
| pstolowski | Chipaca: also, any conclusion re that macaroon thing? | 11:39 |
| Chipaca | pstolowski: $ git tag --contains d062f3f2d2a529b0d329df7f0f2c2713d0927af9 | 11:39 |
| Chipaca | pstolowski: nothing | 11:39 |
| Chipaca | pstolowski: so, no, not in 2.36.1 | 11:39 |
| pstolowski | Chipaca: k, thanks | 11:39 |
| Chipaca | pstolowski: re that macaroon, IIRC (but it was long ago so), we couldn't reproduce it back then either | 11:40 |
| zyga | have I mentioned that shell sucks today? | 11:40 |
| zyga | message of the day: shell sucks | 11:40 |
| zyga | there | 11:40 |
| zyga | now I feel better | 11:40 |
| zyga | for n in *.dupa; do echo $n; done | 11:41 |
| Chipaca | zyga: echo "shell sucks." > ~/.motd | 11:41 |
| zyga | why the hell did people did this | 11:41 |
| zyga | why why why | 11:41 |
| zyga | it's so insane | 11:41 |
| Chipaca | zyga: ? | 11:41 |
| pstolowski | Chipaca: ok, interesting :). closing then | 11:41 |
| zyga | Chipaca: run that | 11:41 |
| zyga | did you expect *.dupa | 11:41 |
| zyga | (sorry about the name) | 11:41 |
| Chipaca | yes | 11:41 |
| * zyga hugs chipaca | 11:41 | |
| Chipaca | ¯\_(ツ)_/¯ | 11:42 |
| zyga | I know this happens but every time I write some more code and hit this I hate myself | 11:42 |
| Chipaca | zyga: stop writing that sort of code then | 11:42 |
| Chipaca | zyga: find -name \*.dupa ftw | 11:42 |
| zyga | that's not the same meaning :) | 11:42 |
| zyga | but yeah | 11:42 |
| Chipaca | zyga: -maxdepth 1 | 11:42 |
| zyga | shell is suuuucky | 11:42 |
| zyga | see | 11:42 |
| Chipaca | zyga: -also-i-don't-want-dotfiles | 11:43 |
| Chipaca | zyga: -dwim | 11:43 |
| Chipaca | zyga: -dwimnwis | 11:43 |
| Chipaca | zyga: -just-work-already | 11:43 |
| * Chipaca stops | 11:43 | |
| zyga | Chipaca: git grep -E 'for [[:alpha:]]+ in .+[*].*' | 11:46 |
| mvo | Chipaca: heh | 11:46 |
| zyga | we are all guilty of that :) | 11:46 |
| * mvo hugs zyga and Chipaca | 11:46 | |
| * zyga goes to fix it | 11:46 | |
| zyga | eh | 11:46 |
| mvo | Chipaca: I remember a long time ago when I was teaching people unix and find - oh boy | 11:47 |
| mvo | find is really not that easy to explain at least to beginners | 11:47 |
| Chipaca | find: warning: you have specified the -maxdepth option after a non-option argument -name, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it). Please specify options before other arguments. | 11:47 |
| Chipaca | that's the point where you duck, as your students hurl their computers at you | 11:47 |
| zyga | Chipaca: this is like python range(0) returning ["range(0)"] because FU that's why | 11:50 |
| zyga | and people coding around it with isinstance(int) | 11:50 |
| zyga | eh :) | 11:50 |
| * zyga feels better by removing this from the tree | 11:51 | |
| Chipaca | well | 11:51 |
| Chipaca | what | 11:51 |
| Chipaca | no it doesn't | 11:51 |
| mvo | Chipaca: haha - yes | 11:51 |
| zyga | right? | 11:51 |
| zyga | because it's sane | 11:51 |
| zyga | and shell is insane | 11:51 |
| Chipaca | zyga: no really range(0) does not return ["range(0)"] | 11:51 |
| Chipaca | and, in python, range objects have len, so if you need to know before looping you can | 11:52 |
| zyga | Chipaca: I know, I meant that this is equally crazy to a hypothetical python behavior where range(0) returning ["range(0)"] | 11:52 |
| Chipaca | ah | 11:52 |
| Chipaca | oh | 11:52 |
| Chipaca | wait i have a gif for this | 11:52 |
| Chipaca | http://i.imgur.com/NU3KE.gif | 11:52 |
| tomwardill | that is a good gif | 11:59 |
| pstolowski | Chipaca: I suppose this is fixed in snapd? https://bugs.launchpad.net/snapd/+bug/1751447 | 12:03 |
| mup | Bug #1751447: snapstore and review-tools use the wrong regexp for snap names <Canonical Click Reviewers tools:Fix Released by chipaca> <review-tools:Fix | 12:03 |
| mup | Released by jdstrand> <Snapcraft:Fix Released by chipaca> <snapd:In Progress by chipaca> <Snap Store:Fix Released> <https://launchpad.net/bugs/1751447> | 12:03 |
| zyga | Chipaca: shellcheck doesn't like loops over for | 12:04 |
| zyga | recommends while read loop | 12:04 |
| zyga | *sigh* | 12:04 |
| zyga | https://github.com/koalaman/shellcheck/wiki/SC2044 | 12:06 |
| zyga | and the solution doesn't works in sh | 12:06 |
| zyga | heh | 12:06 |
| * zyga just stops | 12:07 | |
| Chipaca | zyga: what | 12:07 |
| Chipaca | pstolowski: yes, that's fixed | 12:07 |
| Chipaca | fix-released even | 12:07 |
| pstolowski | Chipaca yep, thanks | 12:08 |
| Chipaca | zyga: which is the for loop it doesn't like? | 12:08 |
| pstolowski | zyga: can you quickly assess https://bugs.launchpad.net/snapd/+bug/1803210 ? | 12:08 |
| mup | Bug #1803210: snap's device cgroup is not discarded upon uninstall <snapd:New> <https://launchpad.net/bugs/1803210> | 12:08 |
| zyga | pstolowski: true | 12:08 |
| zyga | pstolowski: ancient | 12:08 |
| zyga | Chipaca: I converted one for loop to find and ran shellcheck | 12:08 |
| pstolowski | zyga: hm, it's from 2 weeks ago? | 12:09 |
| zyga | pstolowski: the behavior is true since snapd v1 | 12:09 |
| zyga | we never ever did anything about those | 12:09 |
| pstolowski | zyga: ah, in that sense | 12:09 |
| pstolowski | zyga: confirm+low? | 12:10 |
| zyga | no idea what the priority is | 12:10 |
| zyga | but confirmed | 12:10 |
| pstolowski | fair enough | 12:10 |
| pstolowski | thx | 12:10 |
| pstolowski | if it's since forever and nothing exploded, it looks low/medium to me | 12:11 |
| zyga | yeah | 12:11 |
| Chipaca | zyga: can you show me? | 12:12 |
| zyga | https://www.irccloud.com/pastebin/YtRQUGYI/ | 12:12 |
| zyga | Chipaca: patch in https://github.com/snapcore/snapd/pull/6203 | 12:12 |
| mup | PR #6203: tests: discard mount namespaces in reset.sh <Created by zyga> <https://github.com/snapcore/snapd/pull/6203> | 12:12 |
| zyga | Chipaca: at this rate I'm closer to saying that perl is better | 12:13 |
| Chipaca | zyga: that 'cannot create temporary directory for /var/lib/snapd mount' thing, is it expected to just go away or do i need to do something? | 12:13 |
| Chipaca | getting it repeatedly | 12:13 |
| mup | PR snapd#6203 opened: tests: discard mount namespaces in reset.sh <Created by zyga> <https://github.com/snapcore/snapd/pull/6203> | 12:13 |
| zyga | Chipaca: you need to do something | 12:13 |
| zyga | it's a bug in our test code or in snapd | 12:13 |
| zyga | snap-confine profile in edge is more restrictive | 12:13 |
| Chipaca | zyga: so it isn't that it doesn't like for loops, it doesn't like for loops over find | 12:13 |
| Chipaca | i agree with it on this :-) | 12:14 |
| Chipaca | zyga: what's the body of the loop? | 12:14 |
| zyga | repackaging for tests and all the other jazz we do should make the profile from the branch (more permissive) active | 12:14 |
| zyga | but it seems we missed something and it's not working for real | 12:14 |
| zyga | snap-confine profile changes that remove permissions are rare so we didn't observe this before | 12:14 |
| zyga | Chipaca: loop is https://github.com/snapcore/snapd/pull/6203/commits/0e13a3077f4318091e05f90005c8f970461087c3 | 12:14 |
| mup | PR #6203: tests: discard mount namespaces in reset.sh <Created by zyga> <https://github.com/snapcore/snapd/pull/6203> | 12:14 |
| zyga | I know about -exec and stuff | 12:15 |
| zyga | just feels like I shouldn't have to | 12:15 |
| Chipaca | zyga: try find .... | while read | 12:15 |
| Chipaca | see what shellcheck thinks of that | 12:15 |
| zyga | the wiki has a comprehensive list of solutions | 12:15 |
| zyga | look at that please | 12:15 |
| zyga | they all turn a one liner into a body of code | 12:16 |
| mup | PR snapd#6204 opened: daemon: remove enableInternalInterfaceActions <Created by zyga> <https://github.com/snapcore/snapd/pull/6204> | 12:21 |
| zyga | pstolowski: ^ | 12:26 |
| pstolowski | zyga: wow, interesting, i've never stumbled on it | 12:27 |
| Chipaca | zyga: wrt while, the read solution is correct, but while read < <( find ) is a bashism; find | while read would work everywhere | 12:33 |
| Chipaca | zyga: wrt enableInternalInterestingInsects, maybe it's time to run 'unused' again | 12:33 |
| zyga | Chipaca: mmm | 12:34 |
| zyga | +1 | 12:34 |
| Chipaca | it says makeHttpClient is unused | 12:34 |
| Chipaca | etc etc | 12:34 |
| zyga | burn with fire | 12:34 |
| zyga | Chipaca: also, would you be ok with splitting api.go | 12:34 |
| zyga | api_debug.go api_interfaces.go | 12:34 |
| Chipaca | zyga: i already have | 12:35 |
| zyga | ... | 12:35 |
| zyga | oh, perfect | 12:35 |
| Chipaca | zyga: api_snapshots | 12:35 |
| zyga | so can be done on a drive-throuh basis? | 12:35 |
| zyga | cool, didn't notice | 12:35 |
| zyga | api.go makes vim unhappy :) | 12:35 |
| Chipaca | i don't agree with vim a lot, but i'm with it on this | 12:35 |
| Chipaca | or as it would put it, beep beep angry flash beep delete half the text | 12:36 |
| * zyga loves the look of https://github.com/pkg/errors | 12:36 | |
| zyga | mvo: ^ | 12:36 |
| zyga | back to crufty stuff | 12:36 |
| zyga | eh | 12:36 |
| zyga | obviously | 12:36 |
| zyga | I ran a test that failed in https://github.com/snapcore/snapd/pull/6202 and it passed | 12:36 |
| mup | PR #6202: tests: restore in restore, not in prepare <Created by zyga> <https://github.com/snapcore/snapd/pull/6202> | 12:36 |
| zyga | because some other test broke the state | 12:36 |
| zyga | gosh I hate this test suite today | 12:37 |
| * pstolowski lunches | 12:37 | |
| Chipaca | whoa, ineffective break statement | 12:57 |
| mvo | zyga: interessting, I read that after lunch | 13:04 |
| mup | PR snapd#6205 opened: many: staticcheck fixes <Created by chipaca> <https://github.com/snapcore/snapd/pull/6205> | 13:22 |
| Chipaca | ^ a couple of serious ones in there | 13:23 |
| Chipaca | (most are arguably innocuous) | 13:23 |
| zyga | Chipaca: in similar vein https://github.com/snapcore/snapd/pull/6206 | 13:44 |
| mup | PR #6206: many: fix composite literals with unkeyed fields <Created by zyga> <https://github.com/snapcore/snapd/pull/6206> | 13:44 |
| zyga | Chipaca: many vet fixes | 13:44 |
| zyga | Chipaca: oh, I see you fixed the same bug :) | 13:44 |
| Chipaca | zyga: https://github.com/dominikh/go-tools/tree/master/cmd/keyify | 13:44 |
| mup | PR snapd#6206 opened: many: fix composite literals with unkeyed fields <Created by zyga> <https://github.com/snapcore/snapd/pull/6206> | 13:44 |
| mup | PR snapd#6207 opened: mkversion: use "test -n" rather than "! test -z" <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6207> | 13:45 |
| mup | PR snapd#6208 opened: run-checks: assorted fixes <Created by zyga> <https://github.com/snapcore/snapd/pull/6208> | 13:47 |
| zyga | mmm | 13:48 |
| zyga | nice | 13:48 |
| zyga | I wish I'd known :) | 13:48 |
| mup | PR snapd#6209 opened: run-checks: discard test good/bad banner <Created by zyga> <https://github.com/snapcore/snapd/pull/6209> | 13:48 |
| zyga | sorry for the noise | 13:50 |
| zyga | slowly unwinding the stack of stuff | 13:50 |
| mup | PR snapd#6210 opened: many: run go fmt ./ <Created by zyga> <https://github.com/snapcore/snapd/pull/6210> | 13:50 |
| Chipaca | of course a freshly pulled staticcheck breaks with 1.6 :-( | 13:51 |
| Chipaca | BOO | 13:51 |
| zyga | Chipaca: https://github.com/snapcore/snapd/pull/6205/commits/02af5cde6a8fdb86c1ee08979ca195c8fa37c367 | 13:54 |
| zyga | should all of those have a type? | 13:54 |
| mup | PR #6205: many: staticcheck fixes <Created by chipaca> <https://github.com/snapcore/snapd/pull/6205> | 13:54 |
| mup | PR snapd#6202 closed: tests: restore in restore, not in prepare <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6202> | 13:54 |
| Chipaca | zyga: i tried, but then it kinda explodes | 13:58 |
| Chipaca | (give it a try locally you'll see what i mean) | 13:58 |
| zyga | mhm | 13:58 |
| Chipaca | all those foo == opBAR checks would need an operator(foo) == opBAR | 13:59 |
| Chipaca | which seems silly | 13:59 |
| Chipaca | there's no real type safety to be had | 13:59 |
| zyga | mvo, Chipaca: can you eyeball https://github.com/snapcore/snapd/pull/6203 | 14:00 |
| zyga | this is the blocker for my unwind stack | 14:00 |
| mup | PR #6203: tests: discard mount namespaces in reset.sh <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6203> | 14:00 |
| zyga | and standup time | 14:00 |
| Chipaca | zyga: no sorry i have a meeting with these guys | 14:00 |
| zyga | and chrome still sucks | 14:00 |
| zyga | man | 14:01 |
| Chipaca | pedronis: we're assuming you can't make it today | 14:02 |
| pstolowski | mborzecki: didn't you look at https://bugs.launchpad.net/snapd/+bug/1775340 ? | 14:04 |
| mup | Bug #1775340: Make snapd zsh aware <snapd:Triaged> <https://launchpad.net/bugs/1775340> | 14:04 |
| mborzecki | pstolowski: briefly, the problem is still there | 14:07 |
| pstolowski | mborzecki: k, thanks | 14:08 |
| mborzecki | pstolowski: (at least on ubuntu) | 14:08 |
| zyga | Chipaca: https://github.com/snapcore/snapd/pull/6210 makes me sad, means that we cannot go fmt and expect to land things | 14:23 |
| mup | PR #6210: many: run go fmt ./ <Created by zyga> <https://github.com/snapcore/snapd/pull/6210> | 14:23 |
| Chipaca | zyga: stop using 1.11 :-) | 14:23 |
| zyga | Chipaca: I'll take that 2.36 bug now | 14:28 |
| Chipaca | zyga: you are made of rocks | 14:28 |
| zyga | mborzecki: still hoping for that https://github.com/snapcore/snapd/pull/6111 :D | 14:29 |
| mup | PR #6111: packaging/opensuse: move most logic to snapd.mk <Created by zyga> <https://github.com/snapcore/snapd/pull/6111> | 14:29 |
| zyga | trying to close cards if I can | 14:30 |
| mborzecki | on it | 14:30 |
| zyga | thanks | 14:30 |
| zyga | consider it agreed that the rpm logic will move back to spec file | 14:30 |
| zyga | and snapd.mk will include a control file that has variable defs | 14:30 |
| zyga | Chipaca, pstolowski: can you please review https://github.com/snapcore/snapd/pull/6203 | 14:32 |
| mup | PR #6203: tests: discard mount namespaces in reset.sh <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6203> | 14:32 |
| zyga | it's simple and blocks other fixes from landing | 14:32 |
| Chipaca | zyga: doesn't that have the "for foo in *.blah" problem? | 14:33 |
| zyga | it does | 14:33 |
| Chipaca | i guess the || true and the f on the rm fixes those | 14:33 |
| zyga | it doesn't explode though | 14:33 |
| zyga | || is for unmount being not needed | 14:33 |
| zyga | it's not strictly for the *.shit | 14:33 |
| zyga | I'm happy to do a pass specifically to use a less broken idiom | 14:33 |
| zyga | but I need to pop the stack to get to 0 at some point | 14:34 |
| Chipaca | zyga: monday | 14:34 |
| zyga | question is wich Monday ;) | 14:34 |
| Chipaca | zyga: one that ends in a k | 14:35 |
| zyga | pstolowski: trivial fix in https://github.com/snapcore/snapd/pull/6177 | 14:41 |
| mup | PR #6177: interfaces: draft of LimeSDR hotplug interface <Hotplug 🔌> <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6177> | 14:41 |
| zyga | now really fixing 2.36 | 14:42 |
| pstolowski | zyga: uh oh, thanks. | 14:42 |
| pstolowski | zyga: +1 to reset ns PR, with 1 suggestion | 14:43 |
| zyga | thanks looking | 14:43 |
| zyga | Chipaca: can you make sense of this: | 14:46 |
| zyga | https://www.irccloud.com/pastebin/JyNfmgcG/ | 14:47 |
| zyga | is it because version has no "git" in it? | 14:47 |
| zyga | nah, git is optional | 14:47 |
| zyga | tracking edge vs stable! | 14:47 |
| zyga | eh :/ | 14:47 |
| zyga | but .. why? | 14:48 |
| zyga | another prepare/restore woe | 14:48 |
| Chipaca | zyga: isn't that what you're changing? edge to stable for 2.36? | 14:48 |
| * Chipaca doesn't know | 14:48 | |
| zyga | Chipaca: no, it was a random failure | 14:48 |
| Chipaca | lel | 14:48 |
| Chipaca | zyga: look for a store error in logs? | 14:48 |
| zyga | thanks | 14:48 |
| mvo | zyga: I have a look, in a meeting right now | 14:50 |
| Chipaca | ok peeps, i'm wrapping up for the day. Mostly. Will be back online once I'm at the mothership. | 15:04 |
| Chipaca | have a lovely weekend if I don't see you before you EOW, and see you Monday! | 15:04 |
| pstolowski | mvo: do we want a dedicated client error type of dns errors (would affect gnome software i suppose)? | 15:53 |
| pstolowski | s/of/for/ | 15:53 |
| zyga | re | 15:53 |
| zyga | back from walk and dinner | 15:54 |
| zyga | man it's so cold and dark already | 15:54 |
| zyga | it's barely 5PM | 15:54 |
| roadmr | zyga: northern winter heh | 15:55 |
| zyga | it's not even winter yet | 15:56 |
| zyga | I got a new pair of gloves that should work for cold days | 15:56 |
| zyga | old gloves were thin and light but not much warm | 15:56 |
| zyga | man, I don't miss winter :? | 15:56 |
| zyga | :/ | 15:56 |
| roadmr | zyga: crappy gloves are better than no gloves heh | 15:57 |
| mvo | pstolowski: I think we want this, for the impact of a decidcated client error for dns error on gnome-software robert-ancil will know | 15:57 |
| mvo | zyga: back, anything I miseed? had a bunch of meetings | 15:57 |
| zyga | trying to reproduce the 2.36 branch issue | 15:57 |
| zyga | no success | 15:57 |
| pstolowski | mvo: ack, thanks | 15:57 |
| zyga | so it's not only a bug but also a test affecting it | 15:57 |
| zyga | somehow the test suite hates me and throws logs everywhere I go, it seems :) | 15:58 |
| zyga | mvo: does this ring any bells? https://www.irccloud.com/pastebin/H8FyPMX5/ | 15:59 |
| mvo | zyga: it does not | 16:08 |
| zyga | hmm, thanks | 16:08 |
| mvo | zyga: config leftover maybe? | 16:08 |
| zyga | mvo: given that prepare/restore landed | 16:08 |
| mvo | zyga: maybe the timer test ran before the schedule test or something | 16:08 |
| zyga | I can start attacking test cleanup issues | 16:09 |
| cachio | zyga, I can contribute testing this change | 16:21 |
| zyga | cachio: thank you! | 16:21 |
| zyga | cachio: I think we will find things misbehaving but now, with restore being done, we can start to put code that checks pre-prepare and post-restore state | 16:22 |
| zyga | last time I looked we leaked processes, packages and some files (though I bet we fixed many of those over time) | 16:22 |
| cachio | perfect | 16:22 |
| cachio | zyga, I'll start now | 16:23 |
| cachio | I'll send you what I found | 16:24 |
| zyga | thank you! | 16:24 |
| cachio | also I want to test that change on dvices | 16:24 |
| zyga | mvo: still no luck with 2.36 issue, cannot reproduce it | 16:35 |
| zyga | cachio: https://github.com/snapcore/snapd/pull/6208 needs a second review, perhaps you could have a look | 16:37 |
| mup | PR #6208: run-checks: assorted fixes <Created by zyga> <https://github.com/snapcore/snapd/pull/6208> | 16:37 |
| zyga | oh | 16:37 |
| zyga | mvo just posted one :) | 16:37 |
| zyga | but still useful | 16:37 |
| cachio | zyga, sura | 16:37 |
| cachio | sure | 16:37 |
| zyga | mvo: if you are on a spree: https://github.com/snapcore/snapd/pull/6207 | 16:37 |
| mup | PR #6207: mkversion: use "test -n" rather than "! test -z" <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6207> | 16:37 |
| zyga | haha | 16:37 |
| zyga | you did | 16:37 |
| zyga | man I should just shut up and look :) | 16:37 |
| mup | PR snapd#6207 closed: mkversion: use "test -n" rather than "! test -z" <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6207> | 16:37 |
| mup | PR snapd#6208 closed: run-checks: assorted fixes <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6208> | 16:37 |
| cachio | zyga, it is merged :) | 16:38 |
| mvo | zyga: heh, yeah, was looking at reviews | 16:39 |
| mvo | zyga: nice stuff | 16:39 |
| zyga | the completion tests are failing more than usual | 16:40 |
| mup | PR snapd#6204 closed: daemon: remove enableInternalInterfaceActions <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6204> | 16:43 |
| zyga | mvo: can you please review https://github.com/snapcore/snapd/pull/6159 | 16:45 |
| mup | PR #6159: cmd/snap-confine: handle mounted shared /run/snapd/ns <Created by zyga> <https://github.com/snapcore/snapd/pull/6159> | 16:45 |
| zyga | once the fix for the stray mount namespace is merged this can also go in | 16:46 |
| zyga | and unblock features | 16:46 |
| mup | PR snapd#6198 closed: Revert "cmd/snap, tests/main/snap-info: highlight the current channel" <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6198> | 16:48 |
| mup | PR snapd#6197 closed: tests/lib: sync cla check back from snapcraft <Created by chipaca> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6197> | 16:51 |
| === pstolowski is now known as pstolowski|afk | ||
| mup | PR snapd#6210 closed: many: run go fmt ./ <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6210> | 17:03 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/6196#discussion_r235994155 | 17:08 |
| mup | PR #6196: many: validate title <Created by chipaca> <https://github.com/snapcore/snapd/pull/6196> | 17:08 |
| mup | PR snapd#6203 closed: tests: discard mount namespaces in reset.sh <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6203> | 18:49 |
| * cachio afk | 19:09 | |
| * zyga fights spread | 19:13 | |
| zyga | though I should EOD | 19:13 |
| zyga | let's :) | 19:13 |
| * zyga EODs | 19:13 | |
| cachio | zyga, good weekend | 20:25 |
| cachio | I'm over the completion errors now | 20:26 |
| === JanC_ is now known as JanC | ||
| zyga | :-) | 20:29 |
| zyga | thank you | 20:29 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
