| didrocks | hey cjwatson! jibel and I have a question on ubuntu-cdimage: as with the new layered images we are building, we might not know in advance the squashfs, size, manifest files. We want to avoid to hardcode more filenames that already exists. In livefs.py, there are basically 2 code paths to download assets. One is using LP API (and so, can list all artefacts attached to a specific build) and the other | 10:10 |
|---|---|---|
| didrocks | one is just for filesystem + http:// download. We thought to match against regexp, which works in the LP case and for filesystem (via os.listdir()). However, tests are failing as they are using http mock server. I wonder if in production, only the LP path is took. If so, can we just detect "http" for tests and either create a manifest that we download or rely on hardcoded filenames? | 10:10 |
| cjwatson | As far as I know it's only ever the LP path in production, indeed | 10:12 |
| didrocks | so, do you think special casing tests, like not using the regexp for them, is fine? | 10:12 |
| cjwatson | Yeah, I think so | 10:13 |
| didrocks | perfect! Thanks a lot cjwatson :) | 10:13 |
| cjwatson | The http:// case may even be legacy - not sure | 10:13 |
| didrocks | yeah, sounds like it, but we preferred asking you directly :) | 10:13 |
| cjwatson | Obviously for good software engineering reasons keeping special cases for tests to a minimum is a good idea, but creating a sort of meta-manifest doesn't seem unreasonable, maybe with a fallback if it doesn't exist | 10:13 |
| didrocks | yeah, the best would be ofc to rewrite the tests to mock LP | 10:14 |
| didrocks | but I think that's out of our current scope :) | 10:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!