acheronuk | cyphermox jibel et al. does this MP need a changelog entry from me? https://code.launchpad.net/~rikmills/ubiquity/+git/ubiquity/+merge/359785 | 13:55 |
---|---|---|
acheronuk | if so, I'm not sure if to put it in my name or not considering it's a cherry-pick of someone elses commit from a ubiquity fork | 13:56 |
cyphermox | acheronuk: yes please | 14:06 |
cyphermox | you can put your name in the changelog, and say that the patch is from whomever | 14:07 |
cyphermox | I wonder how the hell this isn't a bug in Qt though :) | 14:08 |
acheronuk | it's slightly over my head | 14:09 |
cyphermox | acheronuk: well, just seems to me that if it wants argv, fine, but it should also be fine if that's completely empty | 14:11 |
cyphermox | ie. who cares, you can just start an application that doesn't have any arguments | 14:11 |
cyphermox | *shrugs* | 14:11 |
acheronuk | cyphermox: https://paste.ubuntu.com/p/B95hVVqXb2/ | 14:14 |
* acheronuk shrugs also | 14:14 | |
cyphermox | heh | 14:15 |
cyphermox | fix is simple, this will obviously work | 14:15 |
cyphermox | it's just IMO not very nice to absolutely require a parameter when it could be omitted safely | 14:16 |
acheronuk | cyphermox: changelog added. I mentioned it was from Neon fork, but not the commit ref (716f0ce6). I can amend that if you really want it. | 14:21 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!