| brainwash | bluesabre: I noticed that the bug text for bug 1795135 describes one thing, but the report is now used for another thing | 16:49 |
|---|---|---|
| ubottu | bug 1795135 in X.Org X server "XFCE window buttons are not clickable at the top of the screen" [Medium,Confirmed] https://launchpad.net/bugs/1795135 | 16:49 |
| brainwash | it was originally filed against Greybird | 16:51 |
| brainwash | and ochosi has fixed something in the panel code and greybird css | 16:51 |
| brainwash | however, this is not tracked by the report | 16:51 |
| brainwash | https://bugzilla.xfce.org/show_bug.cgi?id=14729 | 16:55 |
| ubottu | bugzilla.xfce.org bug 14729 in Window Buttons "Buttons do not respond to click" [Normal,Resolved: fixed] | 16:55 |
| brainwash | so, I think we need a copy of that launchpad report, and adjust the text of the existing one to match the tracked bug | 16:58 |
| === MrTulias_ is now known as MrTulias | ||
| ochosi | brainwash: actually it's all pretty well described in the commit: https://git.xfce.org/xfce/xfce4-panel/commit/?id=e56e869 | 21:20 |
| ochosi | but agreed, this one also helped: https://git.xfce.org/xfce/xfce4-panel/commit/?id=52d4c333269452a03a0f1f8c527861b5cd21792d | 21:20 |
| ochosi | and this is the related greybird commit: https://github.com/shimmerproject/Greybird/commit/0904216995f1108f517b98432000fb70a021932d | 21:21 |
| brainwash | ochosi: you agree that a separate report is needed? or should everything be tracked in one report? | 21:24 |
| ochosi | the main question for me is: what is the point of the report | 21:24 |
| ochosi | is it to do an SRU? | 21:25 |
| brainwash | unlikely | 21:25 |
| ochosi | tracking the issue itself is probably not that relevant if we don't want to SRU this, because it has been fixed already and will be gone with the 19.04 release | 21:25 |
| ochosi | so i don't have a strong opinion if we want to track this issue in multiple reports that are all "fix committed" or just in one umbrella-report | 21:26 |
| brainwash | ochosi: I'll wait to see what bluesabre says about this | 21:34 |
| ochosi | sure | 21:35 |
| brainwash | it's his report after all :) | 21:35 |
| === brainwash_ is now known as brainwash | ||
| bluesabre | Hello! | 22:33 |
| bluesabre | It's something that should be SRU'd... If we ship a panel on top layout, the experience shouldn't bite | 22:35 |
| ochosi | it's actually only two commits, the cosmetic panel one could be omitted | 22:36 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!