/srv/irclogs.ubuntu.com/2018/12/04/#snappy.txt

mborzeckimorning06:05
zygagood morning :)06:13
zygamborzecki: I pushed missing patches from master into https://github.com/snapcore/snapd/pull/623506:14
mupPR #6235: overlord,apparmor: new syskey behaviour + non-ignored snap-confine profile errors (2.36) <Created by zyga> <https://github.com/snapcore/snapd/pull/6235>06:14
zygathe reference is https://github.com/snapcore/snapd/pull/623306:14
mupPR #6233: overlord: don't write system key if security setup fails <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6233>06:14
mborzeckioh, and it's green now06:14
zygathere are a few extra lines of diff06:14
zygabecause that branch combines another small patch from master06:15
zyganamely https://github.com/snapcore/snapd/pull/6235/commits/cbc6e3e029e36e2d120a3dbb2edad39f689da47906:15
mupPR #6235: overlord,apparmor: new syskey behaviour + non-ignored snap-confine profile errors (2.36) <Created by zyga> <https://github.com/snapcore/snapd/pull/6235>06:15
zygaI think it's good to go :)06:15
zygamborzecki: I think we can merge https://github.com/snapcore/snapd/pull/624806:19
mupPR #6248: tests/lib/reset: restore context of removed snapd directories <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6248>06:19
mupPR snapd#6248 closed: tests/lib/reset: restore context of removed snapd directories <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6248>06:20
zygaa pair of simple looking conflicts on https://github.com/snapcore/snapd/pull/623806:21
mupPR #6238: [RFC] many: add minimal SELinux support, refactor the policy <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6238>06:21
zygamborzecki: did you pick that keyboard? :)06:22
mborzeckizyga: no, not yet06:22
zygamborzecki: pawel has apparently moved his work onto the new machine06:23
zygaexpectedly, because it's the quietest and fastest machine he has now06:23
zygaI'm curious if you will experiment with vmware as well :)06:23
mupPR snapd#6256 closed: snap: add new `snap run --trace-exec` call (2.36) <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6256>06:24
zygamborzecki: I resolved conflicts on https://github.com/snapcore/snapd/pull/6193/files06:34
mupPR #6193: spread: drop Fedora 27, add Fedora 29 <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6193>06:34
zygathough I made F29 manual so this can land06:34
zygait should pass with just F2806:34
zygaQuick school run06:52
zygaRe07:28
mupPR snapd#6258 opened: WIP: interfaces: support D-Bus activation <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/6258>07:50
zygaand back now07:58
zygajamesh: hey :)07:58
jameshhi zyga07:58
zygaI will try to review all branches this week07:59
zygabut we have a backlog and limited capacity07:59
jameshzyga: no problem.  I'm still working on the dbus activation one: the PR is more for CI feedback08:00
jamesh(that's why I marked it WIP)08:00
* zyga loves to see :: targets used in makefiles08:00
=== pstolowski|afk is now known as pstolowski
pstolowskimornings08:06
mborzeckipstolowski: hey08:08
zygahey pawel :)08:11
zygahttps://github.com/snapcore/snapd/pull/6257 is green08:22
mupPR #6257: testutils: split checkers, tweak tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6257>08:22
zygaand very long :-)08:22
zyganvidia physix is BSD now08:24
zygathat's impressive08:24
zygawonder if nvidia will have a change of strategy for their other software08:24
zygamborzecki: hey08:25
zygamborzecki: I think we should do something about that snapd.mk PR08:25
mborzeckidid that land?08:26
zygaI would like to resurrect it, make minimal modifications as discussed (move variable generation back to .spec file and have snapd.mk include vars.mk)08:26
zygaand land it08:26
zygalooking at the PR from james, there will be new files, new things to look at08:26
zygauh oh08:28
zygaThe job exceeded the maximum log length, and has been terminated.08:28
zygatravis now kills jobs that log too much08:28
zygaperhaps we should tweak spread to log less stuff08:28
zygaand definitely make rpm builds quieter08:28
mborzeckizyga: yeah, 2.36 branch is failing atm because of this i think08:29
zygaone other thing I would silence is the package name selection08:30
zygathat is, mapping from ubuntu names to other names08:30
mborzeckizyga: or sort of, something else fails, but travis terminates the job :)08:30
zygathat's extremely verbose08:30
mborzeckiset +too-much-gibberish-x08:30
zygatrying some simple changes to reduce the log size now08:50
zygamborzecki: do you know if it is possible to query the state of "set" settings?08:54
mborzeckizyga: snap get ?08:55
mborzeckisnap get -d08:55
zygano no08:55
zygaI mean in shell08:55
zygaset -x vs set +x08:55
mborzeckiaah08:55
zygathere's nothing I can find quickly08:55
mborzeckizyga: set -o should do the trick08:59
zygaah, neat, thanks!08:59
mborzeckizyga: xtrace is apparently the option09:00
zygayes09:00
mborzeckiand even supported by zsh :)09:00
zygaquick patch for reduced verbosity https://www.irccloud.com/pastebin/o15U1EqK/09:02
mupPR snapd#6259 opened: tests: reduce verbosity around package installation <Simple 😃> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/6259>09:06
zygamborzecki, pstolowski: ^09:06
pstolowskiok09:07
zygamborzecki: do you want to discuss the connections API?09:08
zygajust looking at some random part of trace log09:08
zygaI would love to have09:08
zygasnap debug is-connected09:08
zygasnap debug connected-slots SNAP:PLUG09:08
zygasnap debug connected-plugs SNAP:SLOT09:08
zygasnap debug connecte-snaps SNAP:<PLUG-OR-SLOT>09:09
zyga(typos aside, you get the idea)09:09
mborzeckimhm09:09
zygaideally all fuelled by a new API call09:09
zygaperhaps those could also be visible via snapctl09:10
zygapstolowski: ^ do we have something like that for snapctl today?09:10
pstolowskizyga: no, unfortunately not09:11
zygawe might expose it in both places eventually09:11
zygafeels like something useful to snap developers09:11
zygamborzecki: the general idea feels like09:12
zygamborzecki: connections <snap:plug> <snap:slot> <interface> <string> <flags>09:12
zygainterface optionally limits to interface type09:12
zygastring optionally filters by name of plug/slot09:12
zygasnap:plug and snap:slot can be empty or partially empty09:13
zyga(perhaps string is useless actually)09:13
zygaflags can alter the set of returned data (e.g. attributes) or visible things (e.g. show disconnected things as well as connected, for hotplug)09:13
zygait seems it could power all the commands mentioned above09:13
zygaall of the options would probably be packed into a query structure09:14
zygawe might also have a flag for controling core/gadget connections09:14
zyga(e.g. skip them or include them)09:14
zygaso that the client code can stop having to special case "system/snapd/core/ubuntu-core"09:15
mborzeckizyga: let's have a chat ~11, 1115?09:17
zygasure09:17
mborzecki#6193 is green09:22
mupPR #6193: spread: drop Fedora 27, add Fedora 29 <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6193>09:22
zygamerge it09:32
zygawe will solve the 29 blocked aspect separately09:32
pstolowskizyga: looking at 625709:34
mborzeckizyga: about fontconfig again, desktop interface mount of /var/cache/fontconfig is probably a problem09:34
zygammm09:34
zygabut that only applies to strictly confined apps09:34
zygaisn't the problem you experienced only affecting classic confined apps?09:35
mborzeckizyga: i'm still bit worried that we're generating that cache in a location that does not match distro choice, with the way things are set up now it should work, we're going to make /var/cache/fontconfig ourselves after all09:38
zygamborzecki: yes09:38
zygamaybe we should really build a cache in /var/cache/snapd/fontconfig09:39
mborzeckizyga: righ, but the the classic snaps that use libfontconfig from core will end up poking /var/cache/fontconfig ;)09:39
zygayes09:40
mborzeckitradeoffs everywhere09:40
zygabut for those we have no way out09:40
zygauntil we can attack  mount namespaces for classic confined software09:40
mborzeckimhm09:41
zygamborzecki: updated https://github.com/snapcore/snapd/pull/625109:42
mupPR #6251: cmd/snap-confine: refactor calling snapd tools into helper module <Created by zyga> <https://github.com/snapcore/snapd/pull/6251>09:42
pstolowski#6180 is green and needs (re)reviews09:42
mupPR #6180: snap/info: bind global plugs/slots to implicit hooks <Created by stolowski> <https://github.com/snapcore/snapd/pull/6180>09:42
mborzeckizyga: pstolowski: can you take a look https://github.com/snapcore/snapd/pull/6193 and +1 ?09:47
mupPR #6193: spread: drop Fedora 27, add Fedora 29 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6193>09:47
pstolowskik09:48
zygamborzecki: aha09:50
mborzeckipstolowski: and this one needs a 2nd review too: https://github.com/snapcore/snapd/pull/6246 super simple :)09:51
mupPR #6246: spread: show AVC audits when debugging, start auditd on Fedora <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6246>09:51
mupPR snapd#6193 closed: spread: drop Fedora 27, add Fedora 29 <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6193>09:52
zygamborzecki: replied on https://github.com/snapcore/snapd/pull/625109:52
mupPR #6251: cmd/snap-confine: refactor calling snapd tools into helper module <Created by zyga> <https://github.com/snapcore/snapd/pull/6251>09:52
mupPR snapd#6246 closed: spread: show AVC audits when debugging, start auditd on Fedora <Simple 😃> <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6246>09:53
mborzeckianyone knowledgeable of assertions left around? https://forum.snapcraft.io/t/cant-install-or-refresh-snaps-on-arch-linux/8690 the device is seeded, however there is no model assertion even though data.auth.model is already set to generic-classic09:53
zygahmmm09:53
zygaI guess we just have to man up and read that code09:53
zygapstolowski: on https://github.com/snapcore/snapd/pull/6257, shall I update all headers to 2018?09:54
mupPR #6257: testutils: split checkers, tweak tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6257>09:54
pstolowskizyga: i'd use this opportunity09:55
zygasure09:55
zygapstolowski: done :)10:00
pstolowskity !10:00
mborzeckisuprising how travis jobs are succeeding now10:04
zygapstolowski: this is not super urgent but it needs a 2nd review https://github.com/snapcore/snapd/pull/624410:04
mupPR #6244: release: detect too old apparmor_parser <Created by zyga> <https://github.com/snapcore/snapd/pull/6244>10:04
zygaa much simpler variant of this went into 2.3610:05
zygathis one is just tidier and less noisy10:05
mupPR snapd#6090 closed: Granted 'account_control' access to /home/** <Created by stefannilsson> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6090>10:08
zygapstolowski, mborzecki: what do you guys think about https://github.com/snapcore/snapd/pull/625010:10
mupPR #6250: data: set KillMode=process for snapd <Created by mvo5> <https://github.com/snapcore/snapd/pull/6250>10:10
mupPR snapd#6200 closed: tests: fix for tests test-*-cgroup <Created by sergiocazzolato> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6200>10:11
zygaperhaps cherry pick the detector I suggested and LGTM?10:11
zygaI'm sure mvo can iterate on top10:11
zygabut feels like the right thing to do10:11
pstolowskizyga: do apparmor_parser and snap-seccomp lock profiles? any risk of having profiles messed up if new instances start writing profiles while old ones are still running?10:19
pstolowski(but in general yes, i think that's the right step what this PR proposes)10:20
zygathey don't lock profiles because they don't have to AFAIK:10:20
zygasnap-seccomp writes a new file with atomic move10:20
zygasnapd writes source profiles with atomic move10:21
pstolowskiah, good then10:21
zygaapparmor_parser loads profiles into the kernel, kernel is the point of mutual exclusion10:21
zygasnap-confine loads profiles from disk only at startup10:21
zygathat holds the lock but that's not really a factor10:21
zygaseccomp profiles persist until process death10:21
zygaapparmor profiles are changed dynamically10:22
mborzeckiuhh reached asserts db trying to find out what's going on10:22
zygaand?10:22
mborzeckigot lost :)10:25
mborzeckiback to devicemgr10:25
mborzeckii bet that device serial is set on that guy's machine, but it's unclear why that'd be the case and the model assertion would not be present10:31
zygafeels like we could use some commands to show stuff10:33
zygamore than "snap known"10:33
zygawhich feels like a debug command, not an end-user thing10:33
mborzeckisuper unpleasant user command if anything :)10:33
zygahttps://www.irccloud.com/pastebin/xNFfHNva/10:34
zygahmmm10:34
zygasomething really broken there :)10:34
zygalooking10:34
mborzeckinice10:34
zyganote that it uses dpkg on centos10:35
mborzeckiheh right10:35
mborzeckisnapd-xdg-open? i don't recall this in rpm10:35
zygatests/upgrade/snapd-xdg-open/task.yaml10:36
zygait runs on centos10:36
zygabut is clearly specific to ubuntu10:36
mborzeckiis that a new task?10:36
zyganope10:36
zygalook at it10:36
zygawonder why the error never surfaced?10:36
mborzeckihaha so how did it not fail before?10:36
zygaexactly10:36
zygaset -e is easy to lose10:36
zygawell10:37
zygait failed now10:37
zygaI really wonder what I changed10:37
zygaI don't quite understand some of the logic in the pkgdb.sh10:38
zygamborzecki: removed cloexec handling in https://github.com/snapcore/snapd/pull/625110:46
mupPR #6251: cmd/snap-confine: refactor calling snapd tools into helper module <Created by zyga> <https://github.com/snapcore/snapd/pull/6251>10:46
mborzeckizyga: what was it?10:47
zygamborzecki: will to fix that centos issue or shall I?10:47
zygamborzecki: with cloexec?10:47
zygamborzecki: just my debug wrappers10:47
mborzeckimhm10:47
mborzeckiaah10:47
mborzeckishell scripts?10:47
zygaI didn't realise this is needed for scripts but not for programs10:47
zygayep10:47
mborzeckiyup, they mention that in the manpage10:47
zygaI test this way locally10:47
zygayeah, in the BUGS section below :)10:48
zygaI missed that10:48
mupPR snapd#6235 closed: overlord,apparmor: new syskey behaviour + non-ignored snap-confine profile errors (2.36) <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6235>10:54
zygamborzecki, pstolowski: my main feature branch that can land https://github.com/snapcore/snapd/pull/614910:57
mupPR #6149: cmd/snap-confine: capture initialized per-user mount ns <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6149>10:57
zygaI will have follow ups and tests once the feature snapd side is ready10:57
pstolowskizyga: k, will take a look10:58
zygathank you!10:58
zygamborzecki: I have a debug shell on centos 7 with that dpkg-query script11:00
zygano idea why it would ever pass before11:00
mborzeckiheh11:01
zygadisabled it, pushed11:01
zygamagic11:01
mborzeckibtw. i'm playing with spread on fedora 2911:01
mborzeckiDEBUG: running snap-device-helper add snap_test-snapd-udev-input-subsystem_slot /sys/class/mem/null 1:311:01
mborzeckiexecl failed: No such file or directory11:01
zygado you know my main issues with spread on fedora 2911:01
zygaright11:01
mborzeckisnap-device-helper is a script, wtf?11:01
zygaI know about htis11:01
zyga*this11:01
zygayes11:01
zygabut that's not the main problem11:01
zygathe problem is that we must never repackage core or snapd snaps11:01
zygawith stuff we've built on a random distro11:01
zygathat's a bad test11:01
zygabad logic11:01
zygaand not representative of what ever happens in production11:02
zygalocally built snapd package gets injected into core snap11:02
mborzeckiyes, wanted to reach that point and inspect what happens exactly11:02
zygaso libc from 2019 will be in a 2016 system11:02
zygaI mean, progs linked to 2019 will be in a 2016 system11:02
zygawhat is wrong is that rpm helpers change the #!/ line11:02
zygalook at the shebang line in the source and in that system that is broken11:03
zygathe short term resolution:11:03
zygastop repackaging core / snapd anywhere outside of 16.0411:03
zygawe can perhaps repackage snap-exec11:03
zygabut nothing more11:03
mborzeckiwoot, rpm learned some new tricks11:07
zygamborzecki: mkosi got a huge static typing boost11:27
zygahttps://github.com/systemd/mkosi/pull/30011:28
mupPR systemd/mkosi#300: Modify so that `flake8` and `mypy` are happy <enhancement> <Created by LukeShu> <https://github.com/systemd/mkosi/pull/300>11:28
mborzeckihm still got mixed feelings about python and type hints11:31
zygareally? that's like 99% of the error checking there :)11:38
mupPR snapd#6260 opened: spread, tests: use audit checkpoints when dumping audit log <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6260>11:41
mborzeckisimple one ^^11:41
mborzeckizyga: it's just the type enforce part is missing11:41
zygamborzecki: no need11:42
zygamypy checks that it is true :)11:42
zygaif mypy says it's ok, the types match11:42
zygareality is somewhat different as sometimes there are bugs in mypy and sometimes there are cases that are valid but the type system cannot express it11:42
zygabut really, apart from changing python in py411:42
zygathis is the best way to write python now11:43
zygaeh11:52
zygauntangling the mess in config manager11:52
zygasucks11:52
zygacyclic import mess, that is11:53
mborzeckihah :)11:53
zygaI will never finish user mounts this way11:54
zygaI think I got it12:03
zygaI will propose a small branch with just the tweak to config12:03
mupPR snapd#6261 opened: tests/lib/prepare: make sure that SELinux context of repacked core snap is controlled <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6261>12:06
mborzeckianother simple PR ^^12:06
mborzeckithis time not dropping xattrs12:06
zygaeh12:07
zygamore cyclic shit12:07
zygaI hate this part of golang12:07
zygaLGTM with capitalisation of sentences12:08
zygamborzecki: hmm12:10
zygadoes set -o12:10
zygadoes that set something in practice12:10
zygabecause i have a feeling that that patch actually uncovered real bugs12:10
cachiozyga, hey12:10
cachioerror: Failed build dependencies:12:10
cachiocompiler(go-compiler) is needed by snapd-1337.2.36.2-0.el7.x86_6412:10
cachioI get this error on centos 7.612:10
mborzecki       −o    Write the current settings of the options to standard  output  in12:10
mborzecki             an unspecified format.12:10
zygacachio: ehey12:11
mborzeckicachio: hmm interesting12:11
cachiozyga, I made sure go is instlaled12:11
zygamborzecki:  https://www.irccloud.com/pastebin/3I0NnCO5/12:11
cachiomborzecki, yes12:11
zygacachio: I don't follow EPEL work so no idea12:11
cachiomborzecki, do you?12:11
cachioright12:11
cachio?12:11
mborzeckicachio: any chance i could use the image?12:12
cachioI have a debug session already openned12:12
cachiomborzecki, do you want to use it?12:12
zygamborzecki: my guess is that sourcing some of our packages nukes set -e12:12
zygaand this is now changed _somehow_12:12
cachiomborzecki, otherwise the image name is test-centos-112:13
zygasourcing vs executing12:13
zygasourcing is evil12:13
mborzeckicachio: yes, i'll try to build snapd there, i recall chasing down something similar12:13
mborzeckizyga: hence, 'evil sourcerer' :)12:14
zygahaha12:14
zygawe should really stop doing that12:14
zygaor add sanity checks on 1st/last line of each file12:15
zygathis really sucks12:15
zygaI wonder what else is hidden by this12:15
mborzeckishell sucks12:15
cachiomborzecki, great, thanks12:16
cachiozyga, are you working with this error on snap-run right?12:19
zygawhich error?12:20
cachiozyga, I have seen many times the error :12:20
cachiosnap run --trace-exec test-snapd-tools.echo hello12:21
zygaI haven't touched that code12:21
zyganor seen the error12:21
zygathat's mvo's new thing, if it fails perhaps we should revert for now12:21
zygamborzecki: https://github.com/snapcore/snapd/pull/6190 should now pass and has the configuration untangled12:22
cachiozyga, ok, I'll collect the logs since yesterday to check it is failing on the same place12:22
mupPR #6190: overlord/configstate,features: expose features to snapd tools <⛔ Blocked> <Created by zyga> <https://github.com/snapcore/snapd/pull/6190>12:22
zygahow is it failing?12:22
cachiozyga, well, it is failing on arm devices12:24
zyga_how_12:24
cachiozyga, https://paste.ubuntu.com/p/4RGQB3VmCv/12:24
zygaerror: unknown flag `trace-exec'12:25
mborzeckithat's the new thing12:25
zygalooks like combination of old binaries and new tests12:25
zygaso?12:25
ackkhi, I opened https://bugs.launchpad.net/snapcraft/+bug/1802345 a while ago. now, with snapcraft building by default in VMs, is there a way to export that env var?12:26
mupBug #1802345: can't build python part with C modules <Snapcraft:New> <https://launchpad.net/bugs/1802345>12:26
zygaackk: that's a question for sergiusens12:26
cachiozyga, ahh, ok, in that case the core on edge did't get the last updates12:26
cachiozyga, sorry, I'll check what happended there12:29
zygamborzecki: I added some sanity detectors to sourcing pkgdb12:33
xnoxhi! can anybody please verify https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1778936 ?12:33
mupBug #1778936: please re-add Support-system-image-read-only-etc.patch <patch> <verification-needed> <verification-needed-bionic> <systemd (Ubuntu):Fix Released> <systemd (Ubuntu Bionic):Fix Committed> <systemd (Ubuntu Cosmic):Fix Released> <https://launchpad.net/bugs/1778936>12:33
xnoxotherwise, i guess i will need to drop the writable-etc patch to get systemd to be released =/12:33
zygaxnox: what's the timeline?12:34
xnoxzyga, well, mvo has been chasing me about this for a long time, and as far as i understand it affects/blocks usablity of core18 by default.....12:34
zygayes, I mean, how soon do you need this verified12:35
zygamvo is away this week12:35
xnoxzyga, i have a new SRU ready to upload with severe regression fixes.12:35
xnoxzyga, thus i do need to release this update soon.12:35
ackksergiusens, hi, do you have any insight on #180234512:35
mupBug #1802345: can't build python part with C modules <Snapcraft:New> <https://launchpad.net/bugs/1802345>12:35
xnoxzyga, i'm away from thursday.... today/tomorrow would be really nice12:35
zygaxnox: I see, I will get back to you shortly12:36
xnoxzyga, mostly i have no idea how to build and boot core18 with systemd from bionic-proposed.12:36
xnoxotherwise i can validate this issue myself....12:36
xnoxzyga, are there core18 images built with bionic-propsoed somewhere?12:36
zygasadly, I don't know this12:36
zygaI'm trying to find out12:36
zygathe pipeline around this is a bit of a black magic12:37
sergiusensackk: might just be a python plugin bug; the xenial issue feels tricky as snapcraft wouldn't be able to build as we use yaml, macaroons and other things so I will have to look into it12:37
ackksergiusens, wdym "snapcraft wouldn't be able to build" ? you mean build itself?12:39
sergiusensyes, build itself12:39
xnoxzyga, also the systemd update, triggered snapd autopkgtests with regressions on all arches.12:40
diddledansergiusens, ackk, try adding libc6-dev if you want the headers for libc12:40
ackksergiusens, why is that relevant? the bug is about building a python snap12:40
ackkdiddledan, the problem is not that headers are not there, it's that they are not found without that export12:41
xnoxzyga, is 2018-11-20 16:29:44 Failed tasks: 112:41
xnox    - autopkgtest:ubuntu-18.04-i386:tests/main/dirs-not-shared-with-host:alternatives12:41
xnoxknown?12:41
sergiusensackk: snapcraft is a python snap, what do you mean it is not relevant?12:41
xnoxin that case i can ask release team to add a hint to ignore that.12:41
ackksergiusens, does it specify that env var in override-build?12:41
diddledanoh, ackk, you're building with python2 but supplying the python3-dev package12:42
diddledanadd `python-version: python3` to your part yaml12:42
ackkdiddledan, oh lemme try that12:43
zygaxnox: hmmm, probably tests out of sync with code12:43
zygaxnox: we no longer have /etc/alternatives management in snapd12:43
zygaand core was changed to not use such symlinks12:44
zygaxnox: it's a bit unfortunate because I don't participate in that part of snapd (release) and this is really something mvo should answer12:44
zygabut he's unlikely to this week12:44
sergiusensackk: envvars do not make it to plugin logic, if you are doing something complex, script the whole thing or write a custom plugin12:44
ackkdiddledan, same error12:46
diddledansergiusens: we should make available a bare-bones template/example for people to base their custom plugins on12:46
diddledani.e. a template that does nothing without adding code but shows all the standard functions12:46
diddledanstubs all the standard functions**12:46
sergiusensdiddledan: we had that in the old docs, I cannot for the life in me find anything in the new ones...12:46
ackkdiddledan, fwiw it'd be nice if you could specify the actual python version, like python3.7  as both 3.6 and 3.7 are available on bionic12:49
mborzeckioff to pick up the kids12:51
ackksergiusens, why am I doing something complex? it's just building a pyhton app, with C modules12:52
ackksergiusens, seems something that the python plugin should support, which it could by just exporting C_INCLUDE_PATH to /usr/include/<python-version>12:52
sergiusenswell, I said I would look at the bug later, all you will get from me now are shallow replies12:53
diddledanhttps://media2.giphy.com/media/JMoyE48gJqivS/giphy.gif?cid=3640f6095c06792f566577304103b64512:55
cachiomborzecki, hey, could you please take a look to #621713:00
cachioit is close13:00
cachiothanks13:00
mupPR #6217: tests: reset snapd state on tests restore <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6217>13:00
* pstolowski lunch13:01
* zyga -> cofee13:09
zyga*coffee13:10
diddledanackk: move `python3-dev` from `build-packages` to `stage-packages`.13:12
ackkdiddledan, ah, that worked! out of curiosity, why is that needed?13:29
zygacachio: hey, can you please work with xnox to run regression tests on https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/177893613:42
mupBug #1778936: please re-add Support-system-image-read-only-etc.patch <patch> <verification-needed> <verification-needed-bionic> <systemd (Ubuntu):Fix Released> <systemd (Ubuntu Bionic):Fix Committed> <systemd (Ubuntu Cosmic):Fix Released> <https://launchpad.net/bugs/1778936>13:42
zygacachio: it needs a core18 snap with systemd from proposed13:42
zyga(back from coffee and extra dog walk that he demanded)13:44
zygamborzecki: I added set -o traces in various points13:44
zygarunning a test now, let's see13:44
cachiozyga, sure13:45
zygathank you13:45
zygaxnox: ^ cachio will help with testing that13:45
ackkdiddledan, thanks for the tip btw13:45
zygamborzecki: set -e is set when the test executes, as expected13:52
zygamborzecki: comparing that to what happens in master13:53
zygathis is really puzzling13:53
mborzecki2018-12-04 14:54:52 Failed tasks: 3 <-- that's with fedora 2913:56
zygamborzecki: which tasks failed?13:56
mborzeckizyga: tests/main/document-portal-activation tests/main/prepare-image-uboot and tests/main/snap-run13:57
zygainteresting13:58
zygawhat did you change?13:58
mborzeckiadded a workaround for snap-device-helper13:58
zygamborzecki: heh13:59
zygaman13:59
zygait passes on master13:59
zygaso yes13:59
zygasomething is broken in our spread test suite13:59
zygarunning with --shell-after now13:59
mborzeckihahah13:59
zygaI will shortly know what's the cause13:59
mborzeckiwe should write go scripts14:00
zygawith the tracing added, all I need is to diff the right spot14:00
zyga:/14:00
mborzecki#!/usr/bin/go run14:00
zygawe should not source stuff14:00
zygawrite tools14:00
zyganot shell functions14:00
zygaand migrate away from that14:00
zygathen tools can become non-shell14:00
mborzeckidamn, standup14:01
zygajoining14:01
zygapstolowski: standup14:02
zygamborzecki: can you ack/merge https://github.com/snapcore/snapd/pull/625714:04
mupPR #6257: testutils: split checkers, tweak tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6257>14:04
mupPR snapd#6257 closed: testutils: split checkers, tweak tests <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6257>14:05
pedroniszyga: mborzecki: hi, I don't the situation of the arch user that lost the model assertion, afaict the code sets the state only after having added the assertion14:20
pedronis* I don'tunderstand14:20
ppisatiogra: where can i find the ubuntu core arm64 image for the raspberrypi3?14:20
pedronismborzecki: if you can spend some thinking what could delete it,  I don't have brain cycle for it atm14:20
zygapedronis: note that i have a core device in similar state, I have the state of that if someone wants to attack that at some point14:20
ograppisati, somewhere in mvo's people account14:21
ograIIRC14:21
ograppisati, https://forum.snapcraft.io/t/pi3-64-unofficial-image/831714:22
pedroniszyga: that sound bad, I don't know any code that would remove a model assertion that was set14:22
pedronissounds a serious bug14:22
ppisatiogra: ack, thank you14:22
ograppisati, did you get anywhere with A+ and vc4 ?14:22
ppisatiogra: oh yeah, it already spawned 2/3 lp bugs14:23
ppisatiogra: cma=256M is the problem14:23
ograwell, thats builtin14:23
ppisatiogra: this is the oops - https://bugs.launchpad.net/ubuntu/+source/linux-raspi2/+bug/180511714:23
mupBug #1805117: Xenial/raspi2 and RaspberryPi3a+: OOPS during boot <patch> <linux-raspi2 (Ubuntu):New> <https://launchpad.net/bugs/1805117>14:23
ograthe driver has it hardcoded somewhere ... IIRC14:24
ppisatiogra: and this is the cma / deadlock: https://bugs.launchpad.net/ubuntu/+source/linux-raspi2/+bug/180517414:24
mupBug #1805174: Xenial/raspi2 and RaspberryPi3A+: video not working <linux-raspi2 (Ubuntu):New> <https://launchpad.net/bugs/1805174>14:24
ppisatiogra: yeah. but you can specify cma=a on the dtparam14:24
ppisatiogra: wait, let me find14:24
ograbtw, the closed driver works really fine14:24
ograyeah, i know14:24
ppisatiogra: https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial/tree/arch/arm/boot/dts/overlays/README?h=raspi214:28
ppisatiogra: search for "vc4-kms-v3d"14:28
ppisatiogra: Params: cma-256                 CMA is 256MB, 256MB-aligned (needs 1GB)14:28
ppisatiogra: while the rpi3a+ has 512MB14:28
ppisatiogra: pass cma-128 and it will work14:28
ograyeah, i got that ... my prob is that i have no conditional i could use in config.txt to actually set it dynamically14:29
ograand i dont want an A+ sepcific image14:29
pedronismborzecki: zyga: notice that those systems could be in that state since long, is just that 2.36 is surfacing now the bad state14:31
zygapedronis: in my case I updated a device after fresh install14:31
ograthe alternative would be to simply default to cma-128, but that degrades the actual pi3 i guess14:31
zygathis was circa ~ 3  weeks ago14:31
zygathe device is off since then14:31
mborzeckipedronis: right, that's my hunch as well, added a note in the forum14:32
pedroniszyga: as I said the update would be make the bad state appear14:32
pedronisI don't think it removed the model14:32
ppisatiogra: the problem is that the fw set cma=256 even on that board, and the drivers locks up with that much memory14:32
pedroniszyga: I might be missing something14:32
pedronistough14:32
ppisatiogra: i can fix the oops, but then ther's another problem after that14:32
ograyeah14:32
ograright14:32
zygapedronis: I will look at that device tomorrow14:32
zygaworking with maciek on mount error now14:33
ograi understand ... that why i would like to simply do it via a conditional in config.txt and have it pick the right value ... https://www.raspberrypi.org/documentation/configuration/config-txt/conditional.md14:33
ogra*that's14:33
ograbut i can neither filter on pi3 vs A+ nor on available RAM14:33
ogra(would be all easier if we could apply the overlays from u-boot ... then i could just check what board i'm on easily)14:34
mupPR snapd#6262 opened: apparmor: allow snap-update-ns access to common devices <Simple 😃> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/6262>15:08
sergiusenshaving a .snapcraft as an alternate to snap is going to be a bigger code change than I wanted15:14
zygasudo umount /tmp/dupa-* &&  sh -c 'for i in $(seq 1000); do mkdir -p /tmp/dupa-$i && umount /tmp/dupa-$i 2>/dev/null; cp foo.snap foo-$i.snap && LIBMOUNT_DEBUG=all mount foo-$i.snap /tmp/dupa-$i >mount.$i.log 2>&1 & done'15:15
zygaer15:16
zygasudo sh -c 'umount /tmp/dupa-* 2>/dev/null; for i in $(seq 1000); do mkdir -p /tmp/dupa-$i && cp foo.snap foo-$i.snap && LIBMOUNT_DEBUG=all mount foo-$i.snap /tmp/dupa-$i >mount.$i.log 2>&1 & done'15:16
zygawith waiting: sudo sh -c 'umount /tmp/dupa-* 2>/dev/null; for i in $(seq 1000); do mkdir -p /tmp/dupa-$i && cp foo.snap foo-$i.snap && LIBMOUNT_DEBUG=all mount foo-$i.snap /tmp/dupa-$i >mount.$i.log 2>&1 & done; wait'15:17
zygamborzecki: ^ those take a lot of CPU from systemd and various mount-observing tools15:18
zygaha15:23
zygawhen running many mount in parallel15:23
zygaI got:15:23
zygasystemd[PID]: Failed to get udev event15:23
zygasudo sh -c 'umount /tmp/dupa-* 2>/dev/null; for i in $(seq 1000); do mkdir -p /tmp/dupa-$i && cp foo.snap foo-$i.snap; done; for i in $(seq 1000); do LIBMOUNT_DEBUG=all mount foo-$i.snap /tmp/dupa-$i >mount.$i.log 2>&1 & done; wait'; grep 'final srcpath'  mount.*.log | cut -f 6 -d ':' | sort | uniq -c | cut -c 7-  | cut -d ' ' -f 1 | sort | uniq -c15:25
zygamborzecki: can you copy any snap you have on hand to foo.snap15:27
zygamborzecki: and run that15:27
* zyga -> dinner15:27
cjwatsonsergiusens: please tell me this isn't another place where snapcraft.yaml can live?  we already have three :(15:38
* cachio lunch15:47
zygare16:03
zygajdstrand_: thank you for the review16:03
zygaI will jump to that shortly16:03
sergiusenscjwatson: the snapd team does not want to rename their in code "snap" directory16:08
sergiusensso it came as a requirement to change it16:09
cjwatsonWell, just remember that adding more locations for snapcraft.yaml requires changing at least LP and BSI too16:09
zygaBSI?16:10
cjwatsonAnd may cause operational problems since it will increase the number of queries BSI is making to GitHub (although hopefully not by very much)16:10
cjwatsonbuild.snapcraft.io16:10
zygaah16:10
sergiusenscjwatson: yeah, it sucks16:10
sergiusensjust to avoid a big sed in the code, we get to add logic all over the place16:10
cjwatsonsergiusens: can you file bugs on LP and BSI once the snapcraft change lands, if it's unavoidable?16:10
sergiusenssure thing16:19
cjwatsonthanks16:19
mupPR snapcraft#2399 closed: cmake plugin: use build snaps to search paths <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2399>16:28
zygamborzecki: still there?16:36
zygano luck on 16.04 either16:36
zygamborzecki: but interestingly I can easily trigger this:16:39
zygahttps://www.irccloud.com/pastebin/UFMlCwov/16:39
zygaso that part is working as intended16:39
zygagru 04 08:44:10 ubuntu snapd[897]: 2018/12/04 08:44:10 Unsolicited response received on idle HTTP channel starting with "HTTP/1.0 408 Request Time-out\r\nCache-Control: no-cache\r\nConnection: close\r\nContent-Type: text/html\r\n\r\n<html><body><h1>408 Request Time-out</h1>\nYour browser didn't send a complete request in time.\n</body></html>\n"; err=<nil>16:47
zygahmm?16:48
katamoaloha, I need to change ownership of a snap, specifically https://snapcraft.io/scout-plane/listing, from myself to a colleague. Can I get help with that here?16:55
mborzeckizyga: nice16:55
zygakatamo: yep, but probably requires a forum topic too,16:55
popeykatamo: best to ask in the store category on the forum16:55
zygamborzecki: yep16:55
zygamborzecki: so, ...16:55
katamopopey ack, ty16:55
zygamborzecki: I'm running this in parallel with systemd restarts now16:55
zygano luck16:55
mborzeckirestarts?16:55
zygadaemon-reload16:56
mborzeckiah ok16:56
mborzeckizyga: have you tried the reproducer script yet?16:56
mborzeckizyga: https://gist.github.com/bboozzoo/d4b142229b1915ef7cc0cf8593599ad916:56
zygayeah but I want to find a deeper angle on this :), the erorr was, clearly, from libmount, not from systemd itself16:56
zygasystem caught and reported it16:56
zygathat's fine16:56
mborzeckizyga: maybe a problem is with loading mountinfo in systemd?16:59
zygahmmm16:59
zygainteresting idea16:59
mborzeckizyga: iirc that's done separately in io loop16:59
zygaworth looking16:59
mborzeckizyga: and there's that super ineresting comment:16:59
mborzecki        /* Note that due to the io event priority logic, we can be sure the new mountinfo is loaded16:59
mborzecki         * before we process the SIGCHLD for the mount command. */16:59
zyga yeah, I read that16:59
zygait looks correct though16:59
zygaone more thing to do16:59
zygais to breakpoint there17:00
zygawhen it cannot find it17:00
zygaand rewind enough state to look around17:00
=== pstolowski is now known as pstolowski|afk
=== jdstrand_ is now known as jdstrand
mupPR snapcraft#2419 opened: project: state file path change <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2419>19:11
mupPR snapd#6263 opened: Retrieving all pages for 'find' command, not only one <Created by WiseRaccoon> <https://github.com/snapcore/snapd/pull/6263>19:17
zygajdstrand: hey, updated https://github.com/snapcore/snapd/pull/624420:46
mupPR #6244: release: detect too old apparmor_parser <Created by zyga> <https://github.com/snapcore/snapd/pull/6244>20:46
zygaI'd like to land it as-is, I'm still doing one aspect20:46
zygawhen we have a object (kernel or parser) and some features20:47
zygathere are features we want to have to be fully operational20:47
zygafeatures we want to have to be partially operational20:47
zygaand features we must have to be in any way operational20:47
zygayou are right this is not captured20:47
zygaI'd like to do that properly with a follow-up20:47
zygaI added a few missing tests, got coverage to 100%20:47
* jdstrand responded in the pr21:16
zygajdstrand: thanks, lookin g21:32
zygajdstrand: replied there21:35
zygajdstrand: totally offtopic21:35
zygado you know what's the status of the upstreaming effort21:35
zygaI'm running tumblweed instead of ubuntu recently and I keep taking notice that we're not fully supported yet21:36
=== gurmble is now known as grumble
jdstrandzyga: af_unix is still missing. it is the last thing. I know jjohansen was working to get things into the latest merge window and af_unix was on the table, but not sure if he got it in21:51
zygacool, fingers crossed :)21:51
zygausing TW is like being on debian sid21:51
zygabut without any debian specific things I may assume are true universally21:51
jdstrandzyga: note that once af_unix is in, will need apparmor 3 userspace for (at least) the networking bits21:51
zygait's been a fun journey21:51
zygais apparmor userspace 3 released?21:52
jdstrandnot yet21:52
jdstrandit is also planned, but behind the af_unix mediation and a few other things. it, those things and af_unix are all for this cycle21:53
jdstrandand by cycle, I mean our dev cycle, not the upstream kernel or anything else21:53
zygado you know if the eventual release will affect ubuntu that has carried the earlier patches in any way?21:53
zygaaha21:53
jdstrandzyga: I don't hve the details on that, but we'll definitely make sure we have things working everywhere in Ubuntu21:54
zygajdstrand: I'm about to EOD but I'd love a one last look at https://github.com/snapcore/snapd/pull/624422:21
mupPR #6244: release: detect too old apparmor_parser <Created by zyga> <https://github.com/snapcore/snapd/pull/6244>22:21
zygaah, I see you replied22:21
zygaagain, stale page :/22:22
zygajdstrand: I'll tweak this tomorrow, thank you :)22:22
jdstrandzyga: np. happy to review again tomorrow. take it easy :)22:23
roadmrjdstrand: the tools r1167 are now merged in the store's trunk and should be deployed some time this week, ideally tomorrowish23:16
jdstrandroadmr: thanks! :)23:21

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!