[07:51] <oSoMoN> good morning desktoppers
[07:55] <duflu> Morning oSoMoN, seb128, all
[07:56] <oSoMoN> good afternoon duflu
[09:01] <Laney> yo
[09:03] <seb128> hey oSoMoN duflu Laney
[09:03] <seb128> how are you?
[09:03] <duflu> 'lo Laney
[09:05] <willcooke> moin
[09:06] <oSoMoN> yo Laney, salut seb128, moin willcooke
[09:06] <seb128> hey willcooke
[09:06] <duflu> Hi willcooke
[09:23] <Laney> hey seb128 duflu oSoMoN willcooke
[09:23]  * Laney is good, won the pub quiz last night :>
[09:24] <willcooke> woot!  Congrats Laney
[09:24] <willcooke> What did you win?
[09:24] <willcooke> Was it a special xmas one?
[09:24] <Laney> N pints (forgot how many)
[09:24] <Laney> yeh, all the questions were xmas themed
[09:24] <willcooke> love it
[09:24] <Laney> luckily for us one of the team members has excellent christmas #1 knowledge
[09:24] <willcooke> :D
[09:25] <Laney> how many christmas number 1s has cliff richard sung on?
[09:25] <willcooke> I'd guess at maybe 3 of his own, and then a couple of charity ones, so...five?
[09:25] <seb128> Laney, again! you/your team are gooood :)
[09:25] <Laney> close, it's 4
[09:26] <Laney> 2 solo / 1 with some band (the shadows?) / band aid
[09:26] <willcooke> No points for close though
[09:26] <willcooke> I think we could have a pub quiz in the channel
[09:26] <willcooke> :)
[09:26] <seb128> haha
[09:27] <seb128> virtual beers
[09:27] <Laney> good plan
[09:27] <willcooke> I wonder if there is a bot for it, I bet there is
[09:28] <seb128> Laney, I commented on the nm/autopkgtest bug, I asked on #nm the other day and thomas made a short reply in between other things (then I was travelling/off, didn't manage to resume that conversation), that's not a solution but give some info/can be maybe useful
[09:29] <Laney> thx
[09:30] <Laney> i'll have a look at that
[09:36] <Laney> proposed-migration forgot about the n-m test and let dnsmasq migrate
[09:36] <Laney> that's a bit dubious
[09:37] <seb128> :/
[09:37] <Laney> trying to write a testcase for that and fix it too
[09:52] <seb128> andyrock, Trevinho: hey, can we get an ubuntu-dock update for disco with what is in trunk from ubuntu dashtodock?
[09:59] <duflu> seb128, which branch is that? The Ubuntu branch seems to be unchanged from January
[10:00] <duflu> Oh. That was a couple days ago. Nevermind :)
[10:01] <seb128> upstream dashtocok I meant
[10:01] <seb128> dashtodock
[10:01] <duflu> It got refreshed this week
[10:02] <seb128> duflu, upstream git has the popover changes and your repaint fix
[10:02] <seb128> would be nice to have those in the distro
[10:02] <duflu> seb128, not in the ubuntu-dock branch
[10:02] <seb128> right, which is what I was asking them about
[10:02] <seb128> rebasing our branch on trunk
[10:02] <seb128> and getting that uploaded to disco
[10:03] <duflu> seb128, yeah sorry. I was misled by "from ubuntu dashtodock". You mean from master
[10:03] <seb128> yeah, "ubuntu"->"upstream" was an unfortable typo
[10:03] <seb128> doh
[10:03] <seb128> unfortunate
[10:03]  * seb128 needs coffeee
[10:03] <duflu> Righto
[10:03] <duflu> +1
[10:03] <seb128> :)
[10:05] <duflu> seb128, it's a little unfortunate actually. I wrote that fix in January and it got stuck on apparently erroneous community testing
[10:05] <seb128> :(
[10:05] <seb128> so we should also SRU the fix to bionic maybe?
[10:05] <duflu> Still goot intentions
[10:06] <duflu> seb128, no it needs time to mature yet
[10:06] <seb128> k
[10:06] <duflu> -goot +good
[10:32] <willcooke> If we SRU d-2-d to B from D, it would change the behaviour of the window preview ordering.  From "most recent at the top" to "always listed in the order they were opened in"
[10:33] <willcooke> I'd be very happy to see that.
[10:33] <willcooke> IMO the current ordering is broken
[10:33] <willcooke> well, and upstream's view as well now
[10:33] <willcooke> so that would be a nice thing to do
[10:33] <willcooke> but, it does change the behaviour, so dunno, is that a special case?
[11:03] <Laney> would have to convince the SRU team
[11:03] <Laney> but if you can make a convincing argument, probably could be done
[11:03] <Laney> wholesale SRU might be interesting (in a bad way) depending on what else is in there, chance of regressions / other behaviour changes etc
[11:06] <willcooke> ack, thx Laney
[11:17] <Laney> probably possible with enough will :-)
[12:12] <seb128> willcooke, right, what L_aney said, I wouldn't could on a behaviour change to be easy to justify to the SRU team, one things users expect from a LTS is stability and not having to adapt/re-learn workflows (especially true in work place where changes might mean more support calls/having to explain to employees the changes/etc)
[12:18] <Laney> probably going to follow what upstream said on network-manager and just remove the check for the link state
[12:18]  * Laney tests that
[12:18] <Laney> fatal: repository 'https://code.launchpad.net/~network-manager/network-manager/+git/ubuntu/' not found
[12:18]  * Laney slaps the archive
[12:23] <seb128> bah, launchpad :/
[12:36] <andyrock> "morning" all
[12:36] <andyrock> seb128: let's wait for Marco to be online
[12:37]  * andyrock overslept too
[12:37] <Laney> hey andyrock
[12:37] <Laney> hope you're feeing relaxed ;-)
[12:39] <andyrock> Laney: xmas mood 🎄
[12:40] <Laney> ah, a hangover
[12:40] <Laney> it all becomes clear
[12:42] <andyrock> 😂
[12:42] <talx> andyrock: whos marco
[12:42] <andyrock> Trevin_ho
[12:42] <andyrock> talx: ^^^
[13:04] <seb128> hey andyrock! happy post-drinking 'morning' :)
[13:04]  * andyrock did not drink yesterday :( 
[13:05] <andyrock> my alarm (my gf) did not wake up today
[13:05] <seb128> lol
[13:05] <andyrock> I mean now she is awake
[13:05] <seb128> well, it's good, at least you are rested and ready to be productive in the afternoon :)
[13:05] <seb128> and you still beat Marco anyway :p
[13:05] <andyrock> "did not wake up" can be easily misunderstood for something else
[13:06] <seb128> no misunderstanding, don't worry, just teasing you :)
[13:20] <Trevinho> Morning guys!
[13:22] <Laney> hey Trevinho !!!!!
[13:23] <Laney> wb, did you have a nice holiday?
[13:23] <Trevinho> Laney: hey laneyyy!
[13:24] <seb128> hey Trevinho, wb! you have been good at not showing up here during you holidays, that's nice ;)
[13:24] <seb128> did you have a good time?
[13:24] <seb128> where are you now? still on the other side of the ocean? or back on the old continent for the holidays?
[13:25] <Trevinho> And hi seb128 too...
[13:25] <Trevinho> for both... Yes had great time
[13:25] <Trevinho> landing in Europe in shorts in December was fun too 😅😢
[13:26] <seb128> haha
[13:26] <seb128> you noticed that was a mistake right? ;)
[13:27] <Trevinho> seb128: yep... Well I was getting notifications but I stay away from it... Although the newly created 3g cuban network would have allowed to interact in some way (a bit expensive but in the cities - better smaller) works quite well. So I almost joined the revolution at its first day
[13:28] <seb128> Trevinho, making history!
[13:28] <Trevinho> as for the shorts.. Well I had a change but I prefer to fly confortable
[13:30] <Trevinho> and happened something I never thought it could... After more 20 days of cuban food, when Alitalia brought me "ravioli di mare" I was about to eat the container too, as hungry i was for some quality stuff 😂
[13:31] <Trevinho> Imagine that in Cuba these days there's miss of flours, eggs and many basics (for locals, not much in restaurants). Quite shocking.
[13:40] <andyrock> hi Trevinho
[13:40] <andyrock> welcome back!
[13:45]  * andyrock goes for lunch
[13:46] <seb128> andyrock, enjoy!
[13:53] <willcooke> wb Trevinho
[14:28] <Trevinho> thanks willcooke
[14:37] <andyrock> seb128: Trevinho so regarding rebasing ubuntu-dock agains dash-to-dock
[14:38] <andyrock> *against
[14:39] <seb128> oSoMoN, sorry to add to your pre-holidays stress level but looks like the new mdds got autosynced from Debian and changed abi number and it makes the libreoffice-l10n autopkgtest fail
[14:39] <seb128> https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco/disco/i386/libr/libreoffice/20181219_132149_dfb21@/log.gz
[14:39] <seb128> it looks for mdds-1.2 >= 1.2.3 but it looks like that got bumped to 1.4
[14:40] <andyrock> I guess it's doable, the only question is who? Trevinho or me? :D
[14:43] <seb128> you guys know each other well enough to sort that detail out I'm sure
[14:43] <seb128> :)
[14:46] <Trevinho> andyrock: I can do that, if you're busy with something elsre
[14:47] <oSoMoN> seb128, ack, looking
[14:52] <willcooke> Trevinho, when you do take a look at d2d, can you make sure this gets in too:  https://github.com/micheleg/dash-to-dock/issues/639#issuecomment-444826023
[14:52] <gitbot> micheleg issue 639 in dash-to-dock "[request] Do not reorder window thumbnails after clicking on them" [Enhancement, Closed]
[14:52] <willcooke> It's in master now by the looks of it, but just want to be sure
[14:53] <Trevinho> willcooke: it looks in master so...
[14:53] <Trevinho> yes
[14:54] <willcooke> coolio, thanks
[14:54] <oSoMoN> seb128, there's already a distro patch to build with mdds 1.4, but it's not applied when building/running autopkgtests, this should be easy enough to fix
[14:54] <Trevinho> do we have an ubuntu bug for that too?
[14:54] <willcooke> dont think so, lemme check
[14:54] <willcooke> I will create one if not
[14:54] <seb128> oSoMoN, great
[14:54]  * oSoMoN wonders why autopkgtest passed in a VM near me this morning, though
[14:54] <seb128> willcooke, that's why I was asking a rebase/upload btw
[14:55]  * seb128 sees that willcook rrrrreeeaaallly care about that change :)
[14:55] <willcooke> yeah, I thought so, but that's the thing I really care about, so just wanted to be explicit
[14:55] <willcooke> ha
[14:55] <willcooke> indeed
[14:55] <seb128> right, you made that obvious by now :p
[14:55]  * willcooke <- stuck record 
[14:55] <willcooke> there will be much rejoicing
[14:55] <seb128> we are going to land, don't worry, that's your holidays' present for this year :)
[14:55] <willcooke> :DDDD
[14:56] <seb128> oSoMoN,  the most recent mdds sync/build is from 6 hours ago
[14:56] <seb128> the previous version failed autopkgtest and didn't move out of proposed
[14:57] <seb128> so you probably tested before it migrated and without proposed?
[14:57] <oSoMoN> I tested with -proposed
[14:58] <oSoMoN> but it could very well be that I hadn't upgraded everything from proposed, only selected packages
[15:04] <willcooke> Trevinho, I created a bug and assigned it to you: https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/+bug/1809129
[15:07] <seb128> lol
[15:07] <oSoMoN> seb128, false alarm, those autopkgtest failures are testing version 1:6.1.3-0ubuntu9
[15:07] <seb128> oSoMoN, oh ok, sorry for overlooking that :/
[15:07] <oSoMoN> because 6.1.4 is not finished building yet
[15:07] <oSoMoN> no worries :)
[15:08] <oSoMoN> that said, s390x tests failed with the correct version, looking
[15:09] <oSoMoN> badpkg: Test dependencies are unsatisfiable.
[15:11] <Trevinho> andyrock: https://github.com/micheleg/dash-to-dock/pull/862 should be fine, a part finalization and such, not sure why github complains though
[15:11] <gitbot> micheleg issue (Pull request) 862 in dash-to-dock "ubuntu-dock: merge with upstream v64" [Open]
[15:11] <andyrock> danke
[15:11] <Trevinho> (ah, no complains...) it just doesn't allow rebasing, but that's fair
[15:11] <Trevinho> better to merge in this case
[16:06] <seb128> willcooke, replying to your trello comment here, https://launchpadlibrarian.net/402016278/ubuntu-welcome-privacy-popup.png isn't good enough for the mozilla privacy notice?
[16:07] <willcooke> otp, standy by
[16:07] <seb128> willcooke, that's what you get when clicking on the privacy mention from https://launchpadlibrarian.net/402015630/ubuntu-welcome-privacy.png
[16:16] <seb128> bbiab, time for pre-evening erands
[16:25] <oSoMoN> seb128, I can upload n-m, but I can't merge the branch, I'm not part of ~network-manager
[16:26] <willcooke> seb128, ace, I didnt know that was there already!
[16:27] <Laney> oSoMoN: how unfortunate
[16:27] <Laney> cyphermox: can we add ~ubuntu-desktop to https://launchpad.net/~network-manager/+members please? nm is in the desktop set
[16:27] <Laney> oSoMoN: if you push it to your own namespace after uploading I can push that on to the central repo
[16:27] <oSoMoN> Laney, ack, I'll do that
[16:28] <Laney> cyphermox: another admin also probably wouldn't go amiss
[16:29] <oSoMoN> Laney, uploaded, and https://code.launchpad.net/~osomon/network-manager/+git/network-manager/+ref/bionic
[16:30] <Laney> thx
[16:31] <Laney> oSoMoN: can haz tag?
[16:32] <Laney> (well, arguably that shouldn't be pushed until it's accepted)
[16:32] <oSoMoN> Laney, done, I often forget to push the tags separately
[16:32] <oSoMoN> Laney, correct, let's wait until it's accepted
[16:33] <Laney> ok, try to remind me if you can remember ;-)
[16:33] <oSoMoN> will do
[16:39] <oSoMoN> huh, my changes have been pushed it seems
[16:39] <Laney> branch has
[17:43]  * Laney is in 'bisect dnsmasq' mode now
[18:37] <willcooke> night all
[18:53] <oSoMoN> good night all
[19:42] <Trevinho> jbicha: for ubuntu side of gjs isntead can you please sponsor https://code.launchpad.net/~canonical-desktop-team/ubuntu/+source/gjs/+git/gjs ?
[19:45] <jbicha> oh we probably don't need to branch for that. I'll take a look today. (I forgot my power cord so I'll need to go back home first)
[21:08] <seb128> Trevinho, andyrock, k, I'm calling it a day, I would have like to get that ubuntu-dock update done today but looks like it's not going to happen, please try to get it out tomorrow morning if possible (unsure what you got blocked on/why it took more than the afternoon, but let's talk about it tomorrow morning, ping me when you get online)
[21:46] <jbicha> Trevinho: I think that LP: #1803271 does not explain or mention the *other* changes from 1.52.1 to 1.52.5
[21:47] <jbicha> also there are a bunch of changes in 1.52.4-1 that aren't necessary for bionic
[21:48] <jbicha> I recommend going back to 1.52.1-1ubuntu, merge upstream/1.52.5 and then you don't need to make any changes in debian/ (except updating the Vcs fields and add the new debian/changelog entry)
[21:50] <jbicha> oh and dropping the 3 Ubuntu patches, but they aren't exactly the same as the 3 Debian patches
[21:52] <jbicha> please point the Vcs fields to https://code.launchpad.net/~ubuntu-desktop/ubuntu/+source/gjs/+git/gjs
[21:53] <jbicha> I suggest dropping the tilde from your version number
[22:03] <Trevinho> jbicha: ok, I can just merge with that then
[22:11] <Trevinho> jbicha: as per vcs fields, we use the other ones in most of places
[22:12] <Trevinho> and it's more readable indeed
[22:14] <Trevinho> anyway, I've updated it
[22:34] <Trevinho> jbicha: so this is https://code.launchpad.net/~3v1n0/ubuntu/+source/gjs/+git/gjs/+merge/361167
[22:41] <jbicha> sure, that version of the vcs is fine
[22:41] <jbicha> I'll look again later tonight
[22:43] <Trevinho> ta
[23:13] <jbicha> Trevinho: do you think we need a new bug to track 1.52.5 or do you want to add that info to the existing bug
[23:18] <Trevinho> we can do both, let me add one
[23:28] <jbicha> 2 nitpick issues then: there are extra lines added to gbp.conf that aren't needed in the SRU. The patches you listed in the changelog don't match the filenames you actually removed.
[23:40] <Trevinho> jbicha: fixed both