[05:50] <mborzecki> morning
[06:07] <mborzecki> mvo: morning
[06:07] <mvo> hey mborzecki - good morning and happy new year
[06:07] <mborzecki> mvo: happy 2019 :)
[06:07] <mvo> mborzecki: (a bit late for that I admit :)
[06:08] <mborzecki> mvo: that was a long break
[06:09] <mvo> mborzecki: indeed it was, longest in years for me. feels great to be back though
[06:09] <mvo> mborzecki: just a mountain of email :)
[06:09] <mborzecki> mvo: lp bug reports mostly
[06:10] <mborzecki> mvo: didn't know discourse is sending summary emails now
[06:10] <mvo> mborzecki: is there anything I should be aware of? anything I/we need to jump on immediately?
[06:11] <mborzecki> mvo: not that i'm aware of
[06:12] <mborzecki> mvo: though, there are some interesting PRs from ondrej
[06:13] <mvo> mborzecki: cool, I check them out once the mail is triaged :)
[06:13] <mborzecki> mvo: ah, and we're going to have 5.0 kernels soon(ish), wonder if there are any assumptions in the test suite that will break
[06:14] <mvo> mborzecki: interessting and good point. I *hope* we don't have any but it will be an interessting test to run it on such a kernel
[06:40] <mborzecki> mvo: are we doing 2.37 this week?
=== cpaelzer__ is now known as cpaelzer
[06:42] <mvo> mborzecki: that was my plan, yes
[07:04] <zyga> good morning
[07:04] <zyga> defer happyNewYear()
[07:05] <zyga> -9 outside and not much warmer in the office, I've set up the heater and will work upstairs for some time
[07:05] <mborzecki> zyga: hey
[07:06] <mborzecki> zyga: i'm reading -13 outside here
[07:06] <zyga> lovely :)
[07:06] <zyga> I do envy you there, winter in the city is just smog and loads of salt to melt the ice
[07:06] <zyga> this must have been the longest winter break at canonical ever
[07:06] <zyga> I don't remember what I was doing before
[07:08] <mvo> hey zyga! great to "see" you. good morning and happy 2019
[07:09] <zyga> hey mvo :)
[07:09] <zyga> hmm, launchpad is timing out for me (on writes)
[07:51] <zyga> we seem to have a new wave of static analyzer failures
[07:51] <zyga> the lot https://www.irccloud.com/pastebin/Z29lszu7/
[07:51] <zyga> this breaks all Prs
[07:51] <zyga> I'll jump into that to unbreak master
[07:52] <mvo> zyga: nice, thank you
=== pstolowski|eoy is now known as pstolowski
[08:01] <pstolowski> morning everyone! happy new year!
[08:02] <zyga> good morning
[08:02] <zyga> happy new year indeed :)
[08:02] <mvo> hey pstolowski good morning and happy new year!
[08:03] <mborzecki> pstolowski: heya
[08:04] <zyga> quick reboot for new kernel
[08:16] <pedronis> happy new year!
[08:22] <zyga> happy new year pedronis :)
[08:22] <pedronis> hi
[08:22] <jamesh> looks like staticcheck doesn't understand cgo (among other things)
[08:23] <zyga> indeed
[08:23] <zyga> I'm working through those
[08:26] <pedronis> zyga: if it give us trouble is also ok to disable it until we actually switch to 1.9/1.10
[08:27] <pedronis> (me is not a fan of tests that fail over an unchanged codebase)
[08:29] <zyga> pedronis: I will disable some tests, fixing some others
[08:30] <zyga> this did find a lot of dead code
[08:30] <pedronis> zyga: I understand but removing dead code is not a high priority either
[08:30] <pedronis> my point stand
[08:30] <zyga> ack
[08:32] <pstolowski> hey pedronis! happy new year!
[08:33] <jamesh> could you build a particular release of staticcheck rather than whatever is latest?
[08:34] <pedronis> jamesh: yea, that's my point about waiting to use something that has it included
[08:35] <pedronis> pstolowski: hi
[08:38] <mvo> hey pedronis - happy new year
[08:38] <mvo> and hello sil2100 - happy new year to you as well :)
[08:38] <mup> PR core18#110 opened: hooks: add support for `.test` files and add some initial tests <Created by mvo5> <https://github.com/snapcore/core18/pull/110>
[08:38] <pedronis> mvo: hi, thanks
[08:41] <zyga> mvo: some comments
[08:41] <mvo> zyga: thank you! looks great
[08:43] <mvo> zyga: core18#110 a bit of an RFC right now mostly for pedronis and sil2100 but I think the point that this tree needs more tests is very valid
[08:43] <mup> PR core18#110: [RFC] hooks: add support for `.test` files and add some initial tests <Created by mvo5> <https://github.com/snapcore/core18/pull/110>
[08:47] <sil2100> Happy new year everyone o/
[08:47] <zyga> sil2100: indeed :) welcome back
[08:47] <zyga> pedronis: https://github.com/snapcore/snapd/pull/6328
[08:47] <mup> PR #6328: run-checks: stop running HEAD of staticcheck <Created by zyga> <https://github.com/snapcore/snapd/pull/6328>
[08:47] <zyga> brb, coffee
[08:47] <sil2100> mvo: thanks for the PRs, will try having a look once I'm done with my SRU shift :)
[08:48] <mvo> sil2100: thank you!
[08:48] <mup> PR snapd#6328 opened: run-checks: stop running HEAD of staticcheck <Created by zyga> <https://github.com/snapcore/snapd/pull/6328>
[08:50] <pedronis> zyga: thx
[08:55] <zyga> and  back
[09:09] <popey> mvo: https://snapcraft.io/core no longer shows distros or maps
[09:09] <popey> is this intentional?
[09:09] <popey> (i know that can be turned off now)
[09:18] <jamesh> zyga: I filed https://github.com/dominikh/go-tools/issues/384 about the cgo issue with staticcheck
[09:18] <zyga> jamesh: thank you! that's great
[09:19] <zyga> I made a batch of removals to unused code where I feel comfortable saying it's meant to go
[09:19] <jamesh> with a two line example program :-)
[09:19] <zyga> but it can wait until master is green
[09:28] <Chipaca> moin moin
[09:28] <zyga> hello Chipaca :)
[09:29] <pedronis> Chipaca: hi
[09:29] <Chipaca> zyga: pedronis: how's things?
[09:30] <mvo> popey: good morning! let me check but I did not turn this off
[09:31] <popey> Interesting.
[09:31] <mvo> hey Chipaca - good morning and happy new year
[09:31] <ogra> you can turn it off ?
[09:31] <popey> yes, it's optional now
[09:32] <ogra> ah, interesting
[09:33] <mvo> popey: hm, this is "funny". the boxes for "display public popularity" are checked
[09:33] <popey> oooh, interesting
[09:33] <mvo> popey: so I guess that is a bug that its not visible
[09:33] <popey> this sounds like a bug :)
[09:33] <mvo> popey: I can try to turn it on and off again (i.e. uncheck/check the boxes)
[09:33] <popey> good idea
[09:33] <ogra> and wiggle the cable too !
[09:33] <mup> PR snapd#6329 opened: cmd/snap-confine, packaging: support SELinux <SELinux> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6329>
[09:34] <mvo> popey: done, does it change anything?
[09:34] <ogra> zyga, whats the status of snaps on chromeos ? https://forum.snapcraft.io/t/tried-to-install-quelea-presentation-software-from-chrome-linux-beta/9247
[09:34] <popey> no, i still don't see it
[09:34] <mvo> :(
[09:34] <zyga> ogra: I don't know anything about chromeos
[09:34]  * ogra bets one of the numbers is just too big
[09:35] <popey> mvo: would you mind filing a bug?
[09:36] <mvo> popey: do you have an example of a snap that displays the map still?
[09:36] <popey> mvo: spotify
[09:36] <ogra> turning on firefox's debugger (shift ctrl c) shows a javascript type error
[09:37] <ogra> (in the debugger tab when you reload the page)
[09:37]  * Chipaca hugs git's diff-highlight
[09:39] <zyga> mborzecki: some feedback on https://github.com/snapcore/snapd/pull/6329/files
[09:39] <mborzecki> zyga: thanks
[09:39] <mup> PR #6329: cmd/snap-confine, packaging: support SELinux <SELinux> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6329>
[09:40] <zyga> public service announcement: master is broken until we land https://github.com/snapcore/snapd/pull/6328
[09:40] <mup> PR #6328: run-checks: stop running HEAD of staticcheck <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/6328>
[09:41] <mup> PR core18#111 opened: [TEST] snapcraft.yaml: find and save snapcraftctl before unsetting PATH <Created by mvo5> <https://github.com/snapcore/core18/pull/111>
[09:44] <mup> PR snapd#6328 closed: run-checks: stop running HEAD of staticcheck <⚠ Critical> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6328>
[09:46] <Chipaca> zyga: it's not true that you can't override the .desktop files of snap apps ("by design" or otherwise); you just need to start with the right desktop files :-)
[09:46] <zyga> Chipaca: well, we don't want that, by design, it may be technically possible but that's not the point :)
[09:47] <Chipaca> zyga: I don't think it's true that we don't want that
[09:47] <Chipaca> if users want to tune (or break) things, more power to them
[09:47] <mborzecki> Chipaca: if you drop a desktop file with the same name uder ~/.local/share/applications gnome will use that right?
[09:48] <Chipaca> mborzecki: I'm not sure if it's the file name, or whether there are more heuristics, but yeah
[09:48] <mborzecki> X-GNOME-magical-key
[09:49] <Chipaca> I do know that if you copy /var/lib/snapd/desktop/applications/foo_bar.desktop into XDG_DATA_DIR, it will override
[09:49] <Chipaca> ${XDG_DATA_DIR}/applications/ bah
[09:50] <zyga> Chipaca: I mean that we have explicitly designed things to be harder to attack by instructing the user to do something "innocent" looking, e.g. you cannot snap connect powerful interfaces without assertions. Editing desktop files, which allows trivial sandbox escape, feels like part of that choice
[09:50] <mborzecki> Chipaca: mhm, so if one starts with a desktop file that snapd dropped under /var/lib they should be able to tweak it to their liking
[09:50] <Chipaca> zyga: yes a user can shoot themselves in the foot with this
[09:51] <Chipaca> mborzecki: exactly
[09:51] <mborzecki> btw. i feel sorry for this guy, wonder if it's v4l broken in his case or skype just being skype
[09:51] <Chipaca> skype is a classic snap still i think
[09:53] <zyga> pstolowski: 6330 is +0, -445
[09:53] <zyga> I didn't remove any unused hotplug stuff
[09:54] <mup> PR snapd#6330 opened: many: remove unused interface code <Created by zyga> <https://github.com/snapcore/snapd/pull/6330>
[09:56] <pstolowski> zyga: a lot of dead code, interesting. will take a look thx
[10:07] <zyga> mvo: quick look on https://github.com/snapcore/snapd/pull/6318/files please
[10:07] <mup> PR #6318: release-tools: display self-help <Created by zyga> <https://github.com/snapcore/snapd/pull/6318>
[10:14] <zyga> brb
[10:18] <popey> kk
[10:19] <mvo> zyga: cool, thanks, looking
[10:21] <mvo> popey: https://bugs.launchpad.net/snapstore/+bug/1810762
[10:21] <popey> thanks
[10:21] <mup> Bug #1810762: No worldmap on "core" snap <Snap Store:New> <https://launchpad.net/bugs/1810762>
[10:21] <mvo> zyga: nice
[10:21] <popey> mvo: sorry, i think that should be at https://github.com/canonical-websites/snapcraft.io/issues
[10:22] <popey> (also, it doesn't even render the footer, which has the link to the bug tracker)
[10:22] <mvo> popey: interessting
[10:23] <popey> the site maintainers are on it, they'll comment, thanks
[10:24] <mvo> popey: great, thank you
[10:26] <mup> PR snapd#5982 closed: interfaces/many: use 'unsafe' with docker-support change_profile rules <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/5982>
[10:28] <Chipaca> hm, staticcheck seems to have gotten pickier over the break
[10:35] <niemeyer> Good morning snapcrafters
[10:35] <pedronis> Chipaca: yes
[10:35] <pedronis> niemeyer: hi
[10:35] <niemeyer> ... and welcome back
[10:35] <mvo> hey niemeyer! good morning and happy new year
[10:35] <zyga> hey niemeyer :)
[10:36] <zyga> Chipaca: indeed
[10:36] <zyga> Chipaca: it's disabled now
[10:36] <Chipaca> zyga: is it? where?
[10:36] <zyga> Chipaca: in master
[10:36] <zyga> it landed a few hours ago
[10:36] <Chipaca> ah, just missed it
[10:44] <mvo> sil2100: (for later) I pushed core18#111 which should fix the missing snapcraftctl issue that caused travis builds to fail. would be nice to look at this too when you have time :)
[10:44] <mup> PR core18#111: snapcraft.yaml: update PATH so that snapcraftctl is still found <Created by mvo5> <https://github.com/snapcore/core18/pull/111>
[10:55]  * Chipaca goes for coffee
[11:12] <mup> PR snapd#6330 closed: many: remove unused interface code <Created by zyga> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6330>
[11:12] <zyga> thanks!
[11:24] <mvo> zyga: thank you, really nice PR
[12:07] <mup> PR snapd#6243 closed: systemd: allow only a single daemon-reload at the same time <⛔ Blocked> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/6243>
[12:20] <Chipaca> FWIW I now have access to a pure nvidia laptop running 18.04 ubuntu mate
[12:29] <Son_Goku> mvo, I can feel it in my bones... 2019 is the year we'll get full SELinux based confinement/sandboxing :D
[12:29] <zyga> Son_Goku: that's unlikely
[12:29] <Son_Goku> you're a debbie downer
[12:29] <Son_Goku> boo
[12:33] <mup> PR snapd#6323 closed: snap: give Epoch an Equal method <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6323>
[12:40]  * Chipaca ~> lunch, probably
[13:05] <mborzecki> off to pick up the kids
=== ricab is now known as ricab|lunch
[13:39] <mvo> Son_Goku: heh - happy new year!
[14:00] <mup> PR snapd#6331 opened: systemd: allow only a single daemon-reload at the same time <Created by mvo5> <https://github.com/snapcore/snapd/pull/6331>
[14:03] <mup> PR # closed: core-build#11, core-build#22, core-build#26, core-build#37
[14:04] <mup> PR # opened: core-build#11, core-build#22, core-build#26, core-build#37
=== ricab|lunch is now known as ricab
[14:42]  * zyga -> afk for walking the dog
[15:24] <pedronis> mvo: when do we plan to branch 2.37 ?
[15:29] <mup> PR snapd#6025 closed: Add go.mod files <⛔ Blocked> <Created by ryanjyoder> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/6025>
[15:31] <pedronis> Chipaca: do we have a bug where we don't consider stable and latest/stable the same (atm)?  https://forum.snapcraft.io/t/channel-latest-stable-for-core-is-closed-temporarily-forwarding-to-stable/9169
[15:38] <mborzecki> zyga: think we can reenable fedora-29 ?
[15:39] <Chipaca> pedronis: i don't think we have a bug #
[15:43] <Chipaca> pedronis: AFAIK the bug is only in snap, not in snapd, fwiw
[15:44] <mvo> pedronis: early this week, ideally today but I think there is still stuff tagged 2.37 that is not merged
[15:51]  * cachio lunch
=== ondra_ is now known as ondra
[16:18] <mup> PR snapd#6332 opened: spread: make Fedora 29 auto again <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6332>
[16:24] <zyga> re
[16:24] <zyga> sorry, the walk turned out to be walk + cooking for kids
[16:25] <zyga> mborzecki: if the underlaying issue was resolved, sure why not
[17:15] <mup> PR core18#111 closed: snapcraft.yaml: update PATH so that snapcraftctl is found <Created by mvo5> <Merged by sil2100> <https://github.com/snapcore/core18/pull/111>
=== pstolowski is now known as pstolowski|afk
[17:22] <kyrofa> Hey ogra, do we have an up-to-date Ubuntu Core porting guide that you know of?
[17:45] <mup> PR snapcraft#2430 closed: extractors: better appstream support for descriptions <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2430>
[18:18] <mup> PR # closed: snapd#5644, snapd#5822, snapd#5845, snapd#5887, snapd#5915, snapd#5962, snapd#6016, snapd#6034, snapd#6079, snapd#6098, snapd#6106, snapd#6108, snapd#6111, snapd#6113, snapd#6121, snapd#6162, snapd#6177, snapd#6238, snapd#6252, snapd#6258, snapd#6270, snapd#6280, snapd#6281,
[18:18] <mup> snapd#6286, snapd#6294, snapd#6313, snapd#6317, snapd#6318, snapd#6320, snapd#6322, snapd#6324, snapd#6325, snapd#6326, snapd#6327, snapd#6329, snapd#6331, snapd#6332
[18:19] <mup> PR # opened: snapd#5644, snapd#5822, snapd#5845, snapd#5887, snapd#5915, snapd#5962, snapd#6016, snapd#6034, snapd#6079, snapd#6098, snapd#6106, snapd#6108, snapd#6111, snapd#6113, snapd#6121, snapd#6162, snapd#6177, snapd#6238, snapd#6252, snapd#6258, snapd#6270, snapd#6280, snapd#6281,
[18:19] <mup> snapd#6286, snapd#6294, snapd#6313, snapd#6317, snapd#6318, snapd#6320, snapd#6322, snapd#6324, snapd#6325, snapd#6326, snapd#6327, snapd#6329, snapd#6331, snapd#6332
[18:49] <zyga> re :)
[19:20] <mup> PR # closed: core-build#11, core-build#22, core-build#26, core-build#37
[19:21] <mup> PR # opened: core-build#11, core-build#22, core-build#26, core-build#37
=== phoenix_firebrd is now known as murthy
[21:55] <mup> Bug #1810858 opened: Default Snapd installation with SELinux causes AVC failures <Snappy:New> <https://launchpad.net/bugs/1810858>