=== chihchun_afk is now known as chihchun
mborzeckimvo: hi, pushed a small shellcheck fix to #6331 hope you don't mind07:17
mupPR #6331: systemd: allow only a single daemon-reload at the same time <Created by mvo5> <https://github.com/snapcore/snapd/pull/6331>07:17
mvomborzecki: thanks for this!07:19
mvomborzecki: nice fix07:20
mborzeckimvo: shoould have gotten it right when i suggested the change :/07:21
mvomborzecki: no worries07:21
mupPR snapd#6335 closed: tests: fix "No space left on device" issue on amazon-linux <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6335>07:21
mborzeckigreat start of the year: http://seclists.org/oss-sec/2019/q1/5407:28
mborzeckizyga: hey07:32
mupPR snapd#6334 closed: dirs, interfaces/builtin/desktop: system fontconfig cache path is different on Fedora <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6334>07:37
mupPR snapd#6342 opened: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <https://github.com/snapcore/snapd/pull/6342>07:47
=== pstolowski|afk is now known as pstolowski
zygaHey hey08:07
zygaI’ll be around shortly, just finishing coffee08:07
mupPR snapd#6338 closed: cmd/snap: right-align revision and size in info's channel map <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6338>08:32
zygainteresting thing with major/minor08:36
zygamvo: the approval email arrived now (both of them :)08:37
mvozyga: oh, let me see08:41
mvozyga: got them now08:42
zygathank you!08:44
mvozyga: I approved the first one and will reject the other two08:45
zygathank you08:47
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
=== sparkieg` is now known as sparkiegeek
pedronismvo: hi, anything blocking #6331 ?09:25
mupPR #6331: systemd: allow only a single daemon-reload at the same time <Created by mvo5> <https://github.com/snapcore/snapd/pull/6331>09:25
mvopedronis: not really, was just running some tests to see what a sensible number of runs is to trigger the bug (when I revert the fix). but thats not blocking it09:34
mupPR snapd#6331 closed: systemd: allow only a single daemon-reload at the same time <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6331>09:35
mupPR snapd#6339 closed: cmd/snap: only auto-enable unicode to a tty <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6339>09:35
pedronismvo: I was interested in the answer about test for 6339, I don't see John around yet tough09:36
pedronisis he off?09:36
mvopedronis: probably just starting a bit later, I don't think he is off09:36
mvopedronis: I would also really like to poke a bit at the displayChannel revLen, sizeLen thing to see if there is a nice way to disentangle this a little bit09:37
pedronismvo: heh09:37
pedronismvo: doesn't sound like a task you should take on :) but you are the boss09:37
mvopedronis: I know! OCD I guess09:37
mvopedronis: I will need to learn a lot :)09:38
mupPR snapd#6343 opened: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>09:38
mvomborzecki: nice one - is this something we need for 2.37 ?09:39
mborzeckipedronis: how urgent is this change? ^^09:40
mvomborzecki: I think I missed the background for this one (sorry!) - where does the original report come from?09:40
mupPR snapd#6344 opened: cmd/snap-confine: join freezer only after setting up user mount <Per-user mount ns  πŸŽ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6344>09:40
pedronismvo: it's from a mail thread09:41
mborzeckimvo: not sure there is one, there's a trello card though :)09:41
mborzeckimvo: ah, there you go09:41
mvopedronis, mborzecki thanks!09:41
pedronismvo: I can forward you the thread09:41
mvopedronis: how urgent? it looks like a nice drive-by for 2.3709:41
mvopedronis: I'm inclined to take it if we get reviews in time (happy to do one now)09:42
pedronismvo: about 6339, we lost tests indeed (at least afaict playing locally)09:42
mvopedronis: meh, thats a bit sad09:42
mvopedronis: so we need a followup09:42
mupPR snapd#6345 opened: cmd/libsnap: pass --from-snap-confine when callingsnap-update-ns as user <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6345>09:42
pedronismvo: is not urgent in the same that I don't think they can drop '-' for a long while,  it would be good to have it in 18.04.02, which is supposed to happen Feb 7 ?09:43
mvopedronis: if 18.04.2 we better have it in, 2.38 is not going to be there in time09:44
mvopedronis: or we could do a 2.37.1 for it but that seems wasteful if we can have it now. I do a review09:44
pedronismvo: mborzecki: anyway it needs a spread test09:44
pedronis(now we should be able to have one)09:44
mupPR snapd#6346 opened: osutil: add helper for loading fstab from string <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6346>09:49
pedronismvo: I forwarded you the mail for context09:50
mupPR snapd#6347 opened: many: allow snap-update-ns to write user mount profile <Per-user mount ns  πŸŽ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6347>09:51
mvopedronis: thanks09:54
pedronisChipaca: hi, #6339  was merged but afaict we lost a bit of testing about the unicode formatting cases?  it seems only CanUnicode tests consider the true case10:01
mupPR #6339: cmd/snap: only auto-enable unicode to a tty <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6339>10:01
mupPR snapd#6348 opened: snap: split alignment calculation and display for channels <Created by mvo5> <https://github.com/snapcore/snapd/pull/6348>10:09
pedronisChipaca: otoh I removed the blocked on #628010:09
mupPR #6280: cmd/snap: make 'snap warnings' output yamlish <Created by chipaca> <https://github.com/snapcore/snapd/pull/6280>10:09
Chipacapedronis: ah, i was just replying to the first of those10:10
Chipacapedronis: There's a test with --unicode=always, and there's a test that --unicode=auto does the right thing10:10
pedronismvo: not a fan of the structuring of #6348, still prefer what I proposed to John10:11
mupPR #6348: snap: split alignment calculation and display for channels <Created by mvo5> <https://github.com/snapcore/snapd/pull/6348>10:11
mborzeckimvo: i should have the spread test for #6343 up shortly10:13
mvopedronis: maybe I misunderstood your original suggestion. in general I like to split data gathering from the display processing, I feel this makes things easier to read. but maybe that is not your concern?10:13
mupPR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <β›” Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>10:13
pedronismvo: I proposed to encapsulate much more into a struct10:14
mvomborzecki: oh, nice. if its shortly we can take that one too. I just reviewed 634310:14
mborzeckimvo: mhm, saw that, thanks!10:14
pedronismvo: I think John got what I proposed he can comment further, pick it up10:14
mvopedronis: sounds good, reading your comment again I see what you have in mind (I think). that sounds even better. like I said, mostly my OCD to split it a bit more but more encapuslation would be even better of course10:16
pedronismvo: anyway as I said, not sure you should be working on this :)10:16
mvopedronis: do you think a spread test for 6343 is required? I see you added blocked, is that because of the missing spread test?10:16
pedronismvo: yes10:17
mvopedronis: yeah, I shouldn't10:17
mvopedronis: ok10:17
mvopedronis: I will start working on 2.37 now, if 6343 looks good, I can cherry pick it, we need a 2.37~pre1 in any case to see if autopkgtest is happy10:18
pedronismvo: anyway, it needs work10:19
pedronisI mean #634310:19
mupPR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <β›” Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>10:19
pedronisnow that I'm looking at it10:19
pedronismborzecki: some comments to 634310:25
mborzeckipedronis: thanks10:27
zygaI posted some simple branches for qucik review10:27
mupPR snapd#6349 opened: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>10:27
zygaas well as one branch I will work with jdstrand on10:27
zygajdstrand: could you please review https://github.com/snapcore/snapd/pull/6347 -- it is a part of larger pull request https://github.com/snapcore/snapd/pull/6341 broken out for reviewabiliy10:28
mupPR #6347: many: allow snap-update-ns to write user mount profile <Per-user mount ns  πŸŽ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6347>10:28
mupPR #6341: cmd/snap-update-ns: persist per-user mount namespace profile <Created by zyga> <https://github.com/snapcore/snapd/pull/6341>10:28
mupPR snapd#6350 opened: cmd/snap-confine: don't preemptively create .mnt files <Per-user mount ns  πŸŽ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6350>10:34
mborzeckipedronis: just to be clear about your coment, you're suggesting to use the fields in pairs, i.e. cloud_name is set, then we'd use availability_zone regardless of it being set or not (or the value of availability-zone), did i get that right?10:44
=== chihchun is now known as chihchun_afk
pedronismborzecki: yes10:57
mborzeckipedronis: updated, pushed a spread test too11:09
mborzeckiit seems that only ubuntu and amazon linux images have instance data set properly, others either do not use cloud-init or instance data is empty/unset11:10
mupPR snapd#6351 opened: tests: review/fix the autopkgtest failures in disco <Created by mvo5> <https://github.com/snapcore/snapd/pull/6351>11:10
pedronismborzecki: that's fine, as long as we have at least ubuntu11:11
mborzeckialso, gce sets both - and _ names, while amazon only sets _ ones11:12
mborzeckimaybe a diferent version of cloud-init11:12
pedronissuspect so11:13
pedronisbut I thought they didn't drop yet producing both11:13
pedronisthat's why I was very keen of having the spread test11:13
mborzeckiiirc it's set at boot time, i suspect that the engine hands an image that has just _ but cloud-init sets _ and - for compatibility with whatever might be runnning in the image11:14
pedronismborzecki: you are saying there's no cloud-init on the amazon linux one?11:16
pedronisbut the file is there?11:16
mborzeckipedronis: there is11:16
pedronisanyway I need to go have lunch11:16
pedronisI'll look again and we can finesse this then11:16
pstolowskipedronis: i've just pushed updates to hotplug-connect branch11:17
mborzeckimixed that up, amazon uses -, not _, gce does both11:20
greybackzyga: hey, can I book a minute to discuss https://github.com/snapcore/snapd/pull/6281#discussion_r241718332 ?11:49
mupPR #6281: interfaces/builtin: add Multipass interfaces <Created by gerboland> <https://github.com/snapcore/snapd/pull/6281>11:49
zygagreyback: I was thinking about using the kmod backend11:49
zygagreyback: where snapd does the modprobe fore you11:49
greybackzyga: oh, this is new to me.11:50
zygalet me show you an example11:50
greybackthat simple, huh? nice11:51
zygayou just declare the modules you want when an interface is connected11:51
greybacksweet, I'll use that11:51
zygagreat, thank you :)11:51
zygaI reproduced this dreaded issue:12:11
pstolowskimvo: hey, can you take a look at #6113 when you have some time?12:13
zygathere's no /var/snap in core16!12:13
mupPR #6113: overlord/ifacestate: handler for hotplug-connect task <Hotplug πŸ”Œ> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6113>12:13
mvopstolowski: I put it on my mlist12:14
Chipacazyga: in which core 16?12:15
zygaChipaca: inspecting12:15
pedronispstolowski: thank, will look again at thos hotplug PRs once done with 2.37 stuff12:15
zygawe just get core16 from edge12:15
Chipacaah, actual core1612:15
zygait's failing randomly all day for me12:15
pstolowskipedronis: sure, thanks12:16
mvozyga: hm, core16 should have that, let me double check12:16
Chipacazyga: hmm12:16
zygamvo: I have a snap that does not12:16
mborzeckizyga: https://github.com/snapcore/snapd/pull/6350#issuecomment-453075903 ?12:16
mupPR #6350: cmd/snap-confine: don't preemptively create .mnt files <Per-user mount ns  πŸŽ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6350>12:16
mborzeckiah, i see you already noticed12:16
mvozyga: which version?12:16
mvozyga: I mean which rev and version?12:16
zygais that expected? 2018 september is kind of old12:16
mvozyga: looking12:17
Chipacai386 core16 on edge has no /var/snap12:17
mvozyga: I triggered a new build from edge12:17
zygamvo: thank you12:17
zygahow come this ever passed?12:17
zygathis is the list of files in that snap12:18
Chipacaamd64 is fine tho12:18
mvozyga, Chipaca the versions are all a bit inconsistent, I triggered a new build with that they should be all in sync again12:19
zygathank you12:19
zygawas it built recently?12:19
zygarevision is kind of low12:19
zygabut perhaps/12:19
zygaI'm trying to understand why it fails12:19
pedronismborzecki: +1 for #6343 with a comment about the spread test tough12:20
mupPR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <β›” Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>12:20
mvozyga: I looked at this earlier today as it failed in autopkgtest on s390x, I think while trying to make sure all versions are vaguely correct I promoted the wrong one12:20
mvozyga: but looking at the versions there is no right one right now :(12:20
zygaaha so you were changing the published revision?12:21
zygaI wish snapcraft had publishing history like git12:21
mborzeckizyga: left a litle comment under #634912:22
mupPR #6349: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>12:22
zygamvo: I don't understand why it only sometimes failed12:23
Chipacazyga: mvo: pedronis: https://pastebin.ubuntu.com/p/Z2BJDqjVRS/12:23
pedronisChipaca: :)12:24
Chipacathose all seem very recent12:24
zygaChipaca: I like the idea, can nitpick on the syntax12:24
mborzeckiChipaca: nice12:24
mborzeckiChipaca: is it still valid yaml?12:24
zygaChipaca: how about channels:\n\t<arch>\n\t\tlatest/stable: ...12:24
Chipacathis was a quick hack just to see what was released where :-)12:24
Chipacamborzecki: probably :-)12:25
pedroniszyga: yea, I expect some back and both on the options and the output12:25
pedronis*back and forth12:25
Chipacamborzecki: http://yaml-online-parser.appspot.com/ thinks it is12:25
Chipacazyga: mvo: strangely enough the released-at is all today, but the version numbers are all over the place12:26
mvoChipaca: yeah, I tried to publish a consistent set today12:28
mvoChipaca: which did not work well, so the released-at is correct12:28
mvoChipaca: and its such a nice feature!12:28
Chipacayou can thank sabdfl for that one :-)12:29
* mvo thanks him12:29
* Chipaca thinks you can probably thank him for the whole thing, while you're at it12:29
mvoChipaca: which reminds me, did you update the bug to fix-commited yet :) ?12:29
* mvo thanks him some more12:29
pedronishe did12:29
ChipacaI did :-)12:29
pedronismborzecki: does my comment on the spread test make sense?12:34
mborzeckipedronis: wonder how much it depends on the cloud provider, nonetheless, the file is there in 16.04+ instances, so ensuring the test runs actually somewhere sgtm12:39
pedronismborzecki: yea, but the cloud provider we nail with backend check12:46
pedroniss/backend check/the backend constraint/12:46
mborzeckipedronis: it's pinned to backends: [google] atm12:46
pedronisyes, that's what I mean12:47
pedronisso my hope is that  google  x ubuntu (classic)  should work12:47
pedronisat a minimum12:47
mborzeckipedronis: instance data is also set in core-16 images too, only 14.04 is missing out12:48
pedronismborzecki: ok, should also be on core1812:48
pedronisbut anyway12:48
pedronislet's indeed do all ubuntus where it seems to work12:48
pedronismborzecki: also the red tests is because of a typo apparently12:49
zygamborzecki: updated https://github.com/snapcore/snapd/pull/6349 :)13:02
mupPR #6349: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>13:02
mborzeckizyga: thanks, will take a look13:02
mborzeckioff to pick up the kids13:03
jdstrandzyga: yes, I plan to go through that and the others I've been asked to look at today/tomorrow13:07
zygathank you13:07
mupPR snapcraft#2434 closed: rust plugin: refactor to use the latest rustup <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2434>13:10
mupPR snapd#6352 opened: many: remove .user-fstab files from /run/snapd/ns <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6352>13:17
Chipacapedronis: would a spread test be enough to cover the rererefresh case?13:20
pedronisChipaca: we need to talk, I'm in a meeting13:20
Chipacapedronis: ok13:20
Chipacai'll go have lunch13:20
=== ricab is now known as ricab|lunch
mupPR snapd#6353 opened: cmd/snap-update-ns: move existing code around, renaming some functions <Created by zyga> <https://github.com/snapcore/snapd/pull/6353>13:22
zygaI pushed one long but simple branch that just splits bigger file into focused chunks13:23
mborzeckihm, under spread, jq is available in core-18 images but not in core-1613:50
mborzeckior am i missing something there?13:51
pedronismborzecki: it's installed as a snap under core afaik13:51
pedronisyou can find the installation in some prepare code I think13:51
pedronismaybe the code checks core but not core 18 atm13:51
pedronisor the reverse13:51
mborzeckiand now travis seems to be slow to start spread jobs https://travis-ci.org/snapcore/snapd/builds/477815742?utm_source=github_status&utm_medium=notification heh14:04
mvomborzecki: yeah, quite a bit of delay in spread right now :/14:05
mvo(well travis to be fair)14:06
Chipacazyga: https://forum.snapcraft.io/t/tried-to-install-quelea-presentation-software-from-chrome-linux-beta/9247?u=chipaca dunno if you're the right person to answer here but ogra seems to think so :)14:15
ograChipaca, well, sorry ... zyga already told  me he has no idea about chromeos support ... i didnt forward that to the forum post14:16
ograbut yeah, zyga being the "foreign distro ambassador" in the team, i thought he might know :)14:17
zygaI don't have a chromebook anymore14:17
zygaand AFAIK only some recent chromebooks can run lxd14:17
zygaand thus run snaps14:17
zygabut I have 0 knowledge about how that works14:17
zygaor what's the nesting story14:18
ograeven then i bet it is doubtful becase of lacking kernel features14:18
zygadunno :)14:20
zygajdstrand: replied on the permission topic14:21
zygajdstrand: it's really about go vs c logic14:21
zygajdstrand: one thing we might do is to open the fd while still in C14:21
zygajdstrand: but I don't really think that warrants the extra logic today14:21
Chipacazyga: even replying "I don't know and this is why I don't know" would be helpful14:22
zygamvo: so based on what you said, can we merge https://github.com/snapcore/snapd/pull/6294 now?14:24
mupPR #6294: packaging/ubuntu: build with golang 1.10 <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/6294>14:24
mvozyga: yeah, maybe early next week but in theory we could do so *now*14:26
Chipacazyga: missing on that PR: move the travis unit tests to run with 1.9 instead of 1.614:27
Chipacazyga: I can push that change14:27
zygaChipaca: oooh, indeed14:28
zygaChipaca: if you can please do14:28
mborzeckican't wait to get rid of the 1.6 gofmt wrappers that I have now14:36
Chipacamborzecki: next you'll be wanting generics or whatever they're getting called14:38
mborzeckihaha :P14:38
mborzeckiChipaca: wouldn't mind pattern matching in go 2 tho14:39
Chipacaare we getting pattern matching as well? i missed that bit14:39
* cachio lunch14:39
pedronisI think the improvements to error wrapping are probably the most interesting bit for us14:40
mborzeckiChipaca: afaik no14:40
mborzeckipedronis: we could use github.com/pkg/errors for this now14:40
pedronismborzecki: it's not about our errors usually14:40
pedronismore about the std lib ones14:41
pedronisespecially networking ones14:41
pedronismborzecki: I'm talking about the contorsions our retry code does for example14:41
mborzeckibtw. did they sort out the context for io interfaces?14:41
mborzeckimvo: about jq https://paste.ubuntu.com/p/YGPvF65wFJ/14:47
mvomborzecki: hm, interessting14:47
=== ricab|lunch is now known as ricab
mborzeckimvo: changes: https://paste.ubuntu.com/p/GphB7jj8Gd/ up to change 8 it's all prepare, change 9 is caused by prepare section of the cloud-init test14:49
zygamvo, mborzecki we install jq in prepare14:49
mborzeckizyga: but it's removed later on14:49
zygamborzecki: grep for jq in the tests/lib section14:49
zygadisable_refreshes needs it14:50
zygai see now14:50
mborzeckizyga: right, but it's removed just below14:50
zygano idea now14:53
pedronismborzecki: mvo: fwiw I just double checked, there is no jq in core18 itself14:55
pedronisat least not in stable14:55
mborzeckipedronis: not in edge either14:56
mborzeckiwaiting for vanilla core18/16 instances to boot and will check there14:56
mborzeckihm no clue15:07
mupPR snapcraft#2435 opened: Appstream desktop <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2435>15:07
mupPR snapcraft#2436 opened: snap: add build-package for xml <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2436>15:13
zygamborzecki, mvo: can I please get a review for https://github.com/snapcore/snapd/pull/635315:20
zygait will let me propose the rest once merfed15:20
mupPR #6353: cmd/snap-update-ns: move existing code around, renaming some functions <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6353>15:20
pedronisdegville: I posted some comments to the doc update PR15:27
pedronisthanks for working on that15:27
degvillepedronis: no problem - thanks, just looking at the comments now.15:28
pedronismvo: you probably want to give it a pass too15:28
plarsogra: hi! Do you think there's any chance the pi core images could ever work booting from USB (at least on pi3b+)? I know they don't currently, and I saw the previous discussion about this with a hacked uEnv.txt that would work temporarily, but I was looking for something that wouldn't break once kernels get updated over time15:33
pedronisChipaca: did you see cachio answer here? #612115:34
mupPR #6121: tests: new test for snapshots with more than 1 user <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6121>15:34
Chipacapedronis: I'll look now15:35
Chipacapedronis: meanwhile, am I holding it wrong, in https://pastebin.ubuntu.com/p/dtZJJhshkS/ ?15:35
Chipacapedronis: the coutner task isn't run and I'm wondering why15:36
mvopedronis: yeah, I have a look in a wee bit, just one more 2.37 push15:37
mupPR snapd#6121 closed: tests: new test for snapshots with more than 1 user <Created by sergiocazzolato> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6121>15:37
pedronisChipaca: you do only one Ensure, why should it run?15:37
pedronisanyway doing just one Ensure is what you probably15:37
pedronisand just check the task is there, not run15:37
pedroniss/probably/probably want/15:38
Chipacapedronis: rerefresh does a st.EnsureBefore(0)15:38
pedronisChipaca: that's relevant only if run Loop15:38
pedronisif you run Loop15:38
pedronisor Settle15:38
pedronisindeed usually it explodes15:38
pedronisif you don't do one of those15:39
pedronisthough if usually mock it because of that15:39
ChipacaI guess I'll look at the tasks then :-)15:39
pedronisChipaca: yes15:39
pedronisChipaca: the auto-connect tests in ifacestate are probably a good inspiration15:39
pedronisI think15:39
pedronisin case15:39
pedronis(similar kind of task that creates more tasks)15:39
ograplars, this should work since ages (if you turned usb booting on in the firmware)15:42
plarsogra: I didn't think anything should be needed on b+, but it doesn't work for me there. What else would I need to do? It does work to boot a usb stick with something like raspbian, but on core 18 and 16 images it does not. So I know the device is capable of it15:44
ograwell, thats a bug then ... it should definitely work on core 16 ... i forgot when abeato did the PR for USB boot, but thats surely already a year in there15:45
abeatoogra, yes, it has been there for a while. I tested it with an rpi3, no idea if something has changed in the b+15:48
zygabreak now, feeling sleepy15:48
ograas long as you did the HW switching to enable USB it should just work ... if not, thats a bug15:49
plarsabeato: and you didn't need anything on an sd card to make it work? Just the core image written to a usb stick?15:49
plarsI will double-check with my b+ and try on the earlier pi3 also15:49
ograplars, right, thats the purpose of the HW hack15:49
abeatoplars, yes, the raw image on the stick should work15:50
ograUSB becomes a normal boot device permanenently once you toggled it ... and you cant revert that15:50
plarsneato, if that works, I have another possibility for getting some better provisioning working15:50
ograplars, let me know if it doesnt, then we can research15:51
plarsusb toggle it how? with program_usb_boot_mode=1 in config.txt?15:51
ograyes, and then turning that off again after one boot ... it burns a fuse on the board and makes it permanently boot from USB alongside SD15:52
abeatoplars, to force the toggle (HW fuses I guess) I had to install raspbian and follow the intructions that are around15:52
ograplars, thats the code that should make it work: https://github.com/snapcore/pi-gadget/blob/master/uboot3.patch#L1915:55
ogra(oh, thats the universal gadget that works on all pi's ... the pi3 specific one (which core16 still uses i think) is at https://github.com/snapcore/pi3-gadget/blob/master/uboot.patch#L21 )15:57
threshhmm the visual distinction in the store metrics page isnt very good: http://thre.sh/stuff/vlc-stats-snap-weird.png16:08
=== cpaelzer_ is now known as cpaelzer
pedronismvo: did you see my question about 18-cm3 vs 18-pi3 ?16:24
mvopedronis: let me check16:31
mvopedronis: replied16:32
pedronismborzecki: it's a bit strange to add /connections end point that return something that has just top-level  plugs and slots16:37
mupPR snapd#6354 opened: overlord: drop old v1 store api support from managers test <Simple πŸ˜ƒ> <Created by chipaca> <https://github.com/snapcore/snapd/pull/6354>16:42
Chipaca^ i'm rebasing rerefresh on this as it simplifies the added complexity of epochs in the managers test16:42
pedronismborzecki: we should brainstorm a bit16:43
mvo6351 and 6342 need a second review17:06
* mvo dinner17:06
pedronismvo: #6343 is green, you might want to re-look tough because it has changed a bit17:19
mupPR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>17:19
pedronismvo: youd didn't actually vote on #634217:24
mupPR #6342: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <https://github.com/snapcore/snapd/pull/6342>17:24
pedronisdegville: there is still a place that needs s/-cm3/-pi3/, left a comment17:30
degvillepedronis: ah, got it. thanks - sorry I missed it.17:31
pedronisChipaca: +1, thank you17:32
zygamvo: I pushed more to https://github.com/snapcore/snapd/pull/6342#pullrequestreview-19132829817:35
mupPR #6342: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <https://github.com/snapcore/snapd/pull/6342>17:35
zygahttps://github.com/snapcore/base-18/issues needs gardening17:36
zygaseems like we never touched the set of issues I made after we started working on core1817:36
zygahttps://github.com/snapcore/snapd/pull/6349 needs a 2nd review17:36
mupPR #6349: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>17:36
zygahttps://github.com/snapcore/snapd/pull/6350 also needs a 2nd review17:37
mupPR #6350: cmd/snap-confine: don't preemptively create .mnt files <Per-user mount ns  πŸŽ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6350>17:37
mupPR snapd#6354 closed: overlord: drop old v1 store api support from managers test <Simple πŸ˜ƒ> <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6354>17:55
mvopedronis: thanks, re-reviewed and also updated the tests PR18:10
mvozyga: thanks for the extra grep and fixing!18:10
=== pstolowski is now known as pstolowski|afk
mborzeckipedronis: let's meet in the morning, i tried to reuse much of the code that was there, but there's definitely room for improvements18:39
zygamvo: +1 to merge https://github.com/snapcore/snapd/pull/6294 now?18:42
mupPR #6294: packaging/ubuntu: build with golang 1.10 <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/6294>18:42
mvozyga: if it helps you now then yes, otherwise I would prefer monday18:43
zygamvo: monday then :)18:47
zygamvo: if you have a moment I would love to land https://github.com/snapcore/snapd/pull/6353 as I can then propose the refactoring18:47
cachiomvo, do you know when sru will be ready?18:47
mupPR #6353: cmd/snap-update-ns: move existing code around, renaming some functions <Per-user mount ns  πŸŽ> <Simple πŸ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6353>18:47
cachiomvo, can I help?18:47
mvocachio: probably not today :( still waiting for two PRs to run through travis18:50
mvocachio: so you can relax and work on something else, no need to wait for this18:50
cachiomvo, ok18:51
pedronismvo: we can merge 6343 then, right?18:51
mvopedronis: yes, I can have a second look but yes, thats fine, I will cherry pick18:52
pedronismvo: I let you merge it18:53
pedronisI approved the tests one18:53
mvopedronis: you had one question (exit 0 vs exit 1) in there, should we do this via a follwup?18:54
pedronismvo: where?18:54
mvopedronis: https://github.com/snapcore/snapd/pull/6343/files#r24673770818:55
mupPR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>18:55
pedronismvo: it was addressed, it's just github confused18:55
mvopedronis: ok18:55
pedronisbecause the line I commented on is still there18:55
pedronismvo: see line 20-  in the test18:56
mvopedronis: +118:56
mupPR snapcraft#2436 closed: snap: add build-package for xml <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2436>19:11
mupPR snapd#6342 closed: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6342>19:55
mupPR snapd#6351 closed: tests: review/fix the autopkgtest failures in disco <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6351>19:55
mupPR snapd#6343 closed: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6343>19:58
mupPR snapd#6355 opened: release: 2.37~pre1 <Created by mvo5> <https://github.com/snapcore/snapd/pull/6355>20:06
tewardis there someone who can field a concern about snapcraft store, malware, security, and privacy?20:27
popeyteward: wassup?21:23
tewardpopey: PM?21:23

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!