[06:00] <mborzecki> morning
[07:17] <mborzecki> mvo: hi, pushed a small shellcheck fix to #6331 hope you don't mind
[07:17] <mup> PR #6331: systemd: allow only a single daemon-reload at the same time <Created by mvo5> <https://github.com/snapcore/snapd/pull/6331>
[07:19] <mvo> mborzecki: thanks for this!
[07:20] <mvo> mborzecki: nice fix
[07:21] <mborzecki> mvo: shoould have gotten it right when i suggested the change :/
[07:21] <mvo> mborzecki: no worries
[07:21] <mup> PR snapd#6335 closed: tests: fix "No space left on device" issue on amazon-linux <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6335>
[07:28] <mborzecki> great start of the year: http://seclists.org/oss-sec/2019/q1/54
[07:31] <zyga> Hello
[07:32] <mborzecki> zyga: hey
[07:37] <mup> PR snapd#6334 closed: dirs, interfaces/builtin/desktop: system fontconfig cache path is different on Fedora <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6334>
[07:47] <mup> PR snapd#6342 opened: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <https://github.com/snapcore/snapd/pull/6342>
[08:04] <pstolowski> morning
[08:07] <zyga> Hey hey
[08:07] <zyga> I’ll be around shortly, just finishing coffee
[08:32] <mup> PR snapd#6338 closed: cmd/snap: right-align revision and size in info's channel map <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6338>
[08:36] <zyga> interesting thing with major/minor
[08:37] <zyga> mvo: the approval email arrived now (both of them :)
[08:41] <mvo> zyga: oh, let me see
[08:42] <mvo> zyga: got them now
[08:44] <zyga> thank you!
[08:45] <mvo> zyga: I approved the first one and will reject the other two
[08:47] <zyga> thank you
[09:15] <zyga> brb
[09:25] <pedronis> mvo: hi, anything blocking #6331 ?
[09:25] <mup> PR #6331: systemd: allow only a single daemon-reload at the same time <Created by mvo5> <https://github.com/snapcore/snapd/pull/6331>
[09:34] <mvo> pedronis: not really, was just running some tests to see what a sensible number of runs is to trigger the bug (when I revert the fix). but thats not blocking it
[09:35] <mup> PR snapd#6331 closed: systemd: allow only a single daemon-reload at the same time <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6331>
[09:35] <mup> PR snapd#6339 closed: cmd/snap: only auto-enable unicode to a tty <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6339>
[09:36] <pedronis> mvo: I was interested in the answer about test for 6339, I don't see John around yet tough
[09:36] <pedronis> is he off?
[09:36] <mvo> pedronis: probably just starting a bit later, I don't think he is off
[09:37] <mvo> pedronis: I would also really like to poke a bit at the displayChannel revLen, sizeLen thing to see if there is a nice way to disentangle this a little bit
[09:37] <pedronis> mvo: heh
[09:37] <pedronis> mvo: doesn't sound like a task you should take on :) but you are the boss
[09:37] <mvo> pedronis: I know! OCD I guess
[09:38] <mvo> pedronis: I will need to learn a lot :)
[09:38] <mup> PR snapd#6343 opened: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>
[09:39] <mvo> mborzecki: nice one - is this something we need for 2.37 ?
[09:40] <mborzecki> pedronis: how urgent is this change? ^^
[09:40] <mvo> mborzecki: I think I missed the background for this one (sorry!) - where does the original report come from?
[09:40] <mup> PR snapd#6344 opened: cmd/snap-confine: join freezer only after setting up user mount <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6344>
[09:41] <pedronis> mvo: it's from a mail thread
[09:41] <mborzecki> mvo: not sure there is one, there's a trello card though :)
[09:41] <mborzecki> mvo: ah, there you go
[09:41] <mvo> pedronis, mborzecki thanks!
[09:41] <pedronis> mvo: I can forward you the thread
[09:41] <mvo> pedronis: how urgent? it looks like a nice drive-by for 2.37
[09:42] <mvo> pedronis: I'm inclined to take it if we get reviews in time (happy to do one now)
[09:42] <pedronis> mvo: about 6339, we lost tests indeed (at least afaict playing locally)
[09:42] <mvo> pedronis: meh, thats a bit sad
[09:42] <mvo> pedronis: so we need a followup
[09:42] <mup> PR snapd#6345 opened: cmd/libsnap: pass --from-snap-confine when callingsnap-update-ns as user <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6345>
[09:43] <pedronis> mvo: is not urgent in the same that I don't think they can drop '-' for a long while,  it would be good to have it in 18.04.02, which is supposed to happen Feb 7 ?
[09:44] <pedronis> s/same/sense/
[09:44] <mvo> pedronis: if 18.04.2 we better have it in, 2.38 is not going to be there in time
[09:44] <mvo> pedronis: or we could do a 2.37.1 for it but that seems wasteful if we can have it now. I do a review
[09:44] <pedronis> mvo: mborzecki: anyway it needs a spread test
[09:44] <pedronis> (now we should be able to have one)
[09:49] <mup> PR snapd#6346 opened: osutil: add helper for loading fstab from string <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6346>
[09:50] <pedronis> mvo: I forwarded you the mail for context
[09:51] <mup> PR snapd#6347 opened: many: allow snap-update-ns to write user mount profile <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6347>
[09:54] <mvo> pedronis: thanks
[10:01] <pedronis> Chipaca: hi, #6339  was merged but afaict we lost a bit of testing about the unicode formatting cases?  it seems only CanUnicode tests consider the true case
[10:01] <mup> PR #6339: cmd/snap: only auto-enable unicode to a tty <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6339>
[10:09] <mup> PR snapd#6348 opened: snap: split alignment calculation and display for channels <Created by mvo5> <https://github.com/snapcore/snapd/pull/6348>
[10:09] <pedronis> Chipaca: otoh I removed the blocked on #6280
[10:09] <mup> PR #6280: cmd/snap: make 'snap warnings' output yamlish <Created by chipaca> <https://github.com/snapcore/snapd/pull/6280>
[10:10] <Chipaca> pedronis: ah, i was just replying to the first of those
[10:10] <Chipaca> pedronis: There's a test with --unicode=always, and there's a test that --unicode=auto does the right thing
[10:11] <pedronis> mvo: not a fan of the structuring of #6348, still prefer what I proposed to John
[10:11] <mup> PR #6348: snap: split alignment calculation and display for channels <Created by mvo5> <https://github.com/snapcore/snapd/pull/6348>
[10:13] <mborzecki> mvo: i should have the spread test for #6343 up shortly
[10:13] <mvo> pedronis: maybe I misunderstood your original suggestion. in general I like to split data gathering from the display processing, I feel this makes things easier to read. but maybe that is not your concern?
[10:13] <mup> PR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>
[10:14] <pedronis> mvo: I proposed to encapsulate much more into a struct
[10:14] <mvo> mborzecki: oh, nice. if its shortly we can take that one too. I just reviewed 6343
[10:14] <mborzecki> mvo: mhm, saw that, thanks!
[10:14] <pedronis> mvo: I think John got what I proposed he can comment further, pick it up
[10:16] <mvo> pedronis: sounds good, reading your comment again I see what you have in mind (I think). that sounds even better. like I said, mostly my OCD to split it a bit more but more encapuslation would be even better of course
[10:16] <pedronis> mvo: anyway as I said, not sure you should be working on this :)
[10:16] <mvo> pedronis: do you think a spread test for 6343 is required? I see you added blocked, is that because of the missing spread test?
[10:17] <pedronis> mvo: yes
[10:17] <mvo> pedronis: yeah, I shouldn't
[10:17] <mvo> pedronis: ok
[10:18] <mvo> pedronis: I will start working on 2.37 now, if 6343 looks good, I can cherry pick it, we need a 2.37~pre1 in any case to see if autopkgtest is happy
[10:19] <pedronis> mvo: anyway, it needs work
[10:19] <pedronis> I mean #6343
[10:19] <mup> PR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>
[10:19] <pedronis> now that I'm looking at it
[10:25] <pedronis> mborzecki: some comments to 6343
[10:27] <mborzecki> pedronis: thanks
[10:27] <zyga> I posted some simple branches for qucik review
[10:27] <mup> PR snapd#6349 opened: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>
[10:27] <zyga> as well as one branch I will work with jdstrand on
[10:28] <zyga> jdstrand: could you please review https://github.com/snapcore/snapd/pull/6347 -- it is a part of larger pull request https://github.com/snapcore/snapd/pull/6341 broken out for reviewabiliy
[10:28] <mup> PR #6347: many: allow snap-update-ns to write user mount profile <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6347>
[10:28] <mup> PR #6341: cmd/snap-update-ns: persist per-user mount namespace profile <Created by zyga> <https://github.com/snapcore/snapd/pull/6341>
[10:34] <mup> PR snapd#6350 opened: cmd/snap-confine: don't preemptively create .mnt files <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6350>
[10:44] <mborzecki> pedronis: just to be clear about your coment, you're suggesting to use the fields in pairs, i.e. cloud_name is set, then we'd use availability_zone regardless of it being set or not (or the value of availability-zone), did i get that right?
[10:57] <pedronis> mborzecki: yes
[10:57] <mborzecki> ack
[11:09] <mborzecki> pedronis: updated, pushed a spread test too
[11:10] <mborzecki> it seems that only ubuntu and amazon linux images have instance data set properly, others either do not use cloud-init or instance data is empty/unset
[11:10] <mup> PR snapd#6351 opened: tests: review/fix the autopkgtest failures in disco <Created by mvo5> <https://github.com/snapcore/snapd/pull/6351>
[11:11] <pedronis> mborzecki: that's fine, as long as we have at least ubuntu
[11:12] <mborzecki> also, gce sets both - and _ names, while amazon only sets _ ones
[11:12] <pedronis> interesting
[11:12] <mborzecki> maybe a diferent version of cloud-init
[11:13] <pedronis> suspect so
[11:13] <pedronis> but I thought they didn't drop yet producing both
[11:13] <pedronis> anyway
[11:13] <pedronis> that's why I was very keen of having the spread test
[11:14] <mborzecki> iirc it's set at boot time, i suspect that the engine hands an image that has just _ but cloud-init sets _ and - for compatibility with whatever might be runnning in the image
[11:16] <pedronis> mborzecki: you are saying there's no cloud-init on the amazon linux one?
[11:16] <pedronis> but the file is there?
[11:16] <mborzecki> pedronis: there is
[11:16] <pedronis> anyway I need to go have lunch
[11:16] <pedronis> I'll look again and we can finesse this then
[11:17] <pstolowski> pedronis: i've just pushed updates to hotplug-connect branch
[11:20] <mborzecki> mixed that up, amazon uses -, not _, gce does both
[11:49] <greyback> zyga: hey, can I book a minute to discuss https://github.com/snapcore/snapd/pull/6281#discussion_r241718332 ?
[11:49] <mup> PR #6281: interfaces/builtin: add Multipass interfaces <Created by gerboland> <https://github.com/snapcore/snapd/pull/6281>
[11:49] <zyga> hey!
[11:49] <zyga> looking
[11:49] <zyga> greyback: I was thinking about using the kmod backend
[11:49] <zyga> greyback: where snapd does the modprobe fore you
[11:49] <zyga> *for
[11:50] <greyback> zyga: oh, this is new to me.
[11:50] <zyga> let me show you an example
[11:50] <greyback> please
[11:50] <zyga> https://github.com/snapcore/snapd/blob/master/interfaces/builtin/firewall_control.go#L156
[11:51] <greyback> that simple, huh? nice
[11:51] <zyga> you just declare the modules you want when an interface is connected
[11:51] <zyga> presto
[11:51] <zyga> yep
[11:51] <greyback> sweet, I'll use that
[11:51] <greyback> thanks!
[11:51] <zyga> great, thank you :)
[12:11] <zyga> whee
[12:11] <zyga> I reproduced this dreaded issue:
[12:11] <zyga> https://www.irccloud.com/pastebin/WAm6nIiD/
[12:13] <zyga> https://www.irccloud.com/pastebin/HfXBv3XJ/
[12:13] <zyga> indeed!
[12:13] <pstolowski> mvo: hey, can you take a look at #6113 when you have some time?
[12:13] <zyga> there's no /var/snap in core16!
[12:13] <zyga> hmmm
[12:13] <mup> PR #6113: overlord/ifacestate: handler for hotplug-connect task <Hotplug 🔌> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6113>
[12:14] <mvo> pstolowski: I put it on my mlist
[12:15] <Chipaca> zyga: in which core 16?
[12:15] <zyga> Chipaca: inspecting
[12:15] <pedronis> pstolowski: thank, will look again at thos hotplug PRs once done with 2.37 stuff
[12:15] <zyga> we just get core16 from edge
[12:15] <Chipaca> ah, actual core16
[12:15] <zyga> it's failing randomly all day for me
[12:16] <pstolowski> pedronis: sure, thanks
[12:16] <mvo> zyga: hm, core16 should have that, let me double check
[12:16] <Chipaca> zyga: hmm
[12:16] <zyga> mvo: I have a snap that does not
[12:16] <mborzecki> zyga: https://github.com/snapcore/snapd/pull/6350#issuecomment-453075903 ?
[12:16] <mup> PR #6350: cmd/snap-confine: don't preemptively create .mnt files <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6350>
[12:16] <mborzecki> ah, i see you already noticed
[12:16] <mvo> zyga: which version?
[12:16] <mvo> zyga: I mean which rev and version?
[12:16] <zyga> https://www.irccloud.com/pastebin/fA0Okwbn/
[12:16] <zyga> is that expected? 2018 september is kind of old
[12:17] <mvo> zyga: looking
[12:17] <Chipaca> confirmed
[12:17] <Chipaca> i386 core16 on edge has no /var/snap
[12:17] <mvo> zyga: I triggered a new build from edge
[12:17] <zyga> http://paste.ubuntu.com/p/yyq8FFKPnY/
[12:17] <zyga> mvo: thank you
[12:17] <zyga> how come this ever passed?
[12:18] <zyga> this is the list of files in that snap
[12:18] <Chipaca> amd64 is fine tho
[12:19] <mvo> zyga, Chipaca the versions are all a bit inconsistent, I triggered a new build with that they should be all in sync again
[12:19] <zyga> thank you
[12:19] <zyga> was it built recently?
[12:19] <zyga> revision is kind of low
[12:19] <zyga> but perhaps/
[12:19] <zyga> I'm trying to understand why it fails
[12:20] <pedronis> mborzecki: +1 for #6343 with a comment about the spread test tough
[12:20] <mup> PR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>
[12:20] <mvo> zyga: I looked at this earlier today as it failed in autopkgtest on s390x, I think while trying to make sure all versions are vaguely correct I promoted the wrong one
[12:20] <mvo> zyga: but looking at the versions there is no right one right now :(
[12:21] <zyga> aha so you were changing the published revision?
[12:21] <zyga> I wish snapcraft had publishing history like git
[12:22] <mborzecki> zyga: left a litle comment under #6349
[12:22] <mup> PR #6349: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>
[12:23] <zyga> mvo: I don't understand why it only sometimes failed
[12:23] <Chipaca> zyga: mvo: pedronis: https://pastebin.ubuntu.com/p/Z2BJDqjVRS/
[12:24] <pedronis> Chipaca: :)
[12:24] <Chipaca> those all seem very recent
[12:24] <zyga> Chipaca: I like the idea, can nitpick on the syntax
[12:24] <mborzecki> Chipaca: nice
[12:24] <mborzecki> Chipaca: is it still valid yaml?
[12:24] <zyga> Chipaca: how about channels:\n\t<arch>\n\t\tlatest/stable: ...
[12:24] <Chipaca> this was a quick hack just to see what was released where :-)
[12:25] <Chipaca> mborzecki: probably :-)
[12:25] <pedronis> zyga: yea, I expect some back and both on the options and the output
[12:25] <pedronis> *back and forth
[12:25] <Chipaca> mborzecki: http://yaml-online-parser.appspot.com/ thinks it is
[12:26] <Chipaca> zyga: mvo: strangely enough the released-at is all today, but the version numbers are all over the place
[12:28] <mvo> Chipaca: yeah, I tried to publish a consistent set today
[12:28] <mvo> Chipaca: which did not work well, so the released-at is correct
[12:28] <mvo> Chipaca: and its such a nice feature!
[12:28] <Chipaca> heh
[12:29] <Chipaca> you can thank sabdfl for that one :-)
[12:29]  * mvo thanks him
[12:29]  * Chipaca thinks you can probably thank him for the whole thing, while you're at it
[12:29] <mvo> Chipaca: which reminds me, did you update the bug to fix-commited yet :) ?
[12:29]  * mvo thanks him some more
[12:29] <pedronis> he did
[12:29] <Chipaca> I did :-)
[12:34] <pedronis> mborzecki: does my comment on the spread test make sense?
[12:39] <mborzecki> pedronis: wonder how much it depends on the cloud provider, nonetheless, the file is there in 16.04+ instances, so ensuring the test runs actually somewhere sgtm
[12:46] <pedronis> mborzecki: yea, but the cloud provider we nail with backend check
[12:46] <pedronis> s/backend check/the backend constraint/
[12:46] <mborzecki> pedronis: it's pinned to backends: [google] atm
[12:47] <pedronis> yes, that's what I mean
[12:47] <pedronis> so my hope is that  google  x ubuntu (classic)  should work
[12:47] <pedronis> at a minimum
[12:48] <mborzecki> pedronis: instance data is also set in core-16 images too, only 14.04 is missing out
[12:48] <pedronis> mborzecki: ok, should also be on core18
[12:48] <pedronis> but anyway
[12:48] <pedronis> let's indeed do all ubuntus where it seems to work
[12:49] <pedronis> mborzecki: also the red tests is because of a typo apparently
[13:02] <zyga> mborzecki: updated https://github.com/snapcore/snapd/pull/6349 :)
[13:02] <mup> PR #6349: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>
[13:02] <mborzecki> zyga: thanks, will take a look
[13:03] <mborzecki> off to pick up the kids
[13:07] <jdstrand> zyga: yes, I plan to go through that and the others I've been asked to look at today/tomorrow
[13:07] <zyga> thank you
[13:10] <mup> PR snapcraft#2434 closed: rust plugin: refactor to use the latest rustup <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2434>
[13:17] <mup> PR snapd#6352 opened: many: remove .user-fstab files from /run/snapd/ns <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6352>
[13:20] <Chipaca> pedronis: would a spread test be enough to cover the rererefresh case?
[13:20] <Chipaca> :-|
[13:20] <pedronis> Chipaca: we need to talk, I'm in a meeting
[13:20] <Chipaca> pedronis: ok
[13:20] <Chipaca> i'll go have lunch
[13:22] <mup> PR snapd#6353 opened: cmd/snap-update-ns: move existing code around, renaming some functions <Created by zyga> <https://github.com/snapcore/snapd/pull/6353>
[13:23] <zyga> I pushed one long but simple branch that just splits bigger file into focused chunks
[13:50] <mborzecki> hm, under spread, jq is available in core-18 images but not in core-16
[13:51] <mborzecki> or am i missing something there?
[13:51] <pedronis> mborzecki: it's installed as a snap under core afaik
[13:51] <pedronis> you can find the installation in some prepare code I think
[13:51] <pedronis> maybe the code checks core but not core 18 atm
[13:51] <pedronis> or the reverse
[14:04] <mborzecki> and now travis seems to be slow to start spread jobs https://travis-ci.org/snapcore/snapd/builds/477815742?utm_source=github_status&utm_medium=notification heh
[14:05] <mvo> mborzecki: yeah, quite a bit of delay in spread right now :/
[14:06] <mvo> (well travis to be fair)
[14:15] <Chipaca> zyga: https://forum.snapcraft.io/t/tried-to-install-quelea-presentation-software-from-chrome-linux-beta/9247?u=chipaca dunno if you're the right person to answer here but ogra seems to think so :)
[14:16] <ogra> Chipaca, well, sorry ... zyga already told  me he has no idea about chromeos support ... i didnt forward that to the forum post
[14:17] <ogra> but yeah, zyga being the "foreign distro ambassador" in the team, i thought he might know :)
[14:17] <zyga> I don't have a chromebook anymore
[14:17] <zyga> and AFAIK only some recent chromebooks can run lxd
[14:17] <zyga> and thus run snaps
[14:17] <zyga> but I have 0 knowledge about how that works
[14:18] <zyga> or what's the nesting story
[14:18] <ogra> even then i bet it is doubtful becase of lacking kernel features
[14:20] <zyga> dunno :)
[14:21] <zyga> jdstrand: replied on the permission topic
[14:21] <zyga> jdstrand: it's really about go vs c logic
[14:21] <zyga> jdstrand: one thing we might do is to open the fd while still in C
[14:21] <zyga> jdstrand: but I don't really think that warrants the extra logic today
[14:22] <Chipaca> zyga: even replying "I don't know and this is why I don't know" would be helpful
[14:24] <zyga> mvo: so based on what you said, can we merge https://github.com/snapcore/snapd/pull/6294 now?
[14:24] <mup> PR #6294: packaging/ubuntu: build with golang 1.10 <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/6294>
[14:26] <mvo> zyga: yeah, maybe early next week but in theory we could do so *now*
[14:27] <Chipaca> zyga: missing on that PR: move the travis unit tests to run with 1.9 instead of 1.6
[14:27] <Chipaca> zyga: I can push that change
[14:28] <zyga> Chipaca: oooh, indeed
[14:28] <zyga> Chipaca: if you can please do
[14:36] <mborzecki> can't wait to get rid of the 1.6 gofmt wrappers that I have now
[14:38] <Chipaca> mborzecki: next you'll be wanting generics or whatever they're getting called
[14:38] <mborzecki> haha :P
[14:39] <mborzecki> Chipaca: wouldn't mind pattern matching in go 2 tho
[14:39] <Chipaca> are we getting pattern matching as well? i missed that bit
[14:39]  * cachio lunch
[14:40] <pedronis> I think the improvements to error wrapping are probably the most interesting bit for us
[14:40] <mborzecki> Chipaca: afaik no
[14:40] <mborzecki> pedronis: we could use github.com/pkg/errors for this now
[14:40] <pedronis> mborzecki: it's not about our errors usually
[14:41] <pedronis> more about the std lib ones
[14:41] <pedronis> especially networking ones
[14:41] <mborzecki> mhm
[14:41] <pedronis> mborzecki: I'm talking about the contorsions our retry code does for example
[14:41] <mborzecki> btw. did they sort out the context for io interfaces?
[14:47] <mborzecki> mvo: about jq https://paste.ubuntu.com/p/YGPvF65wFJ/
[14:47] <mvo> mborzecki: hm, interessting
[14:49] <mborzecki> mvo: changes: https://paste.ubuntu.com/p/GphB7jj8Gd/ up to change 8 it's all prepare, change 9 is caused by prepare section of the cloud-init test
[14:49] <zyga> mvo, mborzecki we install jq in prepare
[14:49] <mborzecki> zyga: but it's removed later on
[14:49] <zyga> mborzecki: grep for jq in the tests/lib section
[14:50] <zyga> disable_refreshes needs it
[14:50] <zyga> hmm
[14:50] <zyga> i see now
[14:50] <mborzecki> zyga: right, but it's removed just below
[14:53] <zyga> indeed
[14:53] <zyga> no idea now
[14:55] <pedronis> mborzecki: mvo: fwiw I just double checked, there is no jq in core18 itself
[14:55] <pedronis> at least not in stable
[14:56] <mborzecki> pedronis: not in edge either
[14:56] <mborzecki> waiting for vanilla core18/16 instances to boot and will check there
[15:07] <mborzecki> hm no clue
[15:07] <mup> PR snapcraft#2435 opened: Appstream desktop <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2435>
[15:13] <mup> PR snapcraft#2436 opened: snap: add build-package for xml <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2436>
[15:20] <zyga> mborzecki, mvo: can I please get a review for https://github.com/snapcore/snapd/pull/6353
[15:20] <zyga> it will let me propose the rest once merfed
[15:20] <mup> PR #6353: cmd/snap-update-ns: move existing code around, renaming some functions <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6353>
[15:27] <pedronis> degville: I posted some comments to the doc update PR
[15:27] <pedronis> thanks for working on that
[15:28] <degville> pedronis: no problem - thanks, just looking at the comments now.
[15:28] <pedronis> mvo: you probably want to give it a pass too
[15:33] <plars> ogra: hi! Do you think there's any chance the pi core images could ever work booting from USB (at least on pi3b+)? I know they don't currently, and I saw the previous discussion about this with a hacked uEnv.txt that would work temporarily, but I was looking for something that wouldn't break once kernels get updated over time
[15:34] <pedronis> Chipaca: did you see cachio answer here? #6121
[15:34] <mup> PR #6121: tests: new test for snapshots with more than 1 user <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6121>
[15:35] <Chipaca> pedronis: I'll look now
[15:35] <Chipaca> pedronis: meanwhile, am I holding it wrong, in https://pastebin.ubuntu.com/p/dtZJJhshkS/ ?
[15:36] <Chipaca> pedronis: the coutner task isn't run and I'm wondering why
[15:37] <mvo> pedronis: yeah, I have a look in a wee bit, just one more 2.37 push
[15:37] <mup> PR snapd#6121 closed: tests: new test for snapshots with more than 1 user <Created by sergiocazzolato> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6121>
[15:37] <pedronis> Chipaca: you do only one Ensure, why should it run?
[15:37] <pedronis> anyway doing just one Ensure is what you probably
[15:37] <pedronis> and just check the task is there, not run
[15:38] <pedronis> s/probably/probably want/
[15:38] <Chipaca> pedronis: rerefresh does a 		st.EnsureBefore(0)
[15:38] <pedronis> Chipaca: that's relevant only if run Loop
[15:38] <pedronis> if you run Loop
[15:38] <pedronis> or Settle
[15:38] <pedronis> indeed usually it explodes
[15:39] <pedronis> if you don't do one of those
[15:39] <pedronis> though if usually mock it because of that
[15:39] <Chipaca> I guess I'll look at the tasks then :-)
[15:39] <pedronis> Chipaca: yes
[15:39] <pedronis> Chipaca: the auto-connect tests in ifacestate are probably a good inspiration
[15:39] <pedronis> I think
[15:39] <pedronis> in case
[15:39] <pedronis> (similar kind of task that creates more tasks)
[15:42] <ogra> plars, this should work since ages (if you turned usb booting on in the firmware)
[15:44] <plars> ogra: I didn't think anything should be needed on b+, but it doesn't work for me there. What else would I need to do? It does work to boot a usb stick with something like raspbian, but on core 18 and 16 images it does not. So I know the device is capable of it
[15:45] <ogra> well, thats a bug then ... it should definitely work on core 16 ... i forgot when abeato did the PR for USB boot, but thats surely already a year in there
[15:48] <abeato> ogra, yes, it has been there for a while. I tested it with an rpi3, no idea if something has changed in the b+
[15:48] <ogra> shouldnt
[15:48] <zyga> break now, feeling sleepy
[15:49] <ogra> as long as you did the HW switching to enable USB it should just work ... if not, thats a bug
[15:49] <plars> abeato: and you didn't need anything on an sd card to make it work? Just the core image written to a usb stick?
[15:49] <plars> I will double-check with my b+ and try on the earlier pi3 also
[15:49] <ogra> plars, right, thats the purpose of the HW hack
[15:50] <abeato> plars, yes, the raw image on the stick should work
[15:50] <ogra> USB becomes a normal boot device permanenently once you toggled it ... and you cant revert that
[15:50] <plars> neato, if that works, I have another possibility for getting some better provisioning working
[15:51] <ogra> plars, let me know if it doesnt, then we can research
[15:51] <plars> usb toggle it how? with program_usb_boot_mode=1 in config.txt?
[15:52] <ogra> yes, and then turning that off again after one boot ... it burns a fuse on the board and makes it permanently boot from USB alongside SD
[15:52] <abeato> plars, to force the toggle (HW fuses I guess) I had to install raspbian and follow the intructions that are around
[15:55] <ogra> plars, thats the code that should make it work: https://github.com/snapcore/pi-gadget/blob/master/uboot3.patch#L19
[15:56] <plars> ok
[15:57] <ogra> (oh, thats the universal gadget that works on all pi's ... the pi3 specific one (which core16 still uses i think) is at https://github.com/snapcore/pi3-gadget/blob/master/uboot.patch#L21 )
[16:08] <thresh> hmm the visual distinction in the store metrics page isnt very good: http://thre.sh/stuff/vlc-stats-snap-weird.png
[16:12] <pstolowski> te
[16:12] <pstolowski> re
[16:24] <pedronis> mvo: did you see my question about 18-cm3 vs 18-pi3 ?
[16:31] <mvo> pedronis: let me check
[16:32] <mvo> pedronis: replied
[16:37] <pedronis> mborzecki: it's a bit strange to add /connections end point that return something that has just top-level  plugs and slots
[16:42] <mup> PR snapd#6354 opened: overlord: drop old v1 store api support from managers test <Simple 😃> <Created by chipaca> <https://github.com/snapcore/snapd/pull/6354>
[16:42] <Chipaca> ^ i'm rebasing rerefresh on this as it simplifies the added complexity of epochs in the managers test
[16:43] <pedronis> mborzecki: we should brainstorm a bit
[17:06] <mvo> 6351 and 6342 need a second review
[17:06]  * mvo dinner
[17:19] <pedronis> mvo: #6343 is green, you might want to re-look tough because it has changed a bit
[17:19] <mup> PR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>
[17:24] <pedronis> mvo: youd didn't actually vote on #6342
[17:24] <mup> PR #6342: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <https://github.com/snapcore/snapd/pull/6342>
[17:30] <pedronis> degville: there is still a place that needs s/-cm3/-pi3/, left a comment
[17:31] <degville> pedronis: ah, got it. thanks - sorry I missed it.
[17:32] <pedronis> Chipaca: +1, thank you
[17:35] <zyga> mvo: I pushed more to https://github.com/snapcore/snapd/pull/6342#pullrequestreview-191328298
[17:35] <mup> PR #6342: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <https://github.com/snapcore/snapd/pull/6342>
[17:36] <zyga> https://github.com/snapcore/base-18/issues needs gardening
[17:36] <zyga> seems like we never touched the set of issues I made after we started working on core18
[17:36] <zyga> https://github.com/snapcore/snapd/pull/6349 needs a 2nd review
[17:36] <mup> PR #6349: cmd/snap-update-ns: move XDG code to dedicated file <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6349>
[17:37] <zyga> https://github.com/snapcore/snapd/pull/6350 also needs a 2nd review
[17:37] <mup> PR #6350: cmd/snap-confine: don't preemptively create .mnt files <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6350>
[17:55] <mup> PR snapd#6354 closed: overlord: drop old v1 store api support from managers test <Simple 😃> <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6354>
[18:10] <mvo> pedronis: thanks, re-reviewed and also updated the tests PR
[18:10] <mvo> zyga: thanks for the extra grep and fixing!
[18:10] <zyga> :)
[18:39] <mborzecki> pedronis: let's meet in the morning, i tried to reuse much of the code that was there, but there's definitely room for improvements
[18:42] <zyga> mvo: +1 to merge https://github.com/snapcore/snapd/pull/6294 now?
[18:42] <mup> PR #6294: packaging/ubuntu: build with golang 1.10 <Core18> <Created by zyga> <https://github.com/snapcore/snapd/pull/6294>
[18:43] <mvo> zyga: if it helps you now then yes, otherwise I would prefer monday
[18:47] <zyga> mvo: monday then :)
[18:47] <zyga> mvo: if you have a moment I would love to land https://github.com/snapcore/snapd/pull/6353 as I can then propose the refactoring
[18:47] <cachio> mvo, do you know when sru will be ready?
[18:47] <mup> PR #6353: cmd/snap-update-ns: move existing code around, renaming some functions <Per-user mount ns  🐎> <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6353>
[18:47] <cachio> mvo, can I help?
[18:50] <mvo> cachio: probably not today :( still waiting for two PRs to run through travis
[18:50] <mvo> cachio: so you can relax and work on something else, no need to wait for this
[18:51] <cachio> mvo, ok
[18:51] <cachio> thank
[18:51] <pedronis> mvo: we can merge 6343 then, right?
[18:52] <mvo> pedronis: yes, I can have a second look but yes, thats fine, I will cherry pick
[18:53] <pedronis> mvo: I let you merge it
[18:53] <pedronis> I approved the tests one
[18:54] <mvo> pedronis: you had one question (exit 0 vs exit 1) in there, should we do this via a follwup?
[18:54] <pedronis> mvo: where?
[18:55] <mvo> pedronis: https://github.com/snapcore/snapd/pull/6343/files#r246737708
[18:55] <mup> PR #6343: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6343>
[18:55] <pedronis> mvo: it was addressed, it's just github confused
[18:55] <mvo> pedronis: ok
[18:55] <pedronis> because the line I commented on is still there
[18:56] <pedronis> mvo: see line 20-  in the test
[18:56] <mvo> pedronis: +1
[19:11] <mup> PR snapcraft#2436 closed: snap: add build-package for xml <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2436>
[19:55] <mup> PR snapd#6342 closed: use major() and minor() in <sys/sysmacros.h> instead of MAJOR and MINOR… <Created by timchen119> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6342>
[19:55] <mup> PR snapd#6351 closed: tests: review/fix the autopkgtest failures in disco <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6351>
[19:58] <mup> PR snapd#6343 closed: overlord/configstate/configcore: support - and _ in cloud init field names <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6343>
[20:06] <mup> PR snapd#6355 opened: release: 2.37~pre1 <Created by mvo5> <https://github.com/snapcore/snapd/pull/6355>
[20:27] <teward> is there someone who can field a concern about snapcraft store, malware, security, and privacy?
[20:27] <teward> off-channel.
[21:23] <popey> teward: wassup?
[21:23] <teward> popey: PM?
[21:23] <popey> sure